Title: [291560] trunk/Tools
- Revision
- 291560
- Author
- jbed...@apple.com
- Date
- 2022-03-21 09:57:10 -0700 (Mon, 21 Mar 2022)
Log Message
[Merge-Queue] Support multiple reviewers names
https://bugs.webkit.org/show_bug.cgi?id=238095
<rdar://problem/90503503>
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(ApplyPatch.start): Only apply the first reviewer name.
(ValidateCommiterAndReviewer.start): Support a list of reviewers.
Canonical link: https://commits.webkit.org/248662@main
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (291559 => 291560)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-03-21 16:29:00 UTC (rev 291559)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-03-21 16:57:10 UTC (rev 291560)
@@ -722,9 +722,9 @@
shell.ShellCommand.start(self)
return None
- reviewer_name = self.getProperty('reviewer_full_name', '')
- if reviewer_name:
- self.command.extend(['--reviewer', reviewer_name])
+ reviewers_names = self.getProperty('reviewers_full_names', [])
+ if reviewers_names:
+ self.command.extend(['--reviewer', reviewers_names[0]])
d = self.downloadFileContentToWorker('.buildbot-diff', patch)
d.addCallback(lambda res: shell.ShellCommand.start(self))
@@ -1516,7 +1516,7 @@
self.finished(SUCCESS)
return None
- self.setProperty('reviewer_full_name', self.full_name_from_email(reviewer))
+ self.setProperty('reviewers_full_names', [self.full_name_from_email(reviewer)])
if not self.is_reviewer(reviewer):
self.fail_build(reviewer, 'reviewer')
return None
Modified: trunk/Tools/ChangeLog (291559 => 291560)
--- trunk/Tools/ChangeLog 2022-03-21 16:29:00 UTC (rev 291559)
+++ trunk/Tools/ChangeLog 2022-03-21 16:57:10 UTC (rev 291560)
@@ -1,3 +1,15 @@
+2022-03-18 Jonathan Bedard <jbed...@apple.com>
+
+ [Merge-Queue] Support multiple reviewers names
+ https://bugs.webkit.org/show_bug.cgi?id=238095
+ <rdar://problem/90503503>
+
+ Reviewed by Aakash Jain.
+
+ * CISupport/ews-build/steps.py:
+ (ApplyPatch.start): Only apply the first reviewer name.
+ (ValidateCommiterAndReviewer.start): Support a list of reviewers.
+
2022-03-21 Diego Pino Garcia <dp...@igalia.com>
Unreviewed, fix Debian Stable build after r291543
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
