Title: [291755] trunk/Source/_javascript_Core
Revision
291755
Author
cdu...@apple.com
Date
2022-03-23 11:37:21 -0700 (Wed, 23 Mar 2022)

Log Message

Avoid unnecessary String constructor under FunctionExecutable::toStringSlow()
https://bugs.webkit.org/show_bug.cgi?id=238263

Reviewed by Darin Adler.

* runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::toStringSlow):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (291754 => 291755)


--- trunk/Source/_javascript_Core/ChangeLog	2022-03-23 18:31:58 UTC (rev 291754)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-03-23 18:37:21 UTC (rev 291755)
@@ -1,3 +1,13 @@
+2022-03-23  Chris Dumez  <cdu...@apple.com>
+
+        Avoid unnecessary String constructor under FunctionExecutable::toStringSlow()
+        https://bugs.webkit.org/show_bug.cgi?id=238263
+
+        Reviewed by Darin Adler.
+
+        * runtime/FunctionExecutable.cpp:
+        (JSC::FunctionExecutable::toStringSlow):
+
 2022-03-23  Yusuke Suzuki  <ysuz...@apple.com>
 
         Unreviewed, fix DataIC's slowPathJump handling

Modified: trunk/Source/_javascript_Core/runtime/FunctionExecutable.cpp (291754 => 291755)


--- trunk/Source/_javascript_Core/runtime/FunctionExecutable.cpp	2022-03-23 18:31:58 UTC (rev 291754)
+++ trunk/Source/_javascript_Core/runtime/FunctionExecutable.cpp	2022-03-23 18:37:21 UTC (rev 291755)
@@ -141,7 +141,7 @@
     if (isClass())
         return cache(jsString(vm, classSource().view().toString()));
 
-    String functionHeader;
+    ASCIILiteral functionHeader = ""_s;
     switch (parseMode()) {
     case SourceParseMode::GeneratorWrapperFunctionMode:
     case SourceParseMode::GeneratorWrapperMethodMode:
@@ -164,7 +164,6 @@
 
     case SourceParseMode::ArrowFunctionMode:
     case SourceParseMode::ClassFieldInitializerMode:
-        functionHeader = "";
         break;
 
     case SourceParseMode::AsyncFunctionMode:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to