Title: [292230] trunk/Source/WebKit
- Revision
- 292230
- Author
- cdu...@apple.com
- Date
- 2022-04-01 12:30:08 -0700 (Fri, 01 Apr 2022)
Log Message
REGRESSION(r292197): 3 TestWebKitAPI.ContentRuleList API tests are constant failures/timeout
https://bugs.webkit.org/show_bug.cgi?id=238678
<rdar://91173297>
Unreviewed, in r292197, I made a last minute mistake when applying some of Darin's review comments.
I converted a few calls to `NSURL.absoluteURL.fileSystemRepresentation` to
`NSURL.absoluteString` instead of `NSURL.absoluteURL.path`. As a result, the file://
prefix was still present and some characters may still be URL-encoded.
No new tests, covered by existing API tests failing on the bots.
* UIProcess/API/Cocoa/WKContentRuleListStore.mm:
(+[WKContentRuleListStore storeWithURL:]):
(+[WKContentRuleListStore storeWithURLAndLegacyFilename:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (292229 => 292230)
--- trunk/Source/WebKit/ChangeLog 2022-04-01 19:26:41 UTC (rev 292229)
+++ trunk/Source/WebKit/ChangeLog 2022-04-01 19:30:08 UTC (rev 292230)
@@ -1,3 +1,20 @@
+2022-04-01 Chris Dumez <cdu...@apple.com>
+
+ REGRESSION(r292197): 3 TestWebKitAPI.ContentRuleList API tests are constant failures/timeout
+ https://bugs.webkit.org/show_bug.cgi?id=238678
+ <rdar://91173297>
+
+ Unreviewed, in r292197, I made a last minute mistake when applying some of Darin's review comments.
+ I converted a few calls to `NSURL.absoluteURL.fileSystemRepresentation` to
+ `NSURL.absoluteString` instead of `NSURL.absoluteURL.path`. As a result, the file://
+ prefix was still present and some characters may still be URL-encoded.
+
+ No new tests, covered by existing API tests failing on the bots.
+
+ * UIProcess/API/Cocoa/WKContentRuleListStore.mm:
+ (+[WKContentRuleListStore storeWithURL:]):
+ (+[WKContentRuleListStore storeWithURLAndLegacyFilename:]):
+
2022-04-01 Zan Dobersek <zdober...@igalia.com>
[Linux] Implement IPC::Semaphore
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm (292229 => 292230)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm 2022-04-01 19:26:41 UTC (rev 292229)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentRuleListStore.mm 2022-04-01 19:30:08 UTC (rev 292230)
@@ -79,7 +79,7 @@
+ (instancetype)storeWithURL:(NSURL *)url
{
#if ENABLE(CONTENT_EXTENSIONS)
- return wrapper(API::ContentRuleListStore::storeWithPath(url.absoluteString));
+ return wrapper(API::ContentRuleListStore::storeWithPath(url.absoluteURL.path));
#else
return nil;
#endif
@@ -194,7 +194,7 @@
+ (instancetype)storeWithURLAndLegacyFilename:(NSURL *)url
{
#if ENABLE(CONTENT_EXTENSIONS)
- return wrapper(API::ContentRuleListStore::storeWithPath(url.absoluteString));
+ return wrapper(API::ContentRuleListStore::storeWithPath(url.absoluteURL.path));
#else
return nil;
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
