Diff
Modified: trunk/Source/WTF/ChangeLog (292351 => 292352)
--- trunk/Source/WTF/ChangeLog 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WTF/ChangeLog 2022-04-04 22:22:34 UTC (rev 292352)
@@ -1,5 +1,17 @@
2022-04-04 Tim Horton <timothy_hor...@apple.com>
+ Remove the incremental_pdf system feature flag
+ https://bugs.webkit.org/show_bug.cgi?id=238754
+
+ Reviewed by Wenson Hsieh.
+
+ * Scripts/Preferences/WebPreferences.yaml:
+ * Scripts/Preferences/WebPreferencesExperimental.yaml:
+ Demote incremental PDF rendering from a developer-exposed experimental feature
+ to a standard web preference now that it's been on and shipping for a while.
+
+2022-04-04 Tim Horton <timothy_hor...@apple.com>
+
Remove the 'RB_full_manage_WK_jetsam' system feature flag and simplify adjacent logic
https://bugs.webkit.org/show_bug.cgi?id=238760
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (292351 => 292352)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-04-04 22:22:34 UTC (rev 292352)
@@ -929,6 +929,18 @@
WebCore:
default: false
+IncrementalPDFLoadingEnabled:
+ type: bool
+ condition: HAVE(INCREMENTAL_PDF_APIS)
+ webcoreBinding: RuntimeEnabledFeatures
+ defaultValue:
+ WebKitLegacy:
+ "PLATFORM(MAC)": true
+ default: false
+ WebKit:
+ "PLATFORM(MAC)": true
+ default: false
+
IncrementalRenderingSuppressionTimeout:
type: double
webKitLegacyPreferenceKey: WebKitIncrementalRenderingSuppressionTimeoutInSeconds
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (292351 => 292352)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-04-04 22:22:34 UTC (rev 292352)
@@ -672,18 +672,6 @@
WebCore:
default: false
-IncrementalPDFLoadingEnabled:
- type: bool
- humanReadableName: "Incremental PDF Loading"
- humanReadableDescription: "Enable Incremental PDF Loading on supported platforms"
- condition: HAVE(INCREMENTAL_PDF_APIS)
- webcoreBinding: RuntimeEnabledFeatures
- defaultValue:
- WebKitLegacy:
- default: WebKit::defaultIncrementalPDFEnabled()
- WebKit:
- default: WebKit::defaultIncrementalPDFEnabled()
-
InertAttributeEnabled:
type: bool
humanReadableName: "inert attribute"
Modified: trunk/Source/WebKit/ChangeLog (292351 => 292352)
--- trunk/Source/WebKit/ChangeLog 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKit/ChangeLog 2022-04-04 22:22:34 UTC (rev 292352)
@@ -1,5 +1,21 @@
2022-04-04 Tim Horton <timothy_hor...@apple.com>
+ Remove the incremental_pdf system feature flag
+ https://bugs.webkit.org/show_bug.cgi?id=238754
+
+ Reviewed by Wenson Hsieh.
+
+ * FeatureFlags/WebKit-appletvos.plist:
+ * FeatureFlags/WebKit-ios.plist:
+ * FeatureFlags/WebKit-macos.plist:
+ * FeatureFlags/WebKit-watchos.plist:
+ * Shared/WebPreferencesDefaultValues.cpp:
+ * Shared/WebPreferencesDefaultValues.h:
+ (WebKit::defaultIncrementalPDFEnabled): Deleted.
+ Remove the incremental_pdf system feature flag in favor of a traditional WebKit preference.
+
+2022-04-04 Tim Horton <timothy_hor...@apple.com>
+
Remove the 'RB_full_manage_WK_jetsam' system feature flag and simplify adjacent logic
https://bugs.webkit.org/show_bug.cgi?id=238760
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist (292351 => 292352)
--- trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist 2022-04-04 22:22:34 UTC (rev 292352)
@@ -47,11 +47,6 @@
<true/>
</dict>
</dict>
- <key>incremental_pdf</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
<key>sw_vp9_decoder_on_battery</key>
<dict>
<key>Enabled</key>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist (292351 => 292352)
--- trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist 2022-04-04 22:22:34 UTC (rev 292352)
@@ -47,11 +47,6 @@
<true/>
</dict>
</dict>
- <key>incremental_pdf</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
<key>sw_vp9_decoder_on_battery</key>
<dict>
<key>Enabled</key>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist (292351 => 292352)
--- trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist 2022-04-04 22:22:34 UTC (rev 292352)
@@ -47,11 +47,6 @@
<true/>
</dict>
</dict>
- <key>incremental_pdf</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
<key>sw_vp9_decoder_on_battery</key>
<dict>
<key>Enabled</key>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist (292351 => 292352)
--- trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist 2022-04-04 22:22:34 UTC (rev 292352)
@@ -47,11 +47,6 @@
<true/>
</dict>
</dict>
- <key>incremental_pdf</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
<key>sw_vp9_decoder_on_battery</key>
<dict>
<key>Enabled</key>
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (292351 => 292352)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2022-04-04 22:22:34 UTC (rev 292352)
@@ -274,19 +274,6 @@
#endif // ENABLE(WEB_RTC)
-#if HAVE(INCREMENTAL_PDF_APIS)
-bool defaultIncrementalPDFEnabled()
-{
-#if PLATFORM(MAC)
- bool defaultValue = true;
-#else
- bool defaultValue = false;
-#endif
-
- return isFeatureFlagEnabled("incremental_pdf", defaultValue);
-}
-#endif
-
#if ENABLE(WEBM_FORMAT_READER)
bool defaultWebMFormatReaderEnabled()
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (292351 => 292352)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2022-04-04 22:22:34 UTC (rev 292352)
@@ -85,10 +85,6 @@
bool defaultWebRTCCodecsInGPUProcess();
#endif
-#if HAVE(INCREMENTAL_PDF_APIS)
-bool defaultIncrementalPDFEnabled();
-#endif
-
#if ENABLE(WEBM_FORMAT_READER)
bool defaultWebMFormatReaderEnabled();
#endif
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (292351 => 292352)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2022-04-04 22:22:34 UTC (rev 292352)
@@ -1,3 +1,14 @@
+2022-04-04 Tim Horton <timothy_hor...@apple.com>
+
+ Remove the incremental_pdf system feature flag
+ https://bugs.webkit.org/show_bug.cgi?id=238754
+
+ Reviewed by Wenson Hsieh.
+
+ * WebView/WebPreferencesDefaultValues.mm:
+ * WebView/WebPreferencesDefaultValues.h:
+ (WebKit::defaultIncrementalPDFEnabled): Deleted.
+
2022-04-04 Elliott Williams <e...@apple.com>
[XCBuild] WebKitLegacy's "Migrated headers" script does not emit task information
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h (292351 => 292352)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2022-04-04 22:22:34 UTC (rev 292352)
@@ -39,10 +39,6 @@
bool isFeatureFlagEnabled(const char*, bool defaultValue = false);
#endif
-#if HAVE(INCREMENTAL_PDF_APIS)
-bool defaultIncrementalPDFEnabled();
-#endif
-
#if PLATFORM(IOS_FAMILY)
bool defaultAllowsInlineMediaPlayback();
bool defaultAllowsInlineMediaPlaybackAfterFullscreen();
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (292351 => 292352)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2022-04-04 22:08:44 UTC (rev 292351)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2022-04-04 22:22:34 UTC (rev 292352)
@@ -70,15 +70,6 @@
#endif
-#if HAVE(INCREMENTAL_PDF_APIS)
-
-bool defaultIncrementalPDFEnabled()
-{
- return isFeatureFlagEnabled("incremental_pdf", false);
-}
-
-#endif
-
#if PLATFORM(IOS_FAMILY)
bool defaultAllowsInlineMediaPlayback()
