Diff
Modified: trunk/Source/WTF/ChangeLog (292357 => 292358)
--- trunk/Source/WTF/ChangeLog 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WTF/ChangeLog 2022-04-05 00:34:32 UTC (rev 292358)
@@ -1,5 +1,16 @@
2022-04-04 Tim Horton <timothy_hor...@apple.com>
+ Remove VP8/9 and WebM-related system feature flags
+ https://bugs.webkit.org/show_bug.cgi?id=238757
+
+ Reviewed by Eric Carlson.
+
+ * Scripts/Preferences/WebPreferences.yaml:
+ * Scripts/Preferences/WebPreferencesExperimental.yaml:
+ Demote these to standard preferences, and stop using system feature flags to control their defaults.
+
+2022-04-04 Tim Horton <timothy_hor...@apple.com>
+
Remove the 'sw_vp9_decoder_on_battery' system feature flag
https://bugs.webkit.org/show_bug.cgi?id=238761
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (292357 => 292358)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-04-05 00:34:32 UTC (rev 292358)
@@ -2459,6 +2459,27 @@
WebCore:
default: false
+VP8DecoderEnabled:
+ type: bool
+ webcoreBinding: none
+ condition: ENABLE(VP9)
+ defaultValue:
+ WebKitLegacy:
+ default: true
+ WebKit:
+ default: true
+
+VP9DecoderEnabled:
+ type: bool
+ condition: ENABLE(VP9)
+ defaultValue:
+ WebCore:
+ default: false
+ WebKitLegacy:
+ default: true
+ WebKit:
+ default: true
+
VideoQualityIncludesDisplayCompositingEnabled:
type: bool
condition: ENABLE(VIDEO)
@@ -2556,6 +2577,25 @@
WebCore:
default: false
+WebMFormatReaderEnabled:
+ type: bool
+ webcoreBinding: RuntimeEnabledFeatures
+ condition: ENABLE(WEBM_FORMAT_READER)
+ defaultValue:
+ WebKit:
+ default: true
+
+# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
+WebMParserEnabled:
+ type: bool
+ webcoreBinding: RuntimeEnabledFeatures
+ condition: ENABLE(MEDIA_SOURCE)
+ defaultValue:
+ WebKitLegacy:
+ default: true
+ WebKit:
+ default: true
+
WebSecurityEnabled:
type: bool
inspectorOverride: true
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (292357 => 292358)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-04-05 00:34:32 UTC (rev 292358)
@@ -1490,31 +1490,6 @@
WebKit:
default: true
-VP8DecoderEnabled:
- type: bool
- humanReadableName: "VP8 decoder"
- humanReadableDescription: "Enable VP8 decoder"
- webcoreBinding: none
- condition: ENABLE(VP9)
- defaultValue:
- WebKitLegacy:
- default: WebKit::defaultVP8DecoderEnabled()
- WebKit:
- default: WebKit::defaultVP8DecoderEnabled()
-
-VP9DecoderEnabled:
- type: bool
- humanReadableName: "VP9 decoder"
- humanReadableDescription: "Enable VP9 decoder"
- condition: ENABLE(VP9)
- defaultValue:
- WebCore:
- default: false
- WebKitLegacy:
- default: WebKit::defaultVP9DecoderEnabled()
- WebKit:
- default: WebKit::defaultVP9DecoderEnabled()
-
VP9SWDecoderEnabledOnBattery:
type: bool
humanReadableName: "VP9 SW decoder on battery"
@@ -1694,29 +1669,6 @@
WebCore:
default: true
-WebMFormatReaderEnabled:
- type: bool
- webcoreBinding: RuntimeEnabledFeatures
- humanReadableName: "WebM format reader"
- humanReadableDescription: "Enable MediaToolbox format reader plug-in for WebM"
- condition: ENABLE(WEBM_FORMAT_READER)
- defaultValue:
- WebKit:
- default: WebKit::defaultWebMFormatReaderEnabled()
-
-# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
-WebMParserEnabled:
- type: bool
- webcoreBinding: RuntimeEnabledFeatures
- humanReadableName: "WebM MSE parser"
- humanReadableDescription: "Enable WebM MSE parser"
- condition: ENABLE(MEDIA_SOURCE)
- defaultValue:
- WebKitLegacy:
- default: WebKit::defaultWebMParserEnabled()
- WebKit:
- default: WebKit::defaultWebMParserEnabled()
-
WebRTCEncodedTransformEnabled:
type: bool
condition: ENABLE(WEB_RTC)
Modified: trunk/Source/WebKit/ChangeLog (292357 => 292358)
--- trunk/Source/WebKit/ChangeLog 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 00:34:32 UTC (rev 292358)
@@ -1,3 +1,21 @@
+2022-04-04 Tim Horton <timothy_hor...@apple.com>
+
+ Remove VP8/9 and WebM-related system feature flags
+ https://bugs.webkit.org/show_bug.cgi?id=238757
+
+ Reviewed by Eric Carlson.
+
+ * FeatureFlags/WebKit-appletvos.plist:
+ * FeatureFlags/WebKit-ios.plist:
+ * FeatureFlags/WebKit-macos.plist:
+ * FeatureFlags/WebKit-watchos.plist:
+ * Shared/WebPreferencesDefaultValues.cpp:
+ (WebKit::defaultWebMFormatReaderEnabled): Deleted.
+ (WebKit::defaultVP8DecoderEnabled): Deleted.
+ (WebKit::defaultVP9DecoderEnabled): Deleted.
+ (WebKit::defaultWebMParserEnabled): Deleted.
+ * Shared/WebPreferencesDefaultValues.h:
+
2022-04-04 Wenson Hsieh <wenson_hs...@apple.com>
[macOS] [WK2] Add plumbing to extract video frames in element fullscreen
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist (292357 => 292358)
--- trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist 2022-04-05 00:34:32 UTC (rev 292358)
@@ -42,25 +42,5 @@
<true/>
</dict>
</dict>
- <key>vp9_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>vp8_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_format_reader</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_parser</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist (292357 => 292358)
--- trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist 2022-04-05 00:34:32 UTC (rev 292358)
@@ -42,25 +42,5 @@
<true/>
</dict>
</dict>
- <key>vp9_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>vp8_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_format_reader</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_parser</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist (292357 => 292358)
--- trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist 2022-04-05 00:34:32 UTC (rev 292358)
@@ -42,30 +42,5 @@
<true/>
</dict>
</dict>
- <key>vp9_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>vp8_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_format_reader</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_parser</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_webaudio</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist (292357 => 292358)
--- trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist 2022-04-05 00:34:32 UTC (rev 292358)
@@ -42,25 +42,5 @@
<true/>
</dict>
</dict>
- <key>vp9_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>vp8_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_format_reader</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_parser</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (292357 => 292358)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2022-04-05 00:34:32 UTC (rev 292358)
@@ -245,44 +245,6 @@
#endif // ENABLE(WEB_RTC)
-#if ENABLE(WEBM_FORMAT_READER)
-
-bool defaultWebMFormatReaderEnabled()
-{
-#if PLATFORM(MAC)
- bool defaultValue = true;
-#else
- bool defaultValue = false;
-#endif
-
- return isFeatureFlagEnabled("webm_format_reader", defaultValue);
-}
-
-#endif // ENABLE(WEBM_FORMAT_READER)
-
-#if ENABLE(VP9)
-
-bool defaultVP8DecoderEnabled()
-{
- return isFeatureFlagEnabled("vp8_decoder", true);
-}
-
-bool defaultVP9DecoderEnabled()
-{
- return isFeatureFlagEnabled("vp9_decoder", true);
-}
-
-#endif // ENABLE(VP9)
-
-#if ENABLE(MEDIA_SOURCE)
-
-bool defaultWebMParserEnabled()
-{
- return isFeatureFlagEnabled("webm_parser", true);
-}
-
-#endif // ENABLE(MEDIA_SOURCE)
-
#if ENABLE(MEDIA_SESSION_COORDINATOR)
bool defaultMediaSessionCoordinatorEnabled()
{
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (292357 => 292358)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2022-04-05 00:34:32 UTC (rev 292358)
@@ -83,19 +83,6 @@
bool defaultWebRTCCodecsInGPUProcess();
#endif
-#if ENABLE(WEBM_FORMAT_READER)
-bool defaultWebMFormatReaderEnabled();
-#endif
-
-#if ENABLE(VP9)
-bool defaultVP8DecoderEnabled();
-bool defaultVP9DecoderEnabled();
-#endif
-
-#if ENABLE(MEDIA_SOURCE)
-bool defaultWebMParserEnabled();
-#endif
-
#if ENABLE(MEDIA_SOURCE) && PLATFORM(IOS_FAMILY)
bool defaultMediaSourceEnabled();
#endif
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (292357 => 292358)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2022-04-05 00:34:32 UTC (rev 292358)
@@ -1,5 +1,14 @@
2022-04-04 Tim Horton <timothy_hor...@apple.com>
+ Remove VP8/9 and WebM-related system feature flags
+ https://bugs.webkit.org/show_bug.cgi?id=238757
+
+ Reviewed by Eric Carlson.
+
+ * WebView/WebPreferencesDefaultValues.h:
+
+2022-04-04 Tim Horton <timothy_hor...@apple.com>
+
Remove the incremental_pdf system feature flag
https://bugs.webkit.org/show_bug.cgi?id=238754
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h (292357 => 292358)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h 2022-04-05 00:34:32 UTC (rev 292358)
@@ -74,17 +74,8 @@
bool defaultWheelEventGesturesBecomeNonBlocking();
#endif
-#if ENABLE(MEDIA_SOURCE)
-bool defaultWebMParserEnabled();
-#endif
-
#if ENABLE(MEDIA_SOURCE) && PLATFORM(IOS_FAMILY)
bool defaultMediaSourceEnabled();
#endif
-#if ENABLE(VP9)
-bool defaultVP8DecoderEnabled();
-bool defaultVP9DecoderEnabled();
-#endif
-
} // namespace WebKit
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (292357 => 292358)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2022-04-04 23:42:13 UTC (rev 292357)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm 2022-04-05 00:34:32 UTC (rev 292358)
@@ -267,27 +267,4 @@
#endif
-#if ENABLE(MEDIA_SOURCE)
-
-bool defaultWebMParserEnabled()
-{
- return isFeatureFlagEnabled("webm_parser", true);
-}
-
-#endif
-
-#if ENABLE(VP9)
-
-bool defaultVP8DecoderEnabled()
-{
- return isFeatureFlagEnabled("vp8_decoder", true);
-}
-
-bool defaultVP9DecoderEnabled()
-{
- return isFeatureFlagEnabled("vp9_decoder", true);
-}
-
-#endif // ENABLE(VP9)
-
} // namespace WebKit
