Title: [292541] trunk/Source/WebCore
- Revision
- 292541
- Author
- n...@apple.com
- Date
- 2022-04-07 10:06:19 -0700 (Thu, 07 Apr 2022)
Log Message
Remove redundant invalidateStyleForSubtree() calls
https://bugs.webkit.org/show_bug.cgi?id=238922
Reviewed by Antti Koivisto.
These calls were for :invalid/:valid validation, which now are invalidated using Style::PseudoClassChangeInvalidation.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::maxLengthAttributeChanged):
(WebCore::HTMLInputElement::minLengthAttributeChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (292540 => 292541)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 17:03:19 UTC (rev 292540)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07 17:06:19 UTC (rev 292541)
@@ -1,3 +1,16 @@
+2022-04-07 Tim Nguyen <n...@apple.com>
+
+ Remove redundant invalidateStyleForSubtree() calls
+ https://bugs.webkit.org/show_bug.cgi?id=238922
+
+ Reviewed by Antti Koivisto.
+
+ These calls were for :invalid/:valid validation, which now are invalidated using Style::PseudoClassChangeInvalidation.
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::maxLengthAttributeChanged):
+ (WebCore::HTMLInputElement::minLengthAttributeChanged):
+
2022-04-07 Chris Dumez <cdu...@apple.com>
Drop unused EditorClient::getAutoCorrectSuggestionForMisspelledWord()
Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (292540 => 292541)
--- trunk/Source/WebCore/html/HTMLInputElement.cpp 2022-04-07 17:03:19 UTC (rev 292540)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2022-04-07 17:06:19 UTC (rev 292541)
@@ -1911,8 +1911,6 @@
if (oldEffectiveMaxLength != effectiveMaxLength())
updateValueIfNeeded();
- // FIXME: Do we really need to do this if the effective maxLength has not changed?
- invalidateStyleForSubtree();
updateValidity();
}
@@ -1923,8 +1921,6 @@
if (oldMinLength != minLength())
updateValueIfNeeded();
- // FIXME: Do we really need to do this if the effective minLength has not changed?
- invalidateStyleForSubtree();
updateValidity();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
