Title: [292966] trunk/Tools
Revision
292966
Author
jbed...@apple.com
Date
2022-04-18 13:25:01 -0700 (Mon, 18 Apr 2022)

Log Message

[ews.webkit.org] Reduce status updates
https://bugs.webkit.org/show_bug.cgi?id=239414
<rdar://problem/91839873>

Reviewed by Aakash Jain.

We're starting to bump against our API limits, many very short steps report
their status, only to be imiediately overwritten. Skip step started updates.

* Tools/CISupport/ews-build/events.py:
(Events.stepStarted):

Canonical link: https://commits.webkit.org/249731@main

Modified Paths

Diff

Modified: trunk/Tools/CISupport/ews-build/events.py (292965 => 292966)


--- trunk/Tools/CISupport/ews-build/events.py	2022-04-18 19:49:44 UTC (rev 292965)
+++ trunk/Tools/CISupport/ews-build/events.py	2022-04-18 20:25:01 UTC (rev 292966)
@@ -81,6 +81,18 @@
 
     EVENT_SERVER_ENDPOINT = 'https://ews.webkit{}.org/results/'.format(custom_suffix).encode()
     MAX_GITHUB_DESCRIPTION = 140
+    SHORT_STEPS = (
+        'configure-build',
+        'validate-change',
+        'configuration',
+        'clean-up-git-repo',
+        'fetch-branch-references',
+        'show-identifier',
+        'update-working-directory',
+        'apply-patch',
+        'kill-old-processes',
+        'set-build-summary',
+    )
 
     def __init__(self, master_hostname, type_prefix='', name='Events'):
         """
@@ -260,7 +272,7 @@
             build['properties'] = yield self.master.db.builds.getBuildProperties(step.get('buildid'))
 
         # We need to force the defered properties to resolve
-        if build['properties'].get('github.number'):
+        if build['properties'].get('github.number') and build.get('step') not in self.SHORT_STEPS:
             self.stepStartedGitHub(build, state_string)
 
         data = {

Modified: trunk/Tools/ChangeLog (292965 => 292966)


--- trunk/Tools/ChangeLog	2022-04-18 19:49:44 UTC (rev 292965)
+++ trunk/Tools/ChangeLog	2022-04-18 20:25:01 UTC (rev 292966)
@@ -1,3 +1,17 @@
+2022-04-15  Jonathan Bedard  <jbed...@apple.com>
+
+        [ews.webkit.org] Reduce status updates
+        https://bugs.webkit.org/show_bug.cgi?id=239414
+        <rdar://problem/91839873>
+
+        Reviewed by Aakash Jain.
+
+        We're starting to bump against our API limits, many very short steps report
+        their status, only to be imiediately overwritten. Skip step started updates.
+
+        * CISupport/ews-build/events.py:
+        (Events.stepStarted):
+
 2022-04-15  Justin Michaud  <justin_mich...@apple.com>
 
         [PGO] Fix build on intel machines
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to