Title: [293322] trunk
Revision
293322
Author
z...@igalia.com
Date
2022-04-25 06:06:15 -0700 (Mon, 25 Apr 2022)

Log Message

UA stylesheet should include table { text-indent: initial } to conform with HTML standard
https://bugs.webkit.org/show_bug.cgi?id=201297

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

* web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
* web-platform-tests/html/rendering/non-replaced-elements/tables/table-ua-stylesheet-expected.txt:

Source/WebCore:

As per [1], text-indent for table should be initial.
[1] https://html.spec.whatwg.org/multipage/rendering.html#tables-2

* css/html.css:
(table):

LayoutTests:

* platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (293321 => 293322)


--- trunk/LayoutTests/ChangeLog	2022-04-25 12:56:13 UTC (rev 293321)
+++ trunk/LayoutTests/ChangeLog	2022-04-25 13:06:15 UTC (rev 293322)
@@ -1,3 +1,12 @@
+2022-04-25  Ziran Sun  <z...@igalia.com>
+
+        UA stylesheet should include table { text-indent: initial } to conform with HTML standard
+        https://bugs.webkit.org/show_bug.cgi?id=201297
+
+        Reviewed by Tim Nguyen.
+
+        * platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
+
 2022-04-25  Kimmo Kinnunen  <kkinnu...@apple.com>
 
         REGRESSION (249585@main): TestWebKitAPI.IPCTestingAPI.CanReceiveIPCSemaphore is timing out

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293321 => 293322)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-04-25 12:56:13 UTC (rev 293321)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-04-25 13:06:15 UTC (rev 293322)
@@ -1,3 +1,13 @@
+2022-04-25  Ziran Sun  <z...@igalia.com>
+
+        UA stylesheet should include table { text-indent: initial } to conform with HTML standard
+        https://bugs.webkit.org/show_bug.cgi?id=201297
+
+        Reviewed by Tim Nguyen.
+
+        * web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
+        * web-platform-tests/html/rendering/non-replaced-elements/tables/table-ua-stylesheet-expected.txt:
+
 2022-04-24  Youenn Fablet  <you...@apple.com>
 
         TextTrackLoader should use SameOrigin mode by default

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt (293321 => 293322)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt	2022-04-25 12:56:13 UTC (rev 293321)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt	2022-04-25 13:06:15 UTC (rev 293322)
@@ -270,7 +270,7 @@
 PASS <table><tbody><tr><td> - word-spacing
 PASS <table><tbody><tr><td> - line-height
 PASS <table><tbody><tr><td> - text-transform
-FAIL <table><tbody><tr><td> - text-indent assert_equals: expected "0px" but got "5px"
+PASS <table><tbody><tr><td> - text-indent
 PASS <table><tbody><tr><td> - text-shadow
 PASS <table><tbody><tr><td> - text-align
 PASS <table><tbody><tr><td> - display
@@ -279,7 +279,7 @@
 PASS <tbody><tr><td> (in <table>) - word-spacing
 PASS <tbody><tr><td> (in <table>) - line-height
 PASS <tbody><tr><td> (in <table>) - text-transform
-FAIL <tbody><tr><td> (in <table>) - text-indent assert_equals: expected "0px" but got "5px"
+PASS <tbody><tr><td> (in <table>) - text-indent
 PASS <tbody><tr><td> (in <table>) - text-shadow
 PASS <tbody><tr><td> (in <table>) - text-align
 PASS <tbody><tr><td> (in <table>) - display
@@ -288,7 +288,7 @@
 PASS <tr><td> (in <table><tbody>) - word-spacing
 PASS <tr><td> (in <table><tbody>) - line-height
 PASS <tr><td> (in <table><tbody>) - text-transform
-FAIL <tr><td> (in <table><tbody>) - text-indent assert_equals: expected "0px" but got "5px"
+PASS <tr><td> (in <table><tbody>) - text-indent
 PASS <tr><td> (in <table><tbody>) - text-shadow
 PASS <tr><td> (in <table><tbody>) - text-align
 PASS <tr><td> (in <table><tbody>) - display
@@ -297,7 +297,7 @@
 PASS <td> (in <table><tbody><tr>) - word-spacing
 PASS <td> (in <table><tbody><tr>) - line-height
 PASS <td> (in <table><tbody><tr>) - text-transform
-FAIL <td> (in <table><tbody><tr>) - text-indent assert_equals: expected "0px" but got "5px"
+PASS <td> (in <table><tbody><tr>) - text-indent
 PASS <td> (in <table><tbody><tr>) - text-shadow
 PASS <td> (in <table><tbody><tr>) - text-align
 PASS <td> (in <table><tbody><tr>) - display

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-ua-stylesheet-expected.txt (293321 => 293322)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-ua-stylesheet-expected.txt	2022-04-25 12:56:13 UTC (rev 293321)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-ua-stylesheet-expected.txt	2022-04-25 13:06:15 UTC (rev 293322)
@@ -3,5 +3,5 @@
 FAIL Computed 'box-sizing' on table should match html spec assert_equals: expected "border-box" but got "content-box"
 PASS Computed 'border-spacing' on table should match html spec
 PASS Computed 'border-collapse' on table should match html spec
-FAIL Computed 'text-indent' on table should match html spec assert_equals: expected "0px" but got "100px"
+PASS Computed 'text-indent' on table should match html spec
 

Modified: trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt (293321 => 293322)


--- trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt	2022-04-25 12:56:13 UTC (rev 293321)
+++ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt	2022-04-25 13:06:15 UTC (rev 293322)
@@ -270,7 +270,7 @@
 PASS <table><tbody><tr><td> - word-spacing
 PASS <table><tbody><tr><td> - line-height
 PASS <table><tbody><tr><td> - text-transform
-FAIL <table><tbody><tr><td> - text-indent assert_equals: expected "0px" but got "5px"
+PASS <table><tbody><tr><td> - text-indent
 PASS <table><tbody><tr><td> - text-shadow
 PASS <table><tbody><tr><td> - text-align
 PASS <table><tbody><tr><td> - display
@@ -279,7 +279,7 @@
 PASS <tbody><tr><td> (in <table>) - word-spacing
 PASS <tbody><tr><td> (in <table>) - line-height
 PASS <tbody><tr><td> (in <table>) - text-transform
-FAIL <tbody><tr><td> (in <table>) - text-indent assert_equals: expected "0px" but got "5px"
+PASS <tbody><tr><td> (in <table>) - text-indent
 PASS <tbody><tr><td> (in <table>) - text-shadow
 PASS <tbody><tr><td> (in <table>) - text-align
 PASS <tbody><tr><td> (in <table>) - display
@@ -288,7 +288,7 @@
 PASS <tr><td> (in <table><tbody>) - word-spacing
 PASS <tr><td> (in <table><tbody>) - line-height
 PASS <tr><td> (in <table><tbody>) - text-transform
-FAIL <tr><td> (in <table><tbody>) - text-indent assert_equals: expected "0px" but got "5px"
+PASS <tr><td> (in <table><tbody>) - text-indent
 PASS <tr><td> (in <table><tbody>) - text-shadow
 PASS <tr><td> (in <table><tbody>) - text-align
 PASS <tr><td> (in <table><tbody>) - display
@@ -297,7 +297,7 @@
 PASS <td> (in <table><tbody><tr>) - word-spacing
 PASS <td> (in <table><tbody><tr>) - line-height
 PASS <td> (in <table><tbody><tr>) - text-transform
-FAIL <td> (in <table><tbody><tr>) - text-indent assert_equals: expected "0px" but got "5px"
+PASS <td> (in <table><tbody><tr>) - text-indent
 PASS <td> (in <table><tbody><tr>) - text-shadow
 PASS <td> (in <table><tbody><tr>) - text-align
 PASS <td> (in <table><tbody><tr>) - display

Modified: trunk/Source/WebCore/ChangeLog (293321 => 293322)


--- trunk/Source/WebCore/ChangeLog	2022-04-25 12:56:13 UTC (rev 293321)
+++ trunk/Source/WebCore/ChangeLog	2022-04-25 13:06:15 UTC (rev 293322)
@@ -1,3 +1,16 @@
+2022-04-25  Ziran Sun  <z...@igalia.com>
+
+        UA stylesheet should include table { text-indent: initial } to conform with HTML standard
+        https://bugs.webkit.org/show_bug.cgi?id=201297
+
+        Reviewed by Tim Nguyen.
+
+        As per [1], text-indent for table should be initial.
+        [1] https://html.spec.whatwg.org/multipage/rendering.html#tables-2
+
+        * css/html.css:
+        (table):
+
 2022-04-24  Philippe Normand  <ph...@igalia.com>
 
         [GStreamer] Disable new demuxers based on adaptivedemux2

Modified: trunk/Source/WebCore/css/html.css (293321 => 293322)


--- trunk/Source/WebCore/css/html.css	2022-04-25 12:56:13 UTC (rev 293321)
+++ trunk/Source/WebCore/css/html.css	2022-04-25 13:06:15 UTC (rev 293322)
@@ -222,6 +222,7 @@
     border-collapse: separate;
     border-spacing: 2px;
     border-color: gray;
+    text-indent: initial;
 }
 
 thead {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to