Title: [293348] trunk
Revision
293348
Author
ysuz...@apple.com
Date
2022-04-25 13:55:17 -0700 (Mon, 25 Apr 2022)

Log Message

[JSC] Enable change-array-by-copy
https://bugs.webkit.org/show_bug.cgi?id=239678

Reviewed by Saam Barati.

* Source/_javascript_Core/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/249964@main

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (293347 => 293348)


--- trunk/LayoutTests/ChangeLog	2022-04-25 20:52:15 UTC (rev 293347)
+++ trunk/LayoutTests/ChangeLog	2022-04-25 20:55:17 UTC (rev 293348)
@@ -1,3 +1,16 @@
+2022-04-22  Yusuke Suzuki  <ysuz...@apple.com>
+
+        [JSC] Enable change-array-by-copy
+        https://bugs.webkit.org/show_bug.cgi?id=239678
+
+        Reviewed by Saam Barati.
+
+        * inspector/model/remote-object-get-properties-expected.txt:
+        * js/Object-getOwnPropertyNames-expected.txt:
+        * js/array-unscopables-properties-expected.txt:
+        * js/script-tests/Object-getOwnPropertyNames.js:
+        * js/script-tests/array-unscopables-properties.js:
+
 2022-04-25  Chris Fleizach  <cfleiz...@apple.com>
 
         AX: Don't expose aria-roledescription value on "generic" elements (e.g. div and span) unless explicit role value is also defined

Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt (293347 => 293348)


--- trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt	2022-04-25 20:52:15 UTC (rev 293347)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties-expected.txt	2022-04-25 20:55:17 UTC (rev 293348)
@@ -88,6 +88,10 @@
     includes
     copyWithin
     at
+    toReversed
+    toSorted
+    toSpliced
+    with
     constructor
     Symbol(Symbol.iterator)
     Symbol(Symbol.unscopables)
@@ -144,6 +148,10 @@
     includes
     copyWithin
     at
+    toReversed
+    toSorted
+    toSpliced
+    with
     constructor
     Symbol(Symbol.iterator)
     Symbol(Symbol.unscopables)
@@ -185,6 +193,10 @@
     includes
     copyWithin
     at
+    toReversed
+    toSorted
+    toSpliced
+    with
     constructor
     Symbol(Symbol.iterator)
     Symbol(Symbol.unscopables)
@@ -226,6 +238,10 @@
     includes
     copyWithin
     at
+    toReversed
+    toSorted
+    toSpliced
+    with
     constructor
     Symbol(Symbol.iterator)
     Symbol(Symbol.unscopables)

Modified: trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt (293347 => 293348)


--- trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt	2022-04-25 20:52:15 UTC (rev 293347)
+++ trunk/LayoutTests/js/Object-getOwnPropertyNames-expected.txt	2022-04-25 20:55:17 UTC (rev 293348)
@@ -47,7 +47,7 @@
 PASS getSortedOwnPropertyNames(Function) is ['length', 'name', 'prototype']
 PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']
 PASS getSortedOwnPropertyNames(Array) is ['from', 'isArray', 'length', 'name', 'of', 'prototype']
-PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']
+PASS getSortedOwnPropertyNames(Array.prototype) is ['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toReversed', 'toSorted', 'toSpliced', 'toString', 'unshift', 'values', 'with']
 PASS getSortedOwnPropertyNames(String) is ['fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']
 PASS getSortedOwnPropertyNames(String.prototype) is ['anchor', 'at', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'matchAll', 'normalize', 'padEnd', 'padStart', 'repeat', 'replace', 'replaceAll', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimEnd', 'trimLeft', 'trimRight', 'trimStart', 'valueOf']
 PASS getSortedOwnPropertyNames(Boolean) is ['length', 'name', 'prototype']

Modified: trunk/LayoutTests/js/array-unscopables-properties-expected.txt (293347 => 293348)


--- trunk/LayoutTests/js/array-unscopables-properties-expected.txt	2022-04-25 20:52:15 UTC (rev 293347)
+++ trunk/LayoutTests/js/array-unscopables-properties-expected.txt	2022-04-25 20:55:17 UTC (rev 293348)
@@ -58,6 +58,18 @@
 PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "keys").writable is true
 PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "keys").enumerable is true
 PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "keys").configurable is true
+PASS Array.prototype[Symbol.unscopables]["toReversed"] is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toReversed").writable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toReversed").enumerable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toReversed").configurable is true
+PASS Array.prototype[Symbol.unscopables]["toSorted"] is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSorted").writable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSorted").enumerable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSorted").configurable is true
+PASS Array.prototype[Symbol.unscopables]["toSpliced"] is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSpliced").writable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSpliced").enumerable is true
+PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "toSpliced").configurable is true
 PASS Array.prototype[Symbol.unscopables]["values"] is true
 PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "values").writable is true
 PASS Object.getOwnPropertyDescriptor(Array.prototype[Symbol.unscopables], "values").enumerable is true

Modified: trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js (293347 => 293348)


--- trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js	2022-04-25 20:52:15 UTC (rev 293347)
+++ trunk/LayoutTests/js/script-tests/Object-getOwnPropertyNames.js	2022-04-25 20:55:17 UTC (rev 293348)
@@ -56,7 +56,7 @@
     "Function": "['length', 'name', 'prototype']",
     "Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString']",
     "Array": "['from', 'isArray', 'length', 'name', 'of', 'prototype']",
-    "Array.prototype": "['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values']",
+    "Array.prototype": "['at', 'concat', 'constructor', 'copyWithin', 'entries', 'every', 'fill', 'filter', 'find', 'findIndex', 'findLast', 'findLastIndex', 'flat', 'flatMap', 'forEach', 'includes', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toReversed', 'toSorted', 'toSpliced', 'toString', 'unshift', 'values', 'with']",
     "String": "['fromCharCode', 'fromCodePoint', 'length', 'name', 'prototype', 'raw']",
     "String.prototype": "['anchor', 'at', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'codePointAt', 'concat', 'constructor', 'endsWith', 'fixed', 'fontcolor', 'fontsize', 'includes', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'matchAll', 'normalize', 'padEnd', 'padStart', 'repeat', 'replace', 'replaceAll', 'search', 'slice', 'small', 'split', 'startsWith', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimEnd', 'trimLeft', 'trimRight', 'trimStart', 'valueOf']",
     "Boolean": "['length', 'name', 'prototype']",

Modified: trunk/LayoutTests/js/script-tests/array-unscopables-properties.js (293347 => 293348)


--- trunk/LayoutTests/js/script-tests/array-unscopables-properties.js	2022-04-25 20:52:15 UTC (rev 293347)
+++ trunk/LayoutTests/js/script-tests/array-unscopables-properties.js	2022-04-25 20:55:17 UTC (rev 293348)
@@ -19,7 +19,10 @@
     "flatMap",
     "includes",
     "keys",
-    "values"
+    "toReversed",
+    "toSorted",
+    "toSpliced",
+    "values",
 ];
 shouldBe("Object.getOwnPropertyNames(Array.prototype[Symbol.unscopables])", "expectedEntries");
 shouldBe("Object.getOwnPropertySymbols(Array.prototype[Symbol.unscopables])", "[]");

Modified: trunk/Source/_javascript_Core/ChangeLog (293347 => 293348)


--- trunk/Source/_javascript_Core/ChangeLog	2022-04-25 20:52:15 UTC (rev 293347)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-04-25 20:55:17 UTC (rev 293348)
@@ -1,3 +1,12 @@
+2022-04-22  Yusuke Suzuki  <ysuz...@apple.com>
+
+        [JSC] Enable change-array-by-copy
+        https://bugs.webkit.org/show_bug.cgi?id=239678
+
+        Reviewed by Saam Barati.
+
+        * runtime/OptionsList.h:
+
 2022-04-25  Claudio Saavedra  <csaave...@igalia.com>
 
         [GLIB] Remove leftover unused variable from r292929

Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (293347 => 293348)


--- trunk/Source/_javascript_Core/runtime/OptionsList.h	2022-04-25 20:52:15 UTC (rev 293347)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h	2022-04-25 20:55:17 UTC (rev 293348)
@@ -540,7 +540,7 @@
     v(Bool, useArrayFindLastMethod, true, Normal, "Expose the findLast() and findLastIndex() methods on Array and %TypedArray%.") \
     v(Bool, useArrayGroupByMethod, false, Normal, "Expose the groupBy() and groupByToMap() methods on Array.") \
     v(Bool, useAtMethod, true, Normal, "Expose the at() method on Array, %TypedArray%, and String.") \
-    v(Bool, useChangeArrayByCopyMethods, false, Normal, "Expose the withAt(), withReversed(), withSorted() and withSpliced() methods on Array and %TypedArray%.") \
+    v(Bool, useChangeArrayByCopyMethods, true, Normal, "Expose the withAt(), withReversed(), withSorted() and withSpliced() methods on Array and %TypedArray%.") \
     v(Bool, useHasOwn, true, Normal, "Expose the Object.hasOwn method") \
     v(Bool, useImportAssertion, false, Normal, "Enable import assertion.") \
     v(Bool, useIntlEnumeration, true, Normal, "Expose the Intl enumeration APIs.") \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to