Title: [293474] trunk/Source/WebCore/dom
- Revision
- 293474
- Author
- cdu...@apple.com
- Date
- 2022-04-26 15:25:12 -0700 (Tue, 26 Apr 2022)
Log Message
ElementData::setClassNames() can take an r-value reference
https://bugs.webkit.org/show_bug.cgi?id=239789
Reviewed by Geoffrey Garen.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::classAttributeChanged):
* Source/WebCore/dom/ElementData.h:
(WebCore::ElementData::setClassNames const):
Canonical link: https://commits.webkit.org/250010@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/dom/Element.cpp (293473 => 293474)
--- trunk/Source/WebCore/dom/Element.cpp 2022-04-26 22:22:00 UTC (rev 293473)
+++ trunk/Source/WebCore/dom/Element.cpp 2022-04-26 22:25:12 UTC (rev 293474)
@@ -2001,7 +2001,7 @@
auto newClassNames = newStringHasClasses ? SpaceSplitString(newClassString, shouldFoldCase) : SpaceSplitString();
{
Style::ClassChangeInvalidation styleInvalidation(*this, oldClassNames, newClassNames);
- elementData()->setClassNames(newClassNames);
+ elementData()->setClassNames(WTFMove(newClassNames));
}
if (hasRareData()) {
Modified: trunk/Source/WebCore/dom/ElementData.h (293473 => 293474)
--- trunk/Source/WebCore/dom/ElementData.h 2022-04-26 22:22:00 UTC (rev 293473)
+++ trunk/Source/WebCore/dom/ElementData.h 2022-04-26 22:25:12 UTC (rev 293474)
@@ -85,7 +85,7 @@
static const unsigned attributeNotFound = static_cast<unsigned>(-1);
- void setClassNames(const SpaceSplitString& classNames) const { m_classNames = classNames; }
+ void setClassNames(SpaceSplitString&& classNames) const { m_classNames = WTFMove(classNames); }
const SpaceSplitString& classNames() const { return m_classNames; }
static ptrdiff_t classNamesMemoryOffset() { return OBJECT_OFFSETOF(ElementData, m_classNames); }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
