Title: [293660] trunk
- Revision
- 293660
- Author
- commit-qu...@webkit.org
- Date
- 2022-05-02 02:31:55 -0700 (Mon, 02 May 2022)
Log Message
[GLib] Make WebKitSettings XSS auditor functions no-op
https://bugs.webkit.org/show_bug.cgi?id=239651
Patch by Michael Catanzaro <mcatanz...@gnome.org> on 2022-05-02
Reviewed by Adrian Perez de Castro.
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):
* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
Canonical link: https://commits.webkit.org/250164@main
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (293659 => 293660)
--- trunk/Source/WebKit/ChangeLog 2022-05-02 05:46:18 UTC (rev 293659)
+++ trunk/Source/WebKit/ChangeLog 2022-05-02 09:31:55 UTC (rev 293660)
@@ -1,3 +1,17 @@
+2022-04-29 Michael Catanzaro <mcatanz...@redhat.com>
+
+ [GLib] Make WebKitSettings XSS auditor functions no-op
+ https://bugs.webkit.org/show_bug.cgi?id=239651
+ <rdar://problem/92304443>
+
+ Reviewed by Adrian Perez de Castro.
+
+ Fix -Wdeprecated-declarations warnings introduced by the previous fix.
+
+ * UIProcess/API/glib/WebKitSettings.cpp:
+ (webKitSettingsSetProperty):
+ (webKitSettingsGetProperty):
+
2022-05-01 Said Abou-Hallawa <s...@apple.com>
REGRESSION(r282117): RemoteRenderingBackend::willDestroyImageBuffer() can crash if the RemoteRenderingBackend has already been destroyed
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (293659 => 293660)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2022-05-02 05:46:18 UTC (rev 293659)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2022-05-02 09:31:55 UTC (rev 293660)
@@ -229,7 +229,6 @@
webkit_settings_set_enable_html5_database(settings, g_value_get_boolean(value));
break;
case PROP_ENABLE_XSS_AUDITOR:
- webkit_settings_set_enable_xss_auditor(settings, g_value_get_boolean(value));
break;
case PROP_ENABLE_FRAME_FLATTENING:
webkit_settings_set_enable_frame_flattening(settings, g_value_get_boolean(value));
@@ -431,7 +430,7 @@
g_value_set_boolean(value, webkit_settings_get_enable_html5_database(settings));
break;
case PROP_ENABLE_XSS_AUDITOR:
- g_value_set_boolean(value, webkit_settings_get_enable_xss_auditor(settings));
+ g_value_set_boolean(value, FALSE);
break;
case PROP_ENABLE_FRAME_FLATTENING:
g_value_set_boolean(value, webkit_settings_get_enable_frame_flattening(settings));
Modified: trunk/Tools/ChangeLog (293659 => 293660)
--- trunk/Tools/ChangeLog 2022-05-02 05:46:18 UTC (rev 293659)
+++ trunk/Tools/ChangeLog 2022-05-02 09:31:55 UTC (rev 293660)
@@ -1,3 +1,16 @@
+2022-04-29 Michael Catanzaro <mcatanz...@redhat.com>
+
+ [GLib] Make WebKitSettings XSS auditor functions no-op
+ https://bugs.webkit.org/show_bug.cgi?id=239651
+ <rdar://problem/92304443>
+
+ Reviewed by Adrian Perez de Castro.
+
+ Fix -Wdeprecated-declarations warnings introduced by the previous fix.
+
+ * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
+ (testWebKitSettings):
+
2022-04-30 Philippe Normand <ph...@igalia.com>
[WPE][GTK] Built product archives include old library files
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp (293659 => 293660)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp 2022-05-02 05:46:18 UTC (rev 293659)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp 2022-05-02 09:31:55 UTC (rev 293660)
@@ -72,11 +72,6 @@
webkit_settings_set_enable_html5_database(settings, FALSE);
g_assert_false(webkit_settings_get_enable_html5_database(settings));
- // XSS Auditor is deprecated and always disabled.
- g_assert_false(webkit_settings_get_enable_xss_auditor(settings));
- webkit_settings_set_enable_xss_auditor(settings, TRUE);
- g_assert_false(webkit_settings_get_enable_xss_auditor(settings));
-
// Frame flattening is disabled by default.
g_assert_false(webkit_settings_get_enable_frame_flattening(settings));
webkit_settings_set_enable_frame_flattening(settings, TRUE);
@@ -362,10 +357,15 @@
g_assert_false(webkit_settings_get_enable_javascript_markup(settings));
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
- // Accelerated 2D canvas setting is deprecated and no-op.
+ // Accelerated 2D canvas is deprecated and always disabled.
g_assert_false(webkit_settings_get_enable_accelerated_2d_canvas(settings));
webkit_settings_set_enable_accelerated_2d_canvas(settings, TRUE);
g_assert_false(webkit_settings_get_enable_accelerated_2d_canvas(settings));
+
+ // XSS Auditor is deprecated and always disabled.
+ g_assert_false(webkit_settings_get_enable_xss_auditor(settings));
+ webkit_settings_set_enable_xss_auditor(settings, TRUE);
+ g_assert_false(webkit_settings_get_enable_xss_auditor(settings));
ALLOW_DEPRECATED_DECLARATIONS_END
g_object_unref(G_OBJECT(settings));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
