Diff
Modified: trunk/LayoutTests/ChangeLog (293688 => 293689)
--- trunk/LayoutTests/ChangeLog 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/ChangeLog 2022-05-02 22:35:13 UTC (rev 293689)
@@ -1,3 +1,19 @@
+2022-05-02 Oriol Brufau <obru...@igalia.com>
+
+ [cssom] Don't index 'all' shorthand in computed styles
+ https://bugs.webkit.org/show_bug.cgi?id=239669
+
+ Reviewed by Darin Adler.
+
+ Update test expectations.
+
+ * platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+ * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+ * platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+
2022-05-02 Devin Rousso <drou...@apple.com>
[Modern Media Controls] REGRESSION(?) tapping a video to start playing for the first time doesn't start playing
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (293688 => 293689)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-02 22:35:13 UTC (rev 293689)
@@ -1,3 +1,15 @@
+2022-05-02 Oriol Brufau <obru...@igalia.com>
+
+ [cssom] Don't index 'all' shorthand in computed styles
+ https://bugs.webkit.org/show_bug.cgi?id=239669
+
+ Reviewed by Darin Adler.
+
+ Update test expectations.
+
+ * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+
2022-05-02 Youenn Fablet <you...@apple.com>
Cancel response stream if load is being cancelled by the web page
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293688 => 293689)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-05-02 22:35:13 UTC (rev 293689)
@@ -7,7 +7,6 @@
PASS align-items
PASS align-self
PASS alignment-baseline
-PASS all
PASS alt
PASS animation-composition
PASS animation-delay
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (293688 => 293689)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-05-02 22:35:13 UTC (rev 293689)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 404
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 404
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 404
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 404
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 403
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 403
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 403
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 403
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293688 => 293689)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-05-02 22:35:13 UTC (rev 293689)
@@ -7,7 +7,6 @@
PASS align-items
PASS align-self
PASS alignment-baseline
-PASS all
PASS alt
PASS animation-composition
PASS animation-delay
Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (293688 => 293689)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-05-02 22:35:13 UTC (rev 293689)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 402
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 402
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 402
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 402
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 401
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 401
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 401
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 401
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (293688 => 293689)
--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-05-02 22:35:13 UTC (rev 293689)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 406
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 406
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 406
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 406
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 405
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 405
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 405
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 405
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (293688 => 293689)
--- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-05-02 22:35:13 UTC (rev 293689)
@@ -7,7 +7,6 @@
PASS align-items
PASS align-self
PASS alignment-baseline
-PASS all
PASS alt
PASS animation-composition
PASS animation-delay
Modified: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (293688 => 293689)
--- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-05-02 22:35:13 UTC (rev 293689)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 401
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 401
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 401
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 401
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 400
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 400
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 400
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 400
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/Source/WebCore/ChangeLog (293688 => 293689)
--- trunk/Source/WebCore/ChangeLog 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/Source/WebCore/ChangeLog 2022-05-02 22:35:13 UTC (rev 293689)
@@ -1,3 +1,21 @@
+2022-05-02 Oriol Brufau <obru...@igalia.com>
+
+ [cssom] Don't index 'all' shorthand in computed styles
+ https://bugs.webkit.org/show_bug.cgi?id=239669
+
+ Reviewed by Darin Adler.
+
+ Computed styles should provide getters for both longhands and shorthands,
+ but only the former should be indexed.
+
+ However, the 'all' shorthand was being indexed as if it was a longhand.
+
+ Tests: imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html
+ imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
+
+ * css/makeprop.pl:
+ (skippedFromComputedStyle):
+
2022-05-02 Devin Rousso <drou...@apple.com>
[Modern Media Controls] REGRESSION(?) tapping a video to start playing for the first time doesn't start playing
Modified: trunk/Source/WebCore/css/makeprop.pl (293688 => 293689)
--- trunk/Source/WebCore/css/makeprop.pl 2022-05-02 22:33:52 UTC (rev 293688)
+++ trunk/Source/WebCore/css/makeprop.pl 2022-05-02 22:35:13 UTC (rev 293689)
@@ -206,6 +206,11 @@
return 1;
}
+ # For convenience, "all" is not defined with the full list of longhands.
+ # Its only listed longhand is itself, so it wouldn't match the condition below.
+ # Then we have to handle it especially.
+ return 1 if $name eq "all";
+
if (exists($propertiesWithStyleBuilderOptions{$name}{"longhands"})) {
my @longhands = @{$propertiesWithStyleBuilderOptions{$name}{"longhands"}};
if (scalar @longhands != 1) {
