Title: [294168] branches/safari-7614.1.13-branch/Source/WebCore
Revision
294168
Author
repst...@apple.com
Date
2022-05-13 11:25:56 -0700 (Fri, 13 May 2022)

Log Message

Cherry-pick r294135. rdar://problem/93201070

    [WebAuthn] Remove document focus requirement for conditional mediation requests
    https://bugs.webkit.org/show_bug.cgi?id=240361
    rdar://problem/93201070

    Reviewed by Brent Fulgham.

    This is necessary so conditional mediation requests work when you open a page in
    a new tab. Conditional mediation requests do not support security keys and the
    request will be aborted if conditional mediation is not available.

    * Modules/credentialmanagement/CredentialsContainer.cpp:
    (WebCore::CredentialsContainer::get):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-7614.1.13-branch/Source/WebCore/ChangeLog (294167 => 294168)


--- branches/safari-7614.1.13-branch/Source/WebCore/ChangeLog	2022-05-13 18:22:07 UTC (rev 294167)
+++ branches/safari-7614.1.13-branch/Source/WebCore/ChangeLog	2022-05-13 18:25:56 UTC (rev 294168)
@@ -1,3 +1,38 @@
+2022-05-13  Russell Epstein  <repst...@apple.com>
+
+        Cherry-pick r294135. rdar://problem/93201070
+
+    [WebAuthn] Remove document focus requirement for conditional mediation requests
+    https://bugs.webkit.org/show_bug.cgi?id=240361
+    rdar://problem/93201070
+    
+    Reviewed by Brent Fulgham.
+    
+    This is necessary so conditional mediation requests work when you open a page in
+    a new tab. Conditional mediation requests do not support security keys and the
+    request will be aborted if conditional mediation is not available.
+    
+    * Modules/credentialmanagement/CredentialsContainer.cpp:
+    (WebCore::CredentialsContainer::get):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-05-12  J Pascoe  <j_pas...@apple.com>
+
+            [WebAuthn] Remove document focus requirement for conditional mediation requests
+            https://bugs.webkit.org/show_bug.cgi?id=240361
+            rdar://problem/93201070
+
+            Reviewed by Brent Fulgham.
+
+            This is necessary so conditional mediation requests work when you open a page in
+            a new tab. Conditional mediation requests do not support security keys and the
+            request will be aborted if conditional mediation is not available.
+
+            * Modules/credentialmanagement/CredentialsContainer.cpp:
+            (WebCore::CredentialsContainer::get):
+
 2022-05-12  Alan Coon  <alanc...@apple.com>
 
         Cherry-pick r293994. rdar://problem/87157773

Modified: branches/safari-7614.1.13-branch/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp (294167 => 294168)


--- branches/safari-7614.1.13-branch/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp	2022-05-13 18:22:07 UTC (rev 294167)
+++ branches/safari-7614.1.13-branch/Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp	2022-05-13 18:25:56 UTC (rev 294168)
@@ -92,8 +92,8 @@
         return;
     }
 
-    // Extra.
-    if (!m_document->hasFocus()) {
+    // The request will be aborted in WebAuthenticatorCoordinatorProxy if conditional mediation is not available.
+    if (options.mediation != CredentialRequestOptions::MediationRequirement::Conditional && !m_document->hasFocus()) {
         promise.reject(Exception { NotAllowedError, "The document is not focused."_s });
         return;
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to