Diff
Modified: trunk/LayoutTests/ChangeLog (294186 => 294187)
--- trunk/LayoutTests/ChangeLog 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/ChangeLog 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,3 +1,24 @@
+2022-05-13 Tim Nguyen <n...@apple.com>
+
+ [css-ui] Unexpose appearance property values already handled by appearance: auto
+ https://bugs.webkit.org/show_bug.cgi?id=240384
+
+ Reviewed by Aditya Keerthi.
+
+ These are only used internally, and are handled by appearance: auto in the UA sheets:
+ - caps-lock-indicator
+ - color-well
+ - list-button
+ - searchfield-decoration
+ - searchfield-results-decoration
+ - searchfield-results-button
+ - searchfield-cancel-button
+
+ * platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+ * platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+ * fast/css/appearance-caps-lock-indicator-expected.txt: Removed.
+ * fast/css/appearance-caps-lock-indicator.html: Removed.
+
2022-05-13 Tyler Wilcock <tyle...@apple.com>
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
Deleted: trunk/LayoutTests/fast/css/appearance-caps-lock-indicator-expected.txt (294186 => 294187)
--- trunk/LayoutTests/fast/css/appearance-caps-lock-indicator-expected.txt 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/fast/css/appearance-caps-lock-indicator-expected.txt 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,3 +0,0 @@
-Test that the CSS parser accepts caps-lock-indicator as a -webkit-appearance value.
-
-PASS
Deleted: trunk/LayoutTests/fast/css/appearance-caps-lock-indicator.html (294186 => 294187)
--- trunk/LayoutTests/fast/css/appearance-caps-lock-indicator.html 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/fast/css/appearance-caps-lock-indicator.html 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,12 +0,0 @@
-<p>
- Test that the CSS parser accepts <tt>caps-lock-indicator</tt> as a <tt>-webkit-appearance</tt> value.
-</p>
-<p id="result">FAIL: Test did not run</p>
-<div id="target" style="display: none; -webkit-appearance: caps-lock-indicator;"></div>
-<script>
- if (window.testRunner)
- testRunner.dumpAsText();
-
- var appearance = document.getElementById("target").style.webkitAppearance;
- document.getElementById("result").innerText = appearance === "caps-lock-indicator" ? "PASS" : "FAIL: parsed as " + appearance;
-</script>
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294186 => 294187)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,5 +1,23 @@
2022-05-13 Tim Nguyen <n...@apple.com>
+ [css-ui] Unexpose appearance property values already handled by appearance: auto
+ https://bugs.webkit.org/show_bug.cgi?id=240384
+
+ Reviewed by Aditya Keerthi.
+
+ These are only used internally, and are handled by appearance: auto in the UA sheets:
+ - caps-lock-indicator
+ - color-well
+ - list-button
+ - searchfield-decoration
+ - searchfield-results-decoration
+ - searchfield-results-button
+ - searchfield-cancel-button
+
+ * web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+
+2022-05-13 Tim Nguyen <n...@apple.com>
+
[css-ui] Remove caret/progress-bar-value/listitem values from appearance property
https://bugs.webkit.org/show_bug.cgi?id=240390
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294186 => 294187)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-14 05:29:41 UTC (rev 294187)
@@ -25,12 +25,12 @@
PASS -webkit-appearance: button-arrow-previous (invalid)
PASS -webkit-appearance: button-arrow-up (invalid)
PASS -webkit-appearance: button-focus (invalid)
-FAIL -webkit-appearance: caps-lock-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caps-lock-indicator"
+PASS -webkit-appearance: caps-lock-indicator (invalid)
PASS -webkit-appearance: caret (invalid)
PASS -webkit-appearance: checkbox-container (invalid)
PASS -webkit-appearance: checkbox-label (invalid)
PASS -webkit-appearance: checkmenuitem (invalid)
-FAIL -webkit-appearance: color-well (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "color-well"
+PASS -webkit-appearance: color-well (invalid)
FAIL -webkit-appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "continuous-capacity-level-indicator"
FAIL -webkit-appearance: default-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "default-button"
FAIL -webkit-appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "discrete-capacity-level-indicator"
@@ -38,7 +38,7 @@
PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
-FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
+PASS -webkit-appearance: list-button (invalid)
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
@@ -107,10 +107,10 @@
PASS -webkit-appearance: scrollbarthumb-vertical (invalid)
PASS -webkit-appearance: scrollbartrack-horizontal (invalid)
PASS -webkit-appearance: scrollbartrack-vertical (invalid)
-FAIL -webkit-appearance: searchfield-cancel-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-cancel-button"
-FAIL -webkit-appearance: searchfield-decoration (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-decoration"
-FAIL -webkit-appearance: searchfield-results-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-results-button"
-FAIL -webkit-appearance: searchfield-results-decoration (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-results-decoration"
+PASS -webkit-appearance: searchfield-cancel-button (invalid)
+PASS -webkit-appearance: searchfield-decoration (invalid)
+PASS -webkit-appearance: searchfield-results-button (invalid)
+PASS -webkit-appearance: searchfield-results-decoration (invalid)
PASS -webkit-appearance: separator (invalid)
PASS -webkit-appearance: sheet (invalid)
FAIL -webkit-appearance: slider-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "slider-vertical"
@@ -188,12 +188,12 @@
PASS appearance: button-arrow-previous (invalid)
PASS appearance: button-arrow-up (invalid)
PASS appearance: button-focus (invalid)
-FAIL appearance: caps-lock-indicator (invalid) assert_equals: style.appearance expected "" but got "caps-lock-indicator"
+PASS appearance: caps-lock-indicator (invalid)
PASS appearance: caret (invalid)
PASS appearance: checkbox-container (invalid)
PASS appearance: checkbox-label (invalid)
PASS appearance: checkmenuitem (invalid)
-FAIL appearance: color-well (invalid) assert_equals: style.appearance expected "" but got "color-well"
+PASS appearance: color-well (invalid)
FAIL appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "continuous-capacity-level-indicator"
FAIL appearance: default-button (invalid) assert_equals: style.appearance expected "" but got "default-button"
FAIL appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "discrete-capacity-level-indicator"
@@ -201,7 +201,7 @@
PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
-FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
+PASS appearance: list-button (invalid)
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
@@ -270,10 +270,10 @@
PASS appearance: scrollbarthumb-vertical (invalid)
PASS appearance: scrollbartrack-horizontal (invalid)
PASS appearance: scrollbartrack-vertical (invalid)
-FAIL appearance: searchfield-cancel-button (invalid) assert_equals: style.appearance expected "" but got "searchfield-cancel-button"
-FAIL appearance: searchfield-decoration (invalid) assert_equals: style.appearance expected "" but got "searchfield-decoration"
-FAIL appearance: searchfield-results-button (invalid) assert_equals: style.appearance expected "" but got "searchfield-results-button"
-FAIL appearance: searchfield-results-decoration (invalid) assert_equals: style.appearance expected "" but got "searchfield-results-decoration"
+PASS appearance: searchfield-cancel-button (invalid)
+PASS appearance: searchfield-decoration (invalid)
+PASS appearance: searchfield-results-button (invalid)
+PASS appearance: searchfield-results-decoration (invalid)
PASS appearance: separator (invalid)
PASS appearance: sheet (invalid)
FAIL appearance: slider-vertical (invalid) assert_equals: style.appearance expected "" but got "slider-vertical"
Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294186 => 294187)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-14 05:29:41 UTC (rev 294187)
@@ -25,12 +25,12 @@
PASS -webkit-appearance: button-arrow-previous (invalid)
PASS -webkit-appearance: button-arrow-up (invalid)
PASS -webkit-appearance: button-focus (invalid)
-FAIL -webkit-appearance: caps-lock-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caps-lock-indicator"
+PASS -webkit-appearance: caps-lock-indicator (invalid)
PASS -webkit-appearance: caret (invalid)
PASS -webkit-appearance: checkbox-container (invalid)
PASS -webkit-appearance: checkbox-label (invalid)
PASS -webkit-appearance: checkmenuitem (invalid)
-FAIL -webkit-appearance: color-well (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "color-well"
+PASS -webkit-appearance: color-well (invalid)
FAIL -webkit-appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "continuous-capacity-level-indicator"
FAIL -webkit-appearance: default-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "default-button"
FAIL -webkit-appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "discrete-capacity-level-indicator"
@@ -38,7 +38,7 @@
PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
-FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
+PASS -webkit-appearance: list-button (invalid)
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
@@ -107,10 +107,10 @@
PASS -webkit-appearance: scrollbarthumb-vertical (invalid)
PASS -webkit-appearance: scrollbartrack-horizontal (invalid)
PASS -webkit-appearance: scrollbartrack-vertical (invalid)
-FAIL -webkit-appearance: searchfield-cancel-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-cancel-button"
-FAIL -webkit-appearance: searchfield-decoration (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-decoration"
-FAIL -webkit-appearance: searchfield-results-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-results-button"
-FAIL -webkit-appearance: searchfield-results-decoration (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-results-decoration"
+PASS -webkit-appearance: searchfield-cancel-button (invalid)
+PASS -webkit-appearance: searchfield-decoration (invalid)
+PASS -webkit-appearance: searchfield-results-button (invalid)
+PASS -webkit-appearance: searchfield-results-decoration (invalid)
PASS -webkit-appearance: separator (invalid)
PASS -webkit-appearance: sheet (invalid)
FAIL -webkit-appearance: slider-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "slider-vertical"
@@ -188,12 +188,12 @@
PASS appearance: button-arrow-previous (invalid)
PASS appearance: button-arrow-up (invalid)
PASS appearance: button-focus (invalid)
-FAIL appearance: caps-lock-indicator (invalid) assert_equals: style.appearance expected "" but got "caps-lock-indicator"
+PASS appearance: caps-lock-indicator (invalid)
PASS appearance: caret (invalid)
PASS appearance: checkbox-container (invalid)
PASS appearance: checkbox-label (invalid)
PASS appearance: checkmenuitem (invalid)
-FAIL appearance: color-well (invalid) assert_equals: style.appearance expected "" but got "color-well"
+PASS appearance: color-well (invalid)
FAIL appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "continuous-capacity-level-indicator"
FAIL appearance: default-button (invalid) assert_equals: style.appearance expected "" but got "default-button"
FAIL appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "discrete-capacity-level-indicator"
@@ -201,7 +201,7 @@
PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
-FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
+PASS appearance: list-button (invalid)
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
@@ -270,10 +270,10 @@
PASS appearance: scrollbarthumb-vertical (invalid)
PASS appearance: scrollbartrack-horizontal (invalid)
PASS appearance: scrollbartrack-vertical (invalid)
-FAIL appearance: searchfield-cancel-button (invalid) assert_equals: style.appearance expected "" but got "searchfield-cancel-button"
-FAIL appearance: searchfield-decoration (invalid) assert_equals: style.appearance expected "" but got "searchfield-decoration"
-FAIL appearance: searchfield-results-button (invalid) assert_equals: style.appearance expected "" but got "searchfield-results-button"
-FAIL appearance: searchfield-results-decoration (invalid) assert_equals: style.appearance expected "" but got "searchfield-results-decoration"
+PASS appearance: searchfield-cancel-button (invalid)
+PASS appearance: searchfield-decoration (invalid)
+PASS appearance: searchfield-results-button (invalid)
+PASS appearance: searchfield-results-decoration (invalid)
PASS appearance: separator (invalid)
PASS appearance: sheet (invalid)
FAIL appearance: slider-vertical (invalid) assert_equals: style.appearance expected "" but got "slider-vertical"
Modified: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294186 => 294187)
--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-14 05:29:41 UTC (rev 294187)
@@ -25,12 +25,12 @@
PASS -webkit-appearance: button-arrow-previous (invalid)
PASS -webkit-appearance: button-arrow-up (invalid)
PASS -webkit-appearance: button-focus (invalid)
-FAIL -webkit-appearance: caps-lock-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caps-lock-indicator"
+PASS -webkit-appearance: caps-lock-indicator (invalid)
PASS -webkit-appearance: caret (invalid)
PASS -webkit-appearance: checkbox-container (invalid)
PASS -webkit-appearance: checkbox-label (invalid)
PASS -webkit-appearance: checkmenuitem (invalid)
-FAIL -webkit-appearance: color-well (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "color-well"
+PASS -webkit-appearance: color-well (invalid)
FAIL -webkit-appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "continuous-capacity-level-indicator"
FAIL -webkit-appearance: default-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "default-button"
FAIL -webkit-appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "discrete-capacity-level-indicator"
@@ -38,7 +38,7 @@
PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
-FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
+PASS -webkit-appearance: list-button (invalid)
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
@@ -107,10 +107,10 @@
PASS -webkit-appearance: scrollbarthumb-vertical (invalid)
PASS -webkit-appearance: scrollbartrack-horizontal (invalid)
PASS -webkit-appearance: scrollbartrack-vertical (invalid)
-FAIL -webkit-appearance: searchfield-cancel-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-cancel-button"
-FAIL -webkit-appearance: searchfield-decoration (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-decoration"
-FAIL -webkit-appearance: searchfield-results-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-results-button"
-FAIL -webkit-appearance: searchfield-results-decoration (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "searchfield-results-decoration"
+PASS -webkit-appearance: searchfield-cancel-button (invalid)
+PASS -webkit-appearance: searchfield-decoration (invalid)
+PASS -webkit-appearance: searchfield-results-button (invalid)
+PASS -webkit-appearance: searchfield-results-decoration (invalid)
PASS -webkit-appearance: separator (invalid)
PASS -webkit-appearance: sheet (invalid)
FAIL -webkit-appearance: slider-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "slider-vertical"
@@ -188,12 +188,12 @@
PASS appearance: button-arrow-previous (invalid)
PASS appearance: button-arrow-up (invalid)
PASS appearance: button-focus (invalid)
-FAIL appearance: caps-lock-indicator (invalid) assert_equals: style.appearance expected "" but got "caps-lock-indicator"
+PASS appearance: caps-lock-indicator (invalid)
PASS appearance: caret (invalid)
PASS appearance: checkbox-container (invalid)
PASS appearance: checkbox-label (invalid)
PASS appearance: checkmenuitem (invalid)
-FAIL appearance: color-well (invalid) assert_equals: style.appearance expected "" but got "color-well"
+PASS appearance: color-well (invalid)
FAIL appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "continuous-capacity-level-indicator"
FAIL appearance: default-button (invalid) assert_equals: style.appearance expected "" but got "default-button"
FAIL appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "discrete-capacity-level-indicator"
@@ -201,7 +201,7 @@
PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
-FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
+PASS appearance: list-button (invalid)
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
@@ -270,10 +270,10 @@
PASS appearance: scrollbarthumb-vertical (invalid)
PASS appearance: scrollbartrack-horizontal (invalid)
PASS appearance: scrollbartrack-vertical (invalid)
-FAIL appearance: searchfield-cancel-button (invalid) assert_equals: style.appearance expected "" but got "searchfield-cancel-button"
-FAIL appearance: searchfield-decoration (invalid) assert_equals: style.appearance expected "" but got "searchfield-decoration"
-FAIL appearance: searchfield-results-button (invalid) assert_equals: style.appearance expected "" but got "searchfield-results-button"
-FAIL appearance: searchfield-results-decoration (invalid) assert_equals: style.appearance expected "" but got "searchfield-results-decoration"
+PASS appearance: searchfield-cancel-button (invalid)
+PASS appearance: searchfield-decoration (invalid)
+PASS appearance: searchfield-results-button (invalid)
+PASS appearance: searchfield-results-decoration (invalid)
PASS appearance: separator (invalid)
PASS appearance: sheet (invalid)
FAIL appearance: slider-vertical (invalid) assert_equals: style.appearance expected "" but got "slider-vertical"
Modified: trunk/Source/WebCore/ChangeLog (294186 => 294187)
--- trunk/Source/WebCore/ChangeLog 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/Source/WebCore/ChangeLog 2022-05-14 05:29:41 UTC (rev 294187)
@@ -1,3 +1,30 @@
+2022-05-13 Tim Nguyen <n...@apple.com>
+
+ [css-ui] Unexpose appearance property values already handled by appearance: auto
+ https://bugs.webkit.org/show_bug.cgi?id=240384
+
+ Reviewed by Aditya Keerthi.
+
+ These are only used internally, and are handled by appearance: auto in the UA sheets:
+ - caps-lock-indicator
+ - color-well
+ - list-button
+ - searchfield-decoration
+ - searchfield-results-decoration
+ - searchfield-results-button
+ - searchfield-cancel-button
+
+ Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ * platform/ThemeTypes.cpp:
+ (WebCore::operator<<):
+ * platform/ThemeTypes.h:
+
2022-05-13 Tyler Wilcock <tyle...@apple.com>
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (294186 => 294187)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2022-05-14 05:29:41 UTC (rev 294187)
@@ -492,7 +492,7 @@
break;
case MediaVolumeSliderThumbPart:
m_value.valueID = CSSValueMediaVolumeSliderthumb;
- break;
+ break;
case MediaFullScreenVolumeSliderPart:
m_value.valueID = CSSValueMediaFullscreenVolumeSlider;
break;
@@ -544,18 +544,6 @@
case SearchFieldPart:
m_value.valueID = CSSValueSearchfield;
break;
- case SearchFieldDecorationPart:
- m_value.valueID = CSSValueSearchfieldDecoration;
- break;
- case SearchFieldResultsDecorationPart:
- m_value.valueID = CSSValueSearchfieldResultsDecoration;
- break;
- case SearchFieldResultsButtonPart:
- m_value.valueID = CSSValueSearchfieldResultsButton;
- break;
- case SearchFieldCancelButtonPart:
- m_value.valueID = CSSValueSearchfieldCancelButton;
- break;
case TextFieldPart:
m_value.valueID = CSSValueTextfield;
break;
@@ -562,9 +550,6 @@
case TextAreaPart:
m_value.valueID = CSSValueTextarea;
break;
- case CapsLockIndicatorPart:
- m_value.valueID = CSSValueCapsLockIndicator;
- break;
#if ENABLE(ATTACHMENT_ELEMENT)
case AttachmentPart:
m_value.valueID = CSSValueAttachment;
@@ -573,27 +558,28 @@
m_value.valueID = CSSValueBorderlessAttachment;
break;
#endif
-#if ENABLE(SERVICE_CONTROLS)
- case ImageControlsButtonPart:
- ASSERT_NOT_REACHED();
- m_value.valueID = CSSValueNone;
- break;
-#endif
#if ENABLE(APPLE_PAY)
case ApplePayButtonPart:
m_value.valueID = CSSValueApplePayButton;
break;
#endif
+ case CapsLockIndicatorPart:
#if ENABLE(INPUT_TYPE_COLOR)
case ColorWellPart:
- m_value.valueID = CSSValueColorWell;
- break;
#endif
+#if ENABLE(SERVICE_CONTROLS)
+ case ImageControlsButtonPart:
+#endif
#if ENABLE(DATALIST_ELEMENT)
case ListButtonPart:
- m_value.valueID = CSSValueListButton;
+#endif
+ case SearchFieldDecorationPart:
+ case SearchFieldResultsDecorationPart:
+ case SearchFieldResultsButtonPart:
+ case SearchFieldCancelButtonPart:
+ ASSERT_NOT_REACHED();
+ m_value.valueID = CSSValueNone;
break;
-#endif
}
}
Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (294186 => 294187)
--- trunk/Source/WebCore/css/CSSValueKeywords.in 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in 2022-05-14 05:29:41 UTC (rev 294187)
@@ -861,11 +861,6 @@
sliderthumb-horizontal
sliderthumb-vertical
searchfield
-searchfield-decoration
-searchfield-results-decoration
-searchfield-results-button
-searchfield-cancel-button
-textfield
relevancy-level-indicator
continuous-capacity-level-indicator
discrete-capacity-level-indicator
@@ -873,18 +868,12 @@
#if defined(ENABLE_APPLE_PAY) && ENABLE_APPLE_PAY
-apple-pay-button
#endif
-#if defined(ENABLE_INPUT_TYPE_COLOR) && ENABLE_INPUT_TYPE_COLOR
-color-well
-#endif
-#if defined(ENABLE_DATALIST_ELEMENT) && ENABLE_DATALIST_ELEMENT
-list-button
-#endif
-textarea
#if defined(ENABLE_ATTACHMENT_ELEMENT) && ENABLE_ATTACHMENT_ELEMENT
attachment
borderless-attachment
#endif
-caps-lock-indicator
+textarea
+textfield
//
// CSS_PROP_BORDER_IMAGE
Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (294186 => 294187)
--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-14 05:29:41 UTC (rev 294187)
@@ -751,7 +751,7 @@
case CSSPropertyVisibility: // visible | hidden | collapse
return valueID == CSSValueVisible || valueID == CSSValueHidden || valueID == CSSValueCollapse;
case CSSPropertyAppearance:
- return (valueID >= CSSValueCheckbox && valueID <= CSSValueCapsLockIndicator) || valueID == CSSValueNone || valueID == CSSValueAuto;
+ return (valueID >= CSSValueCheckbox && valueID <= CSSValueTextfield) || valueID == CSSValueNone || valueID == CSSValueAuto;
case CSSPropertyBackfaceVisibility:
return valueID == CSSValueVisible || valueID == CSSValueHidden;
#if ENABLE(CSS_COMPOSITING)
Modified: trunk/Source/WebCore/platform/ThemeTypes.cpp (294186 => 294187)
--- trunk/Source/WebCore/platform/ThemeTypes.cpp 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/Source/WebCore/platform/ThemeTypes.cpp 2022-05-14 05:29:41 UTC (rev 294187)
@@ -90,7 +90,7 @@
#endif
case CapsLockIndicatorPart: ts << "caps-lock-indicator-part"; break;
}
-
+
return ts;
}
Modified: trunk/Source/WebCore/platform/ThemeTypes.h (294186 => 294187)
--- trunk/Source/WebCore/platform/ThemeTypes.h 2022-05-14 04:37:21 UTC (rev 294186)
+++ trunk/Source/WebCore/platform/ThemeTypes.h 2022-05-14 05:29:41 UTC (rev 294187)
@@ -62,11 +62,6 @@
SliderThumbHorizontalPart,
SliderThumbVerticalPart,
SearchFieldPart,
- SearchFieldDecorationPart,
- SearchFieldResultsDecorationPart,
- SearchFieldResultsButtonPart,
- SearchFieldCancelButtonPart,
- TextFieldPart,
RelevancyLevelIndicatorPart,
ContinuousCapacityLevelIndicatorPart,
DiscreteCapacityLevelIndicatorPart,
@@ -74,23 +69,27 @@
#if ENABLE(APPLE_PAY)
ApplePayButtonPart,
#endif
-#if ENABLE(INPUT_TYPE_COLOR)
- ColorWellPart,
-#endif
-#if ENABLE(DATALIST_ELEMENT)
- ListButtonPart,
-#endif
- TextAreaPart,
#if ENABLE(ATTACHMENT_ELEMENT)
AttachmentPart,
BorderlessAttachmentPart,
#endif
+ TextAreaPart,
+ TextFieldPart,
+ // Internal-only Values
CapsLockIndicatorPart,
- // Internal-only Values
+#if ENABLE(INPUT_TYPE_COLOR)
+ ColorWellPart,
+#endif
#if ENABLE(SERVICE_CONTROLS)
- ImageControlsButtonPart
+ ImageControlsButtonPart,
#endif
-
+#if ENABLE(DATALIST_ELEMENT)
+ ListButtonPart,
+#endif
+ SearchFieldDecorationPart,
+ SearchFieldResultsDecorationPart,
+ SearchFieldResultsButtonPart,
+ SearchFieldCancelButtonPart
};
#if ENABLE(SERVICE_CONTROLS)
