Diff
Modified: trunk/LayoutTests/ChangeLog (294225 => 294226)
--- trunk/LayoutTests/ChangeLog 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/ChangeLog 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,3 +1,25 @@
+2022-05-16 Tim Nguyen <n...@apple.com>
+
+ [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
+ https://bugs.webkit.org/show_bug.cgi?id=240448
+
+ Reviewed by Antti Koivisto.
+
+ iOS baseline for appearance-cssom-001-expected.txt is identical to the main one, so remove it.
+
+ * fast/forms/range/thumbslider-crash-expected.txt: Removed.
+ * fast/forms/range/thumbslider-crash.html: Removed.
+ * fast/forms/range/thumbslider-no-parent-slider.html: Removed.
+ * platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
+ * platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
+ * platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+ * platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.
+ * platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
+ * platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
+ * platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
+ * platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
+ * platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
+
2022-05-16 Martin Robinson <mrobin...@webkit.org>
Do not allow unitless values for CSS unprefixed perspective property
Deleted: trunk/LayoutTests/fast/forms/range/thumbslider-crash-expected.txt (294225 => 294226)
--- trunk/LayoutTests/fast/forms/range/thumbslider-crash-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/fast/forms/range/thumbslider-crash-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1 +0,0 @@
-PASS If this test does not crash. http://bugs.webkit.org/show_bug.cgi?id=12045
Deleted: trunk/LayoutTests/fast/forms/range/thumbslider-crash.html (294225 => 294226)
--- trunk/LayoutTests/fast/forms/range/thumbslider-crash.html 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/fast/forms/range/thumbslider-crash.html 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,14 +0,0 @@
-<html>
-<head>
- <style type="text/css">
- * { -webkit-appearance: sliderthumb-horizontal; }
- </style>
-</head>
-<body>
-PASS If this test does not crash. http://bugs.webkit.org/show_bug.cgi?id=12045
-<script>
-if (window.testRunner)
- testRunner.dumpAsText();
-</script>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/range/thumbslider-no-parent-slider.html (294225 => 294226)
--- trunk/LayoutTests/fast/forms/range/thumbslider-no-parent-slider.html 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/fast/forms/range/thumbslider-no-parent-slider.html 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,23 +0,0 @@
-<html>
-<head>
-<style type="text/css">
-#thumbHorizontal {
- -webkit-appearance: sliderthumb-horizontal;
- display: inline-block;
- width: 20px;
- height: 20px;
-}
-#thumbVertical {
- -webkit-appearance: sliderthumb-vertical;
- display: inline-block;
- width: 20px;
- height: 20px;
-}
-</style>
-</head>
-<body>
-<!-- There should be a horizontal slider thumb and a vertical slider thumb. -->
-<span id="thumbHorizontal"></span><br>
-<span id="thumbVertical"></span>
-</body>
-</html>
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294225 => 294226)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,3 +1,12 @@
+2022-05-16 Tim Nguyen <n...@apple.com>
+
+ [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
+ https://bugs.webkit.org/show_bug.cgi?id=240448
+
+ Reviewed by Antti Koivisto.
+
+ * web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+
2022-05-16 Martin Robinson <mrobin...@webkit.org>
Do not allow unitless values for CSS unprefixed perspective property
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294225 => 294226)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -37,7 +37,7 @@
PASS -webkit-appearance: dualbutton (invalid)
PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
-FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
+PASS -webkit-appearance: inner-spin-button (invalid)
PASS -webkit-appearance: list-button (invalid)
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
@@ -114,8 +114,8 @@
PASS -webkit-appearance: separator (invalid)
PASS -webkit-appearance: sheet (invalid)
FAIL -webkit-appearance: slider-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "slider-vertical"
-FAIL -webkit-appearance: sliderthumb-horizontal (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-horizontal"
-FAIL -webkit-appearance: sliderthumb-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-vertical"
+PASS -webkit-appearance: sliderthumb-horizontal (invalid)
+PASS -webkit-appearance: sliderthumb-vertical (invalid)
PASS -webkit-appearance: snapshotted-plugin-overlay (invalid)
PASS -webkit-appearance: spinner (invalid)
PASS -webkit-appearance: spinner-downbutton (invalid)
@@ -200,7 +200,7 @@
PASS appearance: dualbutton (invalid)
PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
-FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
+PASS appearance: inner-spin-button (invalid)
PASS appearance: list-button (invalid)
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
@@ -277,8 +277,8 @@
PASS appearance: separator (invalid)
PASS appearance: sheet (invalid)
FAIL appearance: slider-vertical (invalid) assert_equals: style.appearance expected "" but got "slider-vertical"
-FAIL appearance: sliderthumb-horizontal (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-horizontal"
-FAIL appearance: sliderthumb-vertical (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-vertical"
+PASS appearance: sliderthumb-horizontal (invalid)
+PASS appearance: sliderthumb-vertical (invalid)
PASS appearance: snapshotted-plugin-overlay (invalid)
PASS appearance: spinner (invalid)
PASS appearance: spinner-downbutton (invalid)
Deleted: trunk/LayoutTests/platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt (294225 => 294226)
--- trunk/LayoutTests/platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,9 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {SPAN} at (0,0) size 20x20
- RenderBR {BR} at (20,6) size 0x17
- RenderBlock {SPAN} at (0,20) size 20x20
- RenderText {#text} at (0,0) size 0x0
Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294225 => 294226)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -37,7 +37,7 @@
PASS -webkit-appearance: dualbutton (invalid)
PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
-FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
+PASS -webkit-appearance: inner-spin-button (invalid)
PASS -webkit-appearance: list-button (invalid)
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
@@ -114,8 +114,8 @@
PASS -webkit-appearance: separator (invalid)
PASS -webkit-appearance: sheet (invalid)
FAIL -webkit-appearance: slider-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "slider-vertical"
-FAIL -webkit-appearance: sliderthumb-horizontal (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-horizontal"
-FAIL -webkit-appearance: sliderthumb-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-vertical"
+PASS -webkit-appearance: sliderthumb-horizontal (invalid)
+PASS -webkit-appearance: sliderthumb-vertical (invalid)
PASS -webkit-appearance: snapshotted-plugin-overlay (invalid)
PASS -webkit-appearance: spinner (invalid)
PASS -webkit-appearance: spinner-downbutton (invalid)
@@ -200,7 +200,7 @@
PASS appearance: dualbutton (invalid)
PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
-FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
+PASS appearance: inner-spin-button (invalid)
PASS appearance: list-button (invalid)
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
@@ -277,8 +277,8 @@
PASS appearance: separator (invalid)
PASS appearance: sheet (invalid)
FAIL appearance: slider-vertical (invalid) assert_equals: style.appearance expected "" but got "slider-vertical"
-FAIL appearance: sliderthumb-horizontal (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-horizontal"
-FAIL appearance: sliderthumb-vertical (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-vertical"
+PASS appearance: sliderthumb-horizontal (invalid)
+PASS appearance: sliderthumb-vertical (invalid)
PASS appearance: snapshotted-plugin-overlay (invalid)
PASS appearance: spinner (invalid)
PASS appearance: spinner-downbutton (invalid)
Deleted: trunk/LayoutTests/platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt (294225 => 294226)
--- trunk/LayoutTests/platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,9 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {SPAN} at (0,0) size 20x20
- RenderBR {BR} at (20,5) size 0x19
- RenderBlock {SPAN} at (0,20) size 20x20
- RenderText {#text} at (0,0) size 0x0
Deleted: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294225 => 294226)
--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,345 +0,0 @@
-Test
-
-PASS -webkit-appearance: none
-PASS -webkit-appearance: auto
-PASS -webkit-appearance: button
-PASS -webkit-appearance: checkbox
-PASS -webkit-appearance: listbox
-PASS -webkit-appearance: menulist
-PASS -webkit-appearance: menulist-button
-PASS -webkit-appearance: meter
-PASS -webkit-appearance: progress-bar
-PASS -webkit-appearance: push-button
-PASS -webkit-appearance: radio
-PASS -webkit-appearance: searchfield
-PASS -webkit-appearance: slider-horizontal
-PASS -webkit-appearance: square-button
-PASS -webkit-appearance: textarea
-PASS -webkit-appearance: textfield
-PASS -webkit-appearance: bogus-button (invalid)
-FAIL -webkit-appearance: attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "attachment"
-PASS -webkit-appearance: button-bevel (invalid)
-FAIL -webkit-appearance: borderless-attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "borderless-attachment"
-PASS -webkit-appearance: button-arrow-down (invalid)
-PASS -webkit-appearance: button-arrow-next (invalid)
-PASS -webkit-appearance: button-arrow-previous (invalid)
-PASS -webkit-appearance: button-arrow-up (invalid)
-PASS -webkit-appearance: button-focus (invalid)
-PASS -webkit-appearance: caps-lock-indicator (invalid)
-PASS -webkit-appearance: caret (invalid)
-PASS -webkit-appearance: checkbox-container (invalid)
-PASS -webkit-appearance: checkbox-label (invalid)
-PASS -webkit-appearance: checkmenuitem (invalid)
-PASS -webkit-appearance: color-well (invalid)
-FAIL -webkit-appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "continuous-capacity-level-indicator"
-FAIL -webkit-appearance: default-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "default-button"
-FAIL -webkit-appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "discrete-capacity-level-indicator"
-PASS -webkit-appearance: dualbutton (invalid)
-PASS -webkit-appearance: groupbox (invalid)
-PASS -webkit-appearance: image-controls-button (invalid)
-FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
-PASS -webkit-appearance: list-button (invalid)
-PASS -webkit-appearance: listitem (invalid)
-PASS -webkit-appearance: media-controls-background (invalid)
-FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
-PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
-FAIL -webkit-appearance: media-controls-light-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-light-bar-background"
-PASS -webkit-appearance: media-current-time-display (invalid)
-PASS -webkit-appearance: media-enter-fullscreen-button (invalid)
-PASS -webkit-appearance: media-exit-fullscreen-button (invalid)
-FAIL -webkit-appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider"
-FAIL -webkit-appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-fullscreen-volume-slider-thumb"
-PASS -webkit-appearance: media-mute-button (invalid)
-PASS -webkit-appearance: media-overlay-play-button (invalid)
-FAIL -webkit-appearance: media-play-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-play-button"
-PASS -webkit-appearance: media-return-to-realtime-button (invalid)
-PASS -webkit-appearance: media-rewind-button (invalid)
-PASS -webkit-appearance: media-seek-back-button (invalid)
-PASS -webkit-appearance: media-seek-forward-button (invalid)
-FAIL -webkit-appearance: media-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-slider"
-FAIL -webkit-appearance: media-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-sliderthumb"
-PASS -webkit-appearance: media-time-remaining-display (invalid)
-PASS -webkit-appearance: media-toggle-closed-captions-button (invalid)
-FAIL -webkit-appearance: media-volume-slider (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider"
-PASS -webkit-appearance: media-volume-slider-container (invalid)
-FAIL -webkit-appearance: media-volume-slider-mute-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-slider-mute-button"
-FAIL -webkit-appearance: media-volume-sliderthumb (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-volume-sliderthumb"
-PASS -webkit-appearance: menuarrow (invalid)
-PASS -webkit-appearance: menubar (invalid)
-PASS -webkit-appearance: menucheckbox (invalid)
-PASS -webkit-appearance: menuimage (invalid)
-PASS -webkit-appearance: menuitem (invalid)
-PASS -webkit-appearance: menuitemtext (invalid)
-PASS -webkit-appearance: menulist-text (invalid)
-PASS -webkit-appearance: menulist-textfield (invalid)
-PASS -webkit-appearance: menupopup (invalid)
-PASS -webkit-appearance: menuradio (invalid)
-PASS -webkit-appearance: menuseparator (invalid)
-PASS -webkit-appearance: meterbar (invalid)
-PASS -webkit-appearance: meterchunk (invalid)
-PASS -webkit-appearance: number-input (invalid)
-PASS -webkit-appearance: progress-bar-value (invalid)
-PASS -webkit-appearance: progressbar (invalid)
-PASS -webkit-appearance: progressbar-vertical (invalid)
-PASS -webkit-appearance: progresschunk (invalid)
-PASS -webkit-appearance: progresschunk-vertical (invalid)
-PASS -webkit-appearance: radio-container (invalid)
-PASS -webkit-appearance: radio-label (invalid)
-PASS -webkit-appearance: radiomenuitem (invalid)
-PASS -webkit-appearance: range (invalid)
-PASS -webkit-appearance: range-thumb (invalid)
-FAIL -webkit-appearance: rating-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "rating-level-indicator"
-FAIL -webkit-appearance: relevancy-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "relevancy-level-indicator"
-PASS -webkit-appearance: resizer (invalid)
-PASS -webkit-appearance: resizerpanel (invalid)
-PASS -webkit-appearance: scale-horizontal (invalid)
-PASS -webkit-appearance: scale-vertical (invalid)
-PASS -webkit-appearance: scalethumb-horizontal (invalid)
-PASS -webkit-appearance: scalethumb-vertical (invalid)
-PASS -webkit-appearance: scalethumbend (invalid)
-PASS -webkit-appearance: scalethumbstart (invalid)
-PASS -webkit-appearance: scalethumbtick (invalid)
-PASS -webkit-appearance: scrollbarbutton-down (invalid)
-PASS -webkit-appearance: scrollbarbutton-left (invalid)
-PASS -webkit-appearance: scrollbarbutton-right (invalid)
-PASS -webkit-appearance: scrollbarbutton-up (invalid)
-PASS -webkit-appearance: scrollbarthumb-horizontal (invalid)
-PASS -webkit-appearance: scrollbarthumb-vertical (invalid)
-PASS -webkit-appearance: scrollbartrack-horizontal (invalid)
-PASS -webkit-appearance: scrollbartrack-vertical (invalid)
-PASS -webkit-appearance: searchfield-cancel-button (invalid)
-PASS -webkit-appearance: searchfield-decoration (invalid)
-PASS -webkit-appearance: searchfield-results-button (invalid)
-PASS -webkit-appearance: searchfield-results-decoration (invalid)
-PASS -webkit-appearance: separator (invalid)
-PASS -webkit-appearance: sheet (invalid)
-FAIL -webkit-appearance: slider-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "slider-vertical"
-FAIL -webkit-appearance: sliderthumb-horizontal (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-horizontal"
-FAIL -webkit-appearance: sliderthumb-vertical (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "sliderthumb-vertical"
-PASS -webkit-appearance: snapshotted-plugin-overlay (invalid)
-PASS -webkit-appearance: spinner (invalid)
-PASS -webkit-appearance: spinner-downbutton (invalid)
-PASS -webkit-appearance: spinner-textfield (invalid)
-PASS -webkit-appearance: spinner-upbutton (invalid)
-PASS -webkit-appearance: splitter (invalid)
-PASS -webkit-appearance: statusbar (invalid)
-PASS -webkit-appearance: statusbarpanel (invalid)
-PASS -webkit-appearance: tab (invalid)
-PASS -webkit-appearance: tab-scroll-arrow-back (invalid)
-PASS -webkit-appearance: tab-scroll-arrow-forward (invalid)
-PASS -webkit-appearance: tabpanel (invalid)
-PASS -webkit-appearance: tabpanels (invalid)
-PASS -webkit-appearance: textfield-multiline (invalid)
-PASS -webkit-appearance: toolbar (invalid)
-PASS -webkit-appearance: toolbarbutton (invalid)
-PASS -webkit-appearance: toolbarbutton-dropdown (invalid)
-PASS -webkit-appearance: toolbargripper (invalid)
-PASS -webkit-appearance: toolbox (invalid)
-PASS -webkit-appearance: tooltip (invalid)
-PASS -webkit-appearance: treeheader (invalid)
-PASS -webkit-appearance: treeheadercell (invalid)
-PASS -webkit-appearance: treeheadersortarrow (invalid)
-PASS -webkit-appearance: treeitem (invalid)
-PASS -webkit-appearance: treeline (invalid)
-PASS -webkit-appearance: treetwisty (invalid)
-PASS -webkit-appearance: treetwistyopen (invalid)
-PASS -webkit-appearance: treeview (invalid)
-FAIL -webkit-appearance: -apple-pay-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "-apple-pay-button"
-PASS -webkit-appearance: -moz-win-borderless-glass (invalid)
-PASS -webkit-appearance: -moz-win-browsertabbar-toolbox (invalid)
-PASS -webkit-appearance: -moz-win-communications-toolbox (invalid)
-PASS -webkit-appearance: -moz-win-communicationstext (invalid)
-PASS -webkit-appearance: -moz-win-exclude-glass (invalid)
-PASS -webkit-appearance: -moz-win-glass (invalid)
-PASS -webkit-appearance: -moz-win-media-toolbox (invalid)
-PASS -webkit-appearance: -moz-window-button-box (invalid)
-PASS -webkit-appearance: -moz-window-button-box-maximized (invalid)
-PASS -webkit-appearance: -moz-window-button-close (invalid)
-PASS -webkit-appearance: -moz-window-button-maximize (invalid)
-PASS -webkit-appearance: -moz-window-button-minimize (invalid)
-PASS -webkit-appearance: -moz-window-button-restore (invalid)
-PASS -webkit-appearance: -moz-window-frame-bottom (invalid)
-PASS -webkit-appearance: -moz-window-frame-left (invalid)
-PASS -webkit-appearance: -moz-window-frame-right (invalid)
-PASS -webkit-appearance: -moz-window-titlebar (invalid)
-PASS -webkit-appearance: -moz-window-titlebar-maximized (invalid)
-PASS appearance: none
-PASS appearance: auto
-PASS appearance: button
-PASS appearance: checkbox
-PASS appearance: listbox
-PASS appearance: menulist
-PASS appearance: menulist-button
-PASS appearance: meter
-PASS appearance: progress-bar
-PASS appearance: push-button
-PASS appearance: radio
-PASS appearance: searchfield
-PASS appearance: slider-horizontal
-PASS appearance: square-button
-PASS appearance: textarea
-PASS appearance: textfield
-PASS appearance: bogus-button (invalid)
-FAIL appearance: attachment (invalid) assert_equals: style.appearance expected "" but got "attachment"
-PASS appearance: button-bevel (invalid)
-FAIL appearance: borderless-attachment (invalid) assert_equals: style.appearance expected "" but got "borderless-attachment"
-PASS appearance: button-arrow-down (invalid)
-PASS appearance: button-arrow-next (invalid)
-PASS appearance: button-arrow-previous (invalid)
-PASS appearance: button-arrow-up (invalid)
-PASS appearance: button-focus (invalid)
-PASS appearance: caps-lock-indicator (invalid)
-PASS appearance: caret (invalid)
-PASS appearance: checkbox-container (invalid)
-PASS appearance: checkbox-label (invalid)
-PASS appearance: checkmenuitem (invalid)
-PASS appearance: color-well (invalid)
-FAIL appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "continuous-capacity-level-indicator"
-FAIL appearance: default-button (invalid) assert_equals: style.appearance expected "" but got "default-button"
-FAIL appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "discrete-capacity-level-indicator"
-PASS appearance: dualbutton (invalid)
-PASS appearance: groupbox (invalid)
-PASS appearance: image-controls-button (invalid)
-FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
-PASS appearance: list-button (invalid)
-PASS appearance: listitem (invalid)
-PASS appearance: media-controls-background (invalid)
-FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
-PASS appearance: media-controls-fullscreen-background (invalid)
-FAIL appearance: media-controls-light-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-light-bar-background"
-PASS appearance: media-current-time-display (invalid)
-PASS appearance: media-enter-fullscreen-button (invalid)
-PASS appearance: media-exit-fullscreen-button (invalid)
-FAIL appearance: media-fullscreen-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider"
-FAIL appearance: media-fullscreen-volume-slider-thumb (invalid) assert_equals: style.appearance expected "" but got "media-fullscreen-volume-slider-thumb"
-PASS appearance: media-mute-button (invalid)
-PASS appearance: media-overlay-play-button (invalid)
-FAIL appearance: media-play-button (invalid) assert_equals: style.appearance expected "" but got "media-play-button"
-PASS appearance: media-return-to-realtime-button (invalid)
-PASS appearance: media-rewind-button (invalid)
-PASS appearance: media-seek-back-button (invalid)
-PASS appearance: media-seek-forward-button (invalid)
-FAIL appearance: media-slider (invalid) assert_equals: style.appearance expected "" but got "media-slider"
-FAIL appearance: media-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-sliderthumb"
-PASS appearance: media-time-remaining-display (invalid)
-PASS appearance: media-toggle-closed-captions-button (invalid)
-FAIL appearance: media-volume-slider (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider"
-PASS appearance: media-volume-slider-container (invalid)
-FAIL appearance: media-volume-slider-mute-button (invalid) assert_equals: style.appearance expected "" but got "media-volume-slider-mute-button"
-FAIL appearance: media-volume-sliderthumb (invalid) assert_equals: style.appearance expected "" but got "media-volume-sliderthumb"
-PASS appearance: menuarrow (invalid)
-PASS appearance: menubar (invalid)
-PASS appearance: menucheckbox (invalid)
-PASS appearance: menuimage (invalid)
-PASS appearance: menuitem (invalid)
-PASS appearance: menuitemtext (invalid)
-PASS appearance: menulist-text (invalid)
-PASS appearance: menulist-textfield (invalid)
-PASS appearance: menupopup (invalid)
-PASS appearance: menuradio (invalid)
-PASS appearance: menuseparator (invalid)
-PASS appearance: meterbar (invalid)
-PASS appearance: meterchunk (invalid)
-PASS appearance: number-input (invalid)
-PASS appearance: progress-bar-value (invalid)
-PASS appearance: progressbar (invalid)
-PASS appearance: progressbar-vertical (invalid)
-PASS appearance: progresschunk (invalid)
-PASS appearance: progresschunk-vertical (invalid)
-PASS appearance: radio-container (invalid)
-PASS appearance: radio-label (invalid)
-PASS appearance: radiomenuitem (invalid)
-PASS appearance: range (invalid)
-PASS appearance: range-thumb (invalid)
-FAIL appearance: rating-level-indicator (invalid) assert_equals: style.appearance expected "" but got "rating-level-indicator"
-FAIL appearance: relevancy-level-indicator (invalid) assert_equals: style.appearance expected "" but got "relevancy-level-indicator"
-PASS appearance: resizer (invalid)
-PASS appearance: resizerpanel (invalid)
-PASS appearance: scale-horizontal (invalid)
-PASS appearance: scale-vertical (invalid)
-PASS appearance: scalethumb-horizontal (invalid)
-PASS appearance: scalethumb-vertical (invalid)
-PASS appearance: scalethumbend (invalid)
-PASS appearance: scalethumbstart (invalid)
-PASS appearance: scalethumbtick (invalid)
-PASS appearance: scrollbarbutton-down (invalid)
-PASS appearance: scrollbarbutton-left (invalid)
-PASS appearance: scrollbarbutton-right (invalid)
-PASS appearance: scrollbarbutton-up (invalid)
-PASS appearance: scrollbarthumb-horizontal (invalid)
-PASS appearance: scrollbarthumb-vertical (invalid)
-PASS appearance: scrollbartrack-horizontal (invalid)
-PASS appearance: scrollbartrack-vertical (invalid)
-PASS appearance: searchfield-cancel-button (invalid)
-PASS appearance: searchfield-decoration (invalid)
-PASS appearance: searchfield-results-button (invalid)
-PASS appearance: searchfield-results-decoration (invalid)
-PASS appearance: separator (invalid)
-PASS appearance: sheet (invalid)
-FAIL appearance: slider-vertical (invalid) assert_equals: style.appearance expected "" but got "slider-vertical"
-FAIL appearance: sliderthumb-horizontal (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-horizontal"
-FAIL appearance: sliderthumb-vertical (invalid) assert_equals: style.appearance expected "" but got "sliderthumb-vertical"
-PASS appearance: snapshotted-plugin-overlay (invalid)
-PASS appearance: spinner (invalid)
-PASS appearance: spinner-downbutton (invalid)
-PASS appearance: spinner-textfield (invalid)
-PASS appearance: spinner-upbutton (invalid)
-PASS appearance: splitter (invalid)
-PASS appearance: statusbar (invalid)
-PASS appearance: statusbarpanel (invalid)
-PASS appearance: tab (invalid)
-PASS appearance: tab-scroll-arrow-back (invalid)
-PASS appearance: tab-scroll-arrow-forward (invalid)
-PASS appearance: tabpanel (invalid)
-PASS appearance: tabpanels (invalid)
-PASS appearance: textfield-multiline (invalid)
-PASS appearance: toolbar (invalid)
-PASS appearance: toolbarbutton (invalid)
-PASS appearance: toolbarbutton-dropdown (invalid)
-PASS appearance: toolbargripper (invalid)
-PASS appearance: toolbox (invalid)
-PASS appearance: tooltip (invalid)
-PASS appearance: treeheader (invalid)
-PASS appearance: treeheadercell (invalid)
-PASS appearance: treeheadersortarrow (invalid)
-PASS appearance: treeitem (invalid)
-PASS appearance: treeline (invalid)
-PASS appearance: treetwisty (invalid)
-PASS appearance: treetwistyopen (invalid)
-PASS appearance: treeview (invalid)
-FAIL appearance: -apple-pay-button (invalid) assert_equals: style.appearance expected "" but got "-apple-pay-button"
-PASS appearance: -moz-win-borderless-glass (invalid)
-PASS appearance: -moz-win-browsertabbar-toolbox (invalid)
-PASS appearance: -moz-win-communications-toolbox (invalid)
-PASS appearance: -moz-win-communicationstext (invalid)
-PASS appearance: -moz-win-exclude-glass (invalid)
-PASS appearance: -moz-win-glass (invalid)
-PASS appearance: -moz-win-media-toolbox (invalid)
-PASS appearance: -moz-window-button-box (invalid)
-PASS appearance: -moz-window-button-box-maximized (invalid)
-PASS appearance: -moz-window-button-close (invalid)
-PASS appearance: -moz-window-button-maximize (invalid)
-PASS appearance: -moz-window-button-minimize (invalid)
-PASS appearance: -moz-window-button-restore (invalid)
-PASS appearance: -moz-window-frame-bottom (invalid)
-PASS appearance: -moz-window-frame-left (invalid)
-PASS appearance: -moz-window-frame-right (invalid)
-PASS appearance: -moz-window-titlebar (invalid)
-PASS appearance: -moz-window-titlebar-maximized (invalid)
-PASS -ms-appearance (should not be supported)
-PASS mso-appearance (should not be supported)
-PASS -moz-appearance (should not be supported)
-PASS -o-appearance (should not be supported)
-PASS -xv-appearance (should not be supported)
-PASS -atsc-appearance (should not be supported)
-PASS -wap-appearance (should not be supported)
-PASS -khtml-appearance (should not be supported)
-PASS -konq-appearance (should not be supported)
-PASS -apple-appearance (should not be supported)
-PASS prince-appearance (should not be supported)
-PASS -ah-appearance (should not be supported)
-PASS -hp-appearance (should not be supported)
-PASS -ro-appearance (should not be supported)
-PASS -rim-appearance (should not be supported)
-PASS -tc-appearance (should not be supported)
-
Deleted: trunk/LayoutTests/platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt (294225 => 294226)
--- trunk/LayoutTests/platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,9 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {SPAN} at (0,0) size 17x17
- RenderBR {BR} at (17,3) size 0x18
- RenderBlock {SPAN} at (0,17) size 17x17
- RenderText {#text} at (0,0) size 0x0
Deleted: trunk/LayoutTests/platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt (294225 => 294226)
--- trunk/LayoutTests/platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,9 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {SPAN} at (0,0) size 7x15
- RenderBR {BR} at (7,15) size 0x0
- RenderBlock {SPAN} at (0,15) size 15x7
- RenderText {#text} at (0,0) size 0x0
Deleted: trunk/LayoutTests/platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt (294225 => 294226)
--- trunk/LayoutTests/platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/LayoutTests/platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,9 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {SPAN} at (0,0) size 7x15
- RenderBR {BR} at (7,15) size 0x0
- RenderBlock {SPAN} at (0,15) size 15x7
- RenderText {#text} at (0,0) size 0x0
Modified: trunk/Source/WebCore/ChangeLog (294225 => 294226)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 10:27:00 UTC (rev 294226)
@@ -1,3 +1,17 @@
+2022-05-16 Tim Nguyen <n...@apple.com>
+
+ [css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
+ https://bugs.webkit.org/show_bug.cgi?id=240448
+
+ Reviewed by Antti Koivisto.
+
+ Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ * css/CSSValueKeywords.in:
+ * platform/ThemeTypes.h:
+
2022-05-16 Youenn Fablet <you...@apple.com>
Make sure calling showNotification will extend the service worker lifetime
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (294225 => 294226)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2022-05-16 10:27:00 UTC (rev 294226)
@@ -469,9 +469,6 @@
case DefaultButtonPart:
m_value.valueID = CSSValueDefaultButton;
break;
- case InnerSpinButtonPart:
- m_value.valueID = CSSValueInnerSpinButton;
- break;
case ListboxPart:
m_value.valueID = CSSValueListbox;
break;
@@ -535,12 +532,6 @@
case SliderVerticalPart:
m_value.valueID = CSSValueSliderVertical;
break;
- case SliderThumbHorizontalPart:
- m_value.valueID = CSSValueSliderthumbHorizontal;
- break;
- case SliderThumbVerticalPart:
- m_value.valueID = CSSValueSliderthumbVertical;
- break;
case SearchFieldPart:
m_value.valueID = CSSValueSearchfield;
break;
@@ -570,6 +561,7 @@
#if ENABLE(SERVICE_CONTROLS)
case ImageControlsButtonPart:
#endif
+ case InnerSpinButtonPart:
#if ENABLE(DATALIST_ELEMENT)
case ListButtonPart:
#endif
@@ -577,6 +569,8 @@
case SearchFieldResultsDecorationPart:
case SearchFieldResultsButtonPart:
case SearchFieldCancelButtonPart:
+ case SliderThumbHorizontalPart:
+ case SliderThumbVerticalPart:
ASSERT_NOT_REACHED();
m_value.valueID = CSSValueNone;
break;
Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (294225 => 294226)
--- trunk/Source/WebCore/css/CSSValueKeywords.in 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in 2022-05-16 10:27:00 UTC (rev 294226)
@@ -840,7 +840,6 @@
square-button
button
default-button
-inner-spin-button
listbox
media-controls-dark-bar-background
media-controls-light-bar-background
@@ -858,8 +857,6 @@
progress-bar
slider-horizontal
slider-vertical
-sliderthumb-horizontal
-sliderthumb-vertical
searchfield
relevancy-level-indicator
continuous-capacity-level-indicator
Modified: trunk/Source/WebCore/platform/ThemeTypes.h (294225 => 294226)
--- trunk/Source/WebCore/platform/ThemeTypes.h 2022-05-16 08:18:23 UTC (rev 294225)
+++ trunk/Source/WebCore/platform/ThemeTypes.h 2022-05-16 10:27:00 UTC (rev 294226)
@@ -41,7 +41,6 @@
SquareButtonPart,
ButtonPart,
DefaultButtonPart,
- InnerSpinButtonPart,
ListboxPart,
MediaControlsDarkBarBackgroundPart,
MediaControlsLightBarBackgroundPart,
@@ -59,8 +58,6 @@
ProgressBarPart,
SliderHorizontalPart,
SliderVerticalPart,
- SliderThumbHorizontalPart,
- SliderThumbVerticalPart,
SearchFieldPart,
RelevancyLevelIndicatorPart,
ContinuousCapacityLevelIndicatorPart,
@@ -83,6 +80,7 @@
#if ENABLE(SERVICE_CONTROLS)
ImageControlsButtonPart,
#endif
+ InnerSpinButtonPart,
#if ENABLE(DATALIST_ELEMENT)
ListButtonPart,
#endif
@@ -89,7 +87,9 @@
SearchFieldDecorationPart,
SearchFieldResultsDecorationPart,
SearchFieldResultsButtonPart,
- SearchFieldCancelButtonPart
+ SearchFieldCancelButtonPart,
+ SliderThumbHorizontalPart,
+ SliderThumbVerticalPart
};
#if ENABLE(SERVICE_CONTROLS)
