Title: [294532] trunk/Tools/Scripts
- Revision
- 294532
- Author
- commit-qu...@webkit.org
- Date
- 2022-05-19 23:19:49 -0700 (Thu, 19 May 2022)
Log Message
Tests with an '-e' parameters in requireOptions fail with bytecode cache enabled
https://bugs.webkit.org/show_bug.cgi?id=218703
Patch by Xan López <x...@igalia.com> on 2022-05-19
Reviewed by Yusuke Suzuki.
Do not try to further tokenize the command parameters to the test run
in the bytecode cache helper script. This will just mess up things
like the '-e "foo bar"' extra options, and it's not needed.
* Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: do not tokenize the arguments to the script.
* Scripts/run-jsc-stress-tests: also run the bytecode cache tests on MIPS.
Canonical link: https://commits.webkit.org/250787@main
Modified Paths
Diff
Modified: trunk/Tools/Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh (294531 => 294532)
--- trunk/Tools/Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh 2022-05-20 05:49:27 UTC (rev 294531)
+++ trunk/Tools/Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh 2022-05-20 06:19:49 UTC (rev 294532)
@@ -25,10 +25,10 @@
mysys() {
set +e
- eval "$*"
+ "$@"
exitCode=$?
if [ $exitCode != 0 ]; then
- echo "Command '$*' failed"
+ echo "Command '$@' failed"
exit $exitCode
fi
}
@@ -35,7 +35,6 @@
fileTemplate=$1
shift
-rest="$@"
diskCachePath=$(mktemp -d -t "$fileTemplate")
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (294531 => 294532)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2022-05-20 05:49:27 UTC (rev 294531)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2022-05-20 06:19:49 UTC (rev 294532)
@@ -1004,8 +1004,7 @@
def bytecodeCacheTemplate
if ($hostOS == "darwin")
return "bytecode-cache"
- elsif ($hostOS == "linux" && $architecture != "mips")
- # FIXME: need to fix https://bugs.webkit.org/show_bug.cgi?id=218703 to enable this on Linux/MIPS.
+ elsif ($hostOS == "linux")
return "bytecode-cacheXXXXXX"
end
nil
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
