Title: [295290] trunk
Revision
295290
Author
wenson_hs...@apple.com
Date
2022-06-06 10:36:12 -0700 (Mon, 06 Jun 2022)

Log Message

REGRESSION (r291302): editing/secure-input tests fail when run while a password input is focused on the system
https://bugs.webkit.org/show_bug.cgi?id=241324
rdar://94184618

Reviewed by Alexey Proskuryakov.

The tests in `editing/secure-input` fail after the removal of `WebCoreTestShim` in r291302, if a
secure text field is focused anywhere on the system while the tests are running. This is because we
now call into the real system `IsSecureEventInputEnabled()` API during these tests, instead of the
shimmed version for testing.

Since interposing these API functions apparently doesn't work on M1 Macs, we can't use this
technique to ensure that these tests are robust moving forward; instead, introduce and use testing-
only SPI (and IPI) to consult whether or not we're currently editing a secure input.

See below for more details.

* Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
* Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm:
(-[WKWebView _secureEventInputEnabledForTesting]):

Add testing-only SPI on WKWebView to return whether or not we're in a secure input, as an
alternative to calling into the actual `IsSecureEventInputEnabled()` API.

* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView _secureEventInputEnabledForTesting]):
* Source/WebKitLegacy/mac/WebView/WebHTMLViewForTestingMac.h: Copied from Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h.

Add a testing-only header file that's internal (i.e. non-exported), but imported in DumpRenderTree
through a Source-relative header include path. At the moment, this only contains a method to check
whether or not we're currently editing a secure text input, as an alternative to calling into
`IsSecureEventInputEnabled()`.

* Tools/DumpRenderTree/TestRunner.cpp:
(getSecureEventInputIsEnabledCallback):
(TestRunner::isSecureEventInputEnabled const):

Adjust DumpRenderTree to consult `-[WebHTMLView _secureEventInputEnabledForTesting]`.

* Tools/DumpRenderTree/TestRunner.h:
* Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:

Add a relative include path on DumpRenderTree, so that we can use `WebHTMLViewForTestingMac.h` in
DumpRenderTree without having to introduce new WebKitLegacy SPI.

* Tools/DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::isSecureEventInputEnabled const):
* Tools/WebKitTestRunner/PlatformWebView.h:
(WTR::PlatformWebView::platformView const):
(WTR::PlatformWebView::platformWindow const):
(WTR::PlatformWebView::platformView): Deleted.
(WTR::PlatformWebView::platformWindow): Deleted.

Mark `platformView` const so that it can be invoked from `isSecureEventInputEnabled`, and also mark
`platformWindow` const for consistency.

* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
* Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::isSecureEventInputEnabled const):
* Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::isSecureEventInputEnabled const):
* Tools/WebKitTestRunner/libwpe/PlatformWebViewLibWPE.cpp:
(WTR::PlatformWebView::isSecureEventInputEnabled const):
* Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::isSecureEventInputEnabled const):

Add a new `isSecureEventInputEnabled` method on the `PlatformWebView`, and adjust WebKitTestRunner
to consult `-[WKWebView _secureEventInputEnabledForTesting]`.

* Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::isSecureEventInputEnabled const):

Canonical link: https://commits.webkit.org/251336@main

Modified Paths

Added Paths

Diff

Modified: trunk/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h (295289 => 295290)


--- trunk/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h	2022-06-06 17:36:12 UTC (rev 295290)
@@ -55,6 +55,8 @@
 - (void)_simulateMouseMove:(NSEvent *)event;
 - (void)_retrieveAccessibilityTreeData:(void (^)(NSData *, NSError *))completionHandler;
 
+@property (nonatomic, readonly) BOOL _secureEventInputEnabledForTesting;
+
 @end
 
 #endif // !TARGET_OS_IPHONE

Modified: trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm (295289 => 295290)


--- trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm	2022-06-06 17:36:12 UTC (rev 295290)
@@ -133,6 +133,11 @@
     });
 }
 
+- (BOOL)_secureEventInputEnabledForTesting
+{
+    return _impl->inSecureInputState();
+}
+
 @end
 
 #endif // PLATFORM(MAC)

Modified: trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj (295289 => 295290)


--- trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj	2022-06-06 17:36:12 UTC (rev 295290)
@@ -3,7 +3,7 @@
 	archiveVersion = 1;
 	classes = {
 	};
-	objectVersion = 51;
+	objectVersion = 52;
 	objects = {
 
 /* Begin PBXAggregateTarget section */
@@ -669,6 +669,7 @@
 		E4AEF97C1C0DF4BC00B01727 /* WebResourceLoadScheduler.h in Headers */ = {isa = PBXBuildFile; fileRef = E4AEF97A1C0DF4BC00B01727 /* WebResourceLoadScheduler.h */; };
 		ED5B9524111B725A00472298 /* WebLocalizableStrings.mm in Sources */ = {isa = PBXBuildFile; fileRef = ED5B9523111B725A00472298 /* WebLocalizableStrings.mm */; };
 		ED7F6D8B0980683500C235ED /* WebNSDataExtrasPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = ED7F6D8A0980683500C235ED /* WebNSDataExtrasPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		F439B1A1284D8C39003DE041 /* WebHTMLViewForTestingMac.h in Headers */ = {isa = PBXBuildFile; fileRef = F439B1A0284D8C39003DE041 /* WebHTMLViewForTestingMac.h */; };
 		F4C98E5D1DD6476F0012FDEC /* DOMHTMLElementPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = F4C98E5C1DD6476F0012FDEC /* DOMHTMLElementPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		F4F665C21DD67672007714B4 /* WebAutocapitalizeTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = F4F665C11DD67672007714B4 /* WebAutocapitalizeTypes.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		F834AAD70E64B1C700E2737C /* WebTextIterator.h in Headers */ = {isa = PBXBuildFile; fileRef = F834AAD50E64B1C700E2737C /* WebTextIterator.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -1530,6 +1531,7 @@
 		EDD1A5C605C83987008E3150 /* WebNSPrintOperationExtras.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebNSPrintOperationExtras.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
 		EDD1A5C705C83987008E3150 /* WebNSPrintOperationExtras.m */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.objc; path = WebNSPrintOperationExtras.m; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
 		EDE850CD06ECC79E005FAB05 /* WebPreferenceKeysPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebPreferenceKeysPrivate.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
+		F439B1A0284D8C39003DE041 /* WebHTMLViewForTestingMac.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WebHTMLViewForTestingMac.h; sourceTree = "<group>"; };
 		F4C98E5C1DD6476F0012FDEC /* DOMHTMLElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMHTMLElementPrivate.h; sourceTree = "<group>"; };
 		F4F665C11DD67672007714B4 /* WebAutocapitalizeTypes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebAutocapitalizeTypes.h; sourceTree = "<group>"; };
 		F508946902B71D59018A9CD4 /* WebNSViewExtras.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebNSViewExtras.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
@@ -2204,6 +2206,7 @@
 				F5A55DC702BAA2E8018635CC /* WebHTMLRepresentationPrivate.h */,
 				35081D9402B6D4D80ACA2ACA /* WebHTMLView.h */,
 				35081D9502B6D4D80ACA2ACA /* WebHTMLView.mm */,
+				F439B1A0284D8C39003DE041 /* WebHTMLViewForTestingMac.h */,
 				93185DB506679F42005D5E7E /* WebHTMLViewInternal.h */,
 				35081D9602B6D4D80ACA2ACA /* WebHTMLViewPrivate.h */,
 			);
@@ -3024,6 +3027,7 @@
 				939810550824BF01008DF038 /* WebHTMLRepresentation.h in Headers */,
 				939810560824BF01008DF038 /* WebHTMLRepresentationPrivate.h in Headers */,
 				939810570824BF01008DF038 /* WebHTMLView.h in Headers */,
+				F439B1A1284D8C39003DE041 /* WebHTMLViewForTestingMac.h in Headers */,
 				939810A10824BF01008DF038 /* WebHTMLViewInternal.h in Headers */,
 				939810580824BF01008DF038 /* WebHTMLViewPrivate.h in Headers */,
 				939810180824BF01008DF038 /* WebIconDatabase.h in Headers */,

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm (295289 => 295290)


--- trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm	2022-06-06 17:36:12 UTC (rev 295290)
@@ -7103,6 +7103,19 @@
 
 @end
 
+#if PLATFORM(MAC)
+
+@implementation WebHTMLView (TestingSupportMac)
+
+- (BOOL)_secureEventInputEnabledForTesting
+{
+    return _private->isInSecureInputState;
+}
+
+@end
+
+#endif // PLATFORM(MAC)
+
 // This is used by AppKit/TextKit. It should be possible to remove this once
 // -[NSAttributedString _documentFromRange:document:documentAttributes:subresources:] is removed.
 @implementation NSURL (WebDataURL)

Copied: trunk/Source/WebKitLegacy/mac/WebView/WebHTMLViewForTestingMac.h (from rev 295289, trunk/Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h) (0 => 295290)


--- trunk/Source/WebKitLegacy/mac/WebView/WebHTMLViewForTestingMac.h	                        (rev 0)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebHTMLViewForTestingMac.h	2022-06-06 17:36:12 UTC (rev 295290)
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2022 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+#if PLATFORM(MAC)
+
+#import <WebKit/WebHTMLView.h>
+
+@interface WebHTMLView (TestingSupportMac)
+@property (nonatomic, readonly) BOOL _secureEventInputEnabledForTesting;
+@end
+
+#endif // PLATFORM(MAC)

Modified: trunk/Tools/DumpRenderTree/TestRunner.cpp (295289 => 295290)


--- trunk/Tools/DumpRenderTree/TestRunner.cpp	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/DumpRenderTree/TestRunner.cpp	2022-06-06 17:36:12 UTC (rev 295290)
@@ -1634,7 +1634,7 @@
 static JSValueRef getSecureEventInputIsEnabledCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
 {
 #if PLATFORM(MAC) && !PLATFORM(IOS_FAMILY)
-    return JSValueMakeBoolean(context, IsSecureEventInputEnabled());
+    return JSValueMakeBoolean(context, static_cast<TestRunner*>(JSObjectGetPrivate(thisObject))->isSecureEventInputEnabled());
 #else
     return JSValueMakeBoolean(context, false);
 #endif
@@ -2372,3 +2372,12 @@
         m_shouldSwapToDefaultSessionOnNextNavigation = false;
     }
 }
+
+#if !PLATFORM(MAC)
+
+bool TestRunner::isSecureEventInputEnabled() const
+{
+    return false;
+}
+
+#endif

Modified: trunk/Tools/DumpRenderTree/TestRunner.h (295289 => 295290)


--- trunk/Tools/DumpRenderTree/TestRunner.h	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/DumpRenderTree/TestRunner.h	2022-06-06 17:36:12 UTC (rev 295290)
@@ -385,6 +385,8 @@
     bool didCancelClientRedirect() const { return m_didCancelClientRedirect; }
     void setDidCancelClientRedirect(bool value) { m_didCancelClientRedirect = value; }
 
+    bool isSecureEventInputEnabled() const;
+
 private:
     TestRunner(const std::string& testURL, const std::string& expectedPixelHash);
 

Modified: trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (295289 => 295290)


--- trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig	2022-06-06 17:36:12 UTC (rev 295290)
@@ -151,5 +151,5 @@
 WK_WHICH_BUILD_SYSTEM = $(inherited)legacy;
 
 HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport ForwardingHeaders $(HEADER_SEARCH_PATHS_$(WK_COCOA_TOUCH));
-HEADER_SEARCH_PATHS_ = mac/InternalHeaders $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport;
+HEADER_SEARCH_PATHS_ = mac/InternalHeaders $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport $(SRCROOT)/../../Source/WebKitLegacy/mac/WebView;
 HEADER_SEARCH_PATHS_cocoatouch = $(SDKROOT)/usr/local/include $(SDKROOT)/usr/local/include/WebCoreTestSupport $(SRCROOT)/../../Source/WebKit/Platform/spi/ios;

Modified: trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm (295289 => 295290)


--- trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/DumpRenderTree/mac/TestRunnerMac.mm	2022-06-06 17:36:12 UTC (rev 295290)
@@ -85,6 +85,10 @@
 #import <WebKit/WebDOMOperationsPrivate.h>
 #endif
 
+#if PLATFORM(MAC)
+#import "WebHTMLViewForTestingMac.h"
+#endif
+
 #if !PLATFORM(IOS_FAMILY)
 
 @interface CommandValidationTarget : NSObject <NSValidatedUserInterfaceItem>
@@ -1197,3 +1201,12 @@
     
     return imagesArray.count;
 }
+
+#if PLATFORM(MAC)
+
+bool TestRunner::isSecureEventInputEnabled() const
+{
+    return dynamic_objc_cast<WebHTMLView>(mainFrame.frameView.documentView)._secureEventInputEnabledForTesting;
+}
+
+#endif // PLATFORM(MAC)

Modified: trunk/Tools/WebKitTestRunner/PlatformWebView.h (295289 => 295290)


--- trunk/Tools/WebKitTestRunner/PlatformWebView.h	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/WebKitTestRunner/PlatformWebView.h	2022-06-06 17:36:12 UTC (rev 295290)
@@ -76,8 +76,8 @@
     ~PlatformWebView();
 
     WKPageRef page();
-    PlatformWKView platformView() { return m_view; }
-    PlatformWindow platformWindow() { return m_window; }
+    PlatformWKView platformView() const { return m_view; }
+    PlatformWindow platformWindow() const { return m_window; }
     static PlatformWindow keyWindow();
 
     enum class WebViewSizingMode {
@@ -103,6 +103,8 @@
     void selectChromeInputField();
     String getSelectedTextInChromeInputField();
 
+    bool isSecureEventInputEnabled() const;
+
     bool drawsBackground() const;
     void setDrawsBackground(bool);
 

Modified: trunk/Tools/WebKitTestRunner/TestInvocation.cpp (295289 => 295290)


--- trunk/Tools/WebKitTestRunner/TestInvocation.cpp	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/WebKitTestRunner/TestInvocation.cpp	2022-06-06 17:36:12 UTC (rev 295290)
@@ -908,13 +908,8 @@
         return nullptr;
     }
 
-    if (WKStringIsEqualToUTF8CString(messageName, "SecureEventInputIsEnabled")) {
-#if PLATFORM(MAC)
-        return adoptWK(WKBooleanCreate(IsSecureEventInputEnabled()));
-#else
-        return adoptWK(WKBooleanCreate(false));
-#endif
-    }
+    if (WKStringIsEqualToUTF8CString(messageName, "SecureEventInputIsEnabled"))
+        return adoptWK(WKBooleanCreate(TestController::singleton().mainWebView()->isSecureEventInputEnabled()));
 
     if (WKStringIsEqualToUTF8CString(messageName, "SetCustomUserAgent")) {
         WKPageSetCustomUserAgent(TestController::singleton().mainWebView()->page(), stringValue(messageBody));

Modified: trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp (295289 => 295290)


--- trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp	2022-06-06 17:36:12 UTC (rev 295290)
@@ -299,5 +299,10 @@
 {
 }
 
+bool PlatformWebView::isSecureEventInputEnabled() const
+{
+    return false;
+}
+
 } // namespace WTR
 

Modified: trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm (295289 => 295290)


--- trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm	2022-06-06 17:36:12 UTC (rev 295290)
@@ -438,4 +438,9 @@
     [platformView() setAllowsBackForwardNavigationGestures:enabled];
 }
 
+bool PlatformWebView::isSecureEventInputEnabled() const
+{
+    return false;
+}
+
 } // namespace WTR

Modified: trunk/Tools/WebKitTestRunner/libwpe/PlatformWebViewLibWPE.cpp (295289 => 295290)


--- trunk/Tools/WebKitTestRunner/libwpe/PlatformWebViewLibWPE.cpp	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/WebKitTestRunner/libwpe/PlatformWebViewLibWPE.cpp	2022-06-06 17:36:12 UTC (rev 295290)
@@ -157,4 +157,9 @@
 {
 }
 
+bool PlatformWebView::isSecureEventInputEnabled() const
+{
+    return false;
+}
+
 } // namespace WTR

Modified: trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm (295289 => 295290)


--- trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm	2022-06-06 17:36:12 UTC (rev 295290)
@@ -34,6 +34,7 @@
 #import <WebKit/WKPreferencesPrivate.h>
 #import <WebKit/WKWebViewConfiguration.h>
 #import <WebKit/WKWebViewPrivate.h>
+#import <WebKit/WKWebViewPrivateForTesting.h>
 #import <wtf/RetainPtr.h>
 #import <wtf/text/WTFString.h>
 
@@ -254,4 +255,9 @@
     [platformView() setAllowsBackForwardNavigationGestures:enabled];
 }
 
+bool PlatformWebView::isSecureEventInputEnabled() const
+{
+    return platformView()._secureEventInputEnabledForTesting;
+}
+
 } // namespace WTR

Modified: trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp (295289 => 295290)


--- trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp	2022-06-06 15:57:15 UTC (rev 295289)
+++ trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp	2022-06-06 17:36:12 UTC (rev 295290)
@@ -278,4 +278,9 @@
 {
 }
 
+bool PlatformWebView::isSecureEventInputEnabled() const
+{
+    return false;
+}
+
 } // namespace WTR
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to