Title: [295627] trunk/Source
- Revision
- 295627
- Author
- csaave...@igalia.com
- Date
- 2022-06-16 22:26:58 -0700 (Thu, 16 Jun 2022)
Log Message
Assorted build-time warnings fixes
https://bugs.webkit.org/show_bug.cgi?id=241681
Reviewed by Mark Lam.
* Source/_javascript_Core/bytecode/Repatch.cpp:
(JSC::linkPolymorphicCall): Use declared codeBlock variable.
* Source/_javascript_Core/runtime/TemporalPlainTime.cpp:
(JSC::roundTime): Fix function reaching end without return
value.
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::computeMinimumValue): Ditto.
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
Remove leftover variable.
Canonical link: https://commits.webkit.org/251632@main
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/bytecode/Repatch.cpp (295626 => 295627)
--- trunk/Source/_javascript_Core/bytecode/Repatch.cpp 2022-06-17 04:53:11 UTC (rev 295626)
+++ trunk/Source/_javascript_Core/bytecode/Repatch.cpp 2022-06-17 05:26:58 UTC (rev 295627)
@@ -1817,7 +1817,7 @@
ArityCheckMode arityCheck = ArityCheckNotRequired;
if (auto* codeBlock = callCase.codeBlock()) {
ASSERT(!variant.executable()->isHostFunction());
- if ((callFrame->argumentCountIncludingThis() < static_cast<size_t>(callCase.codeBlock()->numParameters()) || callLinkInfo.isVarargs()))
+ if ((callFrame->argumentCountIncludingThis() < static_cast<size_t>(codeBlock->numParameters()) || callLinkInfo.isVarargs()))
arityCheck = MustCheckArity;
}
Modified: trunk/Source/_javascript_Core/runtime/TemporalPlainTime.cpp (295626 => 295627)
--- trunk/Source/_javascript_Core/runtime/TemporalPlainTime.cpp 2022-06-17 04:53:11 UTC (rev 295626)
+++ trunk/Source/_javascript_Core/runtime/TemporalPlainTime.cpp 2022-06-17 05:26:58 UTC (rev 295627)
@@ -221,6 +221,8 @@
RELEASE_ASSERT_NOT_REACHED();
break;
}
+
+ return ISO8601::Duration();
}
ISO8601::PlainTime TemporalPlainTime::round(JSGlobalObject* globalObject, JSValue optionsValue) const
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (295626 => 295627)
--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp 2022-06-17 04:53:11 UTC (rev 295626)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp 2022-06-17 05:26:58 UTC (rev 295627)
@@ -191,6 +191,10 @@
case IntegerRange::OneAndGreater:
return 1.0;
}
+
+ RELEASE_ASSERT_NOT_REACHED();
+
+ return 0.0;
}
// MARK: Integer (Raw)
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp (295626 => 295627)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp 2022-06-17 04:53:11 UTC (rev 295626)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp 2022-06-17 05:26:58 UTC (rev 295627)
@@ -263,7 +263,6 @@
void FlexLayout::computeLogicalHeightForFlexItems(LogicalFlexItems& flexItems, const LineRange& lineRange, LayoutUnit availableSpace)
{
auto flexBoxAlignItems = flexBoxStyle().alignItems();
- auto lineHeight = LayoutUnit { };
for (size_t index = lineRange.begin(); index < lineRange.end(); ++index) {
auto& flexItem = flexItems[index];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
