Title: [295655] trunk/Source/WebCore/page/FocusController.cpp
- Revision
- 295655
- Author
- nmouchta...@apple.com
- Date
- 2022-06-17 20:57:40 -0700 (Fri, 17 Jun 2022)
Log Message
Assertion failed m_page.shouldSuppressScrollbarAnimations() in FocusController::setIsVisibleAndActiveInternal(bool)
https://bugs.webkit.org/show_bug.cgi?id=241609
Reviewed by Simon Fraser.
Revert to original assert after change in https://bugs.webkit.org/show_bug.cgi?id=238497. In the case of a scrollable
area with no scrollbars, m_scrollerImpPair is not nil, but its members _horizontalScrollerImp and _verticalScrollerImp
are nil, so presumably the NSScroller API handles this case correctly.
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setIsVisibleAndActiveInternal):
Canonical link: https://commits.webkit.org/251660@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/page/FocusController.cpp (295654 => 295655)
--- trunk/Source/WebCore/page/FocusController.cpp 2022-06-18 03:46:55 UTC (rev 295654)
+++ trunk/Source/WebCore/page/FocusController.cpp 2022-06-18 03:57:40 UTC (rev 295655)
@@ -963,10 +963,7 @@
continue;
for (auto& scrollableArea : *scrollableAreas) {
- if (!scrollableArea->scrollbarsCanBeActive())
- continue;
- ASSERT(m_page.shouldSuppressScrollbarAnimations());
-
+ ASSERT(scrollableArea->scrollbarsCanBeActive() || m_page.shouldSuppressScrollbarAnimations());
contentAreaDidShowOrHide(scrollableArea, contentIsVisible);
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
