Title: [88611] trunk/Source/WebCore
- Revision
- 88611
- Author
- msab...@apple.com
- Date
- 2011-06-11 23:01:25 -0700 (Sat, 11 Jun 2011)
Log Message
2011-06-11 Michael Saboff <msab...@apple.com>
Reviewed by James Robinson.
REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349
Made CHROMIUM platform specific values for cMaxInactiveFontData and
cTargetInactiveFontData to mitigate the current performance issue on Chromium
page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
so that 50 inactive fonts will be cleaned up at a time.
Change made to address existing Chromium performance test regression.
* platform/graphics/FontCache.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (88610 => 88611)
--- trunk/Source/WebCore/ChangeLog 2011-06-12 04:19:39 UTC (rev 88610)
+++ trunk/Source/WebCore/ChangeLog 2011-06-12 06:01:25 UTC (rev 88611)
@@ -1,3 +1,20 @@
+2011-06-11 Michael Saboff <msab...@apple.com>
+
+ Reviewed by James Robinson.
+
+ REGRESSION(88260): 10-50% performance regression across many page cyclers
+ https://bugs.webkit.org/show_bug.cgi?id=62349
+
+ Made CHROMIUM platform specific values for cMaxInactiveFontData and
+ cTargetInactiveFontData to mitigate the current performance issue on Chromium
+ page cycler tests. Made the chromium value for cMaxInactiveFontData 250 based
+ on recommendation from James Robinson. Changed cTargetInactiveFontData to 200
+ so that 50 inactive fonts will be cleaned up at a time.
+
+ Change made to address existing Chromium performance test regression.
+
+ * platform/graphics/FontCache.cpp:
+
2011-06-11 Adam Barth <aba...@webkit.org>
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/platform/graphics/FontCache.cpp (88610 => 88611)
--- trunk/Source/WebCore/platform/graphics/FontCache.cpp 2011-06-12 04:19:39 UTC (rev 88610)
+++ trunk/Source/WebCore/platform/graphics/FontCache.cpp 2011-06-12 06:01:25 UTC (rev 88611)
@@ -251,8 +251,13 @@
static FontDataCache* gFontDataCache = 0;
-const int cMaxInactiveFontData = 120; // Pretty Low Threshold
-const int cTargetInactiveFontData = 100;
+#if PLATFORM(CHROMIUM)
+const int cMaxInactiveFontData = 250;
+const int cTargetInactiveFontData = 200;
+#else
+const int cMaxInactiveFontData = 50; // Pretty Low Threshold
+const int cTargetInactiveFontData = 30;
+#endif
static ListHashSet<const SimpleFontData*>* gInactiveFontData = 0;
SimpleFontData* FontCache::getCachedFontData(const FontDescription& fontDescription, const AtomicString& family, bool checkingAlternateName, ShouldRetain shouldRetain)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
