Title: [91401] trunk/Source/_javascript_Core
Revision
91401
Author
oli...@apple.com
Date
2011-07-20 14:07:41 -0700 (Wed, 20 Jul 2011)

Log Message

Don't throw away code when JSGarbageCollect API is called
https://bugs.webkit.org/show_bug.cgi?id=64894

Reviewed by Sam Weinig.

Just call collectAllGarbage.  That will clean up all unneeded
code without causing any pathological recompilation problems.

* API/JSBase.cpp:
(JSGarbageCollect):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/JSBase.cpp (91400 => 91401)


--- trunk/Source/_javascript_Core/API/JSBase.cpp	2011-07-20 21:04:04 UTC (rev 91400)
+++ trunk/Source/_javascript_Core/API/JSBase.cpp	2011-07-20 21:07:41 UTC (rev 91401)
@@ -97,10 +97,8 @@
     APIEntryShim entryShim(exec, false);
 
     JSGlobalData& globalData = exec->globalData();
-    if (!globalData.heap.isBusy()) {
-        // releaseExecutableMemory forces a full GC
-        globalData.releaseExecutableMemory();
-    }
+    if (!globalData.heap.isBusy())
+        globalData.heap.collectAllGarbage();
 
     // FIXME: Perhaps we should trigger a second mark and sweep
     // once the garbage collector is done if this is called when

Modified: trunk/Source/_javascript_Core/ChangeLog (91400 => 91401)


--- trunk/Source/_javascript_Core/ChangeLog	2011-07-20 21:04:04 UTC (rev 91400)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-07-20 21:07:41 UTC (rev 91401)
@@ -1,5 +1,18 @@
 2011-07-20  Oliver Hunt  <oli...@apple.com>
 
+        Don't throw away code when JSGarbageCollect API is called
+        https://bugs.webkit.org/show_bug.cgi?id=64894
+
+        Reviewed by Sam Weinig.
+
+        Just call collectAllGarbage.  That will clean up all unneeded
+        code without causing any pathological recompilation problems.
+
+        * API/JSBase.cpp:
+        (JSGarbageCollect):
+
+2011-07-20  Oliver Hunt  <oli...@apple.com>
+
         Codeblock doesn't visit cached structures in global resolve instructions
         https://bugs.webkit.org/show_bug.cgi?id=64889
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to