Title: [94243] trunk/Source/WebCore
- Revision
- 94243
- Author
- commit-qu...@webkit.org
- Date
- 2011-08-31 16:06:05 -0700 (Wed, 31 Aug 2011)
Log Message
[Chromium] Switching between overlay and opaque scrollbars causes glitches
https://bugs.webkit.org/show_bug.cgi?id=62686
Patch by Sailesh Agrawal <s...@chromium.org> on 2011-08-31
Reviewed by Beth Dakin.
When switching from opaque scrollbars to overlay scrollbars the page content size wouldn't change leaving a empty region under the overlay scrollbar.
The problem was that we were relying on ScrollView::updateScrollbars() to kick off a layout. Unfortunately this doesn't happen because updateScrollbars doesn't distinguish between overlay and opaque scrollbars.
To fix this I'm explicitly invalidating the layout when ScrollView::scrollbarStyleChanged() is called.
No tests because there are no Mac 10.7 chromium bots yet. Bug 66504 will track the work to add these tests once the bots are in place.
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollbarStyleChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (94242 => 94243)
--- trunk/Source/WebCore/ChangeLog 2011-08-31 23:01:42 UTC (rev 94242)
+++ trunk/Source/WebCore/ChangeLog 2011-08-31 23:06:05 UTC (rev 94243)
@@ -1,3 +1,21 @@
+2011-08-31 Sailesh Agrawal <s...@chromium.org>
+
+ [Chromium] Switching between overlay and opaque scrollbars causes glitches
+ https://bugs.webkit.org/show_bug.cgi?id=62686
+
+ Reviewed by Beth Dakin.
+
+ When switching from opaque scrollbars to overlay scrollbars the page content size wouldn't change leaving a empty region under the overlay scrollbar.
+
+ The problem was that we were relying on ScrollView::updateScrollbars() to kick off a layout. Unfortunately this doesn't happen because updateScrollbars doesn't distinguish between overlay and opaque scrollbars.
+
+ To fix this I'm explicitly invalidating the layout when ScrollView::scrollbarStyleChanged() is called.
+
+ No tests because there are no Mac 10.7 chromium bots yet. Bug 66504 will track the work to add these tests once the bots are in place.
+
+ * platform/ScrollView.cpp:
+ (WebCore::ScrollView::scrollbarStyleChanged):
+
2011-08-31 Alexey Proskuryakov <a...@apple.com>
http/tests/eventsource/workers/eventsource-simple.html is a flaky crash because of
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (94242 => 94243)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2011-08-31 23:01:42 UTC (rev 94242)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2011-08-31 23:06:05 UTC (rev 94243)
@@ -939,6 +939,7 @@
void ScrollView::scrollbarStyleChanged()
{
+ contentsResized();
updateScrollbars(scrollOffset());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
