Title: [96430] trunk/Source/WebKit/chromium
- Revision
- 96430
- Author
- commit-qu...@webkit.org
- Date
- 2011-09-30 15:00:33 -0700 (Fri, 30 Sep 2011)
Log Message
[chromium] Pass a processed bool in WebCompositorClient::didHandleInputEvent to indicate if the event was processed
https://bugs.webkit.org/show_bug.cgi?id=69169
Patch by James Robinson <jam...@chromium.org> on 2011-09-30
Reviewed by Darin Fisher.
If the compositor does not process the input event the embedder might want to do something with it - for
example, if the input event type is part of a CTRL+T keyboard accelerator sequence the browser might want to
open a new tab. This passes that state through the didHandleInputEvent callback.
* public/WebCompositorClient.h:
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::handleInputEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (96429 => 96430)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-30 21:44:20 UTC (rev 96429)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-30 22:00:33 UTC (rev 96430)
@@ -1,3 +1,18 @@
+2011-09-30 James Robinson <jam...@chromium.org>
+
+ [chromium] Pass a processed bool in WebCompositorClient::didHandleInputEvent to indicate if the event was processed
+ https://bugs.webkit.org/show_bug.cgi?id=69169
+
+ Reviewed by Darin Fisher.
+
+ If the compositor does not process the input event the embedder might want to do something with it - for
+ example, if the input event type is part of a CTRL+T keyboard accelerator sequence the browser might want to
+ open a new tab. This passes that state through the didHandleInputEvent callback.
+
+ * public/WebCompositorClient.h:
+ * src/WebCompositorImpl.cpp:
+ (WebKit::WebCompositorImpl::handleInputEvent):
+
2011-09-30 Elliot Poger <epo...@google.com>
webkit->chromium DEPS roll 102910->103471
Modified: trunk/Source/WebKit/chromium/public/WebCompositorClient.h (96429 => 96430)
--- trunk/Source/WebKit/chromium/public/WebCompositorClient.h 2011-09-30 21:44:20 UTC (rev 96429)
+++ trunk/Source/WebKit/chromium/public/WebCompositorClient.h 2011-09-30 22:00:33 UTC (rev 96430)
@@ -32,7 +32,7 @@
public:
// Callbacks invoked from the compositor thread.
virtual void willShutdown() = 0;
- virtual void didHandleInputEvent() = 0;
+ virtual void didHandleInputEvent(bool processed) = 0;
protected:
virtual ~WebCompositorClient() { }
Modified: trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp (96429 => 96430)
--- trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp 2011-09-30 21:44:20 UTC (rev 96429)
+++ trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp 2011-09-30 22:00:33 UTC (rev 96430)
@@ -60,7 +60,7 @@
void WebCompositorImpl::handleInputEvent(const WebInputEvent& event)
{
// FIXME: Do something interesting with the event here.
- m_client->didHandleInputEvent();
+ m_client->didHandleInputEvent(false);
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
