Title: [96768] trunk/Tools
- Revision
- 96768
- Author
- le...@chromium.org
- Date
- 2011-10-05 17:00:30 -0700 (Wed, 05 Oct 2011)
Log Message
Improve the watchlist for threading entries.
https://bugs.webkit.org/show_bug.cgi?id=69463
Reviewed by Adam Barth.
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (96767 => 96768)
--- trunk/Tools/ChangeLog 2011-10-05 23:59:36 UTC (rev 96767)
+++ trunk/Tools/ChangeLog 2011-10-06 00:00:30 UTC (rev 96768)
@@ -1,3 +1,12 @@
+2011-10-05 David Levin <le...@chromium.org>
+
+ Improve the watchlist for threading entries.
+ https://bugs.webkit.org/show_bug.cgi?id=69463
+
+ Reviewed by Adam Barth.
+
+ * Scripts/webkitpy/common/config/watchlist:
+
2011-10-05 Adam Roben <aro...@apple.com>
Add tests for using RetainPtrs inside HashMap and HashSet
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (96767 => 96768)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-05 23:59:36 UTC (rev 96767)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-06 00:00:30 UTC (rev 96768)
@@ -8,11 +8,19 @@
"filename": r"Source/WebKit/chromium/public/.*"
},
"ThreadingFiles": {
- "filename": r"Source/_javascript_Core/wtf/ThreadSafeRefCounted\.h"
- r"|Source/_javascript_Core/wtf/Threading\.h",
+ "filename": r"Source/_javascript_Core/wtf/ThreadSpecific\..*"
+ r"|Source/_javascript_Core/wtf/ThreadSafeRefCounted\..*"
+ r"|Source/_javascript_Core/wtf/ThreadingPrimitives\..*"
+ r"|Source/_javascript_Core/wtf/Threading\..*"
+ r"|Source/WebCore/dom/CrossThreadTask\..*"
+ r"|Source/WebCore/platform/CrossThreadCopier\..*",
},
"ThreadingUsage": {
- "more": r"deprecatedTurnOffVerifier|crossThreadString|threadsafeCopy|ThreadSafeRefCounted|CrossThreadRefCounted",
+ # The intention of this regex is to detect places where people are using common threading mechanisms,
+ # so that one can look them over for common mistakes. This list is long and likely to get longer over time.
+ # Note the negative look-ahead to avoid new mentions of the files (for builds or includes).
+ "more": r"(AllowCrossThreadAccess|AtomicallyInitialize|CrossThreadCopier|CrossThreadRefCounted|Mutex|ReadWriteLock|ThreadCondition|ThreadSafeRefCounted|ThreadSpecific"
+ r"|createCallbackTask|crossThreadString|deprecatedTurnOffVerifier|threadsafeCopy)(?!\.(h|cpp))",
},
"WatchListScript": {
"filename": r"Tools/Scripts/webkitpy/common/watchlist/.*",
@@ -24,8 +32,8 @@
"filename": r"Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/.*",
},
"SecurityCritical": {
- "more": r"[Ss]ecurityOrigin(?!\.(h|cpp)",
- "less": r"[Ss]ecurityOrigin(?!\.(h|cpp)",
+ "more": r"[Ss]ecurityOrigin(?!\.(h|cpp))",
+ "less": r"[Ss]ecurityOrigin(?!\.(h|cpp))",
"filename": r"XSS|[Ss]ecurity",
},
"V8Bindings": {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
