Title: [96794] trunk/Source/_javascript_Core
- Revision
- 96794
- Author
- fpi...@apple.com
- Date
- 2011-10-06 02:08:25 -0700 (Thu, 06 Oct 2011)
Log Message
SpeculativeJIT::isKnownString() is wrong
https://bugs.webkit.org/show_bug.cgi?id=69501
Reviewed by Oliver Hunt.
Removed the wrong case (GetLocal predicted String) and added a case that
works (StrCat).
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownString):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96793 => 96794)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-06 09:00:08 UTC (rev 96793)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-06 09:08:25 UTC (rev 96794)
@@ -1,3 +1,16 @@
+2011-10-05 Filip Pizlo <fpi...@apple.com>
+
+ SpeculativeJIT::isKnownString() is wrong
+ https://bugs.webkit.org/show_bug.cgi?id=69501
+
+ Reviewed by Oliver Hunt.
+
+ Removed the wrong case (GetLocal predicted String) and added a case that
+ works (StrCat).
+
+ * dfg/DFGSpeculativeJIT.h:
+ (JSC::DFG::SpeculativeJIT::isKnownString):
+
2011-10-05 Ryosuke Niwa <rn...@webkit.org>
Windows build fix attempt after r96760.
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (96793 => 96794)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2011-10-06 09:00:08 UTC (rev 96793)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2011-10-06 09:08:25 UTC (rev 96794)
@@ -592,11 +592,10 @@
bool isKnownString(NodeIndex op1)
{
- Node& node = m_jit.graph()[op1];
- switch (node.op) {
- case GetLocal:
- return isStringPrediction(node.variableAccessData()->prediction());
-
+ switch (m_jit.graph()[op1].op) {
+ case StrCat:
+ return true;
+
default:
return false;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
