Title: [98036] trunk/Source/WebKit/chromium
- Revision
- 98036
- Author
- commit-qu...@webkit.org
- Date
- 2011-10-20 16:23:13 -0700 (Thu, 20 Oct 2011)
Log Message
[chromium] Add a setVisibility method to WebGraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=68905
Patch by Michal Mocny <mmo...@google.com> on 2011-10-20
Reviewed by Kenneth Russell.
Added hooks for notifying WebGraphicsContext3D of surface visibility changes.
Useful for releasing various graphics resource.
* DEPS:
* public/WebGraphicsContext3D.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):
* tests/MockWebGraphicsContext3D.h:
(WebKit::MockWebGraphicsContext3D::setVisibility):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98035 => 98036)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-20 23:23:13 UTC (rev 98036)
@@ -1,3 +1,20 @@
+2011-10-20 Michal Mocny <mmo...@google.com>
+
+ [chromium] Add a setVisibility method to WebGraphicsContext3D.
+ https://bugs.webkit.org/show_bug.cgi?id=68905
+
+ Reviewed by Kenneth Russell.
+
+ Added hooks for notifying WebGraphicsContext3D of surface visibility changes.
+ Useful for releasing various graphics resource.
+
+ * DEPS:
+ * public/WebGraphicsContext3D.h:
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::setVisibilityState):
+ * tests/MockWebGraphicsContext3D.h:
+ (WebKit::MockWebGraphicsContext3D::setVisibility):
+
2011-10-20 Antoine Labour <pi...@chromium.org>
Export missing symbols from Web*Layer
Modified: trunk/Source/WebKit/chromium/DEPS (98035 => 98036)
--- trunk/Source/WebKit/chromium/DEPS 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/DEPS 2011-10-20 23:23:13 UTC (rev 98036)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '105970'
+ 'chromium_rev': '106342'
}
deps = {
Modified: trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h (98035 => 98036)
--- trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h 2011-10-20 23:23:13 UTC (rev 98036)
@@ -140,6 +140,9 @@
// Resizes the region into which this WebGraphicsContext3D is drawing.
virtual void reshape(int width, int height) = 0;
+ // Changes the visibility of the region
+ virtual void setVisibility(bool visible) = 0;
+
// Query whether it is built on top of compliant GLES2 implementation.
virtual bool isGLES2Compliant() = 0;
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (98035 => 98036)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-20 23:23:13 UTC (rev 98036)
@@ -2811,6 +2811,7 @@
if (!visible)
m_nonCompositedContentHost->protectVisibleTileTextures();
m_layerTreeHost->setVisible(visible);
+ graphicsContext3D()->setVisibility(visible);
}
#endif
}
Modified: trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h (98035 => 98036)
--- trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h 2011-10-20 23:19:55 UTC (rev 98035)
+++ trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h 2011-10-20 23:23:13 UTC (rev 98036)
@@ -43,6 +43,8 @@
virtual void reshape(int width, int height) { }
+ virtual void setVisibility(bool visible) { }
+
virtual bool isGLES2Compliant() { return false; }
virtual bool readBackFramebuffer(unsigned char* pixels, size_t bufferSize, WebGLId framebuffer, int width, int height) { return false; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
