Title: [98956] trunk
- Revision
- 98956
- Author
- apav...@chromium.org
- Date
- 2011-11-01 06:32:40 -0700 (Tue, 01 Nov 2011)
Log Message
Web Inspector: [Styles] Style-based CSS properties are editable and toggleable
https://bugs.webkit.org/show_bug.cgi?id=71275
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
LayoutTests:
* inspector/styles/styles-source-lines-expected.txt:
* inspector/styles/styles-update-from-js-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (98955 => 98956)
--- trunk/LayoutTests/ChangeLog 2011-11-01 13:09:51 UTC (rev 98955)
+++ trunk/LayoutTests/ChangeLog 2011-11-01 13:32:40 UTC (rev 98956)
@@ -1,3 +1,13 @@
+2011-11-01 Alexander Pavlov <apav...@chromium.org>
+
+ Web Inspector: [Styles] Style-based CSS properties are editable and toggleable
+ https://bugs.webkit.org/show_bug.cgi?id=71275
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/styles/styles-source-lines-expected.txt:
+ * inspector/styles/styles-update-from-js-expected.txt:
+
2011-10-18 Andrey Kosyakov <ca...@chromium.org>
Web Inspector: make extension tests pass on chromium
Modified: trunk/LayoutTests/inspector/styles/styles-source-lines-expected.txt (98955 => 98956)
--- trunk/LayoutTests/inspector/styles/styles-source-lines-expected.txt 2011-11-01 13:09:51 UTC (rev 98955)
+++ trunk/LayoutTests/inspector/styles/styles-source-lines-expected.txt 2011-11-01 13:32:40 UTC (rev 98956)
@@ -6,7 +6,6 @@
[expanded] #main, .at_line_50 { (styles-source-lines.html:50)
border: 1px solid
red;
-border-image: initial;
[expanded] #main, .at_line_43 { (styles-source-lines.html:43)
font-size: 10px;
Modified: trunk/LayoutTests/inspector/styles/styles-update-from-js-expected.txt (98955 => 98956)
--- trunk/LayoutTests/inspector/styles/styles-update-from-js-expected.txt 2011-11-01 13:09:51 UTC (rev 98955)
+++ trunk/LayoutTests/inspector/styles/styles-update-from-js-expected.txt 2011-11-01 13:32:40 UTC (rev 98956)
@@ -20,7 +20,6 @@
border-right-color: black;
border-bottom-color: black;
border-left-color: black;
-border-image: initial;
Modified: trunk/Source/WebCore/ChangeLog (98955 => 98956)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 13:09:51 UTC (rev 98955)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 13:32:40 UTC (rev 98956)
@@ -1,3 +1,13 @@
+2011-11-01 Alexander Pavlov <apav...@chromium.org>
+
+ Web Inspector: [Styles] Style-based CSS properties are editable and toggleable
+ https://bugs.webkit.org/show_bug.cgi?id=71275
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylePropertiesSection.prototype.onpopulate):
+
2011-11-01 Pavel Feldman <pfeld...@google.com>
Web Inspector: do not switch panels on Cmd + -> while in console.
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (98955 => 98956)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-11-01 13:09:51 UTC (rev 98955)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-11-01 13:32:40 UTC (rev 98956)
@@ -1025,7 +1025,7 @@
shorthandNames[property.shorthand] = true;
}
- // Collect all shorthand names.
+ // Create property tree elements.
for (var i = 0; i < this.uniqueProperties.length; ++i) {
var property = this.uniqueProperties[i];
var disabled = property.disabled;
@@ -1043,6 +1043,10 @@
property = new WebInspector.CSSProperty(style, style.allProperties.length, shorthand, style.getShorthandValue(shorthand), style.getShorthandPriority(shorthand), "style", true, true, "", undefined);
}
+ // BUG71275: Never show purely style-based properties in editable rules.
+ if (!shorthand && this.editable && property.styleBased)
+ continue;
+
var isShorthand = !!(property.isLive && (shorthand || shorthandNames[property.name]));
var inherited = this.isPropertyInherited(property.name);
var overloaded = this.isPropertyOverloaded(property.name, isShorthand);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
