Title: [99013] trunk/Source/WebCore
Revision
99013
Author
t...@chromium.org
Date
2011-11-01 16:58:57 -0700 (Tue, 01 Nov 2011)

Log Message

REGRESSION: -webkit-flex() should be an invalid value
https://bugs.webkit.org/show_bug.cgi?id=71320

Reviewed by Ojan Vafai.

This regressed in http://trac.webkit.org/changeset/98773 .

No new tests, covered by css3/flexbox/flex-parsing.html.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (99012 => 99013)


--- trunk/Source/WebCore/ChangeLog	2011-11-01 23:53:19 UTC (rev 99012)
+++ trunk/Source/WebCore/ChangeLog	2011-11-01 23:58:57 UTC (rev 99013)
@@ -1,3 +1,17 @@
+2011-11-01  Tony Chang  <t...@chromium.org>
+
+        REGRESSION: -webkit-flex() should be an invalid value
+        https://bugs.webkit.org/show_bug.cgi?id=71320
+
+        Reviewed by Ojan Vafai.
+
+        This regressed in http://trac.webkit.org/changeset/98773 .
+
+        No new tests, covered by css3/flexbox/flex-parsing.html.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseFlex):
+
 2011-11-01  David Grogan  <dgro...@chromium.org>
 
         IndexedDB: get EventQueue from ScriptExecutionContext instead of Document

Modified: trunk/Source/WebCore/css/CSSParser.cpp (99012 => 99013)


--- trunk/Source/WebCore/css/CSSParser.cpp	2011-11-01 23:53:19 UTC (rev 99012)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2011-11-01 23:58:57 UTC (rev 99013)
@@ -5093,7 +5093,7 @@
 #if ENABLE(CSS3_FLEXBOX)
     CSSParserValue* value = m_valueList->current();
     CSSParserValueList* args = value->function->args.get();
-    if (!equalIgnoringCase(value->function->name, "-webkit-flex(") || !args || args->size() > 3 || m_valueList->next())
+    if (!equalIgnoringCase(value->function->name, "-webkit-flex(") || !args || !args->size() || args->size() > 3 || m_valueList->next())
         return false;
 
     static const double unsetValue = -1;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to