Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 04c8018f9ff3545cd078536028a654d6ab2cc8d5 https://github.com/WebKit/WebKit/commit/04c8018f9ff3545cd078536028a654d6ab2cc8d5 Author: Yusuke Suzuki <ysuz...@apple.com> Date: 2022-10-27 (Thu, 27 Oct 2022)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/content-type-checking-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/import-css-module-basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/integrity-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/load-error-events-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/import-assertions/invalid-type-assertion-error-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/credentials.sub-expected.txt M Source/JavaScriptCore/parser/ModuleAnalyzer.cpp M Source/JavaScriptCore/parser/ModuleAnalyzer.h M Source/JavaScriptCore/parser/Nodes.h M Source/JavaScriptCore/parser/NodesAnalyzeModule.cpp M Source/JavaScriptCore/runtime/Completion.cpp M Source/JavaScriptCore/runtime/JSModuleLoader.cpp M Source/JavaScriptCore/runtime/ScriptFetchParameters.h Log Message: ----------- Validate import-assertions in static module imports https://bugs.webkit.org/show_bug.cgi?id=247102 rdar://101616551 Reviewed by Alexey Shvayka. This patch adds validation of import-assertions' invalid "type" field in static module imports (not dynamic-import). 1. "javascript" is not allowed. We remove this. 2. we validate "type" field in module analyzer, and throws a TypeError if it does not meet the requirement. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/import-assertions/invalid-type-assertion-error-expected.txt: * Source/JavaScriptCore/parser/ModuleAnalyzer.cpp: (JSC::ModuleAnalyzer::analyze): * Source/JavaScriptCore/parser/ModuleAnalyzer.h: (JSC::ModuleAnalyzer::fail): * Source/JavaScriptCore/parser/Nodes.h: * Source/JavaScriptCore/parser/NodesAnalyzeModule.cpp: (JSC::tryCreateAssertion): (JSC::ScopeNode::analyzeModule): (JSC::SourceElements::analyzeModule): (JSC::ImportDeclarationNode::analyzeModule): (JSC::ExportAllDeclarationNode::analyzeModule): (JSC::ExportDefaultDeclarationNode::analyzeModule): (JSC::ExportLocalDeclarationNode::analyzeModule): (JSC::ExportNamedDeclarationNode::analyzeModule): * Source/JavaScriptCore/runtime/Completion.cpp: (JSC::checkModuleSyntax): * Source/JavaScriptCore/runtime/JSModuleLoader.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/ScriptFetchParameters.h: (JSC::ScriptFetchParameters::parseType): Canonical link: https://commits.webkit.org/256075@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes