Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3b1f649acd18a6ac92fca48689c95faf5de23ebe
https://github.com/WebKit/WebKit/commit/3b1f649acd18a6ac92fca48689c95faf5de23ebe
Author: Ryan Haddad <ryanhad...@apple.com>
Date: 2023-04-07 (Fri, 07 Apr 2023)
Changed paths:
M Tools/CISupport/ews-build/config.json
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/loadConfig.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[ews-build] Split iOS layout test queue into no-WPT / only-WPT configurations
https://bugs.webkit.org/show_bug.cgi?id=254559
rdar://107291888
Reviewed by Jonathan Bedard.
The first iteration of this commit used new steps and factories to accomplish
the
no-WPT / only-WPT split, but if retries were required to determine if a failure
was
pre-existing the bots ended up running the whole suite.
Using the additional arguments approach instead will make sure the no-WPT /
only-WPT queues
behave as expected even in the retry case. These specific additional arguments
will be
removed in the RunWebKitTestsInStressMode so they don't interfere with the
intent of this
step running only the new or modified tests.
* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/factories.py:
(iOSTestsFactory):
(iOSTestsNoWPTFactory): Deleted.
(iOSTestsOnlyWPTFactory): Deleted.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/loadConfig.py:
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTestsInStressMode):
(RunWebKitTestsNoWPT): Deleted.
(RunWebKitTestsNoWPT.setLayoutTestCommand): Deleted.
(RunWebKitTestsOnlyWPT): Deleted.
(RunWebKitTestsOnlyWPT.setLayoutTestCommand): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestRunWebKitTestsInStressMode.test_success_additional_arguments): Add new
unit test.
(TestRunWebKitTestsNoWPT): Deleted.
(TestRunWebKitTestsNoWPT.setUp): Deleted.
(TestRunWebKitTestsNoWPT.tearDown): Deleted.
(TestRunWebKitTestsNoWPT.configureStep): Deleted.
(TestRunWebKitTestsNoWPT.test_success): Deleted.
(TestRunWebKitTestsOnlyWPT): Deleted.
(TestRunWebKitTestsOnlyWPT.setUp): Deleted.
(TestRunWebKitTestsOnlyWPT.tearDown): Deleted.
(TestRunWebKitTestsOnlyWPT.configureStep): Deleted.
(TestRunWebKitTestsOnlyWPT.test_success): Deleted.
Canonical link: https://commits.webkit.org/262714@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
