Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4142d950a6e7766786f1f3e2bd4650e3228628ec
https://github.com/WebKit/WebKit/commit/4142d950a6e7766786f1f3e2bd4650e3228628ec
Author: Simon Fraser <simon.fra...@apple.com>
Date: 2024-05-03 (Fri, 03 May 2024)
Changed paths:
M Source/WebCore/rendering/RenderBoxInlines.h
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderBoxModelObjectInlines.h
Log Message:
-----------
Rename "computedCSSPadding()" to "resolveLengthPercentage()"
https://bugs.webkit.org/show_bug.cgi?id=273672
rdar://problem/127473476
Reviewed by Tim Nguyen.
`computedCSSPadding()` was called for margin values in
`RenderBox::marginBoxRect()`,
so is clearly misnamed. It's really resolving the CSS `<length-percentage>`[1]
values
which use the container's logical width (which is true for margins and padding)
so name it thusly.
[1] https://drafts.csswg.org/css-values-4/#mixed-percentages
* Source/WebCore/rendering/RenderBoxInlines.h:
(WebCore::RenderBox::marginBoxRect const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderBoxModelObjectInlines.h:
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter const):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore const):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom const):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd const):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft const):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight const):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart const):
(WebCore::RenderBoxModelObject::computedCSSPaddingTop const):
(WebCore::RenderBoxModelObject::resolveLengthPercentageUsingContainerLogicalWidth
const):
(WebCore::RenderBoxModelObject::computedCSSPadding const): Deleted.
Canonical link: https://commits.webkit.org/278335@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
