Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c9e5ce1f2416cc8631758e33ab26db4e1d9e188 https://github.com/WebKit/WebKit/commit/4c9e5ce1f2416cc8631758e33ab26db4e1d9e188 Author: Fujii Hironori <hironori.fu...@sony.com> Date: 2024-01-22 (Mon, 22 Jan 2024)
Changed paths: M Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp M Source/WebKit/GPUProcess/graphics/wc/WCSceneContext.cpp Log Message: ----------- [Win] Crash in GLContext::makeContextCurrent under WCSceneContext::makeContextCurrent https://bugs.webkit.org/show_bug.cgi?id=264550 Reviewed by Don Olmstead. Running layout tests was randomly observing assertion failures in GPU process due to OpenGL context creation failures for Windows port. It was relatively reproducible with the following invocation: > python .\Tools\Scripts\run-webkit-tests --debug --iter=100 -f --no-retry > --no-show compositing/shared-backing/backing-sharing-compositing-change.html > compositing/shared-backing/move-sharing-child.html In that cases, the HWND was already closed in UI process. We have to check the GLContext validity and the return value of makeContextCurrent in GPU process. * Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp: * Source/WebKit/GPUProcess/graphics/wc/WCSceneContext.cpp: Canonical link: https://commits.webkit.org/273315@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes