Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4ddb4ae9f2b82d334dabab737be670f94edb54e7
https://github.com/WebKit/WebKit/commit/4ddb4ae9f2b82d334dabab737be670f94edb54e7
Author: Sam Sneddon <gsnedd...@apple.com>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
M Tools/Scripts/webkitpy/common/find_files.py
M
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py
M
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py
Log Message:
-----------
TestExpectations cannot represent variants with spaces
https://bugs.webkit.org/show_bug.cgi?id=269484
rdar://123026314
Reviewed by Jonathan Bedard.
This converts variants to always be percent-encoded (specifically: the variant
should be encoded identically to the output from the URL parser).
Along with this, this fixes various places where we only handled query variants
(and not fragment variants).
* Tools/Scripts/webkitpy/common/find_files.py:
(_normalized_find.sorted_paths_generator): Handle fragment variants
* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py:
(LayoutTestFinder._expand_variants): De-duplicate code, handle fragment passed
variants, percent encode everything
(LayoutTestFinder._percent_encoded_variant): Actually do percent encoding of
variants
*
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py:
Canonical link: https://commits.webkit.org/274749@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
