Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c5d9dcd77c99b8a3efbdbaa4be8271b3a60fd2f https://github.com/WebKit/WebKit/commit/6c5d9dcd77c99b8a3efbdbaa4be8271b3a60fd2f Author: Kimmo Kinnunen <kkinnu...@apple.com> Date: 2023-10-25 (Wed, 25 Oct 2023)
Changed paths: M Source/WebCore/platform/graphics/GraphicsContextGL.h M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.h M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h M Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm Log Message: ----------- GraphicsContextGLANGLE subclasses duplicate context state initialization https://bugs.webkit.org/show_bug.cgi?id=263585 rdar://117410801 Reviewed by Dan Glastonbury. Move the context state initialization to common GraphicsContextGLANGLE::initialize(). Adjust GraphicsContextGLANGLE::prepareTexture(), so that it too is common code. This way the code stays in sync for all the ports. This is work towards fixing premultipliedAlpha == false compositing. * Source/WebCore/platform/graphics/GraphicsContextGL.h: (WebCore::GraphicsContextGL::enableRequiredWebXRExtensions): * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLANGLE::initialize): (WebCore::GraphicsContextGLANGLE::prepareTexture): (WebCore::GraphicsContextGLANGLE::ensureExtensionEnabled): (WebCore::GraphicsContextGLANGLE::enableExtension): (WebCore::GraphicsContextGLANGLE::requestExtension): (WebCore::GraphicsContextGLANGLE::platformInitializeContext): Deleted. (WebCore::GraphicsContextGLANGLE::platformInitialize): Deleted. * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::platformInitialize): (WebCore::GraphicsContextGLCocoa::enableRequiredWebXRExtensions): (WebCore::GraphicsContextGLCocoa::enableRequiredWebXRExtensionsImpl): * Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp: (WebCore::GraphicsContextGLGBM::prepareForDisplay): (WebCore::GraphicsContextGLGBM::platformInitialize): (WebCore::GraphicsContextGLGBM::prepareTexture): Deleted. * Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.h: * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLTextureMapperANGLE::platformInitialize): (WebCore::GraphicsContextGLTextureMapperANGLE::swapCompositorTexture): (WebCore::GraphicsContextGLTextureMapperANGLE::prepareForDisplay): (WebCore::GraphicsContextGLTextureMapperANGLE::prepareTexture): Deleted. * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h: Canonical link: https://commits.webkit.org/269758@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes