Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e588a9dece40ae7e3df122b4a863823fd69b2cc2
      
https://github.com/WebKit/WebKit/commit/e588a9dece40ae7e3df122b4a863823fd69b2cc2
  Author: Asumu Takikawa <as...@igalia.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmSectionParser.cpp
    M Source/JavaScriptCore/wasm/WasmSectionParser.h
    M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp

  Log Message:
  -----------
  [Wasm-GC] Fix subtype hashing
https://bugs.webkit.org/show_bug.cgi?id=269024

Reviewed by Justin Michaud.

The main fix is to the hashing+equality calculation for sub types. This fixes a
test case derived from failures in real programs.

There are also some smaller cleanups/refactorings of the subtype checking code
as well.

* Source/JavaScriptCore/wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseType):
(JSC::Wasm::SectionParser::parseRecursionGroup):
(JSC::Wasm::SectionParser::checkSubtypeValidity):
(JSC::Wasm::SectionParser::parseSubtype):
* Source/JavaScriptCore/wasm/WasmSectionParser.h:
* Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp:
(JSC::Wasm::computeSubtypeHash):
(JSC::Wasm::SubtypeParameterTypes::equal):

Canonical link: https://commits.webkit.org/274555@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to