Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec5f9ff74cdb82bfaf65673ac04dc17babe7f440 https://github.com/WebKit/WebKit/commit/ec5f9ff74cdb82bfaf65673ac04dc17babe7f440 Author: Keith Miller <keith_mil...@apple.com> Date: 2024-04-25 (Thu, 25 Apr 2024)
Changed paths: M Tools/Scripts/webkitdirs.pm Log Message: ----------- Improve error message when we can't find Internal xcworkspace. https://bugs.webkit.org/show_bug.cgi?id=273253 rdar://127058846 Reviewed by Elliott Williams. I guess `Cwd::realpath` checks the path actually exists and returns undef if it doesn't. So if the internal workspace didn't exist then our error message would try to concatenate undef and error. I think we technically no longer need the `-e $configuredXcodeWorkspace` but I figure its better to be safe if different versions of perl have different behavior. * Tools/Scripts/webkitdirs.pm: (determineConfiguredXcodeWorkspaceOrDefault): Canonical link: https://commits.webkit.org/277996@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes