Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec9036933491f8f64f0f2c1c75736a2e125da1b9 https://github.com/WebKit/WebKit/commit/ec9036933491f8f64f0f2c1c75736a2e125da1b9 Author: Tim Nguyen <n...@apple.com> Date: 2023-05-05 (Fri, 05 May 2023)
Changed paths: A LayoutTests/fast/forms/date/date-validity-badinput-expected.txt A LayoutTests/fast/forms/date/date-validity-badinput.html A LayoutTests/fast/forms/datetimelocal/datetimelocal-validity-badinput-expected.txt A LayoutTests/fast/forms/datetimelocal/datetimelocal-validity-badinput.html A LayoutTests/fast/forms/resources/datetime-validity-badinput.js A LayoutTests/fast/forms/time/time-validity-badinput-expected.txt A LayoutTests/fast/forms/time/time-validity-badinput.html M LayoutTests/platform/ios-wk2/TestExpectations M Source/WebCore/html/BaseDateAndTimeInputType.cpp M Source/WebCore/html/BaseDateAndTimeInputType.h M Source/WebCore/html/shadow/DateTimeEditElement.cpp M Source/WebCore/html/shadow/DateTimeEditElement.h Log Message: ----------- `input.validity` reports `valid: true` for partially completed dates/times https://bugs.webkit.org/show_bug.cgi?id=248401 rdar://102984901 Reviewed by Aditya Keerthi. Porting over parts of: https://github.com/chromium/chromium/commit/f890442a85ed9791096348138eb305cd97b385b7 We should report badInput: true (and hence valid: false), when the input[type=date/time/datetime-local] are partially filled. * LayoutTests/fast/forms/date/date-validity-badinput-expected.txt: Added. * LayoutTests/fast/forms/date/date-validity-badinput.html: Added. * LayoutTests/fast/forms/datetimelocal/datetimelocal-validity-badinput-expected.txt: Added. * LayoutTests/fast/forms/datetimelocal/datetimelocal-validity-badinput.html: Added. * LayoutTests/fast/forms/resources/datetime-validity-badinput.js: Added. (testBadInput.test): (testBadInput): * LayoutTests/fast/forms/time/time-validity-badinput-expected.txt: Added. * LayoutTests/fast/forms/time/time-validity-badinput.html: Added. * LayoutTests/platform/ios-wk2/TestExpectations: * Source/WebCore/html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::hasBadInput const): * Source/WebCore/html/BaseDateAndTimeInputType.h: * Source/WebCore/html/shadow/DateTimeEditElement.cpp: (WebCore::DateTimeEditElement::editableFieldsHaveValues const): * Source/WebCore/html/shadow/DateTimeEditElement.h: Canonical link: https://commits.webkit.org/263748@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes