[webkit-changes] [191278] trunk/Source/WebKit2

[ossy]

Title: [191278] trunk/Source/WebKit2








Revision 191278
Author o...@webkit.org
Date 2015-10-18 23:49:28 -0700 (Sun, 18 Oct 2015)


Log Message
Fix the ENABLE(SECCOMP_FILTERS) build after r187030
https://bugs.webkit.org/show_bug.cgi?id=150172

Reviewed by Alexey Proskuryakov.

* Shared/linux/SeccompFilters/Syscall.cpp:
(WebKit::reportUnexpectedSyscall):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191277 => 191278)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 02:26:19 UTC (rev 191277)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 06:49:28 UTC (rev 191278)
@@ -1,3 +1,13 @@
+2015-10-18  Csaba Osztrogonác  
+
+Fix the ENABLE(SECCOMP_FILTERS) build after r187030
+https://bugs.webkit.org/show_bug.cgi?id=150172
+
+Reviewed by Alexey Proskuryakov.
+
+* Shared/linux/SeccompFilters/Syscall.cpp:
+(WebKit::reportUnexpectedSyscall):
+
 2015-10-18  Joonghun Park  
 
 [GTK] Remove WebKitContextMenu related missing annotation warnings


Modified: trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp (191277 => 191278)

--- trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp	2015-10-19 02:26:19 UTC (rev 191277)
+++ trunk/Source/WebKit2/Shared/linux/SeccompFilters/Syscall.cpp	2015-10-19 06:49:28 UTC (rev 191278)
@@ -65,15 +65,18 @@
 static void reportUnexpectedSyscall(unsigned syscall)
 {
 char buf[128];
-#if defined(__has_builtin) && __has_builtin(__builtin_strlen)
+#if defined(__has_builtin)
+#if __has_builtin(__builtin_strlen)
 // Buffer must be big enough for the literal, plus the number of digits in the largest possible
 // unsigned int, plus one for the newline, plus one more for the trailing null.
 static_assert(__builtin_strlen(message) + std::numeric_limits::digits10 + 2 < sizeof(buf), "Buffer too small");
 #endif
+#endif
 strcpy(buf, message);
 writeUnsignedInt(buf + strlen(buf), syscall);
 strcat(buf, "\n");
-write(STDERR_FILENO, buf, strlen(buf));
+int unused __attribute__((unused));
+unused = write(STDERR_FILENO, buf, strlen(buf));
 }
 
 std::unique_ptr Syscall::createFromContext(ucontext_t* ucontext)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191279] trunk/Source/WebKit2

[ossy]

Title: [191279] trunk/Source/WebKit2








Revision 191279
Author o...@webkit.org
Date 2015-10-19 00:08:06 -0700 (Mon, 19 Oct 2015)


Log Message
[WK2] Simplify unused return warning in WKRetainPtr.h
https://bugs.webkit.org/show_bug.cgi?id=150173

Reviewed by Darin Adler.

* UIProcess/API/cpp/WKRetainPtr.h:
(WebKit::__attribute__):
(WebKit::adoptWK): Deleted.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191278 => 191279)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 06:49:28 UTC (rev 191278)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 07:08:06 UTC (rev 191279)
@@ -1,5 +1,16 @@
 2015-10-18  Csaba Osztrogonác  
 
+[WK2] Simplify unused return warning in WKRetainPtr.h
+https://bugs.webkit.org/show_bug.cgi?id=150173
+
+Reviewed by Darin Adler.
+
+* UIProcess/API/cpp/WKRetainPtr.h:
+(WebKit::__attribute__):
+(WebKit::adoptWK): Deleted.
+
+2015-10-18  Csaba Osztrogonác  
+
 Fix the ENABLE(SECCOMP_FILTERS) build after r187030
 https://bugs.webkit.org/show_bug.cgi?id=150172
 


Modified: trunk/Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h (191278 => 191279)

--- trunk/Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h	2015-10-19 06:49:28 UTC (rev 191278)
+++ trunk/Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h	2015-10-19 07:08:06 UTC (rev 191279)
@@ -242,17 +242,8 @@
 return a != b.get(); 
 }
 
-#if defined(__GNUC__) && !(defined(__CC_ARM) || defined(__ARMCC__))
-#define WK_WARN_UNUSED_RETURN __attribute__((warn_unused_result))
-#else
-#define WK_WARN_UNUSED_RETURN
-#endif
-
-template inline WKRetainPtr adoptWK(T) WK_WARN_UNUSED_RETURN;
-
-#undef WK_WARN_UNUSED_RETURN
-
-template inline WKRetainPtr adoptWK(T o) 
+template inline WKRetainPtr adoptWK(T) __attribute__((warn_unused_result));
+template inline WKRetainPtr adoptWK(T o)
 {
 return WKRetainPtr(AdoptWK, o);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191280] trunk/Tools

[ossy]

Title: [191280] trunk/Tools








Revision 191280
Author o...@webkit.org
Date 2015-10-19 00:17:35 -0700 (Mon, 19 Oct 2015)


Log Message
Add historical addresses to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=150227

Reviewed by Darin Adler.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (191279 => 191280)

--- trunk/Tools/ChangeLog	2015-10-19 07:08:06 UTC (rev 191279)
+++ trunk/Tools/ChangeLog	2015-10-19 07:17:35 UTC (rev 191280)
@@ -1,3 +1,12 @@
+2015-10-19  Csaba Osztrogonác  
+
+Add historical addresses to contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=150227
+
+Reviewed by Darin Adler.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2015-10-18  Sungmann Cho  
 
 [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (191279 => 191280)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-10-19 07:08:06 UTC (rev 191279)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-10-19 07:17:35 UTC (rev 191280)
@@ -52,7 +52,8 @@
   "Ademar de Souza Reis Jr" : {
  "emails" : [
 "ade...@webkit.org",
-"ademar.r...@gmail.com"
+"ademar.r...@gmail.com",
+"ademar.r...@openbossa.org"
  ],
  "nicks" : [
 "ademar"
@@ -342,7 +343,8 @@
   "Balazs Kelemen" : {
  "emails" : [
 "kbal...@webkit.org",
-"b.kele...@sisa.samsung.com"
+"b.kele...@sisa.samsung.com",
+"b.kele...@samsung.com"
  ],
  "expertise" : "The QtWebKit Port, WebKit2",
  "nicks" : [
@@ -723,7 +725,8 @@
   },
   "Devin Rousso" : {
  "emails" : [
-"dcrousso+web...@gmail.com"
+"dcrousso+web...@gmail.com",
+"drou...@apple.com"
  ],
  "nicks" : [
 "drousso"
@@ -903,6 +906,7 @@
   },
   "Eunmi Lee" : {
  "emails" : [
+"eunmi15@samsung.com",
 "enmi@navercorp.com"
  ],
  "expertise" : "The EFLWebKit Port, Touch and Gesture",
@@ -1097,7 +1101,8 @@
   },
   "Helder Correia" : {
  "emails" : [
-"helder.corr...@nokia.com"
+"helder.corr...@nokia.com",
+"hel...@sencha.com"
  ],
  "expertise" : "The QtWebKit Port, Canvas",
  "nicks" : [
@@ -1157,7 +1162,8 @@
   "Igor Trindade Oliveira" : {
  "emails" : [
 "igor.olive...@webkit.org",
-"igo...@sisa.samsung.com"
+"igo...@sisa.samsung.com",
+"igor.olive...@openbossa.org"
  ],
  "expertise" : "Animations, Accelerated Compositing, WebKitEFL",
  "nicks" : [
@@ -1216,7 +1222,8 @@
   },
   "Jae Hyun Park" : {
  "emails" : [
-"jaep...@webkit.org"
+"jaep...@webkit.org",
+"jae.p...@company100.net"
  ],
  "nicks" : [
 "jaepark"
@@ -1225,7 +1232,8 @@
   "Jake Nielsen" : {
  "emails" : [
 "jake.nielsen.web...@gmail.com",
-"jacob_niel...@gmail.com"
+"jacob_niel...@gmail.com",
+"jacob_niel...@apple.com"
  ]
   },
   "Jakob Petsovits" : {
@@ -1365,7 +1373,8 @@
   },
   "Jeremy Jones" : {
  "emails" : [
-"jeremyj...@apple.com"
+"jeremyj...@apple.com",
+"jere...@apple.com"
  ],
  "nicks" : [
 "jeremyj"
@@ -1499,6 +1508,7 @@
   },
   "Jono Wells" : {
  "emails" : [
+"jonowe...@webkit.org",
 "jonowe...@me.com",
 "jonowe...@apple.com"
  ],
@@ -1510,7 +1520,8 @@
   "Joone Hur" : {
  "emails" : [
 "jo...@webkit.org",
-"joone@intel.com"
+"joone@intel.com",
+"joone@collabora.co.uk"
  ],
  "expertise" : "The WebKitGtk+ port",
  "nicks" : [
@@ -1547,7 +1558,8 @@
   },
   "Julien Brianceau" : {
  "emails" : [
-"jbria...@cisco.com"
+"jbria...@cisco.com",
+"julien.brianc...@gmail.com"
  ],
  "nicks" : [
 "jbrianceau"
@@ -1812,7 +1824,8 @@
 "leoy...@rim.com",
 "leoy...@blackberry.com",
 "leoy...@webkit.org",
-"leoyang.web...@gmail.com"
+"leoyang.web...@gmail.com",
+"leo.y...@torchmobile.com.cn"
  ],
  "expertise" : "The BlackBerry Port",
  "nicks" : [
@@ -1863,7 +1876,8 @@
   "Mahesh Kulkarni" : {
  "emails" : [

[webkit-changes] [191284] trunk/Source/WebKit2

[carlosgc]

Title: [191284] trunk/Source/WebKit2








Revision 191284
Author carlo...@webkit.org
Date 2015-10-19 02:48:51 -0700 (Mon, 19 Oct 2015)


Log Message
[GTK] ASSERTION FAILED: parent in WebInspectorProxy::platformDetach()
https://bugs.webkit.org/show_bug.cgi?id=150319

Reviewed by Žan Doberšek.

This happens when the inspector is shown/closed very
quickly. Since we start the inspector attached by default, when
the web inspector is created m_isAttached is set to true, so that
when opened, it's attached to the view. If the inspector is closed
before it has been actually attached, the inspector view doesn't
have a parent, even if the m_isAttached is true. So, we should
handle this case instead of asserting. This is what happens in
test http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html.

* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformDetach): Remove the view from
its parent container if it was actually attached.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191283 => 191284)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 09:46:01 UTC (rev 191283)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 09:48:51 UTC (rev 191284)
@@ -1,3 +1,23 @@
+2015-10-19  Carlos Garcia Campos  
+
+[GTK] ASSERTION FAILED: parent in WebInspectorProxy::platformDetach()
+https://bugs.webkit.org/show_bug.cgi?id=150319
+
+Reviewed by Žan Doberšek.
+
+This happens when the inspector is shown/closed very
+quickly. Since we start the inspector attached by default, when
+the web inspector is created m_isAttached is set to true, so that
+when opened, it's attached to the view. If the inspector is closed
+before it has been actually attached, the inspector view doesn't
+have a parent, even if the m_isAttached is true. So, we should
+handle this case instead of asserting. This is what happens in
+test http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html.
+
+* UIProcess/gtk/WebInspectorProxyGtk.cpp:
+(WebKit::WebInspectorProxy::platformDetach): Remove the view from
+its parent container if it was actually attached.
+
 2015-10-19  Hunseop Jeong  
 
 [EFL] Implement WebContextMenuProxyEfl::showContextMenu after r191194


Modified: trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp (191283 => 191284)

--- trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp	2015-10-19 09:46:01 UTC (rev 191283)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp	2015-10-19 09:48:51 UTC (rev 191284)
@@ -311,9 +311,11 @@
 
 GRefPtr inspectorView = m_inspectorView;
 if (!m_client.detach(this)) {
-GtkWidget* parent = gtk_widget_get_parent(m_inspectorView);
-ASSERT(parent);
-gtk_container_remove(GTK_CONTAINER(parent), m_inspectorView);
+// Detach is called when m_isAttached is true, but it could called before
+// the inspector is opened if the inspector is shown/closed quickly. So,
+// we might not have a parent yet.
+if (GtkWidget* parent = gtk_widget_get_parent(m_inspectorView))
+gtk_container_remove(GTK_CONTAINER(parent), m_inspectorView);
 }
 
 if (!m_isVisible)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191285] trunk

[youenn . fablet]

Title: [191285] trunk








Revision 191285
Author youenn.fab...@crf.canon.fr
Date 2015-10-19 03:09:07 -0700 (Mon, 19 Oct 2015)


Log Message
[Streams API] Implement ReadableStream tee
https://bugs.webkit.org/show_bug.cgi?id=146315

Reviewed by Darin Adler.

Source/WebCore:

Covered by rebased test.

* Modules/streams/ReadableStream.js:
(tee): Removing not implemented exception throwing.
* Modules/streams/ReadableStreamInternals.js:
(teeReadableStream): Implementing as per spec.
(teeReadableStreamPullFunction): Ditto.
(teeReadableStreamBranch2CancelFunction): Ditto.

LayoutTests:

* streams/reference-implementation/readable-stream-tee-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/streams/reference-implementation/readable-stream-tee-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/streams/ReadableStream.js
trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js




Diff

Modified: trunk/LayoutTests/ChangeLog (191284 => 191285)

--- trunk/LayoutTests/ChangeLog	2015-10-19 09:48:51 UTC (rev 191284)
+++ trunk/LayoutTests/ChangeLog	2015-10-19 10:09:07 UTC (rev 191285)
@@ -1,3 +1,12 @@
+2015-10-19  Youenn Fablet  
+
+[Streams API] Implement ReadableStream tee
+https://bugs.webkit.org/show_bug.cgi?id=146315
+
+Reviewed by Darin Adler.
+
+* streams/reference-implementation/readable-stream-tee-expected.txt:
+
 2015-10-19  Xabier Rodriguez Calvar  
 
 [Streams API] Add skeleton for initial WritableStream support


Modified: trunk/LayoutTests/streams/reference-implementation/readable-stream-tee-expected.txt (191284 => 191285)

--- trunk/LayoutTests/streams/reference-implementation/readable-stream-tee-expected.txt	2015-10-19 09:48:51 UTC (rev 191284)
+++ trunk/LayoutTests/streams/reference-implementation/readable-stream-tee-expected.txt	2015-10-19 10:09:07 UTC (rev 191285)
@@ -1,12 +1,12 @@
 
-FAIL ReadableStream teeing: rs.tee() returns an array of two ReadableStreams tee is not implemented
-FAIL ReadableStream teeing: should be able to read one branch to the end without affecting the other tee is not implemented
-FAIL ReadableStream teeing: values should be equal across each branch tee is not implemented
-FAIL ReadableStream teeing: errors in the source should propagate to both branches tee is not implemented
-FAIL ReadableStream teeing: canceling branch1 should not impact branch2 tee is not implemented
-FAIL ReadableStream teeing: canceling branch2 should not impact branch1 tee is not implemented
-FAIL ReadableStream teeing: canceling both branches should aggregate the cancel reasons into an array tee is not implemented
-FAIL ReadableStream teeing: failing to cancel the original stream should cause cancel() to reject on branches tee is not implemented
-FAIL ReadableStream teeing: closing the original should immediately close the branches tee is not implemented
-FAIL ReadableStream teeing: erroring the original should immediately error the branches tee is not implemented
+PASS ReadableStream teeing: rs.tee() returns an array of two ReadableStreams 
+PASS ReadableStream teeing: should be able to read one branch to the end without affecting the other 
+PASS ReadableStream teeing: values should be equal across each branch 
+PASS ReadableStream teeing: errors in the source should propagate to both branches 
+PASS ReadableStream teeing: canceling branch1 should not impact branch2 
+PASS ReadableStream teeing: canceling branch2 should not impact branch1 
+PASS ReadableStream teeing: canceling both branches should aggregate the cancel reasons into an array 
+PASS ReadableStream teeing: failing to cancel the original stream should cause cancel() to reject on branches 
+PASS ReadableStream teeing: closing the original should immediately close the branches 
+PASS ReadableStream teeing: erroring the original should immediately error the branches 
 


Modified: trunk/Source/WebCore/ChangeLog (191284 => 191285)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 09:48:51 UTC (rev 191284)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 10:09:07 UTC (rev 191285)
@@ -1,3 +1,19 @@
+2015-10-19  Youenn Fablet  
+
+[Streams API] Implement ReadableStream tee
+https://bugs.webkit.org/show_bug.cgi?id=146315
+
+Reviewed by Darin Adler.
+
+Covered by rebased test.
+
+* Modules/streams/ReadableStream.js:
+(tee): Removing not implemented exception throwing.
+* Modules/streams/ReadableStreamInternals.js:
+(teeReadableStream): Implementing as per spec.
+(teeReadableStreamPullFunction): Ditto.
+(teeReadableStreamBranch2CancelFunction): Ditto.
+
 2015-10-19  Xabier Rodriguez Calvar  
 
 [Streams API] Add skeleton for initial WritableStream support


Modified: trunk/Source/WebCore/Modules/streams/ReadableStream.js (191284 => 191285)

--- 

[webkit-changes] [191283] trunk

[calvaris]

Title: [191283] trunk








Revision 191283
Author calva...@igalia.com
Date 2015-10-19 02:46:01 -0700 (Mon, 19 Oct 2015)


Log Message
[Streams API] Add skeleton for initial WritableStream support
https://bugs.webkit.org/show_bug.cgi?id=149951

Reviewed by Darin Adler.

Source/WebCore:

This basically adds an empty WritableStream object without initializing the object. It also adds all empty
methods by raising an exception.

The reason why the object is not fully initialized is that it requires some other support and some refactorings
to share more code with ReadableStream and we will make in following patches.

Tests are covered by current set and their expectations are properly updated.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSBuiltins.h: Build infrastructure.
* Modules/streams/WritableStream.idl: Added all methods and attributes.
* Modules/streams/WritableStream.js:
(initializeWritableStream):
(abort):
(close):
(write):
(closed):
(ready):
(state): Added all by throwing an EvalError.

Source/WebInspectorUI:

* UserInterface/Models/NativeFunctionParameters.js: Added support for WritableStream.

LayoutTests:

Changed expectations to accomodate the WritableStream skeleton, including global-constructors-attributes.

* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:
* streams/reference-implementation/bad-strategies-expected.txt:
* streams/reference-implementation/bad-underlying-sinks-expected.txt:
* streams/reference-implementation/brand-checks-expected.txt:
* streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
* streams/reference-implementation/count-queuing-strategy-expected.txt:
* streams/reference-implementation/pipe-through-expected.txt:
* streams/reference-implementation/pipe-to-expected.txt:
* streams/reference-implementation/pipe-to-options-expected.txt:
* streams/reference-implementation/readable-stream-templated-expected.txt:
* streams/reference-implementation/writable-stream-abort-expected.txt:
* streams/reference-implementation/writable-stream-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/streams/reference-implementation/bad-strategies-expected.txt
trunk/LayoutTests/streams/reference-implementation/bad-underlying-sinks-expected.txt
trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt
trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy-expected.txt
trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt
trunk/LayoutTests/streams/reference-implementation/pipe-through-expected.txt
trunk/LayoutTests/streams/reference-implementation/pipe-to-expected.txt
trunk/LayoutTests/streams/reference-implementation/pipe-to-options-expected.txt
trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt
trunk/LayoutTests/streams/reference-implementation/writable-stream-abort-expected.txt
trunk/LayoutTests/streams/reference-implementation/writable-stream-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.cpp
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js


Added Paths

trunk/Source/WebCore/Modules/streams/WritableStream.idl
trunk/Source/WebCore/Modules/streams/WritableStream.js




Diff

Modified: trunk/LayoutTests/ChangeLog (191282 => 191283)

--- trunk/LayoutTests/ChangeLog	2015-10-19 09:13:43 UTC (rev 191282)
+++ 

[webkit-changes] [191288] trunk/Source/WebCore

[youenn . fablet]

Title: [191288] trunk/Source/WebCore








Revision 191288
Author youenn.fab...@crf.canon.fr
Date 2015-10-19 03:45:03 -0700 (Mon, 19 Oct 2015)


Log Message
Binding generator should generate names for JSBuiltins partial interface methods using ImplementedBy value
https://bugs.webkit.org/show_bug.cgi?id=150163

Reviewed by Darin Adler.

Covered by updated binding tests.

Updating generation of JS built-in function/attribute name to use the ImplementedBy value of the interface if any.
This allows splitting JS built-ins just like is done for IDLs.
Updated accordingly the JS Builtin header include.

* bindings/scripts/CodeGeneratorJS.pm:
(GetAttributeGetterName): Updated to pass function object and not only function name.
(GetAttributeSetterName): Ditto.
(GetFunctionName): Removed unneeded code plus updated to pass function object and not only function name.
(GenerateConstructorHelperMethods): Making direct use of GetJSBuiltinFunctionNameFromString since there is no function object for the constructor.
(GetJSBuiltinFunctionName): Updated to take into accound ImplementedBy value if any.
(GetJSBuiltinFunctionNameFromString):
(GetJSBuiltinScopeName): Returns either the interface name or its ImplementedBy value.
(AddJSBuiltinIncludesIfNeeded): Updating name of the header in case of partial interface.
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/ObjC/DOMTestInterface.h:
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
(-[DOMTestInterface builtinAttribute]):
(-[DOMTestInterface setBuiltinAttribute:]):
(-[DOMTestInterface builtinFunction]):
* bindings/scripts/test/TestSupplemental.idl: Added JSBuiltin attribute and function.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.h
trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestInterface.mm
trunk/Source/WebCore/bindings/scripts/test/TestSupplemental.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (191287 => 191288)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 10:36:42 UTC (rev 191287)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 10:45:03 UTC (rev 191288)
@@ -1,5 +1,35 @@
 2015-10-19  Youenn Fablet  
 
+Binding generator should generate names for JSBuiltins partial interface methods using ImplementedBy value
+https://bugs.webkit.org/show_bug.cgi?id=150163
+
+Reviewed by Darin Adler.
+
+Covered by updated binding tests.
+
+Updating generation of JS built-in function/attribute name to use the ImplementedBy value of the interface if any.
+This allows splitting JS built-ins just like is done for IDLs.
+Updated accordingly the JS Builtin header include.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GetAttributeGetterName): Updated to pass function object and not only function name.
+(GetAttributeSetterName): Ditto.
+(GetFunctionName): Removed unneeded code plus updated to pass function object and not only function name.
+(GenerateConstructorHelperMethods): Making direct use of GetJSBuiltinFunctionNameFromString since there is no function object for the constructor.
+(GetJSBuiltinFunctionName): Updated to take into accound ImplementedBy value if any.
+(GetJSBuiltinFunctionNameFromString):
+(GetJSBuiltinScopeName): Returns either the interface name or its ImplementedBy value.
+(AddJSBuiltinIncludesIfNeeded): Updating name of the header in case of partial interface.
+* bindings/scripts/test/JS/JSTestInterface.cpp:
+* bindings/scripts/test/ObjC/DOMTestInterface.h:
+* bindings/scripts/test/ObjC/DOMTestInterface.mm:
+(-[DOMTestInterface builtinAttribute]):
+(-[DOMTestInterface setBuiltinAttribute:]):
+(-[DOMTestInterface builtinFunction]):
+* bindings/scripts/test/TestSupplemental.idl: Added JSBuiltin attribute and function.
+
+2015-10-19  Youenn Fablet  
+
 Binding generator should allow generating private JS functions
 https://bugs.webkit.org/show_bug.cgi?id=150167
 


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (191287 => 191288)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2015-10-19 10:36:42 UTC (rev 191287)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2015-10-19 10:45:03 UTC (rev 191288)
@@ -11,6 +11,7 @@
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2013 Samsung Electronics. All rights reserved.
+# Copyright (C) 2015 Canon Inc. All rights reserved.
 #
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Library General Public
@@ -571,7 +572,7 @@
 return $codeGenerator->WK_lcfirst($className) . "Constructor" 

[webkit-changes] [191287] trunk/Source/WebCore

[youenn . fablet]

Title: [191287] trunk/Source/WebCore








Revision 191287
Author youenn.fab...@crf.canon.fr
Date 2015-10-19 03:36:42 -0700 (Mon, 19 Oct 2015)


Log Message
Binding generator should allow generating private JS functions
https://bugs.webkit.org/show_bug.cgi?id=150167

Reviewed by Darin Adler.

Introducing the "Private" keyword for that purpose.
Applying it to MediaDevices.getUserMedia which can be used directly or through navigator.webkitGetUserMedia
which could be implemented as JS builtin based on it.

"Private" functions are added to the prototype with a corresponding private symbol.
This symbol must be defined in bindings/js/WebCoreBuiltinNames.h.

Adding a getUserMediaFromJS function visible from builtins script.
Implementing MediaDevices.getUserMedia as a JS builtin based on it.

Adding binding generator test.

* CMakeLists.txt: Adding MediaDevices.js.
* DerivedSources.make: Ditto.
* Modules/mediastream/MediaDevices.h:
(WebCore::MediaDevices::getUserMediaFromJS):
* Modules/mediastream/MediaDevices.idl: Marking getUserMediaFromJS private and getUserMedia JSBuiltin.
* Modules/mediastream/MediaDevices.js: Added.
(getUserMedia):
* bindings/js/WebCoreBuiltinNames.h:
* bindings/js/WebCoreJSBuiltins.cpp:
* bindings/js/WebCoreJSBuiltins.h:
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::mediaDevicesBuiltins):
* bindings/scripts/CodeGeneratorGObject.pm: Skipping generation of Private functions.
(SkipFunction):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Disabling addition of private function in table and adding private member field to the prototype.
* bindings/scripts/CodeGeneratorObjC.pm: Skipping generation of Private functions.
(SkipFunction):
* bindings/scripts/IDLAttributes.txt: Adding Private keyword.
* bindings/scripts/test/JS/JSTestObj.cpp: Adding Private keyword test.
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjPrototypeFunctionPrivateMethod):
* bindings/scripts/test/TestObj.idl:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/mediastream/MediaDevices.h
trunk/Source/WebCore/Modules/mediastream/MediaDevices.idl
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp
trunk/Source/WebCore/bindings/js/WebCoreJSBuiltins.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl


Added Paths

trunk/Source/WebCore/Modules/mediastream/MediaDevices.js




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (191286 => 191287)

--- trunk/Source/WebCore/CMakeLists.txt	2015-10-19 10:16:58 UTC (rev 191286)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-10-19 10:36:42 UTC (rev 191287)
@@ -3363,6 +3363,7 @@
 set(IDL_ATTRIBUTES_FILE ${WEBCORE_DIR}/bindings/scripts/IDLAttributes.txt)
 
 set(WEBCORE_JS_BUILTINS
+${WEBCORE_DIR}/Modules/mediastream/MediaDevices.js
 ${WEBCORE_DIR}/Modules/streams/ByteLengthQueuingStrategy.js
 ${WEBCORE_DIR}/Modules/streams/CountQueuingStrategy.js
 ${WEBCORE_DIR}/Modules/streams/ReadableStream.js


Modified: trunk/Source/WebCore/ChangeLog (191286 => 191287)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 10:16:58 UTC (rev 191286)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 10:36:42 UTC (rev 191287)
@@ -1,5 +1,48 @@
 2015-10-19  Youenn Fablet  
 
+Binding generator should allow generating private JS functions
+https://bugs.webkit.org/show_bug.cgi?id=150167
+
+Reviewed by Darin Adler.
+
+Introducing the "Private" keyword for that purpose.
+Applying it to MediaDevices.getUserMedia which can be used directly or through navigator.webkitGetUserMedia
+which could be implemented as JS builtin based on it.
+
+"Private" functions are added to the prototype with a corresponding private symbol.
+This symbol must be defined in bindings/js/WebCoreBuiltinNames.h.
+
+Adding a getUserMediaFromJS function visible from builtins script.
+Implementing MediaDevices.getUserMedia as a JS builtin based on it.
+
+Adding binding generator test.
+
+* CMakeLists.txt: Adding MediaDevices.js.
+* DerivedSources.make: Ditto.
+* Modules/mediastream/MediaDevices.h:
+(WebCore::MediaDevices::getUserMediaFromJS):
+* Modules/mediastream/MediaDevices.idl: Marking getUserMediaFromJS private and getUserMedia JSBuiltin.
+* Modules/mediastream/MediaDevices.js: Added.
+(getUserMedia):
+* bindings/js/WebCoreBuiltinNames.h:
+* bindings/js/WebCoreJSBuiltins.cpp:
+* bindings/js/WebCoreJSBuiltins.h:
+

[webkit-changes] [191282] trunk/Source/WebKit2

[commit-queue]

Title: [191282] trunk/Source/WebKit2








Revision 191282
Author commit-qu...@webkit.org
Date 2015-10-19 02:13:43 -0700 (Mon, 19 Oct 2015)


Log Message
[EFL] Implement WebContextMenuProxyEfl::showContextMenu after r191194
https://bugs.webkit.org/show_bug.cgi?id=150310

Patch by Hunseop Jeong  on 2015-10-19
Reviewed by Gyuyoung Kim.

showContextMenu() doesn't work correctly after r191194 in EFL port.
This patch implements WebContextMenuProxyEfl::showContextMenu.

* UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::showContextMenu):
(WebKit::WebContextMenuProxyEfl::hideContextMenu):
* UIProcess/efl/WebContextMenuProxyEfl.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.cpp
trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191281 => 191282)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 08:56:28 UTC (rev 191281)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 09:13:43 UTC (rev 191282)
@@ -1,3 +1,19 @@
+2015-10-19  Hunseop Jeong  
+
+[EFL] Implement WebContextMenuProxyEfl::showContextMenu after r191194
+https://bugs.webkit.org/show_bug.cgi?id=150310
+
+Reviewed by Gyuyoung Kim.
+
+showContextMenu() doesn't work correctly after r191194 in EFL port.
+This patch implements WebContextMenuProxyEfl::showContextMenu.
+
+* UIProcess/efl/WebContextMenuProxyEfl.cpp:
+(WebKit::WebContextMenuProxyEfl::WebContextMenuProxyEfl):
+(WebKit::WebContextMenuProxyEfl::showContextMenu):
+(WebKit::WebContextMenuProxyEfl::hideContextMenu):
+* UIProcess/efl/WebContextMenuProxyEfl.h:
+
 2015-10-18  Csaba Osztrogonác  
 
 [WK2] Simplify unused return warning in WKRetainPtr.h


Modified: trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.cpp (191281 => 191282)

--- trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.cpp	2015-10-19 08:56:28 UTC (rev 191281)
+++ trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.cpp	2015-10-19 09:13:43 UTC (rev 191282)
@@ -28,7 +28,9 @@
 
 #if ENABLE(CONTEXT_MENUS)
 
+#include "APIContextMenuClient.h"
 #include "EwkView.h"
+#include "WebContextMenuItem.h"
 #include "WebContextMenuItemData.h"
 #include "WebPageProxy.h"
 #include 
@@ -37,8 +39,10 @@
 
 namespace WebKit {
 
-WebContextMenuProxyEfl::WebContextMenuProxyEfl(EwkView*, WebPageProxy&, const ContextMenuContextData& context, const UserData& userData)
+WebContextMenuProxyEfl::WebContextMenuProxyEfl(EwkView* ewkView, WebPageProxy& page, const ContextMenuContextData& context, const UserData& userData)
 : WebContextMenuProxy(context, userData)
+, m_ewkView(ewkView)
+, m_page(page)
 {
 }
 
@@ -48,7 +52,31 @@
 
 void WebContextMenuProxyEfl::showContextMenu()
 {
-notImplemented();
+Vector proposedAPIItems;
+for (auto& item : m_context.menuItems()) {
+if (item.action() != ContextMenuItemTagShareMenu)
+proposedAPIItems.append(WebContextMenuItem::create(item));
+}
+
+Vector clientItems;
+bool useProposedItems = true;
+
+if (m_page.contextMenuClient().getContextMenuFromProposedMenu(m_page, proposedAPIItems, clientItems, m_context.webHitTestResultData(), m_page.process().transformHandlesToObjects(m_userData.object()).get()))
+useProposedItems = false;
+
+const Vector& items = useProposedItems ? proposedAPIItems : clientItems;
+
+if (items.isEmpty())
+return;
+
+Vector menuItems;
+menuItems.reserveInitialCapacity(items.size());
+
+for (const auto& menuItem : items)
+menuItems.uncheckedAppend(menuItem);
+
+if (m_ewkView)
+m_ewkView->showContextMenu(toAPI(m_context.menuLocation()), toAPI(API::Array::create(WTF::move(menuItems)).ptr()));
 }
 
 void WebContextMenuProxyEfl::hideContextMenu()


Modified: trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.h (191281 => 191282)

--- trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.h	2015-10-19 08:56:28 UTC (rev 191281)
+++ trunk/Source/WebKit2/UIProcess/efl/WebContextMenuProxyEfl.h	2015-10-19 09:13:43 UTC (rev 191282)
@@ -54,6 +54,9 @@
 
 private:
 WebContextMenuProxyEfl(EwkView*, WebPageProxy&, const ContextMenuContextData&, const UserData&);
+
+EwkView* m_ewkView;
+WebPageProxy& m_page;
 };
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191281] trunk/Source/WebInspectorUI

[jcraig]

Title: [191281] trunk/Source/WebInspectorUI








Revision 191281
Author jcr...@apple.com
Date 2015-10-19 01:56:28 -0700 (Mon, 19 Oct 2015)


Log Message
Web Inspector: AX: console list 'input'/'output' markers are not perceivable
https://bugs.webkit.org/show_bug.cgi?id=133045

Enabling WebKit Web Inspector console pseudo-element labels using the new CSS4 'alt' property.

Reviewed by Brian Burg.

* UserInterface/Views/LogContentView.css:
(.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted.selected):
(.console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before):
(@media reader): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (191280 => 191281)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-10-19 07:17:35 UTC (rev 191280)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-10-19 08:56:28 UTC (rev 191281)
@@ -1,3 +1,17 @@
+2015-10-19  James Craig  
+
+Web Inspector: AX: console list 'input'/'output' markers are not perceivable
+https://bugs.webkit.org/show_bug.cgi?id=133045
+
+Enabling WebKit Web Inspector console pseudo-element labels using the new CSS4 'alt' property.
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/LogContentView.css: 
+(.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted.selected):
+(.console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before):
+(@media reader): Deleted.
+
 2015-10-18  Joseph Pecoraro  
 
 Web Inspector: Console Search should update when console is cleared


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (191280 => 191281)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-10-19 07:17:35 UTC (rev 191280)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2015-10-19 08:56:28 UTC (rev 191281)
@@ -199,13 +199,10 @@
 background-color: hsla(53, 83%, 53%, 0.75);
 }
 
-/* @media reader currently blocked by: http://webkit.org/b/118096 */
-@media reader {
-.console-user-command::before,
-.console-messages:focus .console-item.selected .console-user-command::before,
-.console-user-command-result.console-log-level::before,
-.console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before {
-/* accessible label alternative for icon indicating console input/output/warning/error, etc. */
-content: attr(data-labelprefix);
-}
+.console-user-command::before,
+.console-messages:focus .console-item.selected .console-user-command::before,
+.console-user-command-result.console-log-level::before,
+.console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before {
+/* Accessible label alternative for icon indicating console input/output/warning/error, etc. */
+alt: attr(data-labelprefix);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191289] trunk/Source/WebCore

[ossy]

Title: [191289] trunk/Source/WebCore








Revision 191289
Author o...@webkit.org
Date 2015-10-19 09:10:16 -0700 (Mon, 19 Oct 2015)


Log Message
Fix the !ENABLE(CSS_GRID_LAYOUT) build after r190840
https://bugs.webkit.org/show_bug.cgi?id=150322

Reviewed by Ryosuke Niwa.

* html/HTMLDetailsElement.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLDetailsElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (191288 => 191289)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 10:45:03 UTC (rev 191288)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 16:10:16 UTC (rev 191289)
@@ -1,3 +1,12 @@
+2015-10-19  Csaba Osztrogonác  
+
+Fix the !ENABLE(CSS_GRID_LAYOUT) build after r190840
+https://bugs.webkit.org/show_bug.cgi?id=150322
+
+Reviewed by Ryosuke Niwa.
+
+* html/HTMLDetailsElement.cpp:
+
 2015-10-19  Youenn Fablet  
 
 Binding generator should generate names for JSBuiltins partial interface methods using ImplementedBy value


Modified: trunk/Source/WebCore/html/HTMLDetailsElement.cpp (191288 => 191289)

--- trunk/Source/WebCore/html/HTMLDetailsElement.cpp	2015-10-19 10:45:03 UTC (rev 191288)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.cpp	2015-10-19 16:10:16 UTC (rev 191289)
@@ -32,6 +32,7 @@
 #include "ShadowRoot.h"
 #include "SlotAssignment.h"
 #include "Text.h"
+#include 
 
 namespace WebCore {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191311] trunk/Source/WebKit2

[timothy_horton]

Title: [191311] trunk/Source/WebKit2








Revision 191311
Author timothy_hor...@apple.com
Date 2015-10-19 13:07:50 -0700 (Mon, 19 Oct 2015)


Log Message
Try again to fix the 32-bit build.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191310 => 191311)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 20:07:37 UTC (rev 191310)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 20:07:50 UTC (rev 191311)
@@ -1,3 +1,10 @@
+2015-10-19  Tim Horton  
+
+Try again to fix the 32-bit build.
+
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::setupServicesMenu):
+
 2015-10-17  Wenson Hsieh  
 
 Extend fast-clicking behavior to trigger on elements that have negligible zoom


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm (191310 => 191311)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-19 20:07:37 UTC (rev 191310)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-19 20:07:50 UTC (rev 191311)
@@ -261,12 +261,12 @@
 auto cgImage = image->makeCGImage();
 auto nsImage = adoptNS([[NSImage alloc] initWithCGImage:cgImage.get() size:image->size()]);
 
-RetainPtr itemProvider;
 #ifdef __LP64__
-itemProvider = adoptNS([[NSItemProvider alloc] initWithItem:[nsImage TIFFRepresentation] typeIdentifier:(__bridge NSString *)kUTTypeTIFF]);
+auto itemProvider = adoptNS([[NSItemProvider alloc] initWithItem:[nsImage TIFFRepresentation] typeIdentifier:(__bridge NSString *)kUTTypeTIFF]);
+items = @[ itemProvider.get() ];
+#else
+items = @[ ];
 #endif
-
-items = @[ itemProvider.get() ];
 } else if (!context.controlledSelectionData().isEmpty()) {
 RetainPtr selectionData = adoptNS([[NSData alloc] initWithBytes:(void*)context.controlledSelectionData().data() length:context.controlledSelectionData().size()]);
 RetainPtr selection = adoptNS([[NSAttributedString alloc] initWithRTFD:selectionData.get() documentAttributes:nil]);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191316] trunk/Source/WebCore

[ossy]

Title: [191316] trunk/Source/WebCore








Revision 191316
Author o...@webkit.org
Date 2015-10-19 14:21:44 -0700 (Mon, 19 Oct 2015)


Log Message
Fix the binding generator after r191176
https://bugs.webkit.org/show_bug.cgi?id=150320

Reviewed by Darin Adler.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getConstructData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (191315 => 191316)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 20:39:47 UTC (rev 191315)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 21:21:44 UTC (rev 191316)
@@ -1,3 +1,15 @@
+2015-10-19  Csaba Osztrogonác  
+
+Fix the binding generator after r191176
+https://bugs.webkit.org/show_bug.cgi?id=150320
+
+Reviewed by Darin Adler.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateConstructorHelperMethods):
+* bindings/scripts/test/JS/JSTestInterface.cpp:
+(WebCore::JSTestInterfaceConstructor::getConstructData):
+
 2015-10-19  Commit Queue  
 
 Unreviewed, rolling out r191307.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (191315 => 191316)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2015-10-19 20:39:47 UTC (rev 191315)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2015-10-19 21:21:44 UTC (rev 191316)
@@ -4927,9 +4927,10 @@
 
 my $conditionalString = $codeGenerator->GenerateConstructorConditionalString($interface);
 if ($conditionalString) {
-push(@$outputArray, "template<> ConstructType ${constructorClassName}::getConstructData(JSCell*, ConstructData& constructData)\n");
+push(@$outputArray, "template<> ConstructType ${constructorClassName}::getConstructData(JSCell* cell, ConstructData& constructData)\n");
 push(@$outputArray, "{\n");
 push(@$outputArray, "#if $conditionalString\n");
+push(@$outputArray, "UNUSED_PARAM(cell);\n");
 push(@$outputArray, "constructData.native.function = construct;\n");
 push(@$outputArray, "return ConstructTypeHost;\n");
 push(@$outputArray, "#else\n");


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (191315 => 191316)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp	2015-10-19 20:39:47 UTC (rev 191315)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp	2015-10-19 21:21:44 UTC (rev 191316)
@@ -276,9 +276,10 @@
 reifyStaticProperties(vm, JSTestInterfaceConstructorTableValues, *this);
 }
 
-template<> ConstructType JSTestInterfaceConstructor::getConstructData(JSCell*, ConstructData& constructData)
+template<> ConstructType JSTestInterfaceConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
 {
 #if ENABLE(TEST_INTERFACE)
+UNUSED_PARAM(cell);
 constructData.native.function = construct;
 return ConstructTypeHost;
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191314] trunk/Source/WebCore

[commit-queue]

Title: [191314] trunk/Source/WebCore








Revision 191314
Author commit-qu...@webkit.org
Date 2015-10-19 13:32:30 -0700 (Mon, 19 Oct 2015)


Log Message
Unreviewed, rolling out r191295, r191297, and r191301.
https://bugs.webkit.org/show_bug.cgi?id=150337

ASSERTs in 5 tests (Requested by litherum on #webkit).

Reverted changesets:

"Host GraphicsContext's CTM inside GraphicsContextState"
https://bugs.webkit.org/show_bug.cgi?id=150146
http://trac.webkit.org/changeset/191295

"[iOS] Build fix after r191295"
http://trac.webkit.org/changeset/191297

"Unreviewed build fix after r191295."
http://trac.webkit.org/changeset/191301

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/Image.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h
trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.h
trunk/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp
trunk/Source/WebCore/platform/mac/DragImageMac.mm
trunk/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191313 => 191314)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 20:29:45 UTC (rev 191313)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 20:32:30 UTC (rev 191314)
@@ -1,3 +1,22 @@
+2015-10-19  Commit Queue  
+
+Unreviewed, rolling out r191295, r191297, and r191301.
+https://bugs.webkit.org/show_bug.cgi?id=150337
+
+ASSERTs in 5 tests (Requested by litherum on #webkit).
+
+Reverted changesets:
+
+"Host GraphicsContext's CTM inside GraphicsContextState"
+https://bugs.webkit.org/show_bug.cgi?id=150146
+http://trac.webkit.org/changeset/191295
+
+"[iOS] Build fix after r191295"
+http://trac.webkit.org/changeset/191297
+
+"Unreviewed build fix after r191295."
+http://trac.webkit.org/changeset/191301
+
 2015-10-16  Brian Burg  
 
 Unify handling of _javascript_Core scripts that are used in WebCore


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (191313 => 191314)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp	2015-10-19 20:29:45 UTC (rev 191313)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp	2015-10-19 20:32:30 UTC (rev 191314)
@@ -142,87 +142,6 @@
 restorePlatformState();
 }
 
-void GraphicsContext::concatCTM(const AffineTransform& other)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm *= other;
-concatPlatformCTM(other);
-
-checkCTMInvariants();
-}
-
-void GraphicsContext::scale(float x, float y)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm.scale(x, y);
-scalePlatformCTM(x, y);
-
-checkCTMInvariants();
-}
-
-void GraphicsContext::rotate(float angle)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm.rotate(rad2deg(angle));
-rotatePlatformCTM(angle);
-
-checkCTMInvariants();
-}
-
-void GraphicsContext::translate(float x, float y)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm.translate(x, y);
-translatePlatformCTM(x, y);
-
-checkCTMInvariants();
-}
-
-void GraphicsContext::setCTM(const AffineTransform& other)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm = other;
-setPlatformCTM(other);
-
-checkCTMInvariants();
-}
-
-AffineTransform GraphicsContext::getCTM(IncludeDeviceScale includeScale) const
-{
-if (paintingDisabled())
-return AffineTransform();
-
-AffineTransform result;
-if (includeScale == DefinitelyIncludeDeviceScale)
-result = m_state.userToDeviceSpaceCTM * m_state.ctm;
-else
-result = m_state.ctm;
-
-ASSERT(result.isEssentiallyEqualTo(getPlatformCTM(includeScale)));
-
-return result;
-}
-
 void GraphicsContext::drawRaisedEllipse(const FloatRect& rect, const Color& ellipseColor, ColorSpace ellipseColorSpace, const Color& shadowColor, ColorSpace shadowColorSpace)
 {
 if (paintingDisabled())
@@ -376,8 +295,6 @@
 {
 beginPlatformTransparencyLayer(opacity);
 ++m_transparencyCount;
-
-resetPlatformCTM();
 }
 
 void GraphicsContext::endTransparencyLayer()
@@ -737,8 +654,7 @@
 
 void GraphicsContext::applyDeviceScaleFactor(float deviceScaleFactor)
 {
-scale(deviceScaleFactor, deviceScaleFactor);
-
+scale(FloatSize(deviceScaleFactor, deviceScaleFactor));
 platformApplyDeviceScaleFactor(deviceScaleFactor);
 }
 


Modified: 

[webkit-changes] [191317] branches/safari-601-branch/Source/WebInspectorUI

[matthew_hanson]

Title: [191317] branches/safari-601-branch/Source/WebInspectorUI








Revision 191317
Author matthew_han...@apple.com
Date 2015-10-19 14:25:51 -0700 (Mon, 19 Oct 2015)


Log Message
Merge r190437. rdar://problem/23166302

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (191316 => 191317)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-19 21:21:44 UTC (rev 191316)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-10-19 21:25:51 UTC (rev 191317)
@@ -1,3 +1,27 @@
+2015-10-19  Matthew Hanson  
+
+Merge r190437. rdar://problem/23166302
+
+2015-10-01  Joseph Pecoraro  
+
+Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing _javascript_ and Events timeline
+https://bugs.webkit.org/show_bug.cgi?id=149726
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/NavigationSidebarPanel.js:
+(WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
+(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
+(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
+We were populating during filtering if there were any custom filters.
+However the TimelineSidebarPanel has custom filters (based on time and type)
+but those don't need to trigger population. Delay population until it
+would actually be needed (like a text search).
+
+* UserInterface/Views/TimelineSidebarPanel.js:
+(WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
+Do not populate on filter via this custom filters.
+
 2015-10-16  Matthew Hanson  
 
 Follow-up fix for r190246. rdar://problem/22939682


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (191316 => 191317)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js	2015-10-19 21:21:44 UTC (rev 191316)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js	2015-10-19 21:25:51 UTC (rev 191317)
@@ -292,6 +292,12 @@
 this._updateFilter();
 }
 
+shouldFilterPopulate()
+{
+// Overriden by subclasses if needed.
+return this.hasCustomFilters();
+}
+
 hasCustomFilters()
 {
 // Implemented by subclasses if needed.
@@ -520,7 +526,7 @@
 
 // Don't populate if we don't have any active filters.
 // We only need to populate when a filter needs to reveal.
-var dontPopulate = !this._filterBar.hasActiveFilters() && !this.hasCustomFilters();
+var dontPopulate = !this._filterBar.hasActiveFilters() && !this.shouldFilterPopulate();
 
 // Update the whole tree.
 var currentTreeElement = this._contentTreeOutline.children[0];
@@ -545,7 +551,7 @@
 {
 // Don't populate if we don't have any active filters.
 // We only need to populate when a filter needs to reveal.
-var dontPopulate = !this._filterBar.hasActiveFilters() && !this.hasCustomFilters();
+var dontPopulate = !this._filterBar.hasActiveFilters() && !this.shouldFilterPopulate();
 
 // Apply the filters to the tree element and its descendants.
 var currentTreeElement = treeElement;


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js (191316 => 191317)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js	2015-10-19 21:21:44 UTC (rev 191316)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js	2015-10-19 21:25:51 UTC (rev 191317)
@@ -381,6 +381,11 @@
 this._displayedContentView.filterDidChange();
 }
 
+shouldFilterPopulate()
+{
+return false;
+}
+
 hasCustomFilters()
 {
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191318] trunk/Source

[bdakin]

Title: [191318] trunk/Source








Revision 191318
Author bda...@apple.com
Date 2015-10-19 14:39:31 -0700 (Mon, 19 Oct 2015)


Log Message
Build fix.

Source/WebCore:

* dom/EventNames.in:
* dom/make_event_factory.pl:
(generateImplementation):

Source/WTF:

* wtf/FeatureDefines.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventNames.in
trunk/Source/WebCore/dom/make_event_factory.pl




Diff

Modified: trunk/Source/WTF/ChangeLog (191317 => 191318)

--- trunk/Source/WTF/ChangeLog	2015-10-19 21:25:51 UTC (rev 191317)
+++ trunk/Source/WTF/ChangeLog	2015-10-19 21:39:31 UTC (rev 191318)
@@ -1,3 +1,9 @@
+2015-10-19  Beth Dakin  
+
+Build fix.
+
+* wtf/FeatureDefines.h:
+
 2015-10-19  Tim Horton  
 
 Add magnify and rotate gesture event support for Mac


Modified: trunk/Source/WTF/wtf/FeatureDefines.h (191317 => 191318)

--- trunk/Source/WTF/wtf/FeatureDefines.h	2015-10-19 21:25:51 UTC (rev 191317)
+++ trunk/Source/WTF/wtf/FeatureDefines.h	2015-10-19 21:39:31 UTC (rev 191318)
@@ -110,10 +110,6 @@
 #define ENABLE_IOS_TOUCH_EVENTS 1
 #endif
 
-#if !defined(ENABLE_MAC_GESTURE_EVENTS) && USE(APPLE_INTERNAL_SDK)
-#define ENABLE_MAC_GESTURE_EVENTS 1
-#endif
-
 #if !defined(ENABLE_METER_ELEMENT)
 #define ENABLE_METER_ELEMENT 0
 #endif
@@ -264,6 +260,10 @@
 #define ENABLE_SHADOW_DOM 1
 #endif
 
+#if !defined(ENABLE_MAC_GESTURE_EVENTS) && USE(APPLE_INTERNAL_SDK)
+#define ENABLE_MAC_GESTURE_EVENTS 1
+#endif
+
 #endif /* PLATFORM(MAC) */
 
 /* - Apple Windows port - */


Modified: trunk/Source/WebCore/ChangeLog (191317 => 191318)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 21:25:51 UTC (rev 191317)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 21:39:31 UTC (rev 191318)
@@ -1,3 +1,11 @@
+2015-10-19  Beth Dakin  
+
+Build fix.
+
+* dom/EventNames.in:
+* dom/make_event_factory.pl:
+(generateImplementation):
+
 2015-10-19  Csaba Osztrogonác  
 
 Fix the binding generator after r191176


Modified: trunk/Source/WebCore/dom/EventNames.in (191317 => 191318)

--- trunk/Source/WebCore/dom/EventNames.in	2015-10-19 21:25:51 UTC (rev 191317)
+++ trunk/Source/WebCore/dom/EventNames.in	2015-10-19 21:39:31 UTC (rev 191318)
@@ -58,8 +58,7 @@
 CSSFontFaceLoadEvent conditional=FONT_LOAD_EVENTS
 SecurityPolicyViolationEvent conditional=CSP_NEXT
 UIRequestEvent conditional=INDIE_UI
-GestureEvent conditional=IOS_GESTURE_EVENTS
-GestureEvent conditional=MAC_GESTURE_EVENTS
+GestureEvent conditional=IOS_GESTURE_EVENTS|MAC_GESTURE_EVENTS
 WebKitPlaybackTargetAvailabilityEvent conditional=WIRELESS_PLAYBACK_TARGET
 GamepadEvent conditional=GAMEPAD
 


Modified: trunk/Source/WebCore/dom/make_event_factory.pl (191317 => 191318)

--- trunk/Source/WebCore/dom/make_event_factory.pl	2015-10-19 21:25:51 UTC (rev 191317)
+++ trunk/Source/WebCore/dom/make_event_factory.pl	2015-10-19 21:39:31 UTC (rev 191318)
@@ -98,7 +98,10 @@
 my $runtimeConditional = $parsedEvents{$eventName}{"runtimeConditional"};
 my $interfaceName = $InCompiler->interfaceForItem($eventName);
 
-print F "#if ENABLE($conditional)\n" if $conditional;
+if ($conditional) {
+my $conditionals = "#if ENABLE(" . join(") || ENABLE(", split("\\|", $conditional)) . ")";
+print F "$conditionals\n";
+}
 # FIXEME JSC should support RuntimeEnabledFeatures
 print F "if (equalIgnoringASCIICase(type, \"$eventName\"))\n";
 print F "return ${interfaceName}::create();\n";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191310] trunk/Source/WebCore

[simon . fraser]

Title: [191310] trunk/Source/WebCore








Revision 191310
Author simon.fra...@apple.com
Date 2015-10-19 13:07:37 -0700 (Mon, 19 Oct 2015)


Log Message
Add TextStream formatters for FillLayer and all it entails
https://bugs.webkit.org/show_bug.cgi?id=150312

Reviewed by Tim Horton.

Add TextStream output formatters for FillLayer, and all the enum
types used by it.

Drive-by fixes for CompositeOperator and BlendMode string conversions.
compositeOperatorNames was missing the "difference" string, and compositeOperatorName()
would do an OOB memory access if blendOp was zero.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/Length.cpp:
(WebCore::operator<<):
* platform/Length.h:
* platform/LengthSize.cpp: Added.
(WebCore::operator<<):
* platform/LengthSize.h:
* platform/text/TextStream.h:
* rendering/style/FillLayer.cpp:
(WebCore::operator<<):
* rendering/style/FillLayer.h:
* rendering/style/RenderStyleConstants.cpp: Added.
(WebCore::operator<<):
* rendering/style/RenderStyleConstants.h:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/Length.cpp
trunk/Source/WebCore/platform/Length.h
trunk/Source/WebCore/platform/LengthSize.h
trunk/Source/WebCore/platform/graphics/GraphicsTypes.cpp
trunk/Source/WebCore/platform/graphics/GraphicsTypes.h
trunk/Source/WebCore/platform/text/TextStream.h
trunk/Source/WebCore/rendering/style/FillLayer.cpp
trunk/Source/WebCore/rendering/style/FillLayer.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h


Added Paths

trunk/Source/WebCore/platform/LengthSize.cpp
trunk/Source/WebCore/rendering/style/RenderStyleConstants.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (191309 => 191310)

--- trunk/Source/WebCore/CMakeLists.txt	2015-10-19 19:53:45 UTC (rev 191309)
+++ trunk/Source/WebCore/CMakeLists.txt	2015-10-19 20:07:37 UTC (rev 191310)
@@ -2110,6 +2110,7 @@
 platform/KillRingNone.cpp
 platform/Language.cpp
 platform/Length.cpp
+platform/LengthSize.cpp
 platform/LinkHash.cpp
 platform/Logging.cpp
 platform/MIMETypeRegistry.cpp
@@ -2534,6 +2535,7 @@
 rendering/style/NinePieceImage.cpp
 rendering/style/QuotesData.cpp
 rendering/style/RenderStyle.cpp
+rendering/style/RenderStyleConstants.cpp
 rendering/style/SVGRenderStyle.cpp
 rendering/style/SVGRenderStyleDefs.cpp
 rendering/style/ShadowData.cpp


Modified: trunk/Source/WebCore/ChangeLog (191309 => 191310)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 19:53:45 UTC (rev 191309)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 20:07:37 UTC (rev 191310)
@@ -1,3 +1,33 @@
+2015-10-19  Simon Fraser  
+
+Add TextStream formatters for FillLayer and all it entails
+https://bugs.webkit.org/show_bug.cgi?id=150312
+
+Reviewed by Tim Horton.
+
+Add TextStream output formatters for FillLayer, and all the enum
+types used by it.
+
+Drive-by fixes for CompositeOperator and BlendMode string conversions.
+compositeOperatorNames was missing the "difference" string, and compositeOperatorName()
+would do an OOB memory access if blendOp was zero.
+
+* CMakeLists.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/Length.cpp:
+(WebCore::operator<<):
+* platform/Length.h:
+* platform/LengthSize.cpp: Added.
+(WebCore::operator<<):
+* platform/LengthSize.h:
+* platform/text/TextStream.h:
+* rendering/style/FillLayer.cpp:
+(WebCore::operator<<):
+* rendering/style/FillLayer.h:
+* rendering/style/RenderStyleConstants.cpp: Added.
+(WebCore::operator<<):
+* rendering/style/RenderStyleConstants.h:
+
 2015-10-19  Tim Horton  
 
 WKView being inside WKWebView leads to weird API issues


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (191309 => 191310)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2015-10-19 19:53:45 UTC (rev 191309)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2015-10-19 20:07:37 UTC (rev 191310)
@@ -580,6 +580,8 @@
 		0FEA3E84191B31BF000F1B55 /* ScrollingStateOverflowScrollingNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEA3E82191B31BF000F1B55 /* ScrollingStateOverflowScrollingNode.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		0FEA3E87191B3BD7000F1B55 /* ScrollingTreeFrameScrollingNode.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0FEA3E85191B3BD7000F1B55 /* ScrollingTreeFrameScrollingNode.cpp */; };
 		0FEA3E88191B3BD7000F1B55 /* ScrollingTreeFrameScrollingNode.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FEA3E86191B3BD7000F1B55 /* ScrollingTreeFrameScrollingNode.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		0FEF20CE1BD4A24100128E5D /* LengthSize.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 

[webkit-changes] [191315] trunk/Source

[commit-queue]

Title: [191315] trunk/Source








Revision 191315
Author commit-qu...@webkit.org
Date 2015-10-19 13:39:47 -0700 (Mon, 19 Oct 2015)


Log Message
Unreviewed, rolling out r191307.
https://bugs.webkit.org/show_bug.cgi?id=150338

broke lots of API tests, need time to figure out whats up
(Requested by thorton on #webkit).

Reverted changeset:

"WKView being inside WKWebView leads to weird API issues"
https://bugs.webkit.org/show_bug.cgi?id=150174
http://trac.webkit.org/changeset/191307

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.h
trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm
trunk/Source/WebKit2/UIProcess/mac/WKViewLayoutStrategy.h
trunk/Source/WebKit2/UIProcess/mac/WKViewLayoutStrategy.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Removed Paths

trunk/Source/WebCore/platform/spi/mac/NSWindowSPI.h
trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h
trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (191314 => 191315)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 20:32:30 UTC (rev 191314)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 20:39:47 UTC (rev 191315)
@@ -1,5 +1,19 @@
 2015-10-19  Commit Queue  
 
+Unreviewed, rolling out r191307.
+https://bugs.webkit.org/show_bug.cgi?id=150338
+
+broke lots of API tests, need time to figure out whats up
+(Requested by thorton on #webkit).
+
+Reverted changeset:
+
+"WKView being inside WKWebView leads to weird API issues"
+https://bugs.webkit.org/show_bug.cgi?id=150174
+http://trac.webkit.org/changeset/191307
+
+2015-10-19  Commit Queue  
+
 Unreviewed, rolling out r191295, r191297, and r191301.
 https://bugs.webkit.org/show_bug.cgi?id=150337
 


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (191314 => 191315)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2015-10-19 20:32:30 UTC (rev 191314)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2015-10-19 20:39:47 UTC (rev 191315)
@@ -1121,7 +1121,6 @@
 		2BE8E2C912A58A0100FAD550 /* HTMLMetaCharsetParser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2BE8E2C812A58A0100FAD550 /* HTMLMetaCharsetParser.cpp */; };
 		2D0B4AAB18DA1CCD00434DE1 /* IOSurface.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D0B4AA918DA1CCD00434DE1 /* IOSurface.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		2D0B4AAC18DA1CCD00434DE1 /* IOSurface.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2D0B4AAA18DA1CCD00434DE1 /* IOSurface.mm */; };
-		2D0CF8171BCF5DE1007A4937 /* NSWindowSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D0CF8161BCF5DE1007A4937 /* NSWindowSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		2D232C001A326F02006BF2DB /* TUCallSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D232BFF1A326EF9006BF2DB /* TUCallSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		2D25396218CE7F6200270222 /* ImageControlsButtonElementMac.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D25396018CE7F6200270222 /* ImageControlsButtonElementMac.cpp */; };
 		2D25396318CE7F6200270222 /* ImageControlsButtonElementMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D25396118CE7F6200270222 /* ImageControlsButtonElementMac.h */; };
@@ -8440,7 +8439,6 @@
 		2BE8E2C812A58A0100FAD550 /* HTMLMetaCharsetParser.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = HTMLMetaCharsetParser.cpp; sourceTree = ""; };
 		2D0B4AA918DA1CCD00434DE1 /* IOSurface.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IOSurface.h; sourceTree = ""; };
 		2D0B4AAA18DA1CCD00434DE1 /* IOSurface.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = IOSurface.mm; sourceTree = ""; };
-		2D0CF8161BCF5DE1007A4937 /* NSWindowSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSWindowSPI.h; sourceTree = ""; };
 		2D232BFF1A326EF9006BF2DB /* TUCallSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = TUCallSPI.h; sourceTree = ""; };
 		2D25396018CE7F6200270222 /* ImageControlsButtonElementMac.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ImageControlsButtonElementMac.cpp; sourceTree = ""; };
 		2D25396118CE7F6200270222 /* ImageControlsButtonElementMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ImageControlsButtonElementMac.h; sourceTree = ""; };

[webkit-changes] [191303] trunk/Source/WebKit2

[timothy_horton]

Title: [191303] trunk/Source/WebKit2








Revision 191303
Author timothy_hor...@apple.com
Date 2015-10-19 12:09:14 -0700 (Mon, 19 Oct 2015)


Log Message
Try to fix the 32-bit build.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191302 => 191303)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 18:59:16 UTC (rev 191302)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 19:09:14 UTC (rev 191303)
@@ -1,3 +1,10 @@
+2015-10-19  Tim Horton  
+
+Try to fix the 32-bit build.
+
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::setupServicesMenu):
+
 2015-10-16  Anders Carlsson  
 
 Fix image service menus somewhat


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm (191302 => 191303)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-19 18:59:16 UTC (rev 191302)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-19 19:09:14 UTC (rev 191303)
@@ -261,7 +261,10 @@
 auto cgImage = image->makeCGImage();
 auto nsImage = adoptNS([[NSImage alloc] initWithCGImage:cgImage.get() size:image->size()]);
 
-auto itemProvider = adoptNS([[NSItemProvider alloc] initWithItem:[nsImage TIFFRepresentation] typeIdentifier:(__bridge NSString *)kUTTypeTIFF]);
+RetainPtr itemProvider;
+#ifdef __LP64__
+itemProvider = adoptNS([[NSItemProvider alloc] initWithItem:[nsImage TIFFRepresentation] typeIdentifier:(__bridge NSString *)kUTTypeTIFF]);
+#endif
 
 items = @[ itemProvider.get() ];
 } else if (!context.controlledSelectionData().isEmpty()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191309] trunk/Source/WebKit2

[wenson_hsieh]

Title: [191309] trunk/Source/WebKit2








Revision 191309
Author wenson_hs...@apple.com
Date 2015-10-19 12:53:45 -0700 (Mon, 19 Oct 2015)


Log Message
Extend fast-clicking behavior to trigger on elements that have negligible zoom
https://bugs.webkit.org/show_bug.cgi?id=150248


Reviewed by Simon Fraser.

Currently, fast-clicking only triggers on pages that have unscalable viewports. To allow more websites to benefit from fast-clicking
behavior, we generalize fast-clicking to also occur when tapping on elements for which double-tap-to-zoom would zoom the element in
or out by an insignificant amount. We define an insignificant amount of zoom to mean that zooming would increase the viewport scale
by less than a configurable threshold, or decrease the viewport scale by more than a configurable threshold. We accomplish this by
temporarily disabling the double tap gesture recognizer for the duration of the tap. This patch refactors some logic used to compute
zoomed viewports to make it possible to predict the change in viewport scale when double tapping to zoom. See the changes in
SmartMagnificationController and ViewGestureGeometryCollector for more details.

There are no new tests, since this patch does not change existing behavior. Instead, this patch adds the machinery needed for zoom-
dependent fast-clicking: by setting the preferences WebKitFastClickingEnabled and WebKitFastClickZoomThreshold, we will be able to tweak
the behavior dynamically.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _contentZoomScale]):
(-[WKWebView _targetContentZoomScaleForRect:currentScale:fitEntireRect:minimumScale:maximumScale:]):
(-[WKWebView _zoomToRect:withOrigin:fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]):
(-[WKWebView _viewportIsUserScalable]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::disableDoubleTapGesturesUntilTapIsFinishedIfNecessary):
* UIProcess/ios/SmartMagnificationController.h:
* UIProcess/ios/SmartMagnificationController.mm:
(WebKit::SmartMagnificationController::adjustSmartMagnificationTargetRectAndZoomScales):
(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
(WebKit::SmartMagnificationController::magnify):
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _fastClickZoomThreshold]):
(-[WKContentView _allowDoubleTapToZoomForCurrentZoomScale:andTargetZoomScale:]):
(-[WKContentView _disableDoubleTapGesturesUntilTapIsFinishedIfNecessary:allowsDoubleTapZoom:targetRect:isReplaced:minimumScale:maximumScale:]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
(-[WKContentView _singleTapRecognized:]):
(cancelPotentialTapIfNecessary):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView webSelectionRects]): Deleted.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::disableDoubleTapGesturesUntilTapIsFinishedIfNecessary):
* WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
(WebKit::ViewGestureGeometryCollector::computeZoomInformationForNode):
* WebProcess/WebPage/ViewGestureGeometryCollector.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::potentialTapAtPosition):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/ios/SmartMagnificationController.h
trunk/Source/WebKit2/UIProcess/ios/SmartMagnificationController.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.cpp
trunk/Source/WebKit2/WebProcess/WebPage/ViewGestureGeometryCollector.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191308 => 191309)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 19:37:48 UTC (rev 191308)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 19:53:45 UTC (rev 191309)
@@ -1,3 +1,63 @@
+2015-10-17  Wenson Hsieh  
+
+ 

[webkit-changes] [191306] trunk/Source/WebKit2

[cdumez]

Title: [191306] trunk/Source/WebKit2








Revision 191306
Author cdu...@apple.com
Date 2015-10-19 12:21:22 -0700 (Mon, 19 Oct 2015)


Log Message
[WK2] Generalize NetworkCacheStorage API so it can store different types of metadata
https://bugs.webkit.org/show_bug.cgi?id=150221


Reviewed by Darin Adler and Antti Koivisto.

Generalize NetworkCacheStorage API so it can store different types of
metadata alongside the network resources. This is a pre-requirement to
making our NetworkCache smarter by storing information about the
resources.

To keep the code simple, the entry type is now part of the entry key and
we store records of a specific type in a 'type' subfolder. The cache
structure looks like so:
- WebKitCache/Version 5/[Partition]/[Type]/[Hash]
- WebKitCache/Version 5/[Partition]/[Type]/[Hash]-blob (Optional)

Existing cache entries now that the 'resource' type as these are network
resources.

* NetworkProcess/cache/NetworkCache.cpp:
* NetworkProcess/cache/NetworkCacheKey.cpp:
* NetworkProcess/cache/NetworkCacheKey.h:
* NetworkProcess/cache/NetworkCacheStatistics.cpp:
* NetworkProcess/cache/NetworkCacheStorage.cpp:
* NetworkProcess/cache/NetworkCacheStorage.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.h
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStatistics.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191305 => 191306)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 19:19:09 UTC (rev 191305)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 19:21:22 UTC (rev 191306)
@@ -1,3 +1,32 @@
+2015-10-19  Chris Dumez  
+
+[WK2] Generalize NetworkCacheStorage API so it can store different types of metadata
+https://bugs.webkit.org/show_bug.cgi?id=150221
+
+
+Reviewed by Darin Adler and Antti Koivisto.
+
+Generalize NetworkCacheStorage API so it can store different types of
+metadata alongside the network resources. This is a pre-requirement to
+making our NetworkCache smarter by storing information about the
+resources.
+
+To keep the code simple, the entry type is now part of the entry key and
+we store records of a specific type in a 'type' subfolder. The cache
+structure looks like so:
+- WebKitCache/Version 5/[Partition]/[Type]/[Hash]
+- WebKitCache/Version 5/[Partition]/[Type]/[Hash]-blob (Optional)
+
+Existing cache entries now that the 'resource' type as these are network
+resources.
+
+* NetworkProcess/cache/NetworkCache.cpp:
+* NetworkProcess/cache/NetworkCacheKey.cpp:
+* NetworkProcess/cache/NetworkCacheKey.h:
+* NetworkProcess/cache/NetworkCacheStatistics.cpp:
+* NetworkProcess/cache/NetworkCacheStorage.cpp:
+* NetworkProcess/cache/NetworkCacheStorage.h:
+
 2015-10-19  Tim Horton  
 
 Try to fix the iOS build


Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp (191305 => 191306)

--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp	2015-10-19 19:19:09 UTC (rev 191305)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp	2015-10-19 19:21:22 UTC (rev 191306)
@@ -39,6 +39,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -50,6 +51,13 @@
 namespace WebKit {
 namespace NetworkCache {
 
+static const AtomicString& resourceType()
+{
+ASSERT(WTF::isMainThread());
+static NeverDestroyed resource("resource", AtomicString::ConstructFromLiteral);
+return resource;
+}
+
 Cache& singleton()
 {
 static NeverDestroyed instance;
@@ -113,7 +121,7 @@
 // FIXME: This implements minimal Range header disk cache support. We don't parse
 // ranges so only the same exact range request will be served from the cache.
 String range = request.httpHeaderField(WebCore::HTTPHeaderName::Range);
-return { partition, range, request.url().string() };
+return { partition, resourceType(), range, request.url().string() };
 }
 
 static String headerValueForVary(const WebCore::ResourceRequest& request, const String& headerName)
@@ -472,7 +480,7 @@
 {
 ASSERT(isEnabled());
 
-m_storage->traverse(0, [traverseHandler](const Storage::Record* record, const Storage::RecordInfo&) {
+m_storage->traverse(resourceType(), 0, [traverseHandler](const Storage::Record* record, const Storage::RecordInfo&) {
 if (!record) {
 traverseHandler(nullptr);
 return;
@@ -509,7 +517,7 @@
 Totals totals;
 auto flags = Storage::TraverseFlag::ComputeWorth | Storage::TraverseFlag::ShareCount;
 size_t capacity = m_storage->capacity();
-

[webkit-changes] [191297] trunk/Source/WebCore

[mmaxfield]

Title: [191297] trunk/Source/WebCore








Revision 191297
Author mmaxfi...@apple.com
Date 2015-10-19 10:58:49 -0700 (Mon, 19 Oct 2015)


Log Message
[iOS] Build fix after r191295

Unreviewed.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::resetPlatformCTM):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (191296 => 191297)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 17:54:46 UTC (rev 191296)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 17:58:49 UTC (rev 191297)
@@ -1,5 +1,14 @@
 2015-10-19  Myles C. Maxfield  
 
+[iOS] Build fix after r191295
+
+Unreviewed.
+
+* platform/graphics/cg/GraphicsContextCG.cpp:
+(WebCore::GraphicsContext::resetPlatformCTM):
+
+2015-10-19  Myles C. Maxfield  
+
 Host GraphicsContext's CTM inside GraphicsContextState
 https://bugs.webkit.org/show_bug.cgi?id=150146
 


Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (191296 => 191297)

--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2015-10-19 17:54:46 UTC (rev 191296)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2015-10-19 17:58:49 UTC (rev 191297)
@@ -107,7 +107,7 @@
 void GraphicsContext::resetPlatformCTM()
 {
 m_state.ctm = CGContextGetCTM(platformContext());
-#if PLATFORM(WIN)
+#if PLATFORM(WIN) || PLATFORM(IOS)
 m_state.userToDeviceSpaceCTM = static_cast(CGContextGetUserSpaceToDeviceSpaceTransform(platformContext())) * m_state.ctm.inverse();
 #else
 m_state.userToDeviceSpaceCTM = CGContextGetDefaultUserSpaceToDeviceSpaceTransform(platformContext());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191304] trunk/LayoutTests

[commit-queue]

Title: [191304] trunk/LayoutTests








Revision 191304
Author commit-qu...@webkit.org
Date 2015-10-19 12:11:46 -0700 (Mon, 19 Oct 2015)


Log Message
Rebaselining fast/dynamic/insert-before-table-part-in-continuation.html for win
https://bugs.webkit.org/show_bug.cgi?id=150126

Patch by Ryan Haddad  on 2015-10-19
Reviewed by Zalan Bujtas.

* platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (191303 => 191304)

--- trunk/LayoutTests/ChangeLog	2015-10-19 19:09:14 UTC (rev 191303)
+++ trunk/LayoutTests/ChangeLog	2015-10-19 19:11:46 UTC (rev 191304)
@@ -1,5 +1,14 @@
 2015-10-19  Ryan Haddad  
 
+Rebaselining fast/dynamic/insert-before-table-part-in-continuation.html for win
+https://bugs.webkit.org/show_bug.cgi?id=150126
+
+Reviewed by Zalan Bujtas.
+
+* platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
+
+2015-10-19  Ryan Haddad  
+
 Removing Yosemite-only flag for flaky test http/tests/media/video-query-url.html
 https://bugs.webkit.org/show_bug.cgi?id=141085
 


Modified: trunk/LayoutTests/platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt (191303 => 191304)

--- trunk/LayoutTests/platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt	2015-10-19 19:09:14 UTC (rev 191303)
+++ trunk/LayoutTests/platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt	2015-10-19 19:11:46 UTC (rev 191304)
@@ -1,9 +1,9 @@
-layer at (0,0) size 785x678
-  RenderView at (0,0) size 785x600
-layer at (0,0) size 785x678
-  RenderBlock {HTML} at (0,0) size 785x678
-RenderBody {BODY} at (8,8) size 769x662
-  RenderBlock {P} at (0,0) size 769x18
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderBlock {P} at (0,0) size 784x18
 RenderText {#text} at (0,0) size 53x18
   text run at (0,0) width 53: "Test for "
 RenderInline {I} at (0,0) size 632x18
@@ -15,111 +15,89 @@
 text run at (358,0) width 327: "Safari Crashes when opening a JS TreeGrid widget"
 RenderText {#text} at (685,0) size 4x18
   text run at (685,0) width 4: "."
-  RenderBlock {P} at (0,34) size 769x72
-RenderText {#text} at (0,0) size 761x72
-  text run at (0,0) width 753: "The test sets up an inline parent with a child that is some kind of table part. The child gets broken off into a continuation"
-  text run at (0,18) width 761: "and anonymous table parts get created below and/or above the table parts. Then the test tries to insert a new child into the"
-  text run at (0,36) width 743: "inline, specifying the table part as the \"before child\". The resulting render tree should look just like it would look if the"
-  text run at (0,54) width 122: "parent was a block."
-  RenderBlock {DIV} at (0,122) size 769x36
-RenderBlock (anonymous) at (0,0) size 769x18
-  RenderInline {SPAN} at (0,0) size 128x18
-RenderText {#text} at (0,0) size 41x18
-  text run at (0,0) width 41: "Text..."
-RenderText {#text} at (41,0) size 87x18
-  text run at (41,0) width 87: "goes here and"
-RenderBlock (anonymous) at (0,18) size 769x18
-  RenderTable at (0,0) size 103x18
+  RenderBlock {P} at (0,34) size 784x72
+RenderText {#text} at (0,0) size 783x72
+  text run at (0,0) width 780: "The test sets up an inline parent with a child that is some kind of table part. The child gets broken off into a continuation and"
+  text run at (0,18) width 777: "anonymous table parts get created below and/or above the table parts. Then the test tries to insert a new child into the inline,"
+  text run at (0,36) width 783: "specifying the table part as the \"before child\". The resulting render tree should look just like it would look if the parent was a"
+  text run at (0,54) width 39: "block."
+  RenderBlock {DIV} at (0,122) size 784x18
+RenderInline {SPAN} at (0,0) size 231x18
+  RenderText {#text} at (0,0) size 41x18
+text run at (0,0) width 41: "Text..."
+  RenderText {#text} at (41,0) size 87x18
+text run at (41,0) width 87: "goes here and"
+  RenderTable at (128,0) size 103x18
 RenderTableSection (anonymous) at (0,0) size 103x18
   RenderTableRow (anonymous) at (0,0) size 103x18
 RenderTableCell {DIV} at (0,0) size 103x18 [r=0 c=0 rs=1 cs=1]
   RenderText {#text} at (0,0) size 103x18

[webkit-changes] [191308] trunk/Tools

[ap]

Title: [191308] trunk/Tools








Revision 191308
Author a...@apple.com
Date 2015-10-19 12:37:48 -0700 (Mon, 19 Oct 2015)


Log Message
Add new EWS queues to bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=150297

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js (191307 => 191308)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js	2015-10-19 19:23:57 UTC (rev 191307)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js	2015-10-19 19:37:48 UTC (rev 191308)
@@ -32,6 +32,8 @@
 "ios-ews": {platform: Dashboard.Platform.iOS9Device, shortName: "ios", title: "WebKit\xa0Release\xa0Build\xa0EWS"},
 "mac-ews": {platform: Dashboard.Platform.MacOSXMavericks, shortName: "mac", title: "WebKit1\xa0Release\xa0Tests\xa0EWS"},
 "mac-wk2-ews": {platform: Dashboard.Platform.MacOSXMavericks, shortName: "mac-wk2", title: "WebKit2\xa0Release\xa0Tests\xa0EWS"},
+"mac-debug-ews": {platform: Dashboard.Platform.MacOSXYosemite, shortName: "mac-debug", title: "WebKit1\xa0Debug\xa0Tests\xa0EWS"},
+"mac-32bit-ews": {platform: Dashboard.Platform.MacOSXYosemite, shortName: "mac-32bit", title: "Release\xa032\u2011bit\xa0Build\xa0EWS"},
 "win-ews": {platform: Dashboard.Platform.Windows7, shortName: "win", title: "WebKit1\xa0Release\xa0Build\xa0EWS"},
 "efl-wk2-ews": {platform: Dashboard.Platform.LinuxEFL, shortName: "efl-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"}
 };


Modified: trunk/Tools/ChangeLog (191307 => 191308)

--- trunk/Tools/ChangeLog	2015-10-19 19:23:57 UTC (rev 191307)
+++ trunk/Tools/ChangeLog	2015-10-19 19:37:48 UTC (rev 191308)
@@ -1,3 +1,13 @@
+2015-10-19  Alexey Proskuryakov  
+
+Add new EWS queues to bot watcher's dashboard
+https://bugs.webkit.org/show_bug.cgi?id=150297
+
+Reviewed by Darin Adler.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
+(BubbleQueueServer):
+
 2015-10-19  ChangSeok Oh  
 
 REGRESSION(r190262): User media unit test failures after r190262






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191305] trunk/Source

[timothy_horton]

Title: [191305] trunk/Source








Revision 191305
Author timothy_hor...@apple.com
Date 2015-10-19 12:19:09 -0700 (Mon, 19 Oct 2015)


Log Message
Try to fix the iOS build

* Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191304 => 191305)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-19 19:11:46 UTC (rev 191304)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-19 19:19:09 UTC (rev 191305)
@@ -1,3 +1,9 @@
+2015-10-19  Tim Horton  
+
+Try to fix the iOS build
+
+* Configurations/FeatureDefines.xcconfig:
+
 2015-10-17  Keith Miller  
 
 Add regression tests for TypedArray.prototype functions' error messages.


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (191304 => 191305)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2015-10-19 19:11:46 UTC (rev 191304)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2015-10-19 19:19:09 UTC (rev 191305)
@@ -119,9 +119,11 @@
 
 ENABLE_INTL = ENABLE_INTL;
 
+ENABLE_IOS_GESTURE_EVENTS = ;
 ENABLE_IOS_GESTURE_EVENTS[sdk=iphone*] = $(ENABLE_IOS_GESTURE_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_IOS_GESTURE_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_IOS_GESTURE_EVENTS;
 
+ENABLE_MAC_GESTURE_EVENTS = ;
 ENABLE_MAC_GESTURE_EVENTS[sdk=macosx*] = $(ENABLE_MAC_GESTURE_EVENTS_macosx_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_MAC_GESTURE_EVENTS_macosx_WITH_INTERNAL_SDK_YES = ENABLE_MAC_GESTURE_EVENTS;
 


Modified: trunk/Source/WebCore/ChangeLog (191304 => 191305)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 19:11:46 UTC (rev 191304)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 19:19:09 UTC (rev 191305)
@@ -1,3 +1,9 @@
+2015-10-19  Tim Horton  
+
+Try to fix the iOS build
+
+* Configurations/FeatureDefines.xcconfig:
+
 2015-10-19  Alex Christensen  
 
 Unreviewed build fix after r191295.


Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (191304 => 191305)

--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2015-10-19 19:11:46 UTC (rev 191304)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2015-10-19 19:19:09 UTC (rev 191305)
@@ -119,9 +119,11 @@
 
 ENABLE_INTL = ENABLE_INTL;
 
+ENABLE_IOS_GESTURE_EVENTS = ;
 ENABLE_IOS_GESTURE_EVENTS[sdk=iphone*] = $(ENABLE_IOS_GESTURE_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_IOS_GESTURE_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_IOS_GESTURE_EVENTS;
 
+ENABLE_MAC_GESTURE_EVENTS = ;
 ENABLE_MAC_GESTURE_EVENTS[sdk=macosx*] = $(ENABLE_MAC_GESTURE_EVENTS_macosx_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_MAC_GESTURE_EVENTS_macosx_WITH_INTERNAL_SDK_YES = ENABLE_MAC_GESTURE_EVENTS;
 


Modified: trunk/Source/WebKit/mac/ChangeLog (191304 => 191305)

--- trunk/Source/WebKit/mac/ChangeLog	2015-10-19 19:11:46 UTC (rev 191304)
+++ trunk/Source/WebKit/mac/ChangeLog	2015-10-19 19:19:09 UTC (rev 191305)
@@ -1,5 +1,11 @@
 2015-10-19  Tim Horton  
 
+Try to fix the iOS build
+
+* Configurations/FeatureDefines.xcconfig:
+
+2015-10-19  Tim Horton  
+
 Add magnify and rotate gesture event support for Mac
 https://bugs.webkit.org/show_bug.cgi?id=150179
 


Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (191304 => 191305)

--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2015-10-19 19:11:46 UTC (rev 191304)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2015-10-19 19:19:09 UTC (rev 191305)
@@ -119,9 +119,11 @@
 
 ENABLE_INTL = ENABLE_INTL;
 
+ENABLE_IOS_GESTURE_EVENTS = ;
 ENABLE_IOS_GESTURE_EVENTS[sdk=iphone*] = $(ENABLE_IOS_GESTURE_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_IOS_GESTURE_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_IOS_GESTURE_EVENTS;
 
+ENABLE_MAC_GESTURE_EVENTS = ;
 ENABLE_MAC_GESTURE_EVENTS[sdk=macosx*] = $(ENABLE_MAC_GESTURE_EVENTS_macosx_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_MAC_GESTURE_EVENTS_macosx_WITH_INTERNAL_SDK_YES = ENABLE_MAC_GESTURE_EVENTS;
 


Modified: trunk/Source/WebKit2/ChangeLog (191304 => 191305)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 19:11:46 UTC (rev 191304)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 19:19:09 UTC (rev 191305)
@@ -1,5 +1,11 @@
 2015-10-19  Tim Horton  
 
+Try to fix the iOS build
+
+* 

[webkit-changes] [191307] trunk/Source

[timothy_horton]

Title: [191307] trunk/Source








Revision 191307
Author timothy_hor...@apple.com
Date 2015-10-19 12:23:57 -0700 (Mon, 19 Oct 2015)


Log Message
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174

Reviewed by Darin Adler.

No new tests, just moving code around.

* WebCore.xcodeproj/project.pbxproj:
* platform/spi/mac/NSWindowSPI.h: Added.

* UIProcess/API/mac/WKView.mm:
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/Cocoa/WebViewImpl.h: Added.
* UIProcess/Cocoa/WebViewImpl.mm: Added.
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::setDrawsBackground):
(WebKit::WebViewImpl::drawsBackground):
(WebKit::WebViewImpl::setDrawsTransparentBackground):
(WebKit::WebViewImpl::drawsTransparentBackground):
(WebKit::WebViewImpl::acceptsFirstResponder):
(WebKit::WebViewImpl::becomeFirstResponder):
(WebKit::WebViewImpl::resignFirstResponder):
(WebKit::WebViewImpl::isFocused):
(WebKit::WebViewImpl::viewWillStartLiveResize):
(WebKit::WebViewImpl::viewDidEndLiveResize):
(WebKit::WebViewImpl::setFrameSize):
(WebKit::WebViewImpl::disableFrameSizeUpdates):
(WebKit::WebViewImpl::enableFrameSizeUpdates):
(WebKit::WebViewImpl::frameSizeUpdatesDisabled):
(WebKit::WebViewImpl::setFrameAndScrollBy):
(WebKit::WebViewImpl::setFixedLayoutSize):
(WebKit::WebViewImpl::fixedLayoutSize):
(WebKit::WebViewImpl::setDrawingAreaSize):
(WebKit::WebViewImpl::setContentPreparationRect):
(WebKit::WebViewImpl::updateViewExposedRect):
(WebKit::WebViewImpl::setClipsToVisibleRect):
(WebKit::WebViewImpl::setIntrinsicContentSize):
(WebKit::WebViewImpl::intrinsicContentSize):
(WebKit::WebViewImpl::setViewScale):
(WebKit::WebViewImpl::viewScale):
(WebKit::WebViewImpl::layoutMode):
(WebKit::WebViewImpl::setLayoutMode):
(WebKit::WebViewImpl::supportsArbitraryLayoutModes):
(WebKit::WebViewImpl::updateSupportsArbitraryLayoutModes):
(WebKit::WebViewImpl::updateSecureInputState):
(WebKit::WebViewImpl::resetSecureInputState):
(WebKit::WebViewImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::WebViewImpl::hasFullScreenWindowController):
(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::closeFullScreenWindowController):
(WebKit::WebViewImpl::fullScreenPlaceholderView):
(WebKit::WebViewImpl::createFullScreenWindow):
Move the actual implementation of a number of WKView methods into a
C++ class, WebViewImpl, which WKView calls directly into.
Eventually, we will move all of the logic of WKView into WebViewImpl,
and then duplicate the necessary forwarding in WKWebView and remove
WKWebView's inner WKView.

* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::updateSecureInputState):
(WebKit::PageClientImpl::resetSecureInputState):
(WebKit::PageClientImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):
For now, forward PageClient requests that can be answered by WebViewImpl
to WebViewImpl. Eventually, we'll probably fold PageClientImpl and WebViewImpl
together into one class, and these things will collapse down.

* UIProcess/mac/WKFullScreenWindowController.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:webView:page:]):
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(-[WKFullScreenWindowController _manager]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController initWithWindow:webView:]): Deleted.
(-[WKFullScreenWindowController _page]): Deleted.
* UIProcess/mac/WKViewLayoutStrategy.h:
* UIProcess/mac/WKViewLayoutStrategy.mm:
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy invalidate]):
(-[WKViewLayoutStrategy didChangeFrameSize]):
(-[WKViewViewSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewFixedSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy updateLayout]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy didChangeFrameSize]):
(-[WKViewDynamicSizeComputedFromMinimumDocumentSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:mode:]): Deleted.
(-[WKViewLayoutStrategy initWithPage:view:mode:]): Deleted.

[webkit-changes] [191295] trunk/Source/WebCore

[mmaxfield]

Title: [191295] trunk/Source/WebCore








Revision 191295
Author mmaxfi...@apple.com
Date 2015-10-19 10:28:41 -0700 (Mon, 19 Oct 2015)


Log Message
Host GraphicsContext's CTM inside GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=150146

Reviewed by Simon Fraser.

There are 6 operations which interact with CTMs:
- Get
- Set
- Concatenate
- Scale
- Rotate
- Translate

This patch modifies all these operations so that these operations shadow the
platform's CTM inside GraphicsContextState. This way, we don't have to consult
with the underlying graphics context in order to know the current CTM.

There are currently many places in the Core Graphics ports where we will change
the platform's CTM out from under the GraphicsContext. This patch migrates
those users to going through GraphicsContext, thereby preserving the integrity
of the shadowed state.

No new tests because there is no behavior change.

* platform/graphics/GraphicsContext.cpp: Setters deletate to platform calls.
The getter can just consult with the shadowed state.
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::checkCTMInvariants): Make sure the shadowed state
matches the platform graphics context's state.
* platform/graphics/cairo/GraphicsContextCairo.cpp: Renaming functions.
(WebCore::GraphicsContext::resetPlatformCTM):
(WebCore::GraphicsContext::getPlatformCTM):
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::getCTM): Deleted.
(WebCore::GraphicsContext::translate): Deleted.
(WebCore::GraphicsContext::concatCTM): Deleted.
(WebCore::GraphicsContext::setCTM): Deleted.
(WebCore::GraphicsContext::rotate): Deleted.
(WebCore::GraphicsContext::scale): Deleted.
* platform/graphics/cg/GraphicsContextCG.cpp: Renaming functions. Also,
migrate CTM setters to go through GraphicsContext.
(WebCore::GraphicsContext::resetPlatformCTM):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::drawPatternCallback):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::getPlatformCTM):
(WebCore::GraphicsContext::scale): Deleted.
(WebCore::GraphicsContext::rotate): Deleted.
(WebCore::GraphicsContext::translate): Deleted.
(WebCore::GraphicsContext::concatCTM): Deleted.
(WebCore::GraphicsContext::setCTM): Deleted.
(WebCore::GraphicsContext::getCTM): Deleted.
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::flush):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scale):
(WebCore::GraphicsContextPlatformPrivate::rotate):
(WebCore::GraphicsContextPlatformPrivate::translate):
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
(WebCore::GraphicsContextPlatformPrivate::setCTM):
* platform/graphics/transforms/AffineTransform.h:
(WebCore::AffineTransform::isEssentiallyEqualTo): Equality comparison on floats
is not a good idea. Instead, this function is more valuable. (However, note that
it is expected for values in a CTM to hold values close to 0, which means that
this function might erroneously return false (similar to operator=()).
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContextPlatformPrivate::scale):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
* platform/mac/DragImageMac.mm:
(WebCore::drawAtPoint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/Image.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h

[webkit-changes] [191296] trunk/LayoutTests

[commit-queue]

Title: [191296] trunk/LayoutTests








Revision 191296
Author commit-qu...@webkit.org
Date 2015-10-19 10:54:46 -0700 (Mon, 19 Oct 2015)


Log Message
Removing Yosemite-only flag for flaky test http/tests/media/video-query-url.html
https://bugs.webkit.org/show_bug.cgi?id=141085

Patch by Ryan Haddad  on 2015-10-19
Reviewed by Alexey Proskuryakov.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (191295 => 191296)

--- trunk/LayoutTests/ChangeLog	2015-10-19 17:28:41 UTC (rev 191295)
+++ trunk/LayoutTests/ChangeLog	2015-10-19 17:54:46 UTC (rev 191296)
@@ -1,3 +1,12 @@
+2015-10-19  Ryan Haddad  
+
+Removing Yosemite-only flag for flaky test http/tests/media/video-query-url.html
+https://bugs.webkit.org/show_bug.cgi?id=141085
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/mac-wk2/TestExpectations:
+
 2015-10-19  Chris Dumez  
 
 Null dereference loading Blink layout test fast/forms/color/input-color-onchange-event.html


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (191295 => 191296)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-19 17:28:41 UTC (rev 191295)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-10-19 17:54:46 UTC (rev 191296)
@@ -528,7 +528,7 @@
 
 webkit.org/b/141325 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html [ Pass Failure ]
 
-webkit.org/b/141085 [ Yosemite ] http/tests/media/video-query-url.html [ Pass Timeout ]
+webkit.org/b/141085 http/tests/media/video-query-url.html [ Pass Timeout ]
 
 webkit.org/b/145702 [ Debug Yosemite ] http/tests/misc/acid3.html [ Pass Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191300] trunk/Source/JavaScriptCore

[keith_miller]

Title: [191300] trunk/Source/_javascript_Core








Revision 191300
Author keith_mil...@apple.com
Date 2015-10-19 11:32:30 -0700 (Mon, 19 Oct 2015)


Log Message
Add regression tests for TypedArray.prototype functions' error messages.
https://bugs.webkit.org/show_bug.cgi?id=150288

Reviewed by Darin Adler.

Fix a typo in the text passed by TypedArrray.prototype.filter type error message.
Add tests that check the actual error message text for all the TypeArray.prototype
functions that throw.

* builtins/TypedArray.prototype.js:
(filter):
* tests/stress/typedarray-every.js:
* tests/stress/typedarray-filter.js:
* tests/stress/typedarray-find.js:
* tests/stress/typedarray-findIndex.js:
* tests/stress/typedarray-forEach.js:
* tests/stress/typedarray-map.js:
* tests/stress/typedarray-reduce.js:
* tests/stress/typedarray-reduceRight.js:
* tests/stress/typedarray-some.js:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/TypedArray.prototype.js
trunk/Source/_javascript_Core/tests/stress/typedarray-every.js
trunk/Source/_javascript_Core/tests/stress/typedarray-filter.js
trunk/Source/_javascript_Core/tests/stress/typedarray-find.js
trunk/Source/_javascript_Core/tests/stress/typedarray-findIndex.js
trunk/Source/_javascript_Core/tests/stress/typedarray-forEach.js
trunk/Source/_javascript_Core/tests/stress/typedarray-map.js
trunk/Source/_javascript_Core/tests/stress/typedarray-reduce.js
trunk/Source/_javascript_Core/tests/stress/typedarray-reduceRight.js
trunk/Source/_javascript_Core/tests/stress/typedarray-some.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191299 => 191300)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-19 18:10:58 UTC (rev 191299)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-19 18:32:30 UTC (rev 191300)
@@ -1,3 +1,26 @@
+2015-10-17  Keith Miller  
+
+Add regression tests for TypedArray.prototype functions' error messages.
+https://bugs.webkit.org/show_bug.cgi?id=150288
+
+Reviewed by Darin Adler.
+
+Fix a typo in the text passed by TypedArrray.prototype.filter type error message.
+Add tests that check the actual error message text for all the TypeArray.prototype
+functions that throw.
+
+* builtins/TypedArray.prototype.js:
+(filter):
+* tests/stress/typedarray-every.js:
+* tests/stress/typedarray-filter.js:
+* tests/stress/typedarray-find.js:
+* tests/stress/typedarray-findIndex.js:
+* tests/stress/typedarray-forEach.js:
+* tests/stress/typedarray-map.js:
+* tests/stress/typedarray-reduce.js:
+* tests/stress/typedarray-reduceRight.js:
+* tests/stress/typedarray-some.js:
+
 2015-10-19  Tim Horton  
 
 Add magnify and rotate gesture event support for Mac


Modified: trunk/Source/_javascript_Core/builtins/TypedArray.prototype.js (191299 => 191300)

--- trunk/Source/_javascript_Core/builtins/TypedArray.prototype.js	2015-10-19 18:10:58 UTC (rev 191299)
+++ trunk/Source/_javascript_Core/builtins/TypedArray.prototype.js	2015-10-19 18:32:30 UTC (rev 191300)
@@ -249,7 +249,7 @@
 var length = @typedArrayLength(this);
 
 if (typeof callback !== "function")
-throw new @TypeError("Array.prototype.filter callback must be a function");
+throw new @TypeError("TypedArray.prototype.filter callback must be a function");
 
 var thisArg = arguments.length > 1 ? arguments[1] : undefined;
 


Modified: trunk/Source/_javascript_Core/tests/stress/typedarray-every.js (191299 => 191300)

--- trunk/Source/_javascript_Core/tests/stress/typedarray-every.js	2015-10-19 18:10:58 UTC (rev 191299)
+++ trunk/Source/_javascript_Core/tests/stress/typedarray-every.js	2015-10-19 18:32:30 UTC (rev 191300)
@@ -46,11 +46,11 @@
 debug("");
 
 debug("5.0 Wrong Type for Callback Test");
-shouldThrow("testPrototypeFunction('every', '(8)', [12, 15, 10, 13, 44], false)");
-shouldThrow("testPrototypeFunction('every', '(\"wrong\")', [12, 15, 10, 13, 44], false)");
-shouldThrow("testPrototypeFunction('every', '(new Object())', [12, 15, 10, 13, 44], false)");
-shouldThrow("testPrototypeFunction('every', '(null)', [12, 15, 10, 13, 44], false)");
-shouldThrow("testPrototypeFunction('every', '()', [12, 15, 10, 13, 44], false)");
+shouldThrow("testPrototypeFunction('every', '(8)', [12, 15, 10, 13, 44], false)", "'TypeError: TypedArray.prototype.every callback must be a function'");
+shouldThrow("testPrototypeFunction('every', '(\"wrong\")', [12, 15, 10, 13, 44], false)", "'TypeError: TypedArray.prototype.every callback must be a function'");
+shouldThrow("testPrototypeFunction('every', '(new Object())', [12, 15, 10, 13, 44], false)", "'TypeError: TypedArray.prototype.every callback must be a function'");
+shouldThrow("testPrototypeFunction('every', '(null)', [12, 15, 10, 13, 44], false)", "'TypeError: TypedArray.prototype.every callback must be a function'");

[webkit-changes] [191302] trunk/Source/WebKit2

[andersca]

Title: [191302] trunk/Source/WebKit2








Revision 191302
Author ander...@apple.com
Date 2015-10-19 11:59:16 -0700 (Mon, 19 Oct 2015)


Log Message
Fix image service menus somewhat
https://bugs.webkit.org/show_bug.cgi?id=150265

Reviewed by Tim Horton.

* Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
It's a service menu if we have a controlled image.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Use an item provider.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/ContextMenuContextData.cpp
trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191301 => 191302)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 18:50:26 UTC (rev 191301)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-19 18:59:16 UTC (rev 191302)
@@ -1,3 +1,18 @@
+2015-10-16  Anders Carlsson  
+
+Fix image service menus somewhat
+https://bugs.webkit.org/show_bug.cgi?id=150265
+
+Reviewed by Tim Horton.
+
+* Shared/ContextMenuContextData.cpp:
+(WebKit::ContextMenuContextData::ContextMenuContextData):
+It's a service menu if we have a controlled image.
+
+* UIProcess/mac/WebContextMenuProxyMac.mm:
+(WebKit::WebContextMenuProxyMac::setupServicesMenu):
+Use an item provider.
+
 2015-10-19  Tim Horton  
 
 Add magnify and rotate gesture event support for Mac


Modified: trunk/Source/WebKit2/Shared/ContextMenuContextData.cpp (191301 => 191302)

--- trunk/Source/WebKit2/Shared/ContextMenuContextData.cpp	2015-10-19 18:50:26 UTC (rev 191301)
+++ trunk/Source/WebKit2/Shared/ContextMenuContextData.cpp	2015-10-19 18:59:16 UTC (rev 191302)
@@ -46,7 +46,11 @@
 }
 
 ContextMenuContextData::ContextMenuContextData(const WebCore::IntPoint& menuLocation, const Vector& menuItems, const ContextMenuContext& context)
+#if ENABLE(SERVICE_CONTROLS)
+: m_type(context.controlledImage() ? Type::ServicesMenu : Type::ContextMenu)
+#else
 : m_type(Type::ContextMenu)
+#endif
 , m_menuLocation(menuLocation)
 , m_menuItems(menuItems)
 , m_webHitTestResultData(context.hitTestResult(), true)


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm (191301 => 191302)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-19 18:50:26 UTC (rev 191301)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm	2015-10-19 18:59:16 UTC (rev 191302)
@@ -258,9 +258,12 @@
 if (!image)
 return;
 
-RetainPtr cgImage = image->makeCGImage();
-RetainPtr nsImage = adoptNS([[NSImage alloc] initWithCGImage:cgImage.get() size:image->size()]);
-items = @[ nsImage.get() ];
+auto cgImage = image->makeCGImage();
+auto nsImage = adoptNS([[NSImage alloc] initWithCGImage:cgImage.get() size:image->size()]);
+
+auto itemProvider = adoptNS([[NSItemProvider alloc] initWithItem:[nsImage TIFFRepresentation] typeIdentifier:(__bridge NSString *)kUTTypeTIFF]);
+
+items = @[ itemProvider.get() ];
 } else if (!context.controlledSelectionData().isEmpty()) {
 RetainPtr selectionData = adoptNS([[NSData alloc] initWithBytes:(void*)context.controlledSelectionData().data() length:context.controlledSelectionData().size()]);
 RetainPtr selection = adoptNS([[NSAttributedString alloc] initWithRTFD:selectionData.get() documentAttributes:nil]);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191298] trunk/Tools

[changseok . oh]

Title: [191298] trunk/Tools








Revision 191298
Author changseok...@collabora.com
Date 2015-10-19 11:01:07 -0700 (Mon, 19 Oct 2015)


Log Message
REGRESSION(r190262): User media unit test failures after r190262
https://bugs.webkit.org/show_bug.cgi?id=149580

Reviewed by Carlos Garcia Campos.

The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
So we do not need to skip them anymore.

* Scripts/run-gtk-tests:
(TestRunner): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Tools/ChangeLog (191297 => 191298)

--- trunk/Tools/ChangeLog	2015-10-19 17:58:49 UTC (rev 191297)
+++ trunk/Tools/ChangeLog	2015-10-19 18:01:07 UTC (rev 191298)
@@ -1,3 +1,16 @@
+2015-10-19  ChangSeok Oh  
+
+REGRESSION(r190262): User media unit test failures after r190262
+https://bugs.webkit.org/show_bug.cgi?id=149580
+
+Reviewed by Carlos Garcia Campos.
+
+The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
+So we do not need to skip them anymore.
+
+* Scripts/run-gtk-tests:
+(TestRunner): Deleted.
+
 2015-10-19  Csaba Osztrogonác  
 
 Add historical addresses to contributors.json


Modified: trunk/Tools/Scripts/run-gtk-tests (191297 => 191298)

--- trunk/Tools/Scripts/run-gtk-tests	2015-10-19 17:58:49 UTC (rev 191297)
+++ trunk/Tools/Scripts/run-gtk-tests	2015-10-19 18:01:07 UTC (rev 191298)
@@ -62,7 +62,6 @@
 
 SKIPPED = [
 SkippedTest("WebKit2Gtk/TestUIClient", "/webkit2/WebKitWebView/mouse-target", "Test times out after r150890", 117689),
-SkippedTest("WebKit2Gtk/TestUIClient", "/webkit2/WebKitWebView/usermedia-permission-requests", "Test fails after r190262", 149580),
 SkippedTest("WebKit2Gtk/TestCookieManager", "/webkit2/WebKitCookieManager/persistent-storage", "Test is flaky", 134580),
 SkippedTest("WebKit2Gtk/TestWebExtensions", "/webkit2/WebKitWebView/install-missing-plugins-permission-request", "Test times out", 147822),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
@@ -75,7 +74,6 @@
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.DidAssociateFormControls", "Test times out", 120302),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.InjectedBundleFrameHitTest", "Test times out", 120303),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.TerminateTwice", "Test causes crash on the next test", 121970),
-SkippedTest("WebKit2/TestWebKit2", "WebKit2.UserMediaBasic", "Test crashes after r190262", 149580),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.GeolocationTransitionToHighAccuracy", "Test causes crash on the next test", 125068),
 SkippedTest("WebKit2/TestWebKit2", "WebKit2.GeolocationTransitionToLowAccuracy", "Test causes crash on the next test", 125068),
 ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191299] trunk/Source

[timothy_horton]

Title: [191299] trunk/Source








Revision 191299
Author timothy_hor...@apple.com
Date 2015-10-19 11:10:58 -0700 (Mon, 19 Oct 2015)


Log Message
Add magnify and rotate gesture event support for Mac
https://bugs.webkit.org/show_bug.cgi?id=150179


Reviewed by Darin Adler.

No new tests.

* Configurations/FeatureDefines.xcconfig:
New feature flag.

* Configurations/WebCore.xcconfig:
Don't exclude generated gesture sources; they are already #ifdef-guarded.

* DerivedSources.make:
Add GestureEvent.idl for ENABLE_MAC_GESTURE_EVENTS too.

* WebCore.xcodeproj/project.pbxproj:
Add GestureEvents.cpp.

* bindings/objc/DOMEvents.mm:
(kitClass):
Support DOMGestureEvent on Mac if the new flag is enabled.

* dom/mac/GestureEvents.cpp: Added.
* page/mac/EventHandlerMac.mm:

* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
* page/EventHandler.h:
Enable some gesture-related code on Mac if the new flag is enabled.

* platform/PlatformEvent.h:

* Configurations/FeatureDefines.xcconfig:
New feature flag.

* Shared/NativeWebGestureEvent.h: Added.
(WebKit::NativeWebGestureEvent::nativeEvent):
* Shared/WebEvent.h:
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::platform):
* Shared/WebEventConversion.h:
* Shared/mac/NativeWebGestureEventMac.mm: Added.
(WebKit::webEventTypeForNSEvent):
(WebKit::pointForEvent):
(WebKit::NativeWebGestureEvent::NativeWebGestureEvent):
Add and plumb a new native event that wraps a NSEvent of type
NSEventTypeMagnify or NSEventTypeRotate (gesture events).

* Shared/mac/WebGestureEvent.cpp: Added.
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):
(WebKit::WebGestureEvent::isGestureEventType):
* Shared/mac/WebGestureEvent.h: Added.
(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::position):
(WebKit::WebGestureEvent::gestureScale):
(WebKit::WebGestureEvent::gestureRotation):
Add IPC plumbing for WebGestureEvent, which becomes a WebCore::PlatformGestureEvent.

* UIProcess/API/Cocoa/WKViewPrivate.h:
Remove unnecessary iPhone-only WKView code.
Add _gestureEventWasNotHandledByWebCore, SPI which can be overridden
to react when WebCore decides not to handle a gesture event.

* UIProcess/API/mac/WKView.mm:
(-[WKView magnifyWithEvent:]):
Route magnification gesture events to the page, unless we're already
in an active view zoom gesture, in which case we'll bypass the page
and send the event straight to ViewGestureController.

(-[WKView rotateWithEvent:]):
Route rotation gesture events to the page.

(-[WKView _gestureEventWasNotHandledByWebCore:]):
Let ViewGestureController know that WebCore didn't handle a gesture event.
We always give WebCore the first crack at the event if we're not in a zoom,
because it could preventDefault() on the Begin phase event, and that should
prevent pinch-zoom from starting.

* UIProcess/PageClient.h:
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::gestureEventWasNotHandledByWebCore):
Plumb gestureEventWasNotHandledByWebCore back from WebPageProxy to WKView.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::didReceiveEvent):
* UIProcess/WebPageProxy.h:
Forward gesture events to EventDispatcher, and let WKView know when WebCore
passes on handling them.

* UIProcess/mac/ViewGestureController.h:
(WebKit::ViewGestureController::hasActiveMagnificationGesture):
* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::gestureEventWasNotHandledByWebCore):
(WebKit::ViewGestureController::handleMagnificationGestureEvent):
Don't try to start a zoom with anything other than a Begin phase event.
Try to start a zoom with any events that WebCore doesn't handle.
Move dispatch of endMagnificationGesture into ViewGestureController;
there is no reason for that to be in WKView anymore.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::gestureEvent):
(WebKit::EventDispatcher::dispatchGestureEvent):
* WebProcess/WebPage/EventDispatcher.h:
* WebProcess/WebPage/EventDispatcher.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleGestureEvent):
(WebKit::WebPage::gestureEvent):
* WebProcess/WebPage/WebPage.h:
Dispatch to the main thread and hand off the gesture event to WebCore,
asynchronously informing the UI process of whether the event was handled or not.

* Configurations/FeatureDefines.xcconfig:
New feature flag.

* Configurations/FeatureDefines.xcconfig:
New feature flag.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

[webkit-changes] [191301] trunk/Source/WebCore

[achristensen]

Title: [191301] trunk/Source/WebCore








Revision 191301
Author achristen...@apple.com
Date 2015-10-19 11:50:26 -0700 (Mon, 19 Oct 2015)


Log Message
Unreviewed build fix after r191295.

* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::clipOut):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::flush):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scalePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::rotatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::translatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::syncContext):
(WebCore::GraphicsContextPlatformPrivate::scale): Deleted.
(WebCore::GraphicsContextPlatformPrivate::rotate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::translate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191300 => 191301)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 18:32:30 UTC (rev 191300)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 18:50:26 UTC (rev 191301)
@@ -1,3 +1,33 @@
+2015-10-19  Alex Christensen  
+
+Unreviewed build fix after r191295.
+
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+(WebCore::GraphicsContext::translatePlatformCTM):
+(WebCore::GraphicsContext::setPlatformFillColor):
+(WebCore::GraphicsContext::concatPlatformCTM):
+(WebCore::GraphicsContext::setPlatformCTM):
+(WebCore::GraphicsContext::setPlatformShadow):
+(WebCore::GraphicsContext::rotatePlatformCTM):
+(WebCore::GraphicsContext::scalePlatformCTM):
+(WebCore::GraphicsContext::clipOut):
+* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
+(WebCore::GraphicsContextPlatformPrivate::save):
+(WebCore::GraphicsContextPlatformPrivate::restore):
+(WebCore::GraphicsContextPlatformPrivate::flush):
+(WebCore::GraphicsContextPlatformPrivate::clip):
+(WebCore::GraphicsContextPlatformPrivate::scalePlatformCTM):
+(WebCore::GraphicsContextPlatformPrivate::rotatePlatformCTM):
+(WebCore::GraphicsContextPlatformPrivate::translatePlatformCTM):
+(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
+(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
+(WebCore::GraphicsContextPlatformPrivate::syncContext):
+(WebCore::GraphicsContextPlatformPrivate::scale): Deleted.
+(WebCore::GraphicsContextPlatformPrivate::rotate): Deleted.
+(WebCore::GraphicsContextPlatformPrivate::translate): Deleted.
+(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
+(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
+
 2015-10-19  Tim Horton  
 
 Add magnify and rotate gesture event support for Mac


Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (191300 => 191301)

--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp	2015-10-19 18:32:30 UTC (rev 191300)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp	2015-10-19 18:50:26 UTC (rev 191301)
@@ -726,7 +726,7 @@
 
 cairo_t* cr = platformContext()->cr();
 cairo_translate(cr, x, y);
-m_data->translate(x, y);
+m_data->translatePlatformCTM(x, y);
 }
 
 void GraphicsContext::setPlatformFillColor(const Color&, ColorSpace)
@@ -789,7 +789,7 @@
 cairo_t* cr = platformContext()->cr();
 const cairo_matrix_t matrix = cairo_matrix_t(transform);
 cairo_transform(cr, );
-m_data->concatCTM(transform);
+m_data->concatPlatformCTM(transform);
 }
 
 void GraphicsContext::setPlatformCTM(const AffineTransform& transform)
@@ -800,7 +800,7 @@
 cairo_t* cr = platformContext()->cr();
 const cairo_matrix_t matrix = cairo_matrix_t(transform);
 cairo_set_matrix(cr, );
-m_data->setCTM(transform);
+m_data->setPlatformCTM(transform);
 }
 
 void GraphicsContext::setPlatformShadow(FloatSize const& size, float, Color const&, ColorSpace)
@@ 

[webkit-changes] [191322] trunk/LayoutTests

[timothy_horton]

Title: [191322] trunk/LayoutTests








Revision 191322
Author timothy_hor...@apple.com
Date 2015-10-19 17:05:27 -0700 (Mon, 19 Oct 2015)


Log Message
Don't dump GestureEvent constructor attributes for now

Rubber-stamped by Alexey Proskuryakov.

* js/dom/script-tests/global-constructors-attributes.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/script-tests/global-constructors-attributes.js




Diff

Modified: trunk/LayoutTests/ChangeLog (191321 => 191322)

--- trunk/LayoutTests/ChangeLog	2015-10-20 00:01:39 UTC (rev 191321)
+++ trunk/LayoutTests/ChangeLog	2015-10-20 00:05:27 UTC (rev 191322)
@@ -1,3 +1,11 @@
+2015-10-19  Tim Horton  
+
+Don't dump GestureEvent constructor attributes for now
+
+Rubber-stamped by Alexey Proskuryakov.
+
+* js/dom/script-tests/global-constructors-attributes.js:
+
 2015-10-19  Ryan Haddad  
 
 Rebaselining fast/dynamic/insert-before-table-part-in-continuation.html for win


Modified: trunk/LayoutTests/js/dom/script-tests/global-constructors-attributes.js (191321 => 191322)

--- trunk/LayoutTests/js/dom/script-tests/global-constructors-attributes.js	2015-10-20 00:01:39 UTC (rev 191321)
+++ trunk/LayoutTests/js/dom/script-tests/global-constructors-attributes.js	2015-10-20 00:05:27 UTC (rev 191322)
@@ -86,7 +86,8 @@
 "webkitIDBKeyRange", 
 "webkitIDBObjectStore", 
 "webkitIDBRequest", 
-"webkitIDBTransaction" ];
+"webkitIDBTransaction",
+"GestureEvent" ];
 
 var global = this;
 var constructorNames = constructorPropertiesOnGlobalObject(global);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191324] trunk/Source/WebCore

[mmaxfield]

Title: [191324] trunk/Source/WebCore








Revision 191324
Author mmaxfi...@apple.com
Date 2015-10-19 17:36:03 -0700 (Mon, 19 Oct 2015)


Log Message
Host GraphicsContext's CTM inside GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=150146

There are 6 operations which interact with CTMs:
- Get
- Set
- Concatenate
- Scale
- Rotate
- Translate

This patch modifies all these operations so that these operations shadow the
platform's CTM inside GraphicsContextState. This way, we don't have to consult
with the underlying graphics context in order to know the current CTM.

There are currently many places in the Core Graphics ports where we will change
the platform's CTM out from under the GraphicsContext. This patch migrates
those users to going through GraphicsContext, thereby preserving the integrity
of the shadowed state.

No new tests because there is no behavior change.

* platform/graphics/GraphicsContext.cpp: Setters deletate to platform calls.
The getter can just consult with the shadowed state.
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::checkCTMInvariants): Make sure the shadowed state
matches the platform graphics context's state.
* platform/graphics/Image.h:
(WebCore::Image::nativeImageForCurrentFrame):
* platform/graphics/cairo/GraphicsContextCairo.cpp: Renaming functions.
(WebCore::GraphicsContext::resetPlatformCTM):
(WebCore::GraphicsContext::getPlatformCTM):
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::getCTM): Deleted.
(WebCore::GraphicsContext::translate): Deleted.
(WebCore::GraphicsContext::concatCTM): Deleted.
(WebCore::GraphicsContext::setCTM): Deleted.
(WebCore::GraphicsContext::rotate): Deleted.
(WebCore::GraphicsContext::scale): Deleted.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
Renaming functions.
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::flush):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scalePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::rotatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::translatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::scale): Deleted.
(WebCore::GraphicsContextPlatformPrivate::rotate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::translate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
* platform/graphics/cg/GraphicsContextCG.cpp: Renaming functions. Also,
migrate CTM setters to go through GraphicsContext.
(WebCore::GraphicsContext::resetPlatformCTM):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::scalePlatformCTM):
(WebCore::GraphicsContext::rotatePlatformCTM):
(WebCore::GraphicsContext::translatePlatformCTM):
(WebCore::GraphicsContext::concatPlatformCTM):
(WebCore::GraphicsContext::setPlatformCTM):
(WebCore::GraphicsContext::getPlatformCTM):
(WebCore::GraphicsContext::scale): Deleted.
(WebCore::GraphicsContext::rotate): Deleted.
(WebCore::GraphicsContext::translate): Deleted.
(WebCore::GraphicsContext::concatCTM): Deleted.
(WebCore::GraphicsContext::setCTM): Deleted.
(WebCore::GraphicsContext::getCTM): Deleted.
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::flush):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scalePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::rotatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::translatePlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::concatPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::setPlatformCTM):
(WebCore::GraphicsContextPlatformPrivate::scale): Deleted.
(WebCore::GraphicsContextPlatformPrivate::rotate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::translate): Deleted.
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Deleted.
(WebCore::GraphicsContextPlatformPrivate::setCTM): Deleted.
* 

[webkit-changes] [191319] trunk/Source/WebCore

[simon . fraser]

Title: [191319] trunk/Source/WebCore








Revision 191319
Author simon.fra...@apple.com
Date 2015-10-19 15:20:45 -0700 (Mon, 19 Oct 2015)


Log Message
Restore an assertion to the way it was before r191310, which was correct.

* platform/graphics/GraphicsTypes.cpp:
(WebCore::compositeOperatorName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsTypes.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (191318 => 191319)

--- trunk/Source/WebCore/ChangeLog	2015-10-19 21:39:31 UTC (rev 191318)
+++ trunk/Source/WebCore/ChangeLog	2015-10-19 22:20:45 UTC (rev 191319)
@@ -1,3 +1,10 @@
+2015-10-19  Simon Fraser  
+
+Restore an assertion to the way it was before r191310, which was correct.
+
+* platform/graphics/GraphicsTypes.cpp:
+(WebCore::compositeOperatorName):
+
 2015-10-19  Beth Dakin  
 
 Build fix.


Modified: trunk/Source/WebCore/platform/graphics/GraphicsTypes.cpp (191318 => 191319)

--- trunk/Source/WebCore/platform/graphics/GraphicsTypes.cpp	2015-10-19 21:39:31 UTC (rev 191318)
+++ trunk/Source/WebCore/platform/graphics/GraphicsTypes.cpp	2015-10-19 22:20:45 UTC (rev 191319)
@@ -112,7 +112,7 @@
 ASSERT(op >= 0);
 ASSERT(op < numCompositeOperatorNames);
 ASSERT(blendOp >= BlendModeNormal);
-ASSERT(blendOp < numBlendOperatorNames);
+ASSERT(blendOp <= numBlendOperatorNames);
 if (blendOp > BlendModeNormal)
 return blendOperatorNames[blendOp - BlendModeNormal];
 return compositeOperatorNames[op];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191320] trunk/Source

[timothy_horton]

Title: [191320] trunk/Source








Revision 191320
Author timothy_hor...@apple.com
Date 2015-10-19 15:32:59 -0700 (Mon, 19 Oct 2015)


Log Message
WKView being inside WKWebView leads to weird API issues
https://bugs.webkit.org/show_bug.cgi?id=150174

Reviewed by Darin Adler.

No new tests, just moving code around.

* WebCore.xcodeproj/project.pbxproj:
* platform/spi/mac/NSWindowSPI.h: Added.

* UIProcess/API/mac/WKView.mm:
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/Cocoa/WebViewImpl.h: Added.
* UIProcess/Cocoa/WebViewImpl.mm: Added.
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::setDrawsBackground):
(WebKit::WebViewImpl::drawsBackground):
(WebKit::WebViewImpl::setDrawsTransparentBackground):
(WebKit::WebViewImpl::drawsTransparentBackground):
(WebKit::WebViewImpl::acceptsFirstResponder):
(WebKit::WebViewImpl::becomeFirstResponder):
(WebKit::WebViewImpl::resignFirstResponder):
(WebKit::WebViewImpl::isFocused):
(WebKit::WebViewImpl::viewWillStartLiveResize):
(WebKit::WebViewImpl::viewDidEndLiveResize):
(WebKit::WebViewImpl::setFrameSize):
(WebKit::WebViewImpl::disableFrameSizeUpdates):
(WebKit::WebViewImpl::enableFrameSizeUpdates):
(WebKit::WebViewImpl::frameSizeUpdatesDisabled):
(WebKit::WebViewImpl::setFrameAndScrollBy):
(WebKit::WebViewImpl::setFixedLayoutSize):
(WebKit::WebViewImpl::fixedLayoutSize):
(WebKit::WebViewImpl::setDrawingAreaSize):
(WebKit::WebViewImpl::setContentPreparationRect):
(WebKit::WebViewImpl::updateViewExposedRect):
(WebKit::WebViewImpl::setClipsToVisibleRect):
(WebKit::WebViewImpl::setIntrinsicContentSize):
(WebKit::WebViewImpl::intrinsicContentSize):
(WebKit::WebViewImpl::setViewScale):
(WebKit::WebViewImpl::viewScale):
(WebKit::WebViewImpl::layoutMode):
(WebKit::WebViewImpl::setLayoutMode):
(WebKit::WebViewImpl::supportsArbitraryLayoutModes):
(WebKit::WebViewImpl::updateSupportsArbitraryLayoutModes):
(WebKit::WebViewImpl::updateSecureInputState):
(WebKit::WebViewImpl::resetSecureInputState):
(WebKit::WebViewImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::WebViewImpl::hasFullScreenWindowController):
(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::closeFullScreenWindowController):
(WebKit::WebViewImpl::fullScreenPlaceholderView):
(WebKit::WebViewImpl::createFullScreenWindow):
Move the actual implementation of a number of WKView methods into a
C++ class, WebViewImpl, which WKView calls directly into.
Eventually, we will move all of the logic of WKView into WebViewImpl,
and then duplicate the necessary forwarding in WKWebView and remove
WKWebView's inner WKView.

* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::updateSecureInputState):
(WebKit::PageClientImpl::resetSecureInputState):
(WebKit::PageClientImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):
For now, forward PageClient requests that can be answered by WebViewImpl
to WebViewImpl. Eventually, we'll probably fold PageClientImpl and WebViewImpl
together into one class, and these things will collapse down.

* UIProcess/mac/WKFullScreenWindowController.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:webView:page:]):
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(-[WKFullScreenWindowController _manager]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController initWithWindow:webView:]): Deleted.
(-[WKFullScreenWindowController _page]): Deleted.
* UIProcess/mac/WKViewLayoutStrategy.h:
* UIProcess/mac/WKViewLayoutStrategy.mm:
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewLayoutStrategy invalidate]):
(-[WKViewLayoutStrategy didChangeFrameSize]):
(-[WKViewViewSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewFixedSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy initWithPage:view:viewImpl:mode:]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy updateLayout]):
(-[WKViewDynamicSizeComputedFromViewScaleLayoutStrategy didChangeFrameSize]):
(-[WKViewDynamicSizeComputedFromMinimumDocumentSizeLayoutStrategy initWithPage:view:viewImpl:mode:]):
(+[WKViewLayoutStrategy layoutStrategyWithPage:view:mode:]): Deleted.
(-[WKViewLayoutStrategy initWithPage:view:mode:]): Deleted.

[webkit-changes] [191323] trunk/Source

[timothy_horton]

Title: [191323] trunk/Source








Revision 191323
Author timothy_hor...@apple.com
Date 2015-10-19 17:17:17 -0700 (Mon, 19 Oct 2015)


Log Message
Remove unused support for long presses from WebKit
https://bugs.webkit.org/show_bug.cgi?id=150345

Reviewed by Beth Dakin.

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/APIUIClient.h:
(API::UIClient::didBeginTrackingPotentialLongMousePress): Deleted.
(API::UIClient::didRecognizeLongMousePress): Deleted.
(API::UIClient::didCancelTrackingPotentialLongMousePress): Deleted.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient): Deleted.
* UIProcess/API/C/WKPageUIClient.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetLongMousePressEnabled):
(WKPreferencesSetLongMousePressEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBeginTrackingPotentialLongMousePress): Deleted.
(WebKit::WebPageProxy::didRecognizeLongMousePress): Deleted.
(WebKit::WebPageProxy::didCancelTrackingPotentialLongMousePress): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:
(API::InjectedBundle::PageUIClient::didBeginTrackingPotentialLongMousePress): Deleted.
(API::InjectedBundle::PageUIClient::didRecognizeLongMousePress): Deleted.
(API::InjectedBundle::PageUIClient::didCancelTrackingPotentialLongMousePress): Deleted.
* WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::didBeginTrackingPotentialLongMousePress): Deleted.
(WebKit::InjectedBundlePageUIClient::didRecognizeLongMousePress): Deleted.
(WebKit::InjectedBundlePageUIClient::didCancelTrackingPotentialLongMousePress): Deleted.
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress): Deleted.
(WebKit::WebChromeClient::didRecognizeLongMousePress): Deleted.
(WebKit::WebChromeClient::didCancelTrackingPotentialLongMousePress): Deleted.
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Deleted.

* page/Chrome.cpp:
(WebCore::Chrome::didBeginTrackingPotentialLongMousePress): Deleted.
(WebCore::Chrome::didRecognizeLongMousePress): Deleted.
(WebCore::Chrome::didCancelTrackingPotentialLongMousePress): Deleted.
* page/Chrome.h:
* page/ChromeClient.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler): Deleted.
(WebCore::EventHandler::clear): Deleted.
(WebCore::EventHandler::handleMousePressEvent): Deleted.
(WebCore::EventHandler::eventMayStartDrag): Deleted.
(WebCore::EventHandler::handleMouseReleaseEvent): Deleted.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress): Deleted.
(WebCore::EventHandler::recognizeLongMousePress): Deleted.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress): Deleted.
(WebCore::EventHandler::clearLongMousePressState): Deleted.
(WebCore::EventHandler::handleLongMousePressMouseMovedEvent): Deleted.
(WebCore::EventHandler::handleMouseMoveEvent): Deleted.
(WebCore::EventHandler::handleDrag): Deleted.
* page/EventHandler.h:
* page/Settings.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Chrome.cpp
trunk/Source/WebCore/page/Chrome.h
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/UIProcess/API/APIUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPageUIClient.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (191322 => 191323)

--- trunk/Source/WebCore/ChangeLog	2015-10-20 00:05:27 UTC (rev 191322)
+++ trunk/Source/WebCore/ChangeLog	2015-10-20 00:17:17 UTC (rev 191323)
@@ -1,5 +1,34 @@
 2015-10-19  Tim Horton  
 
+Remove unused support for long presses from WebKit
+https://bugs.webkit.org/show_bug.cgi?id=150345
+
+Reviewed by Beth Dakin.
+
+   

[webkit-changes] [191321] trunk/Source/WebKit2

[cdumez]

Title: [191321] trunk/Source/WebKit2








Revision 191321
Author cdu...@apple.com
Date 2015-10-19 17:01:39 -0700 (Mon, 19 Oct 2015)


Log Message
Make sure development Safari does not delete the stable Safari cache storage.
https://bugs.webkit.org/show_bug.cgi?id=150343

Reviewed by Antti Koivisto.

Make sure development Safari does not delete the stable Safari disk cache
storage. Development Safari now uses Version 5, while the last stable
Safari uses Version 4. Since the 2 versions can co-exist, it is best not
to drop the old cache version (4) at this point.

* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::deleteOldVersions):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (191320 => 191321)

--- trunk/Source/WebKit2/ChangeLog	2015-10-19 22:32:59 UTC (rev 191320)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-20 00:01:39 UTC (rev 191321)
@@ -1,3 +1,18 @@
+2015-10-19  Chris Dumez  
+
+Make sure development Safari does not delete the stable Safari cache storage.
+https://bugs.webkit.org/show_bug.cgi?id=150343
+
+Reviewed by Antti Koivisto.
+
+Make sure development Safari does not delete the stable Safari disk cache
+storage. Development Safari now uses Version 5, while the last stable
+Safari uses Version 4. Since the 2 versions can co-exist, it is best not
+to drop the old cache version (4) at this point.
+
+* NetworkProcess/cache/NetworkCacheStorage.cpp:
+(WebKit::NetworkCache::Storage::deleteOldVersions):
+
 2015-10-19  Tim Horton  
 
 WKView being inside WKWebView leads to weird API issues


Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (191320 => 191321)

--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp	2015-10-19 22:32:59 UTC (rev 191320)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp	2015-10-20 00:01:39 UTC (rev 191321)
@@ -1028,6 +1028,13 @@
 if (directoryVersion >= version)
 return;
 
+#if PLATFORM(MAC)
+// Allow the last stable version of the cache to co-exist with the latest development one on Mac.
+const unsigned lastStableVersion = 4;
+if (directoryVersion == lastStableVersion)
+return;
+#endif
+
 auto oldVersionPath = WebCore::pathByAppendingComponent(cachePath, subdirName);
 LOG(NetworkCacheStorage, "(NetworkProcess) deleting old cache version, path %s", oldVersionPath.utf8().data());
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191327] trunk/Source/WebCore

[cdumez]

Title: [191327] trunk/Source/WebCore








Revision 191327
Author cdu...@apple.com
Date 2015-10-19 20:29:34 -0700 (Mon, 19 Oct 2015)


Log Message
Drop unnecessary Node::toInputElement() virtual function
https://bugs.webkit.org/show_bug.cgi?id=150341

Reviewed by Darin Adler.

Drop unnecessary Node::toInputElement() virtual function and use the
usual is() / downcast< HTMLInputElement >() instead.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/StyleResolver.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/editing/TextIterator.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/RadioNodeList.cpp
trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/rendering/RenderButton.cpp
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/testing/Internals.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (191326 => 191327)

--- trunk/Source/WebCore/ChangeLog	2015-10-20 02:43:59 UTC (rev 191326)
+++ trunk/Source/WebCore/ChangeLog	2015-10-20 03:29:34 UTC (rev 191327)
@@ -1,3 +1,13 @@
+2015-10-19  Chris Dumez  
+
+Drop unnecessary Node::toInputElement() virtual function
+https://bugs.webkit.org/show_bug.cgi?id=150341
+
+Reviewed by Darin Adler.
+
+Drop unnecessary Node::toInputElement() virtual function and use the
+usual is() / downcast< HTMLInputElement >() instead.
+
 2015-10-19  Commit Queue  
 
 Unreviewed, rolling out r191324.


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (191326 => 191327)

--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2015-10-20 02:43:59 UTC (rev 191326)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2015-10-20 03:29:34 UTC (rev 191327)
@@ -1316,11 +1316,8 @@
 if (!domNode)
 return;
 
-if (domNode->isHTMLElement()) {
-HTMLInputElement* inputElement = domNode->toInputElement();
-if (inputElement && inputElement->isPasswordField())
-return;
-}
+if (is(*domNode) && downcast(*domNode).isPasswordField())
+return;
 
 // find or create an accessibility object for this node
 AXObjectCache* cache = domNode->document().axObjectCache();


Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (191326 => 191327)

--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp	2015-10-20 02:43:59 UTC (rev 191326)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp	2015-10-20 03:29:34 UTC (rev 191327)
@@ -494,10 +494,11 @@
 if (roleValue() == SearchFieldRole)
 return true;
 
-HTMLInputElement* inputElement = node->toInputElement();
-if (!inputElement)
+if (!is(*node))
 return false;
 
+auto& inputElement = downcast(*node);
+
 // Some websites don't label their search fields as such. However, they will
 // use the word "search" in either the form or input type. This won't catch every case,
 // but it will catch google.com for example.
@@ -508,7 +509,7 @@
 return true;
 
 // Check the form action and the name, which will sometimes be "search".
-HTMLFormElement* form = inputElement->form();
+auto* form = inputElement.form();
 if (form && (form->name().contains("search", false) || form->action().contains("search", false)))
 return true;
 
@@ -542,18 +543,14 @@
 
 bool AccessibilityNodeObject::isPasswordField() const
 {
-Node* node = this->node();
-if (!node || !node->isHTMLElement())
+auto* node = this->node();
+if (!is(node))
 return false;
 
 if (ariaRoleAttribute() != UnknownRole)
 return false;
 
-HTMLInputElement* inputElement = node->toInputElement();
-if (!inputElement)
-return false;
-
-return inputElement->isPasswordField();
+return downcast(*node).isPasswordField();
 }
 
 AccessibilityObject* AccessibilityNodeObject::passwordFieldOrContainingPasswordField()
@@ -562,16 +559,14 @@
 if (!node)
 return nullptr;
 
-if (HTMLInputElement* inputElement = node->toInputElement()) {
-if (inputElement->isPasswordField())
-return this;
-}
+if (is(*node) && downcast(*node).isPasswordField())
+return this;
 
-Element* element = node->shadowHost();
-if (!element || !is(element))
+auto* element = node->shadowHost();
+if (!is(element))
 return nullptr;
 
-if (AXObjectCache* cache = axObjectCache())
+if (auto* cache = axObjectCache())
 return cache->getOrCreate(element);
 
 

[webkit-changes] [191329] branches/safari-601-branch/Source

[matthew_hanson]

Title: [191329] branches/safari-601-branch/Source








Revision 191329
Author matthew_han...@apple.com
Date 2015-10-19 20:39:44 -0700 (Mon, 19 Oct 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig (191328 => 191329)

--- branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-20 03:37:34 UTC (rev 191328)
+++ branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-20 03:39:44 UTC (rev 191329)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig (191328 => 191329)

--- branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-20 03:37:34 UTC (rev 191328)
+++ branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-20 03:39:44 UTC (rev 191329)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (191328 => 191329)

--- branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-20 03:37:34 UTC (rev 191328)
+++ branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-20 03:39:44 UTC (rev 191329)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig (191328 => 191329)

--- branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-20 03:37:34 UTC (rev 191328)
+++ branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-20 03:39:44 UTC (rev 191329)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig (191328 => 191329)

--- branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-20 03:37:34 UTC (rev 191328)
+++ branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-20 03:39:44 UTC (rev 191329)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 3;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191326] trunk/Source/WebCore

[commit-queue]

Title: [191326] trunk/Source/WebCore








Revision 191326
Author commit-qu...@webkit.org
Date 2015-10-19 19:43:59 -0700 (Mon, 19 Oct 2015)


Log Message
Unreviewed, rolling out r191324.
https://bugs.webkit.org/show_bug.cgi?id=150352

Shadowing CTM's state is not necessary (Requested by litherum
on #webkit).

Reverted changeset:

"Host GraphicsContext's CTM inside GraphicsContextState"
https://bugs.webkit.org/show_bug.cgi?id=150146
http://trac.webkit.org/changeset/191324

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/Image.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h
trunk/Source/WebCore/platform/graphics/transforms/AffineTransform.h
trunk/Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp
trunk/Source/WebCore/platform/mac/DragImageMac.mm
trunk/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (191325 => 191326)

--- trunk/Source/WebCore/ChangeLog	2015-10-20 02:23:44 UTC (rev 191325)
+++ trunk/Source/WebCore/ChangeLog	2015-10-20 02:43:59 UTC (rev 191326)
@@ -1,3 +1,17 @@
+2015-10-19  Commit Queue  
+
+Unreviewed, rolling out r191324.
+https://bugs.webkit.org/show_bug.cgi?id=150352
+
+Shadowing CTM's state is not necessary (Requested by litherum
+on #webkit).
+
+Reverted changeset:
+
+"Host GraphicsContext's CTM inside GraphicsContextState"
+https://bugs.webkit.org/show_bug.cgi?id=150146
+http://trac.webkit.org/changeset/191324
+
 2015-10-19  Myles C. Maxfield  
 
 Host GraphicsContext's CTM inside GraphicsContextState


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (191325 => 191326)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp	2015-10-20 02:23:44 UTC (rev 191325)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp	2015-10-20 02:43:59 UTC (rev 191326)
@@ -142,87 +142,6 @@
 restorePlatformState();
 }
 
-void GraphicsContext::concatCTM(const AffineTransform& other)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm *= other;
-concatPlatformCTM(other);
-
-checkCTMInvariants();
-}
-
-void GraphicsContext::scale(float x, float y)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm.scale(x, y);
-scalePlatformCTM(x, y);
-
-checkCTMInvariants();
-}
-
-void GraphicsContext::rotate(float angle)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm.rotate(rad2deg(angle));
-rotatePlatformCTM(angle);
-
-checkCTMInvariants();
-}
-
-void GraphicsContext::translate(float x, float y)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm.translate(x, y);
-translatePlatformCTM(x, y);
-
-checkCTMInvariants();
-}
-
-void GraphicsContext::setCTM(const AffineTransform& other)
-{
-if (paintingDisabled())
-return;
-
-checkCTMInvariants();
-
-m_state.ctm = other;
-setPlatformCTM(other);
-
-checkCTMInvariants();
-}
-
-AffineTransform GraphicsContext::getCTM(IncludeDeviceScale includeScale) const
-{
-if (paintingDisabled())
-return AffineTransform();
-
-AffineTransform result;
-if (includeScale == DefinitelyIncludeDeviceScale)
-result = m_state.userToDeviceSpaceCTM * m_state.ctm;
-else
-result = m_state.ctm;
-
-ASSERT(result.isEssentiallyEqualTo(getPlatformCTM(includeScale)));
-
-return result;
-}
-
 void GraphicsContext::drawRaisedEllipse(const FloatRect& rect, const Color& ellipseColor, ColorSpace ellipseColorSpace, const Color& shadowColor, ColorSpace shadowColorSpace)
 {
 if (paintingDisabled())
@@ -376,8 +295,6 @@
 {
 beginPlatformTransparencyLayer(opacity);
 ++m_transparencyCount;
-
-resetPlatformCTM();
 }
 
 void GraphicsContext::endTransparencyLayer()
@@ -737,8 +654,7 @@
 
 void GraphicsContext::applyDeviceScaleFactor(float deviceScaleFactor)
 {
-scale(deviceScaleFactor, deviceScaleFactor);
-
+scale(FloatSize(deviceScaleFactor, deviceScaleFactor));
 platformApplyDeviceScaleFactor(deviceScaleFactor);
 }
 


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (191325 => 191326)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2015-10-20 02:23:44 UTC (rev 191325)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2015-10-20 02:43:59 UTC (rev 191326)
@@ -156,9 +156,6 @@
 CompositeOperator compositeOperator { CompositeSourceOver };
 BlendMode 

[webkit-changes] [191328] tags/Safari-601.3.5/

[matthew_hanson]

Title: [191328] tags/Safari-601.3.5/








Revision 191328
Author matthew_han...@apple.com
Date 2015-10-19 20:37:34 -0700 (Mon, 19 Oct 2015)


Log Message
New Tag.

Added Paths

tags/Safari-601.3.5/




Diff

Property changes: tags/Safari-601.3.5



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [191330] trunk/Source/WebCore

[mmaxfield]

Title: [191330] trunk/Source/WebCore








Revision 191330
Author mmaxfi...@apple.com
Date 2015-10-19 21:22:59 -0700 (Mon, 19 Oct 2015)


Log Message
Shadow GraphicsContext's ImageInterpolationQuality inside GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=150306

Reviewed by Simon Fraser.

When getting the ImageInterpolationQuality, there is no need to round-trip through
the platform's graphics context. This patch migrates this piece of state to the
existing idiom of having a setter in GraphicsContext.cpp which sets the relevent
state in GraphicsContextState and then calls into a platform-specific setter.

No new tests because there is no behavior change.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setImageInterpolationQuality):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::imageInterpolationQuality):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::setImageInterpolationQuality): Deleted.
(WebCore::GraphicsContext::imageInterpolationQuality): Deleted.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::convertInterpolationQuality):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::setImageInterpolationQuality): Deleted.
(WebCore::GraphicsContext::imageInterpolationQuality): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (191329 => 191330)

--- trunk/Source/WebCore/ChangeLog	2015-10-20 03:39:44 UTC (rev 191329)
+++ trunk/Source/WebCore/ChangeLog	2015-10-20 04:22:59 UTC (rev 191330)
@@ -1,3 +1,32 @@
+2015-10-19  Myles C. Maxfield  
+
+Shadow GraphicsContext's ImageInterpolationQuality inside GraphicsContextState
+https://bugs.webkit.org/show_bug.cgi?id=150306
+
+Reviewed by Simon Fraser.
+
+When getting the ImageInterpolationQuality, there is no need to round-trip through
+the platform's graphics context. This patch migrates this piece of state to the
+existing idiom of having a setter in GraphicsContext.cpp which sets the relevent
+state in GraphicsContextState and then calls into a platform-specific setter.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/GraphicsContext.cpp:
+(WebCore::GraphicsContext::setImageInterpolationQuality):
+* platform/graphics/GraphicsContext.h:
+(WebCore::GraphicsContext::imageInterpolationQuality):
+* platform/graphics/cairo/GraphicsContextCairo.cpp:
+(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
+(WebCore::GraphicsContext::setImageInterpolationQuality): Deleted.
+(WebCore::GraphicsContext::imageInterpolationQuality): Deleted.
+* platform/graphics/cg/GraphicsContextCG.cpp:
+(WebCore::convertInterpolationQuality):
+(WebCore::GraphicsContext::platformInit):
+(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
+(WebCore::GraphicsContext::setImageInterpolationQuality): Deleted.
+(WebCore::GraphicsContext::imageInterpolationQuality): Deleted.
+
 2015-10-19  Chris Dumez  
 
 Drop unnecessary Node::toInputElement() virtual function


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (191329 => 191330)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp	2015-10-20 03:39:44 UTC (rev 191329)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp	2015-10-20 04:22:59 UTC (rev 191330)
@@ -262,6 +262,16 @@
 setPlatformShouldSmoothFonts(shouldSmoothFonts);
 }
 
+void GraphicsContext::setImageInterpolationQuality(InterpolationQuality imageInterpolationQuality)
+{
+m_state.imageInterpolationQuality = imageInterpolationQuality;
+
+if (paintingDisabled())
+return;
+
+setPlatformImageInterpolationQuality(imageInterpolationQuality);
+}
+
 void GraphicsContext::setAntialiasedFontDilationEnabled(bool antialiasedFontDilationEnabled)
 {
 m_state.antialiasedFontDilationEnabled = antialiasedFontDilationEnabled;


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (191329 => 191330)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2015-10-20 03:39:44 UTC (rev 191329)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2015-10-20 04:22:59 UTC (rev 191330)
@@ -155,6 +155,7 @@
 float alpha { 1 };
 CompositeOperator compositeOperator { CompositeSourceOver };
 BlendMode blendMode { BlendModeNormal };
+InterpolationQuality imageInterpolationQuality { 

[webkit-changes] [191331] trunk

[mmaxfield]

Title: [191331] trunk








Revision 191331
Author mmaxfi...@apple.com
Date 2015-10-19 21:55:27 -0700 (Mon, 19 Oct 2015)


Log Message
FontCascade::typesettingFeatures() is not privy to font-variant-* nor font-feature-settings
https://bugs.webkit.org/show_bug.cgi?id=149775

Reviewed by Darin Adler.

Source/WebCore:

This patch has two pieces:

We used to have a boolean, enableLigatures, which affected how we perform shaping in both our
simple and complex text codepaths. However, in this brave new world of font-feature-settings
and font-variant-*, there are many properties which may affect shaping (and multiple kinds
of ligatures). This patch renames this boolean to requiresShaping, and teaches it about all
the various properties which affect text shaping.

Similarly, one of the places which used this enableLigatures boolean was to tell CoreText
if it should disable ligatures. However, we now have much finer-grained control over
ligatures during font creation. This patch moves the responsibility of dictating which
font features should be enabled entirely to the Font. Therefore, getCFStringAttributes()
doesn't know anything about ligatures anymore; the logic inside font creation is used
instead.

An added benefit of moving all the font feature logic to one place is that we can implement
the feature resolution algorithm described in the CSS3 fonts spec. This patch adds a test to
makes sure that text-rendering, font-feature-settings, and font-variant-* play together
nicely.

Test: fast/text/multiple-feature-properties.html

* platform/graphics/Font.cpp:
(WebCore::Font::applyTransforms):
* platform/graphics/Font.h:
* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::FontCascade):
(WebCore::FontCascade::operator=):
(WebCore::FontCascade::update):
(WebCore::FontCascade::drawText):
(WebCore::FontCascade::drawEmphasisMarks):
(WebCore::FontCascade::width):
(WebCore::FontCascade::adjustSelectionRectForText):
(WebCore::FontCascade::offsetForPosition):
(WebCore::FontCascade::codePath):
(WebCore::FontCascade::floatWidthForSimpleText):
* platform/graphics/FontCascade.h:
(WebCore::FontCascade::requiresShaping):
(WebCore::FontCascade::computeRequiresShaping):
(WebCore::FontCascade::enableLigatures): Deleted.
(WebCore::FontCascade::computeEnableLigatures): Deleted.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::applyFontTransforms):
* platform/graphics/WidthIterator.h:
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::preparePlatformFont):
* platform/graphics/cocoa/FontCocoa.mm:
(WebCore::Font::canRenderCombiningCharacterSequence):
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
* platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::Font::getCFStringAttributes):
* svg/SVGFontData.h:

LayoutTests:

* fast/text/multiple-feature-properties-expected.html: Added.
* fast/text/multiple-feature-properties.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Font.cpp
trunk/Source/WebCore/platform/graphics/Font.h
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
trunk/Source/WebCore/platform/graphics/FontCascade.h
trunk/Source/WebCore/platform/graphics/WidthIterator.cpp
trunk/Source/WebCore/platform/graphics/WidthIterator.h
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm
trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm
trunk/Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp
trunk/Source/WebCore/svg/SVGFontData.h


Added Paths

trunk/LayoutTests/fast/text/multiple-feature-properties-expected.html
trunk/LayoutTests/fast/text/multiple-feature-properties.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191330 => 191331)

--- trunk/LayoutTests/ChangeLog	2015-10-20 04:22:59 UTC (rev 191330)
+++ trunk/LayoutTests/ChangeLog	2015-10-20 04:55:27 UTC (rev 191331)
@@ -1,3 +1,13 @@
+2015-10-19  Myles C. Maxfield  
+
+FontCascade::typesettingFeatures() is not privy to font-variant-* nor font-feature-settings
+https://bugs.webkit.org/show_bug.cgi?id=149775
+
+Reviewed by Darin Adler.
+
+* fast/text/multiple-feature-properties-expected.html: Added.
+* fast/text/multiple-feature-properties.html: Added.
+
 2015-10-19  Tim Horton  
 
 Don't dump GestureEvent constructor attributes for now


Added: trunk/LayoutTests/fast/text/multiple-feature-properties-expected.html (0 => 191331)

--- trunk/LayoutTests/fast/text/multiple-feature-properties-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/multiple-feature-properties-expected.html	2015-10-20 04:55:27 UTC (rev 191331)
@@ -0,0 +1,20 @@
+
+
+
+
+
+This test makes sure that feature resolution order is honored. For more 

[webkit-changes] [191291] trunk/Source/JavaScriptCore

[ossy]

Title: [191291] trunk/Source/_javascript_Core








Revision 191291
Author o...@webkit.org
Date 2015-10-19 09:20:08 -0700 (Mon, 19 Oct 2015)


Log Message
Fix the ENABLE(WEBASSEMBLY) build after r190827
https://bugs.webkit.org/show_bug.cgi?id=150330

Reviewed by Geoffrey Garen.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock): Removed the duplicated VM argument.
* bytecode/CodeBlock.h:
(JSC::WebAssemblyCodeBlock::create): Added new parameters to finishCreation() calls.
(JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock): Change VM parameter to pointer to match *CodeBlock classes.
* runtime/Executable.cpp:
(JSC::WebAssemblyExecutable::prepareForExecution): Removed extra ")" and pass pointer as it is expected.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/runtime/Executable.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191290 => 191291)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-19 16:13:59 UTC (rev 191290)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-19 16:20:08 UTC (rev 191291)
@@ -1,3 +1,18 @@
+2015-10-19  Csaba Osztrogonác  
+
+Fix the ENABLE(WEBASSEMBLY) build after r190827
+https://bugs.webkit.org/show_bug.cgi?id=150330
+
+Reviewed by Geoffrey Garen.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock): Removed the duplicated VM argument.
+* bytecode/CodeBlock.h:
+(JSC::WebAssemblyCodeBlock::create): Added new parameters to finishCreation() calls.
+(JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock): Change VM parameter to pointer to match *CodeBlock classes.
+* runtime/Executable.cpp:
+(JSC::WebAssemblyExecutable::prepareForExecution): Removed extra ")" and pass pointer as it is expected.
+
 2015-10-19  Mark Lam  
 
 DoubleRep fails to convert SpecBoolean values.


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (191290 => 191291)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2015-10-19 16:13:59 UTC (rev 191290)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2015-10-19 16:20:08 UTC (rev 191291)
@@ -2203,8 +2203,8 @@
 }
 
 #if ENABLE(WEBASSEMBLY)
-CodeBlock::CodeBlock(VM* vm, Structure* structure, WebAssemblyExecutable* ownerExecutable, VM& vm, JSGlobalObject* globalObject)
-: JSCell(vm, structure)
+CodeBlock::CodeBlock(VM* vm, Structure* structure, WebAssemblyExecutable* ownerExecutable, JSGlobalObject* globalObject)
+: JSCell(*vm, structure)
 , m_globalObject(globalObject->vm(), this, globalObject)
 , m_heap(_globalObject->vm().heap)
 , m_numCalleeRegisters(0)
@@ -2217,7 +2217,7 @@
 , m_steppingMode(SteppingModeDisabled)
 , m_numBreakpoints(0)
 , m_ownerExecutable(m_globalObject->vm(), this, ownerExecutable)
-, m_vm()
+, m_vm(vm)
 , m_isStrictMode(false)
 , m_needsActivation(false)
 , m_codeType(FunctionCode)


Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (191290 => 191291)

--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2015-10-19 16:13:59 UTC (rev 191290)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h	2015-10-19 16:20:08 UTC (rev 191291)
@@ -111,7 +111,7 @@
 CodeBlock(VM*, Structure*, CopyParsedBlockTag, CodeBlock& other);
 CodeBlock(VM*, Structure*, ScriptExecutable* ownerExecutable, UnlinkedCodeBlock*, JSScope*, PassRefPtr, unsigned sourceOffset, unsigned firstLineColumnOffset);
 #if ENABLE(WEBASSEMBLY)
-CodeBlock(VM*, Structure*, WebAssemblyExecutable* ownerExecutable, VM&, JSGlobalObject*);
+CodeBlock(VM*, Structure*, WebAssemblyExecutable* ownerExecutable, JSGlobalObject*);
 #endif
 
 void finishCreation(VM&, CopyParsedBlockTag, CodeBlock& other);
@@ -1286,13 +1286,14 @@
 #if ENABLE(WEBASSEMBLY)
 class WebAssemblyCodeBlock : public CodeBlock {
 public:
+typedef CodeBlock Base;
 DECLARE_INFO;
 
 static WebAssemblyCodeBlock* create(VM* vm, CopyParsedBlockTag, WebAssemblyCodeBlock& other)
 {
 WebAssemblyCodeBlock* instance = new (NotNull, allocateCell(vm->heap))
 WebAssemblyCodeBlock(vm, vm->webAssemblyCodeBlockStructure.get(), CopyParsedBlock, other);
-instance->finishCreation(*vm);
+instance->finishCreation(*vm, CopyParsedBlock, other);
 return instance;
 }
 
@@ -1300,7 +1301,7 @@
 {
 WebAssemblyCodeBlock* instance = new (NotNull, allocateCell(vm->heap))
 WebAssemblyCodeBlock(vm, vm->webAssemblyCodeBlockStructure.get(), ownerExecutable, globalObject);
-instance->finishCreation(*vm);
+instance->finishCreation(*vm, ownerExecutable, globalObject);
 return instance;
 }
 
@@ -1310,13 +1311,13 @@
 }
 
 private:
-WebAssemblyCodeBlock(VM& vm, Structure* structure, CopyParsedBlockTag, WebAssemblyCodeBlock& other)
+

[webkit-changes] [191290] trunk/Source/JavaScriptCore

[mark . lam]

Title: [191290] trunk/Source/_javascript_Core








Revision 191290
Author mark@apple.com
Date 2015-10-19 09:13:59 -0700 (Mon, 19 Oct 2015)


Log Message
DoubleRep fails to convert SpecBoolean values.
https://bugs.webkit.org/show_bug.cgi?id=150313

Reviewed by Geoffrey Garen.

This was uncovered by the op_sub stress test on 32-bit builds.  On 32-bit builds,
DoubleRep will erroneously convert 'true' to a 'NaN' instead of a double 1.
On 64-bit, the same issue exists but is masked by another bug in DoubleRep where
boolean values will always erroneously trigger a BadType OSR exit.

The erroneous conversion of 'true' to 'NaN' is because the 'true' case in
compileDoubleRep() is missing a jump to the "done" destination.  Instead, it
fall through to the "isUndefined" case where it produces a NaN.

The 64-bit erroneous BadType OSR exit is due to the boolean type check being
implemented incorrectly.  It was checking if any bits other than bit 0 were set.
However, boolean JS values always have TagBitBool (the 3rd bit) set.  Hence, the
check will always fail if we have a boolean value.

This patch fixes both of these issues.

No new test is needed because these issues are already covered by scenarios in
the op_sub.js stress test.  This patch also fixes the op_sub.js test to throw an
exception if any failures are encountered (as expected by the stress test
harness).  This patch also re-worked the test code to provide more accurate
descriptions of each test scenario for error reporting.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileDoubleRep):

* tests/stress/op_sub.js:
(generateScenarios):
(func):
(initializeTestCases):
(runTest):
(stringify): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/tests/stress/op_sub.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (191289 => 191290)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-19 16:10:16 UTC (rev 191289)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-19 16:13:59 UTC (rev 191290)
@@ -1,3 +1,42 @@
+2015-10-19  Mark Lam  
+
+DoubleRep fails to convert SpecBoolean values.
+https://bugs.webkit.org/show_bug.cgi?id=150313
+
+Reviewed by Geoffrey Garen.
+
+This was uncovered by the op_sub stress test on 32-bit builds.  On 32-bit builds,
+DoubleRep will erroneously convert 'true' to a 'NaN' instead of a double 1.
+On 64-bit, the same issue exists but is masked by another bug in DoubleRep where
+boolean values will always erroneously trigger a BadType OSR exit.
+
+The erroneous conversion of 'true' to 'NaN' is because the 'true' case in
+compileDoubleRep() is missing a jump to the "done" destination.  Instead, it
+fall through to the "isUndefined" case where it produces a NaN.
+
+The 64-bit erroneous BadType OSR exit is due to the boolean type check being
+implemented incorrectly.  It was checking if any bits other than bit 0 were set.
+However, boolean JS values always have TagBitBool (the 3rd bit) set.  Hence, the
+check will always fail if we have a boolean value.
+
+This patch fixes both of these issues.
+
+No new test is needed because these issues are already covered by scenarios in
+the op_sub.js stress test.  This patch also fixes the op_sub.js test to throw an
+exception if any failures are encountered (as expected by the stress test
+harness).  This patch also re-worked the test code to provide more accurate
+descriptions of each test scenario for error reporting.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileDoubleRep):
+
+* tests/stress/op_sub.js:
+(generateScenarios):
+(func):
+(initializeTestCases):
+(runTest):
+(stringify): Deleted.
+
 2015-10-19  Yusuke Suzuki  
 
 Drop !newTarget check since it always becomes true


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (191289 => 191290)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2015-10-19 16:10:16 UTC (rev 191289)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2015-10-19 16:13:59 UTC (rev 191290)
@@ -2196,11 +2196,12 @@
 done.append(isNull);
 
 DFG_TYPE_CHECK(JSValueRegs(op1GPR), node->child1(), ~SpecCell,
-m_jit.branchTest64(JITCompiler::NonZero, op1GPR, TrustedImm32(static_cast(~1;
+m_jit.branchTest64(JITCompiler::Zero, op1GPR, TrustedImm32(static_cast(TagBitBool;
 
 JITCompiler::Jump isFalse = m_jit.branch64(JITCompiler::Equal, op1GPR, TrustedImm64(ValueFalse));
 static const double _one_ = 1;
 m_jit.loadDouble(MacroAssembler::TrustedImmPtr(), resultFPR);
+done.append(m_jit.jump());
 done.append(isFalse);

[webkit-changes] [191292] trunk/LayoutTests

[calvaris]

Title: [191292] trunk/LayoutTests








Revision 191292
Author calva...@igalia.com
Date 2015-10-19 09:34:44 -0700 (Mon, 19 Oct 2015)


Log Message
[Streams API] Update readable-stream-controller-error tests against latest reference
https://bugs.webkit.org/show_bug.cgi?id=149700

Reviewed by Darin Adler.

* streams/readable-stream-controller-error.html: Updated tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/streams/readable-stream-controller-error.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191291 => 191292)

--- trunk/LayoutTests/ChangeLog	2015-10-19 16:20:08 UTC (rev 191291)
+++ trunk/LayoutTests/ChangeLog	2015-10-19 16:34:44 UTC (rev 191292)
@@ -1,3 +1,12 @@
+2015-10-19  Xabier Rodriguez Calvar  
+
+[Streams API] Update readable-stream-controller-error tests against latest reference
+https://bugs.webkit.org/show_bug.cgi?id=149700
+
+Reviewed by Darin Adler.
+
+* streams/readable-stream-controller-error.html: Updated tests.
+
 2015-10-19  Youenn Fablet  
 
 [Streams API] Implement ReadableStream tee


Modified: trunk/LayoutTests/streams/readable-stream-controller-error.html (191291 => 191292)

--- trunk/LayoutTests/streams/readable-stream-controller-error.html	2015-10-19 16:20:08 UTC (rev 191291)
+++ trunk/LayoutTests/streams/readable-stream-controller-error.html	2015-10-19 16:34:44 UTC (rev 191292)
@@ -2,6 +2,8 @@
 
 
 

[webkit-changes] [191293] trunk/LayoutTests

[calvaris]

Title: [191293] trunk/LayoutTests








Revision 191293
Author calva...@igalia.com
Date 2015-10-19 09:36:44 -0700 (Mon, 19 Oct 2015)


Log Message
[Streams API] Update readable-stream-reader tests to latest spec
https://bugs.webkit.org/show_bug.cgi?id=149699

Reviewed by Darin Adler.

* streams/reference-implementation/readable-stream-reader-expected.txt: Updated expectations.
* streams/reference-implementation/readable-stream-reader.html: Updated tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt
trunk/LayoutTests/streams/reference-implementation/readable-stream-reader.html




Diff

Modified: trunk/LayoutTests/ChangeLog (191292 => 191293)

--- trunk/LayoutTests/ChangeLog	2015-10-19 16:34:44 UTC (rev 191292)
+++ trunk/LayoutTests/ChangeLog	2015-10-19 16:36:44 UTC (rev 191293)
@@ -1,5 +1,15 @@
 2015-10-19  Xabier Rodriguez Calvar  
 
+[Streams API] Update readable-stream-reader tests to latest spec
+https://bugs.webkit.org/show_bug.cgi?id=149699
+
+Reviewed by Darin Adler.
+
+* streams/reference-implementation/readable-stream-reader-expected.txt: Updated expectations.
+* streams/reference-implementation/readable-stream-reader.html: Updated tests.
+
+2015-10-19  Xabier Rodriguez Calvar  
+
 [Streams API] Update readable-stream-controller-error tests against latest reference
 https://bugs.webkit.org/show_bug.cgi?id=149700
 


Modified: trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt (191292 => 191293)

--- trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt	2015-10-19 16:34:44 UTC (rev 191292)
+++ trunk/LayoutTests/streams/reference-implementation/readable-stream-reader-expected.txt	2015-10-19 16:36:44 UTC (rev 191293)
@@ -10,12 +10,12 @@
 PASS Constructing a ReadableStreamReader directly should be OK if the stream is closed 
 PASS Constructing a ReadableStreamReader directly should be OK if the stream is errored 
 PASS Reading from a reader for an empty stream will wait until a chunk is available 
-PASS cancel() on a reader releases the reader before calling through 
+FAIL cancel() on a reader does not release the reader assert_unreached: reader.cancel() should not reject Reached unreachable code
 PASS closed should be fulfilled after stream is closed (.closed access before acquiring) 
-PASS closed should be fulfilled after reader releases its lock (multiple stream locks) 
+FAIL closed should be rejected after reader releases its lock (multiple stream locks) assert_equals: expected 2 but got 1
 PASS Multiple readers can access the stream in sequence 
 PASS Cannot use an already-released reader to unlock a stream again 
-PASS cancel() on a released reader is a no-op and does not pass through 
+FAIL cancel() on a released reader is a no-op and does not pass through assert_unreached: cancel promise should not fulfill Reached unreachable code
 PASS Getting a second reader after erroring the stream should succeed 
 PASS Garbage-collecting a ReadableStreamReader should not unlock its stream 
 PASS ReadableStreamReader closed promise should be rejected with undefined if that is the error 


Modified: trunk/LayoutTests/streams/reference-implementation/readable-stream-reader.html (191292 => 191293)

--- trunk/LayoutTests/streams/reference-implementation/readable-stream-reader.html	2015-10-19 16:34:44 UTC (rev 191292)
+++ trunk/LayoutTests/streams/reference-implementation/readable-stream-reader.html	2015-10-19 16:36:44 UTC (rev 191293)
@@ -4,6 +4,8 @@
 
 
 

[webkit-changes] [191294] trunk

[cdumez]

Title: [191294] trunk








Revision 191294
Author cdu...@apple.com
Date 2015-10-19 09:52:29 -0700 (Mon, 19 Oct 2015)


Log Message
Null dereference loading Blink layout test fast/forms/color/input-color-onchange-event.html
https://bugs.webkit.org/show_bug.cgi?id=150192


Reviewed by Darin Adler.

Source/WebCore:

Calling internals.selectColorInColorChooser() with a non-Element would
cause a null dereference. This is because in such case, the implementation
method is passed a null pointer and we would fail to null-check it. This
patch now does the null-check.

No new tests, existing test was updated.

* testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser):

LayoutTests:

Import more checks from the corresponding Blink test.

* fast/forms/color/input-color-onchange-event-expected.txt:
* fast/forms/color/input-color-onchange-event.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/color/input-color-onchange-event-expected.txt
trunk/LayoutTests/fast/forms/color/input-color-onchange-event.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/Internals.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (191293 => 191294)

--- trunk/LayoutTests/ChangeLog	2015-10-19 16:36:44 UTC (rev 191293)
+++ trunk/LayoutTests/ChangeLog	2015-10-19 16:52:29 UTC (rev 191294)
@@ -1,3 +1,16 @@
+2015-10-19  Chris Dumez  
+
+Null dereference loading Blink layout test fast/forms/color/input-color-onchange-event.html
+https://bugs.webkit.org/show_bug.cgi?id=150192
+
+
+Reviewed by Darin Adler.
+
+Import more checks from the corresponding Blink test.
+
+* fast/forms/color/input-color-onchange-event-expected.txt:
+* fast/forms/color/input-color-onchange-event.html:
+
 2015-10-19  Xabier Rodriguez Calvar  
 
 [Streams API] Update readable-stream-reader tests to latest spec


Modified: trunk/LayoutTests/fast/forms/color/input-color-onchange-event-expected.txt (191293 => 191294)

--- trunk/LayoutTests/fast/forms/color/input-color-onchange-event-expected.txt	2015-10-19 16:36:44 UTC (rev 191293)
+++ trunk/LayoutTests/fast/forms/color/input-color-onchange-event-expected.txt	2015-10-19 16:52:29 UTC (rev 191294)
@@ -4,6 +4,16 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-value changed to #ff
+PASS onChangeCount is 0
+internals.selectColorInColorChooser({}, '#ff');
+internals.selectColorInColorChooser(document, '#ff');
+PASS onChangeCount is 0
+input event dispatched - value is:  #ff
+change event dispatched - value changed to #ff
+PASS onChangeCount is 1
+PASS onChangeCount is 1
 PASS input.value is "#ff"
+PASS successfullyParsed is true
 
+TEST COMPLETE
+


Modified: trunk/LayoutTests/fast/forms/color/input-color-onchange-event.html (191293 => 191294)

--- trunk/LayoutTests/fast/forms/color/input-color-onchange-event.html	2015-10-19 16:36:44 UTC (rev 191293)
+++ trunk/LayoutTests/fast/forms/color/input-color-onchange-event.html	2015-10-19 16:52:29 UTC (rev 191294)
@@ -1,7 +1,7 @@
 
 
 
-+