[webkit-changes] [191462] branches/safari-601.1.46-branch
Title: [191462] branches/safari-601.1.46-branch Revision 191462 Author matthew_han...@apple.com Date 2015-10-22 11:36:16 -0700 (Thu, 22 Oct 2015) Log Message Merge r191364. rdar://problem/22864960 Modified Paths branches/safari-601.1.46-branch/LayoutTests/ChangeLog branches/safari-601.1.46-branch/Source/_javascript_Core/ChangeLog branches/safari-601.1.46-branch/Source/_javascript_Core/yarr/YarrPattern.cpp Added Paths branches/safari-601.1.46-branch/LayoutTests/js/regress-150372-expected.txt branches/safari-601.1.46-branch/LayoutTests/js/regress-150372.html branches/safari-601.1.46-branch/LayoutTests/js/script-tests/regress-150372.js Diff Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (191461 => 191462) --- branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-10-22 18:36:09 UTC (rev 191461) +++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-10-22 18:36:16 UTC (rev 191462) @@ -1,5 +1,20 @@ 2015-10-20 Matthew Hanson+Merge r191364. rdar://problem/22864960 + +2015-10-20 Mark Lam + +YarrPatternConstructor::containsCapturingTerms() should not assume that its terms.size() is greater than 0. +https://bugs.webkit.org/show_bug.cgi?id=150372 + +Reviewed by Geoffrey Garen. + +* js/regress-150372-expected.txt: Added. +* js/regress-150372.html: Added. +* js/script-tests/regress-150372.js: Added. + +2015-10-20 Matthew Hanson + Merge r191063. rdar://problem/22900764 2015-10-14 Alex Christensen Added: branches/safari-601.1.46-branch/LayoutTests/js/regress-150372-expected.txt (0 => 191462) --- branches/safari-601.1.46-branch/LayoutTests/js/regress-150372-expected.txt (rev 0) +++ branches/safari-601.1.46-branch/LayoutTests/js/regress-150372-expected.txt 2015-10-22 18:36:16 UTC (rev 191462) @@ -0,0 +1,10 @@ +Regression test for https://bugs.webkit.org/show_bug.cgi?id=150372. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS Did not crash. +PASS successfullyParsed is true + +TEST COMPLETE + Added: branches/safari-601.1.46-branch/LayoutTests/js/regress-150372.html (0 => 191462) --- branches/safari-601.1.46-branch/LayoutTests/js/regress-150372.html (rev 0) +++ branches/safari-601.1.46-branch/LayoutTests/js/regress-150372.html 2015-10-22 18:36:16 UTC (rev 191462) @@ -0,0 +1,10 @@ + + +
[webkit-changes] [191465] trunk
Title: [191465] trunk Revision 191465 Author beid...@apple.com Date 2015-10-22 12:10:15 -0700 (Thu, 22 Oct 2015) Log Message Modern IDB: Basic createObjectStore implementation. https://bugs.webkit.org/show_bug.cgi?id=150455 Reviewed by Alex Christensen. Source/WebCore: Tests: storage/indexeddb/modern/createobjectstore-basic.html storage/indexeddb/modern/createobjectstore-failures.html * CMakeLists.txt: * WebCore.xcodeproj/project.pbxproj: * Modules/indexeddb/client/IDBConnectionToServer.cpp: (WebCore::IDBClient::IDBConnectionToServer::createObjectStore): (WebCore::IDBClient::IDBConnectionToServer::didCreateObjectStore): * Modules/indexeddb/client/IDBConnectionToServer.h: * Modules/indexeddb/client/IDBConnectionToServerDelegate.h: * Modules/indexeddb/client/IDBDatabaseImpl.cpp: (WebCore::IDBClient::IDBDatabase::objectStoreNames): (WebCore::IDBClient::IDBDatabase::createObjectStore): (WebCore::IDBClient::IDBDatabase::didAbortTransaction): * Modules/indexeddb/client/IDBDatabaseImpl.h: (WebCore::IDBClient::IDBDatabase::serverConnection): * Modules/indexeddb/client/IDBObjectStoreImpl.cpp: Added. (WebCore::IDBClient::IDBObjectStore::create): (WebCore::IDBClient::IDBObjectStore::IDBObjectStore): (WebCore::IDBClient::IDBObjectStore::~IDBObjectStore): (WebCore::IDBClient::IDBObjectStore::id): (WebCore::IDBClient::IDBObjectStore::name): (WebCore::IDBClient::IDBObjectStore::keyPathAny): (WebCore::IDBClient::IDBObjectStore::keyPath): (WebCore::IDBClient::IDBObjectStore::indexNames): (WebCore::IDBClient::IDBObjectStore::transaction): (WebCore::IDBClient::IDBObjectStore::autoIncrement): (WebCore::IDBClient::IDBObjectStore::add): (WebCore::IDBClient::IDBObjectStore::put): (WebCore::IDBClient::IDBObjectStore::openCursor): (WebCore::IDBClient::IDBObjectStore::get): (WebCore::IDBClient::IDBObjectStore::deleteFunction): (WebCore::IDBClient::IDBObjectStore::clear): (WebCore::IDBClient::IDBObjectStore::createIndex): (WebCore::IDBClient::IDBObjectStore::index): (WebCore::IDBClient::IDBObjectStore::deleteIndex): (WebCore::IDBClient::IDBObjectStore::count): * Modules/indexeddb/client/IDBObjectStoreImpl.h: Added. * Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp: (WebCore::IDBClient::IDBOpenDBRequest::requestCompleted): * Modules/indexeddb/client/IDBTransactionImpl.cpp: (WebCore::IDBClient::IDBTransaction::serverConnection): (WebCore::IDBClient::IDBTransaction::objectStore): (WebCore::IDBClient::IDBTransaction::scheduleOperation): (WebCore::IDBClient::IDBTransaction::operationTimerFired): (WebCore::IDBClient::IDBTransaction::finishAbortOrCommit): (WebCore::IDBClient::IDBTransaction::didAbort): (WebCore::IDBClient::IDBTransaction::didCommit): (WebCore::IDBClient::IDBTransaction::createObjectStore): (WebCore::IDBClient::IDBTransaction::createObjectStoreOnServer): (WebCore::IDBClient::IDBTransaction::didCreateObjectStoreOnServer): * Modules/indexeddb/client/IDBTransactionImpl.h: (WebCore::IDBClient::IDBTransaction::originalDatabaseInfo): (WebCore::IDBClient::IDBTransaction::isVersionChange): * Modules/indexeddb/client/TransactionOperation.h: Added. (WebCore::IDBClient::TransactionOperation::perform): (WebCore::IDBClient::TransactionOperation::completed): (WebCore::IDBClient::TransactionOperation::identifier): (WebCore::IDBClient::TransactionOperation::transactionIdentifier): (WebCore::IDBClient::TransactionOperation::TransactionOperation): (WebCore::IDBClient::createTransactionOperation): * Modules/indexeddb/server/IDBConnectionToClient.cpp: (WebCore::IDBServer::IDBConnectionToClient::didCreateObjectStore): * Modules/indexeddb/server/IDBConnectionToClient.h: * Modules/indexeddb/server/IDBConnectionToClientDelegate.h: * Modules/indexeddb/server/IDBServer.cpp: (WebCore::IDBServer::IDBServer::createObjectStore): * Modules/indexeddb/server/IDBServer.h: * Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::createObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::performCreateObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::didPerformCreateObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::performAbortTransaction): (WebCore::IDBServer::UniqueIDBDatabase::didPerformAbortTransaction): (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction): Deleted. * Modules/indexeddb/server/UniqueIDBDatabase.h: * Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp: (WebCore::IDBServer::UniqueIDBDatabaseConnection::didCreateObjectStore): * Modules/indexeddb/server/UniqueIDBDatabaseConnection.h: * Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp: (WebCore::IDBServer::UniqueIDBDatabaseTransaction::isVersionChange): (WebCore::IDBServer::UniqueIDBDatabaseTransaction::createObjectStore): * Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h: * Modules/indexeddb/shared/IDBDatabaseInfo.cpp: (WebCore::IDBDatabaseInfo::hasObjectStore): (WebCore::IDBDatabaseInfo::createNewObjectStore): (WebCore::IDBDatabaseInfo::addExistingObjectStore):
[webkit-changes] [191448] trunk
Title: [191448] trunk Revision 191448 Author carlo...@webkit.org Date 2015-10-22 01:56:01 -0700 (Thu, 22 Oct 2015) Log Message Unreviewed. Fix GTK+ build after r191423. Source/WebCore: Deprecate removed class WebKitDOMHTMLBaseFontElement. * PlatformGTK.cmake: * bindings/gobject/WebKitDOMDeprecated.cpp: (webkit_dom_html_base_font_element_init): (webkit_dom_html_base_font_element_class_init): (webkit_dom_html_base_font_element_get_color): (webkit_dom_html_base_font_element_set_color): (webkit_dom_html_base_font_element_get_face): (webkit_dom_html_base_font_element_set_face): (webkit_dom_html_base_font_element_get_size): (webkit_dom_html_base_font_element_set_size): * bindings/gobject/WebKitDOMDeprecated.h: * bindings/gobject/WebKitDOMDeprecated.symbols: * bindings/gobject/WebKitDOMHTMLPrivate.cpp: * html/HTMLBaseFontElement.h: * html/HTMLBaseFontElement.idl: Tools: Add WebKitDOMHTMLBaseFontElement to the list of deleted classes. * gtk/webkitdom.py: (WebKitDOMDocGenerator): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformGTK.cmake trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols trunk/Source/WebCore/bindings/gobject/WebKitDOMHTMLPrivate.cpp trunk/Source/WebCore/html/HTMLBaseFontElement.h trunk/Source/WebCore/html/HTMLBaseFontElement.idl trunk/Tools/ChangeLog trunk/Tools/gtk/webkitdom.py Diff Modified: trunk/Source/WebCore/ChangeLog (191447 => 191448) --- trunk/Source/WebCore/ChangeLog 2015-10-22 08:08:23 UTC (rev 191447) +++ trunk/Source/WebCore/ChangeLog 2015-10-22 08:56:01 UTC (rev 191448) @@ -1,3 +1,25 @@ +2015-10-22 Carlos Garcia Campos+ +Unreviewed. Fix GTK+ build after r191423. + +Deprecate removed class WebKitDOMHTMLBaseFontElement. + +* PlatformGTK.cmake: +* bindings/gobject/WebKitDOMDeprecated.cpp: +(webkit_dom_html_base_font_element_init): +(webkit_dom_html_base_font_element_class_init): +(webkit_dom_html_base_font_element_get_color): +(webkit_dom_html_base_font_element_set_color): +(webkit_dom_html_base_font_element_get_face): +(webkit_dom_html_base_font_element_set_face): +(webkit_dom_html_base_font_element_get_size): +(webkit_dom_html_base_font_element_set_size): +* bindings/gobject/WebKitDOMDeprecated.h: +* bindings/gobject/WebKitDOMDeprecated.symbols: +* bindings/gobject/WebKitDOMHTMLPrivate.cpp: +* html/HTMLBaseFontElement.h: +* html/HTMLBaseFontElement.idl: + 2015-10-22 Xabier Rodriguez Calvar [Streams API] Add writable stream attributes Modified: trunk/Source/WebCore/PlatformGTK.cmake (191447 => 191448) --- trunk/Source/WebCore/PlatformGTK.cmake 2015-10-22 08:08:23 UTC (rev 191447) +++ trunk/Source/WebCore/PlatformGTK.cmake 2015-10-22 08:56:01 UTC (rev 191448) @@ -608,7 +608,6 @@ html/HTMLAreaElement.idl html/HTMLBRElement.idl html/HTMLBaseElement.idl -html/HTMLBaseFontElement.idl html/HTMLBodyElement.idl html/HTMLButtonElement.idl html/HTMLCanvasElement.idl Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (191447 => 191448) --- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2015-10-22 08:08:23 UTC (rev 191447) +++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2015-10-22 08:56:01 UTC (rev 191448) @@ -24,7 +24,6 @@ #include "JSMainThreadExecState.h" #include "WebKitDOMDocumentPrivate.h" #include "WebKitDOMElementPrivate.h" -#include "WebKitDOMHTMLElement.h" #include "WebKitDOMNodeListPrivate.h" #include #include @@ -155,3 +154,46 @@ g_warning("%s: EntityReference has been removed from DOM spec, this function does nothing.", __func__); return nullptr; } + +G_DEFINE_TYPE(WebKitDOMHTMLBaseFontElement, webkit_dom_html_base_font_element, WEBKIT_DOM_TYPE_HTML_ELEMENT) + +static void webkit_dom_html_base_font_element_init(WebKitDOMHTMLBaseFontElement*) +{ +} + +static void webkit_dom_html_base_font_element_class_init(WebKitDOMHTMLBaseFontElementClass*) +{ +} + +gchar* webkit_dom_html_base_font_element_get_color(WebKitDOMHTMLBaseFontElement*) +{ +g_warning("%s: HTMLBaseFont has been removed from DOM spec, this function does nothing.", __func__); +return nullptr; +} + +void webkit_dom_html_base_font_element_set_color(WebKitDOMHTMLBaseFontElement*, const gchar*) +{ +g_warning("%s: HTMLBaseFont has been removed from DOM spec, this function does nothing.", __func__); +} + +gchar* webkit_dom_html_base_font_element_get_face(WebKitDOMHTMLBaseFontElement*) +{ +g_warning("%s: HTMLBaseFont has been removed from DOM spec, this function does nothing.", __func__); +return nullptr; +} + +void webkit_dom_html_base_font_element_set_face(WebKitDOMHTMLBaseFontElement*, const gchar*) +{ +g_warning("%s:
[webkit-changes] [191442] trunk
Title: [191442] trunk Revision 191442 Author ph...@webkit.org Date 2015-10-22 00:07:41 -0700 (Thu, 22 Oct 2015) Log Message [GTK][Mac] ICU-related build fixes https://bugs.webkit.org/show_bug.cgi?id=150032 Rubber-stamped by Darin Adler. * Source/cmake/FindICU.cmake: Use pkg-config to hint at icu-i18n's library location. Modified Paths trunk/ChangeLog trunk/Source/cmake/FindICU.cmake Diff Modified: trunk/ChangeLog (191441 => 191442) --- trunk/ChangeLog 2015-10-22 06:59:04 UTC (rev 191441) +++ trunk/ChangeLog 2015-10-22 07:07:41 UTC (rev 191442) @@ -1,3 +1,12 @@ +2015-10-22 Philippe Normand+ +[GTK][Mac] ICU-related build fixes +https://bugs.webkit.org/show_bug.cgi?id=150032 + +Rubber-stamped by Darin Adler. + +* Source/cmake/FindICU.cmake: Use pkg-config to hint at icu-i18n's library location. + 2015-10-20 Yoav Weiss Rename the PICTURE_SIZES flag to CURRENTSRC Modified: trunk/Source/cmake/FindICU.cmake (191441 => 191442) --- trunk/Source/cmake/FindICU.cmake 2015-10-22 06:59:04 UTC (rev 191441) +++ trunk/Source/cmake/FindICU.cmake 2015-10-22 07:07:41 UTC (rev 191442) @@ -46,9 +46,12 @@ set(ICU_VERSION "${ICU_MAJOR_VERSION}.${ICU_MINOR_VERSION}") # Look for the ICU internationalization libraries +pkg_check_modules(PC_ICU_I18N icu-i18n) find_library( ICU_I18N_LIBRARY -NAMES icuin icui18n cygicuin cygicuin32 +NAMES icui18n icuin cygicuin cygicuin32 +HINTS ${PC_ICU_I18N_LIBRARY_DIRS} + ${PC_ICU_I18N_LIBDIR} DOC "Libraries to link against for ICU internationalization") mark_as_advanced(ICU_I18N_LIBRARY) if (ICU_I18N_LIBRARY) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191447] trunk/Source/WebKit2
Title: [191447] trunk/Source/WebKit2 Revision 191447 Author carlo...@webkit.org Date 2015-10-22 01:08:23 -0700 (Thu, 22 Oct 2015) Log Message [GTK] Try to fix the build after r191402. https://bugs.webkit.org/show_bug.cgi?id=150435 Patch by Hunseop Jeongon 2015-10-22 Reviewed by Carlos Garcia Campos. * UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createPopupMenuProxy): (WebKit::PageClientImpl::createContextMenuProxy): (WebKit::PageClientImpl::createColorPicker): * UIProcess/API/gtk/PageClientImpl.h: * UIProcess/gtk/WebContextMenuProxyGtk.cpp: (WebKit::WebContextMenuProxyGtk::populate): (WebKit::WebContextMenuProxyGtk::show): (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): (WebKit::WebContextMenuProxyGtk::menuPositionFunction): (WebKit::WebContextMenuProxyGtk::showContextMenu): Deleted. (WebKit::WebContextMenuProxyGtk::hideContextMenu): Deleted. (WebKit::WebContextMenuProxyGtk::cancelTracking): Deleted. * UIProcess/gtk/WebContextMenuProxyGtk.h: (WebKit::WebContextMenuProxyGtk::gtkMenu): (WebKit::WebContextMenuProxyGtk::create): Deleted. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h Diff Modified: trunk/Source/WebKit2/ChangeLog (191446 => 191447) --- trunk/Source/WebKit2/ChangeLog 2015-10-22 07:51:08 UTC (rev 191446) +++ trunk/Source/WebKit2/ChangeLog 2015-10-22 08:08:23 UTC (rev 191447) @@ -1,3 +1,28 @@ +2015-10-22 Hunseop Jeong + +[GTK] Try to fix the build after r191402. +https://bugs.webkit.org/show_bug.cgi?id=150435 + +Reviewed by Carlos Garcia Campos. + +* UIProcess/API/gtk/PageClientImpl.cpp: +(WebKit::PageClientImpl::createPopupMenuProxy): +(WebKit::PageClientImpl::createContextMenuProxy): +(WebKit::PageClientImpl::createColorPicker): +* UIProcess/API/gtk/PageClientImpl.h: +* UIProcess/gtk/WebContextMenuProxyGtk.cpp: +(WebKit::WebContextMenuProxyGtk::populate): +(WebKit::WebContextMenuProxyGtk::show): +(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): +(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): +(WebKit::WebContextMenuProxyGtk::menuPositionFunction): +(WebKit::WebContextMenuProxyGtk::showContextMenu): Deleted. +(WebKit::WebContextMenuProxyGtk::hideContextMenu): Deleted. +(WebKit::WebContextMenuProxyGtk::cancelTracking): Deleted. +* UIProcess/gtk/WebContextMenuProxyGtk.h: +(WebKit::WebContextMenuProxyGtk::gtkMenu): +(WebKit::WebContextMenuProxyGtk::create): Deleted. + 2015-10-21 Gyuyoung Kim Unreviewed EFL build fix. Remove customizeMenu implementation. Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp (191446 => 191447) --- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2015-10-22 07:51:08 UTC (rev 191446) +++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2015-10-22 08:08:23 UTC (rev 191447) @@ -211,9 +211,9 @@ return WebPopupMenuProxyGtk::create(m_viewWidget, page); } -RefPtr PageClientImpl::createContextMenuProxy(WebPageProxy& page, const ContextMenuContextData& context, const UserData& userData) +std::unique_ptr PageClientImpl::createContextMenuProxy(WebPageProxy& page, const ContextMenuContextData& context, const UserData& userData) { -return WebContextMenuProxyGtk::create(m_viewWidget, page, context, userData); +return std::make_unique(m_viewWidget, page, context, userData); } RefPtr PageClientImpl::createColorPicker(WebPageProxy* page, const WebCore::Color& color, const WebCore::IntRect& rect) Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (191446 => 191447) --- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2015-10-22 07:51:08 UTC (rev 191446) +++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2015-10-22 08:08:23 UTC (rev 191447) @@ -83,7 +83,7 @@ virtual WebCore::IntRect rootViewToScreen(const WebCore::IntRect&) override; virtual void doneWithKeyEvent(const NativeWebKeyboardEvent&, bool wasEventHandled) override; virtual RefPtr createPopupMenuProxy(WebPageProxy&) override; -virtual RefPtr createContextMenuProxy(WebPageProxy&, const ContextMenuContextData&, const UserData&) override; +virtual std::unique_ptr createContextMenuProxy(WebPageProxy&, const ContextMenuContextData&, const UserData&) override; #if ENABLE(INPUT_TYPE_COLOR) virtual RefPtr createColorPicker(WebPageProxy*, const WebCore::Color& intialColor, const WebCore::IntRect&) override; #endif Modified: trunk/Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp (191446 => 191447) ---
[webkit-changes] [191441] trunk/Source/WebCore
Title: [191441] trunk/Source/WebCore Revision 191441 Author fred.w...@free.fr Date 2015-10-21 23:59:04 -0700 (Wed, 21 Oct 2015) Log Message Unreviewed compilation fix on Mac. * platform/graphics/cocoa/FontCocoa.mm: (WebCore::Font::platformInit): Add missing font argument. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm Diff Modified: trunk/Source/WebCore/ChangeLog (191440 => 191441) --- trunk/Source/WebCore/ChangeLog 2015-10-22 06:45:21 UTC (rev 191440) +++ trunk/Source/WebCore/ChangeLog 2015-10-22 06:59:04 UTC (rev 191441) @@ -1,5 +1,12 @@ 2015-10-21 Frederic Wang+Unreviewed compilation fix on Mac. + +* platform/graphics/cocoa/FontCocoa.mm: +(WebCore::Font::platformInit): Add missing font argument. + +2015-10-21 Frederic Wang + [Mac] Add support for the USE_TYPO_METRICS flag https://bugs.webkit.org/show_bug.cgi?id=150394 Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm (191440 => 191441) --- trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm 2015-10-22 06:45:21 UTC (rev 191440) +++ trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm 2015-10-22 06:59:04 UTC (rev 191441) @@ -179,7 +179,7 @@ // We only apply this rule in the important case of fonts with a MATH table. CFArrayRef availableTables = CTFontCopyAvailableTables(m_platformData.cgFont(), kCTFontTableOptionNoOptions); if (CFArrayContainsValue(availableTables, CFRangeMake(0, CFArrayGetCount(availableTables)), kCTFontTableMATH)) { -if (CFDataRef os2Table = CGFontCopyTableForTag(kCTFontTableOS2)) { +if (CFDataRef os2Table = CGFontCopyTableForTag(m_platformData.cgFont(), kCTFontTableOS2)) { // For the structure of the OS/2 table, see // https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6OS2.html const CFIndex fsSelectionOffset = 16 * 2 + 10 + 4 * 4 + 4 * 1; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191446] trunk
Title: [191446] trunk Revision 191446 Author calva...@igalia.com Date 2015-10-22 00:51:08 -0700 (Thu, 22 Oct 2015) Log Message [Streams API] Add writable stream attributes https://bugs.webkit.org/show_bug.cgi?id=150389 Reviewed by Darin Adler. Source/WebCore: This patch adds the three writable stream attributes, which are closed, ready and state. They are implemented according to the spec. Current test set suffices, expectations were adjusted accordingly. * Modules/streams/WritableStream.js: (initializeWritableStream): Style fix. (closed): (ready): (state): Implemented according to the spec. * Modules/streams/WritableStreamInternals.js: (isWritableStream): Implemented according to the spec. LayoutTests: Expectations for the implementation of writable stream attributes. * streams/reference-implementation/brand-checks-expected.txt: * streams/reference-implementation/count-queuing-strategy-expected.txt: * streams/reference-implementation/pipe-to-expected.txt: * streams/reference-implementation/readable-stream-templated-expected.txt: * streams/reference-implementation/writable-stream-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt trunk/LayoutTests/streams/reference-implementation/pipe-to-expected.txt trunk/LayoutTests/streams/reference-implementation/readable-stream-templated-expected.txt trunk/LayoutTests/streams/reference-implementation/writable-stream-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/streams/WritableStream.js trunk/Source/WebCore/Modules/streams/WritableStreamInternals.js Diff Modified: trunk/LayoutTests/ChangeLog (191445 => 191446) --- trunk/LayoutTests/ChangeLog 2015-10-22 07:17:20 UTC (rev 191445) +++ trunk/LayoutTests/ChangeLog 2015-10-22 07:51:08 UTC (rev 191446) @@ -1,3 +1,18 @@ +2015-10-22 Xabier Rodriguez Calvar+ +[Streams API] Add writable stream attributes +https://bugs.webkit.org/show_bug.cgi?id=150389 + +Reviewed by Darin Adler. + +Expectations for the implementation of writable stream attributes. + +* streams/reference-implementation/brand-checks-expected.txt: +* streams/reference-implementation/count-queuing-strategy-expected.txt: +* streams/reference-implementation/pipe-to-expected.txt: +* streams/reference-implementation/readable-stream-templated-expected.txt: +* streams/reference-implementation/writable-stream-expected.txt: + 2015-10-22 Frederic Wang Rollout r190440 for the moment. It broke the build. Modified: trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt (191445 => 191446) --- trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt 2015-10-22 07:17:20 UTC (rev 191445) +++ trunk/LayoutTests/streams/reference-implementation/brand-checks-expected.txt 2015-10-22 07:51:08 UTC (rev 191446) @@ -17,9 +17,9 @@ PASS ReadableStreamController.prototype.close enforces a brand check PASS ReadableStreamController.prototype.enqueue enforces a brand check PASS ReadableStreamController.prototype.error enforces a brand check -FAIL WritableStream.prototype.closed enforces a brand check closed not implemented -FAIL WritableStream.prototype.ready enforces a brand check ready not implemented -FAIL WritableStream.prototype.state enforces a brand check assert_throws: state should throw a TypeError function "function () { getter.call(target); }" threw object "EvalError: state not implemented" ("EvalError") expected object "TypeError" ("TypeError") +PASS WritableStream.prototype.closed enforces a brand check +PASS WritableStream.prototype.ready enforces a brand check +PASS WritableStream.prototype.state enforces a brand check FAIL WritableStream.prototype.abort enforces a brand check abort not implemented FAIL WritableStream.prototype.write enforces a brand check write not implemented FAIL WritableStream.prototype.close enforces a brand check close not implemented Modified: trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt (191445 => 191446) --- trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt 2015-10-22 07:17:20 UTC (rev 191445) +++ trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy-expected.txt 2015-10-22 07:51:08 UTC (rev 191446) @@ -9,6 +9,6 @@ PASS Correctly governs a ReadableStreamController's desiredSize property (HWM = 1) PASS Correctly governs a ReadableStreamController's desiredSize property (HWM = 4) PASS Can construct a writable stream with a valid CountQueuingStrategy -FAIL Correctly governs the value of a WritableStream's state property (HWM = 0) state not implemented -FAIL Correctly governs the value of a WritableStream's state property (HWM = 4) state not
[webkit-changes] [191443] trunk/Source/WebCore
Title: [191443] trunk/Source/WebCore Revision 191443 Author fred.w...@free.fr Date 2015-10-22 00:09:43 -0700 (Thu, 22 Oct 2015) Log Message Unreviewed compilation fix on Mac. * platform/graphics/cocoa/FontCocoa.mm: (WebCore::Font::platformInit): Use a pointer for the third argument of CFArrayContainsValue. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm Diff Modified: trunk/Source/WebCore/ChangeLog (191442 => 191443) --- trunk/Source/WebCore/ChangeLog 2015-10-22 07:07:41 UTC (rev 191442) +++ trunk/Source/WebCore/ChangeLog 2015-10-22 07:09:43 UTC (rev 191443) @@ -1,3 +1,10 @@ +2015-10-22 Frederic Wang+ +Unreviewed compilation fix on Mac. + +* platform/graphics/cocoa/FontCocoa.mm: +(WebCore::Font::platformInit): Use a pointer for the third argument of CFArrayContainsValue. + 2015-10-21 Frederic Wang Unreviewed compilation fix on Mac. Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm (191442 => 191443) --- trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm 2015-10-22 07:07:41 UTC (rev 191442) +++ trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm 2015-10-22 07:09:43 UTC (rev 191443) @@ -178,7 +178,7 @@ // "If set, it is strongly recommended to use OS/2.sTypoAscender - OS/2.sTypoDescender+ OS/2.sTypoLineGap as a value for default line spacing for this font." // We only apply this rule in the important case of fonts with a MATH table. CFArrayRef availableTables = CTFontCopyAvailableTables(m_platformData.cgFont(), kCTFontTableOptionNoOptions); -if (CFArrayContainsValue(availableTables, CFRangeMake(0, CFArrayGetCount(availableTables)), kCTFontTableMATH)) { +if (CFArrayContainsValue(availableTables, CFRangeMake(0, CFArrayGetCount(availableTables)), )) { if (CFDataRef os2Table = CGFontCopyTableForTag(m_platformData.cgFont(), kCTFontTableOS2)) { // For the structure of the OS/2 table, see // https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6OS2.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191440] trunk
Title: [191440] trunk Revision 191440 Author fred.w...@free.fr Date 2015-10-21 23:45:21 -0700 (Wed, 21 Oct 2015) Log Message [Mac] Add support for the USE_TYPO_METRICS flag https://bugs.webkit.org/show_bug.cgi?id=150394 Reviewed by Myles C. Maxfield. Source/WebCore: Make the Cocoa backend use the typo metrics for fonts with a MATH table when the OS/2 USE_TYPO_METRICS flag is set. No new tests because this is already tested by fonts/use-typo-metrics-1.html * platform/graphics/cocoa/FontCocoa.mm: (WebCore::Font::platformInit): Verify whether the OS/2 USE_TYPO_METRICS flag is set and use the typo metrics if that is the case. LayoutTests: Update font, reference and Mac expectation for fonts/use-typo-metrics-1.html * fonts/lineheight5000-typolineheight2300.woff: Add a MATH table. * platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated. * platform/mac/TestExpectations: Remove Mac failure expectation. * platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Updated. * platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-expected.txt trunk/LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt trunk/LayoutTests/platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm Diff Modified: trunk/LayoutTests/ChangeLog (191439 => 191440) --- trunk/LayoutTests/ChangeLog 2015-10-22 06:10:53 UTC (rev 191439) +++ trunk/LayoutTests/ChangeLog 2015-10-22 06:45:21 UTC (rev 191440) @@ -1,3 +1,18 @@ +2015-10-21 Frederic Wang+ +[Mac] Add support for the USE_TYPO_METRICS flag +https://bugs.webkit.org/show_bug.cgi?id=150394 + +Reviewed by Myles C. Maxfield. + +Update font, reference and Mac expectation for fonts/use-typo-metrics-1.html + +* fonts/lineheight5000-typolineheight2300.woff: Add a MATH table. +* platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated. +* platform/mac/TestExpectations: Remove Mac failure expectation. +* platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Updated. +* platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated. + 2015-10-21 Ryan Haddad Adding http/tests/media/video-load-suspend.html to the list of flaky media tests Modified: trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff (191439 => 191440) --- trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff 2015-10-22 06:10:53 UTC (rev 191439) +++ trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff 2015-10-22 06:45:21 UTC (rev 191440) @@ -1,17 +1,16 @@ -wOFFOTTOT -CFF \xF4\xDF(\x89\xC9 6FFTM\xD4v\xC5\x86OS/2\xF0D`!\xD5'cmap4EJ\x93\xA9head|06\x8Dh\xB7hhea\xAC$+wOFFOTTO\xB4 CFF `\xDF(\x89\xC9 6FFTM@v\xDANpMATH\K\xF2DOS/2\D`!\xD5'cmapEJ\x93\xA9head06\xA2\xA5\xA1hhea8$ \xAD-\xAFhmtx\xC8 +\xAFhmtx\xA8 -\xD0maxp\xD4Pname\xDC]\xE4\xE7}\xAB\xE0post< \xFF\x863x\x9Ccd`aa`ddTO\xCB\xCF+\xD1\xCD\xC9\xCCK\xCDH\xCDL\xCF(1500\xD0-\xA9,\xC8G002102\xE8\xFD\xE0g\xF8!\xCD\xF8C\x86\xE9\x87,\xF3 \x96\xC6\xEE\xDF1\xBFj~na\x95ax\xC8/\xC3\xC0 \xC3\xF0LP\x86\x81O\x86QJ\x88\x81\xA4G\x8D\xC1\x87\xA1\xC89\xBF\xA0\xB2d\x96\x82F\xB2\xA6\x82\x91\x81\xA1\xA9\x82obI\x86\xAF\x8F\x82cqq~rfbIf~q.!ҽ@\xC0\xC8`\xC0\xC0\xCCȨ\xA4\xAC\xF7\x87\xEB^ƽ{n\xD9˼W\xEC\x97ď\x95\xFF$\xD8\xF6\xFE)\xFD\xE1\xFAs\xCBWv>\xBE\xDF1,\xBFj~\xD5\xFC\xABa\xE7\xFBU#\xD2-Z>\xFF\xE7\x96n\xB6n.\x8Elc[x\x9Cc```d\x82Kvo\xB8\xC1\xB4\xB3\xD0^-?\x8E\xD1x\x9Cc`a~\xC18\x81\x81\x95\x81\x81\xA9\x8BiC\x84f|\xC0`\xC8\xC8e`\xE5d\x80Ft\xD0\xC0\xA0\xC0\xE0Ϭ\xF0߂U\x84\xF3\xE7\x84fd:\xFD --x\x9Cc```f\x80`Fp\xF2\xC1|- \xCD\xA4\x98\xFC\xFF\xFF\xF2\xC1\xF4\xFF\x87\xFF7C\xD5#\x82\x83\x92GL\xA4)x 9x\x9Cc`d``⠖7\xF1\xFC6_\xB8\x99_E.9\xEDE\xD0\xFF-\x98_0+\xB9L Q3\xA2 -\x89x\x9Cc`d`\xE0<\xC2y\x84\x81\x81\xF9\x98dd@LX\xE2u\xE8\xE8Px\x9CŒ?N\xC30ş\xD3?\xB0\xB2\x99\x81\xAAJ\xE5\xA4\xCAҭT\xEAP%k\xF7\xAAJ\x93HU\%^rF\x8E\x828\x823p-^C\x87J\x8D\x95\xF8g\xE7\xBD\xEF\xB3?\xC05^!\xD0=\x88\x8C\xF0\xEE\xD8ýxt\xDC\xC3R|:\xEEc\xE4e\x8E\xB8\xF5\xDE1\xEA\xDDP)\xFAW\xAD\xAD\xABe\xC1\xE8\x95cO\xF8r\xDCóH\xF7{w\x8E\x90ދ\xE3!\xE7?\xB0\x84\xC6-\xA3Ȑ\xC3@b\x8C&\xECC(\x88H \xB6\xFC\x93\xB3\x8F9Z\xA0f\xD3Tv\xBE \x97\xC0R\x9B\xAA\xC8r#ǻ\x89U\xC9dk\xF2$\x96\x8B\xBAֻbk -M\xD9ު-|\xE8,\x912n\xFA\x9B=bζ\xF9\xE4\x86+\xD3\xFF\xAAB̬ -{]\xFFP\x94i\x9E\xB6\x99#\xA5\x94o\x9A\xA3\xFE\x9B
[webkit-changes] [191439] trunk/Source/WebCore
Title: [191439] trunk/Source/WebCore Revision 191439 Author za...@apple.com Date 2015-10-21 23:10:53 -0700 (Wed, 21 Oct 2015) Log Message Print out the render tree from command line. https://bugs.webkit.org/show_bug.cgi?id=150416 Use system-wide notification server (https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man3/notify_register_dispatch.3.html) to print out the render tree for the live documents. Usage: notifyutil -p com.apple.WebKit.showRenderTree Reviewed by Simon Fraser. No change in functionality. * platform/Logging.cpp: (WebCore::registerNotifyCallback): * platform/Logging.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::printRenderTreeForLiveDocuments): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/Logging.cpp trunk/Source/WebCore/platform/Logging.h trunk/Source/WebCore/rendering/RenderObject.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (191438 => 191439) --- trunk/Source/WebCore/ChangeLog 2015-10-22 05:50:24 UTC (rev 191438) +++ trunk/Source/WebCore/ChangeLog 2015-10-22 06:10:53 UTC (rev 191439) @@ -1,3 +1,24 @@ +2015-10-21 Zalan Bujtas+ +Print out the render tree from command line. +https://bugs.webkit.org/show_bug.cgi?id=150416 + +Use system-wide notification server (https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man3/notify_register_dispatch.3.html) +to print out the render tree for the live documents. + +Usage: notifyutil -p com.apple.WebKit.showRenderTree + +Reviewed by Simon Fraser. + +No change in functionality. + +* platform/Logging.cpp: +(WebCore::registerNotifyCallback): +* platform/Logging.h: +* rendering/RenderObject.cpp: +(WebCore::RenderObject::RenderObject): +(WebCore::printRenderTreeForLiveDocuments): + 2015-10-21 Alex Christensen Fix CMake clean build after r191423. Modified: trunk/Source/WebCore/platform/Logging.cpp (191438 => 191439) --- trunk/Source/WebCore/platform/Logging.cpp 2015-10-22 05:50:24 UTC (rev 191438) +++ trunk/Source/WebCore/platform/Logging.cpp 2015-10-22 06:10:53 UTC (rev 191439) @@ -30,6 +30,10 @@ #include #include +#if PLATFORM(COCOA) +#include +#endif + #if !LOG_DISABLED namespace WebCore { @@ -63,6 +67,18 @@ WTFInitializeLogChannelStatesFromString(logChannels, logChannelCount, logLevelString().utf8().data()); } +#ifndef NDEBUG +void registerNotifyCallback(const String& notifyID, std::function callback) +{ +#if PLATFORM(COCOA) +int token; +notify_register_dispatch(notifyID.utf8().data(), , dispatch_get_main_queue(), ^(int) { +callback(); +}); +#endif } +#endif +} + #endif // !LOG_DISABLED Modified: trunk/Source/WebCore/platform/Logging.h (191438 => 191439) --- trunk/Source/WebCore/platform/Logging.h 2015-10-22 05:50:24 UTC (rev 191438) +++ trunk/Source/WebCore/platform/Logging.h 2015-10-22 06:10:53 UTC (rev 191439) @@ -26,6 +26,7 @@ #ifndef Logging_h #define Logging_h +#include #include #include @@ -89,6 +90,9 @@ String logLevelString(); bool isLogChannelEnabled(const String& name); WEBCORE_EXPORT void initializeLoggingChannelsIfNecessary(); +#ifndef NDEBUG +void registerNotifyCallback(const String& notifyID, std::function callback); +#endif } #endif // !LOG_DISABLED Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (191438 => 191439) --- trunk/Source/WebCore/rendering/RenderObject.cpp 2015-10-22 05:50:24 UTC (rev 191438) +++ trunk/Source/WebCore/rendering/RenderObject.cpp 2015-10-22 06:10:53 UTC (rev 191439) @@ -43,6 +43,7 @@ #include "HTMLTableCellElement.h" #include "HTMLTableElement.h" #include "HitTestResult.h" +#include "Logging.h" #include "LogicalSelectionOffsetCaches.h" #include "Page.h" #include "PseudoElement.h" @@ -81,6 +82,8 @@ using namespace HTMLNames; #ifndef NDEBUG +void printRenderTreeForLiveDocuments(); + RenderObject::SetLayoutNeededForbiddenScope::SetLayoutNeededForbiddenScope(RenderObject* renderObject, bool isForbidden) : m_renderObject(renderObject) , m_preexistingForbidden(m_renderObject->isSetNeedsLayoutForbidden()) @@ -123,6 +126,10 @@ renderView->didCreateRenderer(); #ifndef NDEBUG renderObjectCounter.increment(); +static std::once_flag onceFlag; +std::call_once(onceFlag, [] { +registerNotifyCallback("com.apple.WebKit.showRenderTree", printRenderTreeForLiveDocuments); +}); #endif } @@ -2215,6 +,19 @@ setHasRareData(false); } +#ifndef NDEBUG +void printRenderTreeForLiveDocuments() +{ +for (const auto* document : Document::allDocuments()) { +if (!document->renderView() || document->inPageCache()) +continue; +if (document->frame() && document->frame()->isMainFrame()) +fprintf(stderr,
[webkit-changes] [191444] trunk
Title: [191444] trunk Revision 191444 Author fred.w...@free.fr Date 2015-10-22 00:16:38 -0700 (Thu, 22 Oct 2015) Log Message Rollout r190440 for the moment. It broke the build. Source/WebCore: * platform/graphics/cocoa/FontCocoa.mm: (WebCore::Font::platformInit): Deleted. LayoutTests: * fonts/lineheight5000-typolineheight2300.woff: * platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: * platform/mac/TestExpectations: * platform/mac/mathml/opentype/opentype-stretchy-expected.txt: * platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-expected.txt trunk/LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt trunk/LayoutTests/platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm Diff Modified: trunk/LayoutTests/ChangeLog (191443 => 191444) --- trunk/LayoutTests/ChangeLog 2015-10-22 07:09:43 UTC (rev 191443) +++ trunk/LayoutTests/ChangeLog 2015-10-22 07:16:38 UTC (rev 191444) @@ -1,3 +1,13 @@ +2015-10-22 Frederic Wang+ +Rollout r190440 for the moment. It broke the build. + +* fonts/lineheight5000-typolineheight2300.woff: +* platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: +* platform/mac/TestExpectations: +* platform/mac/mathml/opentype/opentype-stretchy-expected.txt: +* platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: + 2015-10-21 Frederic Wang [Mac] Add support for the USE_TYPO_METRICS flag Modified: trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff (191443 => 191444) --- trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff 2015-10-22 07:09:43 UTC (rev 191443) +++ trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff 2015-10-22 07:16:38 UTC (rev 191444) @@ -1,16 +1,17 @@ -wOFFOTTO\xB4 CFF `\xDF(\x89\xC9 6FFTM@v\xDANpMATH\K\xF2DOS/2\D`!\xD5'cmapEJ\x93\xA9head06\xA2\xA5\xA1hhea8$+wOFFOTTOT +CFF \xF4\xDF(\x89\xC9 6FFTM\xD4v\xC5\x86OS/2\xF0D`!\xD5'cmap4EJ\x93\xA9head|06\x8Dh\xB7hhea\xAC$ \xAD-\xAFhmtx\xA8 +\xAFhmtx\xC8 -\xD0maxpTPname\xA0]\xE4\xE6{\xAC\xE0postH \xFF\x863x\x9Cc`d``b\x96\xCC\xF2\x9Ax~\x9B\xAF\xDC\xCC/\x80"\x97|7!\xE8\xFF\xCC/\x98\x80\&\x90($Y -Kx\x9Cc`d`\xE0<\xC2y\x84\x81\x81\xF9\x98dd@LX\xE2uPx\x9Cc`a~\xC18\x81\x81\x95\x81\x81\xA9\x8BiC\x84f|\xC0`\xC8\xC8e`\xE5d\x80Ft\xD0\xC0\xA0\xC0\xE0Ϭ\xF0߂U\x84\xF3\xE7\x84fd:\xFD --x\x9CŒ\xBFN\xC30ƿ\xA4$`e3U+\xE4\xCAI\x95\xA5[\xA9ԡJ\xD6\xEEU\x95&\x96\xAA\xB8J\xBC\xE4y\xC4#\xC0C\xF0\xBC_C\x87J\x8De\xDD\xCF\xCEww\xF6\x9D\\xE3\xBA\xEF\xB1c#\xBC;\xF6q\xEF=:\xEEa\xE9}:\xEEc\xE4g\x8E\xB8\xF5\xDF1\xEA\xDDP\xE9\xF5\xAF\xB8Z\xB7^-{\x8C^:\xF6\xF1\x84/\xC7=<{\x89\xE3>b\xFF\xCE\xF1\xC2q<\xE4\xFE\x9608\xA2f\x8D9,\xC6\xD8aBB!@DJ\xB0埜6\xE6j\x81\x8A\xC3P\xA5\xDB}M.\x80\xA59֥\xCEr+ƻ\x89U\x89dk\xF3$\x8B\xAA2;\xBD\xB5\xDAP\xB6o\xD5zH7\xFD\xCD1g3$\xB9\xE6\xC9̿\xAA\xB3V\x85\xBD)\xAC<\xE8"\xCD\xD3\xA4\x94\x92\xB6>\x9A\xBF\xADp\xA6\xA8;C\xAA\xB2\xAC\xDC\xD5[\xD2?m\x8B8\xA5\xB7\xC0\x9C\xF3\x9CW\xEF"\x86l\x90\xE4l\xBC~څ\x8B\xB22e\x96\x8Ap\xAA\xC4\\x9CV$ -\xC3@J6\x9D\xBBP\x9B6t.\xF9\xB6\xBA%Z\xE7\xA0-`welҲ\xE2+JS\x979\xE77-\xE3\xBFdx\x9Cc```f\x80`Fp\xF2\xC1|- \xCD\xA4\x98\xFC\xFF\xFF\xF2\xC1\xF4\xFF\x87\xFF7C\xD5#\x82\x83\x92GL\xA4)x 9x\x9Cc`f\x83\xFF\xCDF@\x8A\x91-(U\xB9x\x9Ccd`aa`ddTO\xCB\xCF+\xD1\xCD\xC9\xCCK\xCDH\xCDL\xCF(1500\xD0-\xA9,\xC8G002102\xE8\xFD\xE0g\xF8!\xCD\xF8C\x86\xE9\x87,\xF3 \x96\xC6\xEE\xDF1\xBFj~na\x95ax\xC8/\xC3\xC0 \xC3\xF0LP\x86\x81O\x86QJ\x88\x81\xA4G\x8D\xC1\x87\xA1\xC89\xBF\xA0\xB2d\x96\x82F\xB2\xA6\x82\x91\x81\xA1\xA9\x82obI\x86\xAF\x8F\x82cqq~rfbIf~q.!ҽ@\xC0\xC8`\xC0\xC0\xCCȨ\xA4\xAC\xF7\x87\xEB^ƽ{n\xD9˼W\xEC\x97ď\x95\xFF$\xD8\xF6\xFE)\xFD\xE1\xFAs\xCBWv>\xBE\xDF1,\xBFj~\xD5\xFC\xABa\xE7\xFBU#\xD2-Z>\xFF\xE7\x96n\xB6n.\x8Elc[x\x9Cc```d\x82Kvo\xB8\xC1\xB4\xEFF#-B -x\x9Cc`d``\xE0bx\xC0\xF0\x82!\x80\xC1\x86\xF5&\xE8A0\xA0ɝ\x80ҚX\xF4\xA1\x83i@\xFDqD\xA83\x82\xA8\xD306\x92(\xE2F\xD81\xA3(\xC3߫@\xB6 -\\xA7\x8C\x8EF-J\xE8\xE8 \ No newline at end of file +\xD0maxp\xD4Pname\xDC]\xE4\xE7}\xAB\xE0post< \xFF\x863x\x9Ccd`aa`ddTO\xCB\xCF+\xD1\xCD\xC9\xCCK\xCDH\xCDL\xCF(1500\xD0-\xA9,\xC8G002102\xE8\xFD\xE0g\xF8!\xCD\xF8C\x86\xE9\x87,\xF3 \x96\xC6\xEE\xDF1\xBFj~na\x95ax\xC8/\xC3\xC0 \xC3\xF0LP\x86\x81O\x86QJ\x88\x81\xA4G\x8D\xC1\x87\xA1\xC89\xBF\xA0\xB2d\x96\x82F\xB2\xA6\x82\x91\x81\xA1\xA9\x82obI\x86\xAF\x8F\x82cqq~rfbIf~
[webkit-changes] [191445] trunk/Tools
Title: [191445] trunk/Tools Revision 191445 Author commit-qu...@webkit.org Date 2015-10-22 00:17:20 -0700 (Thu, 22 Oct 2015) Log Message [Win][EFL][GTK] webkitpy test failed after r191374. https://bugs.webkit.org/show_bug.cgi?id=150433 Patch by Aakash Jainon 2015-10-22 Reviewed by Alexey Proskuryakov. * Scripts/webkitpy/common/system/crashlogs_unittest.py: (CrashLogsTest.test_find_all_log_darwin): Check platform before running test. (CrashLogsTest.test_find_log_darwin): Same. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py Diff Modified: trunk/Tools/ChangeLog (191444 => 191445) --- trunk/Tools/ChangeLog 2015-10-22 07:16:38 UTC (rev 191444) +++ trunk/Tools/ChangeLog 2015-10-22 07:17:20 UTC (rev 191445) @@ -1,3 +1,14 @@ +2015-10-22 Aakash Jain + +[Win][EFL][GTK] webkitpy test failed after r191374. +https://bugs.webkit.org/show_bug.cgi?id=150433 + +Reviewed by Alexey Proskuryakov. + +* Scripts/webkitpy/common/system/crashlogs_unittest.py: +(CrashLogsTest.test_find_all_log_darwin): Check platform before running test. +(CrashLogsTest.test_find_log_darwin): Same. + 2015-10-21 Brian Burg Unreviewed, update watchlist for JS builtins. Modified: trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py (191444 => 191445) --- trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py 2015-10-22 07:16:38 UTC (rev 191444) +++ trunk/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py 2015-10-22 07:17:20 UTC (rev 191445) @@ -257,6 +257,9 @@ return crash_logs def test_find_all_log_darwin(self): +if not SystemHost().platform.is_mac(): +return + crash_logs = self.create_crash_logs_darwin() all_logs = crash_logs.find_all_logs() self.assertEqual(len(all_logs), 5) @@ -266,6 +269,9 @@ self.assertTrue(test == "Unknown" or int(test.split("-")[1]) in range(28527, 28531)) def test_find_log_darwin(self): +if not SystemHost().platform.is_mac(): +return + crash_logs = self.create_crash_logs_darwin() log = crash_logs.find_newest_log("DumpRenderTree") self.assertMultiLineEqual(log, self.newer_mock_crash_report) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191456] trunk
Title: [191456] trunk Revision 191456 Author fred.w...@free.fr Date 2015-10-22 10:17:56 -0700 (Thu, 22 Oct 2015) Log Message [Mac] Add support for the USE_TYPO_METRICS flag https://bugs.webkit.org/show_bug.cgi?id=150394 Reviewed by Myles C. Maxfield. Source/WebCore: Make the Cocoa backend use the typo metrics for fonts with a MATH table when the OS/2 USE_TYPO_METRICS flag is set. No new tests because this is already tested by fonts/use-typo-metrics-1.html * platform/graphics/cocoa/FontCocoa.mm: (WebCore::fontHasMathTable): Add a function to verify whether a font has a MATH table. (WebCore::Font::platformInit): Verify whether the OS/2 USE_TYPO_METRICS flag is set and use the typo metrics if that is the case. LayoutTests: Update font, reference and Mac expectation for fonts/use-typo-metrics-1.html * fonts/lineheight5000-typolineheight2300.woff: Add a MATH table. * platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated. * platform/mac/TestExpectations: Remove Mac failure expectation. * platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Updated. * platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-expected.txt trunk/LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt trunk/LayoutTests/platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm Diff Modified: trunk/LayoutTests/ChangeLog (191455 => 191456) --- trunk/LayoutTests/ChangeLog 2015-10-22 16:12:42 UTC (rev 191455) +++ trunk/LayoutTests/ChangeLog 2015-10-22 17:17:56 UTC (rev 191456) @@ -1,3 +1,18 @@ +2015-10-22 Frederic Wang+ +[Mac] Add support for the USE_TYPO_METRICS flag +https://bugs.webkit.org/show_bug.cgi?id=150394 + +Reviewed by Myles C. Maxfield. + +Update font, reference and Mac expectation for fonts/use-typo-metrics-1.html + +* fonts/lineheight5000-typolineheight2300.woff: Add a MATH table. +* platform/mac-mavericks/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated. +* platform/mac/TestExpectations: Remove Mac failure expectation. +* platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Updated. +* platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Updated. + 2015-10-22 Michael Saboff REGRESSION(r191360): Repro Crash: com.apple.WebKit.WebContent at _javascript_Core:JSC::ExecState::bytecodeOffset + 174 Modified: trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff (191455 => 191456) --- trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff 2015-10-22 16:12:42 UTC (rev 191455) +++ trunk/LayoutTests/fonts/lineheight5000-typolineheight2300.woff 2015-10-22 17:17:56 UTC (rev 191456) @@ -1,17 +1,16 @@ -wOFFOTTOT -CFF \xF4\xDF(\x89\xC9 6FFTM\xD4v\xC5\x86OS/2\xF0D`!\xD5'cmap4EJ\x93\xA9head|06\x8Dh\xB7hhea\xAC$+wOFFOTTO\xB4 CFF `\xDF(\x89\xC9 6FFTM@v\xDANpMATH\K\xF2DOS/2\D`!\xD5'cmapEJ\x93\xA9head06\xA2\xA5\xA1hhea8$ \xAD-\xAFhmtx\xC8 +\xAFhmtx\xA8 -\xD0maxp\xD4Pname\xDC]\xE4\xE7}\xAB\xE0post< \xFF\x863x\x9Ccd`aa`ddTO\xCB\xCF+\xD1\xCD\xC9\xCCK\xCDH\xCDL\xCF(1500\xD0-\xA9,\xC8G002102\xE8\xFD\xE0g\xF8!\xCD\xF8C\x86\xE9\x87,\xF3 \x96\xC6\xEE\xDF1\xBFj~na\x95ax\xC8/\xC3\xC0 \xC3\xF0LP\x86\x81O\x86QJ\x88\x81\xA4G\x8D\xC1\x87\xA1\xC89\xBF\xA0\xB2d\x96\x82F\xB2\xA6\x82\x91\x81\xA1\xA9\x82obI\x86\xAF\x8F\x82cqq~rfbIf~q.!ҽ@\xC0\xC8`\xC0\xC0\xCCȨ\xA4\xAC\xF7\x87\xEB^ƽ{n\xD9˼W\xEC\x97ď\x95\xFF$\xD8\xF6\xFE)\xFD\xE1\xFAs\xCBWv>\xBE\xDF1,\xBFj~\xD5\xFC\xABa\xE7\xFBU#\xD2-Z>\xFF\xE7\x96n\xB6n.\x8Elc[x\x9Cc```d\x82Kvo\xB8\xC1\xB4\xB3\xD0^-?\x8E\xD1x\x9Cc`a~\xC18\x81\x81\x95\x81\x81\xA9\x8BiC\x84f|\xC0`\xC8\xC8e`\xE5d\x80Ft\xD0\xC0\xA0\xC0\xE0Ϭ\xF0߂U\x84\xF3\xE7\x84fd:\xFD --x\x9Cc```f\x80`Fp\xF2\xC1|- \xCD\xA4\x98\xFC\xFF\xFF\xF2\xC1\xF4\xFF\x87\xFF7C\xD5#\x82\x83\x92GL\xA4)x 9x\x9Cc`d``⠖7\xF1\xFC6_\xB8\x99_E.9\xEDE\xD0\xFF-\x98_0+\xB9L Q3\xA2 -\x89x\x9Cc`d`\xE0<\xC2y\x84\x81\x81\xF9\x98dd@LX\xE2u\xE8\xE8Px\x9CŒ?N\xC30ş\xD3?\xB0\xB2\x99\x81\xAAJ\xE5\xA4\xCAҭT\xEAP%k\xF7\xAAJ\x93HU\%^rF\x8E\x828\x823p-^C\x87J\x8D\x95\xF8g\xE7\xBD\xEF\xB3?\xC05^!\xD0=\x88\x8C\xF0\xEE\xD8ýxt\xDC\xC3R|:\xEEc\xE4e\x8E\xB8\xF5\xDE1\xEA\xDDP)\xFAW\xAD\xAD\xABe\xC1\xE8\x95cO\xF8r\xDCóH\xF7{w\x8E\x90ދ\xE3!\xE7?\xB0\x84\xC6-\xA3Ȑ\xC3@b\x8C&\xECC(\x88H \xB6\xFC\x93\xB3\x8F9Z\xA0f\xD3Tv\xBE \x97\xC0R\x9B\xAA\xC8r#ǻ\x89U\xC9dk\xF2$\x96\x8B\xBAֻbk -M\xD9ު-|
[webkit-changes] [191466] trunk/Source
Title: [191466] trunk/Source Revision 191466 Author mmaxfi...@apple.com Date 2015-10-22 12:50:09 -0700 (Thu, 22 Oct 2015) Log Message [Cocoa] Migrate WKSetPatternPhaseInUserSpace() and WKGetUserToBaseCTM() from WKSI https://bugs.webkit.org/show_bug.cgi?id=150460 Reviewed by Tim Horton. Source/WebCore: No reason to use WKSI for these calls. No new tests because there is no behavior change. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::setPlatformShadow): * platform/graphics/cg/GraphicsContextCG.h: (WebCore::getUserToBaseCTM): * platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::putByteArray): * platform/graphics/mac/GraphicsContextMac.mm: (WebCore::setPatternPhaseInUserSpace): (WebCore::GraphicsContext::drawLineForDocumentMarker): * platform/ios/WebCoreSystemInterfaceIOS.mm: * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: Source/WebKit/mac: * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. Source/WebKit2: * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.h trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp trunk/Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm trunk/Source/WebCore/platform/ios/WebCoreSystemInterfaceIOS.mm trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm Diff Modified: trunk/Source/WebCore/ChangeLog (191465 => 191466) --- trunk/Source/WebCore/ChangeLog 2015-10-22 19:10:15 UTC (rev 191465) +++ trunk/Source/WebCore/ChangeLog 2015-10-22 19:50:09 UTC (rev 191466) @@ -1,3 +1,29 @@ +2015-10-22 Myles C. Maxfield+ +[Cocoa] Migrate WKSetPatternPhaseInUserSpace() and WKGetUserToBaseCTM() from WKSI +https://bugs.webkit.org/show_bug.cgi?id=150460 + +Reviewed by Tim Horton. + +No reason to use WKSI for these calls. + +No new tests because there is no behavior change. + +* platform/graphics/cg/GraphicsContextCG.cpp: +(WebCore::GraphicsContext::applyStrokePattern): +(WebCore::GraphicsContext::applyFillPattern): +(WebCore::GraphicsContext::setPlatformShadow): +* platform/graphics/cg/GraphicsContextCG.h: +(WebCore::getUserToBaseCTM): +* platform/graphics/cg/ImageBufferCG.cpp: +(WebCore::ImageBuffer::putByteArray): +* platform/graphics/mac/GraphicsContextMac.mm: +(WebCore::setPatternPhaseInUserSpace): +(WebCore::GraphicsContext::drawLineForDocumentMarker): +* platform/ios/WebCoreSystemInterfaceIOS.mm: +* platform/mac/WebCoreSystemInterface.h: +* platform/mac/WebCoreSystemInterface.mm: + 2015-10-22 Brady Eidson Modern IDB: Basic createObjectStore implementation. Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (191465 => 191466) --- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2015-10-22 19:10:15 UTC (rev 191465) +++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp 2015-10-22 19:50:09 UTC (rev 191466) @@ -583,7 +583,7 @@ void GraphicsContext::applyStrokePattern() { CGContextRef cgContext = platformContext(); -AffineTransform userToBaseCTM = AffineTransform(wkGetUserToBaseCTM(cgContext)); +AffineTransform userToBaseCTM = AffineTransform(getUserToBaseCTM(cgContext)); RetainPtr platformPattern = adoptCF(m_state.strokePattern->createPlatformPattern(userToBaseCTM)); if (!platformPattern) @@ -599,7 +599,7 @@ void GraphicsContext::applyFillPattern() { CGContextRef cgContext = platformContext(); -AffineTransform userToBaseCTM = AffineTransform(wkGetUserToBaseCTM(cgContext)); +AffineTransform userToBaseCTM = AffineTransform(getUserToBaseCTM(cgContext)); RetainPtr platformPattern = adoptCF(m_state.fillPattern->createPlatformPattern(userToBaseCTM)); if (!platformPattern) @@ -1070,7 +1070,7 @@ CGContextRef context = platformContext(); if (!m_state.shadowsIgnoreTransforms) { -CGAffineTransform userToBaseCTM = wkGetUserToBaseCTM(context); +CGAffineTransform userToBaseCTM = getUserToBaseCTM(context); CGFloat A = userToBaseCTM.a * userToBaseCTM.a + userToBaseCTM.b * userToBaseCTM.b; CGFloat B = userToBaseCTM.a * userToBaseCTM.c + userToBaseCTM.b * userToBaseCTM.d; Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.h (191465
[webkit-changes] [191464] trunk/Source/WebInspectorUI
Title: [191464] trunk/Source/WebInspectorUI Revision 191464 Author commit-qu...@webkit.org Date 2015-10-22 11:42:15 -0700 (Thu, 22 Oct 2015) Log Message Web Inspector: Restore :not(:placeholder-shown) behavior on search bars with comments https://bugs.webkit.org/show_bug.cgi?id=150452 Patch by Joseph Pecoraroon 2015-10-22 Reviewed by Timothy Hatcher. * UserInterface/Views/FindBanner.css: (.find-banner.console-find-banner > input[type="search"]:not(:placeholder-shown)): * UserInterface/Views/SearchBar.css: (.search-bar > input[type="search"]:not(:placeholder-shown)): Add back the placeholder-shown related styles and add a comment about what they are for. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css trunk/Source/WebInspectorUI/UserInterface/Views/SearchBar.css Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (191463 => 191464) --- trunk/Source/WebInspectorUI/ChangeLog 2015-10-22 18:36:28 UTC (rev 191463) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-10-22 18:42:15 UTC (rev 191464) @@ -1,3 +1,16 @@ +2015-10-22 Joseph Pecoraro + +Web Inspector: Restore :not(:placeholder-shown) behavior on search bars with comments +https://bugs.webkit.org/show_bug.cgi?id=150452 + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/FindBanner.css: +(.find-banner.console-find-banner > input[type="search"]:not(:placeholder-shown)): +* UserInterface/Views/SearchBar.css: +(.search-bar > input[type="search"]:not(:placeholder-shown)): +Add back the placeholder-shown related styles and add a comment about what they are for. + 2015-10-22 Devin Rousso Web Inspector: Tabbing over CSS properties prepended by * doesn't move the highlighted range Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css (191463 => 191464) --- trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css 2015-10-22 18:36:28 UTC (rev 191463) +++ trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.css 2015-10-22 18:42:15 UTC (rev 191464) @@ -218,3 +218,9 @@ .find-banner.console-find-banner > input[type="search"]:focus { background-color: white; } + +/* Make the search field's background white when it is not focused and has content. + Needs to be a separate rule. See http://webkit.org/b/118162 */ +.find-banner.console-find-banner > input[type="search"]:not(:placeholder-shown) { +background-color: white; +} Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchBar.css (191463 => 191464) --- trunk/Source/WebInspectorUI/UserInterface/Views/SearchBar.css 2015-10-22 18:36:28 UTC (rev 191463) +++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchBar.css 2015-10-22 18:42:15 UTC (rev 191464) @@ -46,3 +46,9 @@ .search-bar > input[type="search"]:focus { background-color: white; } + +/* Make the search field's background white when it is not focused and has content. + Needs to be a separate rule. See http://webkit.org/b/118162 */ +.search-bar > input[type="search"]:not(:placeholder-shown) { +background-color: white; +} ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191467] trunk/Source/WebKit/win
Title: [191467] trunk/Source/WebKit/win Revision 191467 Author ander...@apple.com Date 2015-10-22 12:59:54 -0700 (Thu, 22 Oct 2015) Log Message Move menu creation to WebView https://bugs.webkit.org/show_bug.cgi?id=150463 Reviewed by Tim Horton. * WebView.cpp: (createContextMenuFromItems): (WebView::createContextMenu): Modified Paths trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/WebView.cpp Diff Modified: trunk/Source/WebKit/win/ChangeLog (191466 => 191467) --- trunk/Source/WebKit/win/ChangeLog 2015-10-22 19:50:09 UTC (rev 191466) +++ trunk/Source/WebKit/win/ChangeLog 2015-10-22 19:59:54 UTC (rev 191467) @@ -1,3 +1,14 @@ +2015-10-22 Anders Carlsson+ +Move menu creation to WebView +https://bugs.webkit.org/show_bug.cgi?id=150463 + +Reviewed by Tim Horton. + +* WebView.cpp: +(createContextMenuFromItems): +(WebView::createContextMenu): + 2015-10-21 Anders Carlsson Get rid of WebContextMenuClient::customizeMenu, it's no longer used Modified: trunk/Source/WebKit/win/WebView.cpp (191466 => 191467) --- trunk/Source/WebKit/win/WebView.cpp 2015-10-22 19:50:09 UTC (rev 191466) +++ trunk/Source/WebKit/win/WebView.cpp 2015-10-22 19:59:54 UTC (rev 191467) @@ -1393,6 +1393,33 @@ return m_page; } +static HMENU createContextMenuFromItems(const Vector& items) +{ +HMENU menu = ::CreatePopupMenu(); + +for (auto& item : items) { +UINT flags = 0; + +flags |= item.enabled() ? MF_ENABLED : MF_DISABLED; +flags |= item.checked() ? MF_CHECKED : MF_UNCHECKED; + +switch (item.type()) { +case ActionType: +case CheckableActionType: +::AppendMenu(menu, flags | MF_STRING, item.action(), item.title().charactersWithNullTermination().data()); +break; +case SeparatorType: +::AppendMenu(menu, flags | MF_SEPARATOR, item.action(), nullptr); +break; +case SubmenuType: +::AppendMenu(menu, flags | MF_POPUP, (UINT_PTR)createContextMenuFromItems(item.subMenuItems()), item.title().charactersWithNullTermination().data()); +break; +} +} + +return menu; +} + HMENU WebView::createContextMenu() { auto& contextMenuController = m_page->contextMenuController(); @@ -1401,7 +1428,7 @@ if (!coreMenu) return nullptr; -HMENU contextMenu = coreMenu->platformContextMenu(); +HMENU contextMenu = createContextMenuFromItems(coreMenu->items()); COMPtr uiDelegate; if (SUCCEEDED(this->uiDelegate())) { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191457] trunk/Source
Title: [191457] trunk/Source Revision 191457 Author achristen...@apple.com Date 2015-10-22 11:00:29 -0700 (Thu, 22 Oct 2015) Log Message Initial NSURLSession WebResourceLoader implementation https://bugs.webkit.org/show_bug.cgi?id=150355 Reviewed by Antti Koivisto. Source/WebCore: * platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::AuthenticationChallenge): Export constructor for use in WebKit2. Source/WebKit2: * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): (WebKit::NetworkConnectionToWebProcess::cookiesForDOM): * NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::~NetworkResourceLoader): (WebKit::NetworkResourceLoader::startNetworkLoad): (WebKit::NetworkResourceLoader::setDefersLoading): (WebKit::NetworkResourceLoader::cleanup): (WebKit::NetworkResourceLoader::didConvertHandleToDownload): (WebKit::NetworkResourceLoader::abort): (WebKit::NetworkResourceLoader::willPerformHTTPRedirection): (WebKit::NetworkResourceLoader::didReceiveChallenge): (WebKit::NetworkResourceLoader::didReceiveResponse): (WebKit::NetworkResourceLoader::didReceiveData): (WebKit::NetworkResourceLoader::didCompleteWithError): (WebKit::NetworkResourceLoader::didReceiveResponseAsync): (WebKit::NetworkResourceLoader::willSendRequestAsync): (WebKit::NetworkResourceLoader::continueWillSendRequest): (WebKit::NetworkResourceLoader::continueDidReceiveResponse): (WebKit::NetworkResourceLoader::didSendData): (WebKit::NetworkResourceLoader::receivedCancellation): (WebKit::NetworkResourceLoader::startBufferingTimerIfNeeded): (WebKit::NetworkResourceLoader::bufferingTimerFired): (WebKit::NetworkResourceLoader::validateCacheEntry): (WebKit::NetworkResourceLoader::sendAbortingOnFailure): (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync): (WebKit::NetworkResourceLoader::continueCanAuthenticateAgainstProtectionSpace): (WebKit::NetworkResourceLoader::supportsDataArray): * NetworkProcess/NetworkResourceLoader.h: (WebKit::NetworkResourceLoader::create): (WebKit::NetworkResourceLoader::currentRequest): (WebKit::NetworkResourceLoader::handle): * NetworkProcess/NetworkSession.h: Added. (WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient): (WebKit::NetworkingDataTask::client): (WebKit::NetworkingDataTask::clearClient): (WebKit::NetworkSession::~NetworkSession): * NetworkProcess/cocoa/NetworkSessionCocoa.mm: Added. (toNSURLSessionResponseDisposition): (toNSURLSessionAuthChallengeDisposition): (-[NetworkSessionDelegate initWithNetworkSession:]): (-[NetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]): (-[NetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]): (-[NetworkSessionDelegate URLSession:task:didCompleteWithError:]): (-[NetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]): (-[NetworkSessionDelegate URLSession:dataTask:didReceiveData:]): (WebKit::NetworkSession::create): (WebKit::NetworkSession::singleton): (WebKit::configurationForType): (WebKit::NetworkSession::NetworkSession): (WebKit::NetworkSession::createDataTaskWithRequest): (WebKit::NetworkSession::dataTaskForIdentifier): (WebKit::NetworkingDataTask::NetworkingDataTask): (WebKit::NetworkingDataTask::~NetworkingDataTask): (WebKit::NetworkingDataTask::suspend): (WebKit::NetworkingDataTask::resume): (WebKit::NetworkingDataTask::taskIdentifier): * NetworkProcess/mac/NetworkResourceLoaderMac.mm: (WebKit::NetworkResourceLoader::willCacheResponseAsync): * WebKit2.xcodeproj/project.pbxproj: * config.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/cf/AuthenticationChallenge.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.h trunk/Source/WebKit2/NetworkProcess/mac/NetworkResourceLoaderMac.mm trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/config.h Added Paths trunk/Source/WebKit2/NetworkProcess/NetworkSession.h trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm Diff Modified: trunk/Source/WebCore/ChangeLog (191456 => 191457) --- trunk/Source/WebCore/ChangeLog 2015-10-22 17:17:56 UTC (rev 191456) +++ trunk/Source/WebCore/ChangeLog 2015-10-22 18:00:29 UTC (rev 191457) @@ -1,3 +1,13 @@ +2015-10-22 Alex Christensen+ +Initial NSURLSession WebResourceLoader implementation +https://bugs.webkit.org/show_bug.cgi?id=150355 + +Reviewed by Antti Koivisto. + +* platform/network/cf/AuthenticationChallenge.h: +(WebCore::AuthenticationChallenge::AuthenticationChallenge): Export constructor for use in WebKit2. + 2015-10-22 Frederic Wang [Mac] Add support for the USE_TYPO_METRICS
[webkit-changes] [191459] branches/safari-601.1.46-branch
Title: [191459] branches/safari-601.1.46-branch Revision 191459 Author matthew_han...@apple.com Date 2015-10-22 11:35:55 -0700 (Thu, 22 Oct 2015) Log Message Merge r191063. rdar://problem/22900764 Modified Paths branches/safari-601.1.46-branch/LayoutTests/ChangeLog branches/safari-601.1.46-branch/Source/WebCore/ChangeLog branches/safari-601.1.46-branch/Source/WebCore/loader/FrameLoader.cpp branches/safari-601.1.46-branch/Source/WebCore/loader/FrameLoader.h branches/safari-601.1.46-branch/Source/WebCore/page/Page.h branches/safari-601.1.46-branch/Source/WebCore/replay/UserInputBridge.cpp branches/safari-601.1.46-branch/Source/WebCore/replay/UserInputBridge.h branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/Shared/WebPageCreationParameters.cpp branches/safari-601.1.46-branch/Source/WebKit2/Shared/WebPageCreationParameters.h branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/C/WKPage.cpp branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/C/WKPage.h branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebFrameProxy.cpp branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/WebPageProxy.h branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in branches/safari-601.1.46-branch/Tools/ChangeLog branches/safari-601.1.46-branch/Tools/WebKitTestRunner/mac/TestControllerMac.mm Removed Paths branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker-expected.txt branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html.json Diff Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (191458 => 191459) --- branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-10-22 18:35:12 UTC (rev 191458) +++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-10-22 18:35:55 UTC (rev 191459) @@ -1,5 +1,22 @@ 2015-10-20 Matthew Hanson+Merge r191063. rdar://problem/22900764 + +2015-10-14 Alex Christensen + +Add SPI for reloading without content blockers +https://bugs.webkit.org/show_bug.cgi?id=150058 +rdar://problem/2274 + +Reviewed by Sam Weinig. + +* http/tests/contentextensions/disable-blocker-expected.txt: Removed. +* http/tests/contentextensions/disable-blocker.html: Removed. +* http/tests/contentextensions/disable-blocker.html.json: Removed. +_userContentExtensionsEnabled is going to be removed, and its functionality is what this test tested. + +2015-10-20 Matthew Hanson + Merge r190510. rdar://problem/22900764 2015-10-02 Alex Christensen Deleted: branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker-expected.txt (191458 => 191459) --- branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker-expected.txt 2015-10-22 18:35:12 UTC (rev 191458) +++ branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker-expected.txt 2015-10-22 18:35:55 UTC (rev 191459) @@ -1,9 +0,0 @@ -CONSOLE MESSAGE: line 12: status: 0, readyState:1, responseText: -CONSOLE MESSAGE: line 12: status: 200, readyState:2, responseText: -CONSOLE MESSAGE: line 12: status: 200, readyState:3, responseText: -CONSOLE MESSAGE: line 12: status: 200, readyState:4, responseText: This page should load. - -console.log("This page should load."); - - -This page should load successfully. The content blocker is disabled in WebKitTestRunner before loading the page. Deleted: branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html (191458 => 191459) --- branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html 2015-10-22 18:35:12 UTC (rev 191458) +++ branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html 2015-10-22 18:35:55 UTC (rev 191459) @@ -1,25 +0,0 @@ - - -if (window.testRunner) { -testRunner.dumpAsText(); -testRunner.waitUntilDone(); -} - -function sendRequest() -{ -var xhr = new XMLHttpRequest(); -xhr._onreadystatechange_ =
[webkit-changes] [191461] branches/safari-601.1.46-branch/Source/WebCore
Title: [191461] branches/safari-601.1.46-branch/Source/WebCore Revision 191461 Author matthew_han...@apple.com Date 2015-10-22 11:36:09 -0700 (Thu, 22 Oct 2015) Log Message Merge r191357. rdar://problem/23103005 Modified Paths branches/safari-601.1.46-branch/Source/WebCore/ChangeLog branches/safari-601.1.46-branch/Source/WebCore/accessibility/AccessibilityTable.cpp Diff Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (191460 => 191461) --- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-10-22 18:36:01 UTC (rev 191460) +++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-10-22 18:36:09 UTC (rev 191461) @@ -1,5 +1,24 @@ 2015-10-20 Matthew Hanson+Merge r191357. rdar://problem/23103005 + +2015-10-20 Chris Fleizach + +AX: CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::AccessibilityTable::tableElement const + 116 +https://bugs.webkit.org/show_bug.cgi?id=150349 + +Reviewed by Brent Fulgham. + +The crash point for this bug says that the parentElement of the firstBody is garbage when it's accessed. +Unfortunately, I could not reproduce this in-situ or with a test. +So my speculative solution is to recalculate those body elements to ensure that they're valid before we access. + +* accessibility/AccessibilityTable.cpp: +(WebCore::AccessibilityTable::tableElement): +(WebCore::AccessibilityTable::isDataTable): + +2015-10-20 Matthew Hanson + Merge r191223. rdar://problem/22900764 2015-10-16 Alex Christensen Modified: branches/safari-601.1.46-branch/Source/WebCore/accessibility/AccessibilityTable.cpp (191460 => 191461) --- branches/safari-601.1.46-branch/Source/WebCore/accessibility/AccessibilityTable.cpp 2015-10-22 18:36:01 UTC (rev 191460) +++ branches/safari-601.1.46-branch/Source/WebCore/accessibility/AccessibilityTable.cpp 2015-10-22 18:36:09 UTC (rev 191461) @@ -99,17 +99,15 @@ if (is(table.element())) return downcast(table.element()); +table.forceSectionsRecalc(); + // If the table has a display:table-row-group, then the RenderTable does not have a pointer to it's HTMLTableElement. // We can instead find it by asking the firstSection for its parent. RenderTableSection* firstBody = table.firstBody(); if (!firstBody || !firstBody->element()) return nullptr; -Element* actualTable = firstBody->element()->parentElement(); -if (!is(actualTable)) -return nullptr; - -return downcast(actualTable); +return ancestorsOfType(*(firstBody->element())).first(); } bool AccessibilityTable::isDataTable() const ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191463] branches/safari-601.1.46-branch
Title: [191463] branches/safari-601.1.46-branch Revision 191463 Author matthew_han...@apple.com Date 2015-10-22 11:36:28 -0700 (Thu, 22 Oct 2015) Log Message Merge r191395. rdar://problem/22846455 Modified Paths branches/safari-601.1.46-branch/Source/_javascript_Core/ChangeLog branches/safari-601.1.46-branch/Source/_javascript_Core/dfg/DFGPlan.cpp branches/safari-601.1.46-branch/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp branches/safari-601.1.46-branch/Source/_javascript_Core/runtime/Options.h branches/safari-601.1.46-branch/Tools/ChangeLog branches/safari-601.1.46-branch/Tools/Scripts/run-jsc-stress-tests Diff Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/ChangeLog (191462 => 191463) --- branches/safari-601.1.46-branch/Source/_javascript_Core/ChangeLog 2015-10-22 18:36:16 UTC (rev 191462) +++ branches/safari-601.1.46-branch/Source/_javascript_Core/ChangeLog 2015-10-22 18:36:28 UTC (rev 191463) @@ -1,3 +1,22 @@ +2015-10-21 Matthew Hanson+ +Merge r191395. rdar://problem/22846455 + +2015-10-21 Filip Pizlo + +Failures in PutStackSinkingPhase should be less severe +https://bugs.webkit.org/show_bug.cgi?id=150400 + +Reviewed by Geoffrey Garen. + +Make the PutStackSinkingPhase abort instead of asserting. To test that it's OK to not have +PutStackSinkingPhase run, this adds a test mode where we run without PutStackSinkingPhase. + +* dfg/DFGPlan.cpp: Make it possible to not run PutStackSinkingPhase for tests. +(JSC::DFG::Plan::compileInThreadImpl): +* dfg/DFGPutStackSinkingPhase.cpp: PutStackSinkingPhase should abort instead of asserting, except when validation is enabled. +* runtime/Options.h: Add an option for disabling PutStackSinkingPhase. + 2015-10-20 Matthew Hanson Merge r191364. rdar://problem/22864960 Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/dfg/DFGPlan.cpp (191462 => 191463) --- branches/safari-601.1.46-branch/Source/_javascript_Core/dfg/DFGPlan.cpp 2015-10-22 18:36:16 UTC (rev 191462) +++ branches/safari-601.1.46-branch/Source/_javascript_Core/dfg/DFGPlan.cpp 2015-10-22 18:36:28 UTC (rev 191463) @@ -354,7 +354,8 @@ // Ideally, these would be run to fixpoint with the object allocation sinking phase. performArgumentsElimination(dfg); -performPutStackSinking(dfg); +if (Options::usePutStackSinking()) +performPutStackSinking(dfg); performConstantHoisting(dfg); performGlobalCSE(dfg); Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp (191462 => 191463) --- branches/safari-601.1.46-branch/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp 2015-10-22 18:36:16 UTC (rev 191462) +++ branches/safari-601.1.46-branch/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp 2015-10-22 18:36:28 UTC (rev 191463) @@ -230,6 +230,39 @@ dataLog("Deferred at ", node, ":", deferred, "\n"); if (node->op() == GetStack) { +// Handle the case that the input doesn't match our requirements. This is +// really a bug, but it's a benign one if we simply don't run this phase. +// It usually arises because of patterns like: +// +// if (thing) +// PutStack() +// ... +// if (thing) +// GetStack() +// +// Or: +// +// if (never happens) +// GetStack() +// +// Because this phase runs early in SSA, it should be sensible to enforce +// that no such code pattern has arisen yet. So, when validation is +// enabled, we assert that we aren't seeing this. But with validation +// disabled we silently let this fly and we just abort this phase. +// FIXME: Get rid of all remaining cases of conflicting GetStacks. +// https://bugs.webkit.org/show_bug.cgi?id=150398 + +bool isConflicting = +deferred.operand(node->stackAccessData()->local) == ConflictingFlush; + +if (validationEnabled()) +DFG_ASSERT(m_graph, node, !isConflicting); + +if (isConflicting) { +// Oh noes! Abort!! +return false; +} + // A GetStack
[webkit-changes] [191460] branches/safari-601.1.46-branch/Source/WebCore
Title: [191460] branches/safari-601.1.46-branch/Source/WebCore Revision 191460 Author matthew_han...@apple.com Date 2015-10-22 11:36:01 -0700 (Thu, 22 Oct 2015) Log Message Merge r191223. rdar://problem/22900764 Modified Paths branches/safari-601.1.46-branch/Source/WebCore/ChangeLog branches/safari-601.1.46-branch/Source/WebCore/page/UserContentController.cpp Diff Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (191459 => 191460) --- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-10-22 18:35:55 UTC (rev 191459) +++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-10-22 18:36:01 UTC (rev 191460) @@ -1,5 +1,27 @@ 2015-10-20 Matthew Hanson+Merge r191223. rdar://problem/22900764 + +2015-10-16 Alex Christensen + +Disabled content blockers should not block any loads +https://bugs.webkit.org/show_bug.cgi?id=150261 + +Reviewed by Brady Eidson. + +This fix was tested manually by reloading without content blockers +on websites with iframes and content blockers that block the contents of the iframes. + +* page/UserContentController.cpp: +(WebCore::UserContentController::removeAllUserContentExtensions): +(WebCore::contentExtensionsEnabled): +(WebCore::UserContentController::processContentExtensionRulesForLoad): +(WebCore::UserContentController::actionsForResourceLoad): +Check the DocumentLoader of the main frame when checking if content extensions are disabled, +because that is the DocumentLoader that has the flag from reloading without content blockers. + +2015-10-20 Matthew Hanson + Merge r191063. rdar://problem/22900764 2015-10-14 Alex Christensen Modified: branches/safari-601.1.46-branch/Source/WebCore/page/UserContentController.cpp (191459 => 191460) --- branches/safari-601.1.46-branch/Source/WebCore/page/UserContentController.cpp 2015-10-22 18:35:55 UTC (rev 191459) +++ branches/safari-601.1.46-branch/Source/WebCore/page/UserContentController.cpp 2015-10-22 18:36:01 UTC (rev 191460) @@ -205,12 +205,24 @@ m_contentExtensionBackend->removeAllContentExtensions(); } +static bool contentExtensionsEnabled(const DocumentLoader& documentLoader) +{ +if (auto frame = documentLoader.frame()) { +if (frame->isMainFrame()) +return documentLoader.userContentExtensionsEnabled(); +if (auto mainDocumentLoader = frame->mainFrame().loader().documentLoader()) +return mainDocumentLoader->userContentExtensionsEnabled(); +} + +return true; +} + void UserContentController::processContentExtensionRulesForLoad(ResourceRequest& request, ResourceType resourceType, DocumentLoader& initiatingDocumentLoader) { if (!m_contentExtensionBackend) return; -if (!initiatingDocumentLoader.userContentExtensionsEnabled()) +if (!contentExtensionsEnabled(initiatingDocumentLoader)) return; m_contentExtensionBackend->processContentExtensionRulesForLoad(request, resourceType, initiatingDocumentLoader); @@ -221,7 +233,7 @@ if (!m_contentExtensionBackend) return Vector(); -if (!initiatingDocumentLoader.userContentExtensionsEnabled()) +if (!contentExtensionsEnabled(initiatingDocumentLoader)) return Vector(); return m_contentExtensionBackend->actionsForResourceLoad(resourceLoadInfo); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191458] branches/safari-601.1.46-branch
Title: [191458] branches/safari-601.1.46-branch Revision 191458 Author matthew_han...@apple.com Date 2015-10-22 11:35:12 -0700 (Thu, 22 Oct 2015) Log Message Merge r190510. rdar://problem/22900764 Modified Paths branches/safari-601.1.46-branch/LayoutTests/ChangeLog branches/safari-601.1.46-branch/Source/WebCore/ChangeLog branches/safari-601.1.46-branch/Source/WebCore/html/HTMLMediaElement.cpp branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.h branches/safari-601.1.46-branch/Source/WebCore/loader/FrameLoader.cpp branches/safari-601.1.46-branch/Source/WebCore/loader/ResourceLoader.cpp branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedResourceLoader.cpp branches/safari-601.1.46-branch/Source/WebCore/page/DOMWindow.cpp branches/safari-601.1.46-branch/Source/WebCore/page/UserContentController.cpp branches/safari-601.1.46-branch/Source/WebCore/page/UserContentController.h branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp branches/safari-601.1.46-branch/Tools/ChangeLog branches/safari-601.1.46-branch/Tools/WebKitTestRunner/mac/TestControllerMac.mm Added Paths branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker-expected.txt branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html.json Diff Modified: branches/safari-601.1.46-branch/LayoutTests/ChangeLog (191457 => 191458) --- branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-10-22 18:00:29 UTC (rev 191457) +++ branches/safari-601.1.46-branch/LayoutTests/ChangeLog 2015-10-22 18:35:12 UTC (rev 191458) @@ -1,3 +1,19 @@ +2015-10-20 Matthew Hanson+ +Merge r190510. rdar://problem/22900764 + +2015-10-02 Alex Christensen + +Reloading without content blockers doesn’t apply to resource loads after the main frame finishes +https://bugs.webkit.org/show_bug.cgi?id=149430 +rdar://problem/2274 + +Reviewed by Geoffrey Garen. + +* http/tests/contentextensions/disable-blocker-expected.txt: Added. +* http/tests/contentextensions/disable-blocker.html: Added. +* http/tests/contentextensions/disable-blocker.html.json: Added. + 2015-10-16 Matthew Hanson Merge r190752. rdar://problem/23110932 Added: branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker-expected.txt (0 => 191458) --- branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker-expected.txt (rev 0) +++ branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker-expected.txt 2015-10-22 18:35:12 UTC (rev 191458) @@ -0,0 +1,9 @@ +CONSOLE MESSAGE: line 12: status: 0, readyState:1, responseText: +CONSOLE MESSAGE: line 12: status: 200, readyState:2, responseText: +CONSOLE MESSAGE: line 12: status: 200, readyState:3, responseText: +CONSOLE MESSAGE: line 12: status: 200, readyState:4, responseText: This page should load. + +console.log("This page should load."); + + +This page should load successfully. The content blocker is disabled in WebKitTestRunner before loading the page. Added: branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html (0 => 191458) --- branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html (rev 0) +++ branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html 2015-10-22 18:35:12 UTC (rev 191458) @@ -0,0 +1,25 @@ + + +if (window.testRunner) { +testRunner.dumpAsText(); +testRunner.waitUntilDone(); +} + +function sendRequest() +{ +var xhr = new XMLHttpRequest(); +xhr._onreadystatechange_ = function() { +console.log("status: " + xhr.status + ", readyState:" + xhr.readyState + ", responseText: " + xhr.responseText); +if (xhr.readyState == 4) { +testRunner.notifyDone(); +} +} + +xhr.open("GET", "resources/should-load.html", true); + xhr.send(); +} + + + +This page should load successfully. The content blocker is disabled in WebKitTestRunner before loading the page. + Added: branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html.json (0 => 191458) --- branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html.json (rev 0) +++ branches/safari-601.1.46-branch/LayoutTests/http/tests/contentextensions/disable-blocker.html.json 2015-10-22 18:35:12 UTC (rev 191458) @@ -0,0 +1,10 @@ +[ +{ +"action": { +"type": "block" +}, +"trigger": { +
[webkit-changes] [191450] trunk/Source/WebCore
Title: [191450] trunk/Source/WebCore Revision 191450 Author commit-qu...@webkit.org Date 2015-10-22 03:50:09 -0700 (Thu, 22 Oct 2015) Log Message [EFL] Fix build break since r191439 https://bugs.webkit.org/show_bug.cgi?id=150441 Patch by Joonghun Parkon 2015-10-22 Reviewed by Csaba Osztrogonác. No new tests, no new behaviours. * platform/Logging.cpp: (WebCore::registerNotifyCallback): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/Logging.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (191449 => 191450) --- trunk/Source/WebCore/ChangeLog 2015-10-22 09:49:33 UTC (rev 191449) +++ trunk/Source/WebCore/ChangeLog 2015-10-22 10:50:09 UTC (rev 191450) @@ -1,3 +1,15 @@ +2015-10-22 Joonghun Park + +[EFL] Fix build break since r191439 +https://bugs.webkit.org/show_bug.cgi?id=150441 + +Reviewed by Csaba Osztrogonác. + +No new tests, no new behaviours. + +* platform/Logging.cpp: +(WebCore::registerNotifyCallback): + 2015-10-22 Carlos Garcia Campos Unreviewed. Fix GTK+ build after r191423. Modified: trunk/Source/WebCore/platform/Logging.cpp (191449 => 191450) --- trunk/Source/WebCore/platform/Logging.cpp 2015-10-22 09:49:33 UTC (rev 191449) +++ trunk/Source/WebCore/platform/Logging.cpp 2015-10-22 10:50:09 UTC (rev 191450) @@ -75,6 +75,9 @@ notify_register_dispatch(notifyID.utf8().data(), , dispatch_get_main_queue(), ^(int) { callback(); }); +#else +UNUSED_PARAM(notifyID); +UNUSED_PARAM(callback); #endif } #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [191451] trunk
Title: [191451] trunk Revision 191451 Author rn...@webkit.org Date 2015-10-22 04:37:46 -0700 (Thu, 22 Oct 2015) Log Message REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs https://bugs.webkit.org/show_bug.cgi?id=150428 Reviewed by Antti Koivisto. Source/WebCore: The bug was caused by updateFocusAppearance in WebPage::restoreSelectionInFocusedEditableElement revealing the focused element which was added in r181972. Fixed the bug by adding an option to suppress this behavior here. * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateFocusAppearanceSoon): * dom/Document.h: * dom/Element.cpp: (WebCore::Element::focus): (WebCore::Element::updateFocusAppearanceAfterAttachIfNeeded): (WebCore::Element::updateFocusAppearance): * dom/Element.h: * history/CachedPage.cpp: (WebCore::CachedPage::restore): * html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::updateFocusAppearance): * html/HTMLAreaElement.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::runPostTypeUpdateTasks): (WebCore::HTMLInputElement::didAttachRenderers): * html/HTMLInputElement.h: * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance): * html/HTMLTextAreaElement.h: Source/WebKit2: Call updateFocusAppearance with RevealMode::DoNotReveal to avoid revealing the focused element. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::restoreSelectionInFocusedEditableElement): Tools: Added a regression test using WebKit API test. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added. (TestWebKitAPI::didFinishLoadForFrame): (TestWebKitAPI::TEST): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/history/CachedPage.cpp trunk/Source/WebCore/html/HTMLAreaElement.cpp trunk/Source/WebCore/html/HTMLAreaElement.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/HTMLTextAreaElement.cpp trunk/Source/WebCore/html/HTMLTextAreaElement.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj Added Paths trunk/Tools/TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm Diff Modified: trunk/Source/WebCore/ChangeLog (191450 => 191451) --- trunk/Source/WebCore/ChangeLog 2015-10-22 10:50:09 UTC (rev 191450) +++ trunk/Source/WebCore/ChangeLog 2015-10-22 11:37:46 UTC (rev 191451) @@ -1,3 +1,37 @@ +2015-10-22 Ryosuke Niwa+ +REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs +https://bugs.webkit.org/show_bug.cgi?id=150428 + +Reviewed by Antti Koivisto. + +The bug was caused by updateFocusAppearance in WebPage::restoreSelectionInFocusedEditableElement +revealing the focused element which was added in r181972. Fixed the bug by adding an option to +suppress this behavior here. + +* dom/Document.cpp: +(WebCore::Document::Document): +(WebCore::Document::updateFocusAppearanceSoon): +* dom/Document.h: +* dom/Element.cpp: +(WebCore::Element::focus): +(WebCore::Element::updateFocusAppearanceAfterAttachIfNeeded): +(WebCore::Element::updateFocusAppearance): +* dom/Element.h: +* history/CachedPage.cpp: +(WebCore::CachedPage::restore): +* html/HTMLAreaElement.cpp: +(WebCore::HTMLAreaElement::updateFocusAppearance): +* html/HTMLAreaElement.h: +* html/HTMLInputElement.cpp: +(WebCore::HTMLInputElement::updateFocusAppearance): +(WebCore::HTMLInputElement::runPostTypeUpdateTasks): +(WebCore::HTMLInputElement::didAttachRenderers): +* html/HTMLInputElement.h: +* html/HTMLTextAreaElement.cpp: +(WebCore::HTMLTextAreaElement::updateFocusAppearance): +* html/HTMLTextAreaElement.h: + 2015-10-22 Joonghun Park [EFL] Fix build break since r191439 Modified: trunk/Source/WebCore/dom/Document.cpp (191450 => 191451) --- trunk/Source/WebCore/dom/Document.cpp 2015-10-22 10:50:09 UTC (rev 191450) +++ trunk/Source/WebCore/dom/Document.cpp 2015-10-22 11:37:46 UTC (rev 191451) @@ -455,7 +455,7 @@ , m_closeAfterStyleRecalc(false) , m_gotoAnchorNeededAfterStylesheetsLoad(false) , m_frameElementsShouldIgnoreScrolling(false) -, m_updateFocusAppearanceRestoresSelection(false) +, m_updateFocusAppearanceRestoresSelection(SelectionRestorationMode::SetDefault) , m_ignoreDestructiveWriteCount(0) , m_markers(std::make_unique(*this)) ,
[webkit-changes] [191480] trunk
Title: [191480] trunk Revision 191480 Author dba...@webkit.org Date 2015-10-22 15:14:08 -0700 (Thu, 22 Oct 2015) Log Message Unreviewed, rolling out r191113. Rollout r144451 since it regressed the visibility of the search cancel button when a search field is empty or showing placeholder text. Further investigation is needed. Reverted changeset: "[iOS] DOM click event may not be dispatched when page has :active style and " https://bugs.webkit.org/show_bug.cgi?id=144451 http://trac.webkit.org/changeset/191113 Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderSearchField.cpp trunk/Source/WebCore/rendering/RenderSearchField.h Removed Paths trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field-expected.txt trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html trunk/LayoutTests/fast/forms/search/search-cancel-button-visible-when-input-becomes-disabled-expected.html trunk/LayoutTests/fast/forms/search/search-cancel-button-visible-when-input-becomes-disabled.html trunk/LayoutTests/fast/forms/search/search-cancel-button-visible-when-input-becomes-readonly-expected.html trunk/LayoutTests/fast/forms/search/search-cancel-button-visible-when-input-becomes-readonly.html trunk/LayoutTests/fast/forms/search/search-cancel-in-formerly-invisible-element-expected.html trunk/LayoutTests/fast/forms/search/search-cancel-in-formerly-invisible-element.html trunk/LayoutTests/fast/forms/search/search-cancel-toggle-visibility-initially-hidden-expected.html trunk/LayoutTests/fast/forms/search/search-cancel-toggle-visibility-initially-hidden.html trunk/LayoutTests/fast/forms/search/search-cancel-toggle-visibility-initially-visible-expected.html trunk/LayoutTests/fast/forms/search/search-cancel-toggle-visibility-initially-visible.html Diff Modified: trunk/LayoutTests/ChangeLog (191479 => 191480) --- trunk/LayoutTests/ChangeLog 2015-10-22 21:54:11 UTC (rev 191479) +++ trunk/LayoutTests/ChangeLog 2015-10-22 22:14:08 UTC (rev 191480) @@ -1,3 +1,18 @@ +2015-10-22 Daniel Bates+ +Unreviewed, rolling out r191113. + +Rollout r144451 since it regressed the visibility of the +search cancel button when a search field is empty or showing +placeholder text. Further investigation is needed. + +Reverted changeset: + +"[iOS] DOM click event may not be dispatched when page has +:active style and " +https://bugs.webkit.org/show_bug.cgi?id=144451 +http://trac.webkit.org/changeset/191113 + 2015-10-22 Brady Eidson Skip a racey test until it can be made proper. Deleted: trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field-expected.txt (191479 => 191480) --- trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field-expected.txt 2015-10-22 21:54:11 UTC (rev 191479) +++ trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field-expected.txt 2015-10-22 22:14:08 UTC (rev 191480) @@ -1,9 +0,0 @@ -Test that an element, with an onclick handler and an empty ontouchstart attribute, in an on a page with a search field and specifies an :active pseudo-class for receives a DOM click event when tapped. To run this test by hand, click the blue square below. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -PASS clicked blue square -PASS successfullyParsed is true - -TEST COMPLETE - Deleted: trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html (191479 => 191480) --- trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html 2015-10-22 21:54:11 UTC (rev 191479) +++ trunk/LayoutTests/fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html 2015-10-22 22:14:08 UTC (rev 191480) @@ -1,72 +0,0 @@ - - - - -body:active { -/* Must be non-empty. */ --webkit-tap-highlight-color: yellow; -} - -