[webkit-changes] [228320] trunk/Source/WebCore

[zalan]

Title: [228320] trunk/Source/WebCore








Revision 228320
Author za...@apple.com
Date 2018-02-09 07:05:15 -0800 (Fri, 09 Feb 2018)


Log Message
[RenderTreeBuilder] Move multicolumn spanner mutation logic to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=182627


Reviewed by Antti Koivisto.

Move spanner triggered mutation logic to RenderTreeBuilder.

No change in functionality.

* rendering/RenderFragmentedFlow.h:
* rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::isColumnSpanningDescendant const):
(WebCore::findSetRendering): Deleted.
(WebCore::isValidColumnSpanner): Deleted.
(WebCore::spannerPlacehoderCandidate): Deleted.
(WebCore::RenderMultiColumnFlow::processPossibleSpannerDescendant): Deleted.
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted): Deleted.
* rendering/RenderMultiColumnFlow.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::insertedIntoTree):
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::multiColumnDescendantInserted):
* rendering/updating/RenderTreeBuilder.h:
* rendering/updating/RenderTreeBuilderMultiColumn.cpp:
(WebCore::findSetRendering):
(WebCore::spannerPlacehoderCandidate):
(WebCore::isValidColumnSpanner):
(WebCore::RenderTreeBuilder::MultiColumn::multiColumnDescendantInserted):
(WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant):
* rendering/updating/RenderTreeBuilderMultiColumn.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFragmentedFlow.h
trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp
trunk/Source/WebCore/rendering/RenderMultiColumnFlow.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (228319 => 228320)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 14:57:12 UTC (rev 228319)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 15:05:15 UTC (rev 228320)
@@ -1,3 +1,37 @@
+2018-02-09  Zalan Bujtas  
+
+[RenderTreeBuilder] Move multicolumn spanner mutation logic to RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=182627
+
+
+Reviewed by Antti Koivisto.
+
+Move spanner triggered mutation logic to RenderTreeBuilder.
+
+No change in functionality.
+
+* rendering/RenderFragmentedFlow.h:
+* rendering/RenderMultiColumnFlow.cpp:
+(WebCore::RenderMultiColumnFlow::isColumnSpanningDescendant const):
+(WebCore::findSetRendering): Deleted.
+(WebCore::isValidColumnSpanner): Deleted.
+(WebCore::spannerPlacehoderCandidate): Deleted.
+(WebCore::RenderMultiColumnFlow::processPossibleSpannerDescendant): Deleted.
+(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted): Deleted.
+* rendering/RenderMultiColumnFlow.h:
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::insertedIntoTree):
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::multiColumnDescendantInserted):
+* rendering/updating/RenderTreeBuilder.h:
+* rendering/updating/RenderTreeBuilderMultiColumn.cpp:
+(WebCore::findSetRendering):
+(WebCore::spannerPlacehoderCandidate):
+(WebCore::isValidColumnSpanner):
+(WebCore::RenderTreeBuilder::MultiColumn::multiColumnDescendantInserted):
+(WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant):
+* rendering/updating/RenderTreeBuilderMultiColumn.h:
+
 2018-02-09  Javier Fernandez  
 
 [css-align] Implement the new behavior of 'legacy' for justify-items


Modified: trunk/Source/WebCore/rendering/RenderFragmentedFlow.h (228319 => 228320)

--- trunk/Source/WebCore/rendering/RenderFragmentedFlow.h	2018-02-09 14:57:12 UTC (rev 228319)
+++ trunk/Source/WebCore/rendering/RenderFragmentedFlow.h	2018-02-09 15:05:15 UTC (rev 228320)
@@ -86,8 +86,6 @@
 
 virtual bool singleFragmentHasUniformLogicalHeight() const { return true; }
 
-// Called when a descendant of the flow thread has been inserted.
-virtual void fragmentedFlowDescendantInserted(RenderObject&) { }
 // Called when a sibling or descendant of the flow thread is about to be removed.
 virtual void fragmentedFlowRelativeWillBeRemoved(RenderObject&) { }
 // Called when a descendant box's layout is finished and it has been positioned within its container.


Modified: trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp (228319 => 228320)

--- trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp	2018-02-09 14:57:12 UTC (rev 228319)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp	2018-02-09 15:05:15 UTC (rev 228320)

[webkit-changes] [228322] trunk/Source/WebKitLegacy/mac

[pvollan]

Title: [228322] trunk/Source/WebKitLegacy/mac








Revision 228322
Author pvol...@apple.com
Date 2018-02-09 09:26:47 -0800 (Fri, 09 Feb 2018)


Log Message
Unreviewed 32-bit build fix after .

* WebView/WebWindowAnimation.mm:
(-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.mm




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (228321 => 228322)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-02-09 16:48:53 UTC (rev 228321)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-02-09 17:26:47 UTC (rev 228322)
@@ -1,3 +1,10 @@
+2018-02-09  Per Arne Vollan  
+
+Unreviewed 32-bit build fix after .
+
+* WebView/WebWindowAnimation.mm:
+(-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
+
 2018-02-08  Per Arne Vollan  
 
 Move WebVideoFullscreenController from WebCore to WebKitLegacy.


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.mm (228321 => 228322)

--- trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.mm	2018-02-09 16:48:53 UTC (rev 228321)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.mm	2018-02-09 17:26:47 UTC (rev 228322)
@@ -210,7 +210,7 @@
 if (dist > maxDist)
 maxDist = dist;
 
-return std::min(sqrt(maxDist) * speedFactor, maxAdditionalDuration);
+return std::min(static_cast(sqrt(maxDist) * speedFactor), maxAdditionalDuration);
 }
 
 - (void)startAnimation






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228326] trunk

[commit-queue]

Title: [228326] trunk








Revision 228326
Author commit-qu...@webkit.org
Date 2018-02-09 10:27:13 -0800 (Fri, 09 Feb 2018)


Log Message
Add support for cache storage of blob response
https://bugs.webkit.org/show_bug.cgi?id=182637

Patch by Youenn Fablet  on 2018-02-09
Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/cache-storage/script-tests/cache-put.js:
(cache_test.async):
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/window/cache-put.https.html:

Source/WebCore:

Covered by updated WPT test.
When putting a blob response in cache, create a readable stream to easily get the body.
Make clear that caching form data is not supported.

* Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::put):
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::isBlob const):
(WebCore::FetchBody::isFormData const):
* Modules/fetch/FetchResponse.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/script-tests/cache-put.js
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https.html
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/cache/DOMCache.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/Modules/fetch/FetchResponse.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (228325 => 228326)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-02-09 18:10:53 UTC (rev 228325)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-02-09 18:27:13 UTC (rev 228326)
@@ -1,3 +1,17 @@
+2018-02-09  Youenn Fablet  
+
+Add support for cache storage of blob response
+https://bugs.webkit.org/show_bug.cgi?id=182637
+
+Reviewed by Brady Eidson.
+
+* web-platform-tests/service-workers/cache-storage/script-tests/cache-put.js:
+(cache_test.async):
+* web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
+* web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
+* web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:
+* web-platform-tests/service-workers/cache-storage/window/cache-put.https.html:
+
 2018-02-09  Javier Fernandez  
 
 [css-align] Implement the new behavior of 'legacy' for justify-items


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/script-tests/cache-put.js (228325 => 228326)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/script-tests/cache-put.js	2018-02-09 18:10:53 UTC (rev 228325)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/script-tests/cache-put.js	2018-02-09 18:27:13 UTC (rev 228326)
@@ -335,4 +335,12 @@
 });
   }, 'Cache.put should store Response.redirect() correctly');
 
+cache_test(async (cache) => {
+var request = new Request(test_url);
+var response = new Response(new Blob([test_body]));
+await cache.put(request, response);
+var cachedResponse = await cache.match(request);
+assert_equals(await cachedResponse.text(), test_body);
+  }, 'Cache.put called with simple Request and blob Response');
+
 done();


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt (228325 => 228326)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt	2018-02-09 18:10:53 UTC (rev 228325)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt	2018-02-09 18:27:13 UTC (rev 228326)
@@ -23,4 +23,5 @@
 PASS Cache.put with a VARY:* Response 
 PASS Cache.put with an embedded VARY:* Response 
 PASS Cache.put should store Response.redirect() correctly 
+PASS Cache.put called with simple Request and blob Response 
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt (228325 => 228326)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt	2018-02-09 18:10:53 UTC (rev 228325)
+++ 

[webkit-changes] [228328] trunk/Source/WebKitLegacy/mac

[pvollan]

Title: [228328] trunk/Source/WebKitLegacy/mac








Revision 228328
Author pvol...@apple.com
Date 2018-02-09 10:40:08 -0800 (Fri, 09 Feb 2018)


Log Message
Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
https://bugs.webkit.org/show_bug.cgi?id=182641

Reviewed by Dan Bernstein.

Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
https://trac.webkit.org/changeset/228308.

* WebView/WebVideoFullscreenController.h:
* WebView/WebVideoFullscreenHUDWindowController.mm:
* WebView/WebWindowAnimation.h:
* WebView/WebWindowAnimation.mm:
(WebCore::WebWindowAnimationDurationFromDuration): Deleted.
(WebCore::scaledRect): Deleted.
(WebCore::squaredDistance): Deleted.

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h
trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm
trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.h
trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.mm




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (228327 => 228328)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-02-09 18:31:29 UTC (rev 228327)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-02-09 18:40:08 UTC (rev 228328)
@@ -1,5 +1,23 @@
 2018-02-09  Per Arne Vollan  
 
+Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
+https://bugs.webkit.org/show_bug.cgi?id=182641
+
+Reviewed by Dan Bernstein.
+
+Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
+https://trac.webkit.org/changeset/228308.
+
+* WebView/WebVideoFullscreenController.h:
+* WebView/WebVideoFullscreenHUDWindowController.mm:
+* WebView/WebWindowAnimation.h:
+* WebView/WebWindowAnimation.mm:
+(WebCore::WebWindowAnimationDurationFromDuration): Deleted.
+(WebCore::scaledRect): Deleted.
+(WebCore::squaredDistance): Deleted.
+
+2018-02-09  Per Arne Vollan  
+
 Unreviewed 32-bit build fix after .
 
 * WebView/WebWindowAnimation.mm:


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h (228327 => 228328)

--- trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h	2018-02-09 18:31:29 UTC (rev 228327)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h	2018-02-09 18:40:08 UTC (rev 228328)
@@ -44,7 +44,7 @@
 @class WebWindowFadeAnimation;
 @class CALayer;
 
-WEBCORE_EXPORT @interface WebVideoFullscreenController : NSWindowController {
+@interface WebVideoFullscreenController : NSWindowController {
 @private
 RefPtr _videoElement; // (retain)
 id  _delegate; // (assign)


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm (228327 => 228328)

--- trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm	2018-02-09 18:31:29 UTC (rev 228327)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm	2018-02-09 18:40:08 UTC (rev 228328)
@@ -44,9 +44,6 @@
 #define QTHUDSlider getQTHUDSliderClass()
 #define QTHUDTimeline getQTHUDTimelineClass()
 
-
-namespace WebCore {
-
 enum class MediaUIControl {
 Timeline,
 Slider,
@@ -58,11 +55,9 @@
 VolumeDownButton,
 };
 
-}
-
-using WebCore::MediaUIControl;
 using WebCore::HTMLVideoElement;
 using WebCore::narrowPrecisionToFloat;
+
 @interface WebVideoFullscreenHUDWindowController (Private) 
 
 - (void)updateTime;


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.h (228327 => 228328)

--- trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.h	2018-02-09 18:31:29 UTC (rev 228327)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.h	2018-02-09 18:40:08 UTC (rev 228328)
@@ -25,7 +25,7 @@
 
 #import 
 
-WEBCORE_EXPORT @interface WebWindowScaleAnimation : NSAnimation {
+@interface WebWindowScaleAnimation : NSAnimation {
 @private
 NSRect _initialFrame, _finalFrame, _realFrame;
 NSWindow *_window; // (assign)
@@ -43,7 +43,7 @@
 @end
 
 
-WEBCORE_EXPORT @interface WebWindowFadeAnimation : NSAnimation {
+@interface WebWindowFadeAnimation : NSAnimation {
 @private
 CGFloat _initialAlpha, _finalAlpha;
 NSWindow *_window; // (assign)


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.mm (228327 => 228328)

--- trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.mm	2018-02-09 18:31:29 UTC (rev 228327)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebWindowAnimation.mm	2018-02-09 18:40:08 UTC (rev 228328)
@@ -32,8 +32,6 @@
 #import 
 #import 
 
-namespace WebCore {
-
 static const CGFloat slowMotionFactor = 10;
 
 static NSTimeInterval WebWindowAnimationDurationFromDuration(NSTimeInterval duration)
@@ -58,12 +56,8 @@
 return deltaX * deltaX + deltaY * deltaY;
 }
 
-}
+using WebCore::narrowPrecisionToFloat;

[webkit-changes] [228329] trunk/LayoutTests

[ryanhaddad]

Title: [228329] trunk/LayoutTests








Revision 228329
Author ryanhad...@apple.com
Date 2018-02-09 10:47:37 -0800 (Fri, 09 Feb 2018)


Log Message
Update TestExpectations for fast/forms/textarea/textarea-state-restore.html
https://bugs.webkit.org/show_bug.cgi?id=90980

Unreviewed test gardening.

* TestExpectations:
* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (228328 => 228329)

--- trunk/LayoutTests/ChangeLog	2018-02-09 18:40:08 UTC (rev 228328)
+++ trunk/LayoutTests/ChangeLog	2018-02-09 18:47:37 UTC (rev 228329)
@@ -1,3 +1,13 @@
+2018-02-09  Ryan Haddad  
+
+Update TestExpectations for fast/forms/textarea/textarea-state-restore.html
+https://bugs.webkit.org/show_bug.cgi?id=90980
+
+Unreviewed test gardening.
+
+* TestExpectations:
+* platform/wk2/TestExpectations:
+
 2018-02-09  Philippe Normand  
 
 [GStreamer][WebAudio] Winamp2-js woes


Modified: trunk/LayoutTests/TestExpectations (228328 => 228329)

--- trunk/LayoutTests/TestExpectations	2018-02-09 18:40:08 UTC (rev 228328)
+++ trunk/LayoutTests/TestExpectations	2018-02-09 18:47:37 UTC (rev 228329)
@@ -1702,3 +1702,4 @@
 
 webkit.org/b/182311 imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html [ Skip ]
 
+webkit.org/b/90980 fast/forms/textarea/textarea-state-restore.html [ Pass Timeout ]


Modified: trunk/LayoutTests/platform/wk2/TestExpectations (228328 => 228329)

--- trunk/LayoutTests/platform/wk2/TestExpectations	2018-02-09 18:40:08 UTC (rev 228328)
+++ trunk/LayoutTests/platform/wk2/TestExpectations	2018-02-09 18:47:37 UTC (rev 228329)
@@ -170,8 +170,6 @@
 
 webkit.org/b/141122 editing/selection/programmatic-selection-on-mac-is-directionless.html [ Pass Failure ]
 
-webkit.org/b/90980 fast/forms/textarea/textarea-state-restore.html [ Pass Timeout ]
-
 webkit.org/b/149087 http/tests/cache/disk-cache/disk-cache-cancel.html [ Pass Failure ]
 
 http/tests/appcache/decide-navigation-policy-after-delay.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228330] trunk

[ross . kirsling]

Title: [228330] trunk








Revision 228330
Author ross.kirsl...@sony.com
Date 2018-02-09 10:59:54 -0800 (Fri, 09 Feb 2018)


Log Message
Use REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR on any non-Windows port.
https://bugs.webkit.org/show_bug.cgi?id=182623

Reviewed by Alex Christensen.

PerformanceTests:

* StitchMarker/wtf/Platform.h:
Simplify #if.

Source/WTF:

* wtf/Platform.h:
Simplify #if.

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/StitchMarker/wtf/Platform.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h




Diff

Modified: trunk/PerformanceTests/ChangeLog (228329 => 228330)

--- trunk/PerformanceTests/ChangeLog	2018-02-09 18:47:37 UTC (rev 228329)
+++ trunk/PerformanceTests/ChangeLog	2018-02-09 18:59:54 UTC (rev 228330)
@@ -1,3 +1,13 @@
+2018-02-09  Ross Kirsling  
+
+Use REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR on any non-Windows port.
+https://bugs.webkit.org/show_bug.cgi?id=182623
+
+Reviewed by Alex Christensen.
+
+* StitchMarker/wtf/Platform.h:
+Simplify #if.
+
 2018-02-01  Antti Koivisto  
 
 StyleBench: Attribute selectors and other improvements


Modified: trunk/PerformanceTests/StitchMarker/wtf/Platform.h (228329 => 228330)

--- trunk/PerformanceTests/StitchMarker/wtf/Platform.h	2018-02-09 18:47:37 UTC (rev 228329)
+++ trunk/PerformanceTests/StitchMarker/wtf/Platform.h	2018-02-09 18:59:54 UTC (rev 228330)
@@ -1102,7 +1102,7 @@
 #define USE_VIDEOTOOLBOX 1
 #endif
 
-#if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE)
+#if !PLATFORM(WIN)
 #define USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1
 #endif
 


Modified: trunk/Source/WTF/ChangeLog (228329 => 228330)

--- trunk/Source/WTF/ChangeLog	2018-02-09 18:47:37 UTC (rev 228329)
+++ trunk/Source/WTF/ChangeLog	2018-02-09 18:59:54 UTC (rev 228330)
@@ -1,3 +1,13 @@
+2018-02-09  Ross Kirsling  
+
+Use REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR on any non-Windows port.
+https://bugs.webkit.org/show_bug.cgi?id=182623
+
+Reviewed by Alex Christensen.
+
+* wtf/Platform.h:
+Simplify #if.
+
 2018-02-08  Filip Pizlo  
 
 Experiment with alternative implementation of memcpy/memset


Modified: trunk/Source/WTF/wtf/Platform.h (228329 => 228330)

--- trunk/Source/WTF/wtf/Platform.h	2018-02-09 18:47:37 UTC (rev 228329)
+++ trunk/Source/WTF/wtf/Platform.h	2018-02-09 18:59:54 UTC (rev 228330)
@@ -1128,7 +1128,7 @@
 #define HAVE_AVFOUNDATION_LOADER_DELEGATE 1
 #endif
 
-#if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE)
+#if !PLATFORM(WIN)
 #define USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR 1
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228331] trunk

[aestes]

Title: [228331] trunk








Revision 228331
Author aes...@apple.com
Date 2018-02-09 11:07:28 -0800 (Fri, 09 Feb 2018)


Log Message
[Payment Request] Crash in PaymentRequest::canMakePayment() when Apple Pay payment method data is missing required fields
https://bugs.webkit.org/show_bug.cgi?id=182631

Reviewed by Mark Lam.

Source/WebCore:

PaymentRequest::canMakePayment() needs to parse each payment method's serialized data to
determine if it is a supported payment method. If parsing fails by raising an exception, we
intend to skip over that payment method and try the next one. If all payment method data
fail to parse, we resolve the returned promise with false. At no point do we intend to
propagate the parsing exception up to the calling script, however.

Even though we intend to swallow any exceptions from parsing, we failed to clear the
_javascript_ VM's exception state. The next time WebCore tries to execute _javascript_, a
release assertion is raised due to seeing an unexpected exception in the VM.

Fix this by using a CatchScope in PaymentRequest::canMakePayment(), and calling
CatchScope::clearException() in the places we intend to swallow exceptions.

Added a test case to http/tests/paymentrequest/payment-request-canmakepayment-method.https.html.

* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::canMakePayment):

LayoutTests:

* http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt:
* http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt
trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (228330 => 228331)

--- trunk/LayoutTests/ChangeLog	2018-02-09 18:59:54 UTC (rev 228330)
+++ trunk/LayoutTests/ChangeLog	2018-02-09 19:07:28 UTC (rev 228331)
@@ -1,3 +1,13 @@
+2018-02-09  Andy Estes  
+
+[Payment Request] Crash in PaymentRequest::canMakePayment() when Apple Pay payment method data is missing required fields
+https://bugs.webkit.org/show_bug.cgi?id=182631
+
+Reviewed by Mark Lam.
+
+* http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt:
+* http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
+
 2018-02-09  Ryan Haddad  
 
 Update TestExpectations for fast/forms/textarea/textarea-state-restore.html


Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt (228330 => 228331)

--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt	2018-02-09 18:59:54 UTC (rev 228330)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt	2018-02-09 19:07:28 UTC (rev 228331)
@@ -3,6 +3,7 @@
 PASS If request.[[state]] is "interactive", then return a promise rejected with an "InvalidStateError" DOMException. 
 PASS If request.[[state]] is "closed", then return a promise rejected with an "InvalidStateError" DOMException. 
 PASS If payment method identifier and serialized parts are supported, resolve promise with true. 
+PASS If a payment method identifier is supported but its serialized parts are not, resolve promise with false. 
 PASS If payment method identifier is unknown, resolve promise with false. 
 PASS Optionally, at the user agent's discretion, return a promise rejected with a "NotAllowedError" DOMException. 
 


Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html (228330 => 228331)

--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html	2018-02-09 18:59:54 UTC (rev 228330)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html	2018-02-09 19:07:28 UTC (rev 228331)
@@ -10,7 +10,7 @@
 

[webkit-changes] [228324] trunk/Source/bmalloc

[clopez]

Title: [228324] trunk/Source/bmalloc








Revision 228324
Author clo...@igalia.com
Date 2018-02-09 10:03:02 -0800 (Fri, 09 Feb 2018)


Log Message
Improve of string.h include after r228317.
https://bugs.webkit.org/show_bug.cgi?id=182642

Reviewed by Mark Lam.

* bmalloc/Algorithm.h: Avoid an architecture-specific #include.

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Algorithm.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (228323 => 228324)

--- trunk/Source/bmalloc/ChangeLog	2018-02-09 17:32:57 UTC (rev 228323)
+++ trunk/Source/bmalloc/ChangeLog	2018-02-09 18:03:02 UTC (rev 228324)
@@ -1,5 +1,14 @@
 2018-02-09  Carlos Alberto Lopez Perez  
 
+Improve of string.h include after r228317.
+https://bugs.webkit.org/show_bug.cgi?id=182642
+
+Reviewed by Mark Lam.
+
+* bmalloc/Algorithm.h: Avoid an architecture-specific #include.
+
+2018-02-09  Carlos Alberto Lopez Perez  
+
 Fix build for !BCPU(X86_64) after r228306
 https://bugs.webkit.org/show_bug.cgi?id=182563
 


Modified: trunk/Source/bmalloc/bmalloc/Algorithm.h (228323 => 228324)

--- trunk/Source/bmalloc/bmalloc/Algorithm.h	2018-02-09 17:32:57 UTC (rev 228323)
+++ trunk/Source/bmalloc/bmalloc/Algorithm.h	2018-02-09 18:03:02 UTC (rev 228324)
@@ -31,13 +31,10 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
-#if !BCPU(X86_64)
-#include 
-#endif
-
 namespace bmalloc {
 
 // Versions of min and max that are compatible with compile-time constants.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228325] trunk/Source/WebCore

[commit-queue]

Title: [228325] trunk/Source/WebCore








Revision 228325
Author commit-qu...@webkit.org
Date 2018-02-09 10:10:53 -0800 (Fri, 09 Feb 2018)


Log Message
Make CoreAudioCaptureSource error logging be release logging
https://bugs.webkit.org/show_bug.cgi?id=182614

Patch by Youenn Fablet  on 2018-02-09
Reviewed by Eric Carlson.

No change of behavior.

* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioSharedUnit::addEchoCancellationSource):
(WebCore::CoreAudioSharedUnit::setupAudioUnit):
(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):
(WebCore::CoreAudioSharedUnit::configureSpeakerProc):
(WebCore::CoreAudioSharedUnit::checkTimestamps):
(WebCore::CoreAudioSharedUnit::provideSpeakerData):
(WebCore::CoreAudioSharedUnit::processMicrophoneSamples):
(WebCore::CoreAudioSharedUnit::cleanupAudioUnit):
(WebCore::CoreAudioSharedUnit::reconfigureAudioUnit):
(WebCore::CoreAudioSharedUnit::startInternal):
(WebCore::CoreAudioSharedUnit::verifyIsCapturing):
(WebCore::CoreAudioSharedUnit::stopInternal):
(WebCore::CoreAudioSharedUnit::defaultInputDevice):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (228324 => 228325)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 18:03:02 UTC (rev 228324)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 18:10:53 UTC (rev 228325)
@@ -1,3 +1,27 @@
+2018-02-09  Youenn Fablet  
+
+Make CoreAudioCaptureSource error logging be release logging
+https://bugs.webkit.org/show_bug.cgi?id=182614
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioSharedUnit::addEchoCancellationSource):
+(WebCore::CoreAudioSharedUnit::setupAudioUnit):
+(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):
+(WebCore::CoreAudioSharedUnit::configureSpeakerProc):
+(WebCore::CoreAudioSharedUnit::checkTimestamps):
+(WebCore::CoreAudioSharedUnit::provideSpeakerData):
+(WebCore::CoreAudioSharedUnit::processMicrophoneSamples):
+(WebCore::CoreAudioSharedUnit::cleanupAudioUnit):
+(WebCore::CoreAudioSharedUnit::reconfigureAudioUnit):
+(WebCore::CoreAudioSharedUnit::startInternal):
+(WebCore::CoreAudioSharedUnit::verifyIsCapturing):
+(WebCore::CoreAudioSharedUnit::stopInternal):
+(WebCore::CoreAudioSharedUnit::defaultInputDevice):
+
 2018-02-09  Carlos Garcia Campos  
 
 Add a way to check if a host is an IP address


Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (228324 => 228325)

--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2018-02-09 18:03:02 UTC (rev 228324)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2018-02-09 18:10:53 UTC (rev 228325)
@@ -198,7 +198,7 @@
 void CoreAudioSharedUnit::addEchoCancellationSource(AudioSampleDataSource& source)
 {
 if (!source.setOutputFormat(m_speakerProcFormat)) {
-LOG(Media, "CoreAudioSharedUnit::addEchoCancellationSource: source %p configureOutput failed", );
+RELEASE_LOG_ERROR(Media, "CoreAudioSharedUnit::addEchoCancellationSource: source %p configureOutput failed", );
 return;
 }
 
@@ -232,7 +232,7 @@
 AudioComponent ioComponent = AudioComponentFindNext(nullptr, );
 ASSERT(ioComponent);
 if (!ioComponent) {
-LOG(Media, "CoreAudioCaptureSource::setupAudioUnit(%p) unable to find vpio unit component", this);
+RELEASE_LOG_ERROR(Media, "CoreAudioCaptureSource::setupAudioUnit(%p) unable to find vpio unit component", this);
 return -1;
 }
 
@@ -242,13 +242,13 @@
 if (name) {
 m_ioUnitName = name;
 CFRelease(name);
-LOG(Media, "CoreAudioCaptureSource::setupAudioUnit(%p) created \"%s\" component", this, m_ioUnitName.utf8().data());
+RELEASE_LOG(Media, "CoreAudioCaptureSource::setupAudioUnit(%p) created \"%s\" component", this, m_ioUnitName.utf8().data());
 }
 #endif
 
 auto err = AudioComponentInstanceNew(ioComponent, _ioUnit);
 if (err) {
-LOG(Media, "CoreAudioCaptureSource::setupAudioUnit(%p) unable to open vpio unit, error %d (%.4s)", this, (int)err, (char*));
+RELEASE_LOG_ERROR(Media, "CoreAudioCaptureSource::setupAudioUnit(%p) unable to open vpio unit, error %d (%.4s)", this, (int)err, (char*));
 return err;
 }
 
@@ -256,13 +256,13 @@
 uint32_t param = 0;
 err = AudioUnitSetProperty(m_ioUnit, kAUVoiceIOProperty_VoiceProcessingEnableAGC, kAudioUnitScope_Global, inputBus, , sizeof(param));
 if (err) {
-LOG(Media, "CoreAudioCaptureSource::setupAudioUnit(%p) unable to set vpio automatic gain control, error %d (%.4s)", this, (int)err, (char*));
+

[webkit-changes] [228332] tags/Safari-606.1.4.1/

[jmarcell]

Title: [228332] tags/Safari-606.1.4.1/








Revision 228332
Author jmarc...@apple.com
Date 2018-02-09 11:09:05 -0800 (Fri, 09 Feb 2018)


Log Message
New tag.

Added Paths

tags/Safari-606.1.4.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228335] tags/Safari-606.1.4.1/Source

[jmarcell]

Title: [228335] tags/Safari-606.1.4.1/Source








Revision 228335
Author jmarc...@apple.com
Date 2018-02-09 12:06:02 -0800 (Fri, 09 Feb 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-606.1.4.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-606.1.4.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-606.1.4.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-606.1.4.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-606.1.4.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-606.1.4.1/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-606.1.4.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-606.1.4.1/Source/_javascript_Core/Configurations/Version.xcconfig (228334 => 228335)

--- tags/Safari-606.1.4.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-02-09 19:19:41 UTC (rev 228334)
+++ tags/Safari-606.1.4.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-02-09 20:06:02 UTC (rev 228335)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.4.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (228334 => 228335)

--- tags/Safari-606.1.4.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-02-09 19:19:41 UTC (rev 228334)
+++ tags/Safari-606.1.4.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-02-09 20:06:02 UTC (rev 228335)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.4.1/Source/WebCore/Configurations/Version.xcconfig (228334 => 228335)

--- tags/Safari-606.1.4.1/Source/WebCore/Configurations/Version.xcconfig	2018-02-09 19:19:41 UTC (rev 228334)
+++ tags/Safari-606.1.4.1/Source/WebCore/Configurations/Version.xcconfig	2018-02-09 20:06:02 UTC (rev 228335)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.4.1/Source/WebCore/PAL/Configurations/Version.xcconfig (228334 => 228335)

--- tags/Safari-606.1.4.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-02-09 19:19:41 UTC (rev 228334)
+++ tags/Safari-606.1.4.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-02-09 20:06:02 UTC (rev 228335)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.4.1/Source/WebInspectorUI/Configurations/Version.xcconfig (228334 => 228335)

--- tags/Safari-606.1.4.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-02-09 19:19:41 UTC (rev 228334)
+++ tags/Safari-606.1.4.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-02-09 20:06:02 UTC (rev 228335)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 4;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-606.1.4.1/Source/WebKit/Configurations/Version.xcconfig (228334 => 228335)

--- tags/Safari-606.1.4.1/Source/WebKit/Configurations/Version.xcconfig	2018-02-09 19:19:41 UTC (rev 228334)
+++ tags/Safari-606.1.4.1/Source/WebKit/Configurations/Version.xcconfig	2018-02-09 20:06:02 UTC (rev 228335)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 

[webkit-changes] [228327] trunk/Source/WebCore

[zalan]

Title: [228327] trunk/Source/WebCore








Revision 228327
Author za...@apple.com
Date 2018-02-09 10:31:29 -0800 (Fri, 09 Feb 2018)


Log Message
[RenderTreeBuilder] Move multicolumn descendant/sibling removal logic to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=182628


Reviewed by Antti Koivisto.

No change in functionality

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::takeChild):
* rendering/RenderFragmentedFlow.h:
* rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::handleSpannerRemoval): Deleted.
(WebCore::RenderMultiColumnFlow::fragmentedFlowRelativeWillBeRemoved): Deleted.
* rendering/RenderMultiColumnFlow.h:
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::multiColumnRelativeWillBeRemoved):
* rendering/updating/RenderTreeBuilder.h:
* rendering/updating/RenderTreeBuilderMultiColumn.cpp:
(WebCore::RenderTreeBuilder::MultiColumn::handleSpannerRemoval):
(WebCore::RenderTreeBuilder::MultiColumn::multiColumnRelativeWillBeRemoved):
* rendering/updating/RenderTreeBuilderMultiColumn.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderFragmentedFlow.h
trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp
trunk/Source/WebCore/rendering/RenderMultiColumnFlow.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (228326 => 228327)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 18:27:13 UTC (rev 228326)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 18:31:29 UTC (rev 228327)
@@ -1,3 +1,28 @@
+2018-02-09  Zalan Bujtas  
+
+[RenderTreeBuilder] Move multicolumn descendant/sibling removal logic to RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=182628
+
+
+Reviewed by Antti Koivisto.
+
+No change in functionality
+
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::takeChild):
+* rendering/RenderFragmentedFlow.h:
+* rendering/RenderMultiColumnFlow.cpp:
+(WebCore::RenderMultiColumnFlow::handleSpannerRemoval): Deleted.
+(WebCore::RenderMultiColumnFlow::fragmentedFlowRelativeWillBeRemoved): Deleted.
+* rendering/RenderMultiColumnFlow.h:
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::multiColumnRelativeWillBeRemoved):
+* rendering/updating/RenderTreeBuilder.h:
+* rendering/updating/RenderTreeBuilderMultiColumn.cpp:
+(WebCore::RenderTreeBuilder::MultiColumn::handleSpannerRemoval):
+(WebCore::RenderTreeBuilder::MultiColumn::multiColumnRelativeWillBeRemoved):
+* rendering/updating/RenderTreeBuilderMultiColumn.h:
+
 2018-02-09  Youenn Fablet  
 
 Add support for cache storage of blob response


Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (228326 => 228327)

--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2018-02-09 18:27:13 UTC (rev 228326)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2018-02-09 18:31:29 UTC (rev 228327)
@@ -3852,9 +3852,9 @@
 RenderPtr RenderBlockFlow::takeChild(RenderTreeBuilder& builder, RenderObject& oldChild)
 {
 if (!renderTreeBeingDestroyed()) {
-RenderFragmentedFlow* fragmentedFlow = multiColumnFlow();
+auto* fragmentedFlow = multiColumnFlow();
 if (fragmentedFlow && fragmentedFlow != )
-fragmentedFlow->fragmentedFlowRelativeWillBeRemoved(oldChild);
+builder.multiColumnRelativeWillBeRemoved(*fragmentedFlow, oldChild);
 }
 return RenderBlock::takeChild(builder, oldChild);
 }


Modified: trunk/Source/WebCore/rendering/RenderFragmentedFlow.h (228326 => 228327)

--- trunk/Source/WebCore/rendering/RenderFragmentedFlow.h	2018-02-09 18:27:13 UTC (rev 228326)
+++ trunk/Source/WebCore/rendering/RenderFragmentedFlow.h	2018-02-09 18:31:29 UTC (rev 228327)
@@ -86,8 +86,6 @@
 
 virtual bool singleFragmentHasUniformLogicalHeight() const { return true; }
 
-// Called when a sibling or descendant of the flow thread is about to be removed.
-virtual void fragmentedFlowRelativeWillBeRemoved(RenderObject&) { }
 // Called when a descendant box's layout is finished and it has been positioned within its container.
 virtual void fragmentedFlowDescendantBoxLaidOut(RenderBox*) { }
 


Modified: trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp (228326 => 228327)

--- trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp	2018-02-09 18:27:13 UTC (rev 228326)
+++ trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp	2018-02-09 18:31:29 UTC (rev 228327)
@@ -165,45 +165,6 @@
 return createRenderer(*this, WTFMove(style));
 }
 
-void 

[webkit-changes] [228334] trunk/Source/WebCore

[bfulgham]

Title: [228334] trunk/Source/WebCore








Revision 228334
Author bfulg...@apple.com
Date 2018-02-09 11:19:41 -0800 (Fri, 09 Feb 2018)


Log Message
[macOS, iOS] Expose OS marketing version in UserAgent
https://bugs.webkit.org/show_bug.cgi?id=182629


Reviewed by Daniel Bates.

Revert back to dynamically reading the operating system marketing version
rather than using a hard-coded version.

* page/cocoa/UserAgent.mm:
(WebCore::systemMarketingVersionForUserAgentString):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/cocoa/UserAgent.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (228333 => 228334)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 19:11:32 UTC (rev 228333)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 19:19:41 UTC (rev 228334)
@@ -1,3 +1,17 @@
+2018-02-09  Brent Fulgham  
+
+[macOS, iOS] Expose OS marketing version in UserAgent
+https://bugs.webkit.org/show_bug.cgi?id=182629
+
+
+Reviewed by Daniel Bates.
+
+Revert back to dynamically reading the operating system marketing version
+rather than using a hard-coded version.
+
+* page/cocoa/UserAgent.mm:
+(WebCore::systemMarketingVersionForUserAgentString):
+
 2018-02-08  Antoine Quint  
 
 [Web Animations] Refactor AnimationEffect and KeyframeEffect into AnimationEffectReadOnly, KeyframeEffectReadOnly and KeyframeEffect


Modified: trunk/Source/WebCore/page/cocoa/UserAgent.mm (228333 => 228334)

--- trunk/Source/WebCore/page/cocoa/UserAgent.mm	2018-02-09 19:11:32 UTC (rev 228333)
+++ trunk/Source/WebCore/page/cocoa/UserAgent.mm	2018-02-09 19:19:41 UTC (rev 228334)
@@ -26,6 +26,8 @@
 #import "config.h"
 #import "UserAgent.h"
 
+#import "SystemVersion.h"
+
 namespace WebCore {
 
 String systemMarketingVersionForUserAgentString()
@@ -33,11 +35,7 @@
 // Use underscores instead of dots because when we first added the Mac OS X version to the user agent string
 // we were concerned about old DHTML libraries interpreting "4." as Netscape 4. That's no longer a concern for us
 // but we're sticking with the underscores for compatibility with the format used by older versions of Safari.
-#if PLATFORM(MAC)
-return ASCIILiteral("10_13_4");
-#else
-return ASCIILiteral("11_3");
-#endif
+return [systemMarketingVersion() stringByReplacingOccurrencesOfString:@"." withString:@"_"];
 }
 
 String userAgentBundleVersion()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228323] trunk

[commit-queue]

Title: [228323] trunk








Revision 228323
Author commit-qu...@webkit.org
Date 2018-02-09 09:32:57 -0800 (Fri, 09 Feb 2018)


Log Message
Add a way to check if a host is an IP address
https://bugs.webkit.org/show_bug.cgi?id=182427

Patch by Carlos Garcia Campos  on 2018-02-09
Reviewed by Alex Christensen.

Source/WebCore:

There are several places where this is needed. We currently just assume that any host ending in a digit is an IP
address, except in PublicSuffix where platform specific code is used. This patch adds URL::hostIsIPAddress()
platform specific implementations, falling back to current assumption if there isn't an implementation for the
platform.

* page/OriginAccessEntry.cpp:
(WebCore::OriginAccessEntry::OriginAccessEntry): Use URL::hostIsIPAddress().
* platform/URL.cpp:
(WebCore::URL::hostIsIPAddress): Fallback implementation.
* platform/URL.h:
* platform/mac/PublicSuffixMac.mm:
(WebCore::topPrivatelyControlledDomain): Use URL::hostIsIPAddress().
* platform/mac/URLMac.mm:
(WebCore::URL::hostIsIPAddress): Move implementation from PublicSuffixMac.mm.
* platform/network/curl/CookieUtil.cpp:
(WebCore::CookieUtil::isIPAddress): Use URL::hostIsIPAddress().
* platform/soup/URLSoup.cpp:
(WebCore::URL::hostIsIPAddress): Use g_hostname_is_ip_address().

Tools:

Add unit test for URL::hostIsIPAddress().

* TestWebKitAPI/Tests/WebCore/URL.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/OriginAccessEntry.cpp
trunk/Source/WebCore/platform/URL.cpp
trunk/Source/WebCore/platform/URL.h
trunk/Source/WebCore/platform/mac/PublicSuffixMac.mm
trunk/Source/WebCore/platform/mac/URLMac.mm
trunk/Source/WebCore/platform/network/curl/CookieUtil.cpp
trunk/Source/WebCore/platform/soup/URLSoup.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (228322 => 228323)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 17:26:47 UTC (rev 228322)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 17:32:57 UTC (rev 228323)
@@ -1,3 +1,29 @@
+2018-02-09  Carlos Garcia Campos  
+
+Add a way to check if a host is an IP address
+https://bugs.webkit.org/show_bug.cgi?id=182427
+
+Reviewed by Alex Christensen.
+
+There are several places where this is needed. We currently just assume that any host ending in a digit is an IP
+address, except in PublicSuffix where platform specific code is used. This patch adds URL::hostIsIPAddress()
+platform specific implementations, falling back to current assumption if there isn't an implementation for the
+platform.
+
+* page/OriginAccessEntry.cpp:
+(WebCore::OriginAccessEntry::OriginAccessEntry): Use URL::hostIsIPAddress().
+* platform/URL.cpp:
+(WebCore::URL::hostIsIPAddress): Fallback implementation.
+* platform/URL.h:
+* platform/mac/PublicSuffixMac.mm:
+(WebCore::topPrivatelyControlledDomain): Use URL::hostIsIPAddress().
+* platform/mac/URLMac.mm:
+(WebCore::URL::hostIsIPAddress): Move implementation from PublicSuffixMac.mm.
+* platform/network/curl/CookieUtil.cpp:
+(WebCore::CookieUtil::isIPAddress): Use URL::hostIsIPAddress().
+* platform/soup/URLSoup.cpp:
+(WebCore::URL::hostIsIPAddress): Use g_hostname_is_ip_address().
+
 2018-02-08  Philippe Normand  
 
 [GStreamer][WebAudio] Winamp2-js woes


Modified: trunk/Source/WebCore/page/OriginAccessEntry.cpp (228322 => 228323)

--- trunk/Source/WebCore/page/OriginAccessEntry.cpp	2018-02-09 17:26:47 UTC (rev 228322)
+++ trunk/Source/WebCore/page/OriginAccessEntry.cpp	2018-02-09 17:32:57 UTC (rev 228323)
@@ -40,11 +40,9 @@
 , m_host(host.convertToASCIILowercase())
 , m_subdomainSettings(subdomainSetting)
 , m_ipAddressSettings(ipAddressSetting)
+, m_hostIsIPAddress(URL::hostIsIPAddress(m_host))
 {
 ASSERT(subdomainSetting == AllowSubdomains || subdomainSetting == DisallowSubdomains);
-
-// Assume that any host that ends with a digit is trying to be an IP address.
-m_hostIsIPAddress = !m_host.isEmpty() && isASCIIDigit(m_host[m_host.length() - 1]);
 }
 
 bool OriginAccessEntry::matchesOrigin(const SecurityOrigin& origin) const
@@ -69,7 +67,7 @@
 
 // IP addresses are not domains: https://url.spec.whatwg.org/#concept-domain
 // Don't try to do subdomain matching on IP addresses.
-if (m_hostIsIPAddress && m_ipAddressSettings == TreatIPAddressAsIPAddress)
+if (m_ipAddressSettings == TreatIPAddressAsIPAddress && (m_hostIsIPAddress || URL::hostIsIPAddress(origin.host(
 return false;
 
 // Match subdomains.


Modified: trunk/Source/WebCore/platform/URL.cpp (228322 => 228323)

--- trunk/Source/WebCore/platform/URL.cpp	2018-02-09 17:26:47 UTC (rev 228322)
+++ trunk/Source/WebCore/platform/URL.cpp	2018-02-09 17:32:57 UTC (rev 228323)
@@ -1035,4 +1035,12 

[webkit-changes] [228319] trunk

[jfernandez]

Title: [228319] trunk








Revision 228319
Author jfernan...@igalia.com
Date 2018-02-09 06:57:12 -0800 (Fri, 09 Feb 2018)


Log Message
[css-align] Implement the new behavior of 'legacy' for justify-items
https://bugs.webkit.org/show_bug.cgi?id=172712

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002-expected.txt:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html:
* web-platform-tests/css/css-align/default-alignment/parse-justify-items-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt:
* web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html:

Source/WebCore:

The syntax of the 'justify-items' property accepts a new 'legacy' value,
replacing the 'auto' value which is now parsed as invalid.

https://github.com/w3c/csswg-drafts/issues/1318

This change affects also to the 'place-items' shorthand, which doesn't
accept 'auto' and, for the time being, neither 'legacy'.

Since the new value 'legacy' is also the default value, I don't expect
this change to break content of sites currently using the 'justify-items'
property.

No new tests, rebaselined existing test.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForItemPositionWithOverflowAlignment):
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ItemPosition const):
* css/CSSProperties.json:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* css/parser/CSSPropertyParser.cpp:
(WebCore::isAuto):
(WebCore::isNormalOrStretch):
(WebCore::consumeSelfPositionOverflowPosition):
(WebCore::consumeJustifyItems):
(WebCore::consumeSimplifiedDefaultPosition):
(WebCore::consumeSimplifiedSelfPosition):
(WebCore::CSSPropertyParser::consumePlaceItemsShorthand):
(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
* rendering/style/RenderStyle.cpp:
(WebCore::resolvedSelfAlignment):
(WebCore::RenderStyle::resolvedJustifyItems const):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::initialJustifyItems):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

LayoutTests:

Rebaselined Default Alignment related tests because of the new 'legacy' value.

* css3/parse-alignment-of-root-elements.html:
* css3/parse-place-items.html:
* fast/css/parse-justify-items.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/parse-alignment-of-root-elements-expected.txt
trunk/LayoutTests/css3/parse-alignment-of-root-elements.html
trunk/LayoutTests/css3/parse-place-items-expected.txt
trunk/LayoutTests/css3/parse-place-items.html
trunk/LayoutTests/fast/css/parse-justify-items-expected.txt
trunk/LayoutTests/fast/css/parse-justify-items.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-002-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-004-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp


Added Paths

[webkit-changes] [228336] trunk

[mattbaker]

Title: [228336] trunk








Revision 228336
Author mattba...@apple.com
Date 2018-02-09 12:40:10 -0800 (Fri, 09 Feb 2018)


Log Message
Web Inspector: Object.shallowEqual always fails when comparing array property values
https://bugs.webkit.org/show_bug.cgi?id=182634


Reviewed by Devin Rousso.

Source/WebInspectorUI:

Object.shallowEqual should use Array.shallowEqual when comparing property
values, since strictly comparing objects/arrays is only true if both
operands reference the same Object.

* UserInterface/Base/Utilities.js:
(value):

LayoutTests:

* inspector/unit-tests/object-utilities-expected.txt:
* inspector/unit-tests/object-utilities.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/unit-tests/object-utilities-expected.txt
trunk/LayoutTests/inspector/unit-tests/object-utilities.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js




Diff

Modified: trunk/LayoutTests/ChangeLog (228335 => 228336)

--- trunk/LayoutTests/ChangeLog	2018-02-09 20:06:02 UTC (rev 228335)
+++ trunk/LayoutTests/ChangeLog	2018-02-09 20:40:10 UTC (rev 228336)
@@ -1,3 +1,14 @@
+2018-02-09  Matt Baker  
+
+Web Inspector: Object.shallowEqual always fails when comparing array property values
+https://bugs.webkit.org/show_bug.cgi?id=182634
+
+
+Reviewed by Devin Rousso.
+
+* inspector/unit-tests/object-utilities-expected.txt:
+* inspector/unit-tests/object-utilities.html:
+
 2018-02-09  Andy Estes  
 
 [Payment Request] Crash in PaymentRequest::canMakePayment() when Apple Pay payment method data is missing required fields


Modified: trunk/LayoutTests/inspector/unit-tests/object-utilities-expected.txt (228335 => 228336)

--- trunk/LayoutTests/inspector/unit-tests/object-utilities-expected.txt	2018-02-09 20:06:02 UTC (rev 228335)
+++ trunk/LayoutTests/inspector/unit-tests/object-utilities-expected.txt	2018-02-09 20:40:10 UTC (rev 228336)
@@ -9,6 +9,11 @@
 PASS: shallowEqual of equal objects should be true.
 PASS: shallowEqual of unequal objects should be false.
 PASS: shallowEqual of unequal objects should be false.
+PASS: shallowEqual of objects with similar arrays at the same key should be true.
+PASS: shallowEqual of objects with similar arrays at the same key should be true.
+PASS: shallowEqual of objects with similar arrays at the same key should be true.
+PASS: shallowEqual of objects with dissimilar arrays at the same key should be false.
+PASS: shallowEqual of objects with dissimilar arrays at the same key should be false.
 PASS: shallowEqual of an object and null should be false.
 PASS: shallowEqual of an object and non-object should be false.
 PASS: shallowEqual of a non-object with itself should be false.


Modified: trunk/LayoutTests/inspector/unit-tests/object-utilities.html (228335 => 228336)

--- trunk/LayoutTests/inspector/unit-tests/object-utilities.html	2018-02-09 20:06:02 UTC (rev 228335)
+++ trunk/LayoutTests/inspector/unit-tests/object-utilities.html	2018-02-09 20:40:10 UTC (rev 228336)
@@ -26,6 +26,13 @@
 InspectorTest.expectThat(!Object.shallowEqual(obj1, obj3), "shallowEqual of unequal objects should be false.");
 InspectorTest.expectThat(!Object.shallowEqual(obj3, obj1), "shallowEqual of unequal objects should be false.");
 
+InspectorTest.expectThat(Object.shallowEqual({x: []}, {x: []}), "shallowEqual of objects with similar arrays at the same key should be true.");
+InspectorTest.expectThat(Object.shallowEqual({x: new Array}, {x: new Array}), "shallowEqual of objects with similar arrays at the same key should be true.");
+InspectorTest.expectThat(Object.shallowEqual({x: [1]}, {x: [1]}), "shallowEqual of objects with similar arrays at the same key should be true.");
+
+InspectorTest.expectThat(!Object.shallowEqual({x: [1]}, {x: []}), "shallowEqual of objects with dissimilar arrays at the same key should be false.");
+InspectorTest.expectThat(!Object.shallowEqual({x: new Array(1)}, {x: new Array}), "shallowEqual of objects with dissimilar arrays at the same key should be false.");
+
 InspectorTest.expectThat(!Object.shallowEqual({}, null), "shallowEqual of an object and null should be false.");
 InspectorTest.expectThat(!Object.shallowEqual({}, 1.23), "shallowEqual of an object and non-object should be false.");
 


Modified: trunk/Source/WebInspectorUI/ChangeLog (228335 => 228336)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-02-09 20:06:02 UTC (rev 228335)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-02-09 20:40:10 UTC (rev 228336)
@@ -1,3 +1,18 @@
+2018-02-09  Matt Baker  
+
+Web Inspector: Object.shallowEqual always fails when comparing array property values
+https://bugs.webkit.org/show_bug.cgi?id=182634
+
+
+Reviewed by Devin Rousso.
+
+

[webkit-changes] [228339] trunk/Source/WebCore

[zalan]

Title: [228339] trunk/Source/WebCore








Revision 228339
Author za...@apple.com
Date 2018-02-09 15:23:02 -0800 (Fri, 09 Feb 2018)


Log Message
[RenderTreeBuilder] Move RenderRubyAsInline/AsBlock::takeChild mutation to a RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=182651


Reviewed by Antti Koivisto.

No change in functionality.

* rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::takeChild):
(WebCore::RenderRubyAsBlock::takeChild):
(WebCore::isAnonymousRubyInlineBlock): Deleted.
(WebCore::isRubyChildForNormalRemoval): Deleted.
(WebCore::findRubyRunParent): Deleted.
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::takeChildFromRenderRubyAsInline):
(WebCore::RenderTreeBuilder::takeChildFromRenderRubyAsBlock):
* rendering/updating/RenderTreeBuilder.h:
* rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::findRubyRunParent):
(WebCore::RenderTreeBuilder::Ruby::takeChild):
* rendering/updating/RenderTreeBuilderRuby.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderRuby.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (228338 => 228339)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 22:13:00 UTC (rev 228338)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 23:23:02 UTC (rev 228339)
@@ -1,3 +1,28 @@
+2018-02-09  Zalan Bujtas  
+
+[RenderTreeBuilder] Move RenderRubyAsInline/AsBlock::takeChild mutation to a RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=182651
+
+
+Reviewed by Antti Koivisto.
+
+No change in functionality.
+
+* rendering/RenderRuby.cpp:
+(WebCore::RenderRubyAsInline::takeChild):
+(WebCore::RenderRubyAsBlock::takeChild):
+(WebCore::isAnonymousRubyInlineBlock): Deleted.
+(WebCore::isRubyChildForNormalRemoval): Deleted.
+(WebCore::findRubyRunParent): Deleted.
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::takeChildFromRenderRubyAsInline):
+(WebCore::RenderTreeBuilder::takeChildFromRenderRubyAsBlock):
+* rendering/updating/RenderTreeBuilder.h:
+* rendering/updating/RenderTreeBuilderRuby.cpp:
+(WebCore::findRubyRunParent):
+(WebCore::RenderTreeBuilder::Ruby::takeChild):
+* rendering/updating/RenderTreeBuilderRuby.h:
+
 2018-02-09  Per Arne Vollan  
 
 Assert that NSApp is not running in the WebProcess.


Modified: trunk/Source/WebCore/rendering/RenderRuby.cpp (228338 => 228339)

--- trunk/Source/WebCore/rendering/RenderRuby.cpp	2018-02-09 22:13:00 UTC (rev 228338)
+++ trunk/Source/WebCore/rendering/RenderRuby.cpp	2018-02-09 23:23:02 UTC (rev 228339)
@@ -45,39 +45,6 @@
 WTF_MAKE_ISO_ALLOCATED_IMPL(RenderRubyAsInline);
 WTF_MAKE_ISO_ALLOCATED_IMPL(RenderRubyAsBlock);
 
-//=== generic helper functions to avoid excessive code duplication ===
-
-static inline bool isAnonymousRubyInlineBlock(const RenderObject* object)
-{
-ASSERT(!object
-|| !isRuby(object->parent())
-|| is(*object)
-|| (object->isInline() && (object->isBeforeContent() || object->isAfterContent()))
-|| (object->isAnonymous() && is(*object) && object->style().display() == INLINE_BLOCK));
-
-return object
-&& isRuby(object->parent())
-&& is(*object)
-&& !is(*object);
-}
-
-#ifndef ASSERT_DISABLED
-static inline bool isRubyChildForNormalRemoval(const RenderObject& object)
-{
-return object.isRubyRun()
-|| object.isBeforeContent()
-|| object.isAfterContent()
-|| object.isRenderMultiColumnFlow()
-|| object.isRenderMultiColumnSet()
-|| isAnonymousRubyInlineBlock();
-}
-#endif
-
-static inline RenderRubyRun& findRubyRunParent(RenderObject& child)
-{
-return *lineageOfType(child).first();
-}
-
 //=== ruby as inline object ===
 
 RenderRubyAsInline::RenderRubyAsInline(Element& element, RenderStyle&& style)
@@ -95,26 +62,7 @@
 
 RenderPtr RenderRubyAsInline::takeChild(RenderTreeBuilder& builder, RenderObject& child)
 {
-// If the child's parent is *this (must be a ruby run or generated content or anonymous block),
-// just use the normal remove method.
-if (child.parent() == this) {
-#ifndef ASSERT_DISABLED
-ASSERT(isRubyChildForNormalRemoval(child));
-#endif
-return RenderInline::takeChild(builder, child);
-}
-// If the child's parent is an anoymous block (must be generated :before/:after content)
-// just use the block's remove method.
-if (isAnonymousRubyInlineBlock(child.parent())) {
-ASSERT(child.isBeforeContent() || child.isAfterContent());
-auto& parent = *child.parent();
-auto takenChild = parent.takeChild(builder, 

[webkit-changes] [228337] trunk/Source/WebCore

[zalan]

Title: [228337] trunk/Source/WebCore








Revision 228337
Author za...@apple.com
Date 2018-02-09 12:50:58 -0800 (Fri, 09 Feb 2018)


Log Message
[RenderTreeBuilder] Introduce RenderTreeBuilder to willBeDestoryed/removeFromParentAndDestroy
https://bugs.webkit.org/show_bug.cgi?id=182635


Reviewed by Antti Koivisto.

This patch helps finding callsites where we don't have a RenderTreeBuilder instance.

No change in functionality.

* dom/Document.cpp:
(WebCore::Document::setFullScreenRenderer):
* dom/Document.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::takeChild):
* rendering/RenderBlock.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
* rendering/RenderBlockFlow.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations):
* rendering/RenderBoxModelObject.h:
* rendering/RenderButton.cpp:
(WebCore::RenderButton::setText):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::willBeDestroyed):
* rendering/RenderCounter.h:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::willBeDestroyed):
* rendering/RenderElement.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::willBeDestroyed):
* rendering/RenderEmbeddedObject.h:
* rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::willBeDestroyed):
* rendering/RenderFragmentedFlow.h:
* rendering/RenderFullScreen.cpp:
(WebCore::RenderFullScreen::willBeDestroyed):
(WebCore::RenderFullScreen::wrapNewRenderer):
(WebCore::RenderFullScreen::wrapExistingRenderer):
(WebCore::RenderFullScreen::unwrapRenderer):
* rendering/RenderFullScreen.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::willBeDestroyed):
* rendering/RenderImage.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
* rendering/RenderInline.h:
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::willBeDestroyed):
* rendering/RenderLayerModelObject.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::willBeDestroyed):
* rendering/RenderListBox.h:
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::willBeDestroyed):
* rendering/RenderListItem.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::willBeDestroyed):
* rendering/RenderListMarker.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::willBeDestroyed):
* rendering/RenderMenuList.h:
* rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::handleSpannerRemoval):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::removeFromParentAndDestroy):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::destroy):
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::willBeDestroyed):
* rendering/RenderReplaced.h:
* rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::takeChild):
(WebCore::RenderRubyAsBlock::takeChild):
* rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::willBeDestroyed):
* rendering/RenderSearchField.h:
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::willBeDestroyed):
* rendering/RenderSnapshottedPlugIn.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::willBeDestroyed):
* rendering/RenderText.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::willBeDestroyed):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::willBeDestroyed):
(WebCore::RenderTextFragment::setText):
* rendering/RenderTextFragment.h:
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::willBeDestroyed):
* rendering/RenderVideo.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::willBeDestroyed):
* rendering/RenderView.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::willBeDestroyed):
* rendering/RenderWidget.h:
* rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::willBeDestroyed):
* rendering/svg/RenderSVGBlock.h:
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::willBeDestroyed):
* rendering/svg/RenderSVGImage.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::willBeDestroyed):
* rendering/svg/RenderSVGInline.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::willBeDestroyed):
* rendering/svg/RenderSVGModelObject.h:
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::willBeDestroyed):
* rendering/svg/RenderSVGResourceContainer.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::willBeDestroyed):
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::willBeDestroyed):
* rendering/svg/RenderSVGText.h:
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::removeFromParentAndDestroyCleaningUpAnonymousWrappers):
* 

[webkit-changes] [228340] trunk

[wenson_hsieh]

Title: [228340] trunk








Revision 228340
Author wenson_hs...@apple.com
Date 2018-02-09 15:41:34 -0800 (Fri, 09 Feb 2018)


Log Message
Pasting from Excel no longer provides text/html data
https://bugs.webkit.org/show_bug.cgi?id=182636


Reviewed by Ryosuke Niwa.

Source/WebCore:

After r222656, we treat images on the pasteboard as files. However, we also have an existing policy which hides
text data ("text/uri-list", "text/html", "text/plain") from the page when files are present on the pasteboard.
When copying a table, Microsoft Excel writes a rendering of the table to the pasteboard as an image. This means
that we'll hide other data types (importantly, 'text/html') upon pasting, even though important clients (such as
Google Docs and Confluence) depend on the 'text/html' data in order to correctly handle the paste (rather than
paste as an image of a table).

To fix this, we add an exception to the DataTransfer.getData codepath when the pasteboard contains files.
Instead of always returning the empty string for text/html, we still allow pasteboard access, but only read
from a limited set of rich text types, i.e. web archive, RTF(D), and HTML markup. Importantly, this prevents
us from exposing any file paths that appear as plain text or URLs on the pasteboard. Just as in the regular
codepath for getData(), if the pasteboard data comes from the same origin, we allow unsanitized access;
otherwise, we use WebContentMarkupReader to extract markup from the pasteboard.

Tests:  PasteMixedContent.ImageFileAndPlainText
PasteMixedContent.ImageFileAndWebArchive
PasteMixedContent.ImageFileAndHTML
PasteMixedContent.ImageFileAndRTF
PasteMixedContent.ImageFileAndURL
PasteMixedContent.ImageFileWithHTMLAndURL
DataInteractionTests.DataTransferGetDataWhenDroppingImageAndMarkup

Also rebaselined some layout tests, which cover changes in behavior when dropping on macOS and pasting on iOS.

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::getDataForItem const):

Augment the codepath handling the case where the pasteboard contains files, such that we allow reading
"text/html", but only from rich text types.

(WebCore::DataTransfer::readStringFromPasteboard const):

Factor out logic for reading from the pasteboard into a private helper. This is called in two places from
getDataForItem: in the normal (existing) path, and in the case where we allow 'text/html' to be read despite
files appearing in the pasteboard.

One important difference here is that this helper now takes a WebContentReadingPolicy, whose purpose is to
prevent reading from non-rich-text types when files appear in the pasteboard.

Another tweak here is that we now use `lowercaseType` instead of the original (unadjusted) `type` when reading
from the pasteboard. This doesn't seem to be intended in the first place.

(WebCore::DataTransfer::types const):

Tweak the implementation of DataTransfer.types() in the case where files exist on the pasteboard, such that we
also add "text/html" if it is present in the list of DOM-safe types.

* dom/DataTransfer.h:
* platform/Pasteboard.h:

Introduce WebContentReadingPolicy, which indicates whether or not we should limit web content reading from the
pasteboard to only rich text types upon paste or drop. Normally, we allow all types to be read as web content
(::AnyType), but when files appear on the pasteboard, we force OnlyRichTextTypes to ensure that no other types
can unintentionally be read back as web content.

* platform/StaticPasteboard.h:
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::read):
* platform/ios/PasteboardIOS.mm:

Teach Pasteboard (on iOS) to respect WebContentReadingPolicy.

(WebCore::isTypeAllowedByReadingPolicy):
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::readRespectingUTIFidelities):
* platform/mac/PasteboardMac.mm:

Teach Pasteboard (on macOS) to respect WebContentReadingPolicy.

(WebCore::Pasteboard::read):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::read):
* platform/wpe/PasteboardWPE.cpp:
(WebCore::Pasteboard::read):

Adjust non-Cocoa Pasteboard implementations for an interface change.

Tools:

Add new API tests to exercise pasting images with various other content types on macOS, and when dropping images
and HTML markup on iOS. See the WebCore ChangeLog for more detail.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html: Added.

Add a new API test harness that dumps various bits of information about a DataTransfer upon paste and drop.
While somewhat similar to some existing harnesses, this makes a distinction between the raw HTML data on the
pasteboard and the actual result of inserting said HTML into the DOM. This allows us to check that the HTML has
been sanitized, while making checks for the actual content of the HTML robust against inline style changes.

* TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
* TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: 

[webkit-changes] [228338] trunk/Source/WebCore

[pvollan]

Title: [228338] trunk/Source/WebCore








Revision 228338
Author pvol...@apple.com
Date 2018-02-09 14:13:00 -0800 (Fri, 09 Feb 2018)


Log Message
Assert that NSApp is not running in the WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=182553

Reviewed by Simon Fraser.

In WebCore, there are a few places where NSApp is referenced. Since the WebContent process
is no longer using the NSApplication run loop, and NSApp is no longer guaranteed to be
valid, we should make sure that the NSApp is not referenced by the WebContent process or
the Network process, by asserting that the NSApplication event loop is running when NSApp
is referenced. It is still ok for the UIProcess to reference NSApp. Adding these assert
will help catch NSApp references when the NSApplication run loop is not used.

Also, do not post a fake mouse event in PasteBoard::setDragImage when the NSApplication
run loop is not running, since this is only relevant in WK1.

No new tests, covered by existing tests.

* page/mac/EventHandlerMac.mm:
(WebCore::lastEventIsMouseUp):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::setDragImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/mac/EventHandlerMac.mm
trunk/Source/WebCore/platform/mac/PasteboardMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (228337 => 228338)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 20:50:58 UTC (rev 228337)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 22:13:00 UTC (rev 228338)
@@ -1,3 +1,28 @@
+2018-02-09  Per Arne Vollan  
+
+Assert that NSApp is not running in the WebProcess.
+https://bugs.webkit.org/show_bug.cgi?id=182553
+
+Reviewed by Simon Fraser.
+
+In WebCore, there are a few places where NSApp is referenced. Since the WebContent process
+is no longer using the NSApplication run loop, and NSApp is no longer guaranteed to be
+valid, we should make sure that the NSApp is not referenced by the WebContent process or
+the Network process, by asserting that the NSApplication event loop is running when NSApp
+is referenced. It is still ok for the UIProcess to reference NSApp. Adding these assert
+will help catch NSApp references when the NSApplication run loop is not used.
+
+Also, do not post a fake mouse event in PasteBoard::setDragImage when the NSApplication
+run loop is not running, since this is only relevant in WK1.
+
+No new tests, covered by existing tests. 
+
+* page/mac/EventHandlerMac.mm:
+(WebCore::lastEventIsMouseUp):
+(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
+* platform/mac/PasteboardMac.mm:
+(WebCore::Pasteboard::setDragImage):
+
 2018-02-09  Zalan Bujtas  
 
 [RenderTreeBuilder] Introduce RenderTreeBuilder to willBeDestoryed/removeFromParentAndDestroy


Modified: trunk/Source/WebCore/page/mac/EventHandlerMac.mm (228337 => 228338)

--- trunk/Source/WebCore/page/mac/EventHandlerMac.mm	2018-02-09 20:50:58 UTC (rev 228337)
+++ trunk/Source/WebCore/page/mac/EventHandlerMac.mm	2018-02-09 22:13:00 UTC (rev 228338)
@@ -196,6 +196,8 @@
 // that state. Handling this was critical when we used AppKit widgets for form elements.
 // It's not clear in what cases this is helpful now -- it's possible it can be removed. 
 
+ASSERT([NSApp isRunning]);
+
 BEGIN_BLOCK_OBJC_EXCEPTIONS;
 NSEvent *currentEventAfterHandlingMouseDown = [NSApp currentEvent];
 return EventHandler::currentNSEvent() != currentEventAfterHandlingMouseDown
@@ -570,6 +572,7 @@
 m_sendingEventToSubview = false;
 int eventType = [initiatingEvent type];
 if (eventType == NSEventTypeLeftMouseDown || eventType == NSEventTypeKeyDown) {
+ASSERT([NSApp isRunning]);
 NSEvent *fakeEvent = nil;
 if (eventType == NSEventTypeLeftMouseDown) {
 fakeEvent = [NSEvent mouseEventWithType:NSEventTypeLeftMouseUp


Modified: trunk/Source/WebCore/platform/mac/PasteboardMac.mm (228337 => 228338)

--- trunk/Source/WebCore/platform/mac/PasteboardMac.mm	2018-02-09 20:50:58 UTC (rev 228337)
+++ trunk/Source/WebCore/platform/mac/PasteboardMac.mm	2018-02-09 22:13:00 UTC (rev 228338)
@@ -658,10 +658,14 @@
 
 // Hack: We must post an event to wake up the NSDragManager, which is sitting in a nextEvent call
 // up the stack from us because the CoreFoundation drag manager does not use the run loop by itself.
-// This is the most innocuous event to use, per Kristen Forster.
-NSEvent* event = [NSEvent mouseEventWithType:NSEventTypeMouseMoved location:NSZeroPoint
-modifierFlags:0 timestamp:0 windowNumber:0 context:nil eventNumber:0 clickCount:0 pressure:0];
-[NSApp postEvent:event atStart:YES];
+// This is the most innocuous event to use, per Kristin Forster.
+// This is only relevant in WK1. Do not execute in the WebContent 

[webkit-changes] [228341] trunk/Source/WebKit

[bfulgham]

Title: [228341] trunk/Source/WebKit








Revision 228341
Author bfulg...@apple.com
Date 2018-02-09 15:56:41 -0800 (Fri, 09 Feb 2018)


Log Message
Sandbox violating attempting to read log formatting preference file
https://bugs.webkit.org/show_bug.cgi?id=182648


Reviewed by Eric Carlson.

Various frameworks attempt to read logging format information from /usr/local/lib/log. The sandbox is blocking
this, generating log spam and preventing some logging features from working properly. We should allow read
access to this path.

* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (228340 => 228341)

--- trunk/Source/WebKit/ChangeLog	2018-02-09 23:41:34 UTC (rev 228340)
+++ trunk/Source/WebKit/ChangeLog	2018-02-09 23:56:41 UTC (rev 228341)
@@ -1,3 +1,20 @@
+2018-02-09  Brent Fulgham  
+
+Sandbox violating attempting to read log formatting preference file
+https://bugs.webkit.org/show_bug.cgi?id=182648
+
+
+Reviewed by Eric Carlson.
+
+Various frameworks attempt to read logging format information from /usr/local/lib/log. The sandbox is blocking
+this, generating log spam and preventing some logging features from working properly. We should allow read
+access to this path.
+
+* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2018-02-08  Chris Dumez  
 
 There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld


Modified: trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (228340 => 228341)

--- trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2018-02-09 23:41:34 UTC (rev 228340)
+++ trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2018-02-09 23:56:41 UTC (rev 228341)
@@ -110,6 +110,10 @@
 (subpath (param "WEBKIT2_FRAMEWORK_DIR")))
 (allow system-fsctl (fsctl-command (_IO "h" 47)))
 
+(allow file-read-data
+(literal "/usr/local/lib/log") ; 
+)
+
 ;; Sandbox extensions
 (define (apply-read-and-issue-extension op path-filter)
 (op file-read* path-filter)


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (228340 => 228341)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2018-02-09 23:41:34 UTC (rev 228340)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2018-02-09 23:56:41 UTC (rev 228341)
@@ -66,6 +66,10 @@
 (allow-well-known-system-group-container-subpath-read
 "/systemgroup.com.apple.nsurlstoragedresources/Library/dafsaData.bin")
 
+(allow file-read-data
+(literal "/usr/local/lib/log") ; 
+)
+
 ;; Security framework
 (allow mach-lookup
 (global-name "com.apple.ocspd")


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (228340 => 228341)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2018-02-09 23:41:34 UTC (rev 228340)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2018-02-09 23:56:41 UTC (rev 228341)
@@ -370,6 +370,10 @@
 ;; Allow ManagedPreference access
 (allow file-read* (literal "/private/var/Managed Preferences/mobile/com.apple.webcontentfilter.plist"))
 
+(allow file-read-data
+(literal "/usr/local/lib/log") ; 
+)
+
 ;; Allow mediaserverd to issue file extensions for the purposes of reading media
 (allow file-issue-extension (require-all
 (extension "com.apple.app-sandbox.read")


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (228340 => 228341)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2018-02-09 23:41:34 UTC (rev 228340)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2018-02-09 23:56:41 UTC (rev 228341)
@@ -439,6 +439,7 @@
 (home-subpath "/Library/Dictionaries"))
 
 (allow file-read-data
+(literal "/usr/local/lib/log") ; 
 ;; Needed for AES3 support
 (subpath "/Library/Audio/Plug-Ins/Components"))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228343] trunk/LayoutTests

[mcatanzaro]

Title: [228343] trunk/LayoutTests








Revision 228343
Author mcatanz...@igalia.com
Date 2018-02-09 16:18:03 -0800 (Fri, 09 Feb 2018)


Log Message
Unreviewed, updated GTK test expectations after r228276

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (228342 => 228343)

--- trunk/LayoutTests/ChangeLog	2018-02-10 00:03:13 UTC (rev 228342)
+++ trunk/LayoutTests/ChangeLog	2018-02-10 00:18:03 UTC (rev 228343)
@@ -1,3 +1,9 @@
+2018-02-09  Michael Catanzaro  
+
+Unreviewed, updated GTK test expectations after r228276
+
+* platform/gtk/TestExpectations:
+
 2018-02-08  Wenson Hsieh  
 
 Pasting from Excel no longer provides text/html data


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (228342 => 228343)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-02-10 00:03:13 UTC (rev 228342)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-02-10 00:18:03 UTC (rev 228343)
@@ -1323,9 +1323,6 @@
 webkit.org/b/182106 imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end.html [ Crash ]
 webkit.org/b/182106 media/video-multiple-concurrent-playback.html [ Crash ]
 
-webkit.org/b/182603 storage/indexeddb/transaction-complete-workers-private.html [ Crash ]
-webkit.org/b/182603 storage/indexeddb/transaction-complete-workers.html [ Crash ]
-
 #
 # End of Crashing tests
 #
@@ -2253,8 +2250,6 @@
 
 webkit.org/b/182317 http/tests/resourceLoadStatistics/grandfathering.html [ Failure ]
 
-webkit.org/b/182603 fast/workers/worker-script-error.html [ Timeout ]
-
 #
 # End of Tests timing out
 #
@@ -3335,14 +3330,6 @@
 webkit.org/b/182502 http/tests/media/modern-media-controls [ Skip ]
 webkit.org/b/182502 media/modern-media-controls [ Skip ]
 
-webkit.org/b/182603 imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm [ Failure ]
-webkit.org/b/182603 imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_filename.htm [ Failure ]
-webkit.org/b/182603 imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_lineno.htm [ Failure ]
-webkit.org/b/182603 imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_message.htm [ Failure ]
-webkit.org/b/182603 imported/w3c/web-platform-tests/workers/Worker_ErrorEvent_error.htm [ Failure ]
-webkit.org/b/182603 imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror.html [ Failure ]
-webkit.org/b/182603 imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/handled.html [ Failure ]
-
 #
 # End of non-crashing, non-flaky tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228345] trunk/Source/WebCore

[zalan]

Title: [228345] trunk/Source/WebCore








Revision 228345
Author za...@apple.com
Date 2018-02-09 16:45:25 -0800 (Fri, 09 Feb 2018)


Log Message
[RenderTreeBuilder] Move RenderRubyRun::takeChild mutation to a RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=182655


Reviewed by Simon Fraser.

No change in functionality.

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::takeChild):
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::takeChildFromRenderRubyRun):
* rendering/updating/RenderTreeBuilder.h:
* rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::RenderTreeBuilder::Ruby::takeChild):
* rendering/updating/RenderTreeBuilderRuby.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderRubyRun.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (228344 => 228345)

--- trunk/Source/WebCore/ChangeLog	2018-02-10 00:26:50 UTC (rev 228344)
+++ trunk/Source/WebCore/ChangeLog	2018-02-10 00:45:25 UTC (rev 228345)
@@ -1,3 +1,22 @@
+2018-02-09  Zalan Bujtas  
+
+[RenderTreeBuilder] Move RenderRubyRun::takeChild mutation to a RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=182655
+
+
+Reviewed by Simon Fraser.
+
+No change in functionality.
+
+* rendering/RenderRubyRun.cpp:
+(WebCore::RenderRubyRun::takeChild):
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::takeChildFromRenderRubyRun):
+* rendering/updating/RenderTreeBuilder.h:
+* rendering/updating/RenderTreeBuilderRuby.cpp:
+(WebCore::RenderTreeBuilder::Ruby::takeChild):
+* rendering/updating/RenderTreeBuilderRuby.h:
+
 2018-02-09  Andy Estes  
 
 [Payment Request] Apple Pay sheet does not dismiss when calling complete() with result "unknown" or "fail"


Modified: trunk/Source/WebCore/rendering/RenderRubyRun.cpp (228344 => 228345)

--- trunk/Source/WebCore/rendering/RenderRubyRun.cpp	2018-02-10 00:26:50 UTC (rev 228344)
+++ trunk/Source/WebCore/rendering/RenderRubyRun.cpp	2018-02-10 00:45:25 UTC (rev 228345)
@@ -99,38 +99,7 @@
 
 RenderPtr RenderRubyRun::takeChild(RenderTreeBuilder& builder, RenderObject& child)
 {
-// If the child is a ruby text, then merge the ruby base with the base of
-// the right sibling run, if possible.
-if (!beingDestroyed() && !renderTreeBeingDestroyed() && child.isRubyText()) {
-RenderRubyBase* base = rubyBase();
-RenderObject* rightNeighbour = nextSibling();
-if (base && is(rightNeighbour)) {
-// Ruby run without a base can happen only at the first run.
-RenderRubyRun& rightRun = downcast(*rightNeighbour);
-if (rightRun.hasRubyBase()) {
-RenderRubyBase* rightBase = rightRun.rubyBase();
-// Collect all children in a single base, then swap the bases.
-builder.moveRubyChildren(*rightBase, *base);
-moveChildTo(builder, , base, RenderBoxModelObject::NormalizeAfterInsertion::No);
-rightRun.moveChildTo(builder, this, rightBase, RenderBoxModelObject::NormalizeAfterInsertion::No);
-// The now empty ruby base will be removed below.
-ASSERT(!rubyBase()->firstChild());
-}
-}
-}
-
-auto takenChild = RenderBlockFlow::takeChild(builder, child);
-
-if (!beingDestroyed() && !renderTreeBeingDestroyed()) {
-// Check if our base (if any) is now empty. If so, destroy it.
-RenderBlock* base = rubyBase();
-if (base && !base->firstChild()) {
-auto takenBase = RenderBlockFlow::takeChild(builder, *base);
-base->deleteLines();
-}
-}
-
-return takenChild;
+return builder.takeChildFromRenderRubyRun(*this, child);
 }
 
 RenderPtr RenderRubyRun::createRubyBase() const


Modified: trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp (228344 => 228345)

--- trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp	2018-02-10 00:26:50 UTC (rev 228344)
+++ trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp	2018-02-10 00:45:25 UTC (rev 228345)
@@ -480,6 +480,11 @@
 return rubyBuilder().takeChild(parent, child);
 }
 
+RenderPtr RenderTreeBuilder::takeChildFromRenderRubyRun(RenderRubyRun& parent, RenderObject& child)
+{
+return rubyBuilder().takeChild(parent, child);
+}
+
 void RenderTreeBuilder::updateAfterDescendants(RenderElement& renderer)
 {
 if (is(renderer))


Modified: trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h (228344 => 228345)

--- trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h	2018-02-10 00:26:50 UTC (rev 

[webkit-changes] [228351] trunk/Source/WebKit

[ross . kirsling]

Title: [228351] trunk/Source/WebKit








Revision 228351
Author ross.kirsl...@sony.com
Date 2018-02-09 20:44:39 -0800 (Fri, 09 Feb 2018)


Log Message
Remove invalidated WebPage::handleEditingKeyboardEvent default implementation after r228260.
https://bugs.webkit.org/show_bug.cgi?id=182663

Reviewed by Chris Dumez.

This would need to be updated to turn `keyEvent` into `underlyingPlatformEvent`;
instead, we can remove it, as it's only for Windows, which doesn't yet support WK2.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::handleEditingKeyboardEvent): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (228350 => 228351)

--- trunk/Source/WebKit/ChangeLog	2018-02-10 01:46:04 UTC (rev 228350)
+++ trunk/Source/WebKit/ChangeLog	2018-02-10 04:44:39 UTC (rev 228351)
@@ -1,3 +1,16 @@
+2018-02-09  Ross Kirsling  
+
+Remove invalidated WebPage::handleEditingKeyboardEvent default implementation after r228260.
+https://bugs.webkit.org/show_bug.cgi?id=182663
+
+Reviewed by Chris Dumez.
+
+This would need to be updated to turn `keyEvent` into `underlyingPlatformEvent`;
+instead, we can remove it, as it's only for Windows, which doesn't yet support WK2.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::handleEditingKeyboardEvent): Deleted.
+
 2018-02-09  Nan Wang  
 
 AX: Accessibility is not notified when a web process cancels the suspension


Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (228350 => 228351)

--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-02-10 01:46:04 UTC (rev 228350)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2018-02-10 04:44:39 UTC (rev 228351)
@@ -3297,42 +3297,6 @@
 return m_notificationPermissionRequestManager.get();
 }
 
-#if !PLATFORM(GTK) && !PLATFORM(COCOA) && !PLATFORM(WPE)
-
-bool WebPage::handleEditingKeyboardEvent(KeyboardEvent* evt)
-{
-Frame* frame = downcast(*evt->target()).document().frame();
-ASSERT(frame);
-
-const PlatformKeyboardEvent* keyEvent = evt->keyEvent();
-if (!keyEvent)
-return false;
-
-Editor::Command command = frame->editor().command(interpretKeyEvent(evt));
-
-if (keyEvent->type() == PlatformEvent::RawKeyDown) {
-// WebKit doesn't have enough information about mode to decide how commands that just insert text if executed via Editor should be treated,
-// so we leave it upon WebCore to either handle them immediately (e.g. Tab that changes focus) or let a keypress event be generated
-// (e.g. Tab that inserts a Tab character, or Enter).
-return !command.isTextInsertion() && command.execute(evt);
-}
-
-if (command.execute(evt))
-return true;
-
-// Don't allow text insertion for nodes that cannot edit.
-if (!frame->editor().canEdit())
-return false;
-
-// Don't insert null or control characters as they can result in unexpected behaviour
-if (evt->charCode() < ' ')
-return false;
-
-return frame->editor().insertText(evt->keyEvent()->text(), evt);
-}
-
-#endif
-
 #if ENABLE(DRAG_SUPPORT)
 
 #if PLATFORM(GTK)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228346] trunk

[ross . kirsling]

Title: [228346] trunk








Revision 228346
Author ross.kirsl...@sony.com
Date 2018-02-09 16:48:52 -0800 (Fri, 09 Feb 2018)


Log Message
Simplify .gitignore's WebKitLibraries/win section.
https://bugs.webkit.org/show_bug.cgi?id=182618

Reviewed by Per Arne Vollan.

We need to update this section for WinCairoRequirements regardless, but
it never needed to be this longwinded in the first place.

* .gitignore:

Modified Paths

trunk/.gitignore
trunk/ChangeLog




Diff

Modified: trunk/.gitignore (228345 => 228346)

--- trunk/.gitignore	2018-02-10 00:45:25 UTC (rev 228345)
+++ trunk/.gitignore	2018-02-10 00:48:52 UTC (rev 228346)
@@ -26,86 +26,13 @@
 # Ignore CMake caches outside of the build directory.
 __cmake_systeminformation/
 
-# Ignore files installed by WebKitSupportLibrary/WebKitAuxiliaryLibrary
+# Ignore files installed by WebKitSupportLibrary/WebKitAuxiliaryLibrary/WinCairoRequirements
 /WebKitSupportLibrary.zip
-/WebKitLibraries/win/Software License Agreement for WebKit Support Libraries.rtf
-/WebKitLibraries/win/WebKitAuxiliaryLibrary.headers
-/WebKitLibraries/win/WebKitAuxiliaryLibraryVersion
-/WebKitLibraries/win/WebKitChangesToPthreads.diff
-/WebKitLibraries/win/WebKitSupportLibraryVersion
-/WebKitLibraries/win/include/AVFoundationCF/
-/WebKitLibraries/win/include/ApplicationServices/
-/WebKitLibraries/win/include/AssertMacros.h
-/WebKitLibraries/win/include/Availability.h
-/WebKitLibraries/win/include/AvailabilityInternal.h
-/WebKitLibraries/win/include/AvailabilityMacros.h
-/WebKitLibraries/win/include/CFNetwork/
-/WebKitLibraries/win/include/ColorSync/
-/WebKitLibraries/win/include/ConditionalMacros.h
-/WebKitLibraries/win/include/CoreAudio/
-/WebKitLibraries/win/include/CoreFoundation/
-/WebKitLibraries/win/include/CoreGraphics/
-/WebKitLibraries/win/include/CoreMedia/
-/WebKitLibraries/win/include/CoreServices/
-/WebKitLibraries/win/include/CoreText/
-/WebKitLibraries/win/include/CoreVideo/
-/WebKitLibraries/win/include/ImageIO/
-/WebKitLibraries/win/include/MediaAccessibility/
-/WebKitLibraries/win/include/MediaToolbox/
-/WebKitLibraries/win/include/QuartzCore/
-/WebKitLibraries/win/include/SQLite/
-/WebKitLibraries/win/include/SQLite3.h
-/WebKitLibraries/win/include/SafariTheme/
-/WebKitLibraries/win/include/TargetConditionals.h
-/WebKitLibraries/win/include/WebKitQuartzCoreAdditions/
-/WebKitLibraries/win/include/asl.h
-/WebKitLibraries/win/include/checkint.h
-/WebKitLibraries/win/include/dispatch/
-/WebKitLibraries/win/include/inttypes.h
-/WebKitLibraries/win/include/libexslt/
-/WebKitLibraries/win/include/libxml/
-/WebKitLibraries/win/include/libxslt/
-/WebKitLibraries/win/include/os/
-/WebKitLibraries/win/include/pthreads/
-/WebKitLibraries/win/include/stdbool.h
-/WebKitLibraries/win/include/stdint.h
-/WebKitLibraries/win/include/unicode/
-/WebKitLibraries/win/include/unistd.h
-/WebKitLibraries/win/include/xlocale.h
-/WebKitLibraries/win/include/zlib/
-/WebKitLibraries/win/lib*/ASL.lib
-/WebKitLibraries/win/lib*/AVFoundationCF.lib
-/WebKitLibraries/win/lib*/CFNetwork.lib
-/WebKitLibraries/win/lib*/CoreAudioToolbox.lib
-/WebKitLibraries/win/lib*/CoreFoundation.lib
-/WebKitLibraries/win/lib*/CoreGraphics.lib
-/WebKitLibraries/win/lib*/CoreMedia.lib
-/WebKitLibraries/win/lib*/CoreText.lib
-/WebKitLibraries/win/lib*/CoreVideo.lib
-/WebKitLibraries/win/lib*/MediaAccessibility.lib
-/WebKitLibraries/win/lib*/MediaToolbox.lib
-/WebKitLibraries/win/lib*/QuartzCore.lib
-/WebKitLibraries/win/lib*/SQLite3.lib
-/WebKitLibraries/win/lib*/SafariTheme.lib
-/WebKitLibraries/win/lib*/WebKitQuartzCoreAdditions.lib
-/WebKitLibraries/win/lib*/icuin.lib
-/WebKitLibraries/win/lib*/icuuc.lib
-/WebKitLibraries/win/lib*/libdispatch.lib
-/WebKitLibraries/win/lib*/libexslt.lib
-/WebKitLibraries/win/lib*/libicuin.lib
-/WebKitLibraries/win/lib*/libicuuc.lib
-/WebKitLibraries/win/lib*/libxml2.lib
-/WebKitLibraries/win/lib*/libxslt.lib
-/WebKitLibraries/win/lib*/pthreadVC2.lib
-/WebKitLibraries/win/lib*/zdll.lib
+/WebKitLibraries/win/
+!/WebKitLibraries/win/include/WebKitSystemInterface/
+!/WebKitLibraries/win/lib32/WebKitSystemInterface.lib
+!/WebKitLibraries/win/tools/scripts/
 
-# Ignore files installed by WinCairoRequirements
-/WebKitLibraries/win/WinCairoRequirements.zip
-/WebKitLibraries/win/WinCairoRequirements.zip.version
-/WebKitLibraries/win/etc/ssl/
-/WebKitLibraries/win/include/
-/WebKitLibraries/win/tools/
-
 # Ignore files generated by Qt Creator:
 *.pro.user
 


Modified: trunk/ChangeLog (228345 => 228346)

--- trunk/ChangeLog	2018-02-10 00:45:25 UTC (rev 228345)
+++ trunk/ChangeLog	2018-02-10 00:48:52 UTC (rev 228346)
@@ -1,3 +1,15 @@
+2018-02-09  Ross Kirsling  
+
+Simplify .gitignore's WebKitLibraries/win section.
+https://bugs.webkit.org/show_bug.cgi?id=182618
+
+Reviewed by Per Arne Vollan.
+
+We need to update this section for WinCairoRequirements regardless, but
+it never needed to be this longwinded in the first place.
+
+

[webkit-changes] [228349] trunk/Source/WebCore

[dino]

Title: [228349] trunk/Source/WebCore








Revision 228349
Author d...@apple.com
Date 2018-02-09 17:24:49 -0800 (Fri, 09 Feb 2018)


Log Message
ImageBitmapRenderingContext should be Runtime guarded
https://bugs.webkit.org/show_bug.cgi?id=182665


Reviewed by Sam Weinig.

Add a flag to ensure the ImageBitmapRenderingContext interface is only
visible when the runtime feature is enabled.

* bindings/js/WebCoreBuiltinNames.h:
* html/canvas/ImageBitmapRenderingContext.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (228348 => 228349)

--- trunk/Source/WebCore/ChangeLog	2018-02-10 01:13:27 UTC (rev 228348)
+++ trunk/Source/WebCore/ChangeLog	2018-02-10 01:24:49 UTC (rev 228349)
@@ -1,3 +1,17 @@
+2018-02-09  Dean Jackson  
+
+ImageBitmapRenderingContext should be Runtime guarded
+https://bugs.webkit.org/show_bug.cgi?id=182665
+
+
+Reviewed by Sam Weinig.
+
+Add a flag to ensure the ImageBitmapRenderingContext interface is only
+visible when the runtime feature is enabled.
+
+* bindings/js/WebCoreBuiltinNames.h:
+* html/canvas/ImageBitmapRenderingContext.idl:
+
 2018-02-09  Don Olmstead  
 
 [CMake] Make PAL headers copies


Modified: trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h (228348 => 228349)

--- trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h	2018-02-10 01:13:27 UTC (rev 228348)
+++ trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h	2018-02-10 01:24:49 UTC (rev 228349)
@@ -82,6 +82,7 @@
 macro(IDBTransaction) \
 macro(IDBVersionChangeEvent) \
 macro(ImageBitmap) \
+macro(ImageBitmapRenderingContext) \
 macro(InputEvent) \
 macro(IntersectionObserver) \
 macro(IntersectionObserverEntry) \


Modified: trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl (228348 => 228349)

--- trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl	2018-02-10 01:13:27 UTC (rev 228348)
+++ trunk/Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl	2018-02-10 01:24:49 UTC (rev 228349)
@@ -24,6 +24,7 @@
  */
 
 [
+EnabledAtRuntime=ImageBitmapOffscreenCanvas,
 Exposed=Window
 ] interface ImageBitmapRenderingContext {
 readonly attribute HTMLCanvasElement canvas;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228350] trunk/Source/WebKit

[n_wang]

Title: [228350] trunk/Source/WebKit








Revision 228350
Author n_w...@apple.com
Date 2018-02-09 17:46:04 -0800 (Fri, 09 Feb 2018)


Log Message
AX: Accessibility is not notified when a web process cancels the suspension
https://bugs.webkit.org/show_bug.cgi?id=182659

Reviewed by Ryosuke Niwa.

We were notifying Accessibility with the web process suspended information in actualPrepareToSuspend
and processDidResume. However, the suspension can be canceled during the prepare call. So that we
should also post a notification in cancelPrepareToSuspend.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::cancelPrepareToSuspend):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (228349 => 228350)

--- trunk/Source/WebKit/ChangeLog	2018-02-10 01:24:49 UTC (rev 228349)
+++ trunk/Source/WebKit/ChangeLog	2018-02-10 01:46:04 UTC (rev 228350)
@@ -1,3 +1,17 @@
+2018-02-09  Nan Wang  
+
+AX: Accessibility is not notified when a web process cancels the suspension
+https://bugs.webkit.org/show_bug.cgi?id=182659
+
+Reviewed by Ryosuke Niwa.
+
+We were notifying Accessibility with the web process suspended information in actualPrepareToSuspend
+and processDidResume. However, the suspension can be canceled during the prepare call. So that we
+should also post a notification in cancelPrepareToSuspend.
+
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::cancelPrepareToSuspend):
+
 2018-02-09  Brent Fulgham  
 
 Sandbox violating attempting to read log formatting preference file


Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (228349 => 228350)

--- trunk/Source/WebKit/WebProcess/WebProcess.cpp	2018-02-10 01:24:49 UTC (rev 228349)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp	2018-02-10 01:46:04 UTC (rev 228350)
@@ -1407,6 +1407,10 @@
 return;
 
 cancelMarkAllLayersVolatile();
+
+#if PLATFORM(IOS)
+accessibilityProcessSuspendedNotification(false);
+#endif
 
 RELEASE_LOG(ProcessSuspension, "%p - WebProcess::cancelPrepareToSuspend() Sending DidCancelProcessSuspension IPC message", this);
 parentProcessConnection()->send(Messages::WebProcessProxy::DidCancelProcessSuspension(), 0);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228342] trunk/Source/WebCore

[aestes]

Title: [228342] trunk/Source/WebCore








Revision 228342
Author aes...@apple.com
Date 2018-02-09 16:03:13 -0800 (Fri, 09 Feb 2018)


Log Message
[Payment Request] Apple Pay sheet does not dismiss when calling complete() with result "unknown" or "fail"
https://bugs.webkit.org/show_bug.cgi?id=182658


Reviewed by Brady Eidson.

When PaymentResponse::complete() is called with a result of "unknown" or "fail", we should
treat this as a fatal error and dismiss the Apple Pay sheet. However, we were adding an
error with code "unknown" to the authorization result, which PassKit interprets as a
non-fatal error. Instead, we should not set any errors and just use a status code of
PaymentAuthorizationStatus::Failure, which PassKit interprets as a fatal error, dismissing
the sheet.

No test possible.

* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::complete):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (228341 => 228342)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 23:56:41 UTC (rev 228341)
+++ trunk/Source/WebCore/ChangeLog	2018-02-10 00:03:13 UTC (rev 228342)
@@ -1,3 +1,23 @@
+2018-02-09  Andy Estes  
+
+[Payment Request] Apple Pay sheet does not dismiss when calling complete() with result "unknown" or "fail"
+https://bugs.webkit.org/show_bug.cgi?id=182658
+
+
+Reviewed by Brady Eidson.
+
+When PaymentResponse::complete() is called with a result of "unknown" or "fail", we should
+treat this as a fatal error and dismiss the Apple Pay sheet. However, we were adding an
+error with code "unknown" to the authorization result, which PassKit interprets as a
+non-fatal error. Instead, we should not set any errors and just use a status code of
+PaymentAuthorizationStatus::Failure, which PassKit interprets as a fatal error, dismissing
+the sheet.
+
+No test possible.
+
+* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
+(WebCore::ApplePayPaymentHandler::complete):
+
 2018-02-09  Wenson Hsieh  
 
 Pasting from Excel no longer provides text/html data


Modified: trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp (228341 => 228342)

--- trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp	2018-02-09 23:56:41 UTC (rev 228341)
+++ trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp	2018-02-10 00:03:13 UTC (rev 228342)
@@ -409,7 +409,6 @@
 case PaymentComplete::Fail:
 case PaymentComplete::Unknown:
 authorizationResult.status = PaymentAuthorizationStatus::Failure;
-authorizationResult.errors.append({ PaymentError::Code::Unknown, { }, std::nullopt });
 break;
 case PaymentComplete::Success:
 authorizationResult.status = PaymentAuthorizationStatus::Success;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228348] trunk/LayoutTests

[ryanhaddad]

Title: [228348] trunk/LayoutTests








Revision 228348
Author ryanhad...@apple.com
Date 2018-02-09 17:13:27 -0800 (Fri, 09 Feb 2018)


Log Message
Mark two service worker LayoutTests as flaky.

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (228347 => 228348)

--- trunk/LayoutTests/ChangeLog	2018-02-10 00:51:11 UTC (rev 228347)
+++ trunk/LayoutTests/ChangeLog	2018-02-10 01:13:27 UTC (rev 228348)
@@ -1,3 +1,11 @@
+2018-02-09  Ryan Haddad  
+
+Mark two service worker LayoutTests as flaky.
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2018-02-09  Michael Catanzaro  
 
 Unreviewed, updated GTK test expectations after r228276


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (228347 => 228348)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-02-10 00:51:11 UTC (rev 228347)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-02-10 01:13:27 UTC (rev 228348)
@@ -884,3 +884,6 @@
 
 webkit.org/b/177663 media/W3C/video/events/event_progress_manual.html [ Pass Failure ]
 
+webkit.org/b/182341 imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https.html [ Pass Failure ]
+
+webkit.org/b/179352 imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228344] branches/safari-605-branch

[ryanhaddad]

Title: [228344] branches/safari-605-branch








Revision 228344
Author ryanhad...@apple.com
Date 2018-02-09 16:26:50 -0800 (Fri, 09 Feb 2018)


Log Message
Work towards rdar://problem/36837397.

Tools:

Unreviewed test gardening..

* TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
(TestWebKitAPI::TEST):

LayoutTests:

Unreviewed test gardening.

* platform/ios/TestExpectations:

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/LayoutTests/platform/ios/TestExpectations
branches/safari-605-branch/Tools/ChangeLog
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (228343 => 228344)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 00:18:03 UTC (rev 228343)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 00:26:50 UTC (rev 228344)
@@ -1,3 +1,11 @@
+2018-02-09  Ryan Haddad  
+
+Work towards rdar://problem/36837397.
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+
 2018-02-08  Ryan Haddad  
 
 Unreviewed, land test results for rdar://problem/37331740.


Modified: branches/safari-605-branch/LayoutTests/platform/ios/TestExpectations (228343 => 228344)

--- branches/safari-605-branch/LayoutTests/platform/ios/TestExpectations	2018-02-10 00:18:03 UTC (rev 228343)
+++ branches/safari-605-branch/LayoutTests/platform/ios/TestExpectations	2018-02-10 00:26:50 UTC (rev 228344)
@@ -3268,3 +3268,9 @@
 webkit.org/b/180062 fast/text/user-installed-fonts/shadow-postscript.html [ ImageOnlyFailure ]
 webkit.org/b/180062 fast/text/user-installed-fonts/shadow.html [ ImageOnlyFailure ]
 webkit.org/b/180062 fast/text/user-installed-fonts/shadow-postscript-family.html [ ImageOnlyFailure ]
+
+# https://bugs.webkit.org/show_bug.cgi?id=182527
+media/media-fullscreen-loop-inline.html
+media/media-higher-prio-audio-stream.html
+media/modern-media-controls/playback-support/playback-support-autoplay.html
+media/video-background-playback.html


Modified: branches/safari-605-branch/Tools/ChangeLog (228343 => 228344)

--- branches/safari-605-branch/Tools/ChangeLog	2018-02-10 00:18:03 UTC (rev 228343)
+++ branches/safari-605-branch/Tools/ChangeLog	2018-02-10 00:26:50 UTC (rev 228344)
@@ -1,3 +1,12 @@
+2018-02-09  Ryan Haddad  
+
+Work towards rdar://problem/36837397.
+
+Unreviewed test gardening..
+
+* TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
+(TestWebKitAPI::TEST):
+
 2018-02-06  Jason Marcell  
 
 Cherry-pick r228188. rdar://problem/37293107


Modified: branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm (228343 => 228344)

--- branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm	2018-02-10 00:18:03 UTC (rev 228343)
+++ branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm	2018-02-10 00:26:50 UTC (rev 228344)
@@ -59,7 +59,7 @@
 
 namespace TestWebKitAPI {
 
-TEST(WebKitLegacy, AudioSessionCategoryIOS)
+TEST(WebKitLegacy, DISABLED_AudioSessionCategoryIOS)
 {
 WebCore::DeprecatedGlobalSettings::setShouldManageAudioSessionCategory(true);
 RetainPtr uiWindow = adoptNS([[UIWindow alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228356] branches/safari-605-branch/Source/WebInspectorUI

[jmarcell]

Title: [228356] branches/safari-605-branch/Source/WebInspectorUI








Revision 228356
Author jmarc...@apple.com
Date 2018-02-09 21:43:40 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228296. rdar://problem/37408890

Modified Paths

branches/safari-605-branch/Source/WebInspectorUI/ChangeLog
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js




Diff

Modified: branches/safari-605-branch/Source/WebInspectorUI/ChangeLog (228355 => 228356)

--- branches/safari-605-branch/Source/WebInspectorUI/ChangeLog	2018-02-10 05:43:38 UTC (rev 228355)
+++ branches/safari-605-branch/Source/WebInspectorUI/ChangeLog	2018-02-10 05:43:40 UTC (rev 228356)
@@ -1,3 +1,23 @@
+2018-02-09  Jason Marcell  
+
+Cherry-pick r228296. rdar://problem/37408890
+
+2018-02-08  Nikita Vasilyev  
+
+Web Inspector: Styles: Typing value and quickly moving focus away may display outdated value in UI
+https://bugs.webkit.org/show_bug.cgi?id=182588
+
+
+Reviewed by Matt Baker.
+
+CSSProperty models were updated with a 250ms delay. Quickly adding a blank property after modifying
+an existing property could result in outdated values being shown.
+
+This patch removes the 250ms delay.
+
+* UserInterface/Views/SpreadsheetStyleProperty.js:
+(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidChange):
+
 2018-02-04  Jason Marcell  
 
 Cherry-pick r228030. rdar://problem/37220121


Modified: branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (228355 => 228356)

--- branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2018-02-10 05:43:38 UTC (rev 228355)
+++ branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js	2018-02-10 05:43:40 UTC (rev 228356)
@@ -236,9 +236,9 @@
 spreadsheetTextFieldDidChange(textField)
 {
 if (textField === this._valueTextField)
-this.debounce(WI.SpreadsheetStyleProperty.CommitCoalesceDelay)._handleValueChange();
+this._handleValueChange();
 else if (textField === this._nameTextField)
-this.debounce(WI.SpreadsheetStyleProperty.CommitCoalesceDelay)._handleNameChange();
+this._handleNameChange();
 }
 
 spreadsheetTextFieldDidCommit(textField, {direction})
@@ -655,5 +655,3 @@
 };
 
 WI.SpreadsheetStyleProperty.StyleClassName = "property";
-
-WI.SpreadsheetStyleProperty.CommitCoalesceDelay = 250;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228354] branches/safari-605-branch

[jmarcell]

Title: [228354] branches/safari-605-branch








Revision 228354
Author jmarc...@apple.com
Date 2018-02-09 21:43:36 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228253. rdar://problem/37408874

Modified Paths

branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/UIProcess/ios/WKScrollView.mm
branches/safari-605-branch/Tools/ChangeLog
branches/safari-605-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

branches/safari-605-branch/Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm


Removed Paths

branches/safari-605-branch/Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm




Diff

Modified: branches/safari-605-branch/Source/WebKit/ChangeLog (228353 => 228354)

--- branches/safari-605-branch/Source/WebKit/ChangeLog	2018-02-10 05:43:33 UTC (rev 228353)
+++ branches/safari-605-branch/Source/WebKit/ChangeLog	2018-02-10 05:43:36 UTC (rev 228354)
@@ -1,3 +1,34 @@
+2018-02-09  Jason Marcell  
+
+Cherry-pick r228253. rdar://problem/37408874
+
+2018-02-07  Tim Horton  
+
+Evernote device management web view sometimes displays at the wrong scale
+https://bugs.webkit.org/show_bug.cgi?id=182590
+
+
+Reviewed by Simon Fraser.
+
+Evernote implements the WKWebView's scroll view's delegate method
+viewForZoomingInScrollView: and returns nil. This results in
+WKScrollView's zoomScale always returning 1, no matter what the
+WKContentView's actual scale is. This will result in us never updating
+the WKContentView's scale to 1. When loading a page that has a few
+scale changes during load but ends up at scale 1, we get stuck at whatever
+intermediate scale immediately preceded settling on 1.
+
+Fix this by not forwarding viewForZoomingInScrollView: to the external
+WKScrollView delegate; we are in charge of the contents of the scroll
+view (including which view scrollView's zoomScale should track), and
+overriding viewForZoomingInScrollView: is only ever going to lead to
+a broken WebKit.
+
+* UIProcess/ios/WKScrollView.mm:
+(shouldForwardScrollViewDelegateMethodToExternalDelegate):
+(-[WKScrollViewDelegateForwarder forwardInvocation:]):
+(-[WKScrollViewDelegateForwarder forwardingTargetForSelector:]):
+
 2018-02-07  Jason Marcell  
 
 Cherry-pick r228230. rdar://problem/37319241


Modified: branches/safari-605-branch/Source/WebKit/UIProcess/ios/WKScrollView.mm (228353 => 228354)

--- branches/safari-605-branch/Source/WebKit/UIProcess/ios/WKScrollView.mm	2018-02-10 05:43:33 UTC (rev 228353)
+++ branches/safari-605-branch/Source/WebKit/UIProcess/ios/WKScrollView.mm	2018-02-10 05:43:36 UTC (rev 228354)
@@ -75,12 +75,23 @@
 return [super respondsToSelector:aSelector] || [_internalDelegate respondsToSelector:aSelector] || [_externalDelegate.get() respondsToSelector:aSelector];
 }
 
+static BOOL shouldForwardScrollViewDelegateMethodToExternalDelegate(SEL selector)
+{
+// We cannot forward viewForZoomingInScrollView: to the external delegate, because WebKit
+// owns the content of the scroll view, and depends on viewForZoomingInScrollView being the
+// content view. Any other view returned by the external delegate will break our behavior.
+if (sel_isEqual(selector, @selector(viewForZoomingInScrollView:)))
+return NO;
+
+return YES;
+}
+
 - (void)forwardInvocation:(NSInvocation *)anInvocation
 {
 auto externalDelegate = _externalDelegate.get();
 SEL aSelector = [anInvocation selector];
 BOOL internalDelegateWillRespond = [_internalDelegate respondsToSelector:aSelector];
-BOOL externalDelegateWillRespond = [externalDelegate respondsToSelector:aSelector];
+BOOL externalDelegateWillRespond = shouldForwardScrollViewDelegateMethodToExternalDelegate(aSelector) && [externalDelegate respondsToSelector:aSelector];
 
 if (internalDelegateWillRespond && externalDelegateWillRespond)
 [_internalDelegate _willInvokeUIScrollViewDelegateCallback];
@@ -100,7 +111,7 @@
 - (id)forwardingTargetForSelector:(SEL)aSelector
 {
 BOOL internalDelegateWillRespond = [_internalDelegate respondsToSelector:aSelector];
-BOOL externalDelegateWillRespond = [_externalDelegate.get() respondsToSelector:aSelector];
+BOOL externalDelegateWillRespond = shouldForwardScrollViewDelegateMethodToExternalDelegate(aSelector) && [_externalDelegate.get() respondsToSelector:aSelector];
 
 if (internalDelegateWillRespond && !externalDelegateWillRespond)
 return _internalDelegate;


Modified: branches/safari-605-branch/Tools/ChangeLog (228353 => 228354)

--- branches/safari-605-branch/Tools/ChangeLog	2018-02-10 05:43:33 UTC (rev 228353)
+++ branches/safari-605-branch/Tools/ChangeLog	

[webkit-changes] [228355] branches/safari-605-branch/Source/WebKit

[jmarcell]

Title: [228355] branches/safari-605-branch/Source/WebKit








Revision 228355
Author jmarc...@apple.com
Date 2018-02-09 21:43:38 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228257. rdar://problem/37408882

Modified Paths

branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp




Diff

Modified: branches/safari-605-branch/Source/WebKit/ChangeLog (228354 => 228355)

--- branches/safari-605-branch/Source/WebKit/ChangeLog	2018-02-10 05:43:36 UTC (rev 228354)
+++ branches/safari-605-branch/Source/WebKit/ChangeLog	2018-02-10 05:43:38 UTC (rev 228355)
@@ -1,5 +1,23 @@
 2018-02-09  Jason Marcell  
 
+Cherry-pick r228257. rdar://problem/37408882
+
+2018-02-07  Antti Koivisto   and Youenn Fablet  
+
+REGRESSION(r227758): Webpage fails to load due to crash in com.apple.WebKit: WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse + 267
+https://bugs.webkit.org/show_bug.cgi?id=182532
+
+
+Reviewed by Chris Dumez.
+
+No test case, don't know how to make one. The repro involves multipart HTTP streaming and details are hazy.
+We were calling a function that was WTFMoved away just a few lines above.
+
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
+
+2018-02-09  Jason Marcell  
+
 Cherry-pick r228253. rdar://problem/37408874
 
 2018-02-07  Tim Horton  


Modified: branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (228354 => 228355)

--- branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2018-02-10 05:43:36 UTC (rev 228354)
+++ branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2018-02-10 05:43:38 UTC (rev 228355)
@@ -746,18 +746,19 @@
 
 bool canShowMIMEType = webPage->canShowMIMEType(response.mimeType());
 
+WebCore::Frame* coreFrame = m_frame->coreFrame();
+auto* policyDocumentLoader = coreFrame ? coreFrame->loader().provisionalDocumentLoader() : nullptr;
+if (!policyDocumentLoader) {
+function(PolicyAction::Ignore);
+return;
+}
+
+Ref protector(*m_frame);
 uint64_t listenerID = m_frame->setUpPolicyListener(WTFMove(function), WebFrame::ForNavigationAction::No);
 bool receivedPolicyAction;
 PolicyAction policyAction;
 DownloadID downloadID;
 
-Ref protect(*m_frame);
-WebCore::Frame* coreFrame = m_frame->coreFrame();
-if (!coreFrame)
-return function(PolicyAction::Ignore);
-auto* policyDocumentLoader = coreFrame->loader().provisionalDocumentLoader();
-if (!policyDocumentLoader)
-return function(PolicyAction::Ignore);
 auto navigationID = static_cast(*policyDocumentLoader).navigationID();
 if (!webPage->sendSync(Messages::WebPageProxy::DecidePolicyForResponseSync(m_frame->frameID(), SecurityOriginData::fromFrame(coreFrame), navigationID, response, request, canShowMIMEType, listenerID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())), Messages::WebPageProxy::DecidePolicyForResponseSync::Reply(receivedPolicyAction, policyAction, downloadID), Seconds::infinity(), IPC::SendSyncOption::InformPlatformProcessWillSuspend)) {
 m_frame->didReceivePolicyDecision(listenerID, PolicyAction::Ignore, 0, { }, { });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228353] branches/safari-605-branch

[jmarcell]

Title: [228353] branches/safari-605-branch








Revision 228353
Author jmarc...@apple.com
Date 2018-02-09 21:43:33 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228240. rdar://problem/37408894

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/LayoutTests/editing/pasteboard/drag-files-to-editable-element-as-URLs-expected.txt
branches/safari-605-branch/LayoutTests/editing/pasteboard/drag-files-to-editable-element-as-URLs.html
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/editing/WebContentReader.cpp
branches/safari-605-branch/Source/WebCore/editing/WebContentReader.h
branches/safari-605-branch/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
branches/safari-605-branch/Tools/ChangeLog
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (228352 => 228353)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 05:07:56 UTC (rev 228352)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 05:43:33 UTC (rev 228353)
@@ -1,3 +1,21 @@
+2018-02-09  Jason Marcell  
+
+Cherry-pick r228240. rdar://problem/37408894
+
+2018-02-07  Wenson Hsieh  
+
+REGRESSION(r226396): File paths are inserted when dropping image files
+https://bugs.webkit.org/show_bug.cgi?id=182557
+
+
+Reviewed by Ryosuke Niwa.
+
+Tweak an existing layout test that drops a file into a contenteditable, to check that no text is inserted into
+the editable element after dropping.
+
+* editing/pasteboard/drag-files-to-editable-element-as-URLs-expected.txt:
+* editing/pasteboard/drag-files-to-editable-element-as-URLs.html:
+
 2018-02-09  Ryan Haddad  
 
 Work towards rdar://problem/36837397.


Modified: branches/safari-605-branch/LayoutTests/editing/pasteboard/drag-files-to-editable-element-as-URLs-expected.txt (228352 => 228353)

--- branches/safari-605-branch/LayoutTests/editing/pasteboard/drag-files-to-editable-element-as-URLs-expected.txt	2018-02-10 05:07:56 UTC (rev 228352)
+++ branches/safari-605-branch/LayoutTests/editing/pasteboard/drag-files-to-editable-element-as-URLs-expected.txt	2018-02-10 05:43:33 UTC (rev 228353)
@@ -1,4 +1,4 @@
-If we drag files onto an editable area, then attachments should be inserted into the editable area.
+If we drag files onto an editable area, then attachments should not be inserted into the editable area since attachment elements are disabled.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
@@ -6,6 +6,7 @@
 PASS window.HTMLAttachmentElement is undefined.
 PASS document.createElement("attachment") instanceof HTMLUnknownElement is true
 PASS editable.querySelector("attachment") is null
+PASS editable.textContent is ""
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: branches/safari-605-branch/LayoutTests/editing/pasteboard/drag-files-to-editable-element-as-URLs.html (228352 => 228353)

--- branches/safari-605-branch/LayoutTests/editing/pasteboard/drag-files-to-editable-element-as-URLs.html	2018-02-10 05:07:56 UTC (rev 228352)
+++ branches/safari-605-branch/LayoutTests/editing/pasteboard/drag-files-to-editable-element-as-URLs.html	2018-02-10 05:43:33 UTC (rev 228353)
@@ -6,7 +6,7 @@
 
 

[webkit-changes] [228361] trunk/PerformanceTests

[rniwa]

Title: [228361] trunk/PerformanceTests








Revision 228361
Author rn...@webkit.org
Date 2018-02-09 22:14:52 -0800 (Fri, 09 Feb 2018)


Log Message
Make run-perf-tests work with Speedometer 2.0 and re-enable the test
https://bugs.webkit.org/show_bug.cgi?id=182088

Reviewed by Antti Koivisto.

This patch updates the test harness to report new metrics of Speedometer 2.0.

Replaced the total time by the geometric mean of the time spent in each suite, and added scores
as a metric in addition to time. Also, updated the PerfTestRunner harness and the results template
to support "Score" metric with "pt" as its unit.

* Skipped: Unskipped the test.
* Speedometer/resources/benchmark-report.js:
(window.benchmarkClient.willStartFirstIteration..createTest): Added the unit as an optional argument
to report the score in addition to time. Also report the geomean of time instead of the total time.
(window.benchmarkClient.willStartFirstIteration): Report the geomean of time.
(window.benchmarkClient.didRunSuites): Record the entire measuredValues instead of just tests.
(window.benchmarkClient.didFinishLastIteration): Report the scores.

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Skipped
trunk/PerformanceTests/Speedometer/resources/benchmark-report.js




Diff

Modified: trunk/PerformanceTests/ChangeLog (228360 => 228361)

--- trunk/PerformanceTests/ChangeLog	2018-02-10 05:43:58 UTC (rev 228360)
+++ trunk/PerformanceTests/ChangeLog	2018-02-10 06:14:52 UTC (rev 228361)
@@ -1,3 +1,24 @@
+2018-02-09  Ryosuke Niwa  
+
+Make run-perf-tests work with Speedometer 2.0 and re-enable the test
+https://bugs.webkit.org/show_bug.cgi?id=182088
+
+Reviewed by Antti Koivisto.
+
+This patch updates the test harness to report new metrics of Speedometer 2.0.
+
+Replaced the total time by the geometric mean of the time spent in each suite, and added scores
+as a metric in addition to time. Also, updated the PerfTestRunner harness and the results template
+to support "Score" metric with "pt" as its unit.
+
+* Skipped: Unskipped the test.
+* Speedometer/resources/benchmark-report.js:
+(window.benchmarkClient.willStartFirstIteration..createTest): Added the unit as an optional argument
+to report the score in addition to time. Also report the geomean of time instead of the total time.
+(window.benchmarkClient.willStartFirstIteration): Report the geomean of time.
+(window.benchmarkClient.didRunSuites): Record the entire measuredValues instead of just tests.
+(window.benchmarkClient.didFinishLastIteration): Report the scores.
+
 2018-02-09  Ross Kirsling  
 
 Use REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR on any non-Windows port.


Modified: trunk/PerformanceTests/Skipped (228360 => 228361)

--- trunk/PerformanceTests/Skipped	2018-02-10 05:43:58 UTC (rev 228360)
+++ trunk/PerformanceTests/Skipped	2018-02-10 06:14:52 UTC (rev 228361)
@@ -82,7 +82,6 @@
 Layout/LineLayoutJapanese.html
 
 # Don't run the interactive runner. We run index.html
-Speedometer/index.html
 Speedometer/InteractiveRunner.html
 StyleBench/InteractiveRunner.html
 


Modified: trunk/PerformanceTests/Speedometer/resources/benchmark-report.js (228360 => 228361)

--- trunk/PerformanceTests/Speedometer/resources/benchmark-report.js	2018-02-10 05:43:58 UTC (rev 228360)
+++ trunk/PerformanceTests/Speedometer/resources/benchmark-report.js	2018-02-10 06:14:52 UTC (rev 228361)
@@ -26,21 +26,21 @@
 window.benchmarkClient = {
 iterationCount: 5, // Use 4 different instances of DRT/WTR to run 5 iterations.
 willStartFirstIteration: function (iterationCount) {
-createTest = function (name, aggregator, isLastTest) {
+createTest = function (name, aggregator, isLastTest, unit = 'ms') {
 return {
 customIterationCount: iterationCount,
 doNotIgnoreInitialRun: true,
 doNotMeasureMemoryUsage: true,
 continueTesting: !isLastTest,
-unit: 'ms',
+unit: unit,
 name: name,
 aggregator: aggregator};
 }
-PerfTestRunner.prepareToMeasureValuesAsync(createTest(null, 'Total'));
+PerfTestRunner.prepareToMeasureValuesAsync(createTest(null, 'Geometric'));
 },
 didRunSuites: function (measuredValues) {
-PerfTestRunner.measureValueAsync(measuredValues.total);
-valuesByIteration.push(measuredValues.tests);
+PerfTestRunner.measureValueAsync(measuredValues.geomean);
+valuesByIteration.push(measuredValues);
 },
 didFinishLastIteration: function () {
 document.head.removeChild(document.querySelector('style'));
@@ -53,9 +53,11 @@
 values.aggregator = aggregator;
 }
 

[webkit-changes] [228362] trunk/Source/WebInspectorUI

[mattbaker]

Title: [228362] trunk/Source/WebInspectorUI








Revision 228362
Author mattba...@apple.com
Date 2018-02-09 22:15:46 -0800 (Fri, 09 Feb 2018)


Log Message
Web Inspector: Canvas tab: tree selection abruptly changes when selecting a recording frame
https://bugs.webkit.org/show_bug.cgi?id=182667


Reviewed by Devin Rousso.

* UserInterface/Views/CanvasSidebarPanel.css:
(.sidebar > .panel.navigation.canvas > .content > .recording-content > .navigation-bar):
(.sidebar > .panel.navigation.canvas:not(.has-recordings) > .filter-bar,):
(.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.recording > .icon):
(.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.folder-icon > .icon):
(.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.folder-icon > .status):
(.sidebar > .panel.navigation.canvas > .content > .navigation-bar): Deleted.
(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.recording > .icon): Deleted.
(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.folder-icon > .icon): Deleted.
(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.folder-icon > .status): Deleted.
Style changes for the additional DOM element required to virtualize the recording tree outline.

* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel):
In order to be virtualized, the tree must be the only child of its parent.

(WI.CanvasSidebarPanel.prototype.set action):
Ensure that a frame tree element isn't deselected when the last action
in the frame becomes selected in the RecordingContentView.

(WI.CanvasSidebarPanel.prototype.shown):
Refresh the sidebar, as represented objects may have changed while hidden.

(WI.CanvasSidebarPanel.prototype._currentRepresentedObjectsDidChange):
Unset the recording when no valid represented objects are found, to
prevent a stale recording tree from being shown when viewing the overview.

(WI.CanvasSidebarPanel.prototype._canvasChanged):
(WI.CanvasSidebarPanel.prototype._recordingChanged):
(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
Moved toggling of the "has-recordings" style to _canvasChanged, since
the navigation bar should be hidden when no canvas exists.

* UserInterface/Views/CollectionContentView.js:
(WI.CollectionContentView.prototype.addContentViewForItem):
(WI.CollectionContentView.prototype.removeContentViewForItem):
Drive by fixes for child view visible state.

* UserInterface/Views/TreeOutline.css:
(.tree-outline:not(.large):matches(:focus, .force-focus) .item.selected .status .indeterminate-progress-spinner):
Make spinner easier to see against the selection background color.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js
trunk/Source/WebInspectorUI/UserInterface/Views/CollectionContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (228361 => 228362)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-02-10 06:14:52 UTC (rev 228361)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-02-10 06:15:46 UTC (rev 228362)
@@ -1,5 +1,55 @@
 2018-02-09  Matt Baker  
 
+Web Inspector: Canvas tab: tree selection abruptly changes when selecting a recording frame
+https://bugs.webkit.org/show_bug.cgi?id=182667
+
+
+Reviewed by Devin Rousso.
+
+* UserInterface/Views/CanvasSidebarPanel.css:
+(.sidebar > .panel.navigation.canvas > .content > .recording-content > .navigation-bar):
+(.sidebar > .panel.navigation.canvas:not(.has-recordings) > .filter-bar,):
+(.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.recording > .icon):
+(.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.folder-icon > .icon):
+(.sidebar > .panel.navigation.canvas > .content > .recording-content > .tree-outline .item.folder-icon > .status):
+(.sidebar > .panel.navigation.canvas > .content > .navigation-bar): Deleted.
+(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.recording > .icon): Deleted.
+(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.folder-icon > .icon): Deleted.
+(.sidebar > .panel.navigation.canvas > .content > .tree-outline .item.folder-icon > .status): Deleted.
+Style changes for the additional DOM element required to virtualize the recording tree outline.
+
+* UserInterface/Views/CanvasSidebarPanel.js:
+(WI.CanvasSidebarPanel):
+In order to be virtualized, the tree must be the only child of its parent.
+
+(WI.CanvasSidebarPanel.prototype.set action):
+Ensure that a frame tree element isn't deselected when 

[webkit-changes] [228364] branches/safari-605-branch

[jmarcell]

Title: [228364] branches/safari-605-branch








Revision 228364
Author jmarc...@apple.com
Date 2018-02-09 22:25:50 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228336. rdar://problem/37408902

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/LayoutTests/inspector/unit-tests/object-utilities-expected.txt
branches/safari-605-branch/LayoutTests/inspector/unit-tests/object-utilities.html
branches/safari-605-branch/Source/WebInspectorUI/ChangeLog
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Base/Utilities.js




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (228363 => 228364)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 06:25:46 UTC (rev 228363)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 06:25:50 UTC (rev 228364)
@@ -1,5 +1,20 @@
 2018-02-09  Jason Marcell  
 
+Cherry-pick r228336. rdar://problem/37408902
+
+2018-02-09  Matt Baker  
+
+Web Inspector: Object.shallowEqual always fails when comparing array property values
+https://bugs.webkit.org/show_bug.cgi?id=182634
+
+
+Reviewed by Devin Rousso.
+
+* inspector/unit-tests/object-utilities-expected.txt:
+* inspector/unit-tests/object-utilities.html:
+
+2018-02-09  Jason Marcell  
+
 Cherry-pick r228241. rdar://problem/37408896
 
 2018-02-07  Youenn Fablet  


Modified: branches/safari-605-branch/LayoutTests/inspector/unit-tests/object-utilities-expected.txt (228363 => 228364)

--- branches/safari-605-branch/LayoutTests/inspector/unit-tests/object-utilities-expected.txt	2018-02-10 06:25:46 UTC (rev 228363)
+++ branches/safari-605-branch/LayoutTests/inspector/unit-tests/object-utilities-expected.txt	2018-02-10 06:25:50 UTC (rev 228364)
@@ -9,6 +9,11 @@
 PASS: shallowEqual of equal objects should be true.
 PASS: shallowEqual of unequal objects should be false.
 PASS: shallowEqual of unequal objects should be false.
+PASS: shallowEqual of objects with similar arrays at the same key should be true.
+PASS: shallowEqual of objects with similar arrays at the same key should be true.
+PASS: shallowEqual of objects with similar arrays at the same key should be true.
+PASS: shallowEqual of objects with dissimilar arrays at the same key should be false.
+PASS: shallowEqual of objects with dissimilar arrays at the same key should be false.
 PASS: shallowEqual of an object and null should be false.
 PASS: shallowEqual of an object and non-object should be false.
 PASS: shallowEqual of a non-object with itself should be false.


Modified: branches/safari-605-branch/LayoutTests/inspector/unit-tests/object-utilities.html (228363 => 228364)

--- branches/safari-605-branch/LayoutTests/inspector/unit-tests/object-utilities.html	2018-02-10 06:25:46 UTC (rev 228363)
+++ branches/safari-605-branch/LayoutTests/inspector/unit-tests/object-utilities.html	2018-02-10 06:25:50 UTC (rev 228364)
@@ -26,6 +26,13 @@
 InspectorTest.expectThat(!Object.shallowEqual(obj1, obj3), "shallowEqual of unequal objects should be false.");
 InspectorTest.expectThat(!Object.shallowEqual(obj3, obj1), "shallowEqual of unequal objects should be false.");
 
+InspectorTest.expectThat(Object.shallowEqual({x: []}, {x: []}), "shallowEqual of objects with similar arrays at the same key should be true.");
+InspectorTest.expectThat(Object.shallowEqual({x: new Array}, {x: new Array}), "shallowEqual of objects with similar arrays at the same key should be true.");
+InspectorTest.expectThat(Object.shallowEqual({x: [1]}, {x: [1]}), "shallowEqual of objects with similar arrays at the same key should be true.");
+
+InspectorTest.expectThat(!Object.shallowEqual({x: [1]}, {x: []}), "shallowEqual of objects with dissimilar arrays at the same key should be false.");
+InspectorTest.expectThat(!Object.shallowEqual({x: new Array(1)}, {x: new Array}), "shallowEqual of objects with dissimilar arrays at the same key should be false.");
+
 InspectorTest.expectThat(!Object.shallowEqual({}, null), "shallowEqual of an object and null should be false.");
 InspectorTest.expectThat(!Object.shallowEqual({}, 1.23), "shallowEqual of an object and non-object should be false.");
 


Modified: branches/safari-605-branch/Source/WebInspectorUI/ChangeLog (228363 => 228364)

--- branches/safari-605-branch/Source/WebInspectorUI/ChangeLog	2018-02-10 06:25:46 UTC (rev 228363)
+++ branches/safari-605-branch/Source/WebInspectorUI/ChangeLog	2018-02-10 06:25:50 UTC (rev 228364)
@@ -1,5 +1,24 @@
 2018-02-09  Jason Marcell  
 
+Cherry-pick r228336. rdar://problem/37408902
+
+2018-02-09  Matt Baker  
+
+Web Inspector: Object.shallowEqual always fails when comparing array property values
+   

[webkit-changes] [228363] branches/safari-605-branch

[jmarcell]

Title: [228363] branches/safari-605-branch








Revision 228363
Author jmarc...@apple.com
Date 2018-02-09 22:25:46 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228241. rdar://problem/37408896

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/loader/CrossOriginPreflightChecker.cpp


Added Paths

branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.js
branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.serviceworker-expected.txt
branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.serviceworker.html




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (228362 => 228363)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 06:15:46 UTC (rev 228362)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 06:25:46 UTC (rev 228363)
@@ -1,5 +1,24 @@
 2018-02-09  Jason Marcell  
 
+Cherry-pick r228241. rdar://problem/37408896
+
+2018-02-07  Youenn Fablet  
+
+ASSERTION FAILED: m_timeOrigin in Performance::Performance()
+https://bugs.webkit.org/show_bug.cgi?id=182558
+
+
+Reviewed by Chris Dumez.
+
+Make use of WPT cors-preflight-star.any.js test in service worker.
+This test should be removed once WPT will run any.js tests in service workers as well as workers and window.
+
+* http/wpt/service-workers/cors-preflight-star.any.js: Added.
+* http/wpt/service-workers/cors-preflight-star.any.serviceworker-expected.txt: Added.
+* http/wpt/service-workers/cors-preflight-star.any.serviceworker.html: Added.
+
+2018-02-09  Jason Marcell  
+
 Cherry-pick r228340. rdar://problem/37408869
 
 2018-02-08  Wenson Hsieh  


Added: branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.js (0 => 228363)

--- branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.js	(rev 0)
+++ branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.js	2018-02-10 06:25:46 UTC (rev 228363)
@@ -0,0 +1,44 @@
+// META: script=/fetch/api/resources/utils.js
+// META: script=/common/get-host-info.sub.js
+
+const url = "" + dirname(location.pathname) + RESOURCES_DIR + "preflight.py",
+  origin = location.origin // assuming an ASCII origin
+
+function preflightTest(succeeds, withCredentials, allowMethod, allowHeader, useMethod, useHeader) {
+  return promise_test(t => {
+let testURL = url + "?",
+requestInit = {}
+if (withCredentials) {
+  testURL += "origin=" + origin + "&"
+  testURL += "credentials&"
+  requestInit.credentials = "include"
+}
+if (useMethod) {
+  requestInit.method = useMethod
+}
+if (useHeader.length > 0) {
+  requestInit.headers = [useHeader]
+}
+testURL += "allow_methods=" + allowMethod + "&"
+testURL += "allow_headers=" + allowHeader + "&"
+
+if (succeeds) {
+  return fetch(testURL, requestInit).then(resp => {
+assert_equals(resp.headers.get("x-origin"), origin)
+  })
+} else {
+  return promise_rejects(t, new TypeError(), fetch(testURL, requestInit))
+}
+  }, "CORS that " + (succeeds ? "succeeds" : "fails") + " with credentials: " + withCredentials + "; method: " + useMethod + " (allowed: " + allowMethod + "); header: " + useHeader + " (allowed: " + allowHeader + ")")
+}
+
+preflightTest(true, false, "get", "x-test", "GET", ["X-Test", "1"])
+preflightTest(true, false, "*", "x-test", "SUPER", ["X-Test", "1"])
+preflightTest(true, false, "*", "*", "OK", ["X-Test", "1"])
+preflightTest(false, true, "*", "*", "OK", ["X-Test", "1"])
+preflightTest(false, true, "*", "", "PUT", [])
+preflightTest(true, true, "PUT", "*", "PUT", [])
+preflightTest(false, true, "put", "*", "PUT", [])
+preflightTest(false, true, "get", "*", "GET", ["X-Test", "1"])
+preflightTest(false, true, "*", "*", "GET", ["X-Test", "1"])
+preflightTest(true, true, "*", "*", "*", ["*", "1"])


Added: branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.serviceworker-expected.txt (0 => 228363)

--- branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.serviceworker-expected.txt	(rev 0)
+++ branches/safari-605-branch/LayoutTests/http/wpt/service-workers/cors-preflight-star.any.serviceworker-expected.txt	2018-02-10 06:25:46 UTC (rev 228363)
@@ -0,0 +1,13 @@
+
+PASS Setting up tests 
+FAIL CORS that succeeds with credentials: false; method: GET (allowed: get); header: X-Test,1 (allowed: x-test) promise_test: Unhandled rejection with value: object "TypeError: Preflight response is not successful"
+FAIL 

[webkit-changes] [228359] branches/safari-605-branch/Source/WebCore

[jmarcell]

Title: [228359] branches/safari-605-branch/Source/WebCore








Revision 228359
Author jmarc...@apple.com
Date 2018-02-09 21:43:52 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228342. rdar://problem/37408891

Modified Paths

branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp




Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (228358 => 228359)

--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-02-10 05:43:50 UTC (rev 228358)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-02-10 05:43:52 UTC (rev 228359)
@@ -1,5 +1,29 @@
 2018-02-09  Jason Marcell  
 
+Cherry-pick r228342. rdar://problem/37408891
+
+2018-02-09  Andy Estes  
+
+[Payment Request] Apple Pay sheet does not dismiss when calling complete() with result "unknown" or "fail"
+https://bugs.webkit.org/show_bug.cgi?id=182658
+
+
+Reviewed by Brady Eidson.
+
+When PaymentResponse::complete() is called with a result of "unknown" or "fail", we should
+treat this as a fatal error and dismiss the Apple Pay sheet. However, we were adding an
+error with code "unknown" to the authorization result, which PassKit interprets as a
+non-fatal error. Instead, we should not set any errors and just use a status code of
+PaymentAuthorizationStatus::Failure, which PassKit interprets as a fatal error, dismissing
+the sheet.
+
+No test possible.
+
+* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
+(WebCore::ApplePayPaymentHandler::complete):
+
+2018-02-09  Jason Marcell  
+
 Cherry-pick r228331. rdar://problem/37408871
 
 2018-02-09  Andy Estes  


Modified: branches/safari-605-branch/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp (228358 => 228359)

--- branches/safari-605-branch/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp	2018-02-10 05:43:50 UTC (rev 228358)
+++ branches/safari-605-branch/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp	2018-02-10 05:43:52 UTC (rev 228359)
@@ -409,7 +409,6 @@
 case PaymentComplete::Fail:
 case PaymentComplete::Unknown:
 authorizationResult.status = PaymentAuthorizationStatus::Failure;
-authorizationResult.errors.append({ PaymentError::Code::Unknown, { }, std::nullopt });
 break;
 case PaymentComplete::Success:
 authorizationResult.status = PaymentAuthorizationStatus::Success;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228360] branches/safari-605-branch

[jmarcell]

Title: [228360] branches/safari-605-branch








Revision 228360
Author jmarc...@apple.com
Date 2018-02-09 21:43:58 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228340. rdar://problem/37408869

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/LayoutTests/editing/pasteboard/data-transfer-item-list-add-file-multiple-times-expected.txt
branches/safari-605-branch/LayoutTests/editing/pasteboard/data-transfer-item-list-add-file-on-copy-expected.txt
branches/safari-605-branch/LayoutTests/editing/pasteboard/data-transfer-item-list-add-file-on-drag-expected.txt
branches/safari-605-branch/LayoutTests/editing/pasteboard/paste-image-does-not-reveal-file-url-expected.txt
branches/safari-605-branch/LayoutTests/editing/pasteboard/paste-image-does-not-reveal-file-url.html
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/dom/DataTransfer.cpp
branches/safari-605-branch/Source/WebCore/dom/DataTransfer.h
branches/safari-605-branch/Source/WebCore/platform/Pasteboard.h
branches/safari-605-branch/Source/WebCore/platform/StaticPasteboard.h
branches/safari-605-branch/Source/WebCore/platform/gtk/PasteboardGtk.cpp
branches/safari-605-branch/Source/WebCore/platform/ios/PasteboardIOS.mm
branches/safari-605-branch/Source/WebCore/platform/mac/PasteboardMac.mm
branches/safari-605-branch/Source/WebCore/platform/win/PasteboardWin.cpp
branches/safari-605-branch/Source/WebCore/platform/wpe/PasteboardWPE.cpp
branches/safari-605-branch/Tools/ChangeLog
branches/safari-605-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm
branches/safari-605-branch/Tools/TestWebKitAPI/cocoa/TestWKWebView.h


Added Paths

branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (228359 => 228360)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 05:43:52 UTC (rev 228359)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 05:43:58 UTC (rev 228360)
@@ -1,5 +1,33 @@
 2018-02-09  Jason Marcell  
 
+Cherry-pick r228340. rdar://problem/37408869
+
+2018-02-08  Wenson Hsieh  
+
+Pasting from Excel no longer provides text/html data
+https://bugs.webkit.org/show_bug.cgi?id=182636
+
+
+Reviewed by Ryosuke Niwa.
+
+Rebaseline some existing layout tests. We now expose "text/html" alongside "Files" on DataTransfer.types() in
+some circumstances. This also provides some test coverage for ensuring that the paste codepath iOS allows the
+page to request HTML, even if there are files on the pasteboard. See the WebCore ChangeLog for more detail.
+
+* editing/pasteboard/data-transfer-item-list-add-file-multiple-times-expected.txt:
+* editing/pasteboard/data-transfer-item-list-add-file-on-copy-expected.txt:
+* editing/pasteboard/data-transfer-item-list-add-file-on-drag-expected.txt:
+
+Adjust test expectations for the additional "text/html" type.
+
+* editing/pasteboard/paste-image-does-not-reveal-file-url-expected.txt:
+* editing/pasteboard/paste-image-does-not-reveal-file-url.html:
+
+Instead of checking that types is [ "Files" ], just check that types contains "Files". On iOS, copying a
+selected image does not also copy HTML, but on macOS it does; this covers both cases.
+
+2018-02-09  Jason Marcell  
+
 Cherry-pick r228331. rdar://problem/37408871
 
 2018-02-09  Andy Estes  


Modified: branches/safari-605-branch/LayoutTests/editing/pasteboard/data-transfer-item-list-add-file-multiple-times-expected.txt (228359 => 228360)

--- branches/safari-605-branch/LayoutTests/editing/pasteboard/data-transfer-item-list-add-file-multiple-times-expected.txt	2018-02-10 05:43:52 UTC (rev 228359)
+++ branches/safari-605-branch/LayoutTests/editing/pasteboard/data-transfer-item-list-add-file-multiple-times-expected.txt	2018-02-10 05:43:58 UTC (rev 228360)
@@ -247,7 +247,8 @@
 6. After adding two files and some string data again
 {
 "data": {
-"Files": ""
+"Files": "",
+"text/html": "some styled text"
 },
 "items": [
 {
@@ -296,7 +297,8 @@
 7. After removing at index 2
 {
 "data": {
-"Files": ""
+"Files": "",
+"text/html": "some styled text"
 },
 "items": [
 {
@@ -341,7 +343,8 @@
 8. After removing at index 2
 {
 "data": {
-"Files": ""
+"Files": "",
+"text/html": "some styled text"
 },
 "items": [
 {


Modified: 

[webkit-changes] [228358] branches/safari-605-branch

[jmarcell]

Title: [228358] branches/safari-605-branch








Revision 228358
Author jmarc...@apple.com
Date 2018-02-09 21:43:50 -0800 (Fri, 09 Feb 2018)


Log Message
Cherry-pick r228331. rdar://problem/37408871

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt
branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (228357 => 228358)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 05:43:47 UTC (rev 228357)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-02-10 05:43:50 UTC (rev 228358)
@@ -1,5 +1,19 @@
 2018-02-09  Jason Marcell  
 
+Cherry-pick r228331. rdar://problem/37408871
+
+2018-02-09  Andy Estes  
+
+[Payment Request] Crash in PaymentRequest::canMakePayment() when Apple Pay payment method data is missing required fields
+https://bugs.webkit.org/show_bug.cgi?id=182631
+
+Reviewed by Mark Lam.
+
+* http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt:
+* http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:
+
+2018-02-09  Jason Marcell  
+
 Cherry-pick r228240. rdar://problem/37408894
 
 2018-02-07  Wenson Hsieh  


Modified: branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt (228357 => 228358)

--- branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt	2018-02-10 05:43:47 UTC (rev 228357)
+++ branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt	2018-02-10 05:43:50 UTC (rev 228358)
@@ -3,6 +3,7 @@
 PASS If request.[[state]] is "interactive", then return a promise rejected with an "InvalidStateError" DOMException. 
 PASS If request.[[state]] is "closed", then return a promise rejected with an "InvalidStateError" DOMException. 
 PASS If payment method identifier and serialized parts are supported, resolve promise with true. 
+PASS If a payment method identifier is supported but its serialized parts are not, resolve promise with false. 
 PASS If payment method identifier is unknown, resolve promise with false. 
 PASS Optionally, at the user agent's discretion, return a promise rejected with a "NotAllowedError" DOMException. 
 


Modified: branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html (228357 => 228358)

--- branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html	2018-02-10 05:43:47 UTC (rev 228357)
+++ branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/payment-request-canmakepayment-method.https.html	2018-02-10 05:43:50 UTC (rev 228358)
@@ -10,7 +10,7 @@
 

[webkit-changes] [228316] trunk/Source/WebCore

[commit-queue]

Title: [228316] trunk/Source/WebCore








Revision 228316
Author commit-qu...@webkit.org
Date 2018-02-09 04:11:10 -0800 (Fri, 09 Feb 2018)


Log Message
[EME][GStreamer] Add support for encrypted caps in GStreamerUtilities
https://bugs.webkit.org/show_bug.cgi?id=181990

Patch by Yacine Bandou  on 2018-02-09
Reviewed by Xabier Rodriguez-Calvar.

Add the support of encrypted caps in GStreamerUtilities.
Refactor the manner that the caps are handled, such as how to extract the resolution
from the video caps or how to check if the caps are encrypted.

The attachTrack function in PlaybackPipeline doesn't need the "structure" parameter,
it is already included in the "caps" parameter.

Replace the "mediaType" parameter by the "caps" parameter in reattachTrack function,
it allows to use the new functions that handle the caps in GStreamerUtilities.

Tests:
media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html
media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html

* platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::getVideoSizeAndFormatFromCaps): Add the support of video encrypted caps.
(WebCore::getVideoResolutionFromCaps):
(WebCore::capsMediaType):
(WebCore::doCapsHaveType):
(WebCore::areEncryptedCaps): Add a new functions in order to handle the caps properly.
* platform/graphics/gstreamer/GStreamerUtilities.h:
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
* platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp:
(WebCore::GStreamerMediaDescription::codec const):
(WebCore::GStreamerMediaDescription::isVideo const):
(WebCore::GStreamerMediaDescription::isAudio const):
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
* platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
(WebCore::PlaybackPipeline::attachTrack):
(WebCore::PlaybackPipeline::reattachTrack):
* platform/graphics/gstreamer/mse/PlaybackPipeline.h:
* platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcUpdatePresentationSize): Refactor some parts by using the new added functions.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h
trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.h
trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.h
trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (228315 => 228316)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 09:14:59 UTC (rev 228315)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 12:11:10 UTC (rev 228316)
@@ -1,3 +1,46 @@
+2018-02-09  Yacine Bandou  
+
+[EME][GStreamer] Add support for encrypted caps in GStreamerUtilities
+https://bugs.webkit.org/show_bug.cgi?id=181990
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Add the support of encrypted caps in GStreamerUtilities.
+Refactor the manner that the caps are handled, such as how to extract the resolution
+from the video caps or how to check if the caps are encrypted.
+
+The attachTrack function in PlaybackPipeline doesn't need the "structure" parameter,
+it is already included in the "caps" parameter.
+
+Replace the "mediaType" parameter by the "caps" parameter in reattachTrack function,
+it allows to use the new functions that handle the caps in GStreamerUtilities.
+
+Tests:
+media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html
+media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html
+
+* platform/graphics/gstreamer/GStreamerUtilities.cpp:
+(WebCore::getVideoSizeAndFormatFromCaps): Add the support of video encrypted caps.
+(WebCore::getVideoResolutionFromCaps):
+(WebCore::capsMediaType):
+(WebCore::doCapsHaveType):
+(WebCore::areEncryptedCaps): Add a new functions in order to handle the caps properly.
+* platform/graphics/gstreamer/GStreamerUtilities.h:
+* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
+* platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp:
+(WebCore::GStreamerMediaDescription::codec const):
+(WebCore::GStreamerMediaDescription::isVideo const):
+

[webkit-changes] [228313] trunk/Source/WebCore

[antti]

Title: [228313] trunk/Source/WebCore








Revision 228313
Author an...@apple.com
Date 2018-02-09 01:11:05 -0800 (Fri, 09 Feb 2018)


Log Message
Move compiled selectors to StyleRule
https://bugs.webkit.org/show_bug.cgi?id=182602

Reviewed by Zalan Bujtas.

Currently they are owned by RuleData. Several RuleData objects can refer to the same StyleRule, requiring recompilation.
Compiled selectors are context-independent so they can be shared between all clients.

* WebCore.xcodeproj/project.pbxproj:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::listSize const):

Compute the number of complex selectors on the list.

* css/CSSSelectorList.h:
* css/DocumentRuleSets.cpp:
(WebCore::makeRuleSet):
(WebCore::DocumentRuleSets::classInvalidationRuleSets const):

Pass around list index along with the selector index (compiled selectors are found by list index).

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
* css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
* css/RuleSet.h:
(WebCore::RuleData::compilationStatus const): Deleted.
(WebCore::RuleData::compiledSelectorCodeRef const): Deleted.
(WebCore::RuleData::setCompiledSelector const): Deleted.
(WebCore::RuleData::~RuleData): Deleted.
(WebCore::RuleData::compiledSelectorUsed const): Deleted.
* css/StyleRule.cpp:
(WebCore::StyleRule::StyleRule):
* css/StyleRule.h:

Add CompiledSelector member.

* cssjit/CompiledSelector.h: Added.

Move to a header of its own to keeps dependencies simple.

(WebCore::SelectorCompilationStatus::SelectorCompilationStatus):
(WebCore::SelectorCompilationStatus::operator Status const):
* cssjit/SelectorCompiler.h:
(): Deleted.
(WebCore::SelectorCompilationStatus::SelectorCompilationStatus): Deleted.
(WebCore::SelectorCompilationStatus::operator Status const): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/css/CSSSelectorList.cpp
trunk/Source/WebCore/css/CSSSelectorList.h
trunk/Source/WebCore/css/DocumentRuleSets.cpp
trunk/Source/WebCore/css/ElementRuleCollector.cpp
trunk/Source/WebCore/css/RuleFeature.cpp
trunk/Source/WebCore/css/RuleFeature.h
trunk/Source/WebCore/css/RuleSet.cpp
trunk/Source/WebCore/css/RuleSet.h
trunk/Source/WebCore/css/StyleRule.cpp
trunk/Source/WebCore/css/StyleRule.h
trunk/Source/WebCore/cssjit/SelectorCompiler.h


Added Paths

trunk/Source/WebCore/cssjit/CompiledSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (228312 => 228313)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 07:31:16 UTC (rev 228312)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 09:11:05 UTC (rev 228313)
@@ -1,3 +1,53 @@
+2018-02-09  Antti Koivisto  
+
+Move compiled selectors to StyleRule
+https://bugs.webkit.org/show_bug.cgi?id=182602
+
+Reviewed by Zalan Bujtas.
+
+Currently they are owned by RuleData. Several RuleData objects can refer to the same StyleRule, requiring recompilation.
+Compiled selectors are context-independent so they can be shared between all clients.
+
+* WebCore.xcodeproj/project.pbxproj:
+* css/CSSSelectorList.cpp:
+(WebCore::CSSSelectorList::listSize const):
+
+Compute the number of complex selectors on the list.
+
+* css/CSSSelectorList.h:
+* css/DocumentRuleSets.cpp:
+(WebCore::makeRuleSet):
+(WebCore::DocumentRuleSets::classInvalidationRuleSets const):
+
+Pass around list index along with the selector index (compiled selectors are found by list index).
+
+* css/ElementRuleCollector.cpp:
+(WebCore::ElementRuleCollector::ruleMatches):
+* css/RuleSet.cpp:
+(WebCore::RuleData::RuleData):
+* css/RuleSet.h:
+(WebCore::RuleData::compilationStatus const): Deleted.
+(WebCore::RuleData::compiledSelectorCodeRef const): Deleted.
+(WebCore::RuleData::setCompiledSelector const): Deleted.
+(WebCore::RuleData::~RuleData): Deleted.
+(WebCore::RuleData::compiledSelectorUsed const): Deleted.
+* css/StyleRule.cpp:
+(WebCore::StyleRule::StyleRule):
+* css/StyleRule.h:
+
+Add CompiledSelector member.
+
+* cssjit/CompiledSelector.h: Added.
+
+Move to a header of its own to keeps dependencies simple.
+
+(WebCore::SelectorCompilationStatus::SelectorCompilationStatus):
+(WebCore::SelectorCompilationStatus::operator Status const):
+* cssjit/SelectorCompiler.h:
+(): Deleted.
+(WebCore::SelectorCompilationStatus::SelectorCompilationStatus): Deleted.
+(WebCore::SelectorCompilationStatus::operator Status const): Deleted.
+
 2018-02-08  Antoine Quint  
 
 [Web Animations] Always expose "composite" in output of getKeyframes()


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (228312 => 228313)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-02-09 

[webkit-changes] [228314] trunk/Tools

[philn]

Title: [228314] trunk/Tools








Revision 228314
Author ph...@webkit.org
Date 2018-02-09 01:12:11 -0800 (Fri, 09 Feb 2018)


Log Message
[JHBuild] Update Mesa to version 17
https://bugs.webkit.org/show_bug.cgi?id=182599

Reviewed by Carlos Alberto Lopez Perez.

* gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Removed Paths

trunk/Tools/gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch




Diff

Modified: trunk/Tools/ChangeLog (228313 => 228314)

--- trunk/Tools/ChangeLog	2018-02-09 09:11:05 UTC (rev 228313)
+++ trunk/Tools/ChangeLog	2018-02-09 09:12:11 UTC (rev 228314)
@@ -1,3 +1,12 @@
+2018-02-09  Philippe Normand  
+
+[JHBuild] Update Mesa to version 17
+https://bugs.webkit.org/show_bug.cgi?id=182599
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.
+
 2018-02-08  Chris Dumez  
 
 There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld


Modified: trunk/Tools/gtk/jhbuild.modules (228313 => 228314)

--- trunk/Tools/gtk/jhbuild.modules	2018-02-09 09:11:05 UTC (rev 228313)
+++ trunk/Tools/gtk/jhbuild.modules	2018-02-09 09:12:11 UTC (rev 228314)
@@ -322,7 +322,7 @@
 
   
 
-+ repo="xorg"
 hash="sha256:a732502f1db000cf36a376cd0c010ffdbf32ecdd7f1fa08ba7f5bdf9601cc197"
 md5sum="3e4ff034a331aed2322b078694a8">
@@ -335,18 +335,18 @@
  autogen-sh="configure"
  autogenargs="--disable-documentation">
 wayland-server.pc
-+ repo="wayland.freedesktop.org"
-hash="sha256:d6b4135cba0188abcb7275513c72dede751d6194f6edc5b82183a3ba8b821ab1"/>
+hash="sha256:ed80cabc0961a759a42092e2c39aabfc1ec9a13c86c98bbe2b812f008da27ab8"/>
   
 
 autogen-sh="configure">
-+ 	repo="wayland.freedesktop.org"
-	hash="sha256:635f2a937d318f1fecb97b54074ca211486e38af943868dd0fa82ea38d091c1f"/>
+	hash="sha256:3b19e8a9e1e19474756a7069db23b90ca9b8ebb438448c6063b4a7fc89b7c8b2"/>
   
 
   @@ -361,12 +361,10 @@
   
   
 
-+ repo="wayland.freedesktop.org"
-hash="sha256:ac7ac2a32e3b9f50131fccded5d2326bd36b2226712d90b61999118a09af5033">
-  
-
+hash="sha256:cde1d55e8dd70c3cbb3d1ec72f60e6041579caa1d6a262bd9c35e93723a5"/>
   
 
   
@@ -383,9 +381,9 @@
 
   
 libdrm.pc
-+ repo="dri.freedesktop.org"
-hash="sha256:71960ac8bde7d710992b1bc8879935e8300a870c36bd06f22412d0447e3d96c4"/>
+hash="sha256:629f9782aabbb4809166de5f24d26fe0766055255038f16935602d89f136a02e"/>
   
 
   @@ -395,10 +393,10 @@
 
 -version="11.0.6"
-module="/archive/older-versions/11.x/${version}/mesa-${version}.tar.xz"
+version="17.3.3"
+module="/archive/mesa-${version}.tar.xz"
 repo="mesa.freedesktop.org"
-hash="sha256:8340e64cdc91999840404c211496f3de38e7b4cb38db34e2f72f1642c5134760">
+hash="sha256:41bac5de0ef6adc1f41a1ec0f80c19e361298ce02fa81b5f9ba4fdca33a9379b">
 
 
   


Deleted: trunk/Tools/gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch (228313 => 228314)

--- trunk/Tools/gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch	2018-02-09 09:11:05 UTC (rev 228313)
+++ trunk/Tools/gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch	2018-02-09 09:12:11 UTC (rev 228314)
@@ -1,58 +0,0 @@
-From c950667e87dc175bd2741a51460ebd3e29a57c92 Mon Sep 17 00:00:00 2001
-From: Vincent Abriou 
-Date: Wed, 5 Oct 2016 16:14:07 +0200
-Subject: [PATCH] libweston: include weston-egl-ext.h in drm, x11 and wayland
- compositor
-
-As to what is done for gl-renderer.c, weston-egl-ext.h should be
-include in compositor-drm.c, compositor-x11.c and compositor-wayland.c.
-This fix building issue with GPU that does not have EGL_PLATFORM_xxx_KHR
-in their extension header file eglext.h.
-
-Signed-off-by: Vincent Abriou 
-Reviewed-by: Daniel Stone 

- libweston/compositor-drm.c | 1 +
- libweston/compositor-wayland.c | 1 +
- libweston/compositor-x11.c | 1 +
- 3 files changed, 3 insertions(+)
-
-diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
-index 567240f9..f61e3d9c 100644
 a/libweston/compositor-drm.c
-+++ b/libweston/compositor-drm.c
-@@ -52,6 +52,7 @@
- #include "shared/helpers.h"
- #include "shared/timespec-util.h"
- #include "gl-renderer.h"
-+#include "weston-egl-ext.h"
- #include "pixman-renderer.h"
- #include "libbacklight.h"
- #include "libinput-seat.h"
-diff --git a/libweston/compositor-wayland.c 

[webkit-changes] [228315] trunk

[philn]

Title: [228315] trunk








Revision 228315
Author ph...@webkit.org
Date 2018-02-09 01:14:59 -0800 (Fri, 09 Feb 2018)


Log Message
[GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
https://bugs.webkit.org/show_bug.cgi?id=176802

Source/WebCore:

Reviewed by Xabier Rodriguez Calvar.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): Prevent the player from loading animated gifs.

Tools:

Reviewed by Xabier Rodriguez-Calvar.

* gstreamer/jhbuild.modules:
* gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Tools/ChangeLog
trunk/Tools/gstreamer/jhbuild.modules


Added Paths

trunk/Tools/gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch




Diff

Modified: trunk/Source/WebCore/ChangeLog (228314 => 228315)

--- trunk/Source/WebCore/ChangeLog	2018-02-09 09:12:11 UTC (rev 228314)
+++ trunk/Source/WebCore/ChangeLog	2018-02-09 09:14:59 UTC (rev 228315)
@@ -1,3 +1,13 @@
+2018-02-09  Philippe Normand  
+
+[GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
+https://bugs.webkit.org/show_bug.cgi?id=176802
+
+Reviewed by Xabier Rodriguez Calvar.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::load): Prevent the player from loading animated gifs.
+
 2018-02-09  Antti Koivisto  
 
 Move compiled selectors to StyleRule


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (228314 => 228315)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2018-02-09 09:12:11 UTC (rev 228314)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2018-02-09 09:14:59 UTC (rev 228315)
@@ -233,6 +233,14 @@
 
 void MediaPlayerPrivateGStreamer::load(const String& urlString)
 {
+// FIXME: This method is still called even if supportsType() returned
+// IsNotSupported. This would deserve more investigation but meanwhile make
+// sure we don't ever try to play animated gif assets.
+if (m_player->contentMIMEType() == "image/gif") {
+loadingFailed(MediaPlayer::FormatError);
+return;
+}
+
 if (!MediaPlayerPrivateGStreamerBase::initializeGStreamerAndRegisterWebKitElements())
 return;
 


Modified: trunk/Tools/ChangeLog (228314 => 228315)

--- trunk/Tools/ChangeLog	2018-02-09 09:12:11 UTC (rev 228314)
+++ trunk/Tools/ChangeLog	2018-02-09 09:14:59 UTC (rev 228315)
@@ -1,5 +1,15 @@
 2018-02-09  Philippe Normand  
 
+[GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
+https://bugs.webkit.org/show_bug.cgi?id=176802
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+* gstreamer/jhbuild.modules:
+* gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.
+
+2018-02-09  Philippe Normand  
+
 [JHBuild] Update Mesa to version 17
 https://bugs.webkit.org/show_bug.cgi?id=182599
 


Modified: trunk/Tools/gstreamer/jhbuild.modules (228314 => 228315)

--- trunk/Tools/gstreamer/jhbuild.modules	2018-02-09 09:12:11 UTC (rev 228314)
+++ trunk/Tools/gstreamer/jhbuild.modules	2018-02-09 09:14:59 UTC (rev 228315)
@@ -77,6 +77,7 @@
  repo="gstreamer"
 hash="sha256:649f49bec60892d47ee6731b92266974c723554da1c6649f21296097715eb957">
+  
   
   
   


Added: trunk/Tools/gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch (0 => 228315)

--- trunk/Tools/gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch	(rev 0)
+++ trunk/Tools/gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch	2018-02-09 09:14:59 UTC (rev 228315)
@@ -0,0 +1,30 @@
+From c7a172517deb7ca8920b6c910998cfecd8b1893d Mon Sep 17 00:00:00 2001
+From: Mathieu Duponchelle 
+Date: Tue, 13 Jun 2017 18:51:32 +0200
+Subject: [PATCH] gstgdkpixbufdec: stop pretending to decode gifs.
+
+If you can't decode an animated gif, you can't decode a gif,
+so stop squatting GST_RANK_SECONDARY for that format, libav
+does a better job.
+

[webkit-changes] [228317] trunk/Source/bmalloc

[clopez]

Title: [228317] trunk/Source/bmalloc








Revision 228317
Author clo...@igalia.com
Date 2018-02-09 05:37:40 -0800 (Fri, 09 Feb 2018)


Log Message
Fix build for !BCPU(X86_64) after r228306
https://bugs.webkit.org/show_bug.cgi?id=182563

Unreviewed build fix.

* bmalloc/Algorithm.h:

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Algorithm.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (228316 => 228317)

--- trunk/Source/bmalloc/ChangeLog	2018-02-09 12:11:10 UTC (rev 228316)
+++ trunk/Source/bmalloc/ChangeLog	2018-02-09 13:37:40 UTC (rev 228317)
@@ -1,3 +1,12 @@
+2018-02-09  Carlos Alberto Lopez Perez  
+
+Fix build for !BCPU(X86_64) after r228306
+https://bugs.webkit.org/show_bug.cgi?id=182563
+
+Unreviewed build fix.
+
+* bmalloc/Algorithm.h:
+
 2018-02-08  Filip Pizlo  
 
 Experiment with alternative implementation of memcpy/memset


Modified: trunk/Source/bmalloc/bmalloc/Algorithm.h (228316 => 228317)

--- trunk/Source/bmalloc/bmalloc/Algorithm.h	2018-02-09 12:11:10 UTC (rev 228316)
+++ trunk/Source/bmalloc/bmalloc/Algorithm.h	2018-02-09 13:37:40 UTC (rev 228317)
@@ -34,6 +34,10 @@
 #include 
 #include 
 
+#if !BCPU(X86_64)
+#include 
+#endif
+
 namespace bmalloc {
 
 // Versions of min and max that are compatible with compile-time constants.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [228318] trunk/Source/JavaScriptCore

[clopez]

Title: [228318] trunk/Source/_javascript_Core








Revision 228318
Author clo...@igalia.com
Date 2018-02-09 05:50:39 -0800 (Fri, 09 Feb 2018)


Log Message
Fix build on ARMv7 traditional JSCOnly bot after r228306
https://bugs.webkit.org/show_bug.cgi?id=182563

Unreviewed build fix.

* assembler/AssemblerBuffer.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (228317 => 228318)

--- trunk/Source/_javascript_Core/ChangeLog	2018-02-09 13:37:40 UTC (rev 228317)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-02-09 13:50:39 UTC (rev 228318)
@@ -1,3 +1,12 @@
+2018-02-09  Carlos Alberto Lopez Perez  
+
+Fix build on ARMv7 traditional JSCOnly bot after r228306
+https://bugs.webkit.org/show_bug.cgi?id=182563
+
+Unreviewed build fix.
+
+* assembler/AssemblerBuffer.h:
+
 2018-02-08  Filip Pizlo  
 
 Experiment with alternative implementation of memcpy/memset


Modified: trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h (228317 => 228318)

--- trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h	2018-02-09 13:37:40 UTC (rev 228317)
+++ trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h	2018-02-09 13:50:39 UTC (rev 228318)
@@ -32,6 +32,7 @@
 #include "stdint.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes