[webkit-changes] [251529] trunk/Source
Title: [251529] trunk/Source Revision 251529 Author ysuz...@apple.com Date 2019-10-23 22:34:21 -0700 (Wed, 23 Oct 2019) Log Message [JSC] Remove wasmAwareLexicalGlobalObject https://bugs.webkit.org/show_bug.cgi?id=203351 Reviewed by Mark Lam. Source/_javascript_Core: CallFrame::lexicalGlobalObject() is no longer called frequently. We can just make the current wasmAwareLexicalGlobalObject as CallFrame::lexicalGlobalObject, and remove wasmAwareLexicalGlobalObject function. * debugger/Debugger.cpp: (JSC::Debugger::hasBreakpoint): (JSC::Debugger::breakProgram): (JSC::lexicalGlobalObjectForCallFrame): * debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::deprecatedVMEntryGlobalObject const): (JSC::DebuggerCallFrame::scope): (JSC::DebuggerCallFrame::thisValue const): (JSC::DebuggerCallFrame::evaluateWithScopeExtension): * debugger/DebuggerCallFrame.h: * inspector/JSJavaScriptCallFrame.cpp: (Inspector::JSJavaScriptCallFrame::thisObject const): * inspector/_javascript_CallFrame.h: (Inspector::_javascript_CallFrame::thisValue const): * interpreter/CallFrame.cpp: (JSC::CallFrame::lexicalGlobalObjectFromWasmCallee const): (JSC::CallFrame::wasmAwareLexicalGlobalObject): Deleted. * interpreter/CallFrame.h: * interpreter/Interpreter.cpp: (JSC::notifyDebuggerOfUnwinding): (JSC::Interpreter::debug): * interpreter/StackVisitor.cpp: (JSC::StackVisitor::Frame::createArguments): * interpreter/StackVisitor.h: * llint/LLIntSlowPaths.cpp: (JSC::LLInt::llint_throw_stack_overflow_error): * runtime/JSFunction.cpp: (JSC::RetrieveArgumentsFunctor::RetrieveArgumentsFunctor): (JSC::RetrieveArgumentsFunctor::operator() const): (JSC::retrieveArguments): * runtime/JSScope.h: (JSC::CallFrame::lexicalGlobalObject const): * runtime/RegExpInlines.h: (JSC::RegExp::matchInline): * wasm/js/WasmToJS.cpp: (JSC::Wasm::wasmToJS): Source/WebCore: * bindings/js/CommonVM.cpp: (WebCore::lexicalFrameFromCommonVM): * bindings/js/JSDOMWindowBase.cpp: (WebCore::responsibleDocument): * bindings/js/StructuredClone.cpp: (WebCore::cloneArrayBufferImpl): * dom/Document.cpp: (WebCore::Document::shouldBypassMainWorldContentSecurityPolicy const): * testing/Internals.cpp: (WebCore::Internals::parserMetaData): (WebCore::Internals::isFromCurrentWorld const): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/debugger/Debugger.cpp trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h trunk/Source/_javascript_Core/inspector/JSJavaScriptCallFrame.cpp trunk/Source/_javascript_Core/inspector/_javascript_CallFrame.h trunk/Source/_javascript_Core/interpreter/CallFrame.cpp trunk/Source/_javascript_Core/interpreter/CallFrame.h trunk/Source/_javascript_Core/interpreter/Interpreter.cpp trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp trunk/Source/_javascript_Core/interpreter/StackVisitor.h trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp trunk/Source/_javascript_Core/runtime/JSFunction.cpp trunk/Source/_javascript_Core/runtime/JSScope.h trunk/Source/_javascript_Core/runtime/RegExpInlines.h trunk/Source/_javascript_Core/wasm/js/WasmToJS.cpp trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/CommonVM.cpp trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp trunk/Source/WebCore/bindings/js/StructuredClone.cpp trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/testing/Internals.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (251528 => 251529) --- trunk/Source/_javascript_Core/ChangeLog 2019-10-24 04:01:30 UTC (rev 251528) +++ trunk/Source/_javascript_Core/ChangeLog 2019-10-24 05:34:21 UTC (rev 251529) @@ -1,3 +1,50 @@ +2019-10-23 Yusuke Suzuki + +[JSC] Remove wasmAwareLexicalGlobalObject +https://bugs.webkit.org/show_bug.cgi?id=203351 + +Reviewed by Mark Lam. + +CallFrame::lexicalGlobalObject() is no longer called frequently. We can just make the current wasmAwareLexicalGlobalObject as CallFrame::lexicalGlobalObject, +and remove wasmAwareLexicalGlobalObject function. + +* debugger/Debugger.cpp: +(JSC::Debugger::hasBreakpoint): +(JSC::Debugger::breakProgram): +(JSC::lexicalGlobalObjectForCallFrame): +* debugger/DebuggerCallFrame.cpp: +(JSC::DebuggerCallFrame::deprecatedVMEntryGlobalObject const): +(JSC::DebuggerCallFrame::scope): +(JSC::DebuggerCallFrame::thisValue const): +(JSC::DebuggerCallFrame::evaluateWithScopeExtension): +* debugger/DebuggerCallFrame.h: +* inspector/JSJavaScriptCallFrame.cpp: +(Inspector::JSJavaScriptCallFrame::thisObject const): +* inspector/_javascript_CallFrame.h: +(Inspector::_javascript_CallFrame::thisValue const): +* interpreter/CallFrame.cpp: +(JSC::CallFrame::lexicalGlobalObjectFromWasmCallee const): +(JSC::CallFrame::wasmAwareLexicalGlobalObject): Deleted. +* interpreter/CallFrame.h: +
[webkit-changes] [251478] trunk/Tools
Title: [251478] trunk/Tools
Revision 251478
Author jbed...@apple.com
Date 2019-10-23 08:42:56 -0700 (Wed, 23 Oct 2019)
Log Message
Python 3: 2to3 script may not be in a user's path
https://bugs.webkit.org/show_bug.cgi?id=203213
Reviewed by Dewei Zhu.
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.__init__): Remove executive dependencies.
(AutoinstallImportHook._install_beautifulsoup): Use multiprocess because 2to3 sets
Some undesirable global logging state.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py
Diff
Modified: trunk/Tools/ChangeLog (251477 => 251478)
--- trunk/Tools/ChangeLog 2019-10-23 07:56:35 UTC (rev 251477)
+++ trunk/Tools/ChangeLog 2019-10-23 15:42:56 UTC (rev 251478)
@@ -1,3 +1,15 @@
+2019-10-23 Jonathan Bedard
+
+Python 3: 2to3 script may not be in a user's path
+https://bugs.webkit.org/show_bug.cgi?id=203213
+
+Reviewed by Dewei Zhu.
+
+* Scripts/webkitpy/thirdparty/__init__.py:
+(AutoinstallImportHook.__init__): Remove executive dependencies.
+(AutoinstallImportHook._install_beautifulsoup): Use multiprocess because 2to3 sets
+Some undesirable global logging state.
+
2019-10-23 Tim Horton
prepare-ChangeLog should whine about not having tests in WebKit-only patches
Modified: trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py (251477 => 251478)
--- trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py 2019-10-23 07:56:35 UTC (rev 251477)
+++ trunk/Tools/Scripts/webkitpy/thirdparty/__init__.py 2019-10-23 15:42:56 UTC (rev 251478)
@@ -42,7 +42,6 @@
from distutils import spawn
from webkitpy.common.system.autoinstall import AutoInstaller
from webkitpy.common.system.filesystem import FileSystem
-from webkitpy.common.system.executive import Executive
_THIRDPARTY_DIR = os.path.dirname(__file__)
_AUTOINSTALLED_DIR = os.path.join(_THIRDPARTY_DIR, "autoinstalled")
@@ -78,9 +77,8 @@
class AutoinstallImportHook(object):
-def __init__(self, filesystem=None, executive=None):
+def __init__(self, filesystem=None):
self._fs = filesystem or FileSystem()
-self._executive = executive or Executive()
def _ensure_autoinstalled_dir_is_in_sys_path(self):
# Some packages require that the are being put somewhere under a directory in sys.path.
@@ -218,9 +216,18 @@
did_download_bs4 = self._install("https://files.pythonhosted.org/packages/86/cd/495c68f0536dcd25f016e006731ba7be72e072280305ec52590012c1e6f2/beautifulsoup4-4.8.1.tar.gz",
"beautifulsoup4-4.8.1/bs4")
if did_download_bs4:
-self._executive.run_command(['2to3', '-w', self._fs.join(_AUTOINSTALLED_DIR, 'bs4')])
+from multiprocessing import Process
+from lib2to3.main import main
+try:
+sys.stdout = open(os.devnull, 'w')
+process = Process(target=main, args=('lib2to3.fixes', ['-w', self._fs.join(_AUTOINSTALLED_DIR, 'bs4')]))
+process.start()
+process.join()
+finally:
+sys.stdout = sys.__stdout__
+
def _install_pylint(self):
self._ensure_autoinstalled_dir_is_in_sys_path()
if (not self._fs.exists(self._fs.join(_AUTOINSTALLED_DIR, "pylint")) or
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [251479] trunk/Tools
Title: [251479] trunk/Tools Revision 251479 Author wenson_hs...@apple.com Date 2019-10-23 10:03:25 -0700 (Wed, 23 Oct 2019) Log Message Unreviewed, fix tvOS and watchOS engineering builds after r251377 -[UIPasteboard itemProviders] is only available on iOS. * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm: (writeMultipleObjectsToPlatformPasteboard): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm Diff Modified: trunk/Tools/ChangeLog (251478 => 251479) --- trunk/Tools/ChangeLog 2019-10-23 15:42:56 UTC (rev 251478) +++ trunk/Tools/ChangeLog 2019-10-23 17:03:25 UTC (rev 251479) @@ -1,3 +1,12 @@ +2019-10-23 Wenson Hsieh + +Unreviewed, fix tvOS and watchOS engineering builds after r251377 + +-[UIPasteboard itemProviders] is only available on iOS. + +* TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm: +(writeMultipleObjectsToPlatformPasteboard): + 2019-10-23 Jonathan Bedard Python 3: 2to3 script may not be in a user's path Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm (251478 => 251479) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm 2019-10-23 15:42:56 UTC (rev 251478) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm 2019-10-23 17:03:25 UTC (rev 251479) @@ -97,7 +97,7 @@ NSPasteboard *pasteboard = NSPasteboard.generalPasteboard; [pasteboard clearContents]; [pasteboard writeObjects:@[firstItem.get(), secondItem.get(), thirdItem.get(), fourthItem.get()]]; -#else +#elif PLATFORM(IOS) auto firstItem = adoptNS([[NSItemProvider alloc] initWithObject:@"Hello"]); auto secondItem = adoptNS([[NSItemProvider alloc] initWithObject:[NSURL URLWithString:@"https://apple.com/"]]); auto thirdItem = adoptNS([[NSItemProvider alloc] init]); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [251484] trunk/Source/WebCore
Title: [251484] trunk/Source/WebCore
Revision 251484
Author an...@apple.com
Date 2019-10-23 11:49:37 -0700 (Wed, 23 Oct 2019)
Log Message
[LFC] LayoutState should have out-of-line destructor
https://bugs.webkit.org/show_bug.cgi?id=203307
Reviewed by Zalan Bujtas.
Otherwise instantiating it requires a pile of other headers.
* layout/LayoutState.cpp:
* layout/LayoutState.h:
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutTree):
Use makeUnique.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/LayoutState.cpp
trunk/Source/WebCore/layout/LayoutState.h
trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (251483 => 251484)
--- trunk/Source/WebCore/ChangeLog 2019-10-23 18:45:37 UTC (rev 251483)
+++ trunk/Source/WebCore/ChangeLog 2019-10-23 18:49:37 UTC (rev 251484)
@@ -1,3 +1,19 @@
+2019-10-23 Antti Koivisto
+
+[LFC] LayoutState should have out-of-line destructor
+https://bugs.webkit.org/show_bug.cgi?id=203307
+
+Reviewed by Zalan Bujtas.
+
+Otherwise instantiating it requires a pile of other headers.
+
+* layout/LayoutState.cpp:
+* layout/LayoutState.h:
+* layout/layouttree/LayoutTreeBuilder.cpp:
+(WebCore::Layout::TreeBuilder::createLayoutTree):
+
+Use makeUnique.
+
2019-10-23 youenn fablet
Remove NavigatorBase::serviceWorkerIfExists
Modified: trunk/Source/WebCore/layout/LayoutState.cpp (251483 => 251484)
--- trunk/Source/WebCore/layout/LayoutState.cpp 2019-10-23 18:45:37 UTC (rev 251483)
+++ trunk/Source/WebCore/layout/LayoutState.cpp 2019-10-23 18:49:37 UTC (rev 251484)
@@ -45,6 +45,8 @@
ASSERT(root.establishesFormattingContext());
}
+LayoutState::~LayoutState() = default;
+
Display::Box& LayoutState::displayBoxForLayoutBox(const Box& layoutBox)
{
return *m_layoutToDisplayBox.ensure(, [] {
Modified: trunk/Source/WebCore/layout/LayoutState.h (251483 => 251484)
--- trunk/Source/WebCore/layout/LayoutState.h 2019-10-23 18:45:37 UTC (rev 251483)
+++ trunk/Source/WebCore/layout/LayoutState.h 2019-10-23 18:49:37 UTC (rev 251484)
@@ -49,6 +49,7 @@
WTF_MAKE_ISO_ALLOCATED(LayoutState);
public:
LayoutState(const Container& root);
+~LayoutState();
FormattingState& createFormattingStateForFormattingRootIfNeeded(const Container& formattingContextRoot);
FormattingState& establishedFormattingState(const Container& formattingRoot) const;
Modified: trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp (251483 => 251484)
--- trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp 2019-10-23 18:45:37 UTC (rev 251483)
+++ trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp 2019-10-23 18:49:37 UTC (rev 251484)
@@ -81,7 +81,7 @@
style.setLogicalWidth(Length(renderView.width(), Fixed));
style.setLogicalHeight(Length(renderView.height(), Fixed));
-std::unique_ptr initialContainingBlock(new Container(WTF::nullopt, WTFMove(style)));
+auto initialContainingBlock = makeUnique(WTF::nullopt, WTFMove(style));
TreeBuilder::createSubTree(renderView, *initialContainingBlock);
return initialContainingBlock;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [251481] trunk/LayoutTests
Title: [251481] trunk/LayoutTests Revision 251481 Author cdu...@apple.com Date 2019-10-23 11:23:28 -0700 (Wed, 23 Oct 2019) Log Message Resync imported/w3c/web-platform-tests/html/webappapis WPT tests from upstream https://bugs.webkit.org/show_bug.cgi?id=203298 Reviewed by Youenn Fablet. Resync imported/w3c/web-platform-tests/html/webappapis WPT tests from upstream 32ffb13f7f7fce355bf. * web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window-expected.txt: * web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window.js: (async_test.t.window.handlers.afterOpen.t.step_func_done): (async_test.t.window.handlers.afterOpenAsync.t.step_func_done): * web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/location-set-and-document-open-expected.txt: Added. * web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/location-set-and-document-open.html: Added. * web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/w3c-import.log: * web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.serviceworker-expected.txt: Added. * web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.serviceworker.html: Added. * web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/disallow-crossorigin.html: * web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/support/promise-access-control.py: (main): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window.js trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/w3c-import.log trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/disallow-crossorigin.html trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/support/promise-access-control.py trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/platform/win/TestExpectations Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/location-set-and-document-open-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/location-set-and-document-open.html trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.serviceworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.serviceworker.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (251480 => 251481) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-10-23 18:07:55 UTC (rev 251480) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-10-23 18:23:28 UTC (rev 251481) @@ -1,3 +1,25 @@ +2019-10-23 Chris Dumez + +Resync imported/w3c/web-platform-tests/html/webappapis WPT tests from upstream +https://bugs.webkit.org/show_bug.cgi?id=203298 + +Reviewed by Youenn Fablet. + +Resync imported/w3c/web-platform-tests/html/webappapis WPT tests from upstream 32ffb13f7f7fce355bf. + +* web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window-expected.txt: +* web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window.js: +(async_test.t.window.handlers.afterOpen.t.step_func_done): +(async_test.t.window.handlers.afterOpenAsync.t.step_func_done): +* web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/location-set-and-document-open-expected.txt: Added. +* web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/location-set-and-document-open.html: Added. +* web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/w3c-import.log: +* web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.serviceworker-expected.txt: Added. +*
[webkit-changes] [251482] trunk
Title: [251482] trunk
Revision 251482
Author sihui_...@apple.com
Date 2019-10-23 11:29:29 -0700 (Wed, 23 Oct 2019)
Log Message
[ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing
https://bugs.webkit.org/show_bug.cgi?id=203173
Source/_javascript_Core:
Hold a strong reference to JSGlobalOjbect in ConsoleMessage so that object is not garbage collected before
WebConsoleAgent::frameWindowDiscarded.
Covered by existing test: inspector/console/webcore-logging.html.
Reviewed by Geoffrey Garen.
* inspector/ConsoleMessage.cpp:
(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::clear):
* inspector/ConsoleMessage.h:
LayoutTests:
Reviewed by Geoffrey Garen.
play() returns a promise and the promise can be rejected by a later pause(). We didn't handle
that case so we could receive a type _javascript_ message for the unhandled rejected promise.
* inspector/console/webcore-logging.html:
* platform/mac-wk1/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/webcore-logging.html
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/ConsoleMessage.cpp
trunk/Source/_javascript_Core/inspector/ConsoleMessage.h
Diff
Modified: trunk/LayoutTests/ChangeLog (251481 => 251482)
--- trunk/LayoutTests/ChangeLog 2019-10-23 18:23:28 UTC (rev 251481)
+++ trunk/LayoutTests/ChangeLog 2019-10-23 18:29:29 UTC (rev 251482)
@@ -1,3 +1,17 @@
+2019-10-23 Sihui Liu
+
+[ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing
+https://bugs.webkit.org/show_bug.cgi?id=203173
+
+
+Reviewed by Geoffrey Garen.
+
+play() returns a promise and the promise can be rejected by a later pause(). We didn't handle
+that case so we could receive a type _javascript_ message for the unhandled rejected promise.
+
+* inspector/console/webcore-logging.html:
+* platform/mac-wk1/TestExpectations:
+
2019-10-22 Simon Fraser
wpt/css/css-images/gradient/color-stops-parsing.html fails
Modified: trunk/LayoutTests/inspector/console/webcore-logging.html (251481 => 251482)
--- trunk/LayoutTests/inspector/console/webcore-logging.html 2019-10-23 18:23:28 UTC (rev 251481)
+++ trunk/LayoutTests/inspector/console/webcore-logging.html 2019-10-23 18:29:29 UTC (rev 251482)
@@ -17,7 +17,7 @@
function play()
{
video.currentTime = 0;
-video.play();
+video.play().catch((err) => { });
TestPage.dispatchEventToFrontend('PlayEvent', {count: 1});
}
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (251481 => 251482)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2019-10-23 18:23:28 UTC (rev 251481)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2019-10-23 18:29:29 UTC (rev 251482)
@@ -801,7 +801,5 @@
# Skip IsLoggedIn
http/tests/is-logged-in/ [ Skip ]
-webkit.org/b/203173 inspector/console/webcore-logging.html [ Pass Failure ]
-
webkit.org/b/203176 [ Debug ] fast/scrolling/latching/scroll-select-bottom-test.html [ Pass Failure ]
Modified: trunk/Source/_javascript_Core/ChangeLog (251481 => 251482)
--- trunk/Source/_javascript_Core/ChangeLog 2019-10-23 18:23:28 UTC (rev 251481)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-10-23 18:29:29 UTC (rev 251482)
@@ -1,3 +1,21 @@
+2019-10-23 Sihui Liu
+
+[ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing
+https://bugs.webkit.org/show_bug.cgi?id=203173
+
+
+Hold a strong reference to JSGlobalOjbect in ConsoleMessage so that object is not garbage collected before
+WebConsoleAgent::frameWindowDiscarded.
+
+Covered by existing test: inspector/console/webcore-logging.html.
+
+Reviewed by Geoffrey Garen.
+
+* inspector/ConsoleMessage.cpp:
+(Inspector::ConsoleMessage::ConsoleMessage):
+(Inspector::ConsoleMessage::clear):
+* inspector/ConsoleMessage.h:
+
2019-10-22 Yusuke Suzuki
Make `JSGlobalObject*` threading change more stabilized by adding tests and assertions
Modified: trunk/Source/_javascript_Core/inspector/ConsoleMessage.cpp (251481 => 251482)
--- trunk/Source/_javascript_Core/inspector/ConsoleMessage.cpp 2019-10-23 18:23:28 UTC (rev 251481)
+++ trunk/Source/_javascript_Core/inspector/ConsoleMessage.cpp 2019-10-23 18:29:29 UTC (rev 251482)
@@ -117,9 +117,11 @@
, m_type(type)
, m_level(level)
, m_url()
-, m_globalObject(globalObject)
, m_requestId(IdentifiersFactory::requestId(requestIdentifier))
{
+if (globalObject)
+m_globalObject = { globalObject->vm(), globalObject };
+
if (!messages.size())
return;
@@ -340,6 +342,9 @@
if (m_arguments)
m_arguments = nullptr;
+
+if (m_globalObject)
+
[webkit-changes] [251485] trunk
Title: [251485] trunk
Revision 251485
Author yu...@chromium.org
Date 2019-10-23 12:09:04 -0700 (Wed, 23 Oct 2019)
Log Message
Web Inspector: frontend tests should clear output before resending results
https://bugs.webkit.org/show_bug.cgi?id=203262
Reviewed by Devin Rousso.
Source/WebInspectorUI:
Inspector front-end tests will clear output log before resending teset results. This avoids
race between InspectorTest.testPageDidLoad event and TestPage.addResult calls that may have
already be sent to the new page after navigation. The latter events otherwise would be added
twice.
* UserInterface/Test/FrontendTestHarness.js:
(FrontendTestHarness):
(FrontendTestHarness.prototype.testPageDidLoad):
(FrontendTestHarness.prototype.reloadPage):
(FrontendTestHarness.prototype.reportUnhandledRejection):
(FrontendTestHarness.prototype.reportUncaughtException):
(FrontendTestHarness.prototype._resendResults): Don't resend the results when the page is loaded
first time.
LayoutTests:
Unflake some of the tests that reload inspected page. This is achieved by waiting for
explicit TestPageDidLoad event. At that point it's known that accumulated so far test
output has been resent to the inspected page and the log lines will not change their
order / appear twice.
* http/tests/inspector/resources/inspector-test.js:
(TestPage.clearOutput):
* inspector/debugger/breakpoint-action-eval.html:
* inspector/debugger/breakpoint-action-log-expected.txt:
* inspector/debugger/breakpoint-action-log.html:
* inspector/debugger/probe-manager-add-remove-actions-expected.txt:
* inspector/debugger/probe-manager-add-remove-actions.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js
trunk/LayoutTests/inspector/debugger/breakpoint-action-eval.html
trunk/LayoutTests/inspector/debugger/breakpoint-action-log-expected.txt
trunk/LayoutTests/inspector/debugger/breakpoint-action-log.html
trunk/LayoutTests/inspector/debugger/probe-manager-add-remove-actions-expected.txt
trunk/LayoutTests/inspector/debugger/probe-manager-add-remove-actions.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js
Diff
Modified: trunk/LayoutTests/ChangeLog (251484 => 251485)
--- trunk/LayoutTests/ChangeLog 2019-10-23 18:49:37 UTC (rev 251484)
+++ trunk/LayoutTests/ChangeLog 2019-10-23 19:09:04 UTC (rev 251485)
@@ -1,3 +1,23 @@
+2019-10-23 Yury Semikhatsky
+
+Web Inspector: frontend tests should clear output before resending results
+https://bugs.webkit.org/show_bug.cgi?id=203262
+
+Reviewed by Devin Rousso.
+
+Unflake some of the tests that reload inspected page. This is achieved by waiting for
+explicit TestPageDidLoad event. At that point it's known that accumulated so far test
+output has been resent to the inspected page and the log lines will not change their
+order / appear twice.
+
+* http/tests/inspector/resources/inspector-test.js:
+(TestPage.clearOutput):
+* inspector/debugger/breakpoint-action-eval.html:
+* inspector/debugger/breakpoint-action-log-expected.txt:
+* inspector/debugger/breakpoint-action-log.html:
+* inspector/debugger/probe-manager-add-remove-actions-expected.txt:
+* inspector/debugger/probe-manager-add-remove-actions.html:
+
2019-10-23 Sihui Liu
[ Mac WK1 ] REGRESSION (r251261): Layout Test inspector/console/webcore-logging.html is consistently Failing
Modified: trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js (251484 => 251485)
--- trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js 2019-10-23 18:49:37 UTC (rev 251484)
+++ trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js 2019-10-23 19:09:04 UTC (rev 251485)
@@ -173,6 +173,16 @@
TestPage.log = TestPage.addResult;
+TestPage.clearOutput = function()
+{
+if (!this._resultElement)
+return;
+
+let output = this._resultElement;
+while (output.firstChild)
+output.removeChild(output.firstChild);
+}
+
TestPage.dispatchEventToFrontend = function(eventName, data)
{
let dispatchEventCodeString = `InspectorTest.dispatchEventToListeners(${JSON.stringify(eventName)}, ${JSON.stringify(data)});`;
Modified: trunk/LayoutTests/inspector/debugger/breakpoint-action-eval.html (251484 => 251485)
--- trunk/LayoutTests/inspector/debugger/breakpoint-action-eval.html 2019-10-23 18:49:37 UTC (rev 251484)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-action-eval.html 2019-10-23 19:09:04 UTC (rev 251485)
@@ -19,6 +19,7 @@
function test()
{
+let breakpointPromise = new WI.WrappedPromise;
WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.ScriptAdded, function(event) {
var scriptObject = event.data.script;
@@ -33,10 +34,19 @@
WI.debuggerManager.addBreakpoint(breakpoint);
+breakpointPromise.resolve()
+});
+
+
[webkit-changes] [251486] trunk/LayoutTests
Title: [251486] trunk/LayoutTests Revision 251486 Author wenson_hs...@apple.com Date 2019-10-23 12:13:36 -0700 (Wed, 23 Oct 2019) Log Message fast/forms/ios/click-should-not-suppress-misspelling.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=203283 Reviewed by Tim Horton. This layout test frequently fails on iOS 13, because it assumes that the `selectionchange` event due to tapping a misspelled word must occur within one zero-delay timeout after detecting a click event. However, this is not guaranteed; to fix the test, we simply wait until both `click` and `selectionchange` events have occured, and then check that the entire contents of the text field are selected. * fast/forms/ios/click-should-not-suppress-misspelling-expected.txt: * fast/forms/ios/click-should-not-suppress-misspelling.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling-expected.txt trunk/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html Diff Modified: trunk/LayoutTests/ChangeLog (251485 => 251486) --- trunk/LayoutTests/ChangeLog 2019-10-23 19:09:04 UTC (rev 251485) +++ trunk/LayoutTests/ChangeLog 2019-10-23 19:13:36 UTC (rev 251486) @@ -1,3 +1,19 @@ +2019-10-23 Wenson Hsieh + +fast/forms/ios/click-should-not-suppress-misspelling.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=203283 + + +Reviewed by Tim Horton. + +This layout test frequently fails on iOS 13, because it assumes that the `selectionchange` event due to tapping +a misspelled word must occur within one zero-delay timeout after detecting a click event. However, this is not +guaranteed; to fix the test, we simply wait until both `click` and `selectionchange` events have occured, and +then check that the entire contents of the text field are selected. + +* fast/forms/ios/click-should-not-suppress-misspelling-expected.txt: +* fast/forms/ios/click-should-not-suppress-misspelling.html: + 2019-10-23 Yury Semikhatsky Web Inspector: frontend tests should clear output before resending results Modified: trunk/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling-expected.txt (251485 => 251486) --- trunk/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling-expected.txt 2019-10-23 19:09:04 UTC (rev 251485) +++ trunk/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling-expected.txt 2019-10-23 19:13:36 UTC (rev 251486) @@ -3,6 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". +PASS clicked && selectionChanged became true PASS input.selectionStart is 0 PASS input.selectionEnd is 7 PASS successfullyParsed is true Modified: trunk/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html (251485 => 251486) --- trunk/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html 2019-10-23 19:09:04 UTC (rev 251485) +++ trunk/LayoutTests/fast/forms/ios/click-should-not-suppress-misspelling.html 2019-10-23 19:13:36 UTC (rev 251486) @@ -21,6 +21,8 @@const input = document.getElementById("input"); jsTestIsAsync = true; +clicked = false; +selectionChanged = false; description("This test verifies that tapping in a misspelled word selects the misspelled word, and does not cause " + "the selection to collapse after a click event is dispatched. To manually test, tap the input field to bring up " + @@ -30,15 +32,15 @@ (async function() { await UIHelper.activateAndWaitForInputSessionAt(100, 200);-input.addEventListener("click", () => { -setTimeout(() => { -shouldBe("input.selectionStart", "0"); -shouldBe("input.selectionEnd", "7"); -finishJSTest(); -});+input.addEventListener("click", () => clicked = true); +document.addEventListener("selectionchange", () => selectionChanged = true); + +await UIHelper.tapAt(300, 200); +shouldBecomeEqual("clicked && selectionChanged", "true", () => { +shouldBe("input.selectionStart", "0"); +shouldBe("input.selectionEnd", "7"); +finishJSTest(); });- -UIHelper.tapAt(800, 200);})(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [251483] trunk
Title: [251483] trunk
Revision 251483
Author ross.kirsl...@sony.com
Date 2019-10-23 11:45:37 -0700 (Wed, 23 Oct 2019)
Log Message
String.prototype.matchAll should throw on non-global regex
https://bugs.webkit.org/show_bug.cgi?id=202838
Reviewed by Keith Miller.
JSTests:
* stress/string-matchall.js: Added.
* test262/expectations.yaml:
Mark four test cases as passing.
Source/_javascript_Core:
* builtins/StringPrototype.js:
(matchAll):
Implement normative change from https://github.com/tc39/ecma262/pull/1716.
* builtins/BuiltinNames.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/RegExpConstructor.cpp:
(JSC::esSpecIsRegExp): Added.
* runtime/RegExpConstructor.h:
Expose isRegExp to builtins. (This differs from @isRegExpObject by first checking for Symbol.match.)
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/builtins/BuiltinNames.h
trunk/Source/_javascript_Core/builtins/StringPrototype.js
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp
trunk/Source/_javascript_Core/runtime/RegExpConstructor.h
Added Paths
trunk/JSTests/stress/string-matchall.js
Diff
Modified: trunk/JSTests/ChangeLog (251482 => 251483)
--- trunk/JSTests/ChangeLog 2019-10-23 18:29:29 UTC (rev 251482)
+++ trunk/JSTests/ChangeLog 2019-10-23 18:45:37 UTC (rev 251483)
@@ -1,5 +1,17 @@
2019-10-23 Ross Kirsling
+String.prototype.matchAll should throw on non-global regex
+https://bugs.webkit.org/show_bug.cgi?id=202838
+
+Reviewed by Keith Miller.
+
+* stress/string-matchall.js: Added.
+
+* test262/expectations.yaml:
+Mark four test cases as passing.
+
+2019-10-23 Ross Kirsling
+
Update test262 (2019.10.11)
https://bugs.webkit.org/show_bug.cgi?id=202861
Added: trunk/JSTests/stress/string-matchall.js (0 => 251483)
--- trunk/JSTests/stress/string-matchall.js (rev 0)
+++ trunk/JSTests/stress/string-matchall.js 2019-10-23 18:45:37 UTC (rev 251483)
@@ -0,0 +1,30 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error(`expected ${expected} but got ${actual}`);
+}
+
+function shouldNotThrow(func) {
+ func();
+}
+
+function shouldThrowTypeError(func) {
+let error;
+try {
+func();
+} catch (e) {
+error = e;
+}
+
+if (!(error instanceof TypeError))
+throw new Error('Expected TypeError!');
+}
+
+shouldThrowTypeError(() => { 'abaca'.matchAll(/a/); });
+shouldThrowTypeError(() => { 'abaca'.matchAll(new RegExp('a')); });
+shouldThrowTypeError(() => { 'abaca'.matchAll({ [Symbol.match]() {} }); });
+
+shouldNotThrow(() => { 'abaca'.matchAll({ [Symbol.match]() {}, flags: 'g' }); });
+
+shouldBe([...'abaca'.matchAll(/a/g)].join(), 'a,a,a');
+shouldBe([...'abaca'.matchAll(new RegExp('a', 'g'))].join(), 'a,a,a');
+shouldBe([...'abaca'.matchAll({ [Symbol.matchAll]: RegExp.prototype[Symbol.matchAll].bind(/a/g) })].join(), 'a,a,a');
Modified: trunk/JSTests/test262/expectations.yaml (251482 => 251483)
--- trunk/JSTests/test262/expectations.yaml 2019-10-23 18:29:29 UTC (rev 251482)
+++ trunk/JSTests/test262/expectations.yaml 2019-10-23 18:45:37 UTC (rev 251483)
@@ -1804,12 +1804,6 @@
test/built-ins/String/proto-from-ctor-realm.js:
default: 'Test262Error: Expected SameValue(«», «») to be true'
strict mode: 'Test262Error: Expected SameValue(«», «») to be true'
-test/built-ins/String/prototype/matchAll/flags-nonglobal-throws.js:
- default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
- strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
-test/built-ins/String/prototype/matchAll/flags-undefined-throws.js:
- default: 'Test262Error: Expected a TypeError but got a SyntaxError'
- strict mode: 'Test262Error: Expected a TypeError but got a SyntaxError'
test/built-ins/ThrowTypeError/extensible.js:
default: 'Test262Error: Expected SameValue(«true», «false») to be true'
strict mode: 'Test262Error: Expected SameValue(«true», «false») to be true'
Modified: trunk/Source/_javascript_Core/ChangeLog (251482 => 251483)
--- trunk/Source/_javascript_Core/ChangeLog 2019-10-23 18:29:29 UTC (rev 251482)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-10-23 18:45:37 UTC (rev 251483)
@@ -1,3 +1,22 @@
+2019-10-23 Ross Kirsling
+
+String.prototype.matchAll should throw on non-global regex
+https://bugs.webkit.org/show_bug.cgi?id=202838
+
+Reviewed by Keith Miller.
+
+* builtins/StringPrototype.js:
+(matchAll):
+Implement normative change from https://github.com/tc39/ecma262/pull/1716.
+
+* builtins/BuiltinNames.h:
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::init):
+*
[webkit-changes] [251487] trunk/Source/WebInspectorUI
Title: [251487] trunk/Source/WebInspectorUI Revision 251487 Author nvasil...@apple.com Date 2019-10-23 12:25:01 -0700 (Wed, 23 Oct 2019) Log Message Web Inspector: Replace color wheel with square HSB color picker https://bugs.webkit.org/show_bug.cgi?id=203169 Reviewed by Devin Rousso. Replace the color wheel with a square HSB color picker. The square HSB color picker provides more precision for choosing saturation, and it's more familiar to most web developers. * UserInterface/Main.html: * UserInterface/Views/ColorPicker.css: (.color-picker): (.color-picker > .hue): (body[dir=ltr] .color-picker > .hue): (body[dir=rtl] .color-picker > .hue): * UserInterface/Views/ColorPicker.js: (WI.ColorPicker): (WI.ColorPicker.prototype.get colorSquare): (WI.ColorPicker.prototype.set color): (WI.ColorPicker.prototype.colorSquareColorDidChange): (WI.ColorPicker.prototype.sliderValueDidChange): (WI.ColorPicker.prototype._updateColor): (WI.ColorPicker.prototype._updateSliders): Add a hue slider. The new color picker has the hue slider instead of the brightness slider. * UserInterface/Views/ColorSquare.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ColorWheel.css. (.color-square): (.color-square > .saturation-gradient): (.color-square > .lightness-gradient): (.color-square > .fill): (.color-square > .crosshair): * UserInterface/Views/ColorSquare.js: Added. (WI.ColorSquare): (WI.ColorSquare.prototype.get element): (WI.ColorSquare.prototype.set dimension): (WI.ColorSquare.prototype.get hue): (WI.ColorSquare.prototype.set hue): (WI.ColorSquare.prototype.get tintedColor): (WI.ColorSquare.prototype.set tintedColor): (WI.ColorSquare.prototype.get rawColor): (WI.ColorSquare.prototype.handleEvent): (WI.ColorSquare.prototype.get _saturation): (WI.ColorSquare.prototype.get _brightness): (WI.ColorSquare.prototype.get _lightness): (WI.ColorSquare.prototype._handleMousedown): (WI.ColorSquare.prototype._handleMousemove): (WI.ColorSquare.prototype._handleMouseup): (WI.ColorSquare.prototype._updateColorForMouseEvent): (WI.ColorSquare.prototype._setCrosshairPosition): (WI.ColorSquare.prototype._updateBaseColor): * UserInterface/Views/ColorWheel.js: Removed. * UserInterface/Views/GradientEditor.js: (WI.GradientEditor): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.css trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js trunk/Source/WebInspectorUI/UserInterface/Views/GradientEditor.js Added Paths trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.css trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.js Removed Paths trunk/Source/WebInspectorUI/UserInterface/Views/ColorWheel.css trunk/Source/WebInspectorUI/UserInterface/Views/ColorWheel.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (251486 => 251487) --- trunk/Source/WebInspectorUI/ChangeLog 2019-10-23 19:13:36 UTC (rev 251486) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-10-23 19:25:01 UTC (rev 251487) @@ -1,3 +1,61 @@ +2019-10-23 Nikita Vasilyev + +Web Inspector: Replace color wheel with square HSB color picker +https://bugs.webkit.org/show_bug.cgi?id=203169 + + +Reviewed by Devin Rousso. + +Replace the color wheel with a square HSB color picker. + +The square HSB color picker provides more precision for choosing saturation, +and it's more familiar to most web developers. + +* UserInterface/Main.html: +* UserInterface/Views/ColorPicker.css: +(.color-picker): +(.color-picker > .hue): +(body[dir=ltr] .color-picker > .hue): +(body[dir=rtl] .color-picker > .hue): +* UserInterface/Views/ColorPicker.js: +(WI.ColorPicker): +(WI.ColorPicker.prototype.get colorSquare): +(WI.ColorPicker.prototype.set color): +(WI.ColorPicker.prototype.colorSquareColorDidChange): +(WI.ColorPicker.prototype.sliderValueDidChange): +(WI.ColorPicker.prototype._updateColor): +(WI.ColorPicker.prototype._updateSliders): +Add a hue slider. The new color picker has the hue slider instead of the brightness slider. + +* UserInterface/Views/ColorSquare.css: Renamed from Source/WebInspectorUI/UserInterface/Views/ColorWheel.css. +(.color-square): +(.color-square > .saturation-gradient): +(.color-square > .lightness-gradient): +(.color-square > .fill): +(.color-square > .crosshair): +* UserInterface/Views/ColorSquare.js: Added. +(WI.ColorSquare): +(WI.ColorSquare.prototype.get element): +(WI.ColorSquare.prototype.set dimension): +(WI.ColorSquare.prototype.get hue): +(WI.ColorSquare.prototype.set hue): +(WI.ColorSquare.prototype.get tintedColor): +(WI.ColorSquare.prototype.set tintedColor): +(WI.ColorSquare.prototype.get rawColor): +
[webkit-changes] [251503] trunk/Source/ThirdParty/ANGLE
Title: [251503] trunk/Source/ThirdParty/ANGLE
Revision 251503
Author d...@apple.com
Date 2019-10-23 15:34:57 -0700 (Wed, 23 Oct 2019)
Log Message
Don't try to compile .inc files in ANGLE
https://bugs.webkit.org/show_bug.cgi?id=203315
Reviewed by Simon Fraser.
These are headers, not files we need to compile directly.
* ANGLE.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
trunk/Source/ThirdParty/ANGLE/ChangeLog
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (251502 => 251503)
--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2019-10-23 22:23:52 UTC (rev 251502)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2019-10-23 22:34:57 UTC (rev 251503)
@@ -625,17 +625,10 @@
A30307052305F636002DA972 /* ReplaceShadowingVariables.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A30307002305F636002DA972 /* ReplaceShadowingVariables.cpp */; };
A30307062305F636002DA972 /* BuiltIn_autogen.h in Headers */ = {isa = PBXBuildFile; fileRef = A30307012305F636002DA972 /* BuiltIn_autogen.h */; };
A30307072305F636002DA972 /* ReplaceShadowingVariables.h in Headers */ = {isa = PBXBuildFile; fileRef = A30307022305F636002DA972 /* ReplaceShadowingVariables.h */; };
- A30307092305F663002DA972 /* Color.inc in Sources */ = {isa = PBXBuildFile; fileRef = A30307082305F662002DA972 /* Color.inc */; };
A303070B2305F6B5002DA972 /* no_destructor.h in Headers */ = {isa = PBXBuildFile; fileRef = A303070A2305F6B5002DA972 /* no_destructor.h */; };
- A303070F2305F705002DA972 /* generatemip.inc in Sources */ = {isa = PBXBuildFile; fileRef = A303070C2305F705002DA972 /* generatemip.inc */; };
- A30307102305F705002DA972 /* copyimage.inc in Sources */ = {isa = PBXBuildFile; fileRef = A303070D2305F705002DA972 /* copyimage.inc */; };
- A30307112305F705002DA972 /* loadimage.inc in Sources */ = {isa = PBXBuildFile; fileRef = A303070E2305F705002DA972 /* loadimage.inc */; };
- A303071E2305F7C4002DA972 /* Error.inc in Sources */ = {isa = PBXBuildFile; fileRef = A30307122305F7C3002DA972 /* Error.inc */; };
A303071F2305F7C4002DA972 /* format_map_desktop.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A30307132305F7C3002DA972 /* format_map_desktop.cpp */; };
A30307202305F7C4002DA972 /* trace.h in Headers */ = {isa = PBXBuildFile; fileRef = A30307142305F7C3002DA972 /* trace.h */; };
- A30307212305F7C4002DA972 /* VertexAttribute.inc in Sources */ = {isa = PBXBuildFile; fileRef = A30307152305F7C3002DA972 /* VertexAttribute.inc */; };
A30307222305F7C4002DA972 /* entry_points_enum_autogen.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A30307162305F7C3002DA972 /* entry_points_enum_autogen.cpp */; };
- A30307232305F7C4002DA972 /* angletypes.inc in Sources */ = {isa = PBXBuildFile; fileRef = A30307172305F7C3002DA972 /* angletypes.inc */; };
A30307242305F7C4002DA972 /* Context_gl.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A30307182305F7C3002DA972 /* Context_gl.cpp */; };
A30307252305F7C4002DA972 /* entry_points_utils.h in Headers */ = {isa = PBXBuildFile; fileRef = A30307192305F7C4002DA972 /* entry_points_utils.h */; };
A30307262305F7C4002DA972 /* entry_points_enum_autogen.h in Headers */ = {isa = PBXBuildFile; fileRef = A303071A2305F7C4002DA972 /* entry_points_enum_autogen.h */; };
@@ -2972,7 +2965,6 @@
5C55D7212282747700B5BA2C /* aligned_memory.cpp in Sources */,
A30307A0230625C6002DA972 /* android_util.cpp in Sources */,
5C1DBDD31B0438D300235552 /* angletypes.cpp in Sources */,
-A30307232305F7C4002DA972 /* angletypes.inc in Sources */,
5C1DBBF01B0436EC00235552 /* angleutils.cpp in Sources */,
A08C3CDC16D6CB61003F0B83 /* ArrayBoundsClamper.cpp in Sources */,
5C55D6AA22826BC800B5BA2C /* ArrayReturnValueToOutParameter.cpp in Sources */,
@@ -2996,7 +2988,6 @@
315EBDBD1FCE44BF00AC7A89 /* ClearMultiviewGL.cpp in Sources */,
31012E1518B97B9B0039062F /* CodeGen.cpp in Sources */,
315EBD8C1FCE443600AC7A89 /* CollectVariables.cpp in Sources */,
-A30307092305F663002DA972 /* Color.inc in Sources */,
31012E1718B97B9B0039062F /* Compiler.cpp in Sources */,
5C1DBDDC1B0438D300235552 /* Compiler.cpp in Sources */,
5CB3011A1DE39F1A00D2C405 /* CompilerGL.cpp in Sources */,
@@ -3009,7 +3000,6 @@
5CB3011C1DE39F1A00D2C405 /* ContextGL.cpp in Sources */,
5CB304DD1DE4164800D2C405 /* ContextImpl.cpp in Sources */,
5CCD598F2284FC400018F2D8 /* copyimage.cpp in Sources */,
-A30307102305F705002DA972 /* copyimage.inc in Sources */,
5CCD81721DBFE999006066B8 /* Debug.cpp in Sources */,
5CC7D46E19102621000B8C1F /* debug.cpp in Sources */,
5C55D733228274DE00B5BA2C /* Declarator.cpp in Sources */,
@@ -3044,7 +3034,6 @@
315EBE091FCE456200AC7A89 /* entry_points_gles_3_1_autogen.cpp in Sources */,
6E344AB322BC35C3001DDB2C /* entry_points_gles_ext_autogen.cpp in Sources */,
5C1DBDEA1B0438D300235552 /*
[webkit-changes] [251505] trunk/LayoutTests
Title: [251505] trunk/LayoutTests Revision 251505 Author repst...@apple.com Date 2019-10-23 15:47:38 -0700 (Wed, 23 Oct 2019) Log Message REGRESSION (r250936?) [ iOS ]: Layout Test http/tests/IndexedDB/storage-limit-1.https.html is a Flaky Failure (203275) https://bugs.webkit.org/show_bug.cgi?id=203275 Unreviewed Test Gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (251504 => 251505) --- trunk/LayoutTests/ChangeLog 2019-10-23 22:39:34 UTC (rev 251504) +++ trunk/LayoutTests/ChangeLog 2019-10-23 22:47:38 UTC (rev 251505) @@ -1,3 +1,12 @@ +2019-10-23 Russell Epstein + +REGRESSION (r250936?) [ iOS ]: Layout Test http/tests/IndexedDB/storage-limit-1.https.html is a Flaky Failure (203275) +https://bugs.webkit.org/show_bug.cgi?id=203275 + +Unreviewed Test Gardening. + +* platform/ios-wk2/TestExpectations: + 2019-10-23 Kate Cheney [macOS WK2] Layout Test http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html is a flaky timeout (198670) Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (251504 => 251505) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-10-23 22:39:34 UTC (rev 251504) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-10-23 22:47:38 UTC (rev 251505) @@ -1362,3 +1362,6 @@ webkit.org/b/203264 [ Release ] editing/pasteboard/smart-paste-paragraph-002.html [ Pass Failure ] webkit.org/b/203264 [ Release ] editing/pasteboard/smart-paste-paragraph-004.html [ Pass Failure ] +# REGRESSION (r250936?) [ iOS ]: Layout Test http/tests/IndexedDB/storage-limit-1.https.html is a Flaky Failure (203275) +webkit.org/b/203275 http/tests/IndexedDB/storage-limit-1.https.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [251491] trunk/Tools
Title: [251491] trunk/Tools
Revision 251491
Author jbed...@apple.com
Date 2019-10-23 13:02:05 -0700 (Wed, 23 Oct 2019)
Log Message
Python 3: Add support in webkitpy.results
https://bugs.webkit.org/show_bug.cgi?id=202478
Reviewed by Carlos Alberto Lopez Perez.
* Scripts/test-webkitpy-python3: Add webkitpy.results.
* Scripts/webkitpy/results/upload.py:
(Upload.Encoder.default): Use range instead of xrange.
(Upload.create_configuration): Support items iteration for Python 3.
(Upload.create_run_stats): Change iteritems to items.
(Upload.create_test_result): Ditto.
* Scripts/webkitpy/results/upload_unittest.py:
(UploadTest.Options.__init__): Change iteritems to items.
(UploadTest.normalize): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/test-webkitpy-python3
trunk/Tools/Scripts/webkitpy/results/upload.py
trunk/Tools/Scripts/webkitpy/results/upload_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (251490 => 251491)
--- trunk/Tools/ChangeLog 2019-10-23 19:41:09 UTC (rev 251490)
+++ trunk/Tools/ChangeLog 2019-10-23 20:02:05 UTC (rev 251491)
@@ -1,3 +1,20 @@
+2019-10-23 Jonathan Bedard
+
+Python 3: Add support in webkitpy.results
+https://bugs.webkit.org/show_bug.cgi?id=202478
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* Scripts/test-webkitpy-python3: Add webkitpy.results.
+* Scripts/webkitpy/results/upload.py:
+(Upload.Encoder.default): Use range instead of xrange.
+(Upload.create_configuration): Support items iteration for Python 3.
+(Upload.create_run_stats): Change iteritems to items.
+(Upload.create_test_result): Ditto.
+* Scripts/webkitpy/results/upload_unittest.py:
+(UploadTest.Options.__init__): Change iteritems to items.
+(UploadTest.normalize): Ditto.
+
2019-10-22 Jiewen Tan
[WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
Modified: trunk/Tools/Scripts/test-webkitpy-python3 (251490 => 251491)
--- trunk/Tools/Scripts/test-webkitpy-python3 2019-10-23 19:41:09 UTC (rev 251490)
+++ trunk/Tools/Scripts/test-webkitpy-python3 2019-10-23 20:02:05 UTC (rev 251491)
@@ -37,6 +37,7 @@
'webkitpy.common.thread',
'webkitpy.common.net',
'webkitpy.common.watchlist',
+ 'webkitpy.results',
]
Modified: trunk/Tools/Scripts/webkitpy/results/upload.py (251490 => 251491)
--- trunk/Tools/Scripts/webkitpy/results/upload.py 2019-10-23 19:41:09 UTC (rev 251490)
+++ trunk/Tools/Scripts/webkitpy/results/upload.py 2019-10-23 20:02:05 UTC (rev 251491)
@@ -69,7 +69,7 @@
buildbot_args = [details.get(arg, None) is None for arg in obj.BUILDBOT_DETAILS]
if any(buildbot_args) and not all(buildbot_args):
raise ValueError('All buildbot details must be defined for upload, details missing: {}'.format(', '.join(
-[obj.BUILDBOT_DETAILS[i] for i in xrange(len(obj.BUILDBOT_DETAILS)) if buildbot_args[i]],
+[obj.BUILDBOT_DETAILS[i] for i in range(len(obj.BUILDBOT_DETAILS)) if buildbot_args[i]],
)))
def unpack_test(current, path_to_test, data):
@@ -81,9 +81,15 @@
unpack_test(current[path_to_test[0]], path_to_test[1:], data)
results = {}
-for test, data in obj.results.iteritems():
-unpack_test(results, test.split('/'), data)
+# FIXME: Python 2 removal, this dictionary is large enough that Python 2 can't just use items
+if sys.version_info > (3, 0):
+for test, data in obj.results.items():
+unpack_test(results, test.split('/'), data)
+else:
+for test, data in obj.results.iteritems():
+unpack_test(results, test.split('/'), data)
+
result = dict(
version=obj.VERSION,
suite=obj.suite,
@@ -129,7 +135,7 @@
architecture=architecture or host_platform.machine(),
)
optional_data = dict(version_name=version_name, model=model, style=style, flavor=flavor, sdk=sdk)
-config.update({key: value for key, value in optional_data.iteritems() if value is not None})
+config.update({key: value for key, value in optional_data.items() if value is not None})
return config
@staticmethod
@@ -157,7 +163,7 @@
def create_run_stats(start_time=None, end_time=None, tests_skipped=None, **kwargs):
stats = dict(**kwargs)
optional_data = dict(start_time=start_time, end_time=end_time, tests_skipped=tests_skipped)
-stats.update({key: value for key, value in optional_data.iteritems() if value is not None})
+stats.update({key: value for key, value in optional_data.items() if value is not None})
return stats
@staticmethod
@@ -166,7 +172,7 @@
# Tests which don't declare expectations or results are
[webkit-changes] [251495] trunk
Title: [251495] trunk Revision 251495 Author cdu...@apple.com Date 2019-10-23 13:38:22 -0700 (Wed, 23 Oct 2019) Log Message FetchRequest should not prevent entering the back/forward cache https://bugs.webkit.org/show_bug.cgi?id=203091 Reviewed by Youenn Fablet. Source/WebCore: FetchRequest used to prevent the page from entering the back/forward cache while it had a blob load in progress. We no longer prevent suspension in such case. Instead, if the document is suspended when the blob load finishes, we post a task to the Window event loop to do the work and resolve / reject the promise. The Window event loop makes sure not to delays tasks that are associated with a document that is suspended. Tests: fast/history/page-cache-active-fetch-request-blobReadAsBlob.html fast/history/page-cache-active-fetch-request-blobReadAsReadableStream.html fast/history/page-cache-active-fetch-request-blobReadAsText.html * Modules/fetch/FetchBodyOwner.cpp: (WebCore::FetchBodyOwner::runNetworkTaskWhenPossible): (WebCore::FetchBodyOwner::blobLoadingSucceeded): (WebCore::FetchBodyOwner::blobLoadingFailed): (WebCore::FetchBodyOwner::blobChunk): (WebCore::FetchBodyOwner::postSuspendableNetworkTask): Deleted. * Modules/fetch/FetchBodyOwner.h: * Modules/fetch/FetchRequest.cpp: * Modules/fetch/FetchRequest.h: * dom/AbstractEventLoop.h: LayoutTests: Add layout test coverage. * TestExpectations: * fast/history/page-cache-active-fetch-request-blobReadAsBlob-expected.txt: Added. * fast/history/page-cache-active-fetch-request-blobReadAsBlob.html: Added. * fast/history/page-cache-active-fetch-request-blobReadAsReadableStream-expected.txt: Added. * fast/history/page-cache-active-fetch-request-blobReadAsReadableStream.html: Added. * fast/history/page-cache-active-fetch-request-blobReadAsText-expected.txt: Added. * fast/history/page-cache-active-fetch-request-blobReadAsText.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h trunk/Source/WebCore/Modules/fetch/FetchRequest.cpp trunk/Source/WebCore/Modules/fetch/FetchRequest.h trunk/Source/WebCore/dom/AbstractEventLoop.h Added Paths trunk/LayoutTests/fast/history/page-cache-active-fetch-request-blobReadAsBlob-expected.txt trunk/LayoutTests/fast/history/page-cache-active-fetch-request-blobReadAsBlob.html trunk/LayoutTests/fast/history/page-cache-active-fetch-request-blobReadAsReadableStream-expected.txt trunk/LayoutTests/fast/history/page-cache-active-fetch-request-blobReadAsReadableStream.html trunk/LayoutTests/fast/history/page-cache-active-fetch-request-blobReadAsText-expected.txt trunk/LayoutTests/fast/history/page-cache-active-fetch-request-blobReadAsText.html Diff Modified: trunk/LayoutTests/ChangeLog (251494 => 251495) --- trunk/LayoutTests/ChangeLog 2019-10-23 20:16:00 UTC (rev 251494) +++ trunk/LayoutTests/ChangeLog 2019-10-23 20:38:22 UTC (rev 251495) @@ -1,3 +1,21 @@ +2019-10-23 Chris Dumez + +FetchRequest should not prevent entering the back/forward cache +https://bugs.webkit.org/show_bug.cgi?id=203091 + + +Reviewed by Youenn Fablet. + +Add layout test coverage. + +* TestExpectations: +* fast/history/page-cache-active-fetch-request-blobReadAsBlob-expected.txt: Added. +* fast/history/page-cache-active-fetch-request-blobReadAsBlob.html: Added. +* fast/history/page-cache-active-fetch-request-blobReadAsReadableStream-expected.txt: Added. +* fast/history/page-cache-active-fetch-request-blobReadAsReadableStream.html: Added. +* fast/history/page-cache-active-fetch-request-blobReadAsText-expected.txt: Added. +* fast/history/page-cache-active-fetch-request-blobReadAsText.html: Added. + 2019-10-23 Yury Semikhatsky Web Inspector: notify inspector when provisional page is created, committed and destroyed Modified: trunk/LayoutTests/TestExpectations (251494 => 251495) --- trunk/LayoutTests/TestExpectations 2019-10-23 20:16:00 UTC (rev 251494) +++ trunk/LayoutTests/TestExpectations 2019-10-23 20:38:22 UTC (rev 251495) @@ -266,6 +266,9 @@ fast/files/file-reader-back-forward-cache.html [ DumpJSConsoleLogInStdErr ] fast/history/page-cache-createImageBitmap.html [ DumpJSConsoleLogInStdErr ] http/tests/navigation/page-cache-xhr-in-loading-iframe.html [ DumpJSConsoleLogInStdErr ] +fast/history/page-cache-active-fetch-request-blobReadAsBlob.html [ DumpJSConsoleLogInStdErr ] +fast/history/page-cache-active-fetch-request-blobReadAsText.html [ DumpJSConsoleLogInStdErr ] +fast/history/page-cache-active-fetch-request-blobReadAsReadableStream.html [ DumpJSConsoleLogInStdErr ] webkit.org/b/202495 imported/w3c/web-platform-tests/shadow-dom/directionality-002.tentative.html [ ImageOnlyFailure ] Added:
[webkit-changes] [251504] trunk/LayoutTests
Title: [251504] trunk/LayoutTests
Revision 251504
Author commit-qu...@webkit.org
Date 2019-10-23 15:39:34 -0700 (Wed, 23 Oct 2019)
Log Message
[macOS WK2] Layout Test http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html is a flaky timeout (198670)
https://bugs.webkit.org/show_bug.cgi?id=198670
Patch by Kate Cheney on 2019-10-23
Reviewed by John Wilander.
Was able to reproduce flaky timeouts extremely rarely accompanied by
the error 'JS ERROR TypeError: null is not an object (evaluating
'document.body.appendChild’)'. Since the frame was being created in
head, the document body was sometimes not finished loading by the time
the appendChild call was being made. Moving the frame load to the body should fix this flakiness.
* http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html:
* platform/mac-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html
trunk/LayoutTests/platform/mac-wk2/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (251503 => 251504)
--- trunk/LayoutTests/ChangeLog 2019-10-23 22:34:57 UTC (rev 251503)
+++ trunk/LayoutTests/ChangeLog 2019-10-23 22:39:34 UTC (rev 251504)
@@ -1,5 +1,22 @@
2019-10-23 Kate Cheney
+[macOS WK2] Layout Test http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html is a flaky timeout (198670)
+https://bugs.webkit.org/show_bug.cgi?id=198670
+
+
+Reviewed by John Wilander.
+
+Was able to reproduce flaky timeouts extremely rarely accompanied by
+the error 'JS ERROR TypeError: null is not an object (evaluating
+'document.body.appendChild’)'. Since the frame was being created in
+head, the document body was sometimes not finished loading by the time
+the appendChild call was being made. Moving the frame load to the body should fix this flakiness.
+
+* http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html:
+* platform/mac-wk2/TestExpectations:
+
+2019-10-23 Kate Cheney
+
Implement dumpResourceLoadStatistics in SQLite ITP Database
https://bugs.webkit.org/show_bug.cgi?id=203224
Modified: trunk/LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html (251503 => 251504)
--- trunk/LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html 2019-10-23 22:34:57 UTC (rev 251503)
+++ trunk/LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html 2019-10-23 22:39:34 UTC (rev 251504)
@@ -1,6 +1,8 @@
+
+