[webkit-changes] [292449] trunk
Title: [292449] trunk Revision 292449 Author commit-qu...@webkit.org Date 2022-04-05 22:30:07 -0700 (Tue, 05 Apr 2022) Log Message [WebXR] Add a new enum type to represent session features https://bugs.webkit.org/show_bug.cgi?id=238837 Patch by Ada Chan on 2022-04-05 Reviewed by Dean Jackson. Source/WebCore: Test: http/wpt/webxr/xrDevice_requestSession_hand_tracking_feature.https.html Add a new enum type, PlatformXR::SessionFeature, to represent session features. It includes the ReferenceSpaceTypes and the hand-tracking feature for now. Fix the algorithm to resolve the requested features to recognize hand-tracking as a feature that requires explicit consent. * Modules/webxr/WebXRSession.cpp: (WebCore::WebXRSession::referenceSpaceIsSupported const): Convert the XRReferenceSpaceType to PlatformXR::SessionFeature first before checking against the feature list. * Modules/webxr/WebXRSystem.cpp: (WebCore::WebXRSystem::inlineSessionRequestIsAllowedForGlobalObject const): Use PlatformXR::parseSessionFeatureDescriptor() to parse the feature string. (WebCore::featureRequiresExplicitConsent): Returns true for the hand tracking feature. (WebCore::WebXRSystem::isFeatureSupported const): Check whether the device supports the feature. For hand-tracking, make sure the hand input module setting is enabled. (WebCore::WebXRSystem::resolveRequestedFeatures const): Update the string conversion between JS and WTF::String now that features cannot be parsed as XRReferenceSpaceType enum. If the feature requires explicit consent and it's not already in the granted list, add it to consentRequired or consentOptional depending on whether it's specified as required. (WebCore::WebXRSystem::resolveFeaturePermissions const): If a feature is required but not given a clear signal of user intent, the session should not be created. (WebCore::WebXRSystem::DummyInlineDevice::DummyInlineDevice): Updated to use PlatformXR::SessionFeature. * Modules/webxr/WebXRSystem.h: * platform/xr/PlatformXR.h: (PlatformXR::sessionFeatureFromReferenceSpaceType): (PlatformXR::parseSessionFeatureDescriptor): Parse feature string to return PlatformXR::SessionFeature. (PlatformXR::sessionFeatureDescriptor): Return feature string from PlatformXR::SessionFeature. (PlatformXR::Device::supports const): Read from the m_supportedFeaturesMap. (PlatformXR::Device::setSupportedFeatures): Write to the m_supportedFeaturesMap. (PlatformXR::Device::supportedFeatures const): Read from the m_supportedFeaturesMap. * platform/xr/openxr/PlatformXROpenXR.cpp: (PlatformXR::OpenXRDevice::collectSupportedFeatures const): Updated to use PlatformXR::SessionFeature. * testing/WebXRTest.cpp: (WebCore::WebXRTest::simulateDeviceConnection): Updated to parse feature string to PlatformXR::SessionFeature. Source/WebKit: Add a new _WKXRSessionFeatureFlags entry for hand-tracking. * Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): (headers_for_type): * Shared/XR/XRDeviceProxy.cpp: (WebKit::XRDeviceProxy::XRDeviceProxy): * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: * UIProcess/Cocoa/UIDelegate.mm: (WebKit::toWKXRSessionFeatureFlags): (WebKit::toPlatformXRFeatures): * UIProcess/XR/PlatformXRSystem.cpp: (WebKit::PlatformXRSystem::requestPermissionOnSessionFeatures): * UIProcess/XR/PlatformXRSystem.h: * UIProcess/XR/PlatformXRSystem.messages.in: LayoutTests: Test listing "hand-tracking" as an optional feature while the device does not support it allows the session to be created. Test listing "hand-tracking" as a required feature while the device does not support it would not create the session. * http/wpt/webxr/resources/webxr_test_constants_single_view.js: * http/wpt/webxr/xrDevice_requestSession_hand_tracking_feature.https-expected.txt: Added. * http/wpt/webxr/xrDevice_requestSession_hand_tracking_feature.https.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/wpt/webxr/resources/webxr_test_constants_single_view.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webxr/WebXRSession.cpp trunk/Source/WebCore/Modules/webxr/WebXRSystem.cpp trunk/Source/WebCore/Modules/webxr/WebXRSystem.h trunk/Source/WebCore/platform/xr/PlatformXR.h trunk/Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp trunk/Source/WebCore/testing/WebXRTest.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Scripts/webkit/messages.py trunk/Source/WebKit/Shared/XR/XRDeviceProxy.cpp trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm trunk/Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp trunk/Source/WebKit/UIProcess/XR/PlatformXRSystem.h trunk/Source/WebKit/UIProcess/XR/PlatformXRSystem.messages.in Added Paths trunk/LayoutTests/http/wpt/webxr/xrDevice_requestSession_hand_tracking_feature.https-expected.txt trunk/LayoutTests/http/wpt/webxr/xrDevice_requestSession_hand_tracking_feature.https.html Diff Modified: trunk/LayoutTests/ChangeLog (292448 => 292449) ---
[webkit-changes] [292448] trunk/Source/WebKit
Title: [292448] trunk/Source/WebKit Revision 292448 Author wenson_hs...@apple.com Date 2022-04-05 21:07:25 -0700 (Tue, 05 Apr 2022) Log Message [iOS] Update the context menu item glyph for visual look up https://bugs.webkit.org/show_bug.cgi?id=238853 Reviewed by Devin Rousso. Switch from `info.circle` to the (private) symbol `info.circle.and.sparkles`, for the icon next to the Look Up item when long pressing images that have visual look up results. * Platform/spi/ios/UIKitSPI.h: * UIProcess/API/Cocoa/_WKElementAction.mm: (+[_WKElementAction imageForElementActionType:]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm Diff Modified: trunk/Source/WebKit/ChangeLog (292447 => 292448) --- trunk/Source/WebKit/ChangeLog 2022-04-06 03:41:00 UTC (rev 292447) +++ trunk/Source/WebKit/ChangeLog 2022-04-06 04:07:25 UTC (rev 292448) @@ -1,3 +1,17 @@ +2022-04-05 Wenson Hsieh + +[iOS] Update the context menu item glyph for visual look up +https://bugs.webkit.org/show_bug.cgi?id=238853 + +Reviewed by Devin Rousso. + +Switch from `info.circle` to the (private) symbol `info.circle.and.sparkles`, for the icon next to the Look Up +item when long pressing images that have visual look up results. + +* Platform/spi/ios/UIKitSPI.h: +* UIProcess/API/Cocoa/_WKElementAction.mm: +(+[_WKElementAction imageForElementActionType:]): + 2022-04-05 Stephan Szabo [PlayStation[ Fix build break after r292408 Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (292447 => 292448) --- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2022-04-06 03:41:00 UTC (rev 292447) +++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2022-04-06 04:07:25 UTC (rev 292448) @@ -378,6 +378,7 @@ @interface UIImage () - (id)initWithCGImage:(CGImageRef)CGImage imageOrientation:(UIImageOrientation)imageOrientation; - (UIImage *)_flatImageWithColor:(UIColor *)color; ++ (UIImage *)_systemImageNamed:(NSString *)name; @end @interface UIKeyCommand () Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm (292447 => 292448) --- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm 2022-04-06 03:41:00 UTC (rev 292447) +++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm 2022-04-06 04:07:25 UTC (rev 292448) @@ -263,7 +263,7 @@ #endif case _WKElementActionTypeRevealImage: #if ENABLE(IMAGE_ANALYSIS) -return [UIImage systemImageNamed:@"info.circle"]; +return [UIImage _systemImageNamed:@"info.circle.and.sparkles"]; #else return nil; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292447] trunk/Source/JavaScriptCore
Title: [292447] trunk/Source/_javascript_Core
Revision 292447
Author ysuz...@apple.com
Date 2022-04-05 20:41:00 -0700 (Tue, 05 Apr 2022)
Log Message
[JSC] Use inlined assertion for CodeBlock type
https://bugs.webkit.org/show_bug.cgi?id=238849
Reviewed by Michael Saboff.
We introduced probeDebug-based CodeBlock assertion, but it is too slow and causing timeout on Debug JSC tests.
Instead, we use inlined assertion which is much faster to prevent these Debug build timeout.
* assembler/AbortReason.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
* dfg/DFGThunks.cpp:
(JSC::DFG::osrEntryThunkGenerator):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
* jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):
* jit/JIT.cpp:
(JSC::JIT::compileAndLinkWithoutFinalizing):
* jit/JITCode.h:
(JSC::JITCode::offsetOfJITType):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbortReason.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGThunks.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JITCode.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292446 => 292447)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-06 03:27:14 UTC (rev 292446)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-06 03:41:00 UTC (rev 292447)
@@ -1,5 +1,35 @@
2022-04-05 Yusuke Suzuki
+[JSC] Use inlined assertion for CodeBlock type
+https://bugs.webkit.org/show_bug.cgi?id=238849
+
+Reviewed by Michael Saboff.
+
+We introduced probeDebug-based CodeBlock assertion, but it is too slow and causing timeout on Debug JSC tests.
+Instead, we use inlined assertion which is much faster to prevent these Debug build timeout.
+
+* assembler/AbortReason.h:
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::compileEntry):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
+* dfg/DFGThunks.cpp:
+(JSC::DFG::osrEntryThunkGenerator):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::lower):
+* jit/AssemblyHelpers.cpp:
+(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
+(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):
+* jit/AssemblyHelpers.h:
+(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameWithType):
+(JSC::AssemblyHelpers::jitAssertCodeBlockOnCallFrameIsOptimizingJIT):
+* jit/JIT.cpp:
+(JSC::JIT::compileAndLinkWithoutFinalizing):
+* jit/JITCode.h:
+(JSC::JITCode::offsetOfJITType):
+
+2022-04-05 Yusuke Suzuki
+
[JSC] Strictly annotate pointers with TrustedImmPtr in CCallHelpers
https://bugs.webkit.org/show_bug.cgi?id=238827
Modified: trunk/Source/_javascript_Core/assembler/AbortReason.h (292446 => 292447)
--- trunk/Source/_javascript_Core/assembler/AbortReason.h 2022-04-06 03:27:14 UTC (rev 292446)
+++ trunk/Source/_javascript_Core/assembler/AbortReason.h 2022-04-06 03:41:00 UTC (rev 292447)
@@ -42,6 +42,7 @@
AHIsNotJSNumber = 80,
AHIsNotNull = 90,
AHStackPointerMisaligned = 100,
+AHInvalidCodeBlock= 101,
AHStructureIDIsValid = 110,
AHNotCellMaskNotInPlace = 120,
AHNumberTagNotInPlace = 130,
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp (292446 => 292447)
--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp 2022-04-06 03:27:14 UTC (rev 292446)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp 2022-04-06 03:41:00 UTC (rev 292447)
@@ -111,12 +111,7 @@
// check) which will be dependent on stack layout. (We'd need to account for this in
// both normal return code and when jumping to an exception handler).
emitFunctionPrologue();
-#if ASSERT_ENABLED
-probeDebug([=](Probe::Context& ctx) {
-CodeBlock* codeBlock = ctx.fp()->codeBlock();
-RELEASE_ASSERT(codeBlock->jitType() == JITType::DFGJIT);
-});
-#endif
+jitAssertCodeBlockOnCallFrameWithType(GPRInfo::regT2, JITType::DFGJIT);
}
void JITCompiler::compileSetupRegistersForEntry()
[webkit-changes] [292446] trunk/Source/WebCore
Title: [292446] trunk/Source/WebCore
Revision 292446
Author andresg...@apple.com
Date 2022-04-05 20:27:14 -0700 (Tue, 05 Apr 2022)
Log Message
Eliminate delays for processing live regions and modal notifications.
https://bugs.webkit.org/show_bug.cgi?id=238833
Reviewed by Chris Fleizach.
We had arbitrary delays to process notifications for live regions and
modal elements. This is no longer necessary and may cause problems
updating the isolated tree that depends on these notifications being
processed in a timely manner.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleChildrenChanged):
(WebCore::AXObjectCache::postLiveRegionChangeNotification):
(WebCore::AXObjectCache::focusModalNode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292445 => 292446)
--- trunk/Source/WebCore/ChangeLog 2022-04-06 00:54:05 UTC (rev 292445)
+++ trunk/Source/WebCore/ChangeLog 2022-04-06 03:27:14 UTC (rev 292446)
@@ -1,3 +1,21 @@
+2022-04-05 Andres Gonzalez
+
+Eliminate delays for processing live regions and modal notifications.
+https://bugs.webkit.org/show_bug.cgi?id=238833
+
+
+Reviewed by Chris Fleizach.
+
+We had arbitrary delays to process notifications for live regions and
+modal elements. This is no longer necessary and may cause problems
+updating the isolated tree that depends on these notifications being
+processed in a timely manner.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::handleChildrenChanged):
+(WebCore::AXObjectCache::postLiveRegionChangeNotification):
+(WebCore::AXObjectCache::focusModalNode):
+
2022-04-05 Stephan Szabo
[PlayStation[ Fix build break after r292408
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (292445 => 292446)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-04-06 00:54:05 UTC (rev 292445)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-04-06 03:27:14 UTC (rev 292446)
@@ -127,8 +127,6 @@
// Post value change notifications for password fields or elements contained in password fields at a 40hz interval to thwart analysis of typing cadence
static const Seconds accessibilityPasswordValueChangeNotificationInterval { 25_ms };
-static const Seconds accessibilityLiveRegionChangedNotificationInterval { 20_ms };
-static const Seconds accessibilityFocusModalNodeNotificationInterval { 50_ms };
static bool rendererNeedsDeferredUpdate(const RenderObject& renderer)
{
@@ -1058,7 +1056,7 @@
parent->setNeedsToUpdateChildren();
// If this object supports ARIA live regions, then notify AT of changes.
-// This notification need to be sent even when the screen reader has not accessed this live region since the last update.
+// This notification needs to be sent even when the screen reader has not accessed this live region since the last update.
// Sometimes this function can be called many times within a short period of time, leading to posting too many AXLiveRegionChanged notifications.
// To fix this, we use a timer to make sure we only post one notification for the children changes within a pre-defined time interval.
if (parent->supportsLiveRegion())
@@ -1695,7 +1693,7 @@
if (!m_liveRegionObjectsSet.contains(object))
m_liveRegionObjectsSet.add(object);
-m_liveRegionChangedPostTimer.startOneShot(accessibilityLiveRegionChangedNotificationInterval);
+m_liveRegionChangedPostTimer.startOneShot(0_s);
}
void AXObjectCache::liveRegionChangedNotificationPostTimerFired()
@@ -1729,7 +1727,7 @@
if (m_focusModalNodeTimer.isActive())
m_focusModalNodeTimer.stop();
-m_focusModalNodeTimer.startOneShot(accessibilityFocusModalNodeNotificationInterval);
+m_focusModalNodeTimer.startOneShot(0_s);
}
void AXObjectCache::focusModalNodeTimerFired()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292444] trunk/Source/WebCore/PAL
Title: [292444] trunk/Source/WebCore/PAL
Revision 292444
Author e...@apple.com
Date 2022-04-05 17:24:58 -0700 (Tue, 05 Apr 2022)
Log Message
[XCBuild] PAL: Add headers-only dependency on WebGPU
https://bugs.webkit.org/show_bug.cgi?id=238646
Reviewed by Alexey Proskuryakov.
Lots of includes of WebGPU in pal/graphics/WebGPU/Impl, so the build system needs to know to
copy its headers before building PAL.
Clean up a file reference to a header that was removed in
https://commits.webkit.org/247364@main
* PAL.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (292443 => 292444)
--- trunk/Source/WebCore/PAL/ChangeLog 2022-04-06 00:08:40 UTC (rev 292443)
+++ trunk/Source/WebCore/PAL/ChangeLog 2022-04-06 00:24:58 UTC (rev 292444)
@@ -1,3 +1,18 @@
+2022-04-05 Elliott Williams
+
+[XCBuild] PAL: Add headers-only dependency on WebGPU
+https://bugs.webkit.org/show_bug.cgi?id=238646
+
+Reviewed by Alexey Proskuryakov.
+
+Lots of includes of WebGPU in pal/graphics/WebGPU/Impl, so the build system needs to know to
+copy its headers before building PAL.
+
+Clean up a file reference to a header that was removed in
+https://commits.webkit.org/247364@main
+
+* PAL.xcodeproj/project.pbxproj:
+
2022-04-05 Chris Dumez
Mark String(const char*) constructor as explicit
Modified: trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig (292443 => 292444)
--- trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig 2022-04-06 00:08:40 UTC (rev 292443)
+++ trunk/Source/WebCore/PAL/Configurations/PAL.xcconfig 2022-04-06 00:24:58 UTC (rev 292444)
@@ -63,7 +63,7 @@
EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_PRODUCT_DEPENDENCY_NAMES_$(WK_WHICH_BUILD_SYSTEM));
EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = $(inherited) *.tiff *Cursor.png;
-EXCLUDED_PRODUCT_DEPENDENCY_NAMES_legacy = libWTF.a libWebKitAdditions.a;
+EXCLUDED_PRODUCT_DEPENDENCY_NAMES_legacy = libWTF.a libWebKitAdditions.a WebGPU.framework;
WK_USE_OVERRIDE_FRAMEWORKS_DIR = $(WK_NOT_$(WK_EMPTY_$(WK_OVERRIDE_FRAMEWORKS_DIR)));
Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (292443 => 292444)
--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2022-04-06 00:08:40 UTC (rev 292443)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2022-04-06 00:24:58 UTC (rev 292444)
@@ -89,6 +89,7 @@
CD6122D12559B8F200FC657A /* OutputDevice.mm in Sources */ = {isa = PBXBuildFile; fileRef = CD6122CF2559B8F200FC657A /* OutputDevice.mm */; };
CDACB3602387425B0018D7CE /* MediaToolboxSoftLink.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDACB35E23873E480018D7CE /* MediaToolboxSoftLink.cpp */; };
DD05A36027BF0ACE0096EFAB /* libWTF.a in Product Dependencies */ = {isa = PBXBuildFile; fileRef = DD05A35F27BF0AC40096EFAB /* libWTF.a */; };
+ DD0B43C227F679A7009E31FC /* WebGPU.framework in Product Dependencies */ = {isa = PBXBuildFile; fileRef = DD0B43C127F67999009E31FC /* WebGPU.framework */; };
DD20DD1227BC90D60093D175 /* MediaTimeAVFoundation.h in Headers */ = {isa = PBXBuildFile; fileRef = 0C00CFD21F68CE4600AAC26D /* MediaTimeAVFoundation.h */; settings = {ATTRIBUTES = (Private, ); }; };
DD20DD1327BC90D60093D175 /* OutputContext.h in Headers */ = {isa = PBXBuildFile; fileRef = CD6122CA2559B6AC00FC657A /* OutputContext.h */; settings = {ATTRIBUTES = (Private, ); }; };
DD20DD1427BC90D60093D175 /* OutputDevice.h in Headers */ = {isa = PBXBuildFile; fileRef = CD6122CE2559B8F200FC657A /* OutputDevice.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -206,7 +207,6 @@
DD20DD8427BC90D70093D175 /* WebGPUPipelineDescriptorBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CC5E45E27374948006F6FF4 /* WebGPUPipelineDescriptorBase.h */; settings = {ATTRIBUTES = (Private, ); }; };
DD20DD8527BC90D70093D175 /* WebGPUPipelineLayout.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CC5E44527374947006F6FF4 /* WebGPUPipelineLayout.h */; settings = {ATTRIBUTES = (Private, ); }; };
DD20DD8627BC90D70093D175 /* WebGPUPipelineLayoutDescriptor.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CC5E44D27374947006F6FF4 /* WebGPUPipelineLayoutDescriptor.h */; settings = {ATTRIBUTES = (Private, ); }; };
- DD20DD8727BC90D70093D175 /* WebGPUPipelineStatisticName.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CC5E43927374946006F6FF4 /* WebGPUPipelineStatisticName.h */; settings = {ATTRIBUTES = (Private, ); }; };
DD20DD8827BC90D70093D175 /* WebGPUPowerPreference.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CC5E47A27374949006F6FF4 /* WebGPUPowerPreference.h */; settings = {ATTRIBUTES = (Private, ); }; };
DD20DD8927BC90D70093D175 /* WebGPUPredefinedColorSpace.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CC5E47D27374949006F6FF4 /* WebGPUPredefinedColorSpace.h */;
[webkit-changes] [292442] branches/safari-614.1.9-branch/Source/WebKit
Title: [292442] branches/safari-614.1.9-branch/Source/WebKit Revision 292442 Author repst...@apple.com Date 2022-04-05 17:08:38 -0700 (Tue, 05 Apr 2022) Log Message Cherry-pick r292426. rdar://problem/90808910 Verify generalStorageDirectory is not in use when creating WebsiteDataStore https://bugs.webkit.org/show_bug.cgi?id=238686 rdar://90808910 Reviewed by Chris Dumez. In r290739, we added assertion to verify that no two sessions share the same general storage directory. The assertion is hit on macOS as shown in rdar://90808910. However, because we checked the directories when launching new network process, not when creating WebsiteDataStore, the backtraces do not give much information about when the problematic WebsiteDataStore (using the generalStorageDirectory that's already used by another WebsiteDataStore) is created. To help debug the issue, let's move the assertion to the constructor of WebsiteDataStore. * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess): * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::activeGeneralStorageDirectories): (WebKit::WebsiteDataStore::WebsiteDataStore): (WebKit::WebsiteDataStore::~WebsiteDataStore): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292426 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-614.1.9-branch/Source/WebKit/ChangeLog branches/safari-614.1.9-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp branches/safari-614.1.9-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp Diff Modified: branches/safari-614.1.9-branch/Source/WebKit/ChangeLog (292441 => 292442) --- branches/safari-614.1.9-branch/Source/WebKit/ChangeLog 2022-04-05 23:52:51 UTC (rev 292441) +++ branches/safari-614.1.9-branch/Source/WebKit/ChangeLog 2022-04-06 00:08:38 UTC (rev 292442) @@ -1,3 +1,52 @@ +2022-04-05 Alan Coon + +Cherry-pick r292426. rdar://problem/90808910 + +Verify generalStorageDirectory is not in use when creating WebsiteDataStore +https://bugs.webkit.org/show_bug.cgi?id=238686 +rdar://90808910 + +Reviewed by Chris Dumez. + +In r290739, we added assertion to verify that no two sessions share the same general storage directory. The +assertion is hit on macOS as shown in rdar://90808910. However, because we checked the directories when +launching new network process, not when creating WebsiteDataStore, the backtraces do not give much information +about when the problematic WebsiteDataStore (using the generalStorageDirectory that's already used by another +WebsiteDataStore) is created. To help debug the issue, let's move the assertion to the constructor of +WebsiteDataStore. + +* UIProcess/Network/NetworkProcessProxy.cpp: +(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess): +* UIProcess/WebsiteData/WebsiteDataStore.cpp: +(WebKit::activeGeneralStorageDirectories): +(WebKit::WebsiteDataStore::WebsiteDataStore): +(WebKit::WebsiteDataStore::~WebsiteDataStore): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292426 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2022-04-05 Sihui Liu + +Verify generalStorageDirectory is not in use when creating WebsiteDataStore +https://bugs.webkit.org/show_bug.cgi?id=238686 +rdar://90808910 + +Reviewed by Chris Dumez. + +In r290739, we added assertion to verify that no two sessions share the same general storage directory. The +assertion is hit on macOS as shown in rdar://90808910. However, because we checked the directories when +launching new network process, not when creating WebsiteDataStore, the backtraces do not give much information +about when the problematic WebsiteDataStore (using the generalStorageDirectory that's already used by another +WebsiteDataStore) is created. To help debug the issue, let's move the assertion to the constructor of +WebsiteDataStore. + +* UIProcess/Network/NetworkProcessProxy.cpp: +(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess): +* UIProcess/WebsiteData/WebsiteDataStore.cpp: +(WebKit::activeGeneralStorageDirectories): +(WebKit::WebsiteDataStore::WebsiteDataStore): +(WebKit::WebsiteDataStore::~WebsiteDataStore): + 2022-04-03 Tim Horton _WKDataTask doesn't work in macCatalyst Modified: branches/safari-614.1.9-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (292441 => 292442) --- branches/safari-614.1.9-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2022-04-05 23:52:51 UTC (rev 292441) +++ branches/safari-614.1.9-branch/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2022-04-06 00:08:38 UTC (rev 292442) @@ -196,16
[webkit-changes] [292443] branches/safari-614.1.9-branch/Source/WebCore
Title: [292443] branches/safari-614.1.9-branch/Source/WebCore
Revision 292443
Author repst...@apple.com
Date 2022-04-05 17:08:40 -0700 (Tue, 05 Apr 2022)
Log Message
Cherry-pick r292430. rdar://problem/91293025
[Cocoa] Video is sometimes not visible after r292049
https://bugs.webkit.org/show_bug.cgi?id=238826
Reviewed by Jer Noble.
RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false),
the page visibility has not changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-614.1.9-branch/Source/WebCore/ChangeLog
branches/safari-614.1.9-branch/Source/WebCore/rendering/RenderVideo.cpp
Diff
Modified: branches/safari-614.1.9-branch/Source/WebCore/ChangeLog (292442 => 292443)
--- branches/safari-614.1.9-branch/Source/WebCore/ChangeLog 2022-04-06 00:08:38 UTC (rev 292442)
+++ branches/safari-614.1.9-branch/Source/WebCore/ChangeLog 2022-04-06 00:08:40 UTC (rev 292443)
@@ -1,3 +1,44 @@
+2022-04-05 Alan Coon
+
+Cherry-pick r292430. rdar://problem/91293025
+
+[Cocoa] Video is sometimes not visible after r292049
+https://bugs.webkit.org/show_bug.cgi?id=238826
+
+Reviewed by Jer Noble.
+
+RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
+MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
+HTMLMediaElement::visibilityStateChanged is the only other thing that calls
+MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
+so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
+recreated.
+
+* rendering/RenderVideo.cpp:
+(WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false),
+the page visibility has not changed.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-05 Eric Carlson
+
+[Cocoa] Video is sometimes not visible after r292049
+https://bugs.webkit.org/show_bug.cgi?id=238826
+
+Reviewed by Jer Noble.
+
+RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
+MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
+HTMLMediaElement::visibilityStateChanged is the only other thing that calls
+MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
+so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
+recreated.
+
+* rendering/RenderVideo.cpp:
+(WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false),
+the page visibility has not changed.
+
2022-04-02 Myles C. Maxfield
[Cocoa] Automatically relayout the page when new fonts are installed
Modified: branches/safari-614.1.9-branch/Source/WebCore/rendering/RenderVideo.cpp (292442 => 292443)
--- branches/safari-614.1.9-branch/Source/WebCore/rendering/RenderVideo.cpp 2022-04-06 00:08:38 UTC (rev 292442)
+++ branches/safari-614.1.9-branch/Source/WebCore/rendering/RenderVideo.cpp 2022-04-06 00:08:40 UTC (rev 292443)
@@ -65,16 +65,6 @@
void RenderVideo::willBeDestroyed()
{
visibleInViewportStateChanged();
-
-#if ENABLE(VIDEO_PRESENTATION_MODE)
-auto player = videoElement().player();
-if (player && videoElement().webkitPresentationMode() != HTMLVideoElement::VideoPresentationMode::PictureInPicture)
-player->setPageIsVisible(false);
-#else
-if (auto player = videoElement().player())
-player->setPageIsVisible(false);
-#endif
-
RenderMedia::willBeDestroyed();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292441] trunk/Source/WebInspectorUI
Title: [292441] trunk/Source/WebInspectorUI
Revision 292441
Author pan...@apple.com
Date 2022-04-05 16:52:51 -0700 (Tue, 05 Apr 2022)
Log Message
Web Inspector: Regression(r291729) The result of logging $0 to the console shows overlapping `$0` and `$[n]` after the node
https://bugs.webkit.org/show_bug.cgi?id=238843
Reviewed by Devin Rousso.
r291729 was missing a check that the `DOMTreeOutline` is actually supposed to show an indicator for the
inspected node, which means other uses of `DOMTreeOutline` (the console, the sources tab, etc.) were showing the
$0 indicator as well.
* UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline.prototype.update):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (292440 => 292441)
--- trunk/Source/WebInspectorUI/ChangeLog 2022-04-05 23:28:55 UTC (rev 292440)
+++ trunk/Source/WebInspectorUI/ChangeLog 2022-04-05 23:52:51 UTC (rev 292441)
@@ -1,3 +1,17 @@
+2022-04-05 Patrick Angle
+
+Web Inspector: Regression(r291729) The result of logging $0 to the console shows overlapping `$0` and `$[n]` after the node
+https://bugs.webkit.org/show_bug.cgi?id=238843
+
+Reviewed by Devin Rousso.
+
+r291729 was missing a check that the `DOMTreeOutline` is actually supposed to show an indicator for the
+inspected node, which means other uses of `DOMTreeOutline` (the console, the sources tab, etc.) were showing the
+$0 indicator as well.
+
+* UserInterface/Views/DOMTreeOutline.js:
+(WI.DOMTreeOutline.prototype.update):
+
2022-04-01 Michael Saboff
Stop copying StagedFrameworks to the secondary path by default
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js (292440 => 292441)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2022-04-05 23:28:55 UTC (rev 292440)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2022-04-05 23:52:51 UTC (rev 292441)
@@ -61,7 +61,8 @@
this._hideElementsKeyboardShortcut = new WI.KeyboardShortcut(null, "H", this._hideElements.bind(this), this.element);
this._hideElementsKeyboardShortcut.implicitlyPreventsDefault = false;
-if (showInspectedNode)
+this._showInspectedNode = !!showInspectedNode;
+if (this._showInspectedNode)
WI.domManager.addEventListener(WI.DOMManager.Event.InspectedNodeChanged, this._handleInspectedNodeChanged, this);
}
@@ -189,7 +190,7 @@
}
}
-if (WI.domManager.inspectedNode) {
+if (this._showInspectedNode && WI.domManager.inspectedNode) {
let inspectedNodeTreeElement = this.findTreeElement(WI.domManager.inspectedNode);
if (inspectedNodeTreeElement) {
inspectedNodeTreeElement.reveal();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292440] trunk/Source
Title: [292440] trunk/Source
Revision 292440
Author stephan.sz...@sony.com
Date 2022-04-05 16:28:55 -0700 (Tue, 05 Apr 2022)
Log Message
[PlayStation[ Fix build break after r292408
https://bugs.webkit.org/show_bug.cgi?id=238840
Unreviewed build fix.
Source/WebCore:
* platform/LocalizedStrings.cpp:
* platform/network/playstation/CurlSSLHandlePlayStation.cpp:
* platform/playstation/UserAgentPlayStation.cpp:
Source/WebKit:
* UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp
trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292439 => 292440)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 23:28:55 UTC (rev 292440)
@@ -1,3 +1,14 @@
+2022-04-05 Stephan Szabo
+
+[PlayStation[ Fix build break after r292408
+https://bugs.webkit.org/show_bug.cgi?id=238840
+
+Unreviewed build fix.
+
+* platform/LocalizedStrings.cpp:
+* platform/network/playstation/CurlSSLHandlePlayStation.cpp:
+* platform/playstation/UserAgentPlayStation.cpp:
+
2022-04-05 Matt Woodrow
Support transitions/animations on grid-template-columns|rows
Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (292439 => 292440)
--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2022-04-05 23:28:55 UTC (rev 292440)
@@ -82,7 +82,7 @@
return String::fromUTF8(result.get());
#else
notImplemented();
-return format;
+return String::fromUTF8(format);
#endif
}
#endif
Modified: trunk/Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp (292439 => 292440)
--- trunk/Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp 2022-04-05 23:28:55 UTC (rev 292440)
@@ -40,8 +40,8 @@
if (certificateData->size())
setCACertData(WTFMove(caCertData));
-setCipherList(CertificateStore::cipherSuites());
-setCurvesList(CertificateStore::supportedGroups());
+setCipherList(String::fromUTF8(CertificateStore::cipherSuites()));
+setCurvesList(String::fromUTF8(CertificateStore::supportedGroups()));
setIgnoreSSLErrors(CertificateStore::shouldIgnoreTLSErrors());
}
Modified: trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp (292439 => 292440)
--- trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp 2022-04-05 23:28:55 UTC (rev 292440)
@@ -43,9 +43,9 @@
#if HAS_GETENV_NP
char buf[32];
if (!getenv_np("SYSTEM_SOFTWARE_NAME", buf, sizeof(buf)))
-return buf;
+return String::fromUTF8(buf);
#endif
-return "PlayStation";
+return "PlayStation"_s;
}
static String getSystemSoftwareVersion()
@@ -53,9 +53,9 @@
#if HAS_GETENV_NP
char buf[32];
if (!getenv_np("SYSTEM_SOFTWARE_VERSION", buf, sizeof(buf)))
-return buf;
+return String::fromUTF8(buf);
#endif
-return "0.00";
+return "0.00"_s;
}
static constexpr const char* versionForUAString()
@@ -87,7 +87,7 @@
String finalApplicationVersion = applicationVersion;
if (finalApplicationVersion.isEmpty())
-finalApplicationVersion = versionForUAString();
+finalApplicationVersion = String::fromUTF8(versionForUAString());
return makeString(standardUserAgentStatic(), ' ', applicationName, '/', finalApplicationVersion);
}
Modified: trunk/Source/WebKit/ChangeLog (292439 => 292440)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 23:28:55 UTC (rev 292440)
@@ -1,3 +1,12 @@
+2022-04-05 Stephan Szabo
+
+[PlayStation[ Fix build break after r292408
+https://bugs.webkit.org/show_bug.cgi?id=238840
+
+Unreviewed build fix.
+
+* UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp:
+
2022-04-05 Alex Christensen
Revert r291598
Modified: trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp (292439 => 292440)
--- trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp 2022-04-05 23:19:46 UTC (rev 292439)
+++ trunk/Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp 2022-04-05 23:28:55 UTC (rev 292440)
@@ -74,7 +74,7 @@
NativeWebKeyboardEvent::HandledByInputMethod handledByInputMethod =
[webkit-changes] [292439] tags/Safari-613.2.5.0.1/
Title: [292439] tags/Safari-613.2.5.0.1/ Revision 292439 Author alanc...@apple.com Date 2022-04-05 16:19:46 -0700 (Tue, 05 Apr 2022) Log Message Tag Safari-613.2.5.0.1. Added Paths tags/Safari-613.2.5.0.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292438] branches/safari-613.2.5.0-branch/Source/WebKit
Title: [292438] branches/safari-613.2.5.0-branch/Source/WebKit
Revision 292438
Author alanc...@apple.com
Date 2022-04-05 16:18:23 -0700 (Tue, 05 Apr 2022)
Log Message
Cherry-pick r292431. rdar://problem/90677955
Revert r291598
https://bugs.webkit.org/show_bug.cgi?id=238842
Reviewed by Geoff Garen.
It caused some problems and needs further analysis.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.2.5.0-branch/Source/WebKit/ChangeLog
branches/safari-613.2.5.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
branches/safari-613.2.5.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: branches/safari-613.2.5.0-branch/Source/WebKit/ChangeLog (292437 => 292438)
--- branches/safari-613.2.5.0-branch/Source/WebKit/ChangeLog 2022-04-05 23:16:39 UTC (rev 292437)
+++ branches/safari-613.2.5.0-branch/Source/WebKit/ChangeLog 2022-04-05 23:18:23 UTC (rev 292438)
@@ -1,3 +1,35 @@
+2022-04-05 Alan Coon
+
+Cherry-pick r292431. rdar://problem/90677955
+
+Revert r291598
+https://bugs.webkit.org/show_bug.cgi?id=238842
+
+
+Reviewed by Geoff Garen.
+
+It caused some problems and needs further analysis.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::createWebSocketTask):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-05 Alex Christensen
+
+Revert r291598
+https://bugs.webkit.org/show_bug.cgi?id=238842
+
+
+Reviewed by Geoff Garen.
+
+It caused some problems and needs further analysis.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::createWebSocketTask):
+
2022-03-31 Alan Coon
Apply patch. rdar://problem/90957287
Modified: branches/safari-613.2.5.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (292437 => 292438)
--- branches/safari-613.2.5.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-04-05 23:16:39 UTC (rev 292437)
+++ branches/safari-613.2.5.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-04-05 23:18:23 UTC (rev 292438)
@@ -340,14 +340,6 @@
RetainPtr nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
-if (parameters.isMainFrameNavigation
-|| parameters.hadMainFrameMainResourcePrivateRelayed // This means it did not fail. FIXME: adjust names to reflect this.
-|| !parameters.topOrigin
-|| request.url().host() == parameters.topOrigin->host()) {
-if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
-[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
-}
-
#if ENABLE(APP_PRIVACY_REPORT)
mutableRequest.get().attribution = request.isAppInitiated() ? NSURLRequestAttributionDeveloper : NSURLRequestAttributionUser;
#endif
Modified: branches/safari-613.2.5.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (292437 => 292438)
--- branches/safari-613.2.5.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-05 23:16:39 UTC (rev 292437)
+++ branches/safari-613.2.5.0-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-05 23:18:23 UTC (rev 292438)
@@ -1716,17 +1716,6 @@
appPrivacyReportTestingData().didLoadAppInitiatedRequest(nsRequest.get().attribution == NSURLRequestAttributionDeveloper);
#endif
-// FIXME: This function can make up to 3 copies of a request.
-// Reduce that to one if the protocol is null, the request isn't app initiated,
-// or the main frame main resource was private relayed, then set all properties
-// on the one copy.
-if (hadMainFrameMainResourcePrivateRelayed || request.url().host() == clientOrigin.topOrigin.host) {
-RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
-if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
-[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
-nsRequest = WTFMove(mutableRequest);
-}
-
auto& sessionSet = sessionSetForPage(webPageProxyID);
RetainPtr task = [sessionSet.sessionWithCredentialStorage.session webSocketTaskWithRequest:nsRequest.get()];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292437] branches/safari-613.2.5.0-branch/Source
Title: [292437] branches/safari-613.2.5.0-branch/Source Revision 292437 Author alanc...@apple.com Date 2022-04-05 16:16:39 -0700 (Tue, 05 Apr 2022) Log Message Versioning. WebKit-7613.2.5.0.1 Modified Paths branches/safari-613.2.5.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.2.5.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.2.5.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.2.5.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.2.5.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.2.5.0-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.2.5.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.2.5.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.2.5.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.2.5.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (292436 => 292437) --- branches/safari-613.2.5.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-05 23:05:31 UTC (rev 292436) +++ branches/safari-613.2.5.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-05 23:16:39 UTC (rev 292437) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 5; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.5.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (292436 => 292437) --- branches/safari-613.2.5.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-05 23:05:31 UTC (rev 292436) +++ branches/safari-613.2.5.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-05 23:16:39 UTC (rev 292437) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 5; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.5.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (292436 => 292437) --- branches/safari-613.2.5.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-05 23:05:31 UTC (rev 292436) +++ branches/safari-613.2.5.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-05 23:16:39 UTC (rev 292437) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 5; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.5.0-branch/Source/WebCore/Configurations/Version.xcconfig (292436 => 292437) --- branches/safari-613.2.5.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-05 23:05:31 UTC (rev 292436) +++ branches/safari-613.2.5.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-05 23:16:39 UTC (rev 292437) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 5; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-613.2.5.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (292436 => 292437) --- branches/safari-613.2.5.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-05 23:05:31 UTC (rev 292436) +++ branches/safari-613.2.5.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-05 23:16:39 UTC (rev 292437) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 5; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are
[webkit-changes] [292436] tags/Safari-614.1.8.4/
Title: [292436] tags/Safari-614.1.8.4/ Revision 292436 Author alanc...@apple.com Date 2022-04-05 16:05:31 -0700 (Tue, 05 Apr 2022) Log Message Tag Safari-614.1.8.4. Added Paths tags/Safari-614.1.8.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292435] branches/safari-614.1.8-branch/Source/WebKit
Title: [292435] branches/safari-614.1.8-branch/Source/WebKit
Revision 292435
Author alanc...@apple.com
Date 2022-04-05 16:02:03 -0700 (Tue, 05 Apr 2022)
Log Message
Cherry-pick r292431. rdar://problem/91320393
Revert r291598
https://bugs.webkit.org/show_bug.cgi?id=238842
Reviewed by Geoff Garen.
It caused some problems and needs further analysis.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-614.1.8-branch/Source/WebKit/ChangeLog
branches/safari-614.1.8-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
branches/safari-614.1.8-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: branches/safari-614.1.8-branch/Source/WebKit/ChangeLog (292434 => 292435)
--- branches/safari-614.1.8-branch/Source/WebKit/ChangeLog 2022-04-05 23:00:50 UTC (rev 292434)
+++ branches/safari-614.1.8-branch/Source/WebKit/ChangeLog 2022-04-05 23:02:03 UTC (rev 292435)
@@ -1,3 +1,35 @@
+2022-04-05 Alan Coon
+
+Cherry-pick r292431. rdar://problem/91320393
+
+Revert r291598
+https://bugs.webkit.org/show_bug.cgi?id=238842
+
+
+Reviewed by Geoff Garen.
+
+It caused some problems and needs further analysis.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::createWebSocketTask):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-04-05 Alex Christensen
+
+Revert r291598
+https://bugs.webkit.org/show_bug.cgi?id=238842
+
+
+Reviewed by Geoff Garen.
+
+It caused some problems and needs further analysis.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::createWebSocketTask):
+
2022-04-04 Alan Coon
Cherry-pick r292258. rdar://problem/91069927
Modified: branches/safari-614.1.8-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (292434 => 292435)
--- branches/safari-614.1.8-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-04-05 23:00:50 UTC (rev 292434)
+++ branches/safari-614.1.8-branch/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-04-05 23:02:03 UTC (rev 292435)
@@ -340,14 +340,6 @@
RetainPtr nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
-if (parameters.isMainFrameNavigation
-|| parameters.hadMainFrameMainResourcePrivateRelayed // This means it did not fail. FIXME: adjust names to reflect this.
-|| !parameters.topOrigin
-|| request.url().host() == parameters.topOrigin->host()) {
-if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
-[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
-}
-
#if ENABLE(APP_PRIVACY_REPORT)
mutableRequest.get().attribution = request.isAppInitiated() ? NSURLRequestAttributionDeveloper : NSURLRequestAttributionUser;
#endif
Modified: branches/safari-614.1.8-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (292434 => 292435)
--- branches/safari-614.1.8-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-05 23:00:50 UTC (rev 292434)
+++ branches/safari-614.1.8-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-05 23:02:03 UTC (rev 292435)
@@ -1718,17 +1718,6 @@
appPrivacyReportTestingData().didLoadAppInitiatedRequest(nsRequest.get().attribution == NSURLRequestAttributionDeveloper);
#endif
-// FIXME: This function can make up to 3 copies of a request.
-// Reduce that to one if the protocol is null, the request isn't app initiated,
-// or the main frame main resource was private relayed, then set all properties
-// on the one copy.
-if (hadMainFrameMainResourcePrivateRelayed || request.url().host() == clientOrigin.topOrigin.host) {
-RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
-if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
-[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
-nsRequest = WTFMove(mutableRequest);
-}
-
auto& sessionSet = sessionSetForPage(webPageProxyID);
RetainPtr task = [sessionSet.sessionWithCredentialStorage.session webSocketTaskWithRequest:nsRequest.get()];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292434] branches/safari-613.2.5.0-branch/
Title: [292434] branches/safari-613.2.5.0-branch/ Revision 292434 Author alanc...@apple.com Date 2022-04-05 16:00:50 -0700 (Tue, 05 Apr 2022) Log Message New branch. Added Paths branches/safari-613.2.5.0-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292433] trunk/Source/WebKitLegacy
Title: [292433] trunk/Source/WebKitLegacy
Revision 292433
Author e...@apple.com
Date 2022-04-05 15:33:54 -0700 (Tue, 05 Apr 2022)
Log Message
Fix STP build error "no such file or directory: 'Technology'"
https://bugs.webkit.org/show_bug.cgi?id=238834
Reviewed by Alexey Proskuryakov.
* scripts/migrate-header-rule: Don't generate an export list when
building for Mac. We won't use it, and this script does not support
paths in FRAMEWORK_SEARCH_PATHS containing spaces.
Modified Paths
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/scripts/migrate-header-rule
Diff
Modified: trunk/Source/WebKitLegacy/ChangeLog (292432 => 292433)
--- trunk/Source/WebKitLegacy/ChangeLog 2022-04-05 22:31:41 UTC (rev 292432)
+++ trunk/Source/WebKitLegacy/ChangeLog 2022-04-05 22:33:54 UTC (rev 292433)
@@ -1,3 +1,15 @@
+2022-04-05 Elliott Williams
+
+Fix STP build error "no such file or directory: 'Technology'"
+https://bugs.webkit.org/show_bug.cgi?id=238834
+
+
+Reviewed by Alexey Proskuryakov.
+
+* scripts/migrate-header-rule: Don't generate an export list when
+building for Mac. We won't use it, and this script does not support
+paths in FRAMEWORK_SEARCH_PATHS containing spaces.
+
2022-04-04 Elliott Williams
[XCBuild] WebKitLegacy's "Migrated headers" script does not emit task information
Modified: trunk/Source/WebKitLegacy/scripts/migrate-header-rule (292432 => 292433)
--- trunk/Source/WebKitLegacy/scripts/migrate-header-rule 2022-04-05 22:31:41 UTC (rev 292432)
+++ trunk/Source/WebKitLegacy/scripts/migrate-header-rule 2022-04-05 22:33:54 UTC (rev 292433)
@@ -6,7 +6,10 @@
# Create a forwarding header to make all imports of this header use WebKitLegacy's header map.
echo "#import " > "${SCRIPT_OUTPUT_FILE_1}"
+if [ ${WK_PLATFORM_NAME} != macosx ]; then
+
# *_SEARCH_PATHS are already shell-escaped, convert to an array so we can pass a flag for each path.
+# Note that this method does not work for search paths which contain spaces (rdar://91303280).
eval HEADER_SEARCH_PATHS=(${HEADER_SEARCH_PATHS} ${SYSTEM_HEADER_SEARCH_PATHS})
eval FRAMEWORK_SEARCH_PATHS=(${FRAMEWORK_SEARCH_PATHS} ${SYSTEM_FRAMEWORK_SEARCH_PATHS})
@@ -13,5 +16,10 @@
# Create an export list, which will be used by "Generate Export Files" to make the
# EXPORTED_SYMBOLS_FILE passes to the linker.
for WK_CURRENT_ARCH in ${ARCHS}; do
-tapi reexport -target ${WK_CURRENT_ARCH}-${LLVM_TARGET_TRIPLE_VENDOR}-${LLVM_TARGET_TRIPLE_OS_VERSION}${LLVM_TARGET_TRIPLE_SUFFIX} -isysroot ${SDK_DIR} -I${BUILT_PRODUCTS_DIR} ${HEADER_SEARCH_PATHS[@]/#/-I} -F${BUILT_PRODUCTS_DIR} ${FRAMEWORK_SEARCH_PATHS[@]/#/-F} -DWEBCORE_EXPORT= "${SDK_DIR}/usr/include/TargetConditionals.h" "${INPUT_FILE_PATH}" -o /dev/stdout
+tapi reexport -target ${WK_CURRENT_ARCH}-${LLVM_TARGET_TRIPLE_VENDOR}-${LLVM_TARGET_TRIPLE_OS_VERSION}${LLVM_TARGET_TRIPLE_SUFFIX} -isysroot ${SDK_DIR} -I${BUILT_PRODUCTS_DIR} ${HEADER_SEARCH_PATHS[@]/#/-I} -F${BUILT_PRODUCTS_DIR} ${FRAMEWORK_SEARCH_PATHS[@]/#/-F} -DWEBCORE_EXPORT= "${SDK_DIR}/usr/include/TargetConditionals.h" "${INPUT_FILE_PATH}" -o /dev/stdout
done > "${SCRIPT_OUTPUT_FILE_2}"
+
+else
+# Mac platforms don't use this export list.
+touch "${SCRIPT_OUTPUT_FILE_2}"
+fi
\ No newline at end of file
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292431] trunk/Source/WebKit
Title: [292431] trunk/Source/WebKit
Revision 292431
Author achristen...@apple.com
Date 2022-04-05 15:16:44 -0700 (Tue, 05 Apr 2022)
Log Message
Revert r291598
https://bugs.webkit.org/show_bug.cgi?id=238842
Reviewed by Geoff Garen.
It caused some problems and needs further analysis.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292430 => 292431)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 21:56:44 UTC (rev 292430)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 22:16:44 UTC (rev 292431)
@@ -1,3 +1,16 @@
+2022-04-05 Alex Christensen
+
+Revert r291598
+https://bugs.webkit.org/show_bug.cgi?id=238842
+
+
+Reviewed by Geoff Garen.
+
+It caused some problems and needs further analysis.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::createWebSocketTask):
+
2022-04-05 Commit Queue
Unreviewed, reverting r291821.
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (292430 => 292431)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-04-05 21:56:44 UTC (rev 292430)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-04-05 22:16:44 UTC (rev 292431)
@@ -340,14 +340,6 @@
RetainPtr nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
-if (parameters.isMainFrameNavigation
-|| parameters.hadMainFrameMainResourcePrivateRelayed // This means it did not fail. FIXME: adjust names to reflect this.
-|| !parameters.topOrigin
-|| request.url().host() == parameters.topOrigin->host()) {
-if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
-[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
-}
-
#if ENABLE(APP_PRIVACY_REPORT)
mutableRequest.get().attribution = request.isAppInitiated() ? NSURLRequestAttributionDeveloper : NSURLRequestAttributionUser;
#endif
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (292430 => 292431)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-05 21:56:44 UTC (rev 292430)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-05 22:16:44 UTC (rev 292431)
@@ -1713,17 +1713,6 @@
appPrivacyReportTestingData().didLoadAppInitiatedRequest(nsRequest.get().attribution == NSURLRequestAttributionDeveloper);
#endif
-// FIXME: This function can make up to 3 copies of a request.
-// Reduce that to one if the protocol is null, the request isn't app initiated,
-// or the main frame main resource was private relayed, then set all properties
-// on the one copy.
-if (hadMainFrameMainResourcePrivateRelayed || request.url().host() == clientOrigin.topOrigin.host) {
-RetainPtr mutableRequest = adoptNS([nsRequest.get() mutableCopy]);
-if ([mutableRequest respondsToSelector:@selector(_setPrivacyProxyFailClosedForUnreachableNonMainHosts:)])
-[mutableRequest _setPrivacyProxyFailClosedForUnreachableNonMainHosts:YES];
-nsRequest = WTFMove(mutableRequest);
-}
-
auto& sessionSet = sessionSetForPage(webPageProxyID);
RetainPtr task = [sessionSet.sessionWithCredentialStorage.session webSocketTaskWithRequest:nsRequest.get()];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292430] trunk/Source/WebCore
Title: [292430] trunk/Source/WebCore
Revision 292430
Author eric.carl...@apple.com
Date 2022-04-05 14:56:44 -0700 (Tue, 05 Apr 2022)
Log Message
[Cocoa] Video is sometimes not visible after r292049
https://bugs.webkit.org/show_bug.cgi?id=238826
Reviewed by Jer Noble.
RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false),
the page visibility has not changed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderVideo.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292429 => 292430)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 21:52:00 UTC (rev 292429)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 21:56:44 UTC (rev 292430)
@@ -1,3 +1,21 @@
+2022-04-05 Eric Carlson
+
+[Cocoa] Video is sometimes not visible after r292049
+https://bugs.webkit.org/show_bug.cgi?id=238826
+
+Reviewed by Jer Noble.
+
+RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
+MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
+HTMLMediaElement::visibilityStateChanged is the only other thing that calls
+MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
+so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
+recreated.
+
+* rendering/RenderVideo.cpp:
+(WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false),
+the page visibility has not changed.
+
2022-04-05 Andres Gonzalez
Make subtrees collapsible in the output of the AXLogger streamSubtree.
Modified: trunk/Source/WebCore/rendering/RenderVideo.cpp (292429 => 292430)
--- trunk/Source/WebCore/rendering/RenderVideo.cpp 2022-04-05 21:52:00 UTC (rev 292429)
+++ trunk/Source/WebCore/rendering/RenderVideo.cpp 2022-04-05 21:56:44 UTC (rev 292430)
@@ -65,16 +65,6 @@
void RenderVideo::willBeDestroyed()
{
visibleInViewportStateChanged();
-
-#if ENABLE(VIDEO_PRESENTATION_MODE)
-auto player = videoElement().player();
-if (player && videoElement().webkitPresentationMode() != HTMLVideoElement::VideoPresentationMode::PictureInPicture)
-player->setPageIsVisible(false);
-#else
-if (auto player = videoElement().player())
-player->setPageIsVisible(false);
-#endif
-
RenderMedia::willBeDestroyed();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292429] trunk/Source/WebKit
Title: [292429] trunk/Source/WebKit
Revision 292429
Author commit-qu...@webkit.org
Date 2022-04-05 14:52:00 -0700 (Tue, 05 Apr 2022)
Log Message
Unreviewed, reverting r291821.
https://bugs.webkit.org/show_bug.cgi?id=238839
Invalid fix.
Reverted changeset:
"REGRESSION(r286590): Links with URL schemes are not clickable
in Mail"
https://bugs.webkit.org/show_bug.cgi?id=238262
https://commits.webkit.org/r291821
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292428 => 292429)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 21:52:00 UTC (rev 292429)
@@ -1,3 +1,17 @@
+2022-04-05 Commit Queue
+
+Unreviewed, reverting r291821.
+https://bugs.webkit.org/show_bug.cgi?id=238839
+
+Invalid fix.
+
+Reverted changeset:
+
+"REGRESSION(r286590): Links with URL schemes are not clickable
+in Mail"
+https://bugs.webkit.org/show_bug.cgi?id=238262
+https://commits.webkit.org/r291821
+
2022-04-05 Sihui Liu
Verify generalStorageDirectory is not in use when creating WebsiteDataStore
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (292428 => 292429)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-04-05 21:52:00 UTC (rev 292429)
@@ -1132,7 +1132,6 @@
(extension "com.apple.webkit.extension.mach")
(global-name
"com.apple.iconservices"
-"com.apple.lsd.open"
)
)
)
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp (292428 => 292429)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2022-04-05 21:52:00 UTC (rev 292429)
@@ -167,7 +167,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
-encoder << dynamicMachExtensionHandles;
encoder << dynamicIOKitExtensionHandles;
#endif
@@ -455,12 +454,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
-std::optional> dynamicMachExtensionHandles;
-decoder >> dynamicMachExtensionHandles;
-if (!dynamicMachExtensionHandles)
-return false;
-parameters.dynamicMachExtensionHandles = WTFMove(*dynamicMachExtensionHandles);
-
std::optional> dynamicIOKitExtensionHandles;
decoder >> dynamicIOKitExtensionHandles;
if (!dynamicIOKitExtensionHandles)
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.h (292428 => 292429)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2022-04-05 21:52:00 UTC (rev 292429)
@@ -208,7 +208,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
-Vector dynamicMachExtensionHandles;
Vector dynamicIOKitExtensionHandles;
#endif
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (292428 => 292429)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2022-04-05 21:52:00 UTC (rev 292429)
@@ -285,17 +285,6 @@
m_resolvedPaths.uiProcessBundleResourcePath = resolvePathForSandboxExtension(String { [[NSBundle mainBundle] resourcePath] });
}
-#if PLATFORM(IOS_FAMILY)
-static const Vector& nonBrowserServices()
-{
-ASSERT(isMainRunLoop());
-static NeverDestroyed services = Vector {
-"com.apple.lsd.open"_s,
-};
-return services;
-}
-#endif
-
void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy& process, WebProcessCreationParameters& parameters)
{
parameters.mediaMIMETypes = process.mediaMIMETypes();
@@ -396,9 +385,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
-if (!isFullWebBrowser())
-parameters.dynamicMachExtensionHandles = SandboxExtension::createHandlesForMachLookup(nonBrowserServices(), std::nullopt);
-
if (WebCore::deviceHasAGXCompilerService())
parameters.dynamicIOKitExtensionHandles = SandboxExtension::createHandlesForIOKitClassExtensions(WebCore::agxCompilerClasses(), std::nullopt);
#endif
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (292428 => 292429)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2022-04-05 21:52:00 UTC (rev 292429)
@@ -421,7 +421,6 @@
#endif
#if
[webkit-changes] [292428] trunk/Source/JavaScriptCore
Title: [292428] trunk/Source/_javascript_Core
Revision 292428
Author cdu...@apple.com
Date 2022-04-05 14:48:50 -0700 (Tue, 05 Apr 2022)
Log Message
Avoid unnecessary String constructions in IdentifiersFactory.cpp
https://bugs.webkit.org/show_bug.cgi?id=238819
Reviewed by Geoffrey Garen.
* inspector/IdentifiersFactory.cpp:
(Inspector::addPrefixToIdentifier):
(Inspector::IdentifiersFactory::createIdentifier):
(Inspector::IdentifiersFactory::requestId):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/IdentifiersFactory.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292427 => 292428)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-05 21:38:40 UTC (rev 292427)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-05 21:48:50 UTC (rev 292428)
@@ -1,5 +1,17 @@
2022-04-05 Chris Dumez
+Avoid unnecessary String constructions in IdentifiersFactory.cpp
+https://bugs.webkit.org/show_bug.cgi?id=238819
+
+Reviewed by Geoffrey Garen.
+
+* inspector/IdentifiersFactory.cpp:
+(Inspector::addPrefixToIdentifier):
+(Inspector::IdentifiersFactory::createIdentifier):
+(Inspector::IdentifiersFactory::requestId):
+
+2022-04-05 Chris Dumez
+
Mark String(const char*) constructor as explicit
https://bugs.webkit.org/show_bug.cgi?id=238693
Modified: trunk/Source/_javascript_Core/inspector/IdentifiersFactory.cpp (292427 => 292428)
--- trunk/Source/_javascript_Core/inspector/IdentifiersFactory.cpp 2022-04-05 21:38:40 UTC (rev 292427)
+++ trunk/Source/_javascript_Core/inspector/IdentifiersFactory.cpp 2022-04-05 21:48:50 UTC (rev 292428)
@@ -27,13 +27,15 @@
#include "config.h"
#include "IdentifiersFactory.h"
+#include
+
namespace Inspector {
namespace {
-static long s_lastUsedIdentifier = 0;
+static unsigned long s_lastUsedIdentifier = 0;
}
-static String addPrefixToIdentifier(const String& identifier)
+static String addPrefixToIdentifier(unsigned long identifier)
{
return makeString("0.", identifier);
}
@@ -40,14 +42,12 @@
String IdentifiersFactory::createIdentifier()
{
-return addPrefixToIdentifier(String::number(++s_lastUsedIdentifier));
+return addPrefixToIdentifier(++s_lastUsedIdentifier);
}
String IdentifiersFactory::requestId(unsigned long identifier)
{
-if (identifier)
-return addPrefixToIdentifier(String::number(identifier));
-return String();
+return identifier ? addPrefixToIdentifier(identifier) : String();
}
} // namespace Inspector
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292427] tags/Safari-614.1.7.6/
Title: [292427] tags/Safari-614.1.7.6/ Revision 292427 Author alanc...@apple.com Date 2022-04-05 14:38:40 -0700 (Tue, 05 Apr 2022) Log Message Tag Safari-614.1.7.6. Added Paths tags/Safari-614.1.7.6/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292426] trunk/Source/WebKit
Title: [292426] trunk/Source/WebKit
Revision 292426
Author sihui_...@apple.com
Date 2022-04-05 14:38:05 -0700 (Tue, 05 Apr 2022)
Log Message
Verify generalStorageDirectory is not in use when creating WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=238686
rdar://90808910
Reviewed by Chris Dumez.
In r290739, we added assertion to verify that no two sessions share the same general storage directory. The
assertion is hit on macOS as shown in rdar://90808910. However, because we checked the directories when
launching new network process, not when creating WebsiteDataStore, the backtraces do not give much information
about when the problematic WebsiteDataStore (using the generalStorageDirectory that's already used by another
WebsiteDataStore) is created. To help debug the issue, let's move the assertion to the constructor of
WebsiteDataStore.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::activeGeneralStorageDirectories):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292425 => 292426)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 21:37:35 UTC (rev 292425)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 21:38:05 UTC (rev 292426)
@@ -1,3 +1,25 @@
+2022-04-05 Sihui Liu
+
+Verify generalStorageDirectory is not in use when creating WebsiteDataStore
+https://bugs.webkit.org/show_bug.cgi?id=238686
+rdar://90808910
+
+Reviewed by Chris Dumez.
+
+In r290739, we added assertion to verify that no two sessions share the same general storage directory. The
+assertion is hit on macOS as shown in rdar://90808910. However, because we checked the directories when
+launching new network process, not when creating WebsiteDataStore, the backtraces do not give much information
+about when the problematic WebsiteDataStore (using the generalStorageDirectory that's already used by another
+WebsiteDataStore) is created. To help debug the issue, let's move the assertion to the constructor of
+WebsiteDataStore.
+
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::activeGeneralStorageDirectories):
+(WebKit::WebsiteDataStore::WebsiteDataStore):
+(WebKit::WebsiteDataStore::~WebsiteDataStore):
+
2022-04-05 Chris Dumez
Unreviewed GTK build fix after r292408.
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (292425 => 292426)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2022-04-05 21:37:35 UTC (rev 292425)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2022-04-05 21:38:05 UTC (rev 292426)
@@ -196,16 +196,7 @@
#if !PLATFORM(GTK) && !PLATFORM(WPE) // GTK and WPE don't use defaultNetworkProcess
parameters.websiteDataStoreParameters = WebsiteDataStore::parametersFromEachWebsiteDataStore();
-HashMap sessionForDirectory;
WebsiteDataStore::forEachWebsiteDataStore([&](auto& websiteDataStore) {
-if (websiteDataStore.isPersistent()) {
-if (auto directory = websiteDataStore.resolvedGeneralStorageDirectory(); !directory.isEmpty()) {
-auto sessionID = websiteDataStore.sessionID();
-// Persistent sessions sharing same storage directory may cause corruption.
-// If the assertion is hit, check if you have multiple WebsiteDataStores with the same generalStorageDirectory.
-RELEASE_ASSERT_WITH_MESSAGE(sessionForDirectory.add(directory, sessionID).isNewEntry, "GeneralStorageDirectory for session %" PRIu64 " is already in use by session %" PRIu64, sessionForDirectory.get(directory).toUInt64(), sessionID.toUInt64());
-}
-}
addSession(websiteDataStore, SendParametersToNetworkProcess::No);
});
#endif
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (292425 => 292426)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2022-04-05 21:37:35 UTC (rev 292425)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2022-04-05 21:38:05 UTC (rev 292426)
@@ -96,6 +96,12 @@
allowsWebsiteDataRecordsForAllOrigins = true;
}
+static HashMap& activeGeneralStorageDirectories()
+{
+static MainThreadNeverDestroyed> directoryToSessionMap;
+return directoryToSessionMap;
+}
+
static HashMap& allDataStores()
{
RELEASE_ASSERT(isUIThread());
@@ -139,6 +145,11 @@
platformInitialize();
ASSERT(RunLoop::isMain());
+
+if (auto directory =
[webkit-changes] [292425] branches/safari-614.1.8-branch/Source
Title: [292425] branches/safari-614.1.8-branch/Source Revision 292425 Author alanc...@apple.com Date 2022-04-05 14:37:35 -0700 (Tue, 05 Apr 2022) Log Message Versioning. WebKit-7614.1.8.4 Modified Paths branches/safari-614.1.8-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-614.1.8-branch/Source/_javascript_Core/Configurations/Version.xcconfig (292424 => 292425) --- branches/safari-614.1.8-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-05 21:32:15 UTC (rev 292424) +++ branches/safari-614.1.8-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-05 21:37:35 UTC (rev 292425) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (292424 => 292425) --- branches/safari-614.1.8-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-05 21:32:15 UTC (rev 292424) +++ branches/safari-614.1.8-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-05 21:37:35 UTC (rev 292425) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (292424 => 292425) --- branches/safari-614.1.8-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-05 21:32:15 UTC (rev 292424) +++ branches/safari-614.1.8-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-05 21:37:35 UTC (rev 292425) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/WebCore/Configurations/Version.xcconfig (292424 => 292425) --- branches/safari-614.1.8-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-05 21:32:15 UTC (rev 292424) +++ branches/safari-614.1.8-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-05 21:37:35 UTC (rev 292425) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (292424 => 292425) --- branches/safari-614.1.8-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-05 21:32:15 UTC (rev 292424) +++ branches/safari-614.1.8-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-05 21:37:35 UTC (rev 292425) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/WebGPU/Configurations/Version.xcconfig (292424 => 292425) --- branches/safari-614.1.8-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-05 21:32:15 UTC (rev 292424) +++ branches/safari-614.1.8-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-05 21:37:35 UTC (rev 292425) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 3; +MICRO_VERSION = 4; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (292424 => 292425) --- branches/safari-614.1.8-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-05 21:32:15 UTC (rev 292424) +++ branches/safari-614.1.8-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-05 21:37:35 UTC (rev 292425) @@ -1,7 +1,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 3; +MICRO_VERSION = 4;
[webkit-changes] [292424] branches/safari-614.1.7-branch/Source/WebKit
Title: [292424] branches/safari-614.1.7-branch/Source/WebKit
Revision 292424
Author alanc...@apple.com
Date 2022-04-05 14:32:15 -0700 (Tue, 05 Apr 2022)
Log Message
Cherry-pick r291823. rdar://problem/91315158
REGRESSION(STP142): "A _javascript_ exception occured: Can't find variable: utils" from SafariDriver
https://bugs.webkit.org/show_bug.cgi?id=238335
Reviewed by Devin Rousso.
Following r289467, we can't just copy the WebDriver atom scripts to the build products, since they now need to
have `utils.js` in any script that uses the `utils` namespace. The `WebKit.framework` copy of these scripts are
later used while building safaridriver, so they need to include the scripts as well.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-614.1.7-branch/Source/WebKit/ChangeLog
branches/safari-614.1.7-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: branches/safari-614.1.7-branch/Source/WebKit/ChangeLog (292423 => 292424)
--- branches/safari-614.1.7-branch/Source/WebKit/ChangeLog 2022-04-05 21:30:35 UTC (rev 292423)
+++ branches/safari-614.1.7-branch/Source/WebKit/ChangeLog 2022-04-05 21:32:15 UTC (rev 292424)
@@ -1,3 +1,34 @@
+2022-04-05 Russell Epstein
+
+Cherry-pick r291823. rdar://problem/91315158
+
+REGRESSION(STP142): "A _javascript_ exception occured: Can't find variable: utils" from SafariDriver
+https://bugs.webkit.org/show_bug.cgi?id=238335
+
+Reviewed by Devin Rousso.
+
+Following r289467, we can't just copy the WebDriver atom scripts to the build products, since they now need to
+have `utils.js` in any script that uses the `utils` namespace. The `WebKit.framework` copy of these scripts are
+later used while building safaridriver, so they need to include the scripts as well.
+
+* WebKit.xcodeproj/project.pbxproj:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-03-24 Patrick Angle
+
+REGRESSION(STP142): "A _javascript_ exception occured: Can't find variable: utils" from SafariDriver
+https://bugs.webkit.org/show_bug.cgi?id=238335
+
+Reviewed by Devin Rousso.
+
+Following r289467, we can't just copy the WebDriver atom scripts to the build products, since they now need to
+have `utils.js` in any script that uses the `utils` namespace. The `WebKit.framework` copy of these scripts are
+later used while building safaridriver, so they need to include the scripts as well.
+
+* WebKit.xcodeproj/project.pbxproj:
+
2022-03-26 Russell Epstein
Cherry-pick r291943. rdar://problem/90878560
Modified: branches/safari-614.1.7-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj (292423 => 292424)
--- branches/safari-614.1.7-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-04-05 21:30:35 UTC (rev 292423)
+++ branches/safari-614.1.7-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-04-05 21:32:15 UTC (rev 292424)
@@ -15629,7 +15629,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "DST_DIR=\"$TARGET_BUILD_DIR/$PRIVATE_HEADERS_FOLDER_PATH/atoms\"\nmkdir -p \"$DST_DIR\"\n\nfor ((i = 0; i < ${SCRIPT_INPUT_FILE_COUNT}; ++i)); do\neval WEBDRIVER_ATOM=\\${SCRIPT_INPUT_FILE_${i}}\nditto \"${WEBDRIVER_ATOM}\" \"${DST_DIR}/${WEBDRIVER_ATOM##*/}\"\ndone\n";
+ shellScript = "DST_DIR=\"$TARGET_BUILD_DIR/$PRIVATE_HEADERS_FOLDER_PATH/atoms\"\nmkdir -p \"$DST_DIR\"\n\nfor ((i = 0; i < ${SCRIPT_INPUT_FILE_COUNT}; ++i)); do\neval WEBDRIVER_ATOM=\\${SCRIPT_INPUT_FILE_${i}}\npython3 ${SRCROOT}/Scripts/generate-automation-atom.py \"${WEBDRIVER_ATOM}\" \"${DST_DIR}/${WEBDRIVER_ATOM##*/}\"\ndone\n";
};
A55DEAA61670402E003DB841 /* Check For Inappropriate Macros in External Headers */ = {
isa = PBXShellScriptBuildPhase;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292423] trunk/Source/WebKit
Title: [292423] trunk/Source/WebKit
Revision 292423
Author cdu...@apple.com
Date 2022-04-05 14:30:35 -0700 (Tue, 05 Apr 2022)
Log Message
Unreviewed GTK build fix after r292408.
* Platform/unix/LoggingUnix.cpp:
(WebKit::logLevelString):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/unix/LoggingUnix.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292422 => 292423)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 21:27:29 UTC (rev 292422)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 21:30:35 UTC (rev 292423)
@@ -1,5 +1,12 @@
2022-04-05 Chris Dumez
+Unreviewed GTK build fix after r292408.
+
+* Platform/unix/LoggingUnix.cpp:
+(WebKit::logLevelString):
+
+2022-04-05 Chris Dumez
+
Unreviewed build fix after r292408.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
Modified: trunk/Source/WebKit/Platform/unix/LoggingUnix.cpp (292422 => 292423)
--- trunk/Source/WebKit/Platform/unix/LoggingUnix.cpp 2022-04-05 21:27:29 UTC (rev 292422)
+++ trunk/Source/WebKit/Platform/unix/LoggingUnix.cpp 2022-04-05 21:30:35 UTC (rev 292423)
@@ -34,7 +34,7 @@
String logLevelString()
{
#if !LOG_DISABLED
-return getenv("WEBKIT_DEBUG");
+return String { getenv("WEBKIT_DEBUG") };
#else
return String();
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292422] trunk/Source/WebCore
Title: [292422] trunk/Source/WebCore
Revision 292422
Author andresg...@apple.com
Date 2022-04-05 14:27:29 -0700 (Tue, 05 Apr 2022)
Log Message
Make subtrees collapsible in the output of the AXLogger streamSubtree.
https://bugs.webkit.org/show_bug.cgi?id=238829
Reviewed by Chris Fleizach.
Moved the TextStream::GroupScope from the method logging an individual
object to the method logging the hierarchy. This allows to collapse the
entire subtree rooted at a given object.
* accessibility/AXLogger.cpp:
(WebCore::streamAXCoreObject):
(WebCore::streamSubtree):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXLogger.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292421 => 292422)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 21:21:43 UTC (rev 292421)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 21:27:29 UTC (rev 292422)
@@ -1,3 +1,19 @@
+2022-04-05 Andres Gonzalez
+
+Make subtrees collapsible in the output of the AXLogger streamSubtree.
+https://bugs.webkit.org/show_bug.cgi?id=238829
+
+
+Reviewed by Chris Fleizach.
+
+Moved the TextStream::GroupScope from the method logging an individual
+object to the method logging the hierarchy. This allows to collapse the
+entire subtree rooted at a given object.
+
+* accessibility/AXLogger.cpp:
+(WebCore::streamAXCoreObject):
+(WebCore::streamSubtree):
+
2022-04-05 Antti Koivisto
Avoid unnecessary traversal when updating list markers
Modified: trunk/Source/WebCore/accessibility/AXLogger.cpp (292421 => 292422)
--- trunk/Source/WebCore/accessibility/AXLogger.cpp 2022-04-05 21:21:43 UTC (rev 292421)
+++ trunk/Source/WebCore/accessibility/AXLogger.cpp 2022-04-05 21:27:29 UTC (rev 292422)
@@ -564,8 +564,6 @@
void streamAXCoreObject(TextStream& stream, const AXCoreObject& object, const OptionSet& options)
{
-TextStream::GroupScope groupScope(stream);
-
if (options & AXStreamOptions::ObjectID)
stream << "objectID " << object.objectID();
@@ -611,6 +609,7 @@
stream.increaseIndent();
+TextStream::GroupScope groupScope(stream);
streamAXCoreObject(stream, *object, options);
for (auto& child : object->children(false))
streamSubtree(stream, child, options);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292421] branches/safari-614.1.7-branch/Source
Title: [292421] branches/safari-614.1.7-branch/Source Revision 292421 Author alanc...@apple.com Date 2022-04-05 14:21:43 -0700 (Tue, 05 Apr 2022) Log Message Versioning. WebKit-7614.1.7.6 Modified Paths branches/safari-614.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-614.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-614.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-614.1.7-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-614.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-614.1.7-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-614.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-614.1.7-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-614.1.7-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-614.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig (292420 => 292421) --- branches/safari-614.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-05 21:10:42 UTC (rev 292420) +++ branches/safari-614.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-05 21:21:43 UTC (rev 292421) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (292420 => 292421) --- branches/safari-614.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-05 21:10:42 UTC (rev 292420) +++ branches/safari-614.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-05 21:21:43 UTC (rev 292421) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (292420 => 292421) --- branches/safari-614.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-05 21:10:42 UTC (rev 292420) +++ branches/safari-614.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-05 21:21:43 UTC (rev 292421) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.7-branch/Source/WebCore/Configurations/Version.xcconfig (292420 => 292421) --- branches/safari-614.1.7-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-05 21:10:42 UTC (rev 292420) +++ branches/safari-614.1.7-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-05 21:21:43 UTC (rev 292421) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (292420 => 292421) --- branches/safari-614.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-05 21:10:42 UTC (rev 292420) +++ branches/safari-614.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-05 21:21:43 UTC (rev 292421) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.7-branch/Source/WebGPU/Configurations/Version.xcconfig (292420 => 292421) --- branches/safari-614.1.7-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-05 21:10:42 UTC (rev 292420) +++ branches/safari-614.1.7-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-05 21:21:43 UTC (rev 292421) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (292420 => 292421) --- branches/safari-614.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-05 21:10:42 UTC (rev 292420) +++ branches/safari-614.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-05 21:21:43 UTC (rev 292421) @@ -1,7 +1,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 5; +MICRO_VERSION = 6;
[webkit-changes] [292420] trunk/LayoutTests
Title: [292420] trunk/LayoutTests Revision 292420 Author matteo_flo...@apple.com Date 2022-04-05 14:10:42 -0700 (Tue, 05 Apr 2022) Log Message [ Mac ] accessibility/mac/expanded-notification.html is a flaky text failure https://bugs.webkit.org/show_bug.cgi?id=238830 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292419 => 292420) --- trunk/LayoutTests/ChangeLog 2022-04-05 20:45:07 UTC (rev 292419) +++ trunk/LayoutTests/ChangeLog 2022-04-05 21:10:42 UTC (rev 292420) @@ -1,3 +1,12 @@ +2022-04-05 Matteo Flores + +[ Mac ] accessibility/mac/expanded-notification.html is a flaky text failure +https://bugs.webkit.org/show_bug.cgi?id=238830 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2022-04-05 Tim Nguyen Re-import css/selectors WPT Modified: trunk/LayoutTests/platform/mac/TestExpectations (292419 => 292420) --- trunk/LayoutTests/platform/mac/TestExpectations 2022-04-05 20:45:07 UTC (rev 292419) +++ trunk/LayoutTests/platform/mac/TestExpectations 2022-04-05 21:10:42 UTC (rev 292420) @@ -2208,6 +2208,8 @@ webkit.org/b/238824 http/tests/workers/service/openwindow-from-notification-click.html [ Pass Failure ] +webkit.org/b/238830 accessibility/mac/expanded-notification.html [ Pass Failure ] + webkit.org/b/215335 [ BigSur Release ] webanimations/css-transition-retargeting-during-ready-promise.html [ Pass Failure ] webkit.org/b/223472 [ BigSur Release arm64 ] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292418] trunk/Source/WebCore
Title: [292418] trunk/Source/WebCore
Revision 292418
Author an...@apple.com
Date 2022-04-05 13:24:03 -0700 (Tue, 05 Apr 2022)
Log Message
Avoid unnecessary traversal when updating list markers
https://bugs.webkit.org/show_bug.cgi?id=238795
Reviewed by Anders Carlsson.
This code could use a full rewrite but there are also some simple optimizations that can be done.
* rendering/RenderListItem.cpp:
(WebCore::nextListItemHelper):
Don't advance into non-rendered subtrees. We won't find any renderers there.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderListItem.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292417 => 292418)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 20:16:18 UTC (rev 292417)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 20:24:03 UTC (rev 292418)
@@ -1,3 +1,17 @@
+2022-04-05 Antti Koivisto
+
+Avoid unnecessary traversal when updating list markers
+https://bugs.webkit.org/show_bug.cgi?id=238795
+
+Reviewed by Anders Carlsson.
+
+This code could use a full rewrite but there are also some simple optimizations that can be done.
+
+* rendering/RenderListItem.cpp:
+(WebCore::nextListItemHelper):
+
+Don't advance into non-rendered subtrees. We won't find any renderers there.
+
2022-04-05 Chris Dumez
Implement faster lookup of HTML tags in the HTML parser
Modified: trunk/Source/WebCore/rendering/RenderListItem.cpp (292417 => 292418)
--- trunk/Source/WebCore/rendering/RenderListItem.cpp 2022-04-05 20:16:18 UTC (rev 292417)
+++ trunk/Source/WebCore/rendering/RenderListItem.cpp 2022-04-05 20:24:03 UTC (rev 292418)
@@ -124,7 +124,10 @@
{
auto* current =
auto advance = [&] {
-current = ElementTraversal::nextIncludingPseudo(*current, );
+if (!current->renderOrDisplayContentsStyle())
+current = ElementTraversal::nextIncludingPseudoSkippingChildren(*current, );
+else
+current = ElementTraversal::nextIncludingPseudo(*current, );
};
advance();
while (current) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292417] trunk/Source/WebCore
Title: [292417] trunk/Source/WebCore
Revision 292417
Author cdu...@apple.com
Date 2022-04-05 13:16:18 -0700 (Tue, 05 Apr 2022)
Log Message
Implement faster lookup of HTML tags in the HTML parser
https://bugs.webkit.org/show_bug.cgi?id=238804
Reviewed by Geoffrey Garen.
Implement faster lookup of HTML tags in the HTML parser by having make_names.pl generate
a findHTMLTag function that returns very efficient well-known HTML tag names.
It is a little more efficient that our current HTMLNameCache (0.4% progression on
Speedometer on MacBookAir 10,1, neutral on iMac20,1). Unlike the HTMLNameCache, It doesn't
require any hashing or additional storage since the set of well-known HTML tags is known
at compile time.
* dom/make_names.pl:
(printNamesHeaderFile):
(findMaxTagLength):
(tagsWithLength):
(generateFindTagForLength):
(printNamesCppFile):
* html/parser/AtomHTMLToken.h:
(WebCore::AtomHTMLToken::AtomHTMLToken):
* html/parser/HTMLNameCache.cpp:
(WebCore::HTMLNameCache::atomStringCache):
* html/parser/HTMLNameCache.h:
(WebCore::HTMLNameCache::makeAttributeValue):
(WebCore::HTMLNameCache::clear):
(WebCore::HTMLNameCache::makeAtomString):
(WebCore::HTMLNameCache::atomStringCacheSlot):
(WebCore::HTMLNameCache::makeTagName): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/make_names.pl
trunk/Source/WebCore/html/parser/AtomHTMLToken.h
trunk/Source/WebCore/html/parser/HTMLNameCache.cpp
trunk/Source/WebCore/html/parser/HTMLNameCache.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (292416 => 292417)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 20:11:37 UTC (rev 292416)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 20:16:18 UTC (rev 292417)
@@ -1,3 +1,35 @@
+2022-04-05 Chris Dumez
+
+Implement faster lookup of HTML tags in the HTML parser
+https://bugs.webkit.org/show_bug.cgi?id=238804
+
+Reviewed by Geoffrey Garen.
+
+Implement faster lookup of HTML tags in the HTML parser by having make_names.pl generate
+a findHTMLTag function that returns very efficient well-known HTML tag names.
+
+It is a little more efficient that our current HTMLNameCache (0.4% progression on
+Speedometer on MacBookAir 10,1, neutral on iMac20,1). Unlike the HTMLNameCache, It doesn't
+require any hashing or additional storage since the set of well-known HTML tags is known
+at compile time.
+
+* dom/make_names.pl:
+(printNamesHeaderFile):
+(findMaxTagLength):
+(tagsWithLength):
+(generateFindTagForLength):
+(printNamesCppFile):
+* html/parser/AtomHTMLToken.h:
+(WebCore::AtomHTMLToken::AtomHTMLToken):
+* html/parser/HTMLNameCache.cpp:
+(WebCore::HTMLNameCache::atomStringCache):
+* html/parser/HTMLNameCache.h:
+(WebCore::HTMLNameCache::makeAttributeValue):
+(WebCore::HTMLNameCache::clear):
+(WebCore::HTMLNameCache::makeAtomString):
+(WebCore::HTMLNameCache::atomStringCacheSlot):
+(WebCore::HTMLNameCache::makeTagName): Deleted.
+
2022-04-05 Alan Bujtas
[CSS-Contain] Flex layout should take "contain: inline-size" into account when computing the flex item's logical width
Modified: trunk/Source/WebCore/dom/make_names.pl (292416 => 292417)
--- trunk/Source/WebCore/dom/make_names.pl 2022-04-05 20:11:37 UTC (rev 292416)
+++ trunk/Source/WebCore/dom/make_names.pl 2022-04-05 20:16:18 UTC (rev 292417)
@@ -747,6 +747,9 @@
if (keys %allTags) {
print F "const unsigned $parameters{namespace}TagsCount = ", scalar(keys %allTags), ";\n";
print F "const WebCore::$parameters{namespace}QualifiedName* const* get$parameters{namespace}Tags();\n";
+if ($parameters{namespace} eq "HTML") {
+print F "AtomString find$parameters{namespace}Tag(Span);\n"
+}
}
if (keys %allAttrs) {
@@ -758,6 +761,86 @@
close F;
}
+sub findMaxTagLength
+{
+my $allTags = shift;
+
+my $maxLength = 0;
+foreach my $tagName (keys %{$allTags}) {
+my $tagLength = length($tagName);
+$maxLength = $tagLength if $tagLength > $maxLength;
+}
+return $maxLength;
+}
+
+sub tagsWithLength
+{
+my $allAttrs = shift;
+my $expectedLength = shift;
+
+my @tags = ();
+foreach my $tagName (sort keys %{$allAttrs}) {
+push(@tags, $tagName) if length($tagName) == $expectedLength;
+}
+return @tags;
+}
+
+sub generateFindTagForLength
+{
+my $indent = shift;
+my $tagsRef = shift;
+my $length = shift;
+my $currentIndex = shift;
+
+my @tags = @{$tagsRef};
+my $tagCount = @tags;
+if ($tagCount == 1) {
+my $tag = $tags[0];
+my $needsIfCheck = $currentIndex < $length;
+if ($needsIfCheck) {
+my $lengthToCompare = $length - $currentIndex;
+if ($lengthToCompare == 1) {
+my $letter = substr($tag, $currentIndex, 1);
+
[webkit-changes] [292416] trunk
Title: [292416] trunk
Revision 292416
Author za...@apple.com
Date 2022-04-05 13:11:37 -0700 (Tue, 05 Apr 2022)
Log Message
[CSS-Contain] Flex layout should take "contain: inline-size" into account when computing the flex item's logical width
https://bugs.webkit.org/show_bug.cgi?id=238805
Reviewed by Antti Koivisto.
Source/WebCore:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths const):
LayoutTests:
* TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (292415 => 292416)
--- trunk/LayoutTests/ChangeLog 2022-04-05 20:02:36 UTC (rev 292415)
+++ trunk/LayoutTests/ChangeLog 2022-04-05 20:11:37 UTC (rev 292416)
@@ -1,3 +1,12 @@
+2022-04-05 Alan Bujtas
+
+[CSS-Contain] Flex layout should take "contain: inline-size" into account when computing the flex item's logical width
+https://bugs.webkit.org/show_bug.cgi?id=238805
+
+Reviewed by Antti Koivisto.
+
+* TestExpectations:
+
2022-04-05 Matteo Flores
[ iOS Mac ] http/tests/workers/service/openwindow-from-notification-click.html is a flaky text failure
Modified: trunk/LayoutTests/TestExpectations (292415 => 292416)
--- trunk/LayoutTests/TestExpectations 2022-04-05 20:02:36 UTC (rev 292415)
+++ trunk/LayoutTests/TestExpectations 2022-04-05 20:11:37 UTC (rev 292416)
@@ -4636,7 +4636,6 @@
# CSS containment tests that fail
imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid.html [ ImageOnlyFailure ]
# webkit-ruby-text
imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (292415 => 292416)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 20:02:36 UTC (rev 292415)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 20:11:37 UTC (rev 292416)
@@ -1,3 +1,13 @@
+2022-04-05 Alan Bujtas
+
+[CSS-Contain] Flex layout should take "contain: inline-size" into account when computing the flex item's logical width
+https://bugs.webkit.org/show_bug.cgi?id=238805
+
+Reviewed by Antti Koivisto.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths const):
+
2022-04-05 Chris Dumez
Unreviewed WinCairo build fix after r292408.
Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (292415 => 292416)
--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2022-04-05 20:02:36 UTC (rev 292415)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2022-04-05 20:11:37 UTC (rev 292416)
@@ -102,7 +102,8 @@
minLogicalWidth += scrollbarWidth;
};
-if (shouldApplySizeContainment(*this)) {
+auto shouldIgnoreFlexItemContentForLogicalWidth = shouldApplySizeContainment(*this) || shouldApplyInlineSizeContainment(*this);
+if (shouldIgnoreFlexItemContentForLogicalWidth) {
addScrollbarWidth();
return;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292415] trunk/Source/WebKitLegacy/win
Title: [292415] trunk/Source/WebKitLegacy/win
Revision 292415
Author cdu...@apple.com
Date 2022-04-05 13:02:36 -0700 (Tue, 05 Apr 2022)
Log Message
Unreviewed WinCairo build fix after r292408.
* WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::initialize):
Modified Paths
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebCoreSupport/AcceleratedCompositingContext.cpp
Diff
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (292414 => 292415)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2022-04-05 20:01:09 UTC (rev 292414)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2022-04-05 20:02:36 UTC (rev 292415)
@@ -2,6 +2,13 @@
Unreviewed WinCairo build fix after r292408.
+* WebCoreSupport/AcceleratedCompositingContext.cpp:
+(AcceleratedCompositingContext::initialize):
+
+2022-04-05 Chris Dumez
+
+Unreviewed WinCairo build fix after r292408.
+
* WebView.cpp:
(imeNotificationName):
(imeRequestName):
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/AcceleratedCompositingContext.cpp (292414 => 292415)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/AcceleratedCompositingContext.cpp 2022-04-05 20:01:09 UTC (rev 292414)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/AcceleratedCompositingContext.cpp 2022-04-05 20:02:36 UTC (rev 292415)
@@ -90,8 +90,8 @@
m_nonCompositedContentLayer->setAcceleratesDrawing(true);
#ifndef NDEBUG
-m_rootLayer->setName("Root layer");
-m_nonCompositedContentLayer->setName("Non-composited content");
+m_rootLayer->setName("Root layer"_s);
+m_nonCompositedContentLayer->setName("Non-composited content"_s);
#endif
m_rootLayer->addChild(*m_nonCompositedContentLayer);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292414] trunk/Source/WebGPU
Title: [292414] trunk/Source/WebGPU Revision 292414 Author mmaxfi...@apple.com Date 2022-04-05 13:01:09 -0700 (Tue, 05 Apr 2022) Log Message [WebGPU] Set svn:ignore on WebGPU.xcodeproj https://bugs.webkit.org/show_bug.cgi?id=238828 Reviewed by Alexey Proskuryakov. For people who use pure SVN, building causes some spurious files to be created. Other WebKit projects solve this by setting svn:ignore on .xcodeproj directories. This does the same. % svn propget svn:ignore WebGPU.xcodeproj *.mode* *.pbxuser *.perspective* project.xcworkspace xcuserdata % * WebGPU.xcodeproj: Set svn:ignore. Modified Paths trunk/Source/WebGPU/ChangeLog Property Changed trunk/Source/WebGPU/WebGPU.xcodeproj/ Diff Modified: trunk/Source/WebGPU/ChangeLog (292413 => 292414) --- trunk/Source/WebGPU/ChangeLog 2022-04-05 19:54:03 UTC (rev 292413) +++ trunk/Source/WebGPU/ChangeLog 2022-04-05 20:01:09 UTC (rev 292414) @@ -1,3 +1,25 @@ +2022-04-04 Myles C. Maxfield + +[WebGPU] Set svn:ignore on WebGPU.xcodeproj +https://bugs.webkit.org/show_bug.cgi?id=238828 + +Reviewed by Alexey Proskuryakov. + +For people who use pure SVN, building causes some spurious files to be created. +Other WebKit projects solve this by setting svn:ignore on .xcodeproj directories. +This does the same. + +% svn propget svn:ignore WebGPU.xcodeproj +*.mode* +*.pbxuser +*.perspective* +project.xcworkspace +xcuserdata + +% + +* WebGPU.xcodeproj: Set svn:ignore. + 2022-04-05 Chris Dumez Mark String(const char*) constructor as explicit Index: trunk/Source/WebGPU/WebGPU.xcodeproj === --- trunk/Source/WebGPU/WebGPU.xcodeproj 2022-04-05 19:54:03 UTC (rev 292413) +++ trunk/Source/WebGPU/WebGPU.xcodeproj 2022-04-05 20:01:09 UTC (rev 292414) Property changes: trunk/Source/WebGPU/WebGPU.xcodeproj Added: svn:ignore +*.mode* +*.pbxuser +*.perspective* +project.xcworkspace +xcuserdata ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292413] trunk/Source
Title: [292413] trunk/Source
Revision 292413
Author cdu...@apple.com
Date 2022-04-05 12:54:03 -0700 (Tue, 05 Apr 2022)
Log Message
Unreviewed WinCairo build fix after r292408.
Source/WebCore:
* platform/win/GDIObjectCounter.cpp:
(WebCore::GDIObjectCounter::GDIObjectCounter):
* platform/win/GDIObjectCounter.h:
Source/WebKitLegacy/win:
* WebView.cpp:
(imeNotificationName):
(imeRequestName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/GDIObjectCounter.cpp
trunk/Source/WebCore/platform/win/GDIObjectCounter.h
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292412 => 292413)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 19:47:28 UTC (rev 292412)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 19:54:03 UTC (rev 292413)
@@ -1,5 +1,13 @@
2022-04-05 Chris Dumez
+Unreviewed WinCairo build fix after r292408.
+
+* platform/win/GDIObjectCounter.cpp:
+(WebCore::GDIObjectCounter::GDIObjectCounter):
+* platform/win/GDIObjectCounter.h:
+
+2022-04-05 Chris Dumez
+
Unreviewed Windows debug build fix after r292279.
* animation/CSSPropertyAnimation.cpp:
Modified: trunk/Source/WebCore/platform/win/GDIObjectCounter.cpp (292412 => 292413)
--- trunk/Source/WebCore/platform/win/GDIObjectCounter.cpp 2022-04-05 19:47:28 UTC (rev 292412)
+++ trunk/Source/WebCore/platform/win/GDIObjectCounter.cpp 2022-04-05 19:54:03 UTC (rev 292413)
@@ -40,9 +40,9 @@
namespace WebCore {
-GDIObjectCounter::GDIObjectCounter(const String& identifier)
+GDIObjectCounter::GDIObjectCounter(const char* identifier)
{
-init(identifier);
+init(String { identifier });
}
GDIObjectCounter::GDIObjectCounter(const String& className, void* instance)
Modified: trunk/Source/WebCore/platform/win/GDIObjectCounter.h (292412 => 292413)
--- trunk/Source/WebCore/platform/win/GDIObjectCounter.h 2022-04-05 19:47:28 UTC (rev 292412)
+++ trunk/Source/WebCore/platform/win/GDIObjectCounter.h 2022-04-05 19:54:03 UTC (rev 292413)
@@ -43,7 +43,7 @@
class GDIObjectCounter {
public:
-GDIObjectCounter(const String& identifier);
+GDIObjectCounter(const char* identifier);
GDIObjectCounter(const String& className, void* instance);
~GDIObjectCounter();
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (292412 => 292413)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2022-04-05 19:47:28 UTC (rev 292412)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2022-04-05 19:54:03 UTC (rev 292413)
@@ -1,5 +1,13 @@
2022-04-05 Chris Dumez
+Unreviewed WinCairo build fix after r292408.
+
+* WebView.cpp:
+(imeNotificationName):
+(imeRequestName):
+
+2022-04-05 Chris Dumez
+
Mark String(const char*) constructor as explicit
https://bugs.webkit.org/show_bug.cgi?id=238693
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (292412 => 292413)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2022-04-05 19:47:28 UTC (rev 292412)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2022-04-05 19:54:03 UTC (rev 292413)
@@ -6079,31 +6079,31 @@
{
switch (wparam) {
case IMN_CHANGECANDIDATE:
-return "IMN_CHANGECANDIDATE";
+return "IMN_CHANGECANDIDATE"_s;
case IMN_CLOSECANDIDATE:
-return "IMN_CLOSECANDIDATE";
+return "IMN_CLOSECANDIDATE"_s;
case IMN_CLOSESTATUSWINDOW:
-return "IMN_CLOSESTATUSWINDOW";
+return "IMN_CLOSESTATUSWINDOW"_s;
case IMN_GUIDELINE:
-return "IMN_GUIDELINE";
+return "IMN_GUIDELINE"_s;
case IMN_OPENCANDIDATE:
-return "IMN_OPENCANDIDATE";
+return "IMN_OPENCANDIDATE"_s;
case IMN_OPENSTATUSWINDOW:
-return "IMN_OPENSTATUSWINDOW";
+return "IMN_OPENSTATUSWINDOW"_s;
case IMN_SETCANDIDATEPOS:
-return "IMN_SETCANDIDATEPOS";
+return "IMN_SETCANDIDATEPOS"_s;
case IMN_SETCOMPOSITIONFONT:
-return "IMN_SETCOMPOSITIONFONT";
+return "IMN_SETCOMPOSITIONFONT"_s;
case IMN_SETCOMPOSITIONWINDOW:
-return "IMN_SETCOMPOSITIONWINDOW";
+return "IMN_SETCOMPOSITIONWINDOW"_s;
case IMN_SETCONVERSIONMODE:
-return "IMN_SETCONVERSIONMODE";
+return "IMN_SETCONVERSIONMODE"_s;
case IMN_SETOPENSTATUS:
-return "IMN_SETOPENSTATUS";
+return "IMN_SETOPENSTATUS"_s;
case IMN_SETSENTENCEMODE:
-return "IMN_SETSENTENCEMODE";
+return "IMN_SETSENTENCEMODE"_s;
case IMN_SETSTATUSWINDOWPOS:
-return "IMN_SETSTATUSWINDOWPOS";
+return "IMN_SETSTATUSWINDOWPOS"_s;
default:
return "Unknown (" + String::number(wparam) + ")";
}
@@ -6113,19 +6113,19 @@
{
switch (wparam) {
case IMR_CANDIDATEWINDOW:
-return "IMR_CANDIDATEWINDOW";
+return "IMR_CANDIDATEWINDOW"_s;
case IMR_COMPOSITIONFONT:
-return "IMR_COMPOSITIONFONT";
[webkit-changes] [292412] trunk/Source/WebCore
Title: [292412] trunk/Source/WebCore Revision 292412 Author cdu...@apple.com Date 2022-04-05 12:47:28 -0700 (Tue, 05 Apr 2022) Log Message Unreviewed Windows debug build fix after r292279. * animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (292411 => 292412) --- trunk/Source/WebCore/ChangeLog 2022-04-05 19:46:00 UTC (rev 292411) +++ trunk/Source/WebCore/ChangeLog 2022-04-05 19:47:28 UTC (rev 292412) @@ -1,5 +1,12 @@ 2022-04-05 Chris Dumez +Unreviewed Windows debug build fix after r292279. + +* animation/CSSPropertyAnimation.cpp: +(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): + +2022-04-05 Chris Dumez + Mark String(const char*) constructor as explicit https://bugs.webkit.org/show_bug.cgi?id=238693 Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (292411 => 292412) --- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-04-05 19:46:00 UTC (rev 292411) +++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-04-05 19:47:28 UTC (rev 292412) @@ -3310,10 +3310,14 @@ // When adding a new property, you should make sure it belongs in this list // or provide a wrapper for it above. If you are adding to this list but the // property should be animatable, make sure to file a bug. +#if ENABLE(DARK_MODE_CSS) case CSSPropertyColorScheme: +#endif case CSSPropertyDirection: case CSSPropertyDisplay: +#if ENABLE(VARIATION_FONTS) case CSSPropertyFontOpticalSizing: +#endif case CSSPropertyTextOrientation: case CSSPropertyWritingMode: case CSSPropertyWebkitFontSmoothing: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292410] trunk/Source/WebKit
Title: [292410] trunk/Source/WebKit
Revision 292410
Author cdu...@apple.com
Date 2022-04-05 12:42:38 -0700 (Tue, 05 Apr 2022)
Log Message
Unreviewed build fix after r292408.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::removeNetworkWebsiteData):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292409 => 292410)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 18:54:46 UTC (rev 292409)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 19:42:38 UTC (rev 292410)
@@ -1,5 +1,12 @@
2022-04-05 Chris Dumez
+Unreviewed build fix after r292408.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::removeNetworkWebsiteData):
+
+2022-04-05 Chris Dumez
+
Mark String(const char*) constructor as explicit
https://bugs.webkit.org/show_bug.cgi?id=238693
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (292409 => 292410)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-05 18:54:46 UTC (rev 292409)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2022-04-05 19:42:38 UTC (rev 292410)
@@ -1935,7 +1935,7 @@
}
if (isActingOnBehalfOfAFullWebBrowser(bundleID))
-bundleID = "com.apple.mobilesafari";
+bundleID = "com.apple.mobilesafari"_s;
NSDictionary *options = @{
(id)getkSymptomAnalyticsServiceDomainTrackingClearHistoryKey(): @{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292409] trunk/LayoutTests
Title: [292409] trunk/LayoutTests Revision 292409 Author matteo_flo...@apple.com Date 2022-04-05 11:54:46 -0700 (Tue, 05 Apr 2022) Log Message [ iOS Mac ] http/tests/workers/service/openwindow-from-notification-click.html is a flaky text failure https://bugs.webkit.org/show_bug.cgi?id=238824 Unreviewed test gardening. * platform/ios/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292408 => 292409) --- trunk/LayoutTests/ChangeLog 2022-04-05 18:54:26 UTC (rev 292408) +++ trunk/LayoutTests/ChangeLog 2022-04-05 18:54:46 UTC (rev 292409) @@ -1,3 +1,13 @@ +2022-04-05 Matteo Flores + +[ iOS Mac ] http/tests/workers/service/openwindow-from-notification-click.html is a flaky text failure +https://bugs.webkit.org/show_bug.cgi?id=238824 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: +* platform/mac/TestExpectations: + 2022-04-05 Alan Bujtas [CSS-Contain] Add support for contain: inline-size Modified: trunk/LayoutTests/platform/ios/TestExpectations (292408 => 292409) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-04-05 18:54:26 UTC (rev 292408) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-04-05 18:54:46 UTC (rev 292409) @@ -3558,6 +3558,8 @@ webkit.org/b/237108 http/tests/websocket/tests/hybi/extensions.html [ Pass ] +webkit.org/b/238824 http/tests/workers/service/openwindow-from-notification-click.html [ Pass Failure ] + webkit.org/b/237433 editing/pasteboard/4076267-3.html [ Timeout Pass Failure ] webkit.org/b/237433 editing/pasteboard/paste-and-sanitize.html [ Timeout Pass Failure ] Modified: trunk/LayoutTests/platform/mac/TestExpectations (292408 => 292409) --- trunk/LayoutTests/platform/mac/TestExpectations 2022-04-05 18:54:26 UTC (rev 292408) +++ trunk/LayoutTests/platform/mac/TestExpectations 2022-04-05 18:54:46 UTC (rev 292409) @@ -2206,6 +2206,8 @@ webkit.org/b/226598 animations/leak-document-with-css-animation.html [ Pass Failure ] +webkit.org/b/238824 http/tests/workers/service/openwindow-from-notification-click.html [ Pass Failure ] + webkit.org/b/215335 [ BigSur Release ] webanimations/css-transition-retargeting-during-ready-promise.html [ Pass Failure ] webkit.org/b/223472 [ BigSur Release arm64 ] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292407] trunk/Source/bmalloc
Title: [292407] trunk/Source/bmalloc
Revision 292407
Author basuke.suz...@sony.com
Date 2022-04-05 11:45:09 -0700 (Tue, 05 Apr 2022)
Log Message
[PlayStation] Enable libpas.
https://bugs.webkit.org/show_bug.cgi?id=238753
Reviewed by Yusuke Suzuki.
PlayStation platform is ready to enable it finally.
* PlatformPlayStation.cmake:
* bmalloc/BPlatform.h:
* libpas/src/libpas/pas_config.h:
* libpas/src/libpas/pas_page_malloc.c:
(pas_page_malloc_try_allocate_without_deallocating_padding):
(commit_impl):
* libpas/src/libpas/pas_platform.h:
* libpas/src/libpas/pas_thread_local_cache.c:
Modified Paths
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/PlatformPlayStation.cmake
trunk/Source/bmalloc/bmalloc/BPlatform.h
trunk/Source/bmalloc/libpas/src/libpas/pas_config.h
trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c
trunk/Source/bmalloc/libpas/src/libpas/pas_segmented_vector.h
trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_heap.c
trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_size_directory.c
trunk/Source/bmalloc/libpas/src/libpas/pas_segregated_size_directory.h
trunk/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c
trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h
Diff
Modified: trunk/Source/bmalloc/ChangeLog (292406 => 292407)
--- trunk/Source/bmalloc/ChangeLog 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/ChangeLog 2022-04-05 18:45:09 UTC (rev 292407)
@@ -1,3 +1,21 @@
+2022-04-05 Basuke Suzuki
+
+[PlayStation] Enable libpas.
+https://bugs.webkit.org/show_bug.cgi?id=238753
+
+Reviewed by Yusuke Suzuki.
+
+PlayStation platform is ready to enable it finally.
+
+* PlatformPlayStation.cmake:
+* bmalloc/BPlatform.h:
+* libpas/src/libpas/pas_config.h:
+* libpas/src/libpas/pas_page_malloc.c:
+(pas_page_malloc_try_allocate_without_deallocating_padding):
+(commit_impl):
+* libpas/src/libpas/pas_platform.h:
+* libpas/src/libpas/pas_thread_local_cache.c:
+
2022-04-04 Yusuke Suzuki
[libpas] Do not need to call pthread_set_qos_class_self_np repeatedly
Modified: trunk/Source/bmalloc/PlatformPlayStation.cmake (292406 => 292407)
--- trunk/Source/bmalloc/PlatformPlayStation.cmake 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/PlatformPlayStation.cmake 2022-04-05 18:45:09 UTC (rev 292407)
@@ -1,8 +1,15 @@
+WEBKIT_APPEND_GLOBAL_COMPILER_FLAGS(
+-Wno-typedef-redefinition)
+
if (${CMAKE_GENERATOR} MATCHES "Visual Studio")
+set(bmalloc_C_SOURCES ${bmalloc_SOURCES})
+list(FILTER bmalloc_C_SOURCES INCLUDE REGEX "\\.c$")
+
# With the VisualStudio generator, the compiler complains about -std=c++* for C sources.
set_source_files_properties(
-${bmalloc_SOURCES}
-PROPERTIES LANGUAGE CXX
+${bmalloc_C_SOURCES}
+PROPERTIES LANGUAGE C
+COMPILE_OPTIONS --std=gnu17
)
endif ()
Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (292406 => 292407)
--- trunk/Source/bmalloc/bmalloc/BPlatform.h 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/bmalloc/BPlatform.h 2022-04-05 18:45:09 UTC (rev 292407)
@@ -324,7 +324,7 @@
/* BENABLE(LIBPAS) is enabling libpas build. But this does not mean we use libpas for bmalloc replacement. */
#if !defined(BENABLE_LIBPAS)
-#if BCPU(ADDRESS64) && (BOS(DARWIN) || (BOS(LINUX) && !BPLATFORM(GTK) && !BPLATFORM(WPE)))
+#if BCPU(ADDRESS64) && (BOS(DARWIN) || (BOS(LINUX) && !BPLATFORM(GTK) && !BPLATFORM(WPE))) || BPLATFORM(PLAYSTATION)
#define BENABLE_LIBPAS 1
#ifndef PAS_BMALLOC
#define PAS_BMALLOC 1
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_config.h (292406 => 292407)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_config.h 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_config.h 2022-04-05 18:45:09 UTC (rev 292407)
@@ -38,7 +38,7 @@
#endif
#endif
-#if PAS_OS(DARWIN) && __PAS_ARM64 && !__PAS_ARM64E && defined(NDEBUG)
+#if ((PAS_OS(DARWIN) && __PAS_ARM64 && !__PAS_ARM64E) || PAS_PLATFORM(PLAYSTATION)) && defined(NDEBUG)
#define PAS_ENABLE_ASSERT 0
#else
#define PAS_ENABLE_ASSERT 1
@@ -54,7 +54,7 @@
#define PAS_ADDRESS_BITS 48
-#if PAS_ARM
+#if PAS_ARM || PAS_PLATFORM(PLAYSTATION)
#define PAS_MAX_GRANULES 256
#else
#define PAS_MAX_GRANULES 1024
Modified: trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c (292406 => 292407)
--- trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c 2022-04-05 18:25:27 UTC (rev 292406)
+++ trunk/Source/bmalloc/libpas/src/libpas/pas_page_malloc.c 2022-04-05 18:45:09 UTC (rev 292407)
@@ -120,8 +120,13 @@
return result;
}
+#if PAS_PLATFORM(PLAYSTATION)
+mmap_result = mmap_np(NULL, mapped_size, PROT_READ | PROT_WRITE,
+ MAP_PRIVATE | MAP_ANON | PAS_NORESERVE, PAS_VM_TAG, 0, "SceNKLibpas");
+#else
mmap_result = mmap(NULL, mapped_size,
[webkit-changes] [292406] trunk/Source/WTF
Title: [292406] trunk/Source/WTF Revision 292406 Author stephan.sz...@sony.com Date 2022-04-05 11:25:27 -0700 (Tue, 05 Apr 2022) Log Message [PlayStation] Build fix after r292389 https://bugs.webkit.org/show_bug.cgi?id=238816 Unreviewed build fix Add UnixFileDescriptor.h to PlatformPlayStation.cmake as per the changes to PlatformGTK and PlatformWPE. * wtf/PlatformPlayStation.cmake: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformPlayStation.cmake Diff Modified: trunk/Source/WTF/ChangeLog (292405 => 292406) --- trunk/Source/WTF/ChangeLog 2022-04-05 18:05:12 UTC (rev 292405) +++ trunk/Source/WTF/ChangeLog 2022-04-05 18:25:27 UTC (rev 292406) @@ -1,3 +1,15 @@ +2022-04-05 Stephan Szabo + +[PlayStation] Build fix after r292389 +https://bugs.webkit.org/show_bug.cgi?id=238816 + +Unreviewed build fix + +Add UnixFileDescriptor.h to PlatformPlayStation.cmake +as per the changes to PlatformGTK and PlatformWPE. + +* wtf/PlatformPlayStation.cmake: + 2022-04-05 Zan Dobersek [Unix] Add UnixFileDescriptor, use it in IPC::Semaphore Modified: trunk/Source/WTF/wtf/PlatformPlayStation.cmake (292405 => 292406) --- trunk/Source/WTF/wtf/PlatformPlayStation.cmake 2022-04-05 18:05:12 UTC (rev 292405) +++ trunk/Source/WTF/wtf/PlatformPlayStation.cmake 2022-04-05 18:25:27 UTC (rev 292406) @@ -1,3 +1,7 @@ +list(APPEND WTF_PUBLIC_HEADERS +unix/UnixFileDescriptor.h +) + list(APPEND WTF_SOURCES generic/MainThreadGeneric.cpp generic/MemoryFootprintGeneric.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292405] trunk/Tools
Title: [292405] trunk/Tools
Revision 292405
Author jbed...@apple.com
Date 2022-04-05 11:05:12 -0700 (Tue, 05 Apr 2022)
Log Message
[Merge-Queue] Extract bug_id when updating pull-request
https://bugs.webkit.org/show_bug.cgi?id=238772
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(LeaveComment.start): Leave comment on both bugzilla and pull request.
(LeaveComment.getResultSummary): Ditto.
(UpdatePullRequest):
(UpdatePullRequest.bug_id_from_log): Extract bug_id from commit message.
(UpdatePullRequest.evaluateCommand): Set bug_id property
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249267@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (292404 => 292405)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-05 18:04:05 UTC (rev 292404)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-05 18:05:12 UTC (rev 292405)
@@ -1764,11 +1764,12 @@
self.finished(WARNINGS)
return None
-if self.pr_number:
-rc = SUCCESS if self.comment_on_pr(self.pr_number, self.comment_text) else FAILURE
-elif self.bug_id:
-rc = self.comment_on_bug(self.bug_id, self.comment_text)
-else:
+rc = SUCCESS
+if self.pr_number and not self.comment_on_pr(self.pr_number, self.comment_text):
+rc = FAILURE
+if self.bug_id and self.comment_on_bug(self.bug_id, self.comment_text) != SUCCESS:
+rc = FAILURE
+if not self.pr_number and not self.bug_id:
self._addToLog('stdio', 'No bug or pull request to comment to.\n')
self.descriptionDone = 'No bug or PR found'
self.finished(FAILURE)
@@ -1779,19 +1780,24 @@
def getResultSummary(self):
if self.results == SUCCESS:
+if self.pr_number and self.bug_id:
+return {'step': f'Added comment on PR {self.pr_number} and added comment on bug {self.bug_id}'}
if self.pr_number:
return {'step': f'Added comment on PR {self.pr_number}'}
-elif self.bug_id:
+if self.bug_id:
return {'step': f'Added comment on bug {self.bug_id}'}
-elif self.results == SKIPPED:
-return buildstep.BuildStep.getResultSummary(self)
-if self.pr_number:
-return {'step': f'Failed to add comment on PR {self.pr_number}'}
-elif self.bug_id:
-return {'step': f'Failed to add comment on bug {self.bug_id}'}
-return {'step': 'Failed to add comment'}
+if self.results == FAILURE:
+if self.pr_number and self.bug_id:
+return {'step': f'Failed to add comment on PR {self.pr_number} and failed to add comment on bug {self.bug_id}'}
+if self.pr_number:
+return {'step': f'Failed to add comment on PR {self.pr_number}'}
+if self.bug_id:
+return {'step': f'Failed to add comment on bug {self.bug_id}'}
+return {'step': 'Failed to add comment'}
+return buildstep.BuildStep.getResultSummary(self)
+
def doStepIf(self, step):
return CURRENT_HOSTNAME == EWS_BUILD_HOSTNAME
@@ -4973,6 +4979,13 @@
'<': '',
'&': '',
}
+BUGS_RE = [
+re.compile(r'\Awebkit.org/b/(?P\d+)\Z'),
+re.compile(r'\Ahttps?://webkit.org/b/(?P\d+)\Z'),
+re.compile(r'\Awebkit.org/b/(?P\d+)\Z'),
+re.compile(r'\Abugs.webkit.org/show_bug.cgi\?id=(?P\d+)\Z'),
+re.compile(r'\Ahttps?://bugs.webkit.org/show_bug.cgi\?id=(?P\d+)\Z'),
+]
@classmethod
def escape_html(cls, message):
@@ -5003,6 +5016,16 @@
return {'step': 'Failed to update pull request'}
return super(UpdatePullRequest, self).getResultSummary()
+@classmethod
+def bug_id_from_log(cls, lines):
+for line in lines:
+for word in line.split():
+for candidate in cls.BUGS_RE:
+match = candidate.match(word)
+if match:
+return match.group('id')
+return None
+
def evaluateCommand(self, cmd):
rc = super(UpdatePullRequest, self).evaluateCommand(cmd)
@@ -5014,6 +5037,10 @@
description += self.escape_html(line[4:] + '\n')
description += '\n'
+bug_id = self.bug_id_from_log(loglines)
+if bug_id:
+self.setProperty('bug_id', bug_id)
+
if not self.update_pr(
self.getProperty('github.number'),
title=title,
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (292404 => 292405)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-05 18:04:05 UTC (rev 292404)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-05 18:05:12 UTC (rev 292405)
[webkit-changes] [292404] trunk/Source/WebKit
Title: [292404] trunk/Source/WebKit Revision 292404 Author timothy_hor...@apple.com Date 2022-04-05 11:04:05 -0700 (Tue, 05 Apr 2022) Log Message Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build * Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h Diff Modified: trunk/Source/WebKit/ChangeLog (292403 => 292404) --- trunk/Source/WebKit/ChangeLog 2022-04-05 17:58:46 UTC (rev 292403) +++ trunk/Source/WebKit/ChangeLog 2022-04-05 18:04:05 UTC (rev 292404) @@ -1,3 +1,9 @@ +2022-04-05 Tim Horton + +Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build + +* Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h: + 2022-04-05 Yury Semikhatsky Do not create network process in ~WebsiteDataStore destructor Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h (292403 => 292404) --- trunk/Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h 2022-04-05 17:58:46 UTC (rev 292403) +++ trunk/Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h 2022-04-05 18:04:05 UTC (rev 292404) @@ -28,6 +28,7 @@ #if ENABLE(CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER) #include "ImageBufferBackendHandleSharing.h" +#include #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292403] trunk
Title: [292403] trunk
Revision 292403
Author yu...@chromium.org
Date 2022-04-05 10:58:46 -0700 (Tue, 05 Apr 2022)
Log Message
Do not create network process in ~WebsiteDataStore destructor
https://bugs.webkit.org/show_bug.cgi?id=238570
Reviewed by Chris Dumez.
Source/WebKit:
Check if m_networkProcess is initialized before removing session
from it instead, otherwise WebsiteDataStore::networkProcess() lazily
creates the process and it will keep running after WebsiteDataStore
is destroyed.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::~WebsiteDataStore):
Tools:
The test is written by Chris Dumez.
* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
(TEST): Test that creating and destroying ephemer WebsiteDataStore doesn't initialize
default network process.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292402 => 292403)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 17:57:55 UTC (rev 292402)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 17:58:46 UTC (rev 292403)
@@ -1,3 +1,18 @@
+2022-04-05 Yury Semikhatsky
+
+Do not create network process in ~WebsiteDataStore destructor
+https://bugs.webkit.org/show_bug.cgi?id=238570
+
+Reviewed by Chris Dumez.
+
+Check if m_networkProcess is initialized before removing session
+from it instead, otherwise WebsiteDataStore::networkProcess() lazily
+creates the process and it will keep running after WebsiteDataStore
+is destroyed.
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::~WebsiteDataStore):
+
2022-04-05 Eric Carlson
5 Media API tests are flakily timing out on iOS14
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (292402 => 292403)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2022-04-05 17:57:55 UTC (rev 292402)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2022-04-05 17:58:46 UTC (rev 292403)
@@ -150,7 +150,8 @@
ASSERT(allDataStores().get(m_sessionID) == this);
allDataStores().remove(m_sessionID);
-networkProcess().removeSession(*this);
+if (m_networkProcess)
+m_networkProcess->removeSession(*this);
#if ENABLE(GPU_PROCESS)
if (auto* gpuProcessProxy = GPUProcessProxy::singletonIfCreated())
gpuProcessProxy->removeSession(m_sessionID);
Modified: trunk/Tools/ChangeLog (292402 => 292403)
--- trunk/Tools/ChangeLog 2022-04-05 17:57:55 UTC (rev 292402)
+++ trunk/Tools/ChangeLog 2022-04-05 17:58:46 UTC (rev 292403)
@@ -1,3 +1,16 @@
+2022-04-05 Yury Semikhatsky
+
+Do not create network process in ~WebsiteDataStore destructor
+https://bugs.webkit.org/show_bug.cgi?id=238570
+
+Reviewed by Chris Dumez.
+
+The test is written by Chris Dumez.
+
+* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
+(TEST): Test that creating and destroying ephemer WebsiteDataStore doesn't initialize
+default network process.
+
2022-04-04 Jonathan Bedard
[Merge-Queue] Add author to commit message
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm (292402 => 292403)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm 2022-04-05 17:57:55 UTC (rev 292402)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm 2022-04-05 17:58:46 UTC (rev 292403)
@@ -159,6 +159,21 @@
TestWebKitAPI::Util::spinRunLoop();
}
+TEST(NetworkProcess, DoNotLaunchOnDataStoreDestruction)
+{
+auto storeConfiguration1 = adoptNS([[_WKWebsiteDataStoreConfiguration alloc] initNonPersistentConfiguration]);
+auto websiteDataStore1 = adoptNS([[WKWebsiteDataStore alloc] _initWithConfiguration: storeConfiguration1.get()]);
+
+EXPECT_FALSE([WKWebsiteDataStore _defaultNetworkProcessExists]);
+@autoreleasepool {
+auto storeConfiguration2 = adoptNS([[_WKWebsiteDataStoreConfiguration alloc] initNonPersistentConfiguration]);
+auto websiteDataStore2 = adoptNS([[WKWebsiteDataStore alloc] _initWithConfiguration: storeConfiguration2.get()]);
+}
+
+TestWebKitAPI::Util::spinRunLoop(10);
+EXPECT_FALSE([WKWebsiteDataStore _defaultNetworkProcessExists]);
+}
+
TEST(NetworkProcess, CORSPreflightCachePartitioned)
{
using namespace TestWebKitAPI;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292402] trunk/Tools
Title: [292402] trunk/Tools
Revision 292402
Author jbed...@apple.com
Date 2022-04-05 10:57:55 -0700 (Tue, 05 Apr 2022)
Log Message
[Merge-Queue] Add author to commit message
https://bugs.webkit.org/show_bug.cgi?id=238752
Reviewed by Aakash Jain.
svn.webkit.org will attribute a change to a specific author
if "Patch by" is in the commit message.
* Tools/CISupport/ews-build/factories.py:
(MergeQueueFactory.__init__): Add AddAuthorToCommitMessage step.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps): Ditto.
* Tools/CISupport/ews-build/master.cfg: Determine commit author from github.head.user.login.
* Tools/CISupport/ews-build/steps.py:
(AddAuthorToCommitMessage):
(AddAuthorToCommitMessage.__init__):
(AddAuthorToCommitMessage.author): Return commit author's name and email, falling back
to the committers name and email if those cannot be determined.
(AddAuthorToCommitMessage.start): Insert "Patch by" into commit message.
(AddAuthorToCommitMessage.getResultSummary):
(AddAuthorToCommitMessage.doStepIf): Only do step if the author can be determined.
(AddAuthorToCommitMessage.hideStepIf): Hide step if skipped.
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249265@main
Modified Paths
trunk/Tools/CISupport/ews-build/factories.py
trunk/Tools/CISupport/ews-build/factories_unittest.py
trunk/Tools/CISupport/ews-build/master.cfg
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/factories.py (292401 => 292402)
--- trunk/Tools/CISupport/ews-build/factories.py 2022-04-05 17:38:45 UTC (rev 292401)
+++ trunk/Tools/CISupport/ews-build/factories.py 2022-04-05 17:57:55 UTC (rev 292402)
@@ -24,8 +24,8 @@
from buildbot.process import factory
from buildbot.steps import trigger
-from steps import (AddReviewerToCommitMessage, AddReviewerToChangeLog, ApplyPatch, ApplyWatchList, Canonicalize, CheckOutPullRequest,
- CheckOutSource, CheckOutSpecificRevision, CheckChangeRelevance,
+from steps import (AddAuthorToCommitMessage, AddReviewerToCommitMessage, AddReviewerToChangeLog, ApplyPatch, ApplyWatchList, Canonicalize,
+ CheckOutPullRequest, CheckOutSource, CheckOutSpecificRevision, CheckChangeRelevance,
CheckPatchStatusOnEWSQueues, CheckStyle, CleanGitRepo, CompileJSC, CompileWebKit, ConfigureBuild, CreateLocalGITCommit,
DownloadBuiltProduct, ExtractBuiltProduct, FetchBranches, FindModifiedChangeLogs, FindModifiedLayoutTests,
InstallGtkDependencies, InstallWpeDependencies, KillOldProcesses, PrintConfiguration, PushCommitToWebKitRepo, PushPullRequestBranch,
@@ -333,6 +333,7 @@
self.addStep(CheckOutPullRequest())
self.addStep(ValidateSquashed())
self.addStep(AddReviewerToCommitMessage())
+self.addStep(AddAuthorToCommitMessage())
self.addStep(AddReviewerToChangeLog())
self.addStep(ValidateCommitMessage())
self.addStep(ValidateChangeLogAndReviewer())
Modified: trunk/Tools/CISupport/ews-build/factories_unittest.py (292401 => 292402)
--- trunk/Tools/CISupport/ews-build/factories_unittest.py 2022-04-05 17:38:45 UTC (rev 292401)
+++ trunk/Tools/CISupport/ews-build/factories_unittest.py 2022-04-05 17:57:55 UTC (rev 292402)
@@ -640,6 +640,7 @@
'checkout-pull-request',
'validate-squashed',
'add-reviewer-to-commit-message',
+'add-author-to-commit-message',
'add-reviewer-to-changelog',
'validate-commit-message',
'validate-changelog-and-reviewer',
Modified: trunk/Tools/CISupport/ews-build/master.cfg (292401 => 292402)
--- trunk/Tools/CISupport/ews-build/master.cfg 2022-04-05 17:38:45 UTC (rev 292401)
+++ trunk/Tools/CISupport/ews-build/master.cfg 2022-04-05 17:57:55 UTC (rev 292402)
@@ -56,6 +56,7 @@
'github.base.ref',
'github.base.sha',
'github.head.repo.full_name',
+'github.head.user.login',
], 'token': load_password('GITHUB_COM_ACCESS_TOKEN'),
},
)
Modified: trunk/Tools/CISupport/ews-build/steps.py (292401 => 292402)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-05 17:38:45 UTC (rev 292401)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-05 17:57:55 UTC (rev 292402)
@@ -4727,6 +4727,69 @@
return not self.doStepIf(step)
+class AddAuthorToCommitMessage(shell.ShellCommand, AddReviewerMixin):
+name = 'add-author-to-commit-message'
+haltOnFailure = True
+
+def __init__(self, **kwargs):
+super(AddAuthorToCommitMessage, self).__init__(logEnviron=False, timeout=60, **kwargs)
+
+def author(self):
+contributors, _ = Contributors.load(use_network=False)
+username = self.getProperty('github.head.user.login')
+owners =
[webkit-changes] [292401] trunk
Title: [292401] trunk
Revision 292401
Author eric.carl...@apple.com
Date 2022-04-05 10:38:45 -0700 (Tue, 05 Apr 2022)
Log Message
5 Media API tests are flakily timing out on iOS14
https://bugs.webkit.org/show_bug.cgi?id=230321
Reviewed by Jer Noble.
Source/WebKit:
Un-skipped API test WKWebViewPausePlayingAudioTests.OutOfWindow
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationWillEnterForegroundForMedia): Log the correct name.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationDidEnterBackgroundForMedia): Call PlatformMediaSessionManager.
(WebKit::WebPage::applicationWillEnterForegroundForMedia): Ditto.
Tools:
* TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292400 => 292401)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 17:04:57 UTC (rev 292400)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 17:38:45 UTC (rev 292401)
@@ -1,3 +1,20 @@
+2022-04-05 Eric Carlson
+
+5 Media API tests are flakily timing out on iOS14
+https://bugs.webkit.org/show_bug.cgi?id=230321
+
+
+Reviewed by Jer Noble.
+
+Un-skipped API test WKWebViewPausePlayingAudioTests.OutOfWindow
+
+* UIProcess/ios/WebPageProxyIOS.mm:
+(WebKit::WebPageProxy::applicationWillEnterForegroundForMedia): Log the correct name.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::applicationDidEnterBackgroundForMedia): Call PlatformMediaSessionManager.
+(WebKit::WebPage::applicationWillEnterForegroundForMedia): Ditto.
+
2022-04-05 Simon Fraser
Pass an IOSurfacePool to ImageBuffer::releaseBufferToPool()
Modified: trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm (292400 => 292401)
--- trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm 2022-04-05 17:04:57 UTC (rev 292400)
+++ trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm 2022-04-05 17:38:45 UTC (rev 292401)
@@ -672,7 +672,7 @@
void WebPageProxy::applicationWillEnterForegroundForMedia()
{
bool isSuspendedUnderLock = [UIApp isSuspendedUnderLock];
-WEBPAGEPROXY_RELEASE_LOG(ViewState, "applicationDidEnterBackgroundForMedia: isSuspendedUnderLock? %d", isSuspendedUnderLock);
+WEBPAGEPROXY_RELEASE_LOG(ViewState, "applicationWillEnterForegroundForMedia: isSuspendedUnderLock? %d", isSuspendedUnderLock);
m_process->send(Messages::WebPage::ApplicationWillEnterForegroundForMedia(isSuspendedUnderLock), m_webPageID);
}
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (292400 => 292401)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2022-04-05 17:04:57 UTC (rev 292400)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2022-04-05 17:38:45 UTC (rev 292401)
@@ -4042,12 +4042,14 @@
void WebPage::applicationDidEnterBackgroundForMedia(bool isSuspendedUnderLock)
{
-[[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationDidEnterBackgroundNotification object:nil userInfo:@{@"isSuspendedUnderLock": @(isSuspendedUnderLock)}];
+if (auto* manager = PlatformMediaSessionManager::sharedManagerIfExists())
+manager->applicationDidEnterBackground(isSuspendedUnderLock);
}
void WebPage::applicationWillEnterForegroundForMedia(bool isSuspendedUnderLock)
{
-[[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationWillEnterForegroundNotification object:nil userInfo:@{@"isSuspendedUnderLock": @(isSuspendedUnderLock)}];
+if (auto* manager = PlatformMediaSessionManager::sharedManagerIfExists())
+manager->applicationWillEnterForeground(isSuspendedUnderLock);
}
static inline void adjustVelocityDataForBoundedScale(VelocityData& velocityData, double exposedRectScale, double minimumScale, double maximumScale)
Modified: trunk/Tools/ChangeLog (292400 => 292401)
--- trunk/Tools/ChangeLog 2022-04-05 17:04:57 UTC (rev 292400)
+++ trunk/Tools/ChangeLog 2022-04-05 17:38:45 UTC (rev 292401)
@@ -1,3 +1,14 @@
+2022-04-05 Eric Carlson
+
+5 Media API tests are flakily timing out on iOS14
+https://bugs.webkit.org/show_bug.cgi?id=230321
+
+
+Reviewed by Jer Noble.
+
+* TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:
+(TestWebKitAPI::TEST):
+
2022-04-05 Kimmo Kinnunen
ANGLE changes.diff contains differences that are from stale files or unneeded
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm (292400 => 292401)
--- trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm 2022-04-05 17:04:57 UTC (rev 292400)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm 2022-04-05
[webkit-changes] [292400] trunk
Title: [292400] trunk
Revision 292400
Author r...@igalia.com
Date 2022-04-05 10:04:57 -0700 (Tue, 05 Apr 2022)
Log Message
[macOS][selectors] :focus-visible matching on button focused via script (after clicking on a different button)
https://bugs.webkit.org/show_bug.cgi?id=236782
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Add specific test for element.
* web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt: Added.
* web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html: Added.
Source/WebCore:
Document::m_latestFocusTrigger was not being updated after clicking on a button (or other form controls)
on platforms different than GTK and WPE.
This is because HTMLFormControlElement::isMouseFocusable() returns false on such platforms.
This issue is causing problems with :focus-visible, as the button is not actually focused via mouse click,
if you move the focus via script afterwards, the new focused element always match :focus-visible.
This patch is a workaround to solve that issue, by updating m_latestFocusTrigger on Document
even if the element is not actually focused.
That way :focus-visible doesn't match if there's a script focus afterwards.
Fix :focus-visible after clicking on a button on Mac
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html
* dom/Document.h:
(WebCore::Document::setLatestFocusTrigger):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/EventHandler.cpp
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292399 => 292400)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-05 16:57:35 UTC (rev 292399)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-05 17:04:57 UTC (rev 292400)
@@ -1,3 +1,16 @@
+2022-04-05 Manuel Rego Casasnovas
+
+[macOS][selectors] :focus-visible matching on button focused via script (after clicking on a different button)
+https://bugs.webkit.org/show_bug.cgi?id=236782
+
+
+Reviewed by Antti Koivisto.
+
+Add specific test for element.
+
+* web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt: Added.
+* web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html: Added.
+
2022-04-05 Alan Bujtas
[CSS-Contain] Add support for contain: inline-size
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt (0 => 292400)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b-expected.txt 2022-04-05 17:04:57 UTC (rev 292400)
@@ -0,0 +1,10 @@
+This test checks that a script focus after a mouse click on a button that does not match :focus visible, does NOT match :focus-visible.
+
+Click on the button that says "Click me".
+If the element that says "Focused" has a red outline then the test result is FAILURE, if it has a green background then the test result is SUCCESS.
+Click me
+Focused
+
+PASS ":focus-visible" should be a valid selector
+PASS Script focus after mouse click on a button that does not match :focus-visible, does NOT match :focus-visible
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html (0 => 292400)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-008-b.html 2022-04-05 17:04:57 UTC (rev 292400)
@@ -0,0 +1,64 @@
+
+
+CSS Test (Selectors): Script focus after mouse click on a button that does not match :focus-visible, does NOT match :focus-visible
+
+
+ #warning {
+display: none;
+background: red;
+ }
+
+ @supports not selector(:focus-visible) {
+#instructions {
+ display: none;
+}
+
+#warning {
+ display: block;
+}
+ }
+
+ :focus-visible {
+outline: solid thick red;
+ }
+
+ :focus:not(:focus-visible) {
+background-color: lime;
+ }
+
+
+This test checks that a script focus after a mouse click on a button that does not match :focus visible, does NOT match :focus-visible.
+
+ - Click on the button that says "Click me".
+ - If the element that says "Focused" has a red outline then the test result is FAILURE, if it has a green
[webkit-changes] [292399] trunk/Source/WebCore/features.json
Title: [292399] trunk/Source/WebCore/features.json
Revision 292399
Author bfulg...@apple.com
Date 2022-04-05 09:57:35 -0700 (Tue, 05 Apr 2022)
Log Message
Correct additional malformed entries in 'specifications' section.
Modified Paths
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/features.json (292398 => 292399)
--- trunk/Source/WebCore/features.json 2022-04-05 16:44:44 UTC (rev 292398)
+++ trunk/Source/WebCore/features.json 2022-04-05 16:57:35 UTC (rev 292399)
@@ -173,13 +173,19 @@
}
},
{
-"name": "CSS Highlight",
+"name": "CSS Custom Highlight API Module Level 1",
"status": {
"status": "In Development"
},
"url": "https://www.w3.org/TR/css-highlight-api-1/",
-"specification": "CSS Custom Highlight API Module Level 1",
-"description": "The Custom Highlight API extends the concept of highlight pseudo-elements (see CSS Pseudo-Elements 4 § 3 Highlight Pseudo-elements) by providing a way for web developers to style the text of arbitrary Range objects, rather than being limited to the user agent defined ::selection, ::inactive-selection, ::spelling-error, and ::grammar-error."
+"webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=204903",
+"keywords": ["highlight"],
+"category": "css",
+"description": "The Custom Highlight API extends the concept of highlight pseudo-elements (see CSS Pseudo-Elements 4 § 3 Highlight Pseudo-elements) by providing a way for web developers to style the text of arbitrary Range objects, rather than being limited to the user agent defined ::selection, ::inactive-selection, ::spelling-error, and ::grammar-error.",
+"contact": {
+"name": "Megan Gardner",
+"email": "megan_gard...@apple.com"
+}
},
{
"name": "CSS Image Values and Replaced Content Module Level 4",
@@ -239,22 +245,24 @@
"category": "css"
},
{
-"name": "CSS Motion Path",
+"name": "CSS Motion Path Module Level 1",
"status": {
"status": "In Development"
},
"url": "https://www.w3.org/TR/motion-1/",
-"specification": "Motion Path Module Level 1",
-"description": "This specification defines a set of CSS properties that allow authors to specify position along a path. The object can be positioned, transitioned and animated along this path over a given period of time."
+"webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=203847",
+"description": "This specification defines a set of CSS properties that allow authors to specify position along a path. The object can be positioned, transitioned and animated along this path over a given period of time.",
+"category": "css"
},
{
-"name": "CSS Overscroll Behavior",
+"name": "CSS Overscroll Behavior Module Level 1",
"status": {
"status": "Supported"
},
"url": "https://www.w3.org/TR/css-overscroll-1/",
-"specification": "CSS Overscroll Behavior Module Level 1",
-"description": "Allow authors to control whether scrolling results in overscroll (\"rubber-banding\") and propagates to enclosing scroll containers."
+"webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=176454",
+"description": "Allow authors to control whether scrolling results in overscroll (\"rubber-banding\") and propagates to enclosing scroll containers.",
+"category": "css"
},
{
"name": "CSS Painting API Level 1",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292398] trunk/Source
Title: [292398] trunk/Source
Revision 292398
Author simon.fra...@apple.com
Date 2022-04-05 09:44:44 -0700 (Tue, 05 Apr 2022)
Log Message
Pass an IOSurfacePool to ImageBuffer::releaseBufferToPool()
https://bugs.webkit.org/show_bug.cgi?id=238768
Reviewed by Said Abou-Hallawa.
In order to move away from a singleton IOSurfacePool, we need to pass the pool
which the IOSurface will be added to.
Source/WebCore:
* platform/graphics/ConcreteImageBuffer.h:
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::CreationContext::CreationContext):
* platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::releaseBufferToPool):
* platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::releaseBufferToPool):
* platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
Source/WebKit:
For RemoteLayerBackingStore, pass the singleton WebProcess pool
(this is the non-GPU Process code path).
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::Buffer::discard):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebCore/platform/graphics/ImageBufferBackend.h
trunk/Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (292397 => 292398)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 16:32:33 UTC (rev 292397)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 16:44:44 UTC (rev 292398)
@@ -1,3 +1,22 @@
+2022-04-05 Simon Fraser
+
+Pass an IOSurfacePool to ImageBuffer::releaseBufferToPool()
+https://bugs.webkit.org/show_bug.cgi?id=238768
+
+Reviewed by Said Abou-Hallawa.
+
+In order to move away from a singleton IOSurfacePool, we need to pass the pool
+which the IOSurface will be added to.
+
+* platform/graphics/ConcreteImageBuffer.h:
+* platform/graphics/ImageBuffer.h:
+(WebCore::ImageBuffer::CreationContext::CreationContext):
+* platform/graphics/ImageBufferBackend.h:
+(WebCore::ImageBufferBackend::releaseBufferToPool):
+* platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
+(WebCore::ImageBufferIOSurfaceBackend::releaseBufferToPool):
+* platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
+
2022-04-05 Wenson Hsieh
Unreviewed, fix the internal iOS build after r292370
Modified: trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h (292397 => 292398)
--- trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h 2022-04-05 16:32:33 UTC (rev 292397)
+++ trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h 2022-04-05 16:44:44 UTC (rev 292398)
@@ -325,11 +325,13 @@
return nullptr;
}
-void releaseBufferToPool() override
+#if HAVE(IOSURFACE)
+void releaseBufferToPool(IOSurfacePool* pool) override
{
if (auto* backend = ensureBackendCreated())
-backend->releaseBufferToPool();
+backend->releaseBufferToPool(pool);
}
+#endif
ImageBufferBackend::Parameters m_parameters;
std::unique_ptr m_backend;
Modified: trunk/Source/WebCore/platform/graphics/ImageBuffer.h (292397 => 292398)
--- trunk/Source/WebCore/platform/graphics/ImageBuffer.h 2022-04-05 16:32:33 UTC (rev 292397)
+++ trunk/Source/WebCore/platform/graphics/ImageBuffer.h 2022-04-05 16:44:44 UTC (rev 292398)
@@ -38,7 +38,9 @@
class Filter;
class HostWindow;
+#if HAVE(IOSURFACE)
class IOSurfacePool;
+#endif
class ImageBuffer : public ThreadSafeRefCounted, public CanMakeWeakPtr {
public:
@@ -45,10 +47,18 @@
struct CreationContext {
// clang 13.1.6 throws errors if we use default initializers here.
HostWindow* hostWindow;
+#if HAVE(IOSURFACE)
IOSurfacePool* surfacePool;
-CreationContext(HostWindow* window = nullptr, IOSurfacePool* pool = nullptr)
+#endif
+CreationContext(HostWindow* window = nullptr
+#if HAVE(IOSURFACE)
+, IOSurfacePool* pool = nullptr
+#endif
+)
: hostWindow(window)
+#if HAVE(IOSURFACE)
, surfacePool(pool)
+#endif
{ }
};
@@ -100,8 +110,9 @@
virtual bool isInUse() const = 0;
virtual void releaseGraphicsContext() = 0;
-virtual void releaseBufferToPool() = 0;
-
+#if HAVE(IOSURFACE)
+virtual void releaseBufferToPool(IOSurfacePool*) = 0;
+#endif
// Returns true on success.
virtual bool setVolatile() = 0;
virtual SetNonVolatileResult setNonVolatile() = 0;
Modified: trunk/Source/WebCore/platform/graphics/ImageBufferBackend.h (292397 => 292398)
--- trunk/Source/WebCore/platform/graphics/ImageBufferBackend.h 2022-04-05 16:32:33 UTC (rev 292397)
+++
[webkit-changes] [292397] tags/Safari-614.1.8.3/
Title: [292397] tags/Safari-614.1.8.3/ Revision 292397 Author alanc...@apple.com Date 2022-04-05 09:32:33 -0700 (Tue, 05 Apr 2022) Log Message Tag Safari-614.1.8.3. Added Paths tags/Safari-614.1.8.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292396] branches/safari-614.1.8-branch/Source
Title: [292396] branches/safari-614.1.8-branch/Source Revision 292396 Author alanc...@apple.com Date 2022-04-05 09:30:29 -0700 (Tue, 05 Apr 2022) Log Message Versioning. WebKit-7614.1.8.3 Modified Paths branches/safari-614.1.8-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-614.1.8-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-614.1.8-branch/Source/_javascript_Core/Configurations/Version.xcconfig (292395 => 292396) --- branches/safari-614.1.8-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-05 16:15:24 UTC (rev 292395) +++ branches/safari-614.1.8-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-04-05 16:30:29 UTC (rev 292396) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (292395 => 292396) --- branches/safari-614.1.8-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-05 16:15:24 UTC (rev 292395) +++ branches/safari-614.1.8-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-04-05 16:30:29 UTC (rev 292396) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (292395 => 292396) --- branches/safari-614.1.8-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-05 16:15:24 UTC (rev 292395) +++ branches/safari-614.1.8-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-04-05 16:30:29 UTC (rev 292396) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/WebCore/Configurations/Version.xcconfig (292395 => 292396) --- branches/safari-614.1.8-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-05 16:15:24 UTC (rev 292395) +++ branches/safari-614.1.8-branch/Source/WebCore/Configurations/Version.xcconfig 2022-04-05 16:30:29 UTC (rev 292396) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (292395 => 292396) --- branches/safari-614.1.8-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-05 16:15:24 UTC (rev 292395) +++ branches/safari-614.1.8-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-04-05 16:30:29 UTC (rev 292396) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/WebGPU/Configurations/Version.xcconfig (292395 => 292396) --- branches/safari-614.1.8-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-05 16:15:24 UTC (rev 292395) +++ branches/safari-614.1.8-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-04-05 16:30:29 UTC (rev 292396) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 2; +MICRO_VERSION = 3; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.8-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (292395 => 292396) --- branches/safari-614.1.8-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-05 16:15:24 UTC (rev 292395) +++ branches/safari-614.1.8-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-04-05 16:30:29 UTC (rev 292396) @@ -1,7 +1,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 8; -MICRO_VERSION = 2; +MICRO_VERSION = 3;
[webkit-changes] [292395] trunk/Source/WebCore
Title: [292395] trunk/Source/WebCore Revision 292395 Author wenson_hs...@apple.com Date 2022-04-05 09:15:24 -0700 (Tue, 05 Apr 2022) Log Message Unreviewed, fix the internal iOS build after r292370 Remove an extraneous opening parenthesis. * page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/DOMWindow.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (292394 => 292395) --- trunk/Source/WebCore/ChangeLog 2022-04-05 15:44:42 UTC (rev 292394) +++ trunk/Source/WebCore/ChangeLog 2022-04-05 16:15:24 UTC (rev 292395) @@ -1,3 +1,12 @@ +2022-04-05 Wenson Hsieh + +Unreviewed, fix the internal iOS build after r292370 + +Remove an extraneous opening parenthesis. + +* page/DOMWindow.cpp: +(WebCore::DOMWindow::addEventListener): + 2022-04-05 Alan Bujtas [CSS-Contain] Add support for contain: inline-size Modified: trunk/Source/WebCore/page/DOMWindow.cpp (292394 => 292395) --- trunk/Source/WebCore/page/DOMWindow.cpp 2022-04-05 15:44:42 UTC (rev 292394) +++ trunk/Source/WebCore/page/DOMWindow.cpp 2022-04-05 16:15:24 UTC (rev 292395) @@ -1993,7 +1993,7 @@ incrementScrollEventListenersCount(); #endif #if ENABLE(IOS_TOUCH_EVENTS) -else if (document && eventNames(.isTouchRelatedEventType(eventType, *document)) +else if (document && eventNames.isTouchRelatedEventType(eventType, *document)) ++m_touchAndGestureEventListenerCount; #endif #if ENABLE(IOS_GESTURE_EVENTS) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292394] trunk
Title: [292394] trunk Revision 292394 Author za...@apple.com Date 2022-04-05 08:44:42 -0700 (Tue, 05 Apr 2022) Log Message [CSS-Contain] Add support for contain: inline-size https://bugs.webkit.org/show_bug.cgi?id=238787 Reviewed by Antti Koivisto. LayoutTests/imported/w3c: * web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: * web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt: Source/WebCore: * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeContain): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::computeIntrinsicLogicalWidths const): (WebCore::RenderBlock::computeBlockPreferredLogicalWidths const): * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths const): (WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const): * rendering/RenderBox.cpp: (WebCore::RenderBox::createsNewFormattingContext const): (WebCore::RenderBox::establishesIndependentFormattingContext const): * rendering/RenderBox.h: * style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyValueContain): LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebCore/style/StyleBuilderCustom.h Diff Modified: trunk/LayoutTests/ChangeLog (292393 => 292394) --- trunk/LayoutTests/ChangeLog 2022-04-05 13:50:58 UTC (rev 292393) +++ trunk/LayoutTests/ChangeLog 2022-04-05 15:44:42 UTC (rev 292394) @@ -1,3 +1,12 @@ +2022-04-05 Alan Bujtas + +[CSS-Contain] Add support for contain: inline-size +https://bugs.webkit.org/show_bug.cgi?id=238787 + +Reviewed by Antti Koivisto. + +* TestExpectations: + 2022-04-05 Cameron McCormack Skip editing-word-with-marker-1.html Modified: trunk/LayoutTests/TestExpectations (292393 => 292394) --- trunk/LayoutTests/TestExpectations 2022-04-05 13:50:58 UTC (rev 292393) +++ trunk/LayoutTests/TestExpectations 2022-04-05 15:44:42 UTC (rev 292394) @@ -4636,15 +4636,8 @@ # CSS containment tests that fail imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-002.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-fieldset.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flexitem.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-legend.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-multicol.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-regular-container.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-vertical-rl-.html [ ImageOnlyFailure ] # webkit-ruby-text imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-contain/contain-paint-021.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292393 => 292394) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-05 13:50:58 UTC (rev 292393) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-05 15:44:42 UTC (rev 292394) @@ -1,3 +1,13 @@ +2022-04-05 Alan Bujtas + +[CSS-Contain] Add support for contain: inline-size +https://bugs.webkit.org/show_bug.cgi?id=238787 + +Reviewed by Antti Koivisto. + +* web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt: +* web-platform-tests/css/css-contain/parsing/contain-valid-expected.txt: + 2022-04-05 Nikolaos Mouchtaris Support rendering url(), CSS basic shapes other than path(), and coord-box for offset-path Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt (292393 => 292394) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/parsing/contain-computed-expected.txt 2022-04-05 13:50:58 UTC (rev 292393) +++
[webkit-changes] [292393] trunk/Source/WebCore
Title: [292393] trunk/Source/WebCore
Revision 292393
Author commit-qu...@webkit.org
Date 2022-04-05 06:50:58 -0700 (Tue, 05 Apr 2022)
Log Message
[GStreamer] GstCapsForeachFunc returns a gboolean
https://bugs.webkit.org/show_bug.cgi?id=238799
Patch by Carlos Garcia Campos on 2022-04-05
Reviewed by Adrian Perez de Castro.
* platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingVideoSourceGStreamer::RealtimeOutgoingVideoSourceGStreamer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292392 => 292393)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 13:37:51 UTC (rev 292392)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 13:50:58 UTC (rev 292393)
@@ -1,3 +1,13 @@
+2022-04-05 Carlos Garcia Campos
+
+[GStreamer] GstCapsForeachFunc returns a gboolean
+https://bugs.webkit.org/show_bug.cgi?id=238799
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:
+(WebCore::RealtimeOutgoingVideoSourceGStreamer::RealtimeOutgoingVideoSourceGStreamer):
+
2022-04-05 Zan Dobersek
[GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp (292392 => 292393)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp 2022-04-05 13:37:51 UTC (rev 292392)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp 2022-04-05 13:50:58 UTC (rev 292393)
@@ -41,7 +41,7 @@
auto* padTemplate = gst_element_get_pad_template(m_encoder.get(), "src");
auto caps = adoptGRef(gst_pad_template_get_caps(padTemplate));
m_allowedCaps = adoptGRef(gst_caps_new_empty());
-gst_caps_foreach(caps.get(), reinterpret_cast(+[](GstCapsFeatures*, GstStructure* structure, gpointer userData) {
+gst_caps_foreach(caps.get(), reinterpret_cast(+[](GstCapsFeatures*, GstStructure* structure, gpointer userData) -> gboolean {
auto* source = reinterpret_cast(userData);
const char* name = gst_structure_get_name(structure);
const char* encodingName = nullptr;
@@ -53,6 +53,7 @@
encodingName = "H264";
if (encodingName)
gst_caps_append_structure(source->m_allowedCaps.get(), gst_structure_new("application/x-rtp", "media", G_TYPE_STRING, "video", "encoding-name", G_TYPE_STRING, encodingName, "clock-rate", G_TYPE_INT, 9, nullptr));
+return TRUE;
}), this);
setSource(WTFMove(source));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292391] trunk/Source/WebCore
Title: [292391] trunk/Source/WebCore Revision 292391 Author zandober...@gmail.com Date 2022-04-05 04:30:09 -0700 (Tue, 05 Apr 2022) Log Message [GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag https://bugs.webkit.org/show_bug.cgi?id=238733 Reviewed by Adrian Perez de Castro. Replace integer values for file descriptors in the DMABufObject and DMABufReleaseFlag structs with UnixFileDescriptors. This enables simply defaulting the destructors and the move constructors and assignment operatos for the two types since the fd wrapper takes care of these operations. Additionally, when constructing the UnixFileDescriptor objects from file descriptors coming from different sources, we can more easily adapt to the need for either adoption or duplication of the passed-in file descriptor right there in the constructor invocation. * platform/graphics/gbm/DMABufObject.h: (WebCore::DMABufObject::~DMABufObject): Deleted. (WebCore::DMABufObject::operator=): Deleted. * platform/graphics/gbm/DMABufReleaseFlag.h: (WebCore::DMABufReleaseFlag::DMABufReleaseFlag): (WebCore::DMABufReleaseFlag::dup const): (WebCore::DMABufReleaseFlag::released const): (WebCore::DMABufReleaseFlag::release): (WebCore::DMABufReleaseFlag::~DMABufReleaseFlag): Deleted. (WebCore::DMABufReleaseFlag::operator=): Deleted. * platform/graphics/gbm/GBMBufferSwapchain.cpp: (WebCore::GBMBufferSwapchain::Buffer::createDMABufObject const): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): * platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLANGLE::makeContextCurrent): * platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp: (WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::createEGLImageData): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h trunk/Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h trunk/Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (292390 => 292391) --- trunk/Source/WebCore/ChangeLog 2022-04-05 10:55:51 UTC (rev 292390) +++ trunk/Source/WebCore/ChangeLog 2022-04-05 11:30:09 UTC (rev 292391) @@ -1,3 +1,40 @@ +2022-04-05 Zan Dobersek + +[GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag +https://bugs.webkit.org/show_bug.cgi?id=238733 + +Reviewed by Adrian Perez de Castro. + +Replace integer values for file descriptors in the DMABufObject and +DMABufReleaseFlag structs with UnixFileDescriptors. This enables +simply defaulting the destructors and the move constructors and +assignment operatos for the two types since the fd wrapper takes care +of these operations. + +Additionally, when constructing the UnixFileDescriptor objects from +file descriptors coming from different sources, we can more easily +adapt to the need for either adoption or duplication of the passed-in +file descriptor right there in the constructor invocation. + +* platform/graphics/gbm/DMABufObject.h: +(WebCore::DMABufObject::~DMABufObject): Deleted. +(WebCore::DMABufObject::operator=): Deleted. +* platform/graphics/gbm/DMABufReleaseFlag.h: +(WebCore::DMABufReleaseFlag::DMABufReleaseFlag): +(WebCore::DMABufReleaseFlag::dup const): +(WebCore::DMABufReleaseFlag::released const): +(WebCore::DMABufReleaseFlag::release): +(WebCore::DMABufReleaseFlag::~DMABufReleaseFlag): Deleted. +(WebCore::DMABufReleaseFlag::operator=): Deleted. +* platform/graphics/gbm/GBMBufferSwapchain.cpp: +(WebCore::GBMBufferSwapchain::Buffer::createDMABufObject const): +* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: +(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): +* platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: +(WebCore::GraphicsContextGLANGLE::makeContextCurrent): +* platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp: +(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::createEGLImageData): + 2022-04-05 Diego Pino Garcia [GStreamer] gst_video_format_info_component not defined in GStreamer <1.18 Modified: trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h (292390 => 292391) --- trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h 2022-04-05 10:55:51 UTC (rev 292390) +++ trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h 2022-04-05 11:30:09 UTC (rev 292391) @@ -32,58 +32,29 @@ #include
[webkit-changes] [292390] trunk/Tools
Title: [292390] trunk/Tools
Revision 292390
Author commit-qu...@webkit.org
Date 2022-04-05 03:55:51 -0700 (Tue, 05 Apr 2022)
Log Message
[Flatpak SDK] Local dependencies override support
https://bugs.webkit.org/show_bug.cgi?id=238452
Patch by Philippe Normand on 2022-04-05
Reviewed by Adrian Perez de Castro.
When the environment variable WEBKIT_SDK_LOCAL_DEPS is set at compile-time and runtime, some
dependencies (currently only libsoup and GStreamer) will be picked up from local git
checkouts located in Tools/flatpak/. If no checkout is present, one will be made based on
the corresponding .wrap file.
Example: WEBKIT_SDK_LOCAL_DEPS=libsoup,gstreamer-full build-webkit --wpe ...
Additional Meson options can be supplied with WEBKIT_SDK_LOCAL_DEPS_OPTIONS. Nested
subprojects configuration is supported as well, for example:
export WEBKIT_SDK_LOCAL_DEPS_OPTIONS="-Dgstreamer-full:introspection=disabled -Dgst-plugins-good:soup=disabled"
This setup replaces the previous one that was specific to GStreamer.
* flatpak/flatpakutils.py:
(WebkitFlatpak.load_from_args):
(WebkitFlatpak.__init__):
(WebkitFlatpak.setup_local_deps):
(WebkitFlatpak._merge_env_variables):
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak.setup_dev_env):
(WebkitFlatpak.setup_gstbuild): Deleted.
* flatpak/local-projects/meson.build: Added.
* flatpak/local-projects/subprojects/gstreamer-full.wrap: Added.
* flatpak/local-projects/subprojects/libsoup.wrap: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py
Added Paths
trunk/Tools/flatpak/local-projects/
trunk/Tools/flatpak/local-projects/meson.build
trunk/Tools/flatpak/local-projects/meson_options.txt
trunk/Tools/flatpak/local-projects/subprojects/
trunk/Tools/flatpak/local-projects/subprojects/gstreamer-full.wrap
trunk/Tools/flatpak/local-projects/subprojects/libsoup.wrap
Diff
Modified: trunk/Tools/ChangeLog (292389 => 292390)
--- trunk/Tools/ChangeLog 2022-04-05 10:48:43 UTC (rev 292389)
+++ trunk/Tools/ChangeLog 2022-04-05 10:55:51 UTC (rev 292390)
@@ -1,3 +1,36 @@
+2022-04-05 Philippe Normand
+
+[Flatpak SDK] Local dependencies override support
+https://bugs.webkit.org/show_bug.cgi?id=238452
+
+Reviewed by Adrian Perez de Castro.
+
+When the environment variable WEBKIT_SDK_LOCAL_DEPS is set at compile-time and runtime, some
+dependencies (currently only libsoup and GStreamer) will be picked up from local git
+checkouts located in Tools/flatpak/. If no checkout is present, one will be made based on
+the corresponding .wrap file.
+
+Example: WEBKIT_SDK_LOCAL_DEPS=libsoup,gstreamer-full build-webkit --wpe ...
+
+Additional Meson options can be supplied with WEBKIT_SDK_LOCAL_DEPS_OPTIONS. Nested
+subprojects configuration is supported as well, for example:
+
+export WEBKIT_SDK_LOCAL_DEPS_OPTIONS="-Dgstreamer-full:introspection=disabled -Dgst-plugins-good:soup=disabled"
+
+This setup replaces the previous one that was specific to GStreamer.
+
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.load_from_args):
+(WebkitFlatpak.__init__):
+(WebkitFlatpak.setup_local_deps):
+(WebkitFlatpak._merge_env_variables):
+(WebkitFlatpak.run_in_sandbox):
+(WebkitFlatpak.setup_dev_env):
+(WebkitFlatpak.setup_gstbuild): Deleted.
+* flatpak/local-projects/meson.build: Added.
+* flatpak/local-projects/subprojects/gstreamer-full.wrap: Added.
+* flatpak/local-projects/subprojects/libsoup.wrap: Added.
+
2022-04-05 Kimmo Kinnunen
update-angle output varies unpredictably due to blob hash abbreviation
Modified: trunk/Tools/flatpak/flatpakutils.py (292389 => 292390)
--- trunk/Tools/flatpak/flatpakutils.py 2022-04-05 10:48:43 UTC (rev 292389)
+++ trunk/Tools/flatpak/flatpakutils.py 2022-04-05 10:55:51 UTC (rev 292390)
@@ -488,9 +488,8 @@
general.add_argument("-u", "--update", dest="update",
action=""
help="Update the SDK")
-general.add_argument("-bgst", "--build-gst", dest="build_gst",
- action=""
- help="Force rebuilding gst-build, repository path is defined by the `GST_BUILD_PATH` environment variable.")
+general.add_argument("-bdeps", "--build-local-deps", dest="build_local_deps",
+ action="" help="Force rebuilding local dependencies")
general.add_argument("-q", "--quiet", dest="quiet",
action=""
help="Do not print anything")
@@ -558,7 +557,7 @@
self.release = False
self.debug = False
-self.build_gst = False
+self.build_local_deps = False
self.platform = "gtk"
self.check_available = False
@@ -669,50 +668,48 @@
return True
-
-def setup_gstbuild(self, building):
-
[webkit-changes] [292389] trunk/Source
Title: [292389] trunk/Source Revision 292389 Author zandober...@gmail.com Date 2022-04-05 03:48:43 -0700 (Tue, 05 Apr 2022) Log Message [Unix] Add UnixFileDescriptor, use it in IPC::Semaphore https://bugs.webkit.org/show_bug.cgi?id=238726 Reviewed by Carlos Garcia Campos. Source/WebKit: Use WTF::UnixFileDescriptor in IPC::Semaphore in place of a raw integer value. This also simplifies other things, e.g. the move constructor and assignment operator can now both be defaulted. The IPC encoding and decoding of the semaphore object is also simpler, leaning into the custom ArgumentCoder specialization for objects of the WTF::UnixFileDescriptor type. The encoding and decoding is done by chaperoning the file descriptor through IPC::Attachment. * Platform/IPC/IPCSemaphore.h: (IPC::Semaphore::operator bool const): * Platform/IPC/unix/IPCSemaphoreUnix.cpp: (IPC::Semaphore::Semaphore): (IPC::Semaphore::signal): (IPC::Semaphore::wait): (IPC::Semaphore::waitFor): (IPC::Semaphore::encode const): (IPC::Semaphore::decode): (IPC::Semaphore::destroy): (IPC::Semaphore::operator=): Deleted. * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): (IPC::ArgumentCoder::decode): * Shared/WebCoreArgumentCoders.h: Source/WTF: Add the UnixFileDescriptor class, intended as a wrapper for a file descriptor integer. Construction is a matter of adopting or duplicating the passed-in file descriptor value. UnixFileDescriptor objects can be moved around and explicitly duplicated, and the contained fd value can be released. The wrapper class makes it easier to handle file descriptor values when embedded into other types as member variables. It also allows to specify custom encoding and decoding in the WebKit IPC infrastructure. * wtf/PlatformGTK.cmake: * wtf/PlatformWPE.cmake: * wtf/unix/UnixFileDescriptor.h: Added. (WTF::UnixFileDescriptor::UnixFileDescriptor): (WTF::UnixFileDescriptor::operator=): (WTF::UnixFileDescriptor::~UnixFileDescriptor): (WTF::UnixFileDescriptor::operator bool const): (WTF::UnixFileDescriptor::value const): (WTF::UnixFileDescriptor::duplicate const): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformGTK.cmake trunk/Source/WTF/wtf/PlatformWPE.cmake trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/IPC/IPCSemaphore.h trunk/Source/WebKit/Platform/IPC/unix/IPCSemaphoreUnix.cpp trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h Added Paths trunk/Source/WTF/wtf/unix/UnixFileDescriptor.h Diff Modified: trunk/Source/WTF/ChangeLog (292388 => 292389) --- trunk/Source/WTF/ChangeLog 2022-04-05 09:40:14 UTC (rev 292388) +++ trunk/Source/WTF/ChangeLog 2022-04-05 10:48:43 UTC (rev 292389) @@ -1,3 +1,30 @@ +2022-04-05 Zan Dobersek + +[Unix] Add UnixFileDescriptor, use it in IPC::Semaphore +https://bugs.webkit.org/show_bug.cgi?id=238726 + +Reviewed by Carlos Garcia Campos. + +Add the UnixFileDescriptor class, intended as a wrapper for a file +descriptor integer. Construction is a matter of adopting or duplicating +the passed-in file descriptor value. UnixFileDescriptor objects can be +moved around and explicitly duplicated, and the contained fd value can +be released. + +The wrapper class makes it easier to handle file descriptor values when +embedded into other types as member variables. It also allows to specify +custom encoding and decoding in the WebKit IPC infrastructure. + +* wtf/PlatformGTK.cmake: +* wtf/PlatformWPE.cmake: +* wtf/unix/UnixFileDescriptor.h: Added. +(WTF::UnixFileDescriptor::UnixFileDescriptor): +(WTF::UnixFileDescriptor::operator=): +(WTF::UnixFileDescriptor::~UnixFileDescriptor): +(WTF::UnixFileDescriptor::operator bool const): +(WTF::UnixFileDescriptor::value const): +(WTF::UnixFileDescriptor::duplicate const): + 2022-04-04 Tim Horton Remove GPU process system feature flags Modified: trunk/Source/WTF/wtf/PlatformGTK.cmake (292388 => 292389) --- trunk/Source/WTF/wtf/PlatformGTK.cmake 2022-04-05 09:40:14 UTC (rev 292388) +++ trunk/Source/WTF/wtf/PlatformGTK.cmake 2022-04-05 10:48:43 UTC (rev 292389) @@ -13,6 +13,8 @@ glib/WTFGType.h linux/RealTimeThreads.h + +unix/UnixFileDescriptor.h ) if (CMAKE_SYSTEM_NAME MATCHES "Linux") Modified: trunk/Source/WTF/wtf/PlatformWPE.cmake (292388 => 292389) --- trunk/Source/WTF/wtf/PlatformWPE.cmake 2022-04-05 09:40:14 UTC (rev 292388) +++ trunk/Source/WTF/wtf/PlatformWPE.cmake 2022-04-05 10:48:43 UTC (rev 292389) @@ -13,6 +13,8 @@ linux/ProcessMemoryFootprint.h linux/CurrentProcessMemoryStatus.h linux/RealTimeThreads.h + +unix/UnixFileDescriptor.h ) list(APPEND WTF_SOURCES Added: trunk/Source/WTF/wtf/unix/UnixFileDescriptor.h (0 => 292389) --- trunk/Source/WTF/wtf/unix/UnixFileDescriptor.h (rev 0) +++
[webkit-changes] [292388] trunk
Title: [292388] trunk Revision 292388 Author commit-qu...@webkit.org Date 2022-04-05 02:40:14 -0700 (Tue, 05 Apr 2022) Log Message update-angle output varies unpredictably due to blob hash abbreviation https://bugs.webkit.org/show_bug.cgi?id=238793 Patch by Kimmo Kinnunen on 2022-04-05 Reviewed by Antti Koivisto. Source/ThirdParty/ANGLE: Update the diff to contain unabbreviated blob hash values. These are more predictable for all developers. * changes.diff: Tools: Add --full-index to diff to get the unabbreviated blob hash. * Scripts/update-angle: Modified Paths trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/changes.diff trunk/Tools/ChangeLog trunk/Tools/Scripts/update-angle Diff Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (292387 => 292388) --- trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-04-05 09:11:43 UTC (rev 292387) +++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-04-05 09:40:14 UTC (rev 292388) @@ -1,5 +1,17 @@ 2022-04-05 Kimmo Kinnunen +update-angle output varies unpredictably due to blob hash abbreviation +https://bugs.webkit.org/show_bug.cgi?id=238793 + +Reviewed by Antti Koivisto. + +Update the diff to contain unabbreviated blob hash values. These are more +predictable for all developers. + +* changes.diff: + +2022-04-05 Kimmo Kinnunen + Update ANGLE changes.diff after "Roll ANGLE to 2022-03-31 (fe28a4295af087ee82b8f629b67176b95019af6d)" https://bugs.webkit.org/show_bug.cgi?id=238794 Modified: trunk/Source/ThirdParty/ANGLE/changes.diff (292387 => 292388) --- trunk/Source/ThirdParty/ANGLE/changes.diff 2022-04-05 09:11:43 UTC (rev 292387) +++ trunk/Source/ThirdParty/ANGLE/changes.diff 2022-04-05 09:40:14 UTC (rev 292388) @@ -1,5 +1,5 @@ diff --git a/.gitignore b/.gitignore -index ba19389..afeca1d 100644 +index ba19389dc517f5d168b616b72554cce67fc42bd2..afeca1d5821d20c50bcefa33c37ae4c283823bf1 100644 --- a/.gitignore +++ b/.gitignore @@ -63,6 +63,7 @@ @@ -12,7 +12,7 @@ /third_party/six diff --git a/ChangeLog-2022-02-22 b/ChangeLog-2022-02-22 new file mode 100644 -index 000..ca67026 +index ..ca67026bc50fdeb3f00af8aa2fba94eb6b0cc277 --- /dev/null +++ b/ChangeLog-2022-02-22 @@ -0,0 +1,19278 @@ @@ -19296,7 +19296,7 @@ + diff --git a/scripts/copy-frameworks-to-secondary-path.sh b/scripts/copy-frameworks-to-secondary-path.sh new file mode 100755 -index 000..2e00c12 +index ..2e00c127043b1a3dd9fd8293346ba237efb4203f --- /dev/null +++ b/scripts/copy-frameworks-to-secondary-path.sh @@ -0,0 +1,62 @@ @@ -19363,7 +19363,7 @@ +done +fi diff --git a/scripts/run_code_generation.py b/scripts/run_code_generation.py -index fa1a029..bc79da2 100755 +index fa1a029b5ee6034cc74f71438e5d21d148fb09e8..bc79da2adff1bab915293c7692942dbaf12a09c2 100755 --- a/scripts/run_code_generation.py +++ b/scripts/run_code_generation.py @@ -254,8 +254,11 @@ def main(): @@ -19379,7 +19379,7 @@ # Update the hash dictionary. all_new_hashes[fname] = new_hashes diff --git a/src/common/utilities.cpp b/src/common/utilities.cpp -index a175734..7fc9aa7 100644 +index a175734c39c5bd25fcba8325da8585a17a0c9d0a..7fc9aa792ace24f146923e374542d7253bd16a48 100644 --- a/src/common/utilities.cpp +++ b/src/common/utilities.cpp @@ -6,6 +6,12 @@ @@ -19396,7 +19396,7 @@ #include "GLES3/gl3.h" #include "common/mathutil.h" diff --git a/src/compiler/preprocessor/preprocessor_tab_autogen.cpp b/src/compiler/preprocessor/preprocessor_tab_autogen.cpp -index 50822f2..3ece210 100644 +index 50822f2007292801b41be16ad956ae0bf06e7e88..3ece2105bcdaea98917001b33d1c6834de022d5e 100644 --- a/src/compiler/preprocessor/preprocessor_tab_autogen.cpp +++ b/src/compiler/preprocessor/preprocessor_tab_autogen.cpp @@ -1,5 +1,8 @@ @@ -19409,7 +19409,7 @@ Copyright (C) 1984, 1989-1990, 2000-2015, 2018-2019 Free Software Foundation, diff --git a/src/compiler/translator/CodeGen.cpp b/src/compiler/translator/CodeGen.cpp -index 497ef88..47213c9 100644 +index 497ef881e2d9cf0efb669ca8c7c4f2669633baba..47213c90497c8c9d8f76baf0653fdbc3c7a2e19d 100644 --- a/src/compiler/translator/CodeGen.cpp +++ b/src/compiler/translator/CodeGen.cpp @@ -23,6 +23,9 @@ @@ -19424,7 +19424,7 @@ #include "compiler/translator/TranslatorMetal.h" diff --git a/src/compiler/translator/TranslatorMetalDirect/EnvironmentVariable.h b/src/compiler/translator/TranslatorMetalDirect/EnvironmentVariable.h new file mode 100644 -index 000..d823fc7 +index ..d823fc72820cffddf3240dc24659a5edcfdb9d27 --- /dev/null +++ b/src/compiler/translator/TranslatorMetalDirect/EnvironmentVariable.h @@ -0,0 +1,45 @@ @@ -19474,7 +19474,7 @@ + +#endif // COMPILER_TRANSLATOR_TRANSLATORMETALDIRECT_ENVIRONMENTVARIABLE_H_ diff --git a/src/compiler/translator/TranslatorMetalDirect/IdGen.cpp
[webkit-changes] [292387] trunk/Source/WebCore
Title: [292387] trunk/Source/WebCore
Revision 292387
Author dp...@igalia.com
Date 2022-04-05 02:11:43 -0700 (Tue, 05 Apr 2022)
Log Message
[GStreamer] gst_video_format_info_component not defined in GStreamer <1.18
https://bugs.webkit.org/show_bug.cgi?id=238685
Reviewed by Philippe Normand.
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::webkitGstVideoFormatInfoComponent):
* platform/graphics/gstreamer/GStreamerCommon.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (292386 => 292387)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 08:50:32 UTC (rev 292386)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 09:11:43 UTC (rev 292387)
@@ -1,3 +1,14 @@
+2022-04-05 Diego Pino Garcia
+
+[GStreamer] gst_video_format_info_component not defined in GStreamer <1.18
+https://bugs.webkit.org/show_bug.cgi?id=238685
+
+Reviewed by Philippe Normand.
+
+* platform/graphics/gstreamer/GStreamerCommon.cpp:
+(WebCore::webkitGstVideoFormatInfoComponent):
+* platform/graphics/gstreamer/GStreamerCommon.h:
+
2022-04-05 Nikolaos Mouchtaris
Support rendering url(), CSS basic shapes other than path(), and coord-box for offset-path
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp (292386 => 292387)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2022-04-05 08:50:32 UTC (rev 292386)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2022-04-05 09:11:43 UTC (rev 292387)
@@ -85,6 +85,24 @@
return pad;
}
+#if !GST_CHECK_VERSION(1, 18, 0)
+void webkitGstVideoFormatInfoComponent(const GstVideoFormatInfo* info, guint plane, gint components[GST_VIDEO_MAX_COMPONENTS])
+{
+guint c, i = 0;
+
+/* Reverse mapping of info->plane. */
+for (c = 0; c < GST_VIDEO_FORMAT_INFO_N_COMPONENTS(info); c++) {
+if (GST_VIDEO_FORMAT_INFO_PLANE(info, c) == plane) {
+components[i] = c;
+i++;
+}
+}
+
+for (c = i; c < GST_VIDEO_MAX_COMPONENTS; c++)
+components[c] = -1;
+}
+#endif
+
#if ENABLE(VIDEO)
bool getVideoSizeAndFormatFromCaps(const GstCaps* caps, WebCore::IntSize& size, GstVideoFormat& format, int& pixelAspectRatioNumerator, int& pixelAspectRatioDenominator, int& stride)
{
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h (292386 => 292387)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h 2022-04-05 08:50:32 UTC (rev 292386)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h 2022-04-05 09:11:43 UTC (rev 292387)
@@ -55,6 +55,15 @@
return true;
}
+// gst_video_format_info_component() is GStreamer 1.18 API, so for older versions we use a local
+// vendored copy of the function.
+#if !GST_CHECK_VERSION(1, 18, 0)
+#define GST_VIDEO_MAX_COMPONENTS 4
+void webkitGstVideoFormatInfoComponent(const GstVideoFormatInfo*, guint, gint components[GST_VIDEO_MAX_COMPONENTS]);
+
+#define gst_video_format_info_component webkitGstVideoFormatInfoComponent
+#endif
+
#define GST_VIDEO_CAPS_TYPE_PREFIX "video/"
#define GST_AUDIO_CAPS_TYPE_PREFIX "audio/"
#define GST_TEXT_CAPS_TYPE_PREFIX "text/"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292386] trunk/LayoutTests
Title: [292386] trunk/LayoutTests Revision 292386 Author hey...@apple.com Date 2022-04-05 01:50:32 -0700 (Tue, 05 Apr 2022) Log Message Skip editing-word-with-marker-1.html https://bugs.webkit.org/show_bug.cgi?id=238767 Unreviewed test gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292385 => 292386) --- trunk/LayoutTests/ChangeLog 2022-04-05 08:36:06 UTC (rev 292385) +++ trunk/LayoutTests/ChangeLog 2022-04-05 08:50:32 UTC (rev 292386) @@ -1,3 +1,12 @@ +2022-04-05 Cameron McCormack + +Skip editing-word-with-marker-1.html +https://bugs.webkit.org/show_bug.cgi?id=238767 + +Unreviewed test gardening. + +* TestExpectations: + 2022-04-05 Tim Nguyen [iOS] Add timeout expectations for focus-after-close.html WPT Modified: trunk/LayoutTests/TestExpectations (292385 => 292386) --- trunk/LayoutTests/TestExpectations 2022-04-05 08:36:06 UTC (rev 292385) +++ trunk/LayoutTests/TestExpectations 2022-04-05 08:50:32 UTC (rev 292386) @@ -4845,6 +4845,9 @@ # "Opacity on an inline element should apply on float child". webkit.org/b/234690 imported/w3c/web-platform-tests/css/css-color/inline-opacity-float-child.html [ ImageOnlyFailure ] +# Interferes with following test +webkit.org/b/237812 editing/spelling/editing-word-with-marker-1.html [ Skip ] + # color-mix() doesn't work with currentcolor webkit.org/b/234691 imported/w3c/web-platform-tests/css/css-color/color-mix-basic-001.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/ios/TestExpectations (292385 => 292386) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-04-05 08:36:06 UTC (rev 292385) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-04-05 08:50:32 UTC (rev 292386) @@ -3547,7 +3547,6 @@ webkit.org/b/238519 animations/shadow-host-child-change.html [ Pass ImageOnlyFailure ] webkit.org/b/236930 accessibility/ios-simulator/aria-details.html [ Crash Pass ] -webkit.org/b/236794 editing/spelling/editing-word-with-marker-2.html [ Pass Crash ] webkit.org/b/238284 editing/spelling/spellcheck-async-remove-frame.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292385] trunk/Source/WebKit
Title: [292385] trunk/Source/WebKit
Revision 292385
Author megan_gard...@apple.com
Date 2022-04-05 01:36:06 -0700 (Tue, 05 Apr 2022)
Log Message
Expand autocorrect context for more accurate results.
https://bugs.webkit.org/show_bug.cgi?id=237990
Reviewed by Wenson Hsieh.
Covered by existing tests.
Expand autocorrect context to at least 10 words instead of 3, and with a min/max length of 40/100
instead of 12/30 and start context at the beginning of sentences to help with having more accurate
autocorrect suggestions.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::autocorrectionContext):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292384 => 292385)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 08:21:52 UTC (rev 292384)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 08:36:06 UTC (rev 292385)
@@ -1,3 +1,19 @@
+2022-04-05 Megan Gardner
+
+Expand autocorrect context for more accurate results.
+https://bugs.webkit.org/show_bug.cgi?id=237990
+
+Reviewed by Wenson Hsieh.
+
+Covered by existing tests.
+
+Expand autocorrect context to at least 10 words instead of 3, and with a min/max length of 40/100
+instead of 12/30 and start context at the beginning of sentences to help with having more accurate
+autocorrect suggestions.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::autocorrectionContext):
+
2022-04-05 Tim Horton
Remove system feature flags implementation
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (292384 => 292385)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2022-04-05 08:21:52 UTC (rev 292384)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2022-04-05 08:36:06 UTC (rev 292385)
@@ -2565,9 +2565,9 @@
Ref frame = CheckedRef(m_page->focusController())->focusedOrMainFrame();
VisiblePosition startPosition = frame->selection().selection().start();
VisiblePosition endPosition = frame->selection().selection().end();
-const unsigned minContextWordCount = 3;
-const unsigned minContextLength = 12;
-const unsigned maxContextLength = 30;
+const unsigned minContextWordCount = 10;
+const unsigned minContextLength = 40;
+const unsigned maxContextLength = 100;
if (frame->selection().isRange())
selectedText = plainTextForContext(frame->selection().selection().toNormalizedRange());
@@ -2598,7 +2598,10 @@
break;
contextStartPosition = previousPosition;
}
-if (contextStartPosition.isNotNull() && contextStartPosition != startPosition) {
+VisiblePosition sentenceContextStartPosition = startOfSentence(startPosition);
+if (sentenceContextStartPosition.isNotNull() && sentenceContextStartPosition < contextStartPosition)
+contextStartPosition = sentenceContextStartPosition;
+if (contextStartPosition.isNotNull() && contextStartPosition < startPosition) {
contextBefore = plainTextForContext(makeSimpleRange(contextStartPosition, startPosition));
if (atBoundaryOfGranularity(contextStartPosition, TextGranularity::ParagraphGranularity, SelectionDirection::Backward) && firstPositionInEditableContent != contextStartPosition)
contextBefore = makeString("\n "_s, contextBefore);
@@ -2606,10 +2609,9 @@
}
if (endPosition != endOfEditableContent(endPosition)) {
-VisiblePosition nextPosition;
-if (!atBoundaryOfGranularity(endPosition, TextGranularity::WordGranularity, SelectionDirection::Forward) && withinTextUnitOfGranularity(endPosition, TextGranularity::WordGranularity, SelectionDirection::Forward))
-nextPosition = positionOfNextBoundaryOfGranularity(endPosition, TextGranularity::WordGranularity, SelectionDirection::Forward);
-contextAfter = plainTextForContext(makeSimpleRange(endPosition, nextPosition));
+VisiblePosition nextPosition = endOfSentence(endPosition);
+if (nextPosition.isNotNull() && nextPosition > endPosition)
+contextAfter = plainTextForContext(makeSimpleRange(endPosition, nextPosition));
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292384] trunk/Source/ThirdParty/ANGLE
Title: [292384] trunk/Source/ThirdParty/ANGLE
Revision 292384
Author commit-qu...@webkit.org
Date 2022-04-05 01:21:52 -0700 (Tue, 05 Apr 2022)
Log Message
Update ANGLE changes.diff after "Roll ANGLE to 2022-03-31 (fe28a4295af087ee82b8f629b67176b95019af6d)"
https://bugs.webkit.org/show_bug.cgi?id=238794
Unreviewed, verifiable by running the script.
Update the diff, turns out it was not up-to-date.
Patch by Kimmo Kinnunen on 2022-04-05
* changes.diff:
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/changes.diff
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (292383 => 292384)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-04-05 08:19:21 UTC (rev 292383)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2022-04-05 08:21:52 UTC (rev 292384)
@@ -1,3 +1,14 @@
+2022-04-05 Kimmo Kinnunen
+
+Update ANGLE changes.diff after "Roll ANGLE to 2022-03-31 (fe28a4295af087ee82b8f629b67176b95019af6d)"
+https://bugs.webkit.org/show_bug.cgi?id=238794
+
+Unreviewed, verifiable by running the script.
+
+Update the diff, turns out it was not up-to-date.
+
+* changes.diff:
+
2022-04-04 Kenneth Russell
Roll ANGLE to 2022-03-31 (fe28a4295af087ee82b8f629b67176b95019af6d)
Modified: trunk/Source/ThirdParty/ANGLE/changes.diff (292383 => 292384)
--- trunk/Source/ThirdParty/ANGLE/changes.diff 2022-04-05 08:19:21 UTC (rev 292383)
+++ trunk/Source/ThirdParty/ANGLE/changes.diff 2022-04-05 08:21:52 UTC (rev 292384)
@@ -1,5 +1,5 @@
diff --git a/.gitignore b/.gitignore
-index ba19389dc..afeca1d58 100644
+index ba19389..afeca1d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -63,6 +63,7 @@
@@ -12,7 +12,7 @@
/third_party/six
diff --git a/ChangeLog-2022-02-22 b/ChangeLog-2022-02-22
new file mode 100644
-index 0..ca67026bc
+index 000..ca67026
--- /dev/null
+++ b/ChangeLog-2022-02-22
@@ -0,0 +1,19278 @@
@@ -19296,7 +19296,7 @@
+
diff --git a/scripts/copy-frameworks-to-secondary-path.sh b/scripts/copy-frameworks-to-secondary-path.sh
new file mode 100755
-index 0..2e00c1270
+index 000..2e00c12
--- /dev/null
+++ b/scripts/copy-frameworks-to-secondary-path.sh
@@ -0,0 +1,62 @@
@@ -19363,7 +19363,7 @@
+done
+fi
diff --git a/scripts/run_code_generation.py b/scripts/run_code_generation.py
-index fa1a029b5..bc79da2ad 100755
+index fa1a029..bc79da2 100755
--- a/scripts/run_code_generation.py
+++ b/scripts/run_code_generation.py
@@ -254,8 +254,11 @@ def main():
@@ -19379,7 +19379,7 @@
# Update the hash dictionary.
all_new_hashes[fname] = new_hashes
diff --git a/src/common/utilities.cpp b/src/common/utilities.cpp
-index a175734c3..7fc9aa792 100644
+index a175734..7fc9aa7 100644
--- a/src/common/utilities.cpp
+++ b/src/common/utilities.cpp
@@ -6,6 +6,12 @@
@@ -19396,7 +19396,7 @@
#include "GLES3/gl3.h"
#include "common/mathutil.h"
diff --git a/src/compiler/preprocessor/preprocessor_tab_autogen.cpp b/src/compiler/preprocessor/preprocessor_tab_autogen.cpp
-index 50822f200..3ece2105b 100644
+index 50822f2..3ece210 100644
--- a/src/compiler/preprocessor/preprocessor_tab_autogen.cpp
+++ b/src/compiler/preprocessor/preprocessor_tab_autogen.cpp
@@ -1,5 +1,8 @@
@@ -19409,7 +19409,7 @@
Copyright (C) 1984, 1989-1990, 2000-2015, 2018-2019 Free Software Foundation,
diff --git a/src/compiler/translator/CodeGen.cpp b/src/compiler/translator/CodeGen.cpp
-index 497ef881e..47213c904 100644
+index 497ef88..47213c9 100644
--- a/src/compiler/translator/CodeGen.cpp
+++ b/src/compiler/translator/CodeGen.cpp
@@ -23,6 +23,9 @@
@@ -19422,33 +19422,9 @@
#ifdef ANGLE_ENABLE_METAL_SPIRV
#include "compiler/translator/TranslatorMetal.h"
-diff --git a/src/compiler/translator/TranslatorMetalDirect.cpp b/src/compiler/translator/TranslatorMetalDirect.cpp
-index 4c85dc199..7197f8e13 100644
a/src/compiler/translator/TranslatorMetalDirect.cpp
-+++ b/src/compiler/translator/TranslatorMetalDirect.cpp
-@@ -943,7 +943,6 @@ bool TranslatorMetalDirect::translateImpl(TInfoSinkBase ,
- getSymbolTable().findBuiltIn(ImmutableString("gl_PointSize"), getShaderVersion()));
- DeclareRightBeforeMain(*root, *pointSize);
- }
--
- if (FindSymbolNode(root, BuiltInVariable::gl_VertexIndex()->name()))
- {
- if (!ReplaceVariable(this, root, BuiltInVariable::gl_VertexIndex(), _VertexIDMetal))
-diff --git a/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp b/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp
-index 4610d5cfc..8f9a13bfa 100644
a/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp
-+++ b/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp
-@@ -1740,7 +1740,6 @@ void GenMetalTraverser::emitFunctionSignature(const TFunction )
- const TVariable = *func.getParam(i);
- emitFunctionParameter(func, param);
- }
--
- if (isTraversingVertexMain)
- {
-
[webkit-changes] [292383] trunk/Source
Title: [292383] trunk/Source
Revision 292383
Author timothy_hor...@apple.com
Date 2022-04-05 01:19:21 -0700 (Tue, 05 Apr 2022)
Log Message
Remove system feature flags implementation
https://bugs.webkit.org/show_bug.cgi?id=238791
Reviewed by Megan Gardner.
Source/WebKit:
* Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
(WebKit::isFeatureFlagEnabled): Deleted.
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::isFeatureFlagEnabled): Deleted.
* Shared/WebPreferencesDefaultValues.h:
* Shared/win/WebPreferencesDefaultValuesWin.cpp: Removed.
Source/WebKitLegacy/mac:
* WebView/WebPreferencesDefaultValues.h:
* WebView/WebPreferencesDefaultValues.mm:
(WebKit::isFeatureFlagEnabled): Deleted.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWin.cmake
trunk/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm
Removed Paths
trunk/Source/WebKit/Shared/win/WebPreferencesDefaultValuesWin.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292382 => 292383)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 08:03:38 UTC (rev 292382)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 08:19:21 UTC (rev 292383)
@@ -1,3 +1,17 @@
+2022-04-05 Tim Horton
+
+Remove system feature flags implementation
+https://bugs.webkit.org/show_bug.cgi?id=238791
+
+Reviewed by Megan Gardner.
+
+* Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:
+(WebKit::isFeatureFlagEnabled): Deleted.
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::isFeatureFlagEnabled): Deleted.
+* Shared/WebPreferencesDefaultValues.h:
+* Shared/win/WebPreferencesDefaultValuesWin.cpp: Removed.
+
2022-04-05 Adrian Perez de Castro
[WPE] Mark "backend" parameters of web view constructors not nullable
Modified: trunk/Source/WebKit/PlatformWin.cmake (292382 => 292383)
--- trunk/Source/WebKit/PlatformWin.cmake 2022-04-05 08:03:38 UTC (rev 292382)
+++ trunk/Source/WebKit/PlatformWin.cmake 2022-04-05 08:19:21 UTC (rev 292383)
@@ -44,7 +44,6 @@
Shared/win/NativeWebWheelEventWin.cpp
Shared/win/WebCoreArgumentCodersWin.cpp
Shared/win/WebEventFactory.cpp
-Shared/win/WebPreferencesDefaultValuesWin.cpp
UIProcess/BackingStore.cpp
UIProcess/DefaultUndoController.cpp
Modified: trunk/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm (292382 => 292383)
--- trunk/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm 2022-04-05 08:03:38 UTC (rev 292382)
+++ trunk/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm 2022-04-05 08:19:21 UTC (rev 292383)
@@ -30,7 +30,6 @@
#import "ImageAnalysisUtilities.h"
#import
-#import
#import
#import
#import
@@ -37,35 +36,7 @@
namespace WebKit {
-// Because of , WebKit has to parse the feature flags plist file
-bool isFeatureFlagEnabled(const char* featureName, bool defaultValue)
-{
-#if HAVE(SYSTEM_FEATURE_FLAGS)
-
#if PLATFORM(MAC)
-static bool isSystemWebKit = [] {
-NSBundle *bundle = [NSBundle bundleForClass:NSClassFromString(@"WKWebView")];
-return [bundle.bundlePath hasPrefix:@"/System/"];
-}();
-
-if (isSystemWebKit)
-return _os_feature_enabled_impl("WebKit", featureName);
-
-return defaultValue;
-#else
-UNUSED_PARAM(defaultValue);
-return _os_feature_enabled_impl("WebKit", featureName);
-#endif // PLATFORM(MAC)
-
-#else
-
-UNUSED_PARAM(featureName);
-return defaultValue;
-
-#endif // HAVE(SYSTEM_FEATURE_FLAGS)
-}
-
-#if PLATFORM(MAC)
bool defaultScrollAnimatorEnabled()
{
return [[NSUserDefaults standardUserDefaults] boolForKey:@"NSScrollAnimationEnabled"];
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (292382 => 292383)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2022-04-05 08:03:38 UTC (rev 292382)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2022-04-05 08:19:21 UTC (rev 292383)
@@ -30,7 +30,6 @@
#include
#if PLATFORM(COCOA)
-#include
#include
#endif
@@ -41,13 +40,6 @@
namespace WebKit {
-#if !PLATFORM(COCOA) && !PLATFORM(WIN)
-bool isFeatureFlagEnabled(const char*, bool defaultValue)
-{
-return defaultValue;
-}
-#endif
-
#if PLATFORM(IOS_FAMILY)
bool defaultPassiveTouchListenersAsDefaultOnDocument()
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (292382 => 292383)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2022-04-05 08:03:38 UTC (rev 292382)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2022-04-05 08:19:21 UTC (rev 292383)
@@ -35,8 +35,6 @@
namespace WebKit {
-bool isFeatureFlagEnabled(const char*, bool defaultValue = false);
-
[webkit-changes] [292382] trunk
Title: [292382] trunk
Revision 292382
Author nmouchta...@apple.com
Date 2022-04-05 01:03:38 -0700 (Tue, 05 Apr 2022)
Log Message
Support rendering url(), CSS basic shapes other than path(), and coord-box for offset-path
https://bugs.webkit.org/show_bug.cgi?id=233382
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
* web-platform-tests/css/motion/offset-path-shape-expected.html: Added.
* web-platform-tests/css/motion/offset-path-shape.html: Added.
* web-platform-tests/css/motion/offset-path-url-expected.html: Added.
* web-platform-tests/css/motion/offset-path-url.html: Added.
Source/WebCore:
Introduce support for url(), CSS basic shapes, and coord-box. Url() allows references to SVG
shapes, so we check for either an SVGPathElement or SVGGeometryElement (which includes
circles, polygons, etc.). We can then get a Path object for that particular SVGElement
using pathFromGraphicsElement(). For coord-box, we check the value for the BoxPathOperation
(if it exists) in updateTransform(), and choose the corresponding reference box to the
referenceBox() value of the BoxPathOperation.
Tests: imported/w3c/web-platform-tests/css/motion/offset-path-shape.html
imported/w3c/web-platform-tests/css/motion/offset-path-url.html
* Sources.txt:
* rendering/PathOperation.cpp: Added.
(WebCore::ReferencePathOperation::create):
(WebCore::ReferencePathOperation::ReferencePathOperation):
(WebCore::ReferencePathOperation::element const):
* rendering/PathOperation.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateTransform):
* rendering/style/RenderStyle.cpp:
(WebCore::getPathFromPathOperation):
* style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPathOperation):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/rendering/PathOperation.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/style/StyleBuilderConverter.h
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-geometry-box-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-geometry-box.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-url-expected.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-url.html
trunk/Source/WebCore/rendering/PathOperation.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292381 => 292382)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-05 08:01:50 UTC (rev 292381)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-05 08:03:38 UTC (rev 292382)
@@ -1,3 +1,15 @@
+2022-04-05 Nikolaos Mouchtaris
+
+Support rendering url(), CSS basic shapes other than path(), and coord-box for offset-path
+https://bugs.webkit.org/show_bug.cgi?id=233382
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/css/motion/offset-path-shape-expected.html: Added.
+* web-platform-tests/css/motion/offset-path-shape.html: Added.
+* web-platform-tests/css/motion/offset-path-url-expected.html: Added.
+* web-platform-tests/css/motion/offset-path-url.html: Added.
+
2022-04-04 Ziran Sun
[Forms] change the default appearance of button, checkbox etc. to 'auto'
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-geometry-box-expected.html (0 => 292382)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-geometry-box-expected.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-geometry-box-expected.html 2022-04-05 08:03:38 UTC (rev 292382)
@@ -0,0 +1,21 @@
+
+
+
+CSS Motion Path: path(geometry-box) paths
+
+ #target {
+position: absolute;
+left: 300px;
+top: 0px;
+width: 300px;
+height: 200px;
+background-color: lime;
+transform-origin: 0px 0px;
+transform: translate(0px, 0px);
+ }
+
+
+
+
+
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-geometry-box.html (0 => 292382)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-geometry-box.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-geometry-box.html 2022-04-05 08:03:38 UTC (rev 292382)
@@ -0,0 +1,24 @@
+
+
+
+CSS Motion Path: path(basic-shape) paths
+
+
+ #target {
+position: absolute;
+left: 300px;
+top: 0px;
+width: 300px;
+height: 200px;
+background-color: lime;
+transform-origin: 0px 0px;
+offset-path:
[webkit-changes] [292381] trunk
Title: [292381] trunk
Revision 292381
Author megan_gard...@apple.com
Date 2022-04-05 01:01:50 -0700 (Tue, 05 Apr 2022)
Log Message
Moving forwards and backwards by sentences across a table results in different breaks in each direction.
https://bugs.webkit.org/show_bug.cgi?id=238621
Reviewed by Darin Adler.
Tests: editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity.html
editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity.html
We need to emit tabs even in a simplified backwards text iterator because otherwise traversing a table by
sentence granularity results in not having the same behavior backwards and forwards.
* editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):
Modified Paths
trunk/LayoutTests/editing/text-iterator/backwards-text-iterator-basic-expected.txt
trunk/LayoutTests/editing/text-iterator/backwards-text-iterator-basic.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextIterator.cpp
Added Paths
trunk/LayoutTests/editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity-expected.txt
trunk/LayoutTests/editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity.html
trunk/LayoutTests/editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity-expected.txt
trunk/LayoutTests/editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity.html
Diff
Added: trunk/LayoutTests/editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity-expected.txt (0 => 292381)
--- trunk/LayoutTests/editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity-expected.txt 2022-04-05 08:01:50 UTC (rev 292381)
@@ -0,0 +1,19 @@
+This tests moving the selection backwards at the end of a table by sentence granularity. The caret should move to the beginning of the table.
+| "\n"
+|
+| "\n "
+|
+|
+| "\n"
+|
+| "<#selection-caret>First"
+| "\n"
+|
+| "Second"
+| " \n"
+|
+| id="target"
+| "Third"
+| "\n "
+| "\n"
+| "\n"
Added: trunk/LayoutTests/editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity.html (0 => 292381)
--- trunk/LayoutTests/editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity.html (rev 0)
+++ trunk/LayoutTests/editing/selection/move-selection-backwards-at-end-of-table-by-sentence-granularity.html 2022-04-05 08:01:50 UTC (rev 292381)
@@ -0,0 +1,31 @@
+
+
+
+table, th, td {
+ border:1px solid black;
+}
+
+
+
+
+
+First
+Second
+Third
+
+
+
+
+
+Markup.description('This tests moving the selection backwards at the end of a table by sentence granularity. The caret should move to the beginning of the table.');
+
+editor.focus();
+getSelection().setPosition(target, 5);
+getSelection().modify('move', 'left', 'sentence');
+
+Markup.dump(editor);
+
+
+
+
Added: trunk/LayoutTests/editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity-expected.txt (0 => 292381)
--- trunk/LayoutTests/editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity-expected.txt 2022-04-05 08:01:50 UTC (rev 292381)
@@ -0,0 +1,20 @@
+This tests moving the selection forwards to the end of a table by sentence granularity. The caret should move to the end of the table.
+| "\n"
+|
+| "\n "
+|
+|
+| "\n"
+|
+| id="target"
+| "First"
+| "\n"
+|
+| "Second"
+| " \n"
+|
+| "Third"
+| "\n "
+| "\n"
+| <#selection-caret>
+| "\n"
Added: trunk/LayoutTests/editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity.html (0 => 292381)
--- trunk/LayoutTests/editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity.html (rev 0)
+++ trunk/LayoutTests/editing/selection/move-selection-forwards-at-beginning-of-table-by-sentence-granularity.html 2022-04-05 08:01:50 UTC (rev 292381)
@@ -0,0 +1,31 @@
+
+
+
+table, th, td {
+ border:1px solid black;
+}
+
+
+
+
+
+First
+Second
+Third
+
+
+
+
+
+Markup.description('This tests moving the selection forwards to the end of a table by sentence granularity. The caret should move to the end of the table.');
+
+editor.focus();
+getSelection().setPosition(target, 0);
+getSelection().modify('move', 'right',
[webkit-changes] [292380] trunk/Source/WebCore
Title: [292380] trunk/Source/WebCore
Revision 292380
Author zandober...@gmail.com
Date 2022-04-05 00:32:25 -0700 (Tue, 05 Apr 2022)
Log Message
Unreviewed, reverting r292377.
The depended-on patch hasn't landed yet
Reverted changeset:
"[GTK][WPE] Use UnixFileDescriptor in DMABufObject,
DMABufReleaseFlag"
https://bugs.webkit.org/show_bug.cgi?id=238733
https://commits.webkit.org/r292377
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h
trunk/Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h
trunk/Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292379 => 292380)
--- trunk/Source/WebCore/ChangeLog 2022-04-05 07:28:33 UTC (rev 292379)
+++ trunk/Source/WebCore/ChangeLog 2022-04-05 07:32:25 UTC (rev 292380)
@@ -1,3 +1,16 @@
+2022-04-05 Zan Dobersek
+
+Unreviewed, reverting r292377.
+
+The depended-on patch hasn't landed yet
+
+Reverted changeset:
+
+"[GTK][WPE] Use UnixFileDescriptor in DMABufObject,
+DMABufReleaseFlag"
+https://bugs.webkit.org/show_bug.cgi?id=238733
+https://commits.webkit.org/r292377
+
2022-04-04 Zan Dobersek
[GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag
Modified: trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h (292379 => 292380)
--- trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h 2022-04-05 07:28:33 UTC (rev 292379)
+++ trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h 2022-04-05 07:32:25 UTC (rev 292380)
@@ -32,7 +32,6 @@
#include
#include
#include
-#include
namespace WebCore {
@@ -41,20 +40,50 @@
: handle(handle)
{ }
-~DMABufObject() = default;
+~DMABufObject()
+{
+for (unsigned i = 0; i < format.numPlanes; ++i) {
+if (fd[i] != -1)
+close(fd[i]);
+}
+}
DMABufObject(const DMABufObject&) = delete;
DMABufObject& operator=(const DMABufObject&) = delete;
-DMABufObject(DMABufObject&&) = default;
-DMABufObject& operator=(DMABufObject&&) = default;
+DMABufObject(DMABufObject&& o)
+: handle(o.handle)
+, format(o.format)
+, width(o.width)
+, height(o.height)
+, releaseFlag(WTFMove(o.releaseFlag))
+{
+for (unsigned i = 0; i < format.numPlanes; ++i) {
+fd[i] = o.fd[i];
+o.fd[i] = -1;
+offset[i] = o.offset[i];
+stride[i] = o.stride[i];
+modifier[i] = o.modifier[i];
+}
+}
+
+DMABufObject& operator=(DMABufObject&& o)
+{
+if (this == )
+return *this;
+
+this->~DMABufObject();
+new (this) DMABufObject(WTFMove(o));
+return *this;
+}
+
uintptr_t handle { 0 };
DMABufFormat format { };
uint32_t width { 0 };
uint32_t height { 0 };
DMABufReleaseFlag releaseFlag { };
-std::array fd { };
+std::array fd { -1, -1, -1, -1 };
std::array offset { 0, 0, 0, 0 };
std::array stride { 0, 0, 0, 0 };
std::array modifier { 0, 0, 0, 0 };
Modified: trunk/Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h (292379 => 292380)
--- trunk/Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h 2022-04-05 07:28:33 UTC (rev 292379)
+++ trunk/Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h 2022-04-05 07:32:25 UTC (rev 292380)
@@ -27,7 +27,7 @@
#pragma once
#include
-#include
+#include
namespace WebCore {
@@ -37,31 +37,52 @@
enum InitializeTag { Initialize };
DMABufReleaseFlag(InitializeTag)
{
-fd = { eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK), WTF::UnixFileDescriptor::Adopt };
+fd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK);
}
-~DMABufReleaseFlag() = default;
+~DMABufReleaseFlag()
+{
+if (fd != -1)
+close(fd);
+fd = -1;
+}
DMABufReleaseFlag(const DMABufReleaseFlag&) = delete;
DMABufReleaseFlag& operator=(const DMABufReleaseFlag&) = delete;
-DMABufReleaseFlag(DMABufReleaseFlag&&) = default;
-DMABufReleaseFlag& operator=(DMABufReleaseFlag&&) = default;
+DMABufReleaseFlag(DMABufReleaseFlag&& o)
+{
+fd = o.fd;
+o.fd = -1;
+}
+DMABufReleaseFlag& operator=(DMABufReleaseFlag&& o)
+{
+if (this == )
+return *this;
+
+this->~DMABufReleaseFlag();
+new (this) DMABufReleaseFlag(WTFMove(o));
+return *this;
+}
+
DMABufReleaseFlag dup() const
{
+if (fd == -1)
+return { };
+
DMABufReleaseFlag flag;
-flag.fd = fd.duplicate();
+flag.fd =
[webkit-changes] [292379] trunk/Source/WebKit
Title: [292379] trunk/Source/WebKit
Revision 292379
Author ape...@igalia.com
Date 2022-04-05 00:28:33 -0700 (Tue, 05 Apr 2022)
Log Message
[WPE] Mark "backend" parameters of web view constructors not nullable
https://bugs.webkit.org/show_bug.cgi?id=238734
Reviewed by Martin Robinson.
No new tests needed.
* UIProcess/API/wpe/WebKitWebViewWPE.cpp: Annotate web view constructors with (not nullable)
and while at it, fix documentation links, and improve the wording to better follow gi-docgen
copywriting style. Remove the mentions to the single process model, which is deprecated anyway.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292378 => 292379)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 07:09:52 UTC (rev 292378)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 07:28:33 UTC (rev 292379)
@@ -1,3 +1,16 @@
+2022-04-05 Adrian Perez de Castro
+
+[WPE] Mark "backend" parameters of web view constructors not nullable
+https://bugs.webkit.org/show_bug.cgi?id=238734
+
+Reviewed by Martin Robinson.
+
+No new tests needed.
+
+* UIProcess/API/wpe/WebKitWebViewWPE.cpp: Annotate web view constructors with (not nullable)
+and while at it, fix documentation links, and improve the wording to better follow gi-docgen
+copywriting style. Remove the mentions to the single process model, which is deprecated anyway.
+
2022-04-04 Tim Horton
Stop generating WebKit system feature flags plists
Modified: trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp (292378 => 292379)
--- trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp 2022-04-05 07:09:52 UTC (rev 292378)
+++ trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp 2022-04-05 07:28:33 UTC (rev 292379)
@@ -62,15 +62,19 @@
/**
* webkit_web_view_new:
- * @backend: (transfer full): a #WebKitWebViewBackend
+ * @backend: (transfer full) (not nullable): wrapped WPE view backend which
+ *will determine the behaviour of the new [class@WebView].
*
- * Creates a new #WebKitWebView with the default #WebKitWebContext and
- * no #WebKitUserContentManager associated with it.
- * See also webkit_web_view_new_with_context(),
- * webkit_web_view_new_with_user_content_manager(), and
- * webkit_web_view_new_with_settings().
+ * Creates a new web view with a default configuration.
*
- * Returns: The newly created #WebKitWebView
+ * The new view will use the default [class@WebContext] and will not
+ * have an associated [class@UserContentManager].
+ *
+ * See also [id@webkit_web_view_new_with_context],
+ * [id@webkit_web_view_new_with_user_content_manager]), and
+ * [id@webkit_web_view_new_with_settings].
+ *
+ * Returns: The newly created web view.
*/
WebKitWebView* webkit_web_view_new(WebKitWebViewBackend* backend)
{
@@ -84,15 +88,19 @@
/**
* webkit_web_view_new_with_context:
- * @backend: (transfer full): a #WebKitWebViewBackend
- * @context: the #WebKitWebContext to be used by the #WebKitWebView
+ * @backend: (transfer full) (not nullable): wrapped WPE view backend which
+ *will determine the behaviour of the new [class@WebView].
+ * @context: the web context the new [class@WebView] will use.
*
- * Creates a new #WebKitWebView with the given #WebKitWebContext and
- * no #WebKitUserContentManager associated with it.
- * See also webkit_web_view_new_with_user_content_manager() and
- * webkit_web_view_new_with_settings().
+ * Creates a new web view with a given context.
*
- * Returns: The newly created #WebKitWebView
+ * The new web view will use the given [class@WebContext] and will not have
+ * an associated [class@UserContentManager].
+ *
+ * See also [id@webkit_web_view_new_with_user_content_manager] and
+ * [id@webkit_web_view_new_with_settings].
+ *
+ * Returns: The newly created web view.
*/
WebKitWebView* webkit_web_view_new_with_context(WebKitWebViewBackend* backend, WebKitWebContext* context)
{
@@ -108,22 +116,20 @@
/**
* webkit_web_view_new_with_related_view: (constructor)
- * @backend: (transfer full): a #WebKitWebViewBackend
- * @web_view: the related #WebKitWebView
+ * @backend: (transfer full) (not nullable): wrapped WPE view backend which
+ *will determine the behaviour of the new [class@WebView].
+ * @web_view: the related web view.
*
- * Creates a new #WebKitWebView sharing the same web process with @web_view.
- * This method doesn't have any effect when %WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS
- * process model is used, because a single web process is shared for all the web views in the
- * same #WebKitWebContext. When using %WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES process model,
- * this method should always be used when creating the #WebKitWebView in the #WebKitWebView::create signal.
- * You can also use this method to implement other process models based on
[webkit-changes] [292378] trunk/LayoutTests
Title: [292378] trunk/LayoutTests Revision 292378 Author n...@apple.com Date 2022-04-05 00:09:52 -0700 (Tue, 05 Apr 2022) Log Message [iOS] Add timeout expectations for focus-after-close.html WPT Unreviewed test gardening. * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (292377 => 292378) --- trunk/LayoutTests/ChangeLog 2022-04-05 06:54:36 UTC (rev 292377) +++ trunk/LayoutTests/ChangeLog 2022-04-05 07:09:52 UTC (rev 292378) @@ -1,3 +1,11 @@ +2022-04-05 Tim Nguyen + +[iOS] Add timeout expectations for focus-after-close.html WPT + +Unreviewed test gardening. + +* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-expected.txt: Added. + 2022-04-04 Ziran Sun [Forms] change the default appearance of button, checkbox etc. to 'auto' Added: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-expected.txt (0 => 292378) --- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-expected.txt 2022-04-05 07:09:52 UTC (rev 292378) @@ -0,0 +1,12 @@ + + +Harness Error (TIMEOUT), message = null + +PASS Focus should be moved to the previously focused element (Simple dialog usage) +PASS Focus should be moved to the previously focused element (Complex dialog usage) +PASS Focus should be moved to the previously focused element even if it has moved in between show/close +PASS Focus should be moved to the previously focused element even if it has moved to shadow DOM root in between show/close +PASS Focus should be moved to the body if the previously focused element is removed +PASS Focus should be moved to the shadow DOM host if the previouly focused element is a shadow DOM node +TIMEOUT Focus should not scroll if the previously focused element is outside the viewport Test timed out + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292377] trunk/Source/WebCore
Title: [292377] trunk/Source/WebCore Revision 292377 Author zandober...@gmail.com Date 2022-04-04 23:54:36 -0700 (Mon, 04 Apr 2022) Log Message [GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag https://bugs.webkit.org/show_bug.cgi?id=238733 Reviewed by Adrian Perez de Castro. Replace integer values for file descriptors in the DMABufObject and DMABufReleaseFlag structs with UnixFileDescriptors. This enables simply defaulting the destructors and the move constructors and assignment operatos for the two types since the fd wrapper takes care of these operations. Additionally, when constructing the UnixFileDescriptor objects from file descriptors coming from different sources, we can more easily adapt to the need for either adoption or duplication of the passed-in file descriptor right there in the constructor invocation. * platform/graphics/gbm/DMABufObject.h: (WebCore::DMABufObject::~DMABufObject): Deleted. (WebCore::DMABufObject::operator=): Deleted. * platform/graphics/gbm/DMABufReleaseFlag.h: (WebCore::DMABufReleaseFlag::DMABufReleaseFlag): (WebCore::DMABufReleaseFlag::dup const): (WebCore::DMABufReleaseFlag::released const): (WebCore::DMABufReleaseFlag::release): (WebCore::DMABufReleaseFlag::~DMABufReleaseFlag): Deleted. (WebCore::DMABufReleaseFlag::operator=): Deleted. * platform/graphics/gbm/GBMBufferSwapchain.cpp: (WebCore::GBMBufferSwapchain::Buffer::createDMABufObject const): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): * platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLANGLE::makeContextCurrent): * platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp: (WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::createEGLImageData): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h trunk/Source/WebCore/platform/graphics/gbm/DMABufReleaseFlag.h trunk/Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp trunk/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (292376 => 292377) --- trunk/Source/WebCore/ChangeLog 2022-04-05 05:38:59 UTC (rev 292376) +++ trunk/Source/WebCore/ChangeLog 2022-04-05 06:54:36 UTC (rev 292377) @@ -1,3 +1,40 @@ +2022-04-04 Zan Dobersek + +[GTK][WPE] Use UnixFileDescriptor in DMABufObject, DMABufReleaseFlag +https://bugs.webkit.org/show_bug.cgi?id=238733 + +Reviewed by Adrian Perez de Castro. + +Replace integer values for file descriptors in the DMABufObject and +DMABufReleaseFlag structs with UnixFileDescriptors. This enables +simply defaulting the destructors and the move constructors and +assignment operatos for the two types since the fd wrapper takes care +of these operations. + +Additionally, when constructing the UnixFileDescriptor objects from +file descriptors coming from different sources, we can more easily +adapt to the need for either adoption or duplication of the passed-in +file descriptor right there in the constructor invocation. + +* platform/graphics/gbm/DMABufObject.h: +(WebCore::DMABufObject::~DMABufObject): Deleted. +(WebCore::DMABufObject::operator=): Deleted. +* platform/graphics/gbm/DMABufReleaseFlag.h: +(WebCore::DMABufReleaseFlag::DMABufReleaseFlag): +(WebCore::DMABufReleaseFlag::dup const): +(WebCore::DMABufReleaseFlag::released const): +(WebCore::DMABufReleaseFlag::release): +(WebCore::DMABufReleaseFlag::~DMABufReleaseFlag): Deleted. +(WebCore::DMABufReleaseFlag::operator=): Deleted. +* platform/graphics/gbm/GBMBufferSwapchain.cpp: +(WebCore::GBMBufferSwapchain::Buffer::createDMABufObject const): +* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: +(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): +* platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: +(WebCore::GraphicsContextGLANGLE::makeContextCurrent): +* platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp: +(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::createEGLImageData): + 2022-04-04 Ziran Sun [Forms] change the default appearance of button, checkbox etc. to 'auto' Modified: trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h (292376 => 292377) --- trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h 2022-04-05 05:38:59 UTC (rev 292376) +++ trunk/Source/WebCore/platform/graphics/gbm/DMABufObject.h 2022-04-05 06:54:36 UTC (rev 292377) @@ -32,6 +32,7 @@ #include #include
