[webkit-changes] [216652] trunk/Source/WebKit2

[timothy_horton]

Title: [216652] trunk/Source/WebKit2








Revision 216652
Author timothy_hor...@apple.com
Date 2017-05-10 21:53:15 -0700 (Wed, 10 May 2017)


Log Message
Null deref in WebPage::dictionaryPopupInfoForRange
https://bugs.webkit.org/show_bug.cgi?id=171959


Reviewed by Beth Dakin.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::dictionaryPopupInfoForRange):
Speculative fix for non-reproducible crash when the startContainer of
the range is in an anonymous node.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216651 => 216652)

--- trunk/Source/WebKit2/ChangeLog	2017-05-11 04:23:26 UTC (rev 216651)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-11 04:53:15 UTC (rev 216652)
@@ -1,3 +1,16 @@
+2017-05-10  Tim Horton  
+
+Null deref in WebPage::dictionaryPopupInfoForRange
+https://bugs.webkit.org/show_bug.cgi?id=171959
+
+
+Reviewed by Beth Dakin.
+
+* WebProcess/WebPage/mac/WebPageMac.mm:
+(WebKit::WebPage::dictionaryPopupInfoForRange):
+Speculative fix for non-reproducible crash when the startContainer of
+the range is in an anonymous node.
+
 2017-05-09  Sam Weinig  
 
 Remove support for legacy Notifications


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (216651 => 216652)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm	2017-05-11 04:23:26 UTC (rev 216651)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm	2017-05-11 04:53:15 UTC (rev 216652)
@@ -74,6 +74,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -434,9 +435,6 @@
 editor.setIsGettingDictionaryPopupInfo(false);
 return dictionaryPopupInfo;
 }
-
-RenderObject* renderer = range.startContainer().renderer();
-const RenderStyle& style = renderer->style();
 
 Vector quads;
 range.absoluteTextQuads(quads);
@@ -447,7 +445,9 @@
 
 IntRect rangeRect = frame->view()->contentsToWindow(quads[0].enclosingBoundingBox());
 
-dictionaryPopupInfo.origin = FloatPoint(rangeRect.x(), rangeRect.y() + (style.fontMetrics().ascent() * pageScaleFactor()));
+const RenderStyle* style = range.startContainer().renderStyle();
+float scaledAscent = style ? style->fontMetrics().ascent() * pageScaleFactor() : 0;
+dictionaryPopupInfo.origin = FloatPoint(rangeRect.x(), rangeRect.y() + scaledAscent);
 dictionaryPopupInfo.options = *options;
 
 NSAttributedString *nsAttributedString = editingAttributedStringFromRange(range, IncludeImagesInAttributedString::No);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216650] trunk/Source/WebCore

[eric . carlson]

Title: [216650] trunk/Source/WebCore








Revision 216650
Author eric.carl...@apple.com
Date 2017-05-10 21:22:08 -0700 (Wed, 10 May 2017)


Log Message
[MediaStream] CoreAudioCaptureSource claims to never be muted
https://bugs.webkit.org/show_bug.cgi?id=171946


Reviewed by Jer Noble.

* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::stopProducingData): Set m_muted to true.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216649 => 216650)

--- trunk/Source/WebCore/ChangeLog	2017-05-11 04:06:02 UTC (rev 216649)
+++ trunk/Source/WebCore/ChangeLog	2017-05-11 04:22:08 UTC (rev 216650)
@@ -1,3 +1,14 @@
+2017-05-10  Eric Carlson  
+
+[MediaStream] CoreAudioCaptureSource claims to never be muted
+https://bugs.webkit.org/show_bug.cgi?id=171946
+
+
+Reviewed by Jer Noble.
+
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioCaptureSource::stopProducingData): Set m_muted to true.
+
 2017-05-10  Jer Noble  
 
 RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()


Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (216649 => 216650)

--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2017-05-11 04:06:02 UTC (rev 216649)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2017-05-11 04:22:08 UTC (rev 216650)
@@ -710,7 +710,7 @@
 
 CoreAudioSharedUnit::singleton().stopProducingData();
 m_isProducingData = false;
-m_muted = false;
+m_muted = true;
 
 if (m_audioSourceProvider)
 m_audioSourceProvider->unprepare();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216651] trunk/Websites/perf.webkit.org

[rniwa]

Title: [216651] trunk/Websites/perf.webkit.org








Revision 216651
Author rn...@webkit.org
Date 2017-05-10 21:23:26 -0700 (Wed, 10 May 2017)


Log Message
Another build fix after r215633 to make the bar graphs render even when the confidence intervals aren't available.

* public/v3/components/bar-graph-group.js:
(BarGraphGroup.prototype._computeRange):

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/components/bar-graph-group.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (216650 => 216651)

--- trunk/Websites/perf.webkit.org/ChangeLog	2017-05-11 04:22:08 UTC (rev 216650)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2017-05-11 04:23:26 UTC (rev 216651)
@@ -1,5 +1,12 @@
 2017-05-10  Ryosuke Niwa  
 
+Another build fix after r215633 to make the bar graphs render even when the confidence intervals aren't available.
+
+* public/v3/components/bar-graph-group.js:
+(BarGraphGroup.prototype._computeRange):
+
+2017-05-10  Ryosuke Niwa  
+
 Build fix after r215633.
 
 * public/v3/models/test-group.js:


Modified: trunk/Websites/perf.webkit.org/public/v3/components/bar-graph-group.js (216650 => 216651)

--- trunk/Websites/perf.webkit.org/public/v3/components/bar-graph-group.js	2017-05-11 04:22:08 UTC (rev 216650)
+++ trunk/Websites/perf.webkit.org/public/v3/components/bar-graph-group.js	2017-05-11 04:23:26 UTC (rev 216651)
@@ -42,6 +42,8 @@
 }
 if (entry.interval) {
 for (const value of entry.interval) {
+if (isNaN(value))
+continue;
 min = Math.min(min, value);
 max = Math.max(max, value);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216649] trunk/Websites/perf.webkit.org

[rniwa]

Title: [216649] trunk/Websites/perf.webkit.org








Revision 216649
Author rn...@webkit.org
Date 2017-05-10 21:06:02 -0700 (Wed, 10 May 2017)


Log Message
Build fix after r215633.

* public/v3/models/test-group.js:
(TestGroup.prototype._computeRequestedCommitSets):
(TestGroup.prototype.requestsForCommitSet):

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/models/test-group.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (216648 => 216649)

--- trunk/Websites/perf.webkit.org/ChangeLog	2017-05-11 02:58:25 UTC (rev 216648)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2017-05-11 04:06:02 UTC (rev 216649)
@@ -1,5 +1,13 @@
 2017-05-10  Ryosuke Niwa  
 
+Build fix after r215633.
+
+* public/v3/models/test-group.js:
+(TestGroup.prototype._computeRequestedCommitSets):
+(TestGroup.prototype.requestsForCommitSet):
+
+2017-05-10  Ryosuke Niwa  
+
 Add API to upload a patched build for a custom A/B testing
 https://bugs.webkit.org/show_bug.cgi?id=171956
 


Modified: trunk/Websites/perf.webkit.org/public/v3/models/test-group.js (216648 => 216649)

--- trunk/Websites/perf.webkit.org/public/v3/models/test-group.js	2017-05-11 02:58:25 UTC (rev 216648)
+++ trunk/Websites/perf.webkit.org/public/v3/models/test-group.js	2017-05-11 04:06:02 UTC (rev 216649)
@@ -90,8 +90,8 @@
 const commitSetLabelMap = new Map;
 for (const request of orderedBuildRequests) {
 const set = request.commitSet();
-if (!this._requestedCommitSets.includes(set))
-this._requestedCommitSets.push(set);
+if (!requestedCommitSets.includes(set))
+requestedCommitSets.push(set);
 }
 return requestedCommitSets;
 }
@@ -98,7 +98,7 @@
 
 requestsForCommitSet(commitSet)
 {
-this._orderedBuildRequests().filter((request) => request.commitSet() == commitSet);
+return this._orderedBuildRequests().filter((request) => request.commitSet() == commitSet);
 }
 
 labelForCommitSet(commitSet)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216648] tags/Safari-603.3.1/

[matthew_hanson]

Title: [216648] tags/Safari-603.3.1/








Revision 216648
Author matthew_han...@apple.com
Date 2017-05-10 19:58:25 -0700 (Wed, 10 May 2017)


Log Message
Tag Safari-603.3.1.

Added Paths

tags/Safari-603.3.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216647] trunk/Websites/perf.webkit.org

[rniwa]

Title: [216647] trunk/Websites/perf.webkit.org








Revision 216647
Author rn...@webkit.org
Date 2017-05-10 19:32:00 -0700 (Wed, 10 May 2017)


Log Message
Add API to upload a patched build for a custom A/B testing
https://bugs.webkit.org/show_bug.cgi?id=171956

Reviewed by Chris Dumez.

Added /api/upload-root to upload a root file, the build product of a patch associated with a commit set.

Extracted more functions out of privileged-api/upload-file.php to uploaded-file-helpers.php to share code
with /api/upload-root.php.

* public/api/upload-root.php: Added.
(main):
(compute_commit_set_items_to_update): Find the list of commit set items to associate this root with.
A root can be associated with multiple repositories and there fore commit set items; e.g. if a software
is built from multiple repositories and there is a patch associated with one of them, the built product
must be associated with all those repositories.

* public/include/build-requests-fetcher.php:
(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Include the root file is there is one.

* public/include/json-header.php:
(validate_arguments): Added the support for validating json string.
(verify_slave): Return the slave ID found.

* public/include/uploaded-file-helpers.php:
(validate_uploaded_file): Extracted from /privileged-api/upload-file to be shared with /api/upload-root.
(query_total_file_size): Ditto.
(create_uploaded_file_from_form_data): Ditto.
(upload_file_in_transaction): Ditto. Takes a lambda to do the extra work inside the transaction.

* public/privileged-api/upload-file.php:
(main):

* public/v3/models/build-request.js:
(BuildRequest.constructBuildRequestsFromData): Resolve the rootFIle of each commit set item.

* public/v3/models/commit-set.js:
(CommitSet): Added _repositoryToRootMap and _allRootFiles as instance variables.
(CommitSet.prototype.updateSingleton): Added. Previously, each commit set's states never changed after
its creation. After this patch, each item can be newly associated with a root so we must update its
_repositoryToRootMap and _allRootFiles. For simplicity, we update all states.
(CommitSet.prototype._updateFromObject): Extracted from the constructor.
(CommitSet.prototype.allRootFiles): Added. Includes custom roots and roots created for patches.
(CommitSet.prototype.rootForRepository): Added.
(CommitSet.prototype.equals): Fixed the bug that we were comparing _repositoryToPatchMap to
_repositoryToCommitMap, and added a check for _repositoryToRootMap.

* public/v3/models/test-group.js:
(TestGroup.prototype.task): Added.
(TestGroup.createWithTask):
(TestGroup.createWithCustomConfiguration):
(TestGroup.createAndRefetchTestGroups):
(TestGroup._fetchTestGroupsForTask): Deleted. Now fetchForTask takes a boolean argument: ignoreCache.
(TestGroup.findAllByTask): Added.
(TestGroup.fetchForTask): Renamed from fetchByTask.

* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._fetchRelatedInfoForTaskId):

* server-tests/api-build-requests-tests.js:

* server-tests/api-upload-root-tests.js: Added. Added tests for /api/upload-root.
(makeReport): Added.
(addSlaveAndCreateRootFile): Added.
(createTestGroupWihPatch): Added.

* server-tests/privileged-api-create-test-group-tests.js:

* server-tests/resources/mock-data.js:
(MockData.sharedRepositoryId): Added.
(MockData.addMockData): Added "Shared" repository along with commits.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php
trunk/Websites/perf.webkit.org/public/include/json-header.php
trunk/Websites/perf.webkit.org/public/include/uploaded-file-helpers.php
trunk/Websites/perf.webkit.org/public/privileged-api/upload-file.php
trunk/Websites/perf.webkit.org/public/v3/models/build-request.js
trunk/Websites/perf.webkit.org/public/v3/models/commit-set.js
trunk/Websites/perf.webkit.org/public/v3/models/test-group.js
trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js
trunk/Websites/perf.webkit.org/server-tests/api-build-requests-tests.js
trunk/Websites/perf.webkit.org/server-tests/privileged-api-create-test-group-tests.js
trunk/Websites/perf.webkit.org/server-tests/resources/mock-data.js


Added Paths

trunk/Websites/perf.webkit.org/public/api/upload-root.php
trunk/Websites/perf.webkit.org/server-tests/api-upload-root-tests.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (216646 => 216647)

--- trunk/Websites/perf.webkit.org/ChangeLog	2017-05-11 02:26:29 UTC (rev 216646)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2017-05-11 02:32:00 UTC (rev 216647)
@@ -1,5 +1,79 @@
 2017-05-10  Ryosuke Niwa  
 
+Add API to upload a patched build for a custom A/B testing
+https://bugs.webkit.org/show_bug.cgi?id=171956
+
+Reviewed by Chris Dumez.
+
+Added /api/upload-root to upload a root file, the build product of a patch associated with a commit set.
+
+Extracted more functions out of 

[webkit-changes] [216646] trunk/Websites/perf.webkit.org

[rniwa]

Title: [216646] trunk/Websites/perf.webkit.org








Revision 216646
Author rn...@webkit.org
Date 2017-05-10 19:26:29 -0700 (Wed, 10 May 2017)


Log Message
Rename server-tests/api-update-triggerable.js to server-tests/api-update-triggerable-tests.js
https://bugs.webkit.org/show_bug.cgi?id=171905

Reviewed by Chris Dumez.

* server-tests/api-update-triggerable-tests.js: Renamed from server-tests/api-update-triggerable.js.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog


Added Paths

trunk/Websites/perf.webkit.org/server-tests/api-update-triggerable-tests.js


Removed Paths

trunk/Websites/perf.webkit.org/server-tests/api-update-triggerable.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (216645 => 216646)

--- trunk/Websites/perf.webkit.org/ChangeLog	2017-05-11 01:51:36 UTC (rev 216645)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2017-05-11 02:26:29 UTC (rev 216646)
@@ -1,3 +1,12 @@
+2017-05-10  Ryosuke Niwa  
+
+Rename server-tests/api-update-triggerable.js to server-tests/api-update-triggerable-tests.js
+https://bugs.webkit.org/show_bug.cgi?id=171905
+
+Reviewed by Chris Dumez.
+
+* server-tests/api-update-triggerable-tests.js: Renamed from server-tests/api-update-triggerable.js.
+
 2017-04-30  Ryosuke Niwa  
 
 Add the support for scheduling a A/B testing with a patch.


Added: trunk/Websites/perf.webkit.org/server-tests/api-update-triggerable-tests.js (0 => 216646)

--- trunk/Websites/perf.webkit.org/server-tests/api-update-triggerable-tests.js	(rev 0)
+++ trunk/Websites/perf.webkit.org/server-tests/api-update-triggerable-tests.js	2017-05-11 02:26:29 UTC (rev 216646)
@@ -0,0 +1,474 @@
+'use strict';
+
+const assert = require('assert');
+
+require('../tools/js/v3-models.js');
+
+const TestServer = require('./resources/test-server.js');
+const MockData = require('./resources/mock-data.js');
+const addSlaveForReport = require('./resources/common-operations.js').addSlaveForReport;
+const prepareServerTest = require('./resources/common-operations.js').prepareServerTest;
+
+describe('/api/update-triggerable/', function () {
+prepareServerTest(this);
+
+const emptyUpdate = {
+'slaveName': 'someSlave',
+'slavePassword': 'somePassword',
+'triggerable': 'build-webkit',
+'configurations': [],
+};
+
+const smallUpdate = {
+'slaveName': 'someSlave',
+'slavePassword': 'somePassword',
+'triggerable': 'build-webkit',
+'configurations': [
+{test: MockData.someTestId(), platform: MockData.somePlatformId()}
+],
+};
+
+it('should reject when slave name is missing', () => {
+return TestServer.remoteAPI().postJSON('/api/update-triggerable/', {}).then((response) => {
+assert.equal(response['status'], 'MissingSlaveName');
+});
+});
+
+it('should reject when there are no slaves', () => {
+const update = {slaveName: emptyUpdate.slaveName, slavePassword: emptyUpdate.slavePassword};
+return TestServer.remoteAPI().postJSON('/api/update-triggerable/', update).then((response) => {
+assert.equal(response['status'], 'SlaveNotFound');
+});
+});
+
+it('should reject when the slave password doesn\'t match', () => {
+return MockData.addMockData(TestServer.database()).then(() => {
+return addSlaveForReport(emptyUpdate);
+}).then(() => {
+const report = {slaveName: emptyUpdate.slaveName, slavePassword: 'badPassword'};
+return TestServer.remoteAPI().postJSON('/api/update-triggerable/', emptyUpdate);
+}).then((response) => {
+assert.equal(response['status'], 'OK');
+});
+});
+
+it('should accept an empty report', () => {
+return MockData.addMockData(TestServer.database()).then(() => {
+return addSlaveForReport(emptyUpdate);
+}).then(() => {
+return TestServer.remoteAPI().postJSON('/api/update-triggerable/', emptyUpdate);
+}).then((response) => {
+assert.equal(response['status'], 'OK');
+});
+});
+
+it('delete existing configurations when accepting an empty report', () => {
+const db = TestServer.database();
+return MockData.addMockData(db).then(() => {
+return Promise.all([
+addSlaveForReport(emptyUpdate),
+db.insert('triggerable_configurations', {'triggerable': 1000 // build-webkit
+, 'test': MockData.someTestId(), 'platform': MockData.somePlatformId()})
+]);
+}).then(() => {
+return TestServer.remoteAPI().postJSON('/api/update-triggerable/', emptyUpdate);
+}).then((response) => {
+assert.equal(response['status'], 'OK');
+return db.selectAll('triggerable_configurations', 'test');
+}).then((rows) => {
+

[webkit-changes] [216645] trunk/Source/WebCore

[jer . noble]

Title: [216645] trunk/Source/WebCore








Revision 216645
Author jer.no...@apple.com
Date 2017-05-10 18:51:36 -0700 (Wed, 10 May 2017)


Log Message
RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
https://bugs.webkit.org/show_bug.cgi?id=171711

Reviewed by Youenn Fablet.

Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
we don't walk over the end of either by only iterating over the minimum length of either.
Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
MediaStreamAudioSourceNode that the number of channels and sample rate have changed.

* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216644 => 216645)

--- trunk/Source/WebCore/ChangeLog	2017-05-11 00:56:00 UTC (rev 216644)
+++ trunk/Source/WebCore/ChangeLog	2017-05-11 01:51:36 UTC (rev 216645)
@@ -1,3 +1,19 @@
+2017-05-10  Jer Noble  
+
+RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
+https://bugs.webkit.org/show_bug.cgi?id=171711
+
+Reviewed by Youenn Fablet.
+
+Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
+we don't walk over the end of either by only iterating over the minimum length of either.
+Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
+MediaStreamAudioSourceNode that the number of channels and sample rate have changed.
+
+* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
+(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
+(WebCore::WebAudioSourceProviderAVFObjC::prepare):
+
 2017-05-10  Andy Estes  
 
 REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html


Modified: trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm (216644 => 216645)

--- trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm	2017-05-11 00:56:00 UTC (rev 216644)
+++ trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm	2017-05-11 01:51:36 UTC (rev 216645)
@@ -80,8 +80,12 @@
 }
 
 WebAudioBufferList list { *m_outputDescription };
-for (unsigned i = 0; i < list.bufferCount(); ++i) {
+for (unsigned i = 0; i < bus->numberOfChannels(); ++i) {
 AudioChannel& channel = *bus->channel(i);
+if (i >= list.bufferCount()) {
+channel.zero();
+continue;
+}
 auto* buffer = list.buffer(i);
 buffer->mNumberChannels = 1;
 buffer->mData = channel.mutableData();
@@ -137,8 +141,7 @@
 m_dataSource->setInputFormat(*m_inputDescription);
 m_dataSource->setOutputFormat(*m_outputDescription);
 
-RefPtr protectedThis = this;
-callOnMainThread([protectedThis = WTFMove(protectedThis), numberOfChannels, sampleRate] {
+callOnMainThread([protectedThis = makeRef(*this), numberOfChannels, sampleRate] {
 if (protectedThis->m_client)
 protectedThis->m_client->setFormat(numberOfChannels, sampleRate);
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216644] trunk/LayoutTests

[jlewis3]

Title: [216644] trunk/LayoutTests








Revision 216644
Author jlew...@apple.com
Date 2017-05-10 17:56:00 -0700 (Wed, 10 May 2017)


Log Message
Marked fast/animation/request-animation-frame-time-unit.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171957

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216643 => 216644)

--- trunk/LayoutTests/ChangeLog	2017-05-11 00:33:33 UTC (rev 216643)
+++ trunk/LayoutTests/ChangeLog	2017-05-11 00:56:00 UTC (rev 216644)
@@ -1,3 +1,12 @@
+2017-05-10  Matt Lewis  
+
+Marked fast/animation/request-animation-frame-time-unit.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171957
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2017-05-10  Andy Estes  
 
 REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216643 => 216644)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-11 00:33:33 UTC (rev 216643)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-11 00:56:00 UTC (rev 216644)
@@ -1982,3 +1982,5 @@
 webkit.org/b/171945 [ Debug ] perf/class-list-remove.html [ Pass Failure Timeout ]
 
 webkit.org/b/171951 [ Debug ] fast/hidpi/filters-and-image-buffer-resolution.html [ Pass ImageOnlyFailure ]
+
+webkit.org/b/171957 [ Debug ] fast/animation/request-animation-frame-time-unit.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216642] trunk/Source/WebCore

[ryanhaddad]

Title: [216642] trunk/Source/WebCore








Revision 216642
Author ryanhad...@apple.com
Date 2017-05-10 17:32:56 -0700 (Wed, 10 May 2017)


Log Message
Unreviewed, rolling out r216630.

This change caused assertion failures with webrtc LayoutTests.

Reverted changeset:

"RELEASE_ASSERT at
WebAudioSourceProviderAVFObjC::provideInput()"
https://bugs.webkit.org/show_bug.cgi?id=171711
http://trac.webkit.org/changeset/216630

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216641 => 216642)

--- trunk/Source/WebCore/ChangeLog	2017-05-11 00:29:37 UTC (rev 216641)
+++ trunk/Source/WebCore/ChangeLog	2017-05-11 00:32:56 UTC (rev 216642)
@@ -1,3 +1,16 @@
+2017-05-10  Ryan Haddad  
+
+Unreviewed, rolling out r216630.
+
+This change caused assertion failures with webrtc LayoutTests.
+
+Reverted changeset:
+
+"RELEASE_ASSERT at
+WebAudioSourceProviderAVFObjC::provideInput()"
+https://bugs.webkit.org/show_bug.cgi?id=171711
+http://trac.webkit.org/changeset/216630
+
 2017-05-09  Sam Weinig  
 
 Remove support for legacy Notifications


Modified: trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm (216641 => 216642)

--- trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm	2017-05-11 00:29:37 UTC (rev 216641)
+++ trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm	2017-05-11 00:32:56 UTC (rev 216642)
@@ -80,9 +80,7 @@
 }
 
 WebAudioBufferList list { *m_outputDescription };
-ASSERT(list.bufferCount() == bus->numberOfChannels());
-unsigned channelCount = std::min(list.bufferCount(), bus->numberOfChannels());
-for (unsigned i = 0; i < channelCount; ++i) {
+for (unsigned i = 0; i < list.bufferCount(); ++i) {
 AudioChannel& channel = *bus->channel(i);
 auto* buffer = list.buffer(i);
 buffer->mNumberChannels = 1;
@@ -139,8 +137,11 @@
 m_dataSource->setInputFormat(*m_inputDescription);
 m_dataSource->setOutputFormat(*m_outputDescription);
 
-if (m_client)
-m_client->setFormat(numberOfChannels, sampleRate);
+RefPtr protectedThis = this;
+callOnMainThread([protectedThis = WTFMove(protectedThis), numberOfChannels, sampleRate] {
+if (protectedThis->m_client)
+protectedThis->m_client->setFormat(numberOfChannels, sampleRate);
+});
 }
 
 void WebAudioSourceProviderAVFObjC::unprepare()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216643] trunk

[aestes]

Title: [216643] trunk








Revision 216643
Author aes...@apple.com
Date 2017-05-10 17:33:33 -0700 (Wed, 10 May 2017)


Log Message
REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html
https://bugs.webkit.org/show_bug.cgi?id=132297

Reviewed by Simon Fraser.

Source/WebCore:

We don't know why m_renderView needs layout in this case, but we know that we don't need to
assert if the client hasn't set the ScrollableInnerFrameTrigger compositing trigger.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):

LayoutTests:

* http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
* http/tests/navigation/resources/keyboard-events-test.js:
(runTest):
* platform/ios-wk2/TestExpectations:
* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt
trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt
trunk/LayoutTests/http/tests/navigation/resources/keyboard-events-test.js
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (216642 => 216643)

--- trunk/LayoutTests/ChangeLog	2017-05-11 00:32:56 UTC (rev 216642)
+++ trunk/LayoutTests/ChangeLog	2017-05-11 00:33:33 UTC (rev 216643)
@@ -1,3 +1,17 @@
+2017-05-10  Andy Estes  
+
+REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html
+https://bugs.webkit.org/show_bug.cgi?id=132297
+
+Reviewed by Simon Fraser.
+
+* http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
+* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
+* http/tests/navigation/resources/keyboard-events-test.js:
+(runTest):
+* platform/ios-wk2/TestExpectations:
+* platform/wk2/TestExpectations:
+
 2017-05-09  Sam Weinig  
 
 Remove support for legacy Notifications


Modified: trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt (216642 => 216643)

--- trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt	2017-05-11 00:32:56 UTC (rev 216642)
+++ trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt	2017-05-11 00:33:33 UTC (rev 216643)
@@ -5,9 +5,9 @@
 CONSOLE MESSAGE: line 28: Pressing tab.
 CONSOLE MESSAGE: line 30: Active element after pressing tab: [object HTMLInputElement].
 CONSOLE MESSAGE: line 32: Pressing "a".
-CONSOLE MESSAGE: line 42: Setting marked text to "b".
-CONSOLE MESSAGE: line 45: Inserting text "c".
-CONSOLE MESSAGE: line 48: Input element value after text input events: "".
+CONSOLE MESSAGE: line 35: Setting marked text to "b".
+CONSOLE MESSAGE: line 38: Inserting text "c".
+CONSOLE MESSAGE: line 41: Input element value after text input events: "".
 CONSOLE MESSAGE: line 18: Pressing "z" with access key modifiers should navigate to resources/keyboard-events-after-navigation.html.
 CONSOLE MESSAGE: line 6: Finished navigating to resources/keyboard-events-after-navigation.html.
 CONSOLE MESSAGE: line 7: Trusted events should be logged and the input element should have the value "ac".
@@ -24,12 +24,12 @@
 CONSOLE MESSAGE: line 5: beforeinputevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: inputevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: keyupevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 42: Setting marked text to "b".
+CONSOLE MESSAGE: line 35: Setting marked text to "b".
 CONSOLE MESSAGE: line 5: compositionstartevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: compositionupdateevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: beforeinputevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: inputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 45: Inserting text "c".
+CONSOLE MESSAGE: line 38: Inserting text "c".
 CONSOLE MESSAGE: line 5: beforeinputevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: inputevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: textInputevent dispatched (isTrusted: true).
@@ -36,5 +36,5 @@
 CONSOLE MESSAGE: line 5: beforeinputevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: inputevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 5: compositionendevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 48: Input element value after text input events: "ac".
+CONSOLE MESSAGE: line 41: Input element value after text input events: "ac".
 

[webkit-changes] [216640] trunk/LayoutTests

[ryanhaddad]

Title: [216640] trunk/LayoutTests








Revision 216640
Author ryanhad...@apple.com
Date 2017-05-10 17:25:48 -0700 (Wed, 10 May 2017)


Log Message
Mark media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169876

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216639 => 216640)

--- trunk/LayoutTests/ChangeLog	2017-05-11 00:20:40 UTC (rev 216639)
+++ trunk/LayoutTests/ChangeLog	2017-05-11 00:25:48 UTC (rev 216640)
@@ -1,5 +1,14 @@
 2017-05-10  Ryan Haddad  
 
+Mark media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=169876
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2017-05-10  Ryan Haddad  
+
 Mark inspector/protocol/inspector-backend-invocation-return-value.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=168146
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (216639 => 216640)

--- trunk/LayoutTests/platform/mac/TestExpectations	2017-05-11 00:20:40 UTC (rev 216639)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-05-11 00:25:48 UTC (rev 216640)
@@ -1594,3 +1594,5 @@
 webkit.org/b/171760 imported/w3c/i18n/bidi/bidi-plaintext-011.html [ ImageOnlyFailure ]
 
 webkit.org/b/171886 imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html [ Pass Failure ]
+
+webkit.org/b/169876 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216639] trunk/LayoutTests

[ryanhaddad]

Title: [216639] trunk/LayoutTests








Revision 216639
Author ryanhad...@apple.com
Date 2017-05-10 17:20:40 -0700 (Wed, 10 May 2017)


Log Message
Mark inspector/protocol/inspector-backend-invocation-return-value.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168146

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216638 => 216639)

--- trunk/LayoutTests/ChangeLog	2017-05-10 23:48:33 UTC (rev 216638)
+++ trunk/LayoutTests/ChangeLog	2017-05-11 00:20:40 UTC (rev 216639)
@@ -1,3 +1,12 @@
+2017-05-10  Ryan Haddad  
+
+Mark inspector/protocol/inspector-backend-invocation-return-value.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=168146
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2017-05-10  Commit Queue  
 
 Unreviewed, rolling out r216635.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (216638 => 216639)

--- trunk/LayoutTests/platform/mac/TestExpectations	2017-05-10 23:48:33 UTC (rev 216638)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-05-11 00:20:40 UTC (rev 216639)
@@ -1195,6 +1195,7 @@
 webkit.org/b/148636 inspector/model/remote-object.html [ Pass Timeout ]
 webkit.org/b/167265 inspector/network/client-blocked-load.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/page/main-frame-resource.html [ Pass Timeout ]
+webkit.org/b/168146 [ Debug ] inspector/protocol/inspector-backend-invocation-return-value.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/model/remote-object-weak-collection.html [ Pass Timeout Failure ]
 webkit.org/b/153108 [ Debug ] inspector/model/scope-chain-node.html [ Pass Timeout ]
 webkit.org/b/164278 inspector/storage/domStorage-events.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216638] trunk

[mark . lam]

Title: [216638] trunk








Revision 216638
Author mark@apple.com
Date 2017-05-10 16:48:33 -0700 (Wed, 10 May 2017)


Log Message
Unreviewed, rolling out r216635.
https://bugs.webkit.org/show_bug.cgi?id=171953

"Some worker tests are failing". (Requested by mlam on #webkit).

Reverted changeset:

"WorkerThread::stop() should call
scheduleExecutionTermination() last."
https://bugs.webkit.org/show_bug.cgi?id=171775
http://trac.webkit.org/changeset/216635

Patch by Commit Queue  on 2017-05-10

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ExceptionScope.cpp
trunk/Source/_javascript_Core/runtime/ExceptionScope.h
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp
trunk/Source/WebCore/workers/WorkerThread.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (216637 => 216638)

--- trunk/LayoutTests/ChangeLog	2017-05-10 23:43:44 UTC (rev 216637)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 23:48:33 UTC (rev 216638)
@@ -1,3 +1,17 @@
+2017-05-10  Commit Queue  
+
+Unreviewed, rolling out r216635.
+https://bugs.webkit.org/show_bug.cgi?id=171953
+
+"Some worker tests are failing". (Requested by mlam on #webkit).
+
+Reverted changeset:
+
+"WorkerThread::stop() should call
+scheduleExecutionTermination() last."
+https://bugs.webkit.org/show_bug.cgi?id=171775
+http://trac.webkit.org/changeset/216635
+
 2017-05-10  Mark Lam  
 
 WorkerThread::stop() should call scheduleExecutionTermination() last.


Modified: trunk/LayoutTests/TestExpectations (216637 => 216638)

--- trunk/LayoutTests/TestExpectations	2017-05-10 23:43:44 UTC (rev 216637)
+++ trunk/LayoutTests/TestExpectations	2017-05-10 23:48:33 UTC (rev 216638)
@@ -365,6 +365,9 @@
 
 webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ]
 
+# rdar://problem/30975761
+[ Debug ] http/tests/fetch/fetch-in-worker-crash.html [ Skip ]
+
 imported/w3c/web-platform-tests/XMLHttpRequest/send-conditional-cors.htm [ Failure ]
 imported/w3c/web-platform-tests/fetch/http-cache/partial.html [ Failure ]
 webkit.org/b/159724 imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm [ Failure Pass ]


Modified: trunk/Source/_javascript_Core/ChangeLog (216637 => 216638)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-10 23:43:44 UTC (rev 216637)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-10 23:48:33 UTC (rev 216638)
@@ -1,3 +1,17 @@
+2017-05-10  Commit Queue  
+
+Unreviewed, rolling out r216635.
+https://bugs.webkit.org/show_bug.cgi?id=171953
+
+"Some worker tests are failing". (Requested by mlam on #webkit).
+
+Reverted changeset:
+
+"WorkerThread::stop() should call
+scheduleExecutionTermination() last."
+https://bugs.webkit.org/show_bug.cgi?id=171775
+http://trac.webkit.org/changeset/216635
+
 2017-05-10  Mark Lam  
 
 Crash in _javascript_Core GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).


Modified: trunk/Source/_javascript_Core/runtime/ExceptionScope.cpp (216637 => 216638)

--- trunk/Source/_javascript_Core/runtime/ExceptionScope.cpp	2017-05-10 23:43:44 UTC (rev 216637)
+++ trunk/Source/_javascript_Core/runtime/ExceptionScope.cpp	2017-05-10 23:48:33 UTC (rev 216638)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2016-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -27,10 +27,8 @@
 #include "ExceptionScope.h"
 
 #include "Exception.h"
-#include "ExceptionHelpers.h"
 #include 
 #include 
-#include 
 
 namespace JSC {
 
@@ -55,14 +53,14 @@
 {
 StringPrintStream out;
 
-out.println("Unexpected exception observed on thread ", currentThread(), " at:");
-auto currentStack = std::unique_ptr(StackTrace::captureStackTrace(100, 1));
+out.println("Unexpected exception observed at:");
+auto currentStack = std::unique_ptr(StackTrace::captureStackTrace(25, 1));
 currentStack->dump(out, "");
 
 if (!m_vm.nativeStackTraceOfLastThrow())
 return CString();
 
-out.println("The exception was thrown from thread ", m_vm.throwingThread(), " at:");
+out.println("The exception was thrown from:");
 m_vm.nativeStackTraceOfLastThrow()->dump(out, "");
 
 return out.toCString();
@@ -70,9 +68,4 @@
 
 #endif // ENABLE(EXCEPTION_SCOPE_VERIFICATION)
 
-void 

[webkit-changes] [216637] trunk/Source/JavaScriptCore

[mark . lam]

Title: [216637] trunk/Source/_javascript_Core








Revision 216637
Author mark@apple.com
Date 2017-05-10 16:43:44 -0700 (Wed, 10 May 2017)


Log Message
Crash in _javascript_Core GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
https://bugs.webkit.org/show_bug.cgi?id=160337


Not reviewed.

Updated a comment per Geoff's suggestion.

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::tryCopyOtherThreadStack):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216636 => 216637)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-10 23:39:48 UTC (rev 216636)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-10 23:43:44 UTC (rev 216637)
@@ -1,5 +1,18 @@
 2017-05-10  Mark Lam  
 
+Crash in _javascript_Core GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
+https://bugs.webkit.org/show_bug.cgi?id=160337
+
+
+Not reviewed.
+
+Updated a comment per Geoff's suggestion.
+
+* heap/MachineStackMarker.cpp:
+(JSC::MachineThreads::tryCopyOtherThreadStack):
+
+2017-05-10  Mark Lam  
+
 WorkerThread::stop() should call scheduleExecutionTermination() last.
 https://bugs.webkit.org/show_bug.cgi?id=171775
 


Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (216636 => 216637)

--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp	2017-05-10 23:39:48 UTC (rev 216636)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp	2017-05-10 23:43:44 UTC (rev 216637)
@@ -312,17 +312,9 @@
 MachineThread::Registers registers;
 size_t registersSize = thread->getRegisters(registers);
 
-// This is a workaround for . During thread initialization,
-// for some target platforms, thread state is momentarily set to 0 before being
-// filled in with the target thread's real register values. As a result, there's
-// a race condition that may result in us getting a null stackPointer.
-// This issue may manifest with workqueue threads where the OS may choose to recycle
-// a thread for an expired task.
-//
-// The workaround is simply to indicate that there's nothing to copy and return.
-// This is correct because we will only ever observe a null pointer during thread
-// initialization. Hence, by definition, there's nothing there that we need to scan
-// yet, and therefore, nothing that needs to be copied.
+// This is a workaround for . libdispatch recycles work
+// queue threads without running pthread exit destructors. This can cause us to scan a
+// thread during work queue initialization, when the stack pointer is null.
 if (UNLIKELY(!registers.stackPointer())) {
 *size = 0;
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216636] branches/safari-603-branch/Source

[matthew_hanson]

Title: [216636] branches/safari-603-branch/Source








Revision 216636
Author matthew_han...@apple.com
Date 2017-05-10 16:39:48 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r214320. rdar://problem/32057095

Modified Paths

branches/safari-603-branch/Source/WebCore/page/DiagnosticLoggingKeys.cpp
branches/safari-603-branch/Source/WebCore/page/DiagnosticLoggingKeys.h
branches/safari-603-branch/Source/WebCore/page/MemoryRelease.cpp
branches/safari-603-branch/Source/WebCore/page/MemoryRelease.h
branches/safari-603-branch/Source/WebKit2/UIProcess/WebProcessProxy.cpp
branches/safari-603-branch/Source/WebKit2/UIProcess/WebProcessProxy.h
branches/safari-603-branch/Source/WebKit2/UIProcess/WebProcessProxy.messages.in
branches/safari-603-branch/Source/WebKit2/WebProcess/WebProcess.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/page/DiagnosticLoggingKeys.cpp (216635 => 216636)

--- branches/safari-603-branch/Source/WebCore/page/DiagnosticLoggingKeys.cpp	2017-05-10 23:22:33 UTC (rev 216635)
+++ branches/safari-603-branch/Source/WebCore/page/DiagnosticLoggingKeys.cpp	2017-05-10 23:39:48 UTC (rev 216636)
@@ -338,6 +338,16 @@
 return ASCIILiteral("documentLoaderStopping");
 }
 
+String DiagnosticLoggingKeys::simulatedPageCrashKey()
+{
+return ASCIILiteral("SimulatedPageCrash");
+}
+
+String DiagnosticLoggingKeys::exceededMemoryLimitKey()
+{
+return ASCIILiteral("ExceededMemoryLimit");
+}
+
 String DiagnosticLoggingKeys::cannotSuspendActiveDOMObjectsKey()
 {
 return ASCIILiteral("cannotSuspendActiveDOMObjects");


Modified: branches/safari-603-branch/Source/WebCore/page/DiagnosticLoggingKeys.h (216635 => 216636)

--- branches/safari-603-branch/Source/WebCore/page/DiagnosticLoggingKeys.h	2017-05-10 23:22:33 UTC (rev 216635)
+++ branches/safari-603-branch/Source/WebCore/page/DiagnosticLoggingKeys.h	2017-05-10 23:39:48 UTC (rev 216636)
@@ -50,6 +50,8 @@
 static String diskCacheKey();
 static String diskCacheAfterValidationKey();
 static String documentLoaderStoppingKey();
+WEBCORE_EXPORT static String simulatedPageCrashKey();
+WEBCORE_EXPORT static String exceededMemoryLimitKey();
 static String engineFailedToLoadKey();
 WEBCORE_EXPORT static String entryRightlyNotWarmedUpKey();
 WEBCORE_EXPORT static String entryWronglyNotWarmedUpKey();


Modified: branches/safari-603-branch/Source/WebCore/page/MemoryRelease.cpp (216635 => 216636)

--- branches/safari-603-branch/Source/WebCore/page/MemoryRelease.cpp	2017-05-10 23:22:33 UTC (rev 216635)
+++ branches/safari-603-branch/Source/WebCore/page/MemoryRelease.cpp	2017-05-10 23:39:48 UTC (rev 216636)
@@ -182,13 +182,6 @@
 #endif
 }
 
-void didExceedMemoryLimitAndFailedToRecover()
-{
-RELEASE_LOG(MemoryPressure, "Crashing non-visible process due to excessive memory usage + inability to free up memory below panic threshold.");
-logMemoryStatisticsAtTimeOfDeath();
-CRASH();
-}
-
 bool processIsEligibleForMemoryKill()
 {
 bool hasVisiblePages = false;


Modified: branches/safari-603-branch/Source/WebCore/page/MemoryRelease.h (216635 => 216636)

--- branches/safari-603-branch/Source/WebCore/page/MemoryRelease.h	2017-05-10 23:22:33 UTC (rev 216635)
+++ branches/safari-603-branch/Source/WebCore/page/MemoryRelease.h	2017-05-10 23:39:48 UTC (rev 216636)
@@ -34,7 +34,6 @@
 void jettisonExpensiveObjectsOnTopLevelNavigation();
 WEBCORE_EXPORT void registerMemoryReleaseNotifyCallbacks();
 WEBCORE_EXPORT void logMemoryStatisticsAtTimeOfDeath();
-WEBCORE_EXPORT NO_RETURN_DUE_TO_CRASH void didExceedMemoryLimitAndFailedToRecover();
 WEBCORE_EXPORT bool processIsEligibleForMemoryKill();
 
 } // namespace WebCore


Modified: branches/safari-603-branch/Source/WebKit2/UIProcess/WebProcessProxy.cpp (216635 => 216636)

--- branches/safari-603-branch/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2017-05-10 23:22:33 UTC (rev 216635)
+++ branches/safari-603-branch/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2017-05-10 23:39:48 UTC (rev 216636)
@@ -50,6 +50,7 @@
 #include "WebProcessProxyMessages.h"
 #include "WebUserContentControllerProxy.h"
 #include "WebsiteData.h"
+#include 
 #include 
 #include 
 #include 
@@ -1026,6 +1027,24 @@
 callback(isWebProcessResponsive);
 }
 
+static Vector pagesCopy(WTF::IteratorRange pages)
+{
+Vector vector;
+for (auto& page : pages)
+vector.append(page);
+return vector;
+}
+
+void WebProcessProxy::didExceedMemoryLimit()
+{
+RELEASE_LOG(PerformanceLogging, "%p - WebProcessProxy::didExceedMemoryLimit() Terminating WebProcess that has exceeded the memory limit", this);
+for (auto& page : pagesCopy(pages())) {
+page->logDiagnosticMessage(DiagnosticLoggingKeys::simulatedPageCrashKey(), DiagnosticLoggingKeys::exceededMemoryLimitKey(), false);
+page->terminateProcess();
+page->processDidCrash();
+}
+}
+
 #if !PLATFORM(COCOA)
 const HashSet& WebProcessProxy::platformPathsWithAssumedReadAccess()
 {


Modified: 

[webkit-changes] [216635] trunk

[mark . lam]

Title: [216635] trunk








Revision 216635
Author mark@apple.com
Date 2017-05-10 16:22:33 -0700 (Wed, 10 May 2017)


Log Message
WorkerThread::stop() should call scheduleExecutionTermination() last.
https://bugs.webkit.org/show_bug.cgi?id=171775


Reviewed by Geoffrey Garen.

Source/_javascript_Core:

Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100.  From experience, I found that 25 is sometimes not sufficient
for our debugging needs.

Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.

* runtime/ExceptionScope.cpp:
(JSC::ExceptionScope::unexpectedExceptionMessage):
(JSC::ExceptionScope::releaseAssertIsTerminatedExecutionException):
* runtime/ExceptionScope.h:
(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):
* runtime/VM.cpp:
(JSC::VM::throwException):
* runtime/VM.h:
(JSC::VM::throwingThread):
(JSC::VM::clearException):

Source/WebCore:

Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.

As a result, before run loop is terminate, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.

WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by ensuring that having WorkerThread::stop() terminate
the run loop before it scheduleExecutionTermination() which throws the
TerminatedExecutionException.  This way, by the time JS code unwinds out of the
VM due to the TerminatedExecutionException, runLoop.terminated() is guaranteed
to be true and thereby prevents re-entry into the VM.

This issue is covered by an existing test that I just unskipped in TestExpectations.

* bindings/js/JSDOMPromiseDeferred.cpp:
(WebCore::DeferredPromise::callFunction):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop):

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ExceptionScope.cpp
trunk/Source/_javascript_Core/runtime/ExceptionScope.h
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMPromiseDeferred.cpp
trunk/Source/WebCore/workers/WorkerThread.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (216634 => 216635)

--- trunk/LayoutTests/ChangeLog	2017-05-10 23:05:09 UTC (rev 216634)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 23:22:33 UTC (rev 216635)
@@ -1,3 +1,13 @@
+2017-05-10  Mark Lam  
+
+WorkerThread::stop() should call scheduleExecutionTermination() last.
+https://bugs.webkit.org/show_bug.cgi?id=171775
+
+
+Reviewed by Geoffrey Garen.
+
+* TestExpectations:
+
 2017-05-10  Tim Horton  
 
 Add an experimental feature flag for viewport-fit


Modified: trunk/LayoutTests/TestExpectations (216634 => 216635)

--- trunk/LayoutTests/TestExpectations	2017-05-10 23:05:09 UTC (rev 216634)
+++ trunk/LayoutTests/TestExpectations	2017-05-10 23:22:33 UTC (rev 216635)
@@ -365,9 +365,6 @@
 
 webkit.org/b/161312 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html [ Failure Pass ]
 
-# rdar://problem/30975761
-[ Debug ] http/tests/fetch/fetch-in-worker-crash.html [ Skip ]
-
 imported/w3c/web-platform-tests/XMLHttpRequest/send-conditional-cors.htm [ Failure ]
 imported/w3c/web-platform-tests/fetch/http-cache/partial.html [ Failure ]
 webkit.org/b/159724 imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm [ Failure Pass ]


Modified: trunk/Source/_javascript_Core/ChangeLog (216634 => 216635)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-10 23:05:09 UTC (rev 216634)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-10 23:22:33 UTC (rev 216635)
@@ -1,5 +1,32 @@
 2017-05-10  Mark Lam  
 
+WorkerThread::stop() should call scheduleExecutionTermination() last.
+https://bugs.webkit.org/show_bug.cgi?id=171775
+
+
+Reviewed by Geoffrey Garen.
+
+Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
+from 25 to 100.  From experience, I found that 25 is sometimes not sufficient
+for our debugging needs.
+
+Also added VM::throwingThread() to track which thread an exception was thrown in.
+This may be useful if the client is entering 

[webkit-changes] [216634] trunk

[timothy_horton]

Title: [216634] trunk








Revision 216634
Author timothy_hor...@apple.com
Date 2017-05-10 16:05:09 -0700 (Wed, 10 May 2017)


Log Message
Add an experimental feature flag for viewport-fit
https://bugs.webkit.org/show_bug.cgi?id=171948


Reviewed by Simon Fraser.

* Shared/WebPreferencesDefinitions.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Add an experimental feature flag.

* dom/ViewportArguments.cpp:
(WebCore::setViewportFeature):
* page/Settings.in:
Disable parsing of viewport-fit if the experimental feature is disabled.

* fast/css/variables/constants/ios/safe-area-inset-set-expected.html:
* fast/css/variables/constants/ios/safe-area-inset-set.html:
* fast/viewport/ios/viewport-fit-auto.html:
* fast/viewport/ios/viewport-fit-contain.html:
* fast/viewport/ios/viewport-fit-cover.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/variables/constants/ios/safe-area-inset-set-expected.html
trunk/LayoutTests/fast/css/variables/constants/ios/safe-area-inset-set.html
trunk/LayoutTests/fast/viewport/ios/viewport-fit-auto.html
trunk/LayoutTests/fast/viewport/ios/viewport-fit-contain.html
trunk/LayoutTests/fast/viewport/ios/viewport-fit-cover.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ViewportArguments.cpp
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (216633 => 216634)

--- trunk/LayoutTests/ChangeLog	2017-05-10 22:57:28 UTC (rev 216633)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 23:05:09 UTC (rev 216634)
@@ -1,3 +1,17 @@
+2017-05-10  Tim Horton  
+
+Add an experimental feature flag for viewport-fit
+https://bugs.webkit.org/show_bug.cgi?id=171948
+
+
+Reviewed by Simon Fraser.
+
+* fast/css/variables/constants/ios/safe-area-inset-set-expected.html:
+* fast/css/variables/constants/ios/safe-area-inset-set.html:
+* fast/viewport/ios/viewport-fit-auto.html:
+* fast/viewport/ios/viewport-fit-contain.html:
+* fast/viewport/ios/viewport-fit-cover.html:
+
 2017-05-10  Matt Lewis  
 
 Marked fast/hidpi/filters-and-image-buffer-resolution.html as flaky.


Modified: trunk/LayoutTests/fast/css/variables/constants/ios/safe-area-inset-set-expected.html (216633 => 216634)

--- trunk/LayoutTests/fast/css/variables/constants/ios/safe-area-inset-set-expected.html	2017-05-10 22:57:28 UTC (rev 216633)
+++ trunk/LayoutTests/fast/css/variables/constants/ios/safe-area-inset-set-expected.html	2017-05-10 23:05:09 UTC (rev 216634)
@@ -1,5 +1,9 @@
  
 
+
+if (window.internals)
+internals.settings.setViewportFitEnabled(true);
+
 
 

[webkit-changes] [216633] trunk/LayoutTests

[jlewis3]

Title: [216633] trunk/LayoutTests








Revision 216633
Author jlew...@apple.com
Date 2017-05-10 15:57:28 -0700 (Wed, 10 May 2017)


Log Message
Marked fast/hidpi/filters-and-image-buffer-resolution.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171951

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216632 => 216633)

--- trunk/LayoutTests/ChangeLog	2017-05-10 22:25:43 UTC (rev 216632)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 22:57:28 UTC (rev 216633)
@@ -1,3 +1,12 @@
+2017-05-10  Matt Lewis  
+
+Marked fast/hidpi/filters-and-image-buffer-resolution.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171951
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2017-05-10  Antti Koivisto  
 
 REGRESSION (r207372) Visibility property is not inherited when used in an animation


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216632 => 216633)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-10 22:25:43 UTC (rev 216632)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-10 22:57:28 UTC (rev 216633)
@@ -1981,3 +1981,5 @@
 webkit.org/b/171930 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html [ Pass Failure ]
 
 webkit.org/b/171945 [ Debug ] perf/class-list-remove.html [ Pass Failure Timeout ]
+
+webkit.org/b/171951 [ Debug ] fast/hidpi/filters-and-image-buffer-resolution.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216632] trunk/Source

[cdumez]

Title: [216632] trunk/Source








Revision 216632
Author cdu...@apple.com
Date 2017-05-10 15:25:43 -0700 (Wed, 10 May 2017)


Log Message
Simplify relationship between Attr and Element now that Attr is childless
https://bugs.webkit.org/show_bug.cgi?id=171909

Reviewed by Ryosuke Niwa.

Source/WebCore:

Simplify relationship between Attr and Element now that Attr is childless
after r216259.

No new tests, no Web facing behavior change.

* dom/Attr.cpp:
(WebCore::Attr::setValue):
Attr::setValue() was only called by Element::setAttributeInternal() to make sure
we updated the Attr node's Text child. However, now that Attr has no Text child,
Element no longer needs to update the Attr node's value.
Attr::setValueForBindings() was thus renamed to setValue(). Its implementation
was also simplified by calling Element::setAttribute() on its ownerElement, if
it has one, instead of duplicating a bunch of code from Element::setAttributeInternal().

(WebCore::Attr::setNodeValue):
Call setValue() instead of setValueForBindings() now that it has been renamed.

* dom/Attr.h:
* dom/Attr.idl:
Rename valueForBindings / setValueForBindings to value / setValue.

* dom/Document.h:
Split shouldInvalidateNodeListAndCollectionCaches() into 2 methods, one taking an Attr name
and another that does not. There are now 2 calls sites instead of one, so we no longer need
to branch in this function.

* dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
Drop code calling Attr::setValue() on the Attr node since Attr::setValue() was only
duplicating logic from Element::setAttributeInternal() after r216259. There is nothing
on Attr that needs updating when an element attribute gets updated.

(WebCore::Element::attributeChanged):
Call the new invalidateNodeListAndCollectionCachesInAncestorsForAttribute(). This
is the only call site that passes an attribute name.

* dom/Node.cpp:
(WebCore::Document::shouldInvalidateNodeListAndCollectionCaches):
(WebCore::Document::shouldInvalidateNodeListAndCollectionCachesForAttribute):
Split into 2 to avoid branching, as explained above.

(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestors):
(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestorsForAttribute):
- invalidateNodeListAndCollectionCachesInAncestors() used to invalidate childNodeLists
  if the Node was an attribute node. Drop this as this is no longer needed as of r216259.
- After the change to Attr::setValue(), call sites for
  invalidateNodeListAndCollectionCachesInAncestors() either had no parameters, or both
  parameters present and non-null. There is therefore no longer any need to handle
  having an attrName but no attributeOwnerElement. To make this obvious, I split this
  into 2 methods: invalidateNodeListAndCollectionCachesInAncestors() and
  invalidateNodeListAndCollectionCachesInAncestorsForAttribute(attrName). We no longer
  need the attributeOwnerElement parameter as it was only used to exit early.

* dom/Node.h:

Source/WebKit/mac:

Build fix.

* DOM/DOMAttr.mm:
(-[DOMAttr value]):
(-[DOMAttr setValue:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/Attr.h
trunk/Source/WebCore/dom/Attr.idl
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/LiveNodeList.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/NodeRareData.h
trunk/Source/WebCore/html/CachedHTMLCollection.h
trunk/Source/WebCore/html/HTMLCollection.cpp
trunk/Source/WebCore/html/HTMLCollection.h
trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp
trunk/Source/WebCore/html/HTMLFormControlsCollection.h
trunk/Source/WebCore/html/HTMLSelectElement.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/DOM/DOMAttr.mm
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMAttr.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216631 => 216632)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 22:23:11 UTC (rev 216631)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 22:25:43 UTC (rev 216632)
@@ -1,3 +1,65 @@
+2017-05-10  Chris Dumez  
+
+Simplify relationship between Attr and Element now that Attr is childless
+https://bugs.webkit.org/show_bug.cgi?id=171909
+
+Reviewed by Ryosuke Niwa.
+
+Simplify relationship between Attr and Element now that Attr is childless
+after r216259.
+
+No new tests, no Web facing behavior change.
+
+* dom/Attr.cpp:
+(WebCore::Attr::setValue):
+Attr::setValue() was only called by Element::setAttributeInternal() to make sure
+we updated the Attr node's Text child. However, now that Attr has no Text child,
+Element no longer needs to update the Attr node's value.
+Attr::setValueForBindings() was thus renamed to setValue(). Its implementation
+was also simplified by calling Element::setAttribute() on its ownerElement, if
+it has 

[webkit-changes] [216631] trunk

[antti]

Title: [216631] trunk








Revision 216631
Author an...@apple.com
Date 2017-05-10 15:23:11 -0700 (Wed, 10 May 2017)


Log Message
REGRESSION (r207372) Visibility property is not inherited when used in an animation
https://bugs.webkit.org/show_bug.cgi?id=171883


Reviewed by Simon Fraser.

Source/WebCore:

The problem here is that our animation code is tied to renderers. We don't have renderers during
the initial style resolution so animations are not applied yet. When constructing renderers we set
their style to the initial animated style but this step can't implement inheritance.

Normally this is invisible as the first animation frame will immediately inherit the style correctly.
However in this case the animation is discrete and the first frame is the same as the initial state.
With r207372 we optimize the descendant style change away.

This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.

Test: animations/animation-initial-inheritance.html

* rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
* rendering/RenderElement.h:
(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createRenderer):

Set a bit on renderer indicating it has initial animated style.

* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Return at least 'Inherit' for style change when updating renderer with initial animated style.

LayoutTests:

* animations/animation-initial-inheritance-expected.html: Added.
* animations/animation-initial-inheritance.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/style/RenderTreeUpdater.cpp
trunk/Source/WebCore/style/StyleTreeResolver.cpp


Added Paths

trunk/LayoutTests/animations/animation-initial-inheritance-expected.html
trunk/LayoutTests/animations/animation-initial-inheritance.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216630 => 216631)

--- trunk/LayoutTests/ChangeLog	2017-05-10 22:03:14 UTC (rev 216630)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 22:23:11 UTC (rev 216631)
@@ -1,3 +1,14 @@
+2017-05-10  Antti Koivisto  
+
+REGRESSION (r207372) Visibility property is not inherited when used in an animation
+https://bugs.webkit.org/show_bug.cgi?id=171883
+
+
+Reviewed by Simon Fraser.
+
+* animations/animation-initial-inheritance-expected.html: Added.
+* animations/animation-initial-inheritance.html: Added.
+
 2017-05-10  Matt Lewis  
 
 Marked transitions/extra-transition.html as flaky.


Added: trunk/LayoutTests/animations/animation-initial-inheritance-expected.html (0 => 216631)

--- trunk/LayoutTests/animations/animation-initial-inheritance-expected.html	(rev 0)
+++ trunk/LayoutTests/animations/animation-initial-inheritance-expected.html	2017-05-10 22:23:11 UTC (rev 216631)
@@ -0,0 +1,23 @@
+
+
+
+
+#test1 {
+visibility: hidden;
+}
+#test2 {
+color: green;
+}
+
+
+
+
+This shouldn't be initially visible
+This shouldn't be initially visible
+
+
+This should be initially green
+This should be initially green
+
+
+


Added: trunk/LayoutTests/animations/animation-initial-inheritance.html (0 => 216631)

--- trunk/LayoutTests/animations/animation-initial-inheritance.html	(rev 0)
+++ trunk/LayoutTests/animations/animation-initial-inheritance.html	2017-05-10 22:23:11 UTC (rev 216631)
@@ -0,0 +1,39 @@
+
+
+
+
+#test1 {
+animation:test1 3s steps(1,end) 0s 1 normal both
+}
+#test2 {
+animation:test2 3s steps(1,end) 0s 1 normal both
+}
+@keyframes test1 {
+from {visibility: hidden}
+to {visibility: visible}
+}
+@keyframes test2 {
+from {color: green}
+to {color: red}
+}
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+requestAnimationFrame(() => {
+testRunner.notifyDone();
+});
+}
+
+
+
+
+This shouldn't be initially visible
+This shouldn't be initially visible
+
+
+This should be initially green
+This should be initially green
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (216630 => 216631)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 22:03:14 UTC (rev 216630)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 22:23:11 UTC (rev 216631)
@@ -1,3 +1,39 @@
+2017-05-10  Antti Koivisto  
+
+REGRESSION (r207372) Visibility property is not inherited when used in an animation
+https://bugs.webkit.org/show_bug.cgi?id=171883
+
+
+Reviewed by Simon Fraser.
+
+The problem here is that our animation code is tied to renderers. We don't have renderers during
+the initial style resolution so 

[webkit-changes] [216630] trunk/Source/WebCore

[jer . noble]

Title: [216630] trunk/Source/WebCore








Revision 216630
Author jer.no...@apple.com
Date 2017-05-10 15:03:14 -0700 (Wed, 10 May 2017)


Log Message
RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
https://bugs.webkit.org/show_bug.cgi?id=171711

Reviewed by Youenn Fablet.

Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
we don't walk over the end of either by only iterating over the minimum length of either.
Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
MediaStreamAudioSourceNode that the number of channels and sample rate have changed.

* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216629 => 216630)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 22:01:05 UTC (rev 216629)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 22:03:14 UTC (rev 216630)
@@ -1,3 +1,19 @@
+2017-05-10  Jer Noble  
+
+RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
+https://bugs.webkit.org/show_bug.cgi?id=171711
+
+Reviewed by Youenn Fablet.
+
+Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
+we don't walk over the end of either by only iterating over the minimum length of either.
+Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
+MediaStreamAudioSourceNode that the number of channels and sample rate have changed.
+
+* platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
+(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
+(WebCore::WebAudioSourceProviderAVFObjC::prepare):
+
 2017-05-04  Filip Pizlo  
 
 GCController.cpp's collect() should be Async


Modified: trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm (216629 => 216630)

--- trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm	2017-05-10 22:01:05 UTC (rev 216629)
+++ trunk/Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm	2017-05-10 22:03:14 UTC (rev 216630)
@@ -80,7 +80,9 @@
 }
 
 WebAudioBufferList list { *m_outputDescription };
-for (unsigned i = 0; i < list.bufferCount(); ++i) {
+ASSERT(list.bufferCount() == bus->numberOfChannels());
+unsigned channelCount = std::min(list.bufferCount(), bus->numberOfChannels());
+for (unsigned i = 0; i < channelCount; ++i) {
 AudioChannel& channel = *bus->channel(i);
 auto* buffer = list.buffer(i);
 buffer->mNumberChannels = 1;
@@ -137,11 +139,8 @@
 m_dataSource->setInputFormat(*m_inputDescription);
 m_dataSource->setOutputFormat(*m_outputDescription);
 
-RefPtr protectedThis = this;
-callOnMainThread([protectedThis = WTFMove(protectedThis), numberOfChannels, sampleRate] {
-if (protectedThis->m_client)
-protectedThis->m_client->setFormat(numberOfChannels, sampleRate);
-});
+if (m_client)
+m_client->setFormat(numberOfChannels, sampleRate);
 }
 
 void WebAudioSourceProviderAVFObjC::unprepare()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216629] trunk/Source/WebInspectorUI

[bburg]

Title: [216629] trunk/Source/WebInspectorUI








Revision 216629
Author bb...@apple.com
Date 2017-05-10 15:01:05 -0700 (Wed, 10 May 2017)


Log Message
Web Inspector: RTL: in Timelines > _javascript_ & Events, digits for timer and animation frame number are not localized
https://bugs.webkit.org/show_bug.cgi?id=171818

Reviewed by Joseph Pecoraro.

These numbers need to be formatted with %d, not %s.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (216628 => 216629)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-05-10 21:59:17 UTC (rev 216628)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-05-10 22:01:05 UTC (rev 216629)
@@ -1,5 +1,18 @@
 2017-05-10  Brian Burg  
 
+Web Inspector: RTL: in Timelines > _javascript_ & Events, digits for timer and animation frame number are not localized
+https://bugs.webkit.org/show_bug.cgi?id=171818
+
+Reviewed by Joseph Pecoraro.
+
+These numbers need to be formatted with %d, not %s.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Models/ScriptTimelineRecord.js:
+(WebInspector.ScriptTimelineRecord.EventType.displayName):
+
+2017-05-10  Brian Burg  
+
 Web Inspector: remove dead code for switching Toolbar display options
 https://bugs.webkit.org/show_bug.cgi?id=170738
 


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (216628 => 216629)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2017-05-10 21:59:17 UTC (rev 216628)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2017-05-10 22:01:05 UTC (rev 216629)
@@ -87,9 +87,9 @@
 localizedStrings["An unexpected error occurred."] = "An unexpected error occurred.";
 localizedStrings["Angle"] = "Angle";
 localizedStrings["Animation"] = "Animation";
-localizedStrings["Animation Frame %s Canceled"] = "Animation Frame %s Canceled";
-localizedStrings["Animation Frame %s Fired"] = "Animation Frame %s Fired";
-localizedStrings["Animation Frame %s Requested"] = "Animation Frame %s Requested";
+localizedStrings["Animation Frame %d Canceled"] = "Animation Frame %d Canceled";
+localizedStrings["Animation Frame %d Fired"] = "Animation Frame %d Fired";
+localizedStrings["Animation Frame %d Requested"] = "Animation Frame %d Requested";
 localizedStrings["Animation Frame Canceled"] = "Animation Frame Canceled";
 localizedStrings["Animation Frame Fired"] = "Animation Frame Fired";
 localizedStrings["Animation Frame Requested"] = "Animation Frame Requested";
@@ -839,9 +839,9 @@
 localizedStrings["Timeline"] = "Timeline";
 localizedStrings["Timeline Recording %d"] = "Timeline Recording %d";
 localizedStrings["Timelines"] = "Timelines";
-localizedStrings["Timer %s Fired"] = "Timer %s Fired";
-localizedStrings["Timer %s Installed"] = "Timer %s Installed";
-localizedStrings["Timer %s Removed"] = "Timer %s Removed";
+localizedStrings["Timer %d Fired"] = "Timer %d Fired";
+localizedStrings["Timer %d Installed"] = "Timer %d Installed";
+localizedStrings["Timer %d Removed"] = "Timer %d Removed";
 localizedStrings["Timer Fired"] = "Timer Fired";
 localizedStrings["Timer Installed"] = "Timer Installed";
 localizedStrings["Timer Removed"] = "Timer Removed";


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js (216628 => 216629)

--- trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js	2017-05-10 21:59:17 UTC (rev 216628)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js	2017-05-10 22:01:05 UTC (rev 216629)
@@ -388,27 +388,27 @@
 return WebInspector.UIString("Garbage Collection");
 case WebInspector.ScriptTimelineRecord.EventType.TimerFired:
 if (details && includeDetailsInMainTitle)
-return WebInspector.UIString("Timer %s Fired").format(details);
+return WebInspector.UIString("Timer %d Fired").format(details);
 return WebInspector.UIString("Timer Fired");
 case WebInspector.ScriptTimelineRecord.EventType.TimerInstalled:
 if (details && includeDetailsInMainTitle)
-return WebInspector.UIString("Timer %s Installed").format(details.timerId);
+return WebInspector.UIString("Timer %d Installed").format(details.timerId);
 return WebInspector.UIString("Timer Installed");
 case WebInspector.ScriptTimelineRecord.EventType.TimerRemoved:
 if (details && includeDetailsInMainTitle)
-return WebInspector.UIString("Timer %s Removed").format(details);
+return WebInspector.UIString("Timer %d 

[webkit-changes] [216628] trunk/Source/WebInspectorUI

[bburg]

Title: [216628] trunk/Source/WebInspectorUI








Revision 216628
Author bb...@apple.com
Date 2017-05-10 14:59:17 -0700 (Wed, 10 May 2017)


Log Message
Web Inspector: remove dead code for switching Toolbar display options
https://bugs.webkit.org/show_bug.cgi?id=170738

Reviewed by Joseph Pecoraro.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
* UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button > .glyph):
(.toolbar .item.button > .label):
(.toolbar.icon-and-label-vertical .item.button): Deleted.
(.toolbar.icon-and-label-horizontal .item.button): Deleted.
(.toolbar.small-size .item.button > .glyph): Deleted.
(.toolbar.label-only .item.button > .glyph): Deleted.
(.toolbar.label-only .item.activate.button.activated > .label): Deleted.
(.toolbar.icon-and-label-horizontal .item.button > .label): Deleted.
(.toolbar.icon-only .item.button > .label): Deleted.
* UserInterface/Views/ControlToolbarItem.css:
(.toolbar .item.control):
(.toolbar:matches(.icon-and-label-horizontal, .icon-only) .item.control): Deleted.
* UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container):
(.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container): Deleted.
(.toolbar.label-only .dashboard-container,): Deleted.
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
(.toolbar.label-only .dashboard-container .advance-arrow): Deleted.
(body[dir=ltr] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.
(body[dir=rtl] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.
* UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default > .item):
(.toolbar.label-only .dashboard.default > .item,): Deleted.
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item): Deleted.
* UserInterface/Views/ReplayDashboardView.css:
(.toolbar .dashboard.replay .item.button > .glyph):
(.toolbar.label-only .dashboard.replay .item.button > .glyph): Deleted.
* UserInterface/Views/Toolbar.css:
(.toolbar .control-section):
(.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section): Deleted.
* UserInterface/Views/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.layout):
(WebInspector.Toolbar.prototype.get displayMode): Deleted.
(WebInspector.Toolbar.prototype.set displayMode): Deleted.
(WebInspector.Toolbar.prototype.get sizeMode): Deleted.
(WebInspector.Toolbar.prototype.set sizeMode): Deleted.
(WebInspector.Toolbar.prototype._handleContextMenuEvent): Deleted.
(WebInspector.Toolbar.prototype._changeDisplayMode): Deleted.
(WebInspector.Toolbar.prototype._toggleSmallIcons): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/ButtonToolbarItem.css
trunk/Source/WebInspectorUI/UserInterface/Views/ControlToolbarItem.css
trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css
trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.css
trunk/Source/WebInspectorUI/UserInterface/Views/ReplayDashboardView.css
trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css
trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (216627 => 216628)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-05-10 21:59:04 UTC (rev 216627)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-05-10 21:59:17 UTC (rev 216628)
@@ -1,3 +1,55 @@
+2017-05-10  Brian Burg  
+
+Web Inspector: remove dead code for switching Toolbar display options
+https://bugs.webkit.org/show_bug.cgi?id=170738
+
+Reviewed by Joseph Pecoraro.
+
+* Localizations/en.lproj/localizedStrings.js:
+* UserInterface/Base/Main.js:
+(WebInspector.contentLoaded):
+* UserInterface/Views/ButtonToolbarItem.css:
+(.toolbar .item.button > .glyph):
+(.toolbar .item.button > .label):
+(.toolbar.icon-and-label-vertical .item.button): Deleted.
+(.toolbar.icon-and-label-horizontal .item.button): Deleted.
+(.toolbar.small-size .item.button > .glyph): Deleted.
+(.toolbar.label-only .item.button > .glyph): Deleted.
+(.toolbar.label-only .item.activate.button.activated > .label): Deleted.
+(.toolbar.icon-and-label-horizontal .item.button > .label): Deleted.
+(.toolbar.icon-only .item.button > .label): Deleted.
+* UserInterface/Views/ControlToolbarItem.css:
+(.toolbar .item.control):
+(.toolbar:matches(.icon-and-label-horizontal, .icon-only) .item.control): Deleted.
+* UserInterface/Views/DashboardContainerView.css:
+

[webkit-changes] [216627] branches/safari-603-branch/Source/WebCore/ChangeLog

[matthew_hanson]

Title: [216627] branches/safari-603-branch/Source/WebCore/ChangeLog








Revision 216627
Author matthew_han...@apple.com
Date 2017-05-10 14:59:04 -0700 (Wed, 10 May 2017)


Log Message
Fix order of merge from r212528. rdar://problem/31153819

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216626 => 216627)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 21:59:01 UTC (rev 216626)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 21:59:04 UTC (rev 216627)
@@ -1,6 +1,6 @@
 2017-05-10  Matthew Hanson  
 
-Fix order of merge from r212528
+Fix order of merge from r212528. rdar://problem/31153819
 
 2017-05-01  Jeremy Jones  
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216626] branches/safari-603-branch/Source/WebCore

[matthew_hanson]

Title: [216626] branches/safari-603-branch/Source/WebCore








Revision 216626
Author matthew_han...@apple.com
Date 2017-05-10 14:59:01 -0700 (Wed, 10 May 2017)


Log Message
Fix order of merge from r212528

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/html/MediaElementSession.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216625 => 216626)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 21:57:17 UTC (rev 216625)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 21:59:01 UTC (rev 216626)
@@ -1,5 +1,23 @@
 2017-05-10  Matthew Hanson  
 
+Fix order of merge from r212528
+
+2017-05-01  Jeremy Jones  
+
+Fix order of merge from r212528
+
+Two changes got merged in the wrong order.
+rdar://problem/31153819
+
+Reviewed by Jer Noble.
+
+Fixes test failure media/media-fullscreen-loop-inline.html
+
+* html/MediaElementSession.cpp:
+(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
+
+2017-05-10  Matthew Hanson  
+
 Cherry-pick r215429. rdar://problem/32057106
 
 2017-04-17  Youenn Fablet  


Modified: branches/safari-603-branch/Source/WebCore/html/MediaElementSession.cpp (216625 => 216626)

--- branches/safari-603-branch/Source/WebCore/html/MediaElementSession.cpp	2017-05-10 21:57:17 UTC (rev 216625)
+++ branches/safari-603-branch/Source/WebCore/html/MediaElementSession.cpp	2017-05-10 21:59:01 UTC (rev 216626)
@@ -541,13 +541,13 @@
 if (is(element))
 return false;
 
+if (element.isTemporarilyAllowingInlinePlaybackAfterFullscreen())
+return false;
+
 Settings* settings = element.document().settings();
 if (!settings || !settings->allowsInlineMediaPlayback())
 return true;
 
-if (element.isTemporarilyAllowingInlinePlaybackAfterFullscreen())
-return false;
-
 if (!settings->inlineMediaPlaybackRequiresPlaysInlineAttribute())
 return false;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216625] trunk/Source/WebCore

[fpizlo]

Title: [216625] trunk/Source/WebCore








Revision 216625
Author fpi...@apple.com
Date 2017-05-10 14:57:17 -0700 (Wed, 10 May 2017)


Log Message
GCController.cpp's collect() should be Async
https://bugs.webkit.org/show_bug.cgi?id=171708

Reviewed by Saam Barati and Geoffrey Garen.

No new tests because no change in behavior.

This is one step towards not requesting sync GCs in WebCore. I'm landing this incrementally to
make bisecting super easy.

This is a ~7% JetStream iOS "regression", because JetStream has a bug where it allows trunk
to sneakily hide GC work between when JetStream measures time. After this change, we are no
longer trying to be sneaky.

* bindings/js/GCController.cpp:
(WebCore::collect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/GCController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216624 => 216625)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 21:34:43 UTC (rev 216624)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 21:57:17 UTC (rev 216625)
@@ -1,3 +1,22 @@
+2017-05-04  Filip Pizlo  
+
+GCController.cpp's collect() should be Async
+https://bugs.webkit.org/show_bug.cgi?id=171708
+
+Reviewed by Saam Barati and Geoffrey Garen.
+
+No new tests because no change in behavior.
+
+This is one step towards not requesting sync GCs in WebCore. I'm landing this incrementally to
+make bisecting super easy.
+
+This is a ~7% JetStream iOS "regression", because JetStream has a bug where it allows trunk
+to sneakily hide GC work between when JetStream measures time. After this change, we are no
+longer trying to be sneaky.
+
+* bindings/js/GCController.cpp:
+(WebCore::collect):
+
 2017-05-10  Jer Noble  
 
 CoreAudioCaptureSource reports 3 or 5 channel audio output; actually only mono


Modified: trunk/Source/WebCore/bindings/js/GCController.cpp (216624 => 216625)

--- trunk/Source/WebCore/bindings/js/GCController.cpp	2017-05-10 21:34:43 UTC (rev 216624)
+++ trunk/Source/WebCore/bindings/js/GCController.cpp	2017-05-10 21:57:17 UTC (rev 216625)
@@ -41,7 +41,7 @@
 static void collect(void*)
 {
 JSLockHolder lock(commonVM());
-commonVM().heap.collectNow(Sync, CollectionScope::Full);
+commonVM().heap.collectNow(Async, CollectionScope::Full);
 }
 
 GCController& GCController::singleton()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216624] trunk/LayoutTests

[jlewis3]

Title: [216624] trunk/LayoutTests








Revision 216624
Author jlew...@apple.com
Date 2017-05-10 14:34:43 -0700 (Wed, 10 May 2017)


Log Message
Marked transitions/extra-transition.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171947

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216623 => 216624)

--- trunk/LayoutTests/ChangeLog	2017-05-10 21:31:05 UTC (rev 216623)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 21:34:43 UTC (rev 216624)
@@ -1,3 +1,12 @@
+2017-05-10  Matt Lewis  
+
+Marked transitions/extra-transition.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171947
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2017-05-10  Ryan Haddad  
 
 Unreviewed, rolling out r216591.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216623 => 216624)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-10 21:31:05 UTC (rev 216623)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-10 21:34:43 UTC (rev 216624)
@@ -680,3 +680,5 @@
 webkit.org/171935 [ Sierra ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html [ Pass Failure ]
 
 webkit.org/171939 [ Sierra Release ] media/track/track-cue-rendering-on-resize.html [ Pass Timeout ]
+
+webkit.org/171947 [ Sierra Release ] transitions/extra-transition.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216623] trunk/Source/WebCore

[jer . noble]

Title: [216623] trunk/Source/WebCore








Revision 216623
Author jer.no...@apple.com
Date 2017-05-10 14:31:05 -0700 (Wed, 10 May 2017)


Log Message
CoreAudioCaptureSource reports 3 or 5 channel audio output; actually only mono
https://bugs.webkit.org/show_bug.cgi?id=171940

Reviewed by Eric Carlson.

Asking for the Input VPIO stream format will return the internal mic format, before processing. Instead
ask for the input bus's output format, which is post processing, which will return the correct number
of channels (one).

* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216622 => 216623)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 21:23:45 UTC (rev 216622)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 21:31:05 UTC (rev 216623)
@@ -1,3 +1,17 @@
+2017-05-10  Jer Noble  
+
+CoreAudioCaptureSource reports 3 or 5 channel audio output; actually only mono
+https://bugs.webkit.org/show_bug.cgi?id=171940
+
+Reviewed by Eric Carlson.
+
+Asking for the Input VPIO stream format will return the internal mic format, before processing. Instead
+ask for the input bus's output format, which is post processing, which will return the correct number
+of channels (one).
+
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):
+
 2017-05-10  Ryan Haddad  
 
 Unreviewed, rolling out r216591.


Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (216622 => 216623)

--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2017-05-10 21:23:45 UTC (rev 216622)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2017-05-10 21:31:05 UTC (rev 216623)
@@ -316,7 +316,7 @@
 AudioStreamBasicDescription microphoneProcFormat = { };
 
 UInt32 size = sizeof(microphoneProcFormat);
-err = AudioUnitGetProperty(m_ioUnit, kAudioUnitProperty_StreamFormat, kAudioUnitScope_Input, inputBus, , );
+err = AudioUnitGetProperty(m_ioUnit, kAudioUnitProperty_StreamFormat, kAudioUnitScope_Output, inputBus, , );
 if (err) {
 LOG(Media, "CoreAudioSharedUnit::configureMicrophoneProc(%p) unable to get output stream format, error %d (%.4s)", this, (int)err, (char*));
 return err;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216622] branches/safari-603-branch/Source

[matthew_hanson]

Title: [216622] branches/safari-603-branch/Source








Revision 216622
Author matthew_han...@apple.com
Date 2017-05-10 14:23:45 -0700 (Wed, 10 May 2017)


Log Message
Additional ENABLE_STREAMS cleanup

Modified Paths

branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/WebCore-GuardedInternalBuiltin-Separate.js
branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result
branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result
branches/safari-603-branch/Source/WebCore/Modules/streams/ByteLengthQueuingStrategy.idl
branches/safari-603-branch/Source/WebCore/Modules/streams/ByteLengthQueuingStrategy.js
branches/safari-603-branch/Source/WebCore/Modules/streams/CountQueuingStrategy.idl
branches/safari-603-branch/Source/WebCore/Modules/streams/CountQueuingStrategy.js
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableByteStreamController.idl
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableByteStreamController.js
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStream.idl
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStream.js
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStreamDefaultController.idl
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStreamDefaultController.js
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.idl
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStreamInternals.js
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStreamSource.h
branches/safari-603-branch/Source/WebCore/Modules/streams/ReadableStreamSource.idl
branches/safari-603-branch/Source/WebCore/Modules/streams/StreamInternals.js
branches/safari-603-branch/Source/WebCore/Modules/streams/WritableStream.idl
branches/safari-603-branch/Source/WebCore/Modules/streams/WritableStream.js
branches/safari-603-branch/Source/WebCore/Modules/streams/WritableStreamInternals.js




Diff

Modified: branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/WebCore-GuardedInternalBuiltin-Separate.js (216621 => 216622)

--- branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/WebCore-GuardedInternalBuiltin-Separate.js	2017-05-10 21:23:38 UTC (rev 216621)
+++ branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/WebCore-GuardedInternalBuiltin-Separate.js	2017-05-10 21:23:45 UTC (rev 216622)
@@ -23,7 +23,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-// @conditional=ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
+// @conditional=ENABLE(STREAMS_API)
 // @internal
 
 function isReadableStreamLocked(stream)


Modified: branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result (216621 => 216622)

--- branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result	2017-05-10 21:23:38 UTC (rev 216621)
+++ branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result	2017-05-10 21:23:45 UTC (rev 216622)
@@ -31,7 +31,7 @@
 
 #pragma once
 
-#if ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
+#if ENABLE(STREAMS_API)
 
 #include 
 #include 
@@ -151,7 +151,7 @@
 
 } // namespace WebCore
 
-#endif // ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
+#endif // ENABLE(STREAMS_API)
 ### End File: GuardedInternalBuiltinBuiltins.h
 
 ### Begin File: GuardedInternalBuiltinBuiltins.cpp
@@ -188,7 +188,7 @@
 #include "config.h"
 #include "GuardedInternalBuiltinBuiltins.h"
 
-#if ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
+#if ENABLE(STREAMS_API)
 
 #include "WebCoreJSClientData.h"
 #include 
@@ -224,6 +224,6 @@
 
 } // namespace WebCore
 
-#endif // ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
+#endif // ENABLE(STREAMS_API)
 
 ### End File: GuardedInternalBuiltinBuiltins.cpp


Modified: branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result (216621 => 216622)

--- branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result	2017-05-10 21:23:38 UTC (rev 216621)
+++ branches/safari-603-branch/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result	2017-05-10 21:23:45 UTC (rev 216622)
@@ -54,9 +54,9 @@
 #if ENABLE(STREAMS_API)
 , m_guardedBuiltinBuiltins(_vm)
 #endif // ENABLE(STREAMS_API)
-#if ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
+#if 

[webkit-changes] [216620] branches/safari-603-branch

[matthew_hanson]

Title: [216620] branches/safari-603-branch








Revision 216620
Author matthew_han...@apple.com
Date 2017-05-10 14:23:20 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r215250. rdar://problem/32057106

Modified Paths

branches/safari-603-branch/Source/_javascript_Core/ChangeLog
branches/safari-603-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Source/WebKit/mac/ChangeLog
branches/safari-603-branch/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Tools/ChangeLog
branches/safari-603-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: branches/safari-603-branch/Source/_javascript_Core/ChangeLog (216619 => 216620)

--- branches/safari-603-branch/Source/_javascript_Core/ChangeLog	2017-05-10 21:14:17 UTC (rev 216619)
+++ branches/safari-603-branch/Source/_javascript_Core/ChangeLog	2017-05-10 21:23:20 UTC (rev 216620)
@@ -1,3 +1,20 @@
+2017-05-10  Matthew Hanson  
+
+Cherry-pick r215250. rdar://problem/32057106
+
+2017-04-11  Dean Jackson  
+
+Disable outdated WritableStream API
+https://bugs.webkit.org/show_bug.cgi?id=170749
+
+
+Reviewed by Tim Horton.
+
+The API we implement is no longer accurate. Disable it until we
+are compatible with the new specification
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-05-09  Matthew Hanson  
 
 Cherry-pick r216279. rdar://problem/31967829


Modified: branches/safari-603-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (216619 => 216620)

--- branches/safari-603-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-05-10 21:14:17 UTC (rev 216619)
+++ branches/safari-603-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-05-10 21:23:20 UTC (rev 216620)
@@ -167,7 +167,7 @@
 ENABLE_SUBTLE_CRYPTO = ENABLE_SUBTLE_CRYPTO;
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC = ;
-ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API;
+ENABLE_WRITABLE_STREAM_API = ;
 
 ENABLE_TELEPHONE_NUMBER_DETECTION = ENABLE_TELEPHONE_NUMBER_DETECTION;
 


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216619 => 216620)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 21:14:17 UTC (rev 216619)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 21:23:20 UTC (rev 216620)
@@ -1,3 +1,20 @@
+2017-05-10  Matthew Hanson  
+
+Cherry-pick r215250. rdar://problem/32057106
+
+2017-04-11  Dean Jackson  
+
+Disable outdated WritableStream API
+https://bugs.webkit.org/show_bug.cgi?id=170749
+
+
+Reviewed by Tim Horton.
+
+The API we implement is no longer accurate. Disable it until we
+are compatible with the new specification
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-05-09  Matthew Hanson  
 
 Cherry-pick r216352. rdar://problem/32057098


Modified: branches/safari-603-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig (216619 => 216620)

--- branches/safari-603-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-05-10 21:14:17 UTC (rev 216619)
+++ branches/safari-603-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-05-10 21:23:20 UTC (rev 216620)
@@ -167,7 +167,7 @@
 ENABLE_SUBTLE_CRYPTO = ENABLE_SUBTLE_CRYPTO;
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC = ;
-ENABLE_WRITABLE_STREAM_API = ENABLE_WRITABLE_STREAM_API;
+ENABLE_WRITABLE_STREAM_API = ;
 
 ENABLE_TELEPHONE_NUMBER_DETECTION = ENABLE_TELEPHONE_NUMBER_DETECTION;
 


Modified: branches/safari-603-branch/Source/WebKit/mac/ChangeLog (216619 => 216620)

--- branches/safari-603-branch/Source/WebKit/mac/ChangeLog	2017-05-10 21:14:17 UTC (rev 216619)
+++ branches/safari-603-branch/Source/WebKit/mac/ChangeLog	2017-05-10 21:23:20 UTC (rev 216620)
@@ -1,3 +1,20 @@
+2017-05-10  Matthew Hanson  
+
+Cherry-pick r215250. rdar://problem/32057106
+
+2017-04-11  Dean Jackson  
+
+Disable outdated WritableStream API
+https://bugs.webkit.org/show_bug.cgi?id=170749
+
+
+Reviewed by Tim Horton.
+
+The API we implement is no longer accurate. Disable it until we
+are compatible with the new specification
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-02-20  Matthew Hanson  
 
 Merge r212331. 

[webkit-changes] [216621] branches/safari-603-branch

[matthew_hanson]

Title: [216621] branches/safari-603-branch








Revision 216621
Author matthew_han...@apple.com
Date 2017-05-10 14:23:38 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r215429. rdar://problem/32057106

Modified Paths

branches/safari-603-branch/Source/_javascript_Core/ChangeLog
branches/safari-603-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Source/_javascript_Core/runtime/CommonIdentifiers.h
branches/safari-603-branch/Source/WTF/ChangeLog
branches/safari-603-branch/Source/WTF/wtf/FeatureDefines.h
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Source/WebCore/DerivedSources.cpp
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchBody.cpp
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchBody.h
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchBodyOwner.h
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchResponse.cpp
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchResponse.h
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchResponse.idl
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchResponse.js
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchResponseSource.cpp
branches/safari-603-branch/Source/WebCore/Modules/fetch/FetchResponseSource.h
branches/safari-603-branch/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
branches/safari-603-branch/Source/WebCore/bindings/js/JSDOMGlobalObject.cpp
branches/safari-603-branch/Source/WebCore/bindings/js/JSReadableStreamPrivateConstructors.cpp
branches/safari-603-branch/Source/WebCore/bindings/js/JSReadableStreamPrivateConstructors.h
branches/safari-603-branch/Source/WebCore/bindings/js/JSReadableStreamSourceCustom.cpp
branches/safari-603-branch/Source/WebCore/bindings/js/ReadableStreamDefaultController.cpp
branches/safari-603-branch/Source/WebCore/bindings/js/ReadableStreamDefaultController.h
branches/safari-603-branch/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
branches/safari-603-branch/Source/WebCore/testing/Internals.cpp
branches/safari-603-branch/Source/WebCore/testing/Internals.h
branches/safari-603-branch/Source/WebCore/testing/Internals.idl
branches/safari-603-branch/Source/WebKit/mac/ChangeLog
branches/safari-603-branch/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
branches/safari-603-branch/Source/WebKit/mac/WebView/WebPreferences.mm
branches/safari-603-branch/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
branches/safari-603-branch/Source/WebKit/mac/WebView/WebView.mm
branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
branches/safari-603-branch/Source/cmake/OptionsWin.cmake
branches/safari-603-branch/Source/cmake/WebKitFeatures.cmake
branches/safari-603-branch/Source/cmake/tools/vsprops/FeatureDefines.props
branches/safari-603-branch/Tools/ChangeLog
branches/safari-603-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
branches/safari-603-branch/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
branches/safari-603-branch/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
branches/safari-603-branch/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h




Diff

Modified: branches/safari-603-branch/Source/_javascript_Core/ChangeLog (216620 => 216621)

--- branches/safari-603-branch/Source/_javascript_Core/ChangeLog	2017-05-10 21:23:20 UTC (rev 216620)
+++ branches/safari-603-branch/Source/_javascript_Core/ChangeLog	2017-05-10 21:23:38 UTC (rev 216621)
@@ -1,5 +1,19 @@
 2017-05-10  Matthew Hanson  
 
+Cherry-pick r215429. rdar://problem/32057106
+
+2017-04-17  Youenn Fablet  
+
+Disable outdated WritableStream API
+https://bugs.webkit.org/show_bug.cgi?id=170749
+
+
+Reviewed by Alex Christensen.
+
+* Configurations/FeatureDefines.xcconfig:
+
+2017-05-10  Matthew Hanson  
+
 Cherry-pick r215250. rdar://problem/32057106
 
 2017-04-11  Dean Jackson  


Modified: branches/safari-603-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (216620 => 216621)

--- branches/safari-603-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-05-10 21:23:20 UTC (rev 216620)
+++ branches/safari-603-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-05-10 21:23:38 UTC (rev 216621)
@@ -154,8 +154,6 @@
 ENABLE_PROXIMITY_EVENTS = ;
 ENABLE_PUBLIC_SUFFIX_LIST = ENABLE_PUBLIC_SUFFIX_LIST;
 ENABLE_QUOTA = ;
-ENABLE_READABLE_STREAM_API 

[webkit-changes] [216619] trunk

[ryanhaddad]

Title: [216619] trunk








Revision 216619
Author ryanhad...@apple.com
Date 2017-05-10 14:14:17 -0700 (Wed, 10 May 2017)


Log Message
Unreviewed, rolling out r216591.

This change broke an internal build.

Reverted changeset:

"REGRESSION (r207372) Visibility property is not inherited
when used in an animation"
https://bugs.webkit.org/show_bug.cgi?id=171883
http://trac.webkit.org/changeset/216591

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/style/RenderTreeUpdater.cpp
trunk/Source/WebCore/style/StyleTreeResolver.cpp


Removed Paths

trunk/LayoutTests/animations/animation-initial-inheritance-expected.html
trunk/LayoutTests/animations/animation-initial-inheritance.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216618 => 216619)

--- trunk/LayoutTests/ChangeLog	2017-05-10 21:11:31 UTC (rev 216618)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 21:14:17 UTC (rev 216619)
@@ -1,5 +1,18 @@
 2017-05-10  Ryan Haddad  
 
+Unreviewed, rolling out r216591.
+
+This change broke an internal build.
+
+Reverted changeset:
+
+"REGRESSION (r207372) Visibility property is not inherited
+when used in an animation"
+https://bugs.webkit.org/show_bug.cgi?id=171883
+http://trac.webkit.org/changeset/216591
+
+2017-05-10  Ryan Haddad  
+
 Unreviewed, remove TestExpectation for a test that was removed in r216259.
 
 * platform/mac/TestExpectations:


Deleted: trunk/LayoutTests/animations/animation-initial-inheritance-expected.html (216618 => 216619)

--- trunk/LayoutTests/animations/animation-initial-inheritance-expected.html	2017-05-10 21:11:31 UTC (rev 216618)
+++ trunk/LayoutTests/animations/animation-initial-inheritance-expected.html	2017-05-10 21:14:17 UTC (rev 216619)
@@ -1,23 +0,0 @@
-
-
-
-
-#test1 {
-visibility: hidden;
-}
-#test2 {
-color: green;
-}
-
-
-
-
-This shouldn't be initially visible
-This shouldn't be initially visible
-
-
-This should be initially green
-This should be initially green
-
-
-


Deleted: trunk/LayoutTests/animations/animation-initial-inheritance.html (216618 => 216619)

--- trunk/LayoutTests/animations/animation-initial-inheritance.html	2017-05-10 21:11:31 UTC (rev 216618)
+++ trunk/LayoutTests/animations/animation-initial-inheritance.html	2017-05-10 21:14:17 UTC (rev 216619)
@@ -1,39 +0,0 @@
-
-
-
-
-#test1 {
-animation:test1 3s steps(1,end) 0s 1 normal both
-}
-#test2 {
-animation:test2 3s steps(1,end) 0s 1 normal both
-}
-@keyframes test1 {
-from {visibility: hidden}
-to {visibility: visible}
-}
-@keyframes test2 {
-from {color: green}
-to {color: red}
-}
-
-
-if (window.testRunner) {
-testRunner.waitUntilDone();
-requestAnimationFrame(() => {
-testRunner.notifyDone();
-});
-}
-
-
-
-
-This shouldn't be initially visible
-This shouldn't be initially visible
-
-
-This should be initially green
-This should be initially green
-
-
-


Modified: trunk/Source/WebCore/ChangeLog (216618 => 216619)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 21:11:31 UTC (rev 216618)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 21:14:17 UTC (rev 216619)
@@ -1,3 +1,16 @@
+2017-05-10  Ryan Haddad  
+
+Unreviewed, rolling out r216591.
+
+This change broke an internal build.
+
+Reverted changeset:
+
+"REGRESSION (r207372) Visibility property is not inherited
+when used in an animation"
+https://bugs.webkit.org/show_bug.cgi?id=171883
+http://trac.webkit.org/changeset/216591
+
 2017-05-10  Chris Dumez  
 
 Drop custom bindings code now window.open()


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (216618 => 216619)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2017-05-10 21:11:31 UTC (rev 216618)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2017-05-10 21:14:17 UTC (rev 216619)
@@ -102,7 +102,6 @@
 , m_baseTypeFlags(baseTypeFlags)
 , m_ancestorLineBoxDirty(false)
 , m_hasInitializedStyle(false)
-, m_hasInitialAnimatedStyle(false)
 , m_renderInlineAlwaysCreatesLineBoxes(false)
 , m_renderBoxNeedsLazyRepaint(false)
 , m_hasPausedImageAnimations(false)


Modified: trunk/Source/WebCore/rendering/RenderElement.h (216618 => 216619)

--- trunk/Source/WebCore/rendering/RenderElement.h	2017-05-10 21:11:31 UTC (rev 216618)
+++ trunk/Source/WebCore/rendering/RenderElement.h	2017-05-10 21:14:17 UTC (rev 216619)
@@ -133,9 +133,6 @@
 // and so only should be called when the style is known not to have changed (or from setStyle).
 void setStyleInternal(RenderStyle&& style) { m_style = WTFMove(style); }
 
-bool hasInitialAnimatedStyle() const { return m_hasInitialAnimatedStyle; }
-void setHasInitialAnimatedStyle(bool b) { m_hasInitialAnimatedStyle 

[webkit-changes] [216618] trunk/LayoutTests

[ryanhaddad]

Title: [216618] trunk/LayoutTests








Revision 216618
Author ryanhad...@apple.com
Date 2017-05-10 14:11:31 -0700 (Wed, 10 May 2017)


Log Message
Unreviewed, remove TestExpectation for a test that was removed in r216259.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216617 => 216618)

--- trunk/LayoutTests/ChangeLog	2017-05-10 21:02:50 UTC (rev 216617)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 21:11:31 UTC (rev 216618)
@@ -1,3 +1,9 @@
+2017-05-10  Ryan Haddad  
+
+Unreviewed, remove TestExpectation for a test that was removed in r216259.
+
+* platform/mac/TestExpectations:
+
 2017-05-10  Matt Lewis  
 
 Marked perf/class-list-remove.html as flaky.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (216617 => 216618)

--- trunk/LayoutTests/platform/mac/TestExpectations	2017-05-10 21:02:50 UTC (rev 216617)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-05-10 21:11:31 UTC (rev 216618)
@@ -400,8 +400,6 @@
 editing/mac/pasteboard/dataTransfer-set-data-file-url.html [ Skip ]
 webkit.org/b/147674 editing/mac/pasteboard/5583362.html [ Skip ]
 
-webkit.org/b/112620 [ Debug ] svg/custom/image-with-attr-change-after-delete-crash.html [ Crash Pass ]
-
 # Assorted failures that need investigation
 
 webkit.org/b/107118 fast/canvas/canvas-quadratic-same-endpoint.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216617] trunk/LayoutTests

[jlewis3]

Title: [216617] trunk/LayoutTests








Revision 216617
Author jlew...@apple.com
Date 2017-05-10 14:02:50 -0700 (Wed, 10 May 2017)


Log Message
Marked perf/class-list-remove.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171945

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216616 => 216617)

--- trunk/LayoutTests/ChangeLog	2017-05-10 20:52:39 UTC (rev 216616)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 21:02:50 UTC (rev 216617)
@@ -1,3 +1,12 @@
+2017-05-10  Matt Lewis  
+
+Marked perf/class-list-remove.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171945
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2017-05-10  Andy Estes  
 
 r216599 accidentally included two copies of the new layout test and expected result


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216616 => 216617)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-10 20:52:39 UTC (rev 216616)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-10 21:02:50 UTC (rev 216617)
@@ -1979,3 +1979,5 @@
 webkit.org/b/171899 webrtc/libwebrtc/release-while-setting-local-description.html [ Pass Failure ]
 
 webkit.org/b/171930 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html [ Pass Failure ]
+
+webkit.org/b/171945 [ Debug ] perf/class-list-remove.html [ Pass Failure Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216616] trunk/Source/WebKit2

[achristensen]

Title: [216616] trunk/Source/WebKit2








Revision 216616
Author achristen...@apple.com
Date 2017-05-10 13:52:39 -0700 (Wed, 10 May 2017)


Log Message
Include headers in WebKit.h
https://bugs.webkit.org/show_bug.cgi?id=171943

Reviewed by Dan Bernstein.

* Shared/API/Cocoa/WebKit.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/Cocoa/WebKit.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216615 => 216616)

--- trunk/Source/WebKit2/ChangeLog	2017-05-10 20:50:01 UTC (rev 216615)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-10 20:52:39 UTC (rev 216616)
@@ -1,3 +1,12 @@
+2017-05-10  Alex Christensen  
+
+Include headers in WebKit.h
+https://bugs.webkit.org/show_bug.cgi?id=171943
+
+Reviewed by Dan Bernstein.
+
+* Shared/API/Cocoa/WebKit.h:
+
 2017-05-10  Timothy Horton  
 
 Disable block selection for dynamic selection granularity


Modified: trunk/Source/WebKit2/Shared/API/Cocoa/WebKit.h (216615 => 216616)

--- trunk/Source/WebKit2/Shared/API/Cocoa/WebKit.h	2017-05-10 20:50:01 UTC (rev 216615)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/WebKit.h	2017-05-10 20:52:39 UTC (rev 216616)
@@ -30,6 +30,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -44,6 +45,8 @@
 #import 
 #import 
 #import 
+#import 
+#import 
 #import 
 #import 
 #import 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216615] trunk/Source/WebCore

[cdumez]

Title: [216615] trunk/Source/WebCore








Revision 216615
Author cdu...@apple.com
Date 2017-05-10 13:50:01 -0700 (Wed, 10 May 2017)


Log Message
Drop custom bindings code now window.open()
https://bugs.webkit.org/show_bug.cgi?id=171933

Reviewed by Geoffrey Garen.

Drop custom bindings code now window.open() as it is not doing anything special.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::open): Deleted.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* testing/Internals.cpp:
(WebCore::Internals::openDummyInspectorFrontend):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/DOMWindow.h
trunk/Source/WebCore/page/DOMWindow.idl
trunk/Source/WebCore/testing/Internals.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216614 => 216615)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 20:44:37 UTC (rev 216614)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 20:50:01 UTC (rev 216615)
@@ -1,3 +1,21 @@
+2017-05-10  Chris Dumez  
+
+Drop custom bindings code now window.open()
+https://bugs.webkit.org/show_bug.cgi?id=171933
+
+Reviewed by Geoffrey Garen.
+
+Drop custom bindings code now window.open() as it is not doing anything special.
+
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::JSDOMWindow::open): Deleted.
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::open):
+* page/DOMWindow.h:
+* page/DOMWindow.idl:
+* testing/Internals.cpp:
+(WebCore::Internals::openDummyInspectorFrontend):
+
 2017-05-10  Tim Horton  
 
 Add an experimental feature flag for constant properties


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (216614 => 216615)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2017-05-10 20:44:37 UTC (rev 216614)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2017-05-10 20:50:01 UTC (rev 216615)
@@ -462,25 +462,6 @@
 
 // Custom functions
 
-JSValue JSDOMWindow::open(ExecState& state)
-{
-VM& vm = state.vm();
-auto scope = DECLARE_THROW_SCOPE(vm);
-
-String urlString = convert(state, state.argument(0));
-RETURN_IF_EXCEPTION(scope, JSValue());
-JSValue targetValue = state.argument(1);
-AtomicString target = targetValue.isUndefinedOrNull() ? AtomicString("_blank", AtomicString::ConstructFromLiteral) : targetValue.toString()->toAtomicString();
-RETURN_IF_EXCEPTION(scope, JSValue());
-String windowFeaturesString = convert(state, state.argument(2));
-RETURN_IF_EXCEPTION(scope, JSValue());
-
-RefPtr openedWindow = wrapped().open(urlString, target, windowFeaturesString, activeDOMWindow(), firstDOMWindow());
-if (!openedWindow)
-return jsNull();
-return toJS(, openedWindow.get());
-}
-
 class DialogHandler {
 public:
 explicit DialogHandler(ExecState& exec)


Modified: trunk/Source/WebCore/page/DOMWindow.cpp (216614 => 216615)

--- trunk/Source/WebCore/page/DOMWindow.cpp	2017-05-10 20:44:37 UTC (rev 216614)
+++ trunk/Source/WebCore/page/DOMWindow.cpp	2017-05-10 20:50:01 UTC (rev 216615)
@@ -2227,7 +2227,7 @@
 return windowFeatures.noopener ? nullptr : newFrame;
 }
 
-RefPtr DOMWindow::open(const String& urlString, const AtomicString& frameName, const String& windowFeaturesString, DOMWindow& activeWindow, DOMWindow& firstWindow)
+RefPtr DOMWindow::open(DOMWindow& activeWindow, DOMWindow& firstWindow, const String& urlString, const AtomicString& frameName, const String& windowFeaturesString)
 {
 if (!isCurrentlyDisplayedInFrame())
 return nullptr;


Modified: trunk/Source/WebCore/page/DOMWindow.h (216614 => 216615)

--- trunk/Source/WebCore/page/DOMWindow.h	2017-05-10 20:44:37 UTC (rev 216614)
+++ trunk/Source/WebCore/page/DOMWindow.h	2017-05-10 20:50:01 UTC (rev 216615)
@@ -149,7 +149,7 @@
 void print();
 void stop();
 
-WEBCORE_EXPORT RefPtr open(const String& urlString, const AtomicString& frameName, const String& windowFeaturesString, DOMWindow& activeWindow, DOMWindow& firstWindow);
+WEBCORE_EXPORT RefPtr open(DOMWindow& activeWindow, DOMWindow& firstWindow, const String& urlString, const AtomicString& frameName, const String& windowFeaturesString);
 
 void showModalDialog(const String& urlString, const String& dialogFeaturesString, DOMWindow& activeWindow, DOMWindow& firstWindow, std::function prepareDialogFunction);
 


Modified: trunk/Source/WebCore/page/DOMWindow.idl (216614 => 216615)

--- trunk/Source/WebCore/page/DOMWindow.idl	2017-05-10 20:44:37 UTC (rev 216614)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2017-05-10 20:50:01 UTC (rev 216615)
@@ -76,7 +76,7 @@
 [Replaceable, DoNotCheckSecurityOnGetter] readonly attribute DOMWindow? opener;
 [Replaceable, DoNotCheckSecurityOnGetter] readonly 

[webkit-changes] [216614] trunk/LayoutTests

[aestes]

Title: [216614] trunk/LayoutTests








Revision 216614
Author aes...@apple.com
Date 2017-05-10 13:44:37 -0700 (Wed, 10 May 2017)


Log Message
r216599 accidentally included two copies of the new layout test and expected result
https://bugs.webkit.org/show_bug.cgi?id=171938

Unreviewed.


* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt
trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216613 => 216614)

--- trunk/LayoutTests/ChangeLog	2017-05-10 20:41:52 UTC (rev 216613)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 20:44:37 UTC (rev 216614)
@@ -1,3 +1,13 @@
+2017-05-10  Andy Estes  
+
+r216599 accidentally included two copies of the new layout test and expected result
+https://bugs.webkit.org/show_bug.cgi?id=171938
+
+Unreviewed.
+
+* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
+* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html:
+
 2017-05-10  Ryan Haddad  
 
 Skip http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html on ios-simulator.


Modified: trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt (216613 => 216614)

--- trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt	2017-05-10 20:41:52 UTC (rev 216613)
+++ trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt	2017-05-10 20:44:37 UTC (rev 216614)
@@ -36,41 +36,3 @@
 CONSOLE MESSAGE: line 5: compositionendevent dispatched (isTrusted: true).
 CONSOLE MESSAGE: line 48: Input element value after text input events: "ac".
 
-CONSOLE MESSAGE: line 16: Provisional navigation started.
-CONSOLE MESSAGE: line 17: No trusted events should be logged and the input element should have the value "".
-CONSOLE MESSAGE: line 20: Dispatching untrusted keypress event.
-CONSOLE MESSAGE: line 5: keypressevent dispatched (isTrusted: false).
-CONSOLE MESSAGE: line 28: Pressing tab.
-CONSOLE MESSAGE: line 30: Active element after pressing tab: [object HTMLInputElement].
-CONSOLE MESSAGE: line 32: Pressing "a".
-CONSOLE MESSAGE: line 38: Input element value after text input events: "".
-CONSOLE MESSAGE: line 20: Pressing "z" with access key modifiers should navigate to resources/keyboard-events-after-navigation.html.
-CONSOLE MESSAGE: line 6: Finished navigating to resources/keyboard-events-after-navigation.html.
-CONSOLE MESSAGE: line 7: Trusted events should be logged and the input element should have the value "ac".
-CONSOLE MESSAGE: line 20: Dispatching untrusted keypress event.
-CONSOLE MESSAGE: line 5: keypressevent dispatched (isTrusted: false).
-CONSOLE MESSAGE: line 28: Pressing tab.
-CONSOLE MESSAGE: line 5: keydownevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: keyupevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 30: Active element after pressing tab: [object HTMLInputElement].
-CONSOLE MESSAGE: line 32: Pressing "a".
-CONSOLE MESSAGE: line 5: keydownevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: keypressevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: textInputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: beforeinputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: inputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: keyupevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 42: Setting marked text to "b".
-CONSOLE MESSAGE: line 5: compositionstartevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: compositionupdateevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: beforeinputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: inputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 45: Inserting text "c".
-CONSOLE MESSAGE: line 5: beforeinputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: inputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: textInputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: beforeinputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: inputevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 5: compositionendevent dispatched (isTrusted: true).
-CONSOLE MESSAGE: line 48: Input element value after text input events: "ac".
-


Modified: trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html (216613 => 216614)

--- 

[webkit-changes] [216613] trunk/LayoutTests

[ryanhaddad]

Title: [216613] trunk/LayoutTests








Revision 216613
Author ryanhad...@apple.com
Date 2017-05-10 13:41:52 -0700 (Wed, 10 May 2017)


Log Message
Skip http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=171880

Unreviewed test gardening.

This test times out on ios-simulator because it relies on eventSender.keyDown.

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216612 => 216613)

--- trunk/LayoutTests/ChangeLog	2017-05-10 20:29:27 UTC (rev 216612)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 20:41:52 UTC (rev 216613)
@@ -1,3 +1,14 @@
+2017-05-10  Ryan Haddad  
+
+Skip http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html on ios-simulator.
+https://bugs.webkit.org/show_bug.cgi?id=171880
+
+Unreviewed test gardening.
+
+This test times out on ios-simulator because it relies on eventSender.keyDown.
+
+* platform/ios/TestExpectations:
+
 2017-05-10  Timothy Horton  
 
 Add an experimental feature flag for constant properties


Modified: trunk/LayoutTests/platform/ios/TestExpectations (216612 => 216613)

--- trunk/LayoutTests/platform/ios/TestExpectations	2017-05-10 20:29:27 UTC (rev 216612)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2017-05-10 20:41:52 UTC (rev 216613)
@@ -377,6 +377,7 @@
 fast/events/keyboardevent-key.html [ Skip ]
 fast/events/keyboardevent-code.html [ Skip ]
 http/tests/navigation/keyboard-events-during-provisional-navigation.html [ Skip ]
+http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html [ Skip ]
 media/audio-dealloc-crash.html [ Skip ]
 
 # Tests that use EventSender's mouseMoveTo, mouseUp and mouseDown






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216612] trunk/Source/WebKit2

[timothy_horton]

Title: [216612] trunk/Source/WebKit2








Revision 216612
Author timothy_hor...@apple.com
Date 2017-05-10 13:29:27 -0700 (Wed, 10 May 2017)


Log Message
Disable block selection for dynamic selection granularity
https://bugs.webkit.org/show_bug.cgi?id=171908


Reviewed by Enrica Casucci.

* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowsBlockSelection]):
(-[WKWebViewConfiguration _setAllowsBlockSelection:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Add a private configuration parameter to re-enable block selection.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allowsBlockSelection]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/Cocoa/VersionChecks.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::allowsBlockSelection):
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
Plumb allowsBlockSelection through from WKWebViewConfiguration to WebPage.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView useSelectionAssistantWithGranularity:]):
(-[WKContentView _startAssistingKeyboard]):
(-[WKContentView _stopAssistingKeyboard]):
(toUIWebSelectionMode): Deleted.
(-[WKContentView useSelectionAssistantWithMode:]): Deleted.
Stop needlessly converting to UIWebSelectionMode.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::shouldSwitchToBlockModeForHandle):
Don't switch to block selection unless allowsBlockSelection is set.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp
trunk/Source/WebKit2/Shared/WebPageCreationParameters.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h
trunk/Source/WebKit2/UIProcess/Cocoa/VersionChecks.h
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216611 => 216612)

--- trunk/Source/WebKit2/ChangeLog	2017-05-10 20:26:59 UTC (rev 216611)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-10 20:29:27 UTC (rev 216612)
@@ -1,3 +1,50 @@
+2017-05-10  Timothy Horton  
+
+Disable block selection for dynamic selection granularity
+https://bugs.webkit.org/show_bug.cgi?id=171908
+
+
+Reviewed by Enrica Casucci.
+
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration init]):
+(-[WKWebViewConfiguration copyWithZone:]):
+(-[WKWebViewConfiguration _allowsBlockSelection]):
+(-[WKWebViewConfiguration _setAllowsBlockSelection:]):
+* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
+Add a private configuration parameter to re-enable block selection.
+
+* Shared/WebPageCreationParameters.cpp:
+(WebKit::WebPageCreationParameters::encode):
+(WebKit::WebPageCreationParameters::decode):
+* Shared/WebPageCreationParameters.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _allowsBlockSelection]):
+* UIProcess/API/Cocoa/WKWebViewInternal.h:
+* UIProcess/Cocoa/VersionChecks.h:
+* UIProcess/PageClient.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::creationParameters):
+* UIProcess/ios/PageClientImplIOS.h:
+* UIProcess/ios/PageClientImplIOS.mm:
+(WebKit::PageClientImpl::allowsBlockSelection):
+* WebProcess/WebPage/WebPage.cpp:
+* WebProcess/WebPage/WebPage.h:
+Plumb allowsBlockSelection through from WKWebViewConfiguration to WebPage.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView setupInteraction]):
+(-[WKContentView useSelectionAssistantWithGranularity:]):
+(-[WKContentView _startAssistingKeyboard]):
+(-[WKContentView _stopAssistingKeyboard]):
+(toUIWebSelectionMode): Deleted.
+(-[WKContentView useSelectionAssistantWithMode:]): Deleted.
+Stop needlessly converting to UIWebSelectionMode.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+

[webkit-changes] [216611] trunk

[timothy_horton]

Title: [216611] trunk








Revision 216611
Author timothy_hor...@apple.com
Date 2017-05-10 13:26:59 -0700 (Wed, 10 May 2017)


Log Message
Add an experimental feature flag for constant properties
https://bugs.webkit.org/show_bug.cgi?id=171913


Reviewed by Ryosuke Niwa.

* css/parser/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
* css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeCustomPropertyValue):
* css/parser/CSSParserMode.h:
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseValueStart):
* css/parser/CSSVariableParser.cpp:
(WebCore::classifyBlock):
(WebCore::isValidVariableReference):
(WebCore::isValidConstantReference):
(WebCore::classifyVariableRange):
(WebCore::CSSVariableParser::containsValidVariableReferences):
(WebCore::CSSVariableParser::parseDeclarationValue):
* css/parser/CSSVariableParser.h:
Plumb the experimental feature flag down into CSSVariableParser by way
of CSSParserContext.

* page/Settings.in:

* Shared/WebPreferencesDefinitions.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Add an experimental feature flag.

* fast/css/variables/constants/invalid-constant-name-fallback.html:
* fast/css/variables/constants/ios/safe-area-inset-set.html:
* fast/css/variables/constants/safe-area-inset-cannot-override.html:
* fast/css/variables/constants/safe-area-inset-zero.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/variables/constants/invalid-constant-name-fallback.html
trunk/LayoutTests/fast/css/variables/constants/ios/safe-area-inset-set.html
trunk/LayoutTests/fast/css/variables/constants/safe-area-inset-cannot-override.html
trunk/LayoutTests/fast/css/variables/constants/safe-area-inset-zero.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSParser.cpp
trunk/Source/WebCore/css/parser/CSSParserImpl.cpp
trunk/Source/WebCore/css/parser/CSSParserMode.h
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/css/parser/CSSVariableParser.cpp
trunk/Source/WebCore/css/parser/CSSVariableParser.h
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (216610 => 216611)

--- trunk/LayoutTests/ChangeLog	2017-05-10 20:16:14 UTC (rev 216610)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 20:26:59 UTC (rev 216611)
@@ -1,3 +1,16 @@
+2017-05-10  Timothy Horton  
+
+Add an experimental feature flag for constant properties
+https://bugs.webkit.org/show_bug.cgi?id=171913
+
+
+Reviewed by Ryosuke Niwa.
+
+* fast/css/variables/constants/invalid-constant-name-fallback.html:
+* fast/css/variables/constants/ios/safe-area-inset-set.html:
+* fast/css/variables/constants/safe-area-inset-cannot-override.html:
+* fast/css/variables/constants/safe-area-inset-zero.html:
+
 2017-05-10  Matt Lewis  
 
 Marked media/track/track-cue-rendering-on-resize.html as flaky.


Modified: trunk/LayoutTests/fast/css/variables/constants/invalid-constant-name-fallback.html (216610 => 216611)

--- trunk/LayoutTests/fast/css/variables/constants/invalid-constant-name-fallback.html	2017-05-10 20:16:14 UTC (rev 216610)
+++ trunk/LayoutTests/fast/css/variables/constants/invalid-constant-name-fallback.html	2017-05-10 20:26:59 UTC (rev 216611)
@@ -1,3 +1,7 @@
+
+if (window.internals)
+internals.settings.setConstantPropertiesEnabled(true);
+
 

[webkit-changes] [216610] trunk/Source/WebKit2

[dino]

Title: [216610] trunk/Source/WebKit2








Revision 216610
Author d...@apple.com
Date 2017-05-10 13:16:14 -0700 (Wed, 10 May 2017)


Log Message
Disable WebGL2 by default
https://bugs.webkit.org/show_bug.cgi?id=171894


Reviewed by Tim Horton.

Some WASM and WebGL2 content is failing because it
detects our WebGL2RenderingContext, but doesn't realise
that we don't implement enough of it to be useful.

* Shared/WebPreferencesDefinitions.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216609 => 216610)

--- trunk/Source/WebKit2/ChangeLog	2017-05-10 20:07:09 UTC (rev 216609)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-10 20:16:14 UTC (rev 216610)
@@ -1,3 +1,17 @@
+2017-05-09  Dean Jackson  
+
+Disable WebGL2 by default
+https://bugs.webkit.org/show_bug.cgi?id=171894
+
+
+Reviewed by Tim Horton.
+
+Some WASM and WebGL2 content is failing because it
+detects our WebGL2RenderingContext, but doesn't realise
+that we don't implement enough of it to be useful.
+
+* Shared/WebPreferencesDefinitions.h:
+
 2017-05-10  Matt Lewis  
 
 Unreviewed, rolling out r216563.


Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (216609 => 216610)

--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2017-05-10 20:07:09 UTC (rev 216609)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2017-05-10 20:16:14 UTC (rev 216610)
@@ -351,7 +351,7 @@
 macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "SubtleCrypto", "Enable SubtleCrypto support") \
 macro(UserTimingEnabled, userTimingEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "User Timing", "Enable UserTiming API") \
 macro(WebAnimationsEnabled, webAnimationsEnabled, Bool, bool, false, "Web Animations", "Web Animations prototype") \
-macro(WebGL2Enabled, webGL2Enabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "WebGL 2.0", "WebGL 2 prototype") \
+macro(WebGL2Enabled, webGL2Enabled, Bool, bool, false, "WebGL 2.0", "WebGL 2 prototype") \
 macro(WebGPUEnabled, webGPUEnabled, Bool, bool, false, "WebGPU", "WebGPU prototype") \
 \
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216609] trunk/LayoutTests

[jlewis3]

Title: [216609] trunk/LayoutTests








Revision 216609
Author jlew...@apple.com
Date 2017-05-10 13:07:09 -0700 (Wed, 10 May 2017)


Log Message
Marked media/track/track-cue-rendering-on-resize.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171939

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216608 => 216609)

--- trunk/LayoutTests/ChangeLog	2017-05-10 20:07:03 UTC (rev 216608)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 20:07:09 UTC (rev 216609)
@@ -1,3 +1,12 @@
+2017-05-10  Matt Lewis  
+
+Marked media/track/track-cue-rendering-on-resize.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171939
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2017-05-10  Ryan Haddad  
 
 Mark imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All tests as flaky.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216608 => 216609)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-10 20:07:03 UTC (rev 216608)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-10 20:07:09 UTC (rev 216609)
@@ -678,3 +678,5 @@
 webkit.org/b/171930 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html [ Pass Failure ]
 
 webkit.org/171935 [ Sierra ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html [ Pass Failure ]
+
+webkit.org/171939 [ Sierra Release ] media/track/track-cue-rendering-on-resize.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216608] trunk/Source/JavaScriptCore

[mark . lam]

Title: [216608] trunk/Source/_javascript_Core








Revision 216608
Author mark@apple.com
Date 2017-05-10 13:07:03 -0700 (Wed, 10 May 2017)


Log Message
Crash in _javascript_Core GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
https://bugs.webkit.org/show_bug.cgi?id=160337


Reviewed by Filip Pizlo and Geoffrey Garen.

This is a workaround for . During thread initialization,
for some target platforms, thread state is momentarily set to 0 before being
filled in with the target thread's real register values. As a result, there's
a race condition that may result in us getting a null stackPointer during a GC scan.
This issue may manifest with workqueue threads where the OS may choose to recycle
a thread for an expired task.

The workaround is simply to indicate that there's nothing to copy and return.
This is correct because we will only ever observe a null pointer during thread
initialization. Hence, by definition, there's nothing there that we need to scan
yet, and therefore, nothing that needs to be copied.

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::tryCopyOtherThreadStack):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216607 => 216608)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-10 19:52:21 UTC (rev 216607)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-10 20:07:03 UTC (rev 216608)
@@ -1,3 +1,26 @@
+2017-05-10  Mark Lam  
+
+Crash in _javascript_Core GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
+https://bugs.webkit.org/show_bug.cgi?id=160337
+
+
+Reviewed by Filip Pizlo and Geoffrey Garen.
+
+This is a workaround for . During thread initialization,
+for some target platforms, thread state is momentarily set to 0 before being
+filled in with the target thread's real register values. As a result, there's
+a race condition that may result in us getting a null stackPointer during a GC scan.
+This issue may manifest with workqueue threads where the OS may choose to recycle
+a thread for an expired task.
+
+The workaround is simply to indicate that there's nothing to copy and return.
+This is correct because we will only ever observe a null pointer during thread
+initialization. Hence, by definition, there's nothing there that we need to scan
+yet, and therefore, nothing that needs to be copied.
+
+* heap/MachineStackMarker.cpp:
+(JSC::MachineThreads::tryCopyOtherThreadStack):
+
 2017-05-10  JF Bastien  
 
 WebAssembly: support name section


Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (216607 => 216608)

--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp	2017-05-10 19:52:21 UTC (rev 216607)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp	2017-05-10 20:07:03 UTC (rev 216608)
@@ -311,6 +311,23 @@
 {
 MachineThread::Registers registers;
 size_t registersSize = thread->getRegisters(registers);
+
+// This is a workaround for . During thread initialization,
+// for some target platforms, thread state is momentarily set to 0 before being
+// filled in with the target thread's real register values. As a result, there's
+// a race condition that may result in us getting a null stackPointer.
+// This issue may manifest with workqueue threads where the OS may choose to recycle
+// a thread for an expired task.
+//
+// The workaround is simply to indicate that there's nothing to copy and return.
+// This is correct because we will only ever observe a null pointer during thread
+// initialization. Hence, by definition, there's nothing there that we need to scan
+// yet, and therefore, nothing that needs to be copied.
+if (UNLIKELY(!registers.stackPointer())) {
+*size = 0;
+return;
+}
+
 std::pair stack = thread->captureStack(registers.stackPointer());
 
 bool canCopy = *size + registersSize + stack.second <= capacity;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216607] trunk/Source/WebCore

[cdumez]

Title: [216607] trunk/Source/WebCore








Revision 216607
Author cdu...@apple.com
Date 2017-05-10 12:52:21 -0700 (Wed, 10 May 2017)


Log Message
REGRESSION (r206960): Possible null pointer dereference under DOMSelection::getRangeAt()
https://bugs.webkit.org/show_bug.cgi?id=171925


Reviewed by Wenson Hsieh.

We have evidence that selection().firstRange() can return null in DOMSelection::getRangeAt().
When this happens, we now throw an INDEX_SIZE_ERR instead of dereferencing it.

I believe this can happen if the VisibleSelection is orphaned but not none, because
rangeCount() only checks for isNone() but VisibleSelection::firstRange() can return null
if isNoneOrOrphaned().

No new tests, I do not know how to reproduce.

* page/DOMSelection.cpp:
(WebCore::DOMSelection::getRangeAt):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DOMSelection.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216606 => 216607)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 19:41:06 UTC (rev 216606)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 19:52:21 UTC (rev 216607)
@@ -1,3 +1,23 @@
+2017-05-10  Chris Dumez  
+
+REGRESSION (r206960): Possible null pointer dereference under DOMSelection::getRangeAt()
+https://bugs.webkit.org/show_bug.cgi?id=171925
+
+
+Reviewed by Wenson Hsieh.
+
+We have evidence that selection().firstRange() can return null in DOMSelection::getRangeAt().
+When this happens, we now throw an INDEX_SIZE_ERR instead of dereferencing it.
+
+I believe this can happen if the VisibleSelection is orphaned but not none, because
+rangeCount() only checks for isNone() but VisibleSelection::firstRange() can return null
+if isNoneOrOrphaned().
+
+No new tests, I do not know how to reproduce.
+
+* page/DOMSelection.cpp:
+(WebCore::DOMSelection::getRangeAt):
+
 2017-05-10  Matt Rajca  
 
 DumpRenderTree crashed in com.apple.WebCore: std::optional::operator-> + 71 :: CRASHING TEST: fullscreen/video-controls-timeline.html


Modified: trunk/Source/WebCore/page/DOMSelection.cpp (216606 => 216607)

--- trunk/Source/WebCore/page/DOMSelection.cpp	2017-05-10 19:41:06 UTC (rev 216606)
+++ trunk/Source/WebCore/page/DOMSelection.cpp	2017-05-10 19:52:21 UTC (rev 216607)
@@ -304,7 +304,11 @@
 return Range::create(shadowAncestor->document(), container, offset, container, offset);
 }
 
-return m_frame->selection().selection().firstRange().releaseNonNull();
+auto firstRange = m_frame->selection().selection().firstRange();
+ASSERT(firstRange);
+if (!firstRange)
+return Exception { INDEX_SIZE_ERR };
+return firstRange.releaseNonNull();
 }
 
 void DOMSelection::removeAllRanges()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216606] trunk/LayoutTests

[ryanhaddad]

Title: [216606] trunk/LayoutTests








Revision 216606
Author ryanhad...@apple.com
Date 2017-05-10 12:41:06 -0700 (Wed, 10 May 2017)


Log Message
Mark imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All tests as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171937

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216605 => 216606)

--- trunk/LayoutTests/ChangeLog	2017-05-10 19:34:43 UTC (rev 216605)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 19:41:06 UTC (rev 216606)
@@ -1,3 +1,12 @@
+2017-05-10  Ryan Haddad  
+
+Mark imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All tests as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171937
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2017-05-10  Matt Lewis  
 
 Marked tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html as flaky.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (216605 => 216606)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-10 19:34:43 UTC (rev 216605)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-10 19:41:06 UTC (rev 216606)
@@ -373,3 +373,6 @@
 
 # This was a WK2-only fix.
 http/tests/css/filters-on-iframes.html [ Skip ]
+
+webkit.org/b/171937 imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht.xht [ Pass Failure ]
+webkit.org/b/171937 imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216605] branches/safari-603-branch/LayoutTests

[ryanhaddad]

Title: [216605] branches/safari-603-branch/LayoutTests








Revision 216605
Author ryanhad...@apple.com
Date 2017-05-10 12:34:43 -0700 (Wed, 10 May 2017)


Log Message
Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216604 => 216605)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 19:29:56 UTC (rev 216604)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 19:34:43 UTC (rev 216605)
@@ -1,3 +1,9 @@
+2017-05-10  Ryan Haddad  
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/TestExpectations:
+
 2017-05-09  Matthew Hanson  
 
 Cherry-pick r216352. rdar://problem/32057098


Modified: branches/safari-603-branch/LayoutTests/platform/ios-simulator/TestExpectations (216604 => 216605)

--- branches/safari-603-branch/LayoutTests/platform/ios-simulator/TestExpectations	2017-05-10 19:29:56 UTC (rev 216604)
+++ branches/safari-603-branch/LayoutTests/platform/ios-simulator/TestExpectations	2017-05-10 19:34:43 UTC (rev 216605)
@@ -2770,3 +2770,11 @@
 
 fast/media/video-element-in-details-collapse.html [ Skip ]
 webkit.org/b/167795 http/tests/security/bypassing-cors-checks-for-extension-urls.html [ Skip ]
+
+http/tests/cache/disk-cache/disk-cache-remove-several-pending-writes.html [ Failure ]
+http/tests/loading/preload-css-with-csp-nonce.html [ Failure ]
+imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html [ Failure ]
+imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html [ Failure ]
+media/media-fullscreen-loop-inline.html [ Failure ]
+editing/caret/emoji.html [ Timeout ]
+media/audio-dealloc-crash.html [ Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216604] trunk/LayoutTests

[jlewis3]

Title: [216604] trunk/LayoutTests








Revision 216604
Author jlew...@apple.com
Date 2017-05-10 12:29:56 -0700 (Wed, 10 May 2017)


Log Message
Marked tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171935

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216603 => 216604)

--- trunk/LayoutTests/ChangeLog	2017-05-10 19:24:07 UTC (rev 216603)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 19:29:56 UTC (rev 216604)
@@ -1,3 +1,12 @@
+2017-05-10  Matt Lewis  
+
+Marked tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171935
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2017-05-10  Andy Estes  
 
 Keyboard input suppression should extend to subframes


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216603 => 216604)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-10 19:24:07 UTC (rev 216603)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-10 19:29:56 UTC (rev 216604)
@@ -676,3 +676,5 @@
 webkit.org/b/171895 webrtc/audio-replace-track.html [ Pass Failure Timeout ]
 
 webkit.org/b/171930 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html [ Pass Failure ]
+
+webkit.org/171935 [ Sierra ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216603] trunk/Source/WebCore

[mrajca]

Title: [216603] trunk/Source/WebCore








Revision 216603
Author mra...@apple.com
Date 2017-05-10 12:24:07 -0700 (Wed, 10 May 2017)


Log Message
DumpRenderTree crashed in com.apple.WebCore: std::optional::operator-> + 71 :: CRASHING TEST: fullscreen/video-controls-timeline.html
https://bugs.webkit.org/show_bug.cgi?id=171932

Reviewed by Eric Carlson.

Explicitly initialize m_playbackWithoutUserGesture to "None".

* html/HTMLMediaElement.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (216602 => 216603)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 18:53:33 UTC (rev 216602)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 19:24:07 UTC (rev 216603)
@@ -1,3 +1,14 @@
+2017-05-10  Matt Rajca  
+
+DumpRenderTree crashed in com.apple.WebCore: std::optional::operator-> + 71 :: CRASHING TEST: fullscreen/video-controls-timeline.html
+https://bugs.webkit.org/show_bug.cgi?id=171932
+
+Reviewed by Eric Carlson.
+
+Explicitly initialize m_playbackWithoutUserGesture to "None".
+
+* html/HTMLMediaElement.h:
+
 2017-05-10  Andy Estes  
 
 Keyboard input suppression should extend to subframes


Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (216602 => 216603)

--- trunk/Source/WebCore/html/HTMLMediaElement.h	2017-05-10 18:53:33 UTC (rev 216602)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h	2017-05-10 19:24:07 UTC (rev 216603)
@@ -1020,7 +1020,7 @@
 bool m_haveVisibleTextTrack : 1;
 bool m_processingPreferenceChange : 1;
 
-PlaybackWithoutUserGesture m_playbackWithoutUserGesture;
+PlaybackWithoutUserGesture m_playbackWithoutUserGesture { PlaybackWithoutUserGesture::None };
 std::optional m_playbackWithoutUserGestureStartedTime;
 
 String m_subtitleTrackLanguage;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216602] trunk/Source/WebInspectorUI

[commit-queue]

Title: [216602] trunk/Source/WebInspectorUI








Revision 216602
Author commit-qu...@webkit.org
Date 2017-05-10 11:53:33 -0700 (Wed, 10 May 2017)


Log Message
Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub
https://bugs.webkit.org/show_bug.cgi?id=171907

Patch by Ross Kirsling  on 2017-05-10
Reviewed by Joseph Pecoraro.

* UserInterface/Base/InspectorFrontendHostStub.js:
(WebInspector.InspectorFrontendHostStub.prototype.copyText):
Actually make a text selection before attempting to copy to clipboard.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (216601 => 216602)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-05-10 18:43:41 UTC (rev 216601)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-05-10 18:53:33 UTC (rev 216602)
@@ -1,3 +1,14 @@
+2017-05-10  Ross Kirsling  
+
+Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub
+https://bugs.webkit.org/show_bug.cgi?id=171907
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Base/InspectorFrontendHostStub.js:
+(WebInspector.InspectorFrontendHostStub.prototype.copyText):
+Actually make a text selection before attempting to copy to clipboard.
+
 2017-05-09  Joseph Pecoraro  
 
 Web Inspector: Provide resource load error reason text in details sidebar


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js (216601 => 216602)

--- trunk/Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js	2017-05-10 18:43:41 UTC (rev 216601)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js	2017-05-10 18:53:33 UTC (rev 216602)
@@ -121,9 +121,15 @@
 
 copyText: function(text)
 {
-this._textToCopy = text;
+let textarea = document.createElement("textarea");
+textarea.textContent = text;
+document.body.appendChild(textarea);
+textarea.select();
+
 if (!document.execCommand("copy"))
-console.error("Clipboard access is denied");
+console.error("Could not copy to clipboard.");
+
+document.body.removeChild(textarea);
 },
 
 killText: function(text, shouldStartNewSequence)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216601] branches/safari-603-branch

[matthew_hanson]

Title: [216601] branches/safari-603-branch








Revision 216601
Author matthew_han...@apple.com
Date 2017-05-10 11:43:41 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r216352. rdar://problem/32057098

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/page/FrameView.cpp
branches/safari-603-branch/Source/WebCore/page/FrameView.h
branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/UIProcess/WebPageProxy.h
branches/safari-603-branch/Source/WebKit2/UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm
branches/safari-603-branch/Source/WebKit2/UIProcess/ios/WKContentView.mm
branches/safari-603-branch/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm
branches/safari-603-branch/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm
branches/safari-603-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm


Added Paths

branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/
branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-rotation-expected.txt
branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-rotation.html
branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt
branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html
branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/resources/
branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/resources/rotation-utils.js




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216600 => 216601)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 18:43:35 UTC (rev 216600)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 18:43:41 UTC (rev 216601)
@@ -1,5 +1,30 @@
 2017-05-09  Matthew Hanson  
 
+Cherry-pick r216352. rdar://problem/32057098
+
+2017-05-07  Simon Fraser  
+
+[iOS] REGRESSION (r209409): getBoundingClientRect is wrong for fixed-position elements in resize/orientationchange
+https://bugs.webkit.org/show_bug.cgi?id=171140
+
+Reviewed by Sam Weinig.
+
+Tests that fetch the dimensions of a fixed element in resize and orientationchange handlers,
+which is a proxy for reading the layout viewport.
+
+* fast/events/ios/rotation/layout-viewport-during-rotation-expected.txt: Added.
+* fast/events/ios/rotation/layout-viewport-during-rotation.html: Added.
+* fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt: Added.
+* fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html: Added.
+* fast/events/ios/rotation/resources/rotation-utils.js: Added.
+(stringFromRect):
+(accumulateLog):
+(logFixedObject):
+(logFixedAndViewports):
+(doTest):
+
+2017-05-09  Matthew Hanson  
+
 Cherry-pick r211379. rdar://problem/32057099
 
 2017-01-30  Simon Fraser  


Added: branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-rotation-expected.txt (0 => 216601)

--- branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-rotation-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-rotation-expected.txt	2017-05-10 18:43:41 UTC (rev 216601)
@@ -0,0 +1,20 @@
+Before rotation
+layoutViewport: 0, 0 - 320 x 548
+visualViewport: 0, 0 - 320 x 548
+client rect of fixed object:0, 0 - 320 x 548
+
+In orientationchange event handler:
+layoutViewport: 0, 0 - 320 x 548
+visualViewport: 0, 0 - 320 x 548
+client rect of fixed object:0, 0 - 320 x 548
+
+In resize event handler:
+layoutViewport: 0, 0 - 568 x 320
+visualViewport: 0, 0 - 568 x 320
+client rect of fixed object:0, 0 - 568 x 320
+
+After rotation
+layoutViewport: 0, 0 - 568 x 320
+visualViewport: 0, 0 - 568 x 320
+client rect of fixed object:0, 0 - 568 x 320
+


Added: branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-rotation.html (0 => 216601)

--- branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-rotation.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/events/ios/rotation/layout-viewport-during-rotation.html	2017-05-10 18:43:41 UTC (rev 216601)
@@ -0,0 +1,54 @@
+ 
+
+
+
+
+
+body {
+height: 2000px;
+}
+
+#extent {
+position: fixed;
+border: 10px solid rgba(0, 0, 128, 0.5);
+top: 0;
+left: 0;
+bottom: 0;
+ 

[webkit-changes] [216600] branches/safari-603-branch

[matthew_hanson]

Title: [216600] branches/safari-603-branch








Revision 216600
Author matthew_han...@apple.com
Date 2017-05-10 11:43:35 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r211379. rdar://problem/32057099

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/TestExpectations
branches/safari-603-branch/LayoutTests/platform/ios-simulator-wk2/TestExpectations
branches/safari-603-branch/LayoutTests/platform/mac-wk2/TestExpectations
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/page/FrameView.cpp
branches/safari-603-branch/Source/WebCore/page/FrameView.h
branches/safari-603-branch/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
branches/safari-603-branch/Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.cpp
branches/safari-603-branch/Source/WebCore/platform/ScrollView.cpp
branches/safari-603-branch/Source/WebCore/platform/ScrollView.h
branches/safari-603-branch/Source/WebCore/testing/InternalSettings.cpp
branches/safari-603-branch/Source/WebCore/testing/InternalSettings.h
branches/safari-603-branch/Source/WebCore/testing/InternalSettings.idl
branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm


Added Paths

branches/safari-603-branch/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects-expected.txt
branches/safari-603-branch/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt
branches/safari-603-branch/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html
branches/safari-603-branch/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects.html
branches/safari-603-branch/LayoutTests/platform/ios-simulator-wk2/fast/visual-viewport/rubberbanding-viewport-rects-expected.txt
branches/safari-603-branch/LayoutTests/platform/ios-simulator-wk2/fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216599 => 216600)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 18:30:57 UTC (rev 216599)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 18:43:35 UTC (rev 216600)
@@ -1,3 +1,30 @@
+2017-05-09  Matthew Hanson  
+
+Cherry-pick r211379. rdar://problem/32057099
+
+2017-01-30  Simon Fraser  
+
+Fixed elements should not rubber-band in WK2, nor remain at negative offsets
+https://bugs.webkit.org/show_bug.cgi?id=167484
+rdar://problem/29453068
+
+Reviewed by Dean Jackson.
+
+Add two tests that use internals.settings.setAllowUnclampedScrollPosition(true) and then
+over-scroll to simulator rubber-banding, dumping viewport rects.
+
+setAllowUnclampedScrollPosition() only works in WebKit2, so skip the tests elsewhere.
+
+* TestExpectations:
+* fast/visual-viewport/rubberbanding-viewport-rects-expected.txt: Added.
+* fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt: Added.
+* fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html: Added.
+* fast/visual-viewport/rubberbanding-viewport-rects.html: Added.
+* platform/ios-simulator-wk2/TestExpectations:
+* platform/ios-simulator-wk2/fast/visual-viewport/rubberbanding-viewport-rects-expected.txt: Added.
+* platform/ios-simulator-wk2/fast/visual-viewport/rubberbanding-viewport-rects-header-footer-expected.txt: Added.
+* platform/mac-wk2/TestExpectations:
+
 2017-05-09  Jason Marcell  
 
 Cherry-pick r216443. rdar://problem/31971375


Modified: branches/safari-603-branch/LayoutTests/TestExpectations (216599 => 216600)

--- branches/safari-603-branch/LayoutTests/TestExpectations	2017-05-10 18:30:57 UTC (rev 216599)
+++ branches/safari-603-branch/LayoutTests/TestExpectations	2017-05-10 18:43:35 UTC (rev 216600)
@@ -92,6 +92,10 @@
 # ApplePay is only available on iOS (greater than iOS 10) and macOS (greater than macOS 10.12) and only for WebKit2.
 http/tests/ssl/applepay/ [ Skip ]
 
+# Only WK2 allows unconstrained scrolling
+fast/visual-viewport/rubberbanding-viewport-rects.html [ Skip ]
+fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html  [ Skip ]
+
 #//
 # End platform-specific tests.
 #//


Added: branches/safari-603-branch/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects-expected.txt (0 => 216600)

--- branches/safari-603-branch/LayoutTests/fast/visual-viewport/rubberbanding-viewport-rects-expected.txt	(rev 0)
+++ 

[webkit-changes] [216599] trunk

[aestes]

Title: [216599] trunk








Revision 216599
Author aes...@apple.com
Date 2017-05-10 11:30:57 -0700 (Wed, 10 May 2017)


Log Message
Keyboard input suppression should extend to subframes
https://bugs.webkit.org/show_bug.cgi?id=171880


Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html

* dom/EventDispatcher.cpp:
(WebCore::shouldSuppressEventDispatchInDOM): Changed to call shouldSuppressKeyboardInput()
on the main frame's loader.
* editing/Editor.cpp:
(WebCore::Editor::shouldInsertText): Ditto.

LayoutTests:

* http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
* http/tests/navigation/keyboard-events-during-provisional-navigation.html:
* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html.
* http/tests/navigation/resources/keyboard-events-after-navigation.html:
* http/tests/navigation/resources/keyboard-events-test.js:
(runTest):
(waitForProvisionalNavigation.xhr.onreadystatechange):
(waitForProvisionalNavigation):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt
trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html
trunk/LayoutTests/http/tests/navigation/resources/keyboard-events-after-navigation.html
trunk/LayoutTests/http/tests/navigation/resources/keyboard-events-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/editing/Editor.cpp


Added Paths

trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt
trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216598 => 216599)

--- trunk/LayoutTests/ChangeLog	2017-05-10 18:22:31 UTC (rev 216598)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 18:30:57 UTC (rev 216599)
@@ -1,3 +1,21 @@
+2017-05-10  Andy Estes  
+
+Keyboard input suppression should extend to subframes
+https://bugs.webkit.org/show_bug.cgi?id=171880
+
+
+Reviewed by Ryosuke Niwa.
+
+* http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
+* http/tests/navigation/keyboard-events-during-provisional-navigation.html:
+* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
+* http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html.
+* http/tests/navigation/resources/keyboard-events-after-navigation.html:
+* http/tests/navigation/resources/keyboard-events-test.js:
+(runTest):
+(waitForProvisionalNavigation.xhr.onreadystatechange):
+(waitForProvisionalNavigation):
+
 2017-05-10  Matt Lewis  
 
 Unreviewed, rolling out r216563.


Modified: trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt (216598 => 216599)

--- trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt	2017-05-10 18:22:31 UTC (rev 216598)
+++ trunk/LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt	2017-05-10 18:30:57 UTC (rev 216599)
@@ -1,23 +1,23 @@
-CONSOLE MESSAGE: line 30: Provisional navigation started.
-CONSOLE MESSAGE: line 31: No trusted events should be logged and the input element should have the value "".
-CONSOLE MESSAGE: line 18: Dispatching untrusted keypress event.
+CONSOLE MESSAGE: line 14: Provisional navigation started.
+CONSOLE MESSAGE: line 15: No trusted events should be logged and the input element should have the value "".
+CONSOLE MESSAGE: line 20: Dispatching untrusted keypress event.
 CONSOLE MESSAGE: line 5: keypressevent dispatched (isTrusted: false).
-CONSOLE MESSAGE: line 26: Pressing tab.
-CONSOLE MESSAGE: line 28: Active element after pressing tab: [object HTMLInputElement].
-CONSOLE MESSAGE: line 30: Pressing "a".
-CONSOLE MESSAGE: line 33: Setting marked text to "b".
-CONSOLE MESSAGE: line 36: Inserting text "c".
-CONSOLE MESSAGE: line 39: Input element value after text input events: "".
-CONSOLE MESSAGE: line 34: Pressing "z" with access key modifiers should navigate to resources/keyboard-events-after-navigation.html.
+CONSOLE MESSAGE: line 28: Pressing tab.
+CONSOLE MESSAGE: 

[webkit-changes] [216598] trunk/JSTests

[jfbastien]

Title: [216598] trunk/JSTests








Revision 216598
Author jfbast...@apple.com
Date 2017-05-10 11:22:31 -0700 (Wed, 10 May 2017)


Log Message
WebAssemby: builder doesn't do Memory section maximum correctly
https://bugs.webkit.org/show_bug.cgi?id=171931

Reviewed by Keith Miller.

* wasm/Builder.js:
(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):
* wasm/Builder_WebAssemblyBinary.js:
(const.emitters.Memory):
* wasm/function-tests/memory-grow-invalid.js: Added.

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/Builder.js
trunk/JSTests/wasm/Builder_WebAssemblyBinary.js


Added Paths

trunk/JSTests/wasm/function-tests/memory-grow-invalid.js




Diff

Modified: trunk/JSTests/ChangeLog (216597 => 216598)

--- trunk/JSTests/ChangeLog	2017-05-10 18:15:17 UTC (rev 216597)
+++ trunk/JSTests/ChangeLog	2017-05-10 18:22:31 UTC (rev 216598)
@@ -1,5 +1,18 @@
 2017-05-10  JF Bastien  
 
+WebAssemby: builder doesn't do Memory section maximum correctly
+https://bugs.webkit.org/show_bug.cgi?id=171931
+
+Reviewed by Keith Miller.
+
+* wasm/Builder.js:
+(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):
+* wasm/Builder_WebAssemblyBinary.js:
+(const.emitters.Memory):
+* wasm/function-tests/memory-grow-invalid.js: Added.
+
+2017-05-10  JF Bastien  
+
 WebAssembly: support name section
 https://bugs.webkit.org/show_bug.cgi?id=171263
 


Modified: trunk/JSTests/wasm/Builder.js (216597 => 216598)

--- trunk/JSTests/wasm/Builder.js	2017-05-10 18:15:17 UTC (rev 216597)
+++ trunk/JSTests/wasm/Builder.js	2017-05-10 18:22:31 UTC (rev 216598)
@@ -517,8 +517,8 @@
 const s = this._addSection(section);
 const memoryBuilder = {
 End: () => this,
-InitialMaxPages: (initial, max) => {
-s.data.push({ initial, max });
+InitialMaxPages: (initial, maximum) => {
+s.data.push({ initial, maximum });
 return _errorHandlingProxyFor(memoryBuilder);
 }
 };


Modified: trunk/JSTests/wasm/Builder_WebAssemblyBinary.js (216597 => 216598)

--- trunk/JSTests/wasm/Builder_WebAssemblyBinary.js	2017-05-10 18:15:17 UTC (rev 216597)
+++ trunk/JSTests/wasm/Builder_WebAssemblyBinary.js	2017-05-10 18:22:31 UTC (rev 216598)
@@ -154,12 +154,8 @@
 Memory: (section, bin) => {
 // Flags, currently can only be [0,1]
 put(bin, "varuint1", section.data.length);
-for (const memory of section.data) {
-put(bin, "varuint32", memory.max ? 1 : 0);
-put(bin, "varuint32", memory.initial);
-if (memory.max)
-put(bin, "varuint32", memory.max);
-}
+for (const memory of section.data)
+putResizableLimits(bin, memory.initial, memory.maximum);
 },
 
 Global: (section, bin) => {


Added: trunk/JSTests/wasm/function-tests/memory-grow-invalid.js (0 => 216598)

--- trunk/JSTests/wasm/function-tests/memory-grow-invalid.js	(rev 0)
+++ trunk/JSTests/wasm/function-tests/memory-grow-invalid.js	2017-05-10 18:22:31 UTC (rev 216598)
@@ -0,0 +1,29 @@
+import * as assert from '../assert.js';
+import Builder from '../Builder.js';
+
+const verbose = false;
+
+const initial = 0;
+const max = 0;
+
+const builder = (new Builder())
+.Type().End()
+.Function().End()
+.Memory().InitialMaxPages(initial, max).End()
+.Export().Function("current").Function("grow").End()
+.Code()
+.Function("current", { params: [], ret: "i32" }).CurrentMemory(0).Return().End()
+.Function("grow", { params: ["i32"], ret: "i32" }).GetLocal(0).GrowMemory(0).Return().End()
+.End();
+
+let instance = new WebAssembly.Instance(new WebAssembly.Module(builder.WebAssembly().get()));
+
+const current = instance.exports.current();
+const by = 2;
+const result = instance.exports.grow(current + by);
+if (verbose)
+print(`Grow from ${current} (max ${max}) to ${current + by} returned ${result}, current now ${instance.exports.current()}`);
+
+assert.eq(result, -1);
+assert.eq(current, instance.exports.current());
+assert.le(instance.exports.current(), max);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216597] trunk

[jfbastien]

Title: [216597] trunk








Revision 216597
Author jfbast...@apple.com
Date 2017-05-10 11:15:17 -0700 (Wed, 10 May 2017)


Log Message
WebAssembly: support name section
JSTests:

https://bugs.webkit.org/show_bug.cgi?id=171263

Reviewed by Keith Miller.

* wasm/function-tests/nameSection.js: Added.
(const.compile):
* wasm/function-tests/nameSection.wasm: Added.
* wasm/function-tests/stack-trace.js: Update format

Source/_javascript_Core:

https://bugs.webkit.org/show_bug.cgi?id=171263

Reviewed by Keith Miller.

The name section is an optional custom section in the WebAssembly
spec. At least when debugging, developers expect to be able to use
this section to obtain intelligible stack traces, otherwise we
just number the wasm functions which is somewhat painful.

This patch parses this section, dropping its content eagerly on
error, and if there is a name section then backtraces use their
value instead of numbers. Otherwise we stick to numbers as before.

Note that the format of name sections changed in mid-February:
  https://github.com/WebAssembly/design/pull/984
And binaryen was only updated in early March:
  https://github.com/WebAssembly/binaryen/pull/933

* CMakeLists.txt:
* _javascript_Core.xcodeproj/project.pbxproj:
* interpreter/Interpreter.cpp:
(JSC::GetStackTraceFunctor::operator()):
* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::Frame::functionName):
* interpreter/StackVisitor.h:
(JSC::StackVisitor::Frame::wasmFunctionIndexOrName):
* runtime/StackFrame.cpp:
(JSC::StackFrame::functionName):
* runtime/StackFrame.h:
(JSC::StackFrame::StackFrame):
(JSC::StackFrame::wasm):
* wasm/WasmBBQPlanInlines.h:
(JSC::Wasm::BBQPlan::initializeCallees):
* wasm/WasmCallee.cpp:
(JSC::Wasm::Callee::Callee):
* wasm/WasmCallee.h:
(JSC::Wasm::Callee::create):
(JSC::Wasm::Callee::indexOrName):
* wasm/WasmFormat.cpp:
(JSC::Wasm::makeString):
* wasm/WasmFormat.h:
(JSC::Wasm::isValidExternalKind):
(JSC::Wasm::isValidNameType):
(JSC::Wasm::NameSection::get):
* wasm/WasmIndexOrName.cpp: Copied from Source/_javascript_Core/wasm/WasmCallee.cpp.
(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):
* wasm/WasmIndexOrName.h: Copied from Source/_javascript_Core/wasm/WasmFormat.cpp.
* wasm/WasmModuleInformation.h:
* wasm/WasmModuleParser.cpp:
* wasm/WasmName.h: Copied from Source/_javascript_Core/wasm/WasmCallee.cpp.
* wasm/WasmNameSectionParser.cpp: Added.
* wasm/WasmNameSectionParser.h: Copied from Source/_javascript_Core/wasm/WasmCallee.cpp.
(JSC::Wasm::NameSectionParser::NameSectionParser):
* wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::work):
* wasm/WasmParser.h:
(JSC::Wasm::Parser::consumeUTF8String):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/function-tests/stack-trace.js
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp
trunk/Source/_javascript_Core/interpreter/StackVisitor.h
trunk/Source/_javascript_Core/runtime/StackFrame.cpp
trunk/Source/_javascript_Core/runtime/StackFrame.h
trunk/Source/_javascript_Core/wasm/WasmBBQPlanInlines.h
trunk/Source/_javascript_Core/wasm/WasmCallee.cpp
trunk/Source/_javascript_Core/wasm/WasmCallee.h
trunk/Source/_javascript_Core/wasm/WasmFormat.cpp
trunk/Source/_javascript_Core/wasm/WasmFormat.h
trunk/Source/_javascript_Core/wasm/WasmModuleInformation.h
trunk/Source/_javascript_Core/wasm/WasmModuleParser.cpp
trunk/Source/_javascript_Core/wasm/WasmOMGPlan.cpp
trunk/Source/_javascript_Core/wasm/WasmParser.h


Added Paths

trunk/JSTests/wasm/function-tests/nameSection.js
trunk/JSTests/wasm/function-tests/nameSection.wasm
trunk/Source/_javascript_Core/wasm/WasmIndexOrName.cpp
trunk/Source/_javascript_Core/wasm/WasmIndexOrName.h
trunk/Source/_javascript_Core/wasm/WasmName.h
trunk/Source/_javascript_Core/wasm/WasmNameSectionParser.cpp
trunk/Source/_javascript_Core/wasm/WasmNameSectionParser.h




Diff

Modified: trunk/JSTests/ChangeLog (216596 => 216597)

--- trunk/JSTests/ChangeLog	2017-05-10 17:30:19 UTC (rev 216596)
+++ trunk/JSTests/ChangeLog	2017-05-10 18:15:17 UTC (rev 216597)
@@ -1,3 +1,15 @@
+2017-05-10  JF Bastien  
+
+WebAssembly: support name section
+https://bugs.webkit.org/show_bug.cgi?id=171263
+
+Reviewed by Keith Miller.
+
+* wasm/function-tests/nameSection.js: Added.
+(const.compile):
+* wasm/function-tests/nameSection.wasm: Added.
+* wasm/function-tests/stack-trace.js: Update format
+
 2017-05-10  Filip Pizlo  
 
 Null pointer dereference in WTF::RefPtr::operator!() under slow_path_get_direct_pname


Added: trunk/JSTests/wasm/function-tests/nameSection.js (0 => 216597)

--- trunk/JSTests/wasm/function-tests/nameSection.js	(rev 0)
+++ 

[webkit-changes] [216596] trunk

[jlewis3]

Title: [216596] trunk








Revision 216596
Author jlew...@apple.com
Date 2017-05-10 10:30:19 -0700 (Wed, 10 May 2017)


Log Message
Unreviewed, rolling out r216563.

Revision caused 2 api failures

Reverted changeset:

"[MediaStream] deviceId constraint doesn't work with
getUserMedia"
https://bugs.webkit.org/show_bug.cgi?id=171877
http://trac.webkit.org/changeset/216563

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaConstraintsImpl.h
trunk/Source/WebCore/Modules/mediastream/MediaDevicesEnumerationRequest.cpp
trunk/Source/WebCore/Modules/mediastream/UserMediaController.h
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.h
trunk/Source/WebCore/platform/mediastream/MediaConstraints.h
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h
trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.cpp
trunk/Source/WebKit2/UIProcess/UserMediaPermissionCheckProxy.h
trunk/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp
trunk/Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.cpp


Removed Paths

trunk/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt
trunk/LayoutTests/fast/mediastream/get-user-media-device-id.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216595 => 216596)

--- trunk/LayoutTests/ChangeLog	2017-05-10 17:29:32 UTC (rev 216595)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 17:30:19 UTC (rev 216596)
@@ -1,5 +1,18 @@
 2017-05-10  Matt Lewis  
 
+Unreviewed, rolling out r216563.
+
+Revision caused 2 api failures
+
+Reverted changeset:
+
+"[MediaStream] deviceId constraint doesn't work with
+getUserMedia"
+https://bugs.webkit.org/show_bug.cgi?id=171877
+http://trac.webkit.org/changeset/216563
+
+2017-05-10  Matt Lewis  
+
 Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=171930
 


Deleted: trunk/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt (216595 => 216596)

--- trunk/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt	2017-05-10 17:29:32 UTC (rev 216595)
+++ trunk/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt	2017-05-10 17:30:19 UTC (rev 216596)
@@ -1,5 +0,0 @@
-
-PASS Collect device IDs 
-PASS Pass device IDs as exact constraints 
-PASS Pass device IDs as optional constraints 
-


Deleted: trunk/LayoutTests/fast/mediastream/get-user-media-device-id.html (216595 => 216596)

--- trunk/LayoutTests/fast/mediastream/get-user-media-device-id.html	2017-05-10 17:29:32 UTC (rev 216595)
+++ trunk/LayoutTests/fast/mediastream/get-user-media-device-id.html	2017-05-10 17:30:19 UTC (rev 216596)
@@ -1,56 +0,0 @@
-
-
-
-
-Test passing capture device IDs to getUserMedia
-
-let deviceIds = [];
-
-if (window.testRunner)
-testRunner.setUserMediaPermission(true);
-
-promise_test((test) => {
-return navigator.mediaDevices.enumerateDevices()
-.then((devices) => {
-devices.forEach((device) => {
-let kind = device.kind == "audioinput" ? "audio" : "video";
-deviceIds.push({ type: kind, id : device.deviceId});
-});
-});
-}, "Collect device IDs");
-
-let constraints = { };
-
-promise_test((test) => {
-deviceIds.forEach((info) => {
-constraints[info.type] = { deviceId: { exact: info.id } };
-});
-
-return navigator.mediaDevices.getUserMedia(constraints)
-.then((stream) => {
-assert_equals(stream.getAudioTracks().length, 1, "correct number of audio tracks");
-assert_equals(stream.getVideoTracks().length, 1, "correct number of audio tracks");
-})
-
-}, "Pass device IDs as exact constraints");
-
-promise_test((test) => {
-deviceIds.forEach((info) => {
-constraints[info.type] = { 

[webkit-changes] [216595] branches/safari-603-branch/Source/WebCore

[jmarcell]

Title: [216595] branches/safari-603-branch/Source/WebCore








Revision 216595
Author jmarc...@apple.com
Date 2017-05-10 10:29:32 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r215102. rdar://problem/32057110

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp
branches/safari-603-branch/Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216594 => 216595)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 17:16:58 UTC (rev 216594)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 17:29:32 UTC (rev 216595)
@@ -1,3 +1,27 @@
+2017-05-10  Jason Marcell  
+
+Cherry-pick r215102. rdar://problem/32057110
+
+2017-04-07  Alex Christensen  
+
+REGRESSION(r204512): WebSocket errors with "Failed to send WebSocket frame."  if too much data is sent
+https://bugs.webkit.org/show_bug.cgi?id=170463
+
+Reviewed by Michael Catanzaro.
+
+This only reproduces when using WebSockets to communicate with an external server.
+When communicating with a local server, CFWriteStreamWrite succeeds too reliably, so
+CFWriteStreamCanAcceptBytes returns true, when sometimes it doesn't when communicating
+across the real internet.
+
+* platform/network/cf/SocketStreamHandleImplCFNet.cpp:
+(WebCore::SocketStreamHandleImpl::platformSendInternal):
+* platform/network/soup/SocketStreamHandleImplSoup.cpp:
+(WebCore::SocketStreamHandleImpl::platformSendInternal):
+Returning std::nullopt means there was an error, which is not true when the socket stream
+is in a state where it cannot be written to because it is actively communicating.
+Returning 0 means 0 new bytes were sent, so we will try again later.
+
 2017-05-10  Matthew Hanson  
 
 Remove inadvertant change to ScrollView.h that was included in r216589.


Modified: branches/safari-603-branch/Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp (216594 => 216595)

--- branches/safari-603-branch/Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp	2017-05-10 17:16:58 UTC (rev 216594)
+++ branches/safari-603-branch/Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp	2017-05-10 17:29:32 UTC (rev 216595)
@@ -655,8 +655,11 @@
 
 std::optional SocketStreamHandleImpl::platformSend(const char* data, size_t length)
 {
+if (!m_writeStream)
+return 0;
+
 if (!CFWriteStreamCanAcceptBytes(m_writeStream.get()))
-return std::nullopt;
+return 0;
 
 CFIndex result = CFWriteStreamWrite(m_writeStream.get(), reinterpret_cast(data), length);
 if (result == -1)


Modified: branches/safari-603-branch/Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp (216594 => 216595)

--- branches/safari-603-branch/Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp	2017-05-10 17:16:58 UTC (rev 216594)
+++ branches/safari-603-branch/Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp	2017-05-10 17:29:32 UTC (rev 216595)
@@ -175,7 +175,7 @@
 {
 LOG(Network, "SocketStreamHandle %p platformSend", this);
 if (!m_outputStream || !data)
-return std::nullopt;
+return 0;
 
 GUniqueOutPtr error;
 gssize written = g_pollable_output_stream_write_nonblocking(m_outputStream.get(), data, length, m_cancellable.get(), ());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216594] trunk/LayoutTests

[jlewis3]

Title: [216594] trunk/LayoutTests








Revision 216594
Author jlew...@apple.com
Date 2017-05-10 10:16:58 -0700 (Wed, 10 May 2017)


Log Message
Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171930

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216593 => 216594)

--- trunk/LayoutTests/ChangeLog	2017-05-10 17:00:22 UTC (rev 216593)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 17:16:58 UTC (rev 216594)
@@ -1,3 +1,13 @@
+2017-05-10  Matt Lewis  
+
+Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171930
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2017-05-10  Antti Koivisto  
 
 REGRESSION (r207372) Visibility property is not inherited when used in an animation


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216593 => 216594)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-10 17:00:22 UTC (rev 216593)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-10 17:16:58 UTC (rev 216594)
@@ -1977,3 +1977,5 @@
 webkit.org/b/171886 imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html [ Pass Failure ]
 
 webkit.org/b/171899 webrtc/libwebrtc/release-while-setting-local-description.html [ Pass Failure ]
+
+webkit.org/b/171930 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216593 => 216594)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-10 17:00:22 UTC (rev 216593)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-10 17:16:58 UTC (rev 216594)
@@ -674,3 +674,5 @@
 webkit.org/b/170870 webrtc/captureCanvas-webrtc.html [ Pass Timeout ]
 
 webkit.org/b/171895 webrtc/audio-replace-track.html [ Pass Failure Timeout ]
+
+webkit.org/b/171930 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216593] trunk

[fpizlo]

Title: [216593] trunk








Revision 216593
Author fpi...@apple.com
Date 2017-05-10 10:00:22 -0700 (Wed, 10 May 2017)


Log Message
Null pointer dereference in WTF::RefPtr::operator!() under slow_path_get_direct_pname
https://bugs.webkit.org/show_bug.cgi?id=171801

Reviewed by Michael Saboff.

JSTests:

These tests used to crash. The prefix and postfix tests cover different paths, except
postfix-ignored goes down the same path as prefix due to an optimization.

* stress/for-in-postfix-ignored-index.js: Added.
(foo):
* stress/for-in-postfix-index.js: Added.
(foo):
* stress/for-in-prefix-index.js: Added.
(foo):

Source/_javascript_Core:

This was a goofy oversight. The for-in optimization relies on the bytecode generator
to detect when the loop's index variable gets mutated. We forgot to have the hooks for
detecting this in prefix and postfix operations (++i and i++).

* bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp


Added Paths

trunk/JSTests/stress/for-in-postfix-ignored-index.js
trunk/JSTests/stress/for-in-postfix-index.js
trunk/JSTests/stress/for-in-prefix-index.js




Diff

Modified: trunk/JSTests/ChangeLog (216592 => 216593)

--- trunk/JSTests/ChangeLog	2017-05-10 16:57:51 UTC (rev 216592)
+++ trunk/JSTests/ChangeLog	2017-05-10 17:00:22 UTC (rev 216593)
@@ -1,3 +1,20 @@
+2017-05-10  Filip Pizlo  
+
+Null pointer dereference in WTF::RefPtr::operator!() under slow_path_get_direct_pname
+https://bugs.webkit.org/show_bug.cgi?id=171801
+
+Reviewed by Michael Saboff.
+
+These tests used to crash. The prefix and postfix tests cover different paths, except
+postfix-ignored goes down the same path as prefix due to an optimization.
+
+* stress/for-in-postfix-ignored-index.js: Added.
+(foo):
+* stress/for-in-postfix-index.js: Added.
+(foo):
+* stress/for-in-prefix-index.js: Added.
+(foo):
+
 2017-05-08  Mark Lam  
 
 op_throw_static_error's use of its first operand should be reflected in DFG BytecodeUseDef as well.


Added: trunk/JSTests/stress/for-in-postfix-ignored-index.js (0 => 216593)

--- trunk/JSTests/stress/for-in-postfix-ignored-index.js	(rev 0)
+++ trunk/JSTests/stress/for-in-postfix-ignored-index.js	2017-05-10 17:00:22 UTC (rev 216593)
@@ -0,0 +1,14 @@
+//@ runDefault
+
+function foo(o) {
+var result = 0;
+for (var s in o) {
+s++;
+result += o[s];
+}
+return result;
+}
+
+var result = foo({f:42});
+if ("" + result != "NaN")
+throw "Error: bad result: " + result;


Added: trunk/JSTests/stress/for-in-postfix-index.js (0 => 216593)

--- trunk/JSTests/stress/for-in-postfix-index.js	(rev 0)
+++ trunk/JSTests/stress/for-in-postfix-index.js	2017-05-10 17:00:22 UTC (rev 216593)
@@ -0,0 +1,15 @@
+//@ runDefault
+
+function foo(o) {
+var result = 0;
+for (var s in o) {
+var tmp = s++;
+result += o[s];
+result += tmp;
+}
+return result;
+}
+
+var result = foo({f:42});
+if ("" + result != "NaN")
+throw "Error: bad result: " + result;


Added: trunk/JSTests/stress/for-in-prefix-index.js (0 => 216593)

--- trunk/JSTests/stress/for-in-prefix-index.js	(rev 0)
+++ trunk/JSTests/stress/for-in-prefix-index.js	2017-05-10 17:00:22 UTC (rev 216593)
@@ -0,0 +1,12 @@
+//@ runDefault
+
+function foo(o) {
+var result = 0;
+for (var s in o)
+result += o[--s];
+return result;
+}
+
+var result = foo({f:42});
+if ("" + result != "NaN")
+throw "Error: bad result: " + result;


Modified: trunk/Source/_javascript_Core/ChangeLog (216592 => 216593)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-10 16:57:51 UTC (rev 216592)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-10 17:00:22 UTC (rev 216593)
@@ -1,3 +1,18 @@
+2017-05-10  Filip Pizlo  
+
+Null pointer dereference in WTF::RefPtr::operator!() under slow_path_get_direct_pname
+https://bugs.webkit.org/show_bug.cgi?id=171801
+
+Reviewed by Michael Saboff.
+
+This was a goofy oversight. The for-in optimization relies on the bytecode generator
+to detect when the loop's index variable gets mutated. We forgot to have the hooks for
+detecting this in prefix and postfix operations (++i and i++).
+
+* bytecompiler/NodesCodegen.cpp:
+(JSC::PostfixNode::emitResolve):
+(JSC::PrefixNode::emitResolve):
+
 2017-05-10  Michael Catanzaro  
 
 [GTK] -Wmissing-field-initializers triggered by RemoteInspectorServer.cpp:128


Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (216592 => 216593)

--- 

[webkit-changes] [216592] trunk/Source/WebCore

[commit-queue]

Title: [216592] trunk/Source/WebCore








Revision 216592
Author commit-qu...@webkit.org
Date 2017-05-10 09:57:51 -0700 (Wed, 10 May 2017)


Log Message
Refactor ScrollingCoordinator::setSynchronousScrollingReasons to accept a FrameView
https://bugs.webkit.org/show_bug.cgi?id=171923

Patch by Frederic Wang  on 2017-05-10
Reviewed by Simon Fraser.

Currently ScrollingCoordinator::setSynchronousScrollingReasons implementations assumes
SynchronousScrollingReasons apply to the main frame. This commit allows to specify
a FrameView in order to prepare support for fast scrolling of frames.

No new tests, no behavior changes.

* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::setSynchronousScrollingReasons): Use the FrameView to
find the state node.
(WebCore::AsyncScrollingCoordinator::updateScrollLayerPosition): Rename this function
updateMainFrameScrollLayerPosition and use the specified FrameView.
* page/scrolling/AsyncScrollingCoordinator.h: Add FrameView parameter.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons): Remove the const since
AsyncScrollingCoordinator uses scrollLayerForFrameView. Pass the frameView to
setSynchronousScrollingReasons.
* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::setSynchronousScrollingReasons): Add FrameView parameter.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (216591 => 216592)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 16:50:56 UTC (rev 216591)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 16:57:51 UTC (rev 216592)
@@ -1,3 +1,29 @@
+2017-05-10  Frederic Wang  
+
+Refactor ScrollingCoordinator::setSynchronousScrollingReasons to accept a FrameView
+https://bugs.webkit.org/show_bug.cgi?id=171923
+
+Reviewed by Simon Fraser.
+
+Currently ScrollingCoordinator::setSynchronousScrollingReasons implementations assumes
+SynchronousScrollingReasons apply to the main frame. This commit allows to specify
+a FrameView in order to prepare support for fast scrolling of frames.
+
+No new tests, no behavior changes.
+
+* page/scrolling/AsyncScrollingCoordinator.cpp:
+(WebCore::AsyncScrollingCoordinator::setSynchronousScrollingReasons): Use the FrameView to
+find the state node.
+(WebCore::AsyncScrollingCoordinator::updateScrollLayerPosition): Rename this function
+updateMainFrameScrollLayerPosition and use the specified FrameView.
+* page/scrolling/AsyncScrollingCoordinator.h: Add FrameView parameter.
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons): Remove the const since
+AsyncScrollingCoordinator uses scrollLayerForFrameView. Pass the frameView to
+setSynchronousScrollingReasons.
+* page/scrolling/ScrollingCoordinator.h:
+(WebCore::ScrollingCoordinator::setSynchronousScrollingReasons): Add FrameView parameter.
+
 2017-05-10  Antti Koivisto  
 
 REGRESSION (r207372) Visibility property is not inherited when used in an animation


Modified: trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp (216591 => 216592)

--- trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp	2017-05-10 16:50:56 UTC (rev 216591)
+++ trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp	2017-05-10 16:57:51 UTC (rev 216592)
@@ -581,9 +581,10 @@
 }
 }
 
-void AsyncScrollingCoordinator::setSynchronousScrollingReasons(SynchronousScrollingReasons reasons)
+void AsyncScrollingCoordinator::setSynchronousScrollingReasons(FrameView& frameView, SynchronousScrollingReasons reasons)
 {
-if (!m_scrollingStateTree->rootStateNode())
+ScrollingStateFrameScrollingNode* scrollingStateNode = static_cast(m_scrollingStateTree->stateNodeForID(frameView.scrollLayerID()));
+if (!scrollingStateNode)
 return;
 
 // The FrameView's GraphicsLayer is likely to be out-of-synch with the PlatformLayer
@@ -590,23 +591,15 @@
 // at this point. So we'll update it before we switch back to main thread scrolling
 // in order to avoid layer positioning bugs.
 if (reasons)
-updateMainFrameScrollLayerPosition();
-m_scrollingStateTree->rootStateNode()->setSynchronousScrollingReasons(reasons);
+updateScrollLayerPosition(frameView);
+scrollingStateNode->setSynchronousScrollingReasons(reasons);
 }
 
-void AsyncScrollingCoordinator::updateMainFrameScrollLayerPosition()
+void 

[webkit-changes] [216591] trunk

[antti]

Title: [216591] trunk








Revision 216591
Author an...@apple.com
Date 2017-05-10 09:50:56 -0700 (Wed, 10 May 2017)


Log Message
REGRESSION (r207372) Visibility property is not inherited when used in an animation
https://bugs.webkit.org/show_bug.cgi?id=171883


Reviewed by Simon Fraser.

Source/WebCore:

The problem here is that our animation code is tied to renderers. We don't have renderers during
the initial style resolution so animations are not applied yet. When constructing renderers we set
their style to the initial animated style but this step can't implement inheritance.

Normally this is invisible as the first animation frame will immediately inherit the style correctly.
However in this case the animation is discrete and the first frame is the same as the initial state.
With r207372 we optimize the descendant style change away.

This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.

Test: animations/animation-initial-inheritance.html

* rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
* rendering/RenderElement.h:
(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createRenderer):

Set a bit on renderer indicating it has initial animated style.

* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Return at least 'Inherit' for style change when updating renderer with initial animated style.

LayoutTests:

* animations/animation-initial-inheritance-expected.html: Added.
* animations/animation-initial-inheritance.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/style/RenderTreeUpdater.cpp
trunk/Source/WebCore/style/StyleTreeResolver.cpp


Added Paths

trunk/LayoutTests/animations/animation-initial-inheritance-expected.html
trunk/LayoutTests/animations/animation-initial-inheritance.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216590 => 216591)

--- trunk/LayoutTests/ChangeLog	2017-05-10 16:44:56 UTC (rev 216590)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 16:50:56 UTC (rev 216591)
@@ -1,3 +1,14 @@
+2017-05-10  Antti Koivisto  
+
+REGRESSION (r207372) Visibility property is not inherited when used in an animation
+https://bugs.webkit.org/show_bug.cgi?id=171883
+
+
+Reviewed by Simon Fraser.
+
+* animations/animation-initial-inheritance-expected.html: Added.
+* animations/animation-initial-inheritance.html: Added.
+
 2017-05-10  Per Arne Vollan  
 
 LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout


Added: trunk/LayoutTests/animations/animation-initial-inheritance-expected.html (0 => 216591)

--- trunk/LayoutTests/animations/animation-initial-inheritance-expected.html	(rev 0)
+++ trunk/LayoutTests/animations/animation-initial-inheritance-expected.html	2017-05-10 16:50:56 UTC (rev 216591)
@@ -0,0 +1,23 @@
+
+
+
+
+#test1 {
+visibility: hidden;
+}
+#test2 {
+color: green;
+}
+
+
+
+
+This shouldn't be initially visible
+This shouldn't be initially visible
+
+
+This should be initially green
+This should be initially green
+
+
+


Added: trunk/LayoutTests/animations/animation-initial-inheritance.html (0 => 216591)

--- trunk/LayoutTests/animations/animation-initial-inheritance.html	(rev 0)
+++ trunk/LayoutTests/animations/animation-initial-inheritance.html	2017-05-10 16:50:56 UTC (rev 216591)
@@ -0,0 +1,39 @@
+
+
+
+
+#test1 {
+animation:test1 3s steps(1,end) 0s 1 normal both
+}
+#test2 {
+animation:test2 3s steps(1,end) 0s 1 normal both
+}
+@keyframes test1 {
+from {visibility: hidden}
+to {visibility: visible}
+}
+@keyframes test2 {
+from {color: green}
+to {color: red}
+}
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+requestAnimationFrame(() => {
+testRunner.notifyDone();
+});
+}
+
+
+
+
+This shouldn't be initially visible
+This shouldn't be initially visible
+
+
+This should be initially green
+This should be initially green
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (216590 => 216591)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 16:44:56 UTC (rev 216590)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 16:50:56 UTC (rev 216591)
@@ -1,3 +1,39 @@
+2017-05-10  Antti Koivisto  
+
+REGRESSION (r207372) Visibility property is not inherited when used in an animation
+https://bugs.webkit.org/show_bug.cgi?id=171883
+
+
+Reviewed by Simon Fraser.
+
+The problem here is that our animation code is tied to renderers. We don't have renderers during
+ 

[webkit-changes] [216590] branches/safari-603-branch/Source/WebCore

[matthew_hanson]

Title: [216590] branches/safari-603-branch/Source/WebCore








Revision 216590
Author matthew_han...@apple.com
Date 2017-05-10 09:44:56 -0700 (Wed, 10 May 2017)


Log Message
Remove inadvertant change to ScrollView.h that was included in r216589.

Unreviewed build fix.

* platform/ScrollView.h:
(WebCore::ScrollView::children):

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/platform/ScrollView.h




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216589 => 216590)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 16:34:11 UTC (rev 216589)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 16:44:56 UTC (rev 216590)
@@ -1,3 +1,12 @@
+2017-05-10  Matthew Hanson  
+
+Remove inadvertant change to ScrollView.h that was included in r216589.
+
+Unreviewed build fix.
+
+* platform/ScrollView.h:
+(WebCore::ScrollView::children):
+
 2017-05-09  Matthew Hanson  
 
 Cherry-pick r216131. rdar://problem/31967895


Modified: branches/safari-603-branch/Source/WebCore/platform/ScrollView.h (216589 => 216590)

--- branches/safari-603-branch/Source/WebCore/platform/ScrollView.h	2017-05-10 16:34:11 UTC (rev 216589)
+++ branches/safari-603-branch/Source/WebCore/platform/ScrollView.h	2017-05-10 16:44:56 UTC (rev 216590)
@@ -85,7 +85,7 @@
 virtual IntRect windowClipRect() const = 0;
 
 // Functions for child manipulation and inspection.
-const HashSet& children() const { return m_children; }
+const HashSet& children() const { return m_children; }
 WEBCORE_EXPORT virtual void addChild(PassRefPtr);
 virtual void removeChild(Widget&);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216588] trunk/LayoutTests

[pvollan]

Title: [216588] trunk/LayoutTests








Revision 216588
Author pvol...@apple.com
Date 2017-05-10 09:29:59 -0700 (Wed, 10 May 2017)


Log Message
LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167749

Reviewed by Eric Carlson.

This is a speculative fix of the test. I have not been able to reproduce the timeout.
When the test times out, the 'addtrack' event is never received. In case the event
was dispatched before we added the event listener, the event listener is added before
the video source is set. In case the test will continue to time out, a couple of
error event callbacks have been added to get more information. Also, video playback
will begin when the 'canplaythrough' event is received.

* http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
* http/tests/media/track-in-band-hls-metadata-crash.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt
trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216587 => 216588)

--- trunk/LayoutTests/ChangeLog	2017-05-10 16:08:24 UTC (rev 216587)
+++ trunk/LayoutTests/ChangeLog	2017-05-10 16:29:59 UTC (rev 216588)
@@ -1,3 +1,20 @@
+2017-05-10  Per Arne Vollan  
+
+LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=167749
+
+Reviewed by Eric Carlson.
+
+This is a speculative fix of the test. I have not been able to reproduce the timeout.
+When the test times out, the 'addtrack' event is never received. In case the event
+was dispatched before we added the event listener, the event listener is added before
+the video source is set. In case the test will continue to time out, a couple of
+error event callbacks have been added to get more information. Also, video playback
+will begin when the 'canplaythrough' event is received.
+ 
+* http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
+* http/tests/media/track-in-band-hls-metadata-crash.html:
+
 2017-05-10  Commit Queue  
 
 Unreviewed, rolling out r216578.


Modified: trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt (216587 => 216588)

--- trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt	2017-05-10 16:08:24 UTC (rev 216587)
+++ trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash-expected.txt	2017-05-10 16:29:59 UTC (rev 216588)
@@ -8,6 +8,7 @@
 EVENT(addtrack)
 RUN(track = video.textTracks[0])
 RUN(track.mode = 'hidden')
+EVENT(canplaythrough)
 RUN(video.play())
 EVENT(cuechange)
 


Modified: trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html (216587 => 216588)

--- trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html	2017-05-10 16:08:24 UTC (rev 216587)
+++ trunk/LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html	2017-05-10 16:29:59 UTC (rev 216588)
@@ -14,7 +14,6 @@
 tracks = event.target;
 run("track = video.textTracks[0]");
 run("track.mode = 'hidden'");
-run("video.play()");
 waitForEvent('cuechange', cuechange, false, true, track);
 }
 
@@ -25,14 +24,38 @@
 waitForEventAndEnd("seeked");
 }
 
+function canplaythrough()
+{
+run("video.play()");
+}
+
+function errorCallbackVideo(event)
+{
+logResult(true, "errorCallbackVideo called.");
+consoleWrite("");
+endTest();
+}
+
+function errorCallbackTextTracks(event)
+{
+logResult(true, "errorCallbackTextTracks called.");
+consoleWrite("");
+endTest();
+}
+
 function start()
 {
 consoleWrite("** Set video.src, wait for media data to load");
 findMediaElement();
+
+waitForEvent('addtrack', addtrack, false, true, video.textTracks);
+waitForEvent("canplaythrough", canplaythrough);
+waitForEvent('error', errorCallbackVideo, false, false, video);
+waitForEvent('error', errorCallbackTextTracks, false, false, video.textTracks);
+
 run("video.src = ''");
 
 consoleWrite("");
-waitForEvent('addtrack', addtrack, false, true, video.textTracks);
 }
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216587] branches/safari-603-branch/Source/WebCore

[matthew_hanson]

Title: [216587] branches/safari-603-branch/Source/WebCore








Revision 216587
Author matthew_han...@apple.com
Date 2017-05-10 09:08:24 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r216131. rdar://problem/31967895

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/rendering/RenderObject.h
branches/safari-603-branch/Source/WebCore/rendering/RenderSearchField.h




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216586 => 216587)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 16:06:35 UTC (rev 216586)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 16:08:24 UTC (rev 216587)
@@ -1,3 +1,20 @@
+2017-05-09  Matthew Hanson  
+
+Cherry-pick r216131. rdar://problem/31967895
+
+2017-05-03  Zalan Bujtas  
+
+RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
+https://bugs.webkit.org/show_bug.cgi?id=171608
+
+Reviewed by Simon Fraser.
+
+isTextField() is true for any generic single line text control.
+
+* rendering/RenderObject.h:
+(WebCore::RenderObject::isSearchField):
+* rendering/RenderSearchField.h:
+
 2017-05-09  Jason Marcell  
 
 Cherry-pick r216443. rdar://problem/31971375


Modified: branches/safari-603-branch/Source/WebCore/rendering/RenderObject.h (216586 => 216587)

--- branches/safari-603-branch/Source/WebCore/rendering/RenderObject.h	2017-05-10 16:06:35 UTC (rev 216586)
+++ branches/safari-603-branch/Source/WebCore/rendering/RenderObject.h	2017-05-10 16:08:24 UTC (rev 216587)
@@ -267,6 +267,7 @@
 virtual bool isTextControl() const { return false; }
 virtual bool isTextArea() const { return false; }
 virtual bool isTextField() const { return false; }
+virtual bool isSearchField() const { return false; }
 virtual bool isTextControlInnerBlock() const { return false; }
 virtual bool isVideo() const { return false; }
 virtual bool isWidget() const { return false; }


Modified: branches/safari-603-branch/Source/WebCore/rendering/RenderSearchField.h (216586 => 216587)

--- branches/safari-603-branch/Source/WebCore/rendering/RenderSearchField.h	2017-05-10 16:06:35 UTC (rev 216586)
+++ branches/safari-603-branch/Source/WebCore/rendering/RenderSearchField.h	2017-05-10 16:08:24 UTC (rev 216587)
@@ -45,6 +45,8 @@
 void hidePopup();
 
 private:
+bool isSearchField() const final { return true; }
+
 void centerContainerIfNeeded(RenderBox*) const override;
 LayoutUnit computeControlLogicalHeight(LayoutUnit lineHeight, LayoutUnit nonContentHeight) const override;
 LayoutUnit computeLogicalHeightLimit() const override;
@@ -91,4 +93,4 @@
 
 } // namespace WebCore
 
-SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderSearchField, isTextField())
+SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderSearchField, isSearchField())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216586] trunk/Source/WebCore

[mmaxfield]

Title: [216586] trunk/Source/WebCore








Revision 216586
Author mmaxfi...@apple.com
Date 2017-05-10 09:06:35 -0700 (Wed, 10 May 2017)


Log Message
Tiny cleanup in Font::DerivedFonts
https://bugs.webkit.org/show_bug.cgi?id=171893

Reviewed by Jon Lee.

This variable was written to but never read.

No new tests because there is no behavior change.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
* platform/graphics/Font.cpp:
(WebCore::Font::verticalRightOrientationFont):
(WebCore::Font::uprightOrientationFont):
(WebCore::Font::smallCapsFont):
(WebCore::Font::noSynthesizableFeaturesFont):
(WebCore::Font::emphasisMarkFont):
(WebCore::Font::brokenIdeographFont):
(WebCore::Font::DerivedFonts::~DerivedFonts): Deleted.
* platform/graphics/Font.h:
(WebCore::Font::DerivedFonts::DerivedFonts): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSource.cpp
trunk/Source/WebCore/platform/graphics/Font.cpp
trunk/Source/WebCore/platform/graphics/Font.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (216585 => 216586)

--- trunk/Source/WebCore/ChangeLog	2017-05-10 14:50:02 UTC (rev 216585)
+++ trunk/Source/WebCore/ChangeLog	2017-05-10 16:06:35 UTC (rev 216586)
@@ -1,3 +1,27 @@
+2017-05-10  Myles C. Maxfield  
+
+Tiny cleanup in Font::DerivedFonts
+https://bugs.webkit.org/show_bug.cgi?id=171893
+
+Reviewed by Jon Lee.
+
+This variable was written to but never read.
+
+No new tests because there is no behavior change.
+
+* css/CSSFontFaceSource.cpp:
+(WebCore::CSSFontFaceSource::font):
+* platform/graphics/Font.cpp:
+(WebCore::Font::verticalRightOrientationFont):
+(WebCore::Font::uprightOrientationFont):
+(WebCore::Font::smallCapsFont):
+(WebCore::Font::noSynthesizableFeaturesFont):
+(WebCore::Font::emphasisMarkFont):
+(WebCore::Font::brokenIdeographFont):
+(WebCore::Font::DerivedFonts::~DerivedFonts): Deleted.
+* platform/graphics/Font.h:
+(WebCore::Font::DerivedFonts::DerivedFonts): Deleted.
+
 2017-05-10  Michael Catanzaro  
 
 Remove user agent quirk for Slack


Modified: trunk/Source/WebCore/css/CSSFontFaceSource.cpp (216585 => 216586)

--- trunk/Source/WebCore/css/CSSFontFaceSource.cpp	2017-05-10 14:50:02 UTC (rev 216585)
+++ trunk/Source/WebCore/css/CSSFontFaceSource.cpp	2017-05-10 16:06:35 UTC (rev 216586)
@@ -206,9 +206,9 @@
 if (!m_inDocumentCustomPlatformData)
 return nullptr;
 #if PLATFORM(COCOA)
-return Font::create(m_inDocumentCustomPlatformData->fontPlatformData(fontDescription, syntheticBold, syntheticItalic, fontFaceFeatures, fontFaceVariantSettings, fontFaceCapabilities), true, false);
+return Font::create(m_inDocumentCustomPlatformData->fontPlatformData(fontDescription, syntheticBold, syntheticItalic, fontFaceFeatures, fontFaceVariantSettings, fontFaceCapabilities), true);
 #else
-return Font::create(m_inDocumentCustomPlatformData->fontPlatformData(fontDescription, syntheticBold, syntheticItalic), true, false);
+return Font::create(m_inDocumentCustomPlatformData->fontPlatformData(fontDescription, syntheticBold, syntheticItalic), true);
 #endif
 #endif
 


Modified: trunk/Source/WebCore/platform/graphics/Font.cpp (216585 => 216586)

--- trunk/Source/WebCore/platform/graphics/Font.cpp	2017-05-10 14:50:02 UTC (rev 216585)
+++ trunk/Source/WebCore/platform/graphics/Font.cpp	2017-05-10 16:06:35 UTC (rev 216586)
@@ -263,7 +263,7 @@
 const Font& Font::verticalRightOrientationFont() const
 {
 if (!m_derivedFontData)
-m_derivedFontData = std::make_unique(isCustomFont());
+m_derivedFontData = std::make_unique();
 if (!m_derivedFontData->verticalRightOrientation) {
 auto verticalRightPlatformData = FontPlatformData::cloneWithOrientation(m_platformData, Horizontal);
 m_derivedFontData->verticalRightOrientation = create(verticalRightPlatformData, isCustomFont(), false, true);
@@ -275,7 +275,7 @@
 const Font& Font::uprightOrientationFont() const
 {
 if (!m_derivedFontData)
-m_derivedFontData = std::make_unique(isCustomFont());
+m_derivedFontData = std::make_unique();
 if (!m_derivedFontData->uprightOrientation)
 m_derivedFontData->uprightOrientation = create(m_platformData, isCustomFont(), false, true);
 ASSERT(m_derivedFontData->uprightOrientation != this);
@@ -285,7 +285,7 @@
 const Font* Font::smallCapsFont(const FontDescription& fontDescription) const
 {
 if (!m_derivedFontData)
-m_derivedFontData = std::make_unique(isCustomFont());
+m_derivedFontData = std::make_unique();
 if (!m_derivedFontData->smallCaps)
 m_derivedFontData->smallCaps = createScaledFont(fontDescription, smallCapsFontSizeMultiplier);
 ASSERT(m_derivedFontData->smallCaps != this);
@@ -296,7 +296,7 @@
 {
 #if PLATFORM(COCOA)
 if (!m_derivedFontData)
-   

[webkit-changes] [216583] trunk

[commit-queue]

Title: [216583] trunk








Revision 216583
Author commit-qu...@webkit.org
Date 2017-05-10 07:31:29 -0700 (Wed, 10 May 2017)


Log Message
[Win] Specify source file type when preprocessing IDL files
https://bugs.webkit.org/show_bug.cgi?id=171864

Patch by Don Olmstead  on 2017-05-10
Reviewed by Alex Christensen.

* Source/cmake/OptionsCommon.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsCommon.cmake




Diff

Modified: trunk/ChangeLog (216582 => 216583)

--- trunk/ChangeLog	2017-05-10 14:26:53 UTC (rev 216582)
+++ trunk/ChangeLog	2017-05-10 14:31:29 UTC (rev 216583)
@@ -1,3 +1,12 @@
+2017-05-10  Don Olmstead  
+
+[Win] Specify source file type when preprocessing IDL files
+https://bugs.webkit.org/show_bug.cgi?id=171864
+
+Reviewed by Alex Christensen.
+
+* Source/cmake/OptionsCommon.cmake:
+
 2017-05-10  Adrian Perez de Castro  
 
 Remove some last remnants of the EFL port


Modified: trunk/Source/cmake/OptionsCommon.cmake (216582 => 216583)

--- trunk/Source/cmake/OptionsCommon.cmake	2017-05-10 14:26:53 UTC (rev 216582)
+++ trunk/Source/cmake/OptionsCommon.cmake	2017-05-10 14:31:29 UTC (rev 216583)
@@ -9,7 +9,7 @@
 # FIXME: Some codegenerators don't support paths with spaces. So use the executable name only.
 get_filename_component(CODE_GENERATOR_PREPROCESSOR_EXECUTABLE ${CMAKE_CXX_COMPILER} ABSOLUTE)
 
-set(CODE_GENERATOR_PREPROCESSOR_ARGUMENTS "/nologo /EP")
+set(CODE_GENERATOR_PREPROCESSOR_ARGUMENTS "/nologo /EP /TP")
 set(CODE_GENERATOR_PREPROCESSOR "\"${CODE_GENERATOR_PREPROCESSOR_EXECUTABLE}\" ${CODE_GENERATOR_PREPROCESSOR_ARGUMENTS}")
 
 set(CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS ${CODE_GENERATOR_PREPROCESSOR})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216580] trunk

[commit-queue]

Title: [216580] trunk








Revision 216580
Author commit-qu...@webkit.org
Date 2017-05-10 07:01:36 -0700 (Wed, 10 May 2017)


Log Message
Remove some last remnants of the EFL port
https://bugs.webkit.org/show_bug.cgi?id=171922

Patch by Adrian Perez de Castro  on 2017-05-10
Reviewed by Antonio Gomes.

The EFL port is no more.

.:

* Source/PlatformEfl.cmake: Removed.

Source/_javascript_Core:

* PlatformEfl.cmake: Removed.
* shell/PlatformEfl.cmake: Removed.

Source/WTF:

* wtf/PlatformEfl.cmake: Removed.

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WTF/ChangeLog


Removed Paths

trunk/Source/_javascript_Core/PlatformEfl.cmake
trunk/Source/_javascript_Core/shell/PlatformEfl.cmake
trunk/Source/PlatformEfl.cmake
trunk/Source/WTF/wtf/PlatformEfl.cmake




Diff

Modified: trunk/ChangeLog (216579 => 216580)

--- trunk/ChangeLog	2017-05-10 12:35:47 UTC (rev 216579)
+++ trunk/ChangeLog	2017-05-10 14:01:36 UTC (rev 216580)
@@ -1,3 +1,14 @@
+2017-05-10  Adrian Perez de Castro  
+
+Remove some last remnants of the EFL port
+https://bugs.webkit.org/show_bug.cgi?id=171922
+
+Reviewed by Antonio Gomes.
+
+The EFL port is no more.
+
+* Source/PlatformEfl.cmake: Removed.
+
 2017-05-10  Zan Dobersek  
 
 Enable FTL JIT by default on AArch64


Modified: trunk/Source/_javascript_Core/ChangeLog (216579 => 216580)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-10 12:35:47 UTC (rev 216579)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-10 14:01:36 UTC (rev 216580)
@@ -1,3 +1,15 @@
+2017-05-10  Adrian Perez de Castro  
+
+Remove some last remnants of the EFL port
+https://bugs.webkit.org/show_bug.cgi?id=171922
+
+Reviewed by Antonio Gomes.
+
+The EFL port is no more.
+
+* PlatformEfl.cmake: Removed.
+* shell/PlatformEfl.cmake: Removed.
+
 2017-05-09  Filip Pizlo  
 
 JSInjectedScriptHost should get a copy of the boundArgs


Deleted: trunk/Source/_javascript_Core/PlatformEfl.cmake (216579 => 216580)

--- trunk/Source/_javascript_Core/PlatformEfl.cmake	2017-05-10 12:35:47 UTC (rev 216579)
+++ trunk/Source/_javascript_Core/PlatformEfl.cmake	2017-05-10 14:01:36 UTC (rev 216580)
@@ -1,20 +0,0 @@
-list(APPEND _javascript_Core_SYSTEM_INCLUDE_DIRECTORIES
-${ECORE_EVAS_INCLUDE_DIRS}
-${ECORE_IMF_INCLUDE_DIRS}
-${ECORE_INCLUDE_DIRS}
-${EINA_INCLUDE_DIRS}
-${EO_INCLUDE_DIRS}
-)
-
-add_definitions(-DSTATICALLY_LINKED_WITH_WTF)
-
-install(FILES API/_javascript_.h
-  API/JSBase.h
-  API/JSContextRef.h
-  API/JSObjectRef.h
-  API/JSStringRef.h
-  API/JSValueRef.h
-  API/JSTypedArray.h
-  API/WebKitAvailability.h
-DESTINATION "${HEADER_INSTALL_DIR}/_javascript_Core"
-)


Deleted: trunk/Source/_javascript_Core/shell/PlatformEfl.cmake (216579 => 216580)

--- trunk/Source/_javascript_Core/shell/PlatformEfl.cmake	2017-05-10 12:35:47 UTC (rev 216579)
+++ trunk/Source/_javascript_Core/shell/PlatformEfl.cmake	2017-05-10 14:01:36 UTC (rev 216580)
@@ -1,4 +0,0 @@
-list(APPEND JSC_LIBRARIES
-${ECORE_LIBRARIES}
-${GLIB_LIBRARIES}
-)


Deleted: trunk/Source/PlatformEfl.cmake (216579 => 216580)

--- trunk/Source/PlatformEfl.cmake	2017-05-10 12:35:47 UTC (rev 216579)
+++ trunk/Source/PlatformEfl.cmake	2017-05-10 14:01:36 UTC (rev 216580)
@@ -1,53 +0,0 @@
-add_subdirectory(${WEBCORE_DIR}/platform/efl/DefaultTheme)
-
-# DerivedSources/_javascript_Core/inspector/InspectorBackendCommands.js is
-# expected in DerivedSources/WebInspectorUI/UserInterface/Protocol/.
-add_custom_command(
-OUTPUT ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol/InspectorBackendCommands.js
-DEPENDS ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector/InspectorBackendCommands.js
-COMMAND cp ${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector/InspectorBackendCommands.js ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol/InspectorBackendCommands.js
-)
-
-add_custom_target(
-web-inspector-resources ALL
-COMMAND ${CMAKE_COMMAND} -E copy_directory ${WEBINSPECTORUI_DIR}/UserInterface ${WEB_INSPECTOR_DIR}
-COMMAND ${CMAKE_COMMAND} -E copy ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol/InspectorBackendCommands.js ${WEB_INSPECTOR_DIR}/Protocol
-COMMAND ${CMAKE_COMMAND} -E copy ${WEBINSPECTORUI_DIR}/Localizations/en.lproj/localizedStrings.js ${WEB_INSPECTOR_DIR}
-COMMAND ${CMAKE_COMMAND} -E copy ${WEBKIT2_DIR}/UIProcess/InspectorServer/front-end/inspectorPageIndex.html ${WEB_INSPECTOR_DIR}
-DEPENDS _javascript_Core WebCore ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol/InspectorBackendCommands.js
-WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
-)
-install(DIRECTORY "${CMAKE_BINARY_DIR}/${WEB_INSPECTOR_DIR}"
-DESTINATION ${DATA_INSTALL_DIR}
-

[webkit-changes] [216577] trunk/Tools

[commit-queue]

Title: [216577] trunk/Tools








Revision 216577
Author commit-qu...@webkit.org
Date 2017-05-10 03:04:36 -0700 (Wed, 10 May 2017)


Log Message
[Win] Set CMake args in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=171436

Patch by Don Olmstead  on 2017-05-10
Reviewed by Per Arne Vollan.

* Scripts/build-webkit:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/Tools/ChangeLog (216576 => 216577)

--- trunk/Tools/ChangeLog	2017-05-10 08:16:15 UTC (rev 216576)
+++ trunk/Tools/ChangeLog	2017-05-10 10:04:36 UTC (rev 216577)
@@ -1,3 +1,12 @@
+2017-05-10  Don Olmstead  
+
+[Win] Set CMake args in build-webkit
+https://bugs.webkit.org/show_bug.cgi?id=171436
+
+Reviewed by Per Arne Vollan.
+
+* Scripts/build-webkit:
+
 2017-05-10  Carlos Garcia Campos  
 
 ImageDiff: Add CG implementation for new ImageDiff


Modified: trunk/Tools/Scripts/build-webkit (216576 => 216577)

--- trunk/Tools/Scripts/build-webkit	2017-05-10 08:16:15 UTC (rev 216576)
+++ trunk/Tools/Scripts/build-webkit	2017-05-10 10:04:36 UTC (rev 216577)
@@ -258,7 +258,7 @@
 removeCMakeCache(@featureArgs);
 
 chdirWebKit();
-if (exitStatus(generateBuildSystemFromCMakeProject())) {
+if (exitStatus(generateBuildSystemFromCMakeProject($prefixPath, @cmakeArgs))) {
 die "Run \"C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/vcvarsall.bat\" before build-webkit when using ninja";
 }
 chdirWebKit();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216576] trunk/Tools

[commit-queue]

Title: [216576] trunk/Tools








Revision 216576
Author commit-qu...@webkit.org
Date 2017-05-10 01:16:15 -0700 (Wed, 10 May 2017)


Log Message
ImageDiff: Add CG implementation for new ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=170608

Reviewed Alex Christensen.

Patch by Carlos Garcia Campos  on 2017-05-10

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
* DumpRenderTree/win/ImageDiffWin.cpp: Removed.
* ImageDiff/CMakeLists.txt:
* ImageDiff/Cairo.cmake:
* ImageDiff/ImageDiff.cpp:
(main):
* ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
* ImageDiff/PlatformImage.cpp:
* ImageDiff/PlatformImage.h:
* ImageDiff/cairo/PlatformImageCairo.cpp:
* ImageDiff/cg/ImageDiff.cpp: Removed.
* ImageDiff/cg/PlatformImageCG.cpp: Added.
(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::createFromDiffData):
(ImageDiff::PlatformImage::PlatformImage):
(ImageDiff::PlatformImage::~PlatformImage):
(ImageDiff::PlatformImage::width):
(ImageDiff::PlatformImage::height):
(ImageDiff::PlatformImage::rowBytes):
(ImageDiff::PlatformImage::hasAlpha):
(ImageDiff::PlatformImage::pixels):
(ImageDiff::PlatformImage::writeAsPNGToStdout):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/ImageDiff/CMakeLists.txt
trunk/Tools/ImageDiff/Cairo.cmake
trunk/Tools/ImageDiff/ImageDiff.cpp
trunk/Tools/ImageDiff/ImageDiff.xcodeproj/project.pbxproj
trunk/Tools/ImageDiff/PlatformImage.cpp
trunk/Tools/ImageDiff/PlatformImage.h
trunk/Tools/ImageDiff/PlatformMac.cmake
trunk/Tools/ImageDiff/PlatformWin.cmake
trunk/Tools/ImageDiff/cairo/PlatformImageCairo.cpp


Added Paths

trunk/Tools/ImageDiff/cg/PlatformImageCG.cpp


Removed Paths

trunk/Tools/DumpRenderTree/win/ImageDiffCairo.cpp
trunk/Tools/DumpRenderTree/win/ImageDiffWin.cpp
trunk/Tools/ImageDiff/cg/ImageDiff.cpp




Diff

Modified: trunk/Tools/ChangeLog (216575 => 216576)

--- trunk/Tools/ChangeLog	2017-05-10 08:04:44 UTC (rev 216575)
+++ trunk/Tools/ChangeLog	2017-05-10 08:16:15 UTC (rev 216576)
@@ -1,3 +1,34 @@
+2017-05-10  Carlos Garcia Campos  
+
+ImageDiff: Add CG implementation for new ImageDiff
+https://bugs.webkit.org/show_bug.cgi?id=170608
+
+Reviewed Alex Christensen.
+
+* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+* DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
+* DumpRenderTree/win/ImageDiffWin.cpp: Removed.
+* ImageDiff/CMakeLists.txt:
+* ImageDiff/Cairo.cmake:
+* ImageDiff/ImageDiff.cpp:
+(main):
+* ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
+* ImageDiff/PlatformImage.cpp:
+* ImageDiff/PlatformImage.h:
+* ImageDiff/cairo/PlatformImageCairo.cpp:
+* ImageDiff/cg/ImageDiff.cpp: Removed.
+* ImageDiff/cg/PlatformImageCG.cpp: Added.
+(ImageDiff::PlatformImage::createFromStdin):
+(ImageDiff::PlatformImage::createFromDiffData):
+(ImageDiff::PlatformImage::PlatformImage):
+(ImageDiff::PlatformImage::~PlatformImage):
+(ImageDiff::PlatformImage::width):
+(ImageDiff::PlatformImage::height):
+(ImageDiff::PlatformImage::rowBytes):
+(ImageDiff::PlatformImage::hasAlpha):
+(ImageDiff::PlatformImage::pixels):
+(ImageDiff::PlatformImage::writeAsPNGToStdout):
+
 2017-05-10  Zan Dobersek  
 
 Enable FTL JIT by default on AArch64


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (216575 => 216576)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2017-05-10 08:04:44 UTC (rev 216575)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2017-05-10 08:16:15 UTC (rev 216576)
@@ -398,7 +398,6 @@
 		BCB2848A0CFA820F007E533E /* PixelDumpSupport.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = PixelDumpSupport.h; sourceTree = ""; };
 		BCB2848C0CFA8221007E533E /* PixelDumpSupportMac.mm */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.objcpp; name = PixelDumpSupportMac.mm; path = mac/PixelDumpSupportMac.mm; sourceTree = ""; };
 		BCB284B20CFA82CB007E533E /* ApplicationServices.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = ApplicationServices.framework; path = /System/Library/Frameworks/ApplicationServices.framework; sourceTree = ""; };
-		BCB284F30CFA84F2007E533E /* ImageDiffCG.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; name = ImageDiffCG.cpp; path = cg/ImageDiffCG.cpp; sourceTree = ""; };
 		BCD08A580E10496B00A7D0C1 /* AccessibilityController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AccessibilityController.h; sourceTree = ""; };
 		BCD08B390E1057EF00A7D0C1 /* 

[webkit-changes] [216571] branches/safari-603-branch

[jmarcell]

Title: [216571] branches/safari-603-branch








Revision 216571
Author jmarc...@apple.com
Date 2017-05-10 00:40:28 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r216104. rdar://problem/32057088

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp


Added Paths

branches/safari-603-branch/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html
branches/safari-603-branch/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216570 => 216571)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 07:40:25 UTC (rev 216570)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 07:40:28 UTC (rev 216571)
@@ -1,5 +1,20 @@
 2017-05-09  Jason Marcell  
 
+Cherry-pick r216104. rdar://problem/32057088
+
+2017-05-02  Simon Fraser  
+
+Dynamically added position:fixed element is in the wrong place
+https://bugs.webkit.org/show_bug.cgi?id=170280
+rdar://problem/31374008
+
+Reviewed by Tim Horton.
+
+* scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html: Added.
+* scrollingcoordinator/ios/nested-fixed-layer-positions.html: Added.
+
+2017-05-09  Jason Marcell  
+
 Cherry-pick r214375. rdar://problem/32057082
 
 2017-03-24  Brady Eidson  


Added: branches/safari-603-branch/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html (0 => 216571)

--- branches/safari-603-branch/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions-expected.html	2017-05-10 07:40:28 UTC (rev 216571)
@@ -0,0 +1,29 @@
+ 
+
+
+
+
+
+body {
+height: 2000px;
+margin: 0;
+}
+
+.fixed {
+position: fixed;
+}
+
+.fixed-bar {
+position: fixed;
+top: 10px;
+left: 0;
+height: 100px;
+width: 400px;
+background-color: blue;
+}
+
+
+
+
+
+


Added: branches/safari-603-branch/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions.html (0 => 216571)

--- branches/safari-603-branch/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/scrollingcoordinator/ios/nested-fixed-layer-positions.html	2017-05-10 07:40:28 UTC (rev 216571)
@@ -0,0 +1,62 @@
+ 
+
+
+
+
+
+body {
+height: 2000px;
+margin: 0;
+}
+
+.fixed {
+position: fixed;
+}
+
+.fixed-bar {
+position: fixed;
+top: 10px;
+left: 0;
+height: 100px;
+width: 400px;
+background-color: blue;
+}
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function getScrollDownUIScript()
+{
+return `(function() {
+uiController.scrollToOffset(0, 300);
+
+uiController.didEndScrollingCallback = function() {
+uiController.uiScriptComplete();
+};
+})();`;
+}
+
+function makeBodyFixed()
+{
+document.body.classList.add('fixed');
+testRunner.notifyDone();
+}
+
+function doTest()
+{
+if (!testRunner.runUIScript)
+return
+
+testRunner.runUIScript(getScrollDownUIScript(), function() {
+makeBodyFixed();
+});
+}
+
+window.addEventListener('load', doTest, false);
+
+
+
+
+
+


Modified: branches/safari-603-branch/Source/WebKit2/ChangeLog (216570 => 216571)

--- branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-05-10 07:40:25 UTC (rev 216570)
+++ branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-05-10 07:40:28 UTC (rev 216571)
@@ -1,5 +1,32 @@
 2017-05-09  Jason Marcell  
 
+Cherry-pick r216104. rdar://problem/32057088
+
+2017-05-02  Simon Fraser  
+
+Dynamically added position:fixed element is in the wrong place
+https://bugs.webkit.org/show_bug.cgi?id=170280
+rdar://problem/31374008
+
+Reviewed by Tim Horton.
+
+Layers for position:fixed elements have their positions reconciled after scrolls
+via 

[webkit-changes] [216573] branches/safari-603-branch

[jmarcell]

Title: [216573] branches/safari-603-branch








Revision 216573
Author jmarc...@apple.com
Date 2017-05-10 00:40:35 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r216443. rdar://problem/31971375

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/html/SearchInputType.cpp


Added Paths

branches/safari-603-branch/LayoutTests/fast/forms/search/search-incremental-crash-expected.txt
branches/safari-603-branch/LayoutTests/fast/forms/search/search-incremental-crash.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216572 => 216573)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 07:40:31 UTC (rev 216572)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 07:40:35 UTC (rev 216573)
@@ -1,5 +1,20 @@
 2017-05-09  Jason Marcell  
 
+Cherry-pick r216443. rdar://problem/31971375
+
+2017-05-04  Jiewen Tan  
+
+Search events should not fire synchronously for search type input elements with incremental attribute set
+https://bugs.webkit.org/show_bug.cgi?id=171376
+
+
+Reviewed by Chris Dumez.
+
+* fast/forms/search/search-incremental-crash-expected.txt: Added.
+* fast/forms/search/search-incremental-crash.html: Added.
+
+2017-05-09  Jason Marcell  
+
 Cherry-pick r216159. rdar://problem/31971329
 
 2017-05-03  Zalan Bujtas  


Added: branches/safari-603-branch/LayoutTests/fast/forms/search/search-incremental-crash-expected.txt (0 => 216573)

--- branches/safari-603-branch/LayoutTests/fast/forms/search/search-incremental-crash-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/forms/search/search-incremental-crash-expected.txt	2017-05-10 07:40:35 UTC (rev 216573)
@@ -0,0 +1 @@
+ Test passes if WebKit doesn't crash.


Added: branches/safari-603-branch/LayoutTests/fast/forms/search/search-incremental-crash.html (0 => 216573)

--- branches/safari-603-branch/LayoutTests/fast/forms/search/search-incremental-crash.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/forms/search/search-incremental-crash.html	2017-05-10 07:40:35 UTC (rev 216573)
@@ -0,0 +1,28 @@
+
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var runcount = 0;
+function go() {
+runcount++;
+if (runcount > 2)
+return;
+
+i.type = "foo";
+i.select();
+i.type = "search";
+
+document._onsearch_ = document.body.onload;
+
+document.execCommand("insertHTML", false, "");
+}
+
+
+
+
+Test passes if WebKit doesn't crash.
+
+
\ No newline at end of file


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216572 => 216573)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 07:40:31 UTC (rev 216572)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 07:40:35 UTC (rev 216573)
@@ -1,5 +1,26 @@
 2017-05-09  Jason Marcell  
 
+Cherry-pick r216443. rdar://problem/31971375
+
+2017-05-04  Jiewen Tan  
+
+Search events should not fire synchronously for search type input elements with incremental attribute set
+https://bugs.webkit.org/show_bug.cgi?id=171376
+
+
+Reviewed by Chris Dumez.
+
+For some reasons, we fire search events immediately for search type input elements with incremental
+attribute set only when the length of the input equals to zero. This behaviour should be prevented
+as event listeners in the middle might perform unexpectedly.
+
+Test: fast/forms/search/search-incremental-crash.html
+
+* html/SearchInputType.cpp:
+(WebCore::SearchInputType::startSearchEventTimer):
+
+2017-05-09  Jason Marcell  
+
 Cherry-pick r216159. rdar://problem/31971329
 
 2017-05-03  Zalan Bujtas  


Modified: branches/safari-603-branch/Source/WebCore/html/SearchInputType.cpp (216572 => 216573)

--- branches/safari-603-branch/Source/WebCore/html/SearchInputType.cpp	2017-05-10 07:40:31 UTC (rev 216572)
+++ branches/safari-603-branch/Source/WebCore/html/SearchInputType.cpp	2017-05-10 07:40:35 UTC (rev 216573)
@@ -161,8 +161,7 @@
 unsigned length = element().innerTextValue().length();
 
 if (!length) {
-stopSearchEventTimer();
-element().onSearch();
+m_searchEventTimer.startOneShot(0_ms);
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216568] branches/safari-603-branch

[jmarcell]

Title: [216568] branches/safari-603-branch








Revision 216568
Author jmarc...@apple.com
Date 2017-05-10 00:40:17 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r214375. rdar://problem/32057082

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp
branches/safari-603-branch/Source/WebCore/Modules/indexeddb/IDBKeyPath.h
branches/safari-603-branch/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
branches/safari-603-branch/Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.cpp
branches/safari-603-branch/Source/WebCore/bindings/js/IDBBindingUtilities.cpp


Added Paths

branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/resources/single-entry-index-invalid-key-crash.js
branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/single-entry-index-invalid-key-crash-expected.txt
branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/single-entry-index-invalid-key-crash-private-expected.txt
branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/single-entry-index-invalid-key-crash-private.html
branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/single-entry-index-invalid-key-crash.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216567 => 216568)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 07:40:11 UTC (rev 216567)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 07:40:17 UTC (rev 216568)
@@ -1,3 +1,20 @@
+2017-05-09  Jason Marcell  
+
+Cherry-pick r214375. rdar://problem/32057082
+
+2017-03-24  Brady Eidson  
+
+A null compound index value crashes the Databases process.
+ and https://bugs.webkit.org/show_bug.cgi?id=17
+
+Reviewed by Alex Christensen.
+
+* storage/indexeddb/modern/resources/single-entry-index-invalid-key-crash.js: Added.
+* storage/indexeddb/modern/single-entry-index-invalid-key-crash-expected.txt: Added.
+* storage/indexeddb/modern/single-entry-index-invalid-key-crash-private-expected.txt: Added.
+* storage/indexeddb/modern/single-entry-index-invalid-key-crash-private.html: Added.
+* storage/indexeddb/modern/single-entry-index-invalid-key-crash.html: Added.
+
 2017-05-09  Matthew Hanson  
 
 Cherry-pick r216431. rdar://problem/31971208


Added: branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/resources/single-entry-index-invalid-key-crash.js (0 => 216568)

--- branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/resources/single-entry-index-invalid-key-crash.js	(rev 0)
+++ branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/resources/single-entry-index-invalid-key-crash.js	2017-05-10 07:40:17 UTC (rev 216568)
@@ -0,0 +1,29 @@
+description("Tests that adding to an object store, with a single-entry Index, where the index key is an array that is not entirely valid... does not crash.");
+
+indexedDBTest(prepareDatabase);
+
+function log(message)
+{
+debug(message);
+}
+
+function prepareDatabase(event)
+{
+db = event.target.result;
+os = db.createObjectStore("friends", { keyPath: "id", autoIncrement: true });
+	idx = os.createIndex("[age+shoeSize]", ["age", "shoeSize"]);
+	os.add({ name: "Mark", age: 29, shoeSize: null });
+
+	idx.openCursor()._onsuccess_ = function(event) {
+	if (event.target.result)
+	log("Index unexpectedly has an entry");
+else
+	log("Index has no entries");
+};
+	
+event.target.transaction._oncomplete_ = function() {
+finishJSTest();
+};
+}
+
+ 
\ No newline at end of file


Added: branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/single-entry-index-invalid-key-crash-expected.txt (0 => 216568)

--- branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/single-entry-index-invalid-key-crash-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/single-entry-index-invalid-key-crash-expected.txt	2017-05-10 07:40:17 UTC (rev 216568)
@@ -0,0 +1,14 @@
+Tests that adding to an object store, with a single-entry Index, where the index key is an array that is not entirely valid... does not crash.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+indexedDB.deleteDatabase(dbname)
+indexedDB.open(dbname)
+Index has no entries
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: branches/safari-603-branch/LayoutTests/storage/indexeddb/modern/single-entry-index-invalid-key-crash-private-expected.txt (0 => 216568)

--- 

[webkit-changes] [216572] branches/safari-603-branch

[jmarcell]

Title: [216572] branches/safari-603-branch








Revision 216572
Author jmarc...@apple.com
Date 2017-05-10 00:40:31 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r216159. rdar://problem/31971329

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/html/SearchInputType.cpp


Added Paths

branches/safari-603-branch/LayoutTests/fast/forms/change-input-type-and-submit-form-crash-expected.txt
branches/safari-603-branch/LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (216571 => 216572)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 07:40:28 UTC (rev 216571)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-05-10 07:40:31 UTC (rev 216572)
@@ -1,5 +1,20 @@
 2017-05-09  Jason Marcell  
 
+Cherry-pick r216159. rdar://problem/31971329
+
+2017-05-03  Zalan Bujtas  
+
+SearchInputType could end up with a mismatched renderer.
+https://bugs.webkit.org/show_bug.cgi?id=171547
+
+
+Reviewed by Antti Koivisto.
+
+* fast/forms/change-input-type-and-submit-form-crash-expected.txt: Added.
+* fast/forms/change-input-type-and-submit-form-crash.html: Added.
+
+2017-05-09  Jason Marcell  
+
 Cherry-pick r216104. rdar://problem/32057088
 
 2017-05-02  Simon Fraser  


Added: branches/safari-603-branch/LayoutTests/fast/forms/change-input-type-and-submit-form-crash-expected.txt (0 => 216572)

--- branches/safari-603-branch/LayoutTests/fast/forms/change-input-type-and-submit-form-crash-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/forms/change-input-type-and-submit-form-crash-expected.txt	2017-05-10 07:40:31 UTC (rev 216572)
@@ -0,0 +1,2 @@
+PASS if no crash or assert.
+


Added: branches/safari-603-branch/LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html (0 => 216572)

--- branches/safari-603-branch/LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html	2017-05-10 07:40:31 UTC (rev 216572)
@@ -0,0 +1,19 @@
+
+
+
+This tests that submitting a form soon after changing the input type is ok.
+
+
+PASS if no crash or assert.
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.body.offsetHeight;
+inputToChange.value = "1";
+inputToChange.type = "search";
+formToSubmit.submit();
+
+
+


Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216571 => 216572)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 07:40:28 UTC (rev 216571)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 07:40:31 UTC (rev 216572)
@@ -1,5 +1,28 @@
 2017-05-09  Jason Marcell  
 
+Cherry-pick r216159. rdar://problem/31971329
+
+2017-05-03  Zalan Bujtas  
+
+SearchInputType could end up with a mismatched renderer.
+https://bugs.webkit.org/show_bug.cgi?id=171547
+
+
+Reviewed by Antti Koivisto.
+
+Normally we've got the correct renderer by the time we call into SearchInputType.
+However, since HTMLInputElement::updateType() eagerly updates the type while the associated renderers are done lazily
+(so we don't get them updated until after the next tree update), we could actually end up
+with a mismatched renderer (e.g. through form submission).
+
+Test: fast/forms/change-input-type-and-submit-form-crash.html
+
+* html/SearchInputType.cpp:
+(WebCore::SearchInputType::addSearchResult):
+(WebCore::SearchInputType::didSetValueByUserEdit):
+
+2017-05-09  Jason Marcell  
+
 Cherry-pick r214375. rdar://problem/32057082
 
 2017-03-24  Brady Eidson  


Modified: branches/safari-603-branch/Source/WebCore/html/SearchInputType.cpp (216571 => 216572)

--- branches/safari-603-branch/Source/WebCore/html/SearchInputType.cpp	2017-05-10 07:40:28 UTC (rev 216571)
+++ branches/safari-603-branch/Source/WebCore/html/SearchInputType.cpp	2017-05-10 07:40:31 UTC (rev 216572)
@@ -55,8 +55,11 @@
 void SearchInputType::addSearchResult()
 {
 #if !PLATFORM(IOS)
-if (auto* renderer = element().renderer())
-downcast(*renderer).addSearchResult();
+// Normally we've got the correct renderer by the time we get here. However when the input type changes
+// we don't update the associated renderers until after the next tree update, so we could actually end up here
+// with a mismatched renderer (e.g. through form submission).
+if (is(element().renderer()))
+

[webkit-changes] [216569] branches/safari-603-branch

[jmarcell]

Title: [216569] branches/safari-603-branch








Revision 216569
Author jmarc...@apple.com
Date 2017-05-10 00:40:21 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r215197. rdar://problem/31971401

Modified Paths

branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm
branches/safari-603-branch/Tools/ChangeLog
branches/safari-603-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp
branches/safari-603-branch/Tools/TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp




Diff

Modified: branches/safari-603-branch/Source/WebKit2/ChangeLog (216568 => 216569)

--- branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-05-10 07:40:17 UTC (rev 216568)
+++ branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-05-10 07:40:21 UTC (rev 216569)
@@ -1,3 +1,21 @@
+2017-05-09  Jason Marcell  
+
+Cherry-pick r215197. rdar://problem/31971401
+
+2017-04-10  Brent Fulgham  
+
+[WK2][macOS] Block access to Apple Events before launch.
+https://bugs.webkit.org/show_bug.cgi?id=170626
+
+
+Reviewed by Alexey Proskuryakov.
+
+Clear the environment of the AppleEvent server name before initializing
+AppKit so we never bother connecting.
+
+* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
+(main):
+
 2017-04-12  Jason Marcell  
 
 Cherry-pick 214376. rdar://problem/31502340


Modified: branches/safari-603-branch/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm (216568 => 216569)

--- branches/safari-603-branch/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm	2017-05-10 07:40:17 UTC (rev 216568)
+++ branches/safari-603-branch/Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm	2017-05-10 07:40:21 UTC (rev 216569)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013, 2015, 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -127,6 +127,11 @@
 }
 }
 
+#if PLATFORM(MAC)
+// Don't allow Apple Events in WebKit processes. This can be removed when  is fixed.
+setenv("__APPLEEVENTSSERVICENAME", "", 1);
+#endif
+
 xpc_main(XPCServiceEventHandler);
 return 0;
 }


Modified: branches/safari-603-branch/Tools/ChangeLog (216568 => 216569)

--- branches/safari-603-branch/Tools/ChangeLog	2017-05-10 07:40:17 UTC (rev 216568)
+++ branches/safari-603-branch/Tools/ChangeLog	2017-05-10 07:40:21 UTC (rev 216569)
@@ -1,3 +1,26 @@
+2017-05-09  Jason Marcell  
+
+Cherry-pick r215197. rdar://problem/31971401
+
+2017-04-10  Brent Fulgham  
+
+[WK2][macOS] Block access to Apple Events before launch.
+https://bugs.webkit.org/show_bug.cgi?id=170626
+
+
+Reviewed by Alexey Proskuryakov.
+
+Add a new TestWebKitAPI test that fails if Apple Events are sent.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
+* TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.
+(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
+(TestWebKitAPI::didFinishLoadForFrame):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.
+(TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
+(TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):
+
 2017-05-09  Ryan Haddad  
 
 Merge r213654. rdar://problem/32074957


Modified: branches/safari-603-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (216568 => 216569)

--- branches/safari-603-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2017-05-10 07:40:17 UTC (rev 216568)
+++ branches/safari-603-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2017-05-10 07:40:21 UTC (rev 216569)
@@ -196,6 +196,8 @@
 		7A909A811D877480007E10F8 /* IntPoint.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A909A731D877475007E10F8 /* IntPoint.cpp */; };
 		7A909A821D877480007E10F8 /* IntRect.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A909A741D877475007E10F8 /* IntRect.cpp */; };
 		7A909A831D877480007E10F8 /* IntSize.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A909A751D877475007E10F8 /* IntSize.cpp */; };
+		7A95BDE11E9BEC5F00865498 /* InjectedBundleAppleEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 

[webkit-changes] [216567] branches/safari-603-branch/Source/WebCore

[jmarcell]

Title: [216567] branches/safari-603-branch/Source/WebCore








Revision 216567
Author jmarc...@apple.com
Date 2017-05-10 00:40:11 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r213727. rdar://problem/32086123

Modified Paths

branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/platform/win/ScrollbarThemeWin.cpp




Diff

Modified: branches/safari-603-branch/Source/WebCore/ChangeLog (216566 => 216567)

--- branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 07:22:57 UTC (rev 216566)
+++ branches/safari-603-branch/Source/WebCore/ChangeLog	2017-05-10 07:40:11 UTC (rev 216567)
@@ -1,3 +1,20 @@
+2017-05-09  Jason Marcell  
+
+Cherry-pick r213727. rdar://problem/32086123
+
+2017-03-10  Per Arne Vollan  
+
+[Win] Scrollbars buttons have incorrect size in HiDPI.
+https://bugs.webkit.org/show_bug.cgi?id=169463
+
+Reviewed by Alex Christensen.
+
+There seems to be a bug in DrawThemeBackground when the device context is scaled.
+We can work around this by scaling the drawing rectangle instead.
+
+* platform/win/ScrollbarThemeWin.cpp:
+(WebCore::ScrollbarThemeWin::paintButton):
+
 2017-05-09  Matthew Hanson  
 
 Cherry-pick r216431. rdar://problem/31971208


Modified: branches/safari-603-branch/Source/WebCore/platform/win/ScrollbarThemeWin.cpp (216566 => 216567)

--- branches/safari-603-branch/Source/WebCore/platform/win/ScrollbarThemeWin.cpp	2017-05-10 07:22:57 UTC (rev 216566)
+++ branches/safari-603-branch/Source/WebCore/platform/win/ScrollbarThemeWin.cpp	2017-05-10 07:40:11 UTC (rev 216567)
@@ -331,15 +331,26 @@
 if (scrollbarTheme)
 alphaBlend = IsThemeBackgroundPartiallyTransparent(scrollbarTheme, SP_BUTTON, xpState);
 
-LocalWindowsContext windowsContext(context, rect, alphaBlend);
-RECT themeRect(rect);
-if (scrollbarTheme)
-DrawThemeBackground(scrollbarTheme, windowsContext.hdc(), SP_BUTTON, xpState, , 0);
-else
-::DrawFrameControl(windowsContext.hdc(), , DFC_SCROLL, classicState);
+// There seems to be a bug in DrawThemeBackground when the device context is scaled.
+// We can work around this by scaling the drawing rectangle instead.
+auto scaleFactor = context.scaleFactor().width();
+auto scaledRect = rect;
+scaledRect.scale(scaleFactor);
+context.save();
+context.scale(FloatSize(1.0f / scaleFactor, 1.0f / scaleFactor));
 
-if (!alphaBlend && !context.isInTransparencyLayer())
-DIBPixelData::setRGBABitmapAlpha(windowsContext.hdc(), rect, 255);
+{
+LocalWindowsContext windowsContext(context, scaledRect, alphaBlend);
+RECT themeRect(scaledRect);
+if (scrollbarTheme)
+DrawThemeBackground(scrollbarTheme, windowsContext.hdc(), SP_BUTTON, xpState, , 0);
+else
+::DrawFrameControl(windowsContext.hdc(), , DFC_SCROLL, classicState);
+
+if (!alphaBlend && !context.isInTransparencyLayer())
+DIBPixelData::setRGBABitmapAlpha(windowsContext.hdc(), scaledRect, 255);
+}
+context.restore();
 }
 
 static IntRect gripperRect(int thickness, const IntRect& thumbRect)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216570] branches/safari-603-branch

[jmarcell]

Title: [216570] branches/safari-603-branch








Revision 216570
Author jmarc...@apple.com
Date 2017-05-10 00:40:25 -0700 (Wed, 10 May 2017)


Log Message
Cherry-pick r215748. rdar://problem/31971413

Modified Paths

branches/safari-603-branch/JSTests/ChangeLog
branches/safari-603-branch/Source/_javascript_Core/ChangeLog
branches/safari-603-branch/Source/_javascript_Core/dfg/DFGCSEPhase.cpp
branches/safari-603-branch/Source/_javascript_Core/dfg/DFGClobberize.h
branches/safari-603-branch/Source/_javascript_Core/dfg/DFGHeapLocation.cpp
branches/safari-603-branch/Source/_javascript_Core/dfg/DFGHeapLocation.h


Added Paths

branches/safari-603-branch/JSTests/stress/regress-170990.js




Diff

Modified: branches/safari-603-branch/JSTests/ChangeLog (216569 => 216570)

--- branches/safari-603-branch/JSTests/ChangeLog	2017-05-10 07:40:21 UTC (rev 216569)
+++ branches/safari-603-branch/JSTests/ChangeLog	2017-05-10 07:40:25 UTC (rev 216570)
@@ -1,3 +1,17 @@
+2017-05-09  Jason Marcell  
+
+Cherry-pick r215748. rdar://problem/31971413
+
+2017-04-25  Mark Lam  
+
+Local CSE wrongly CSEs array accesses with different result types.
+https://bugs.webkit.org/show_bug.cgi?id=170990
+
+
+Reviewed by Saam Barati.
+
+* stress/regress-170990.js: Added.
+
 2017-05-09  Matthew Hanson  
 
 Cherry-pick r215596. rdar://problem/31971150


Added: branches/safari-603-branch/JSTests/stress/regress-170990.js (0 => 216570)

--- branches/safari-603-branch/JSTests/stress/regress-170990.js	(rev 0)
+++ branches/safari-603-branch/JSTests/stress/regress-170990.js	2017-05-10 07:40:25 UTC (rev 216570)
@@ -0,0 +1,15 @@
+function getter(arr, operand, resultArr) { 
+ resultArr[0] = arr[operand];
+}
+
+function test(resultArr, arr, getter) {
+getter(arr, 0, resultArr);
+getter(arr, 1, resultArr);
+resultArr[0] == arr[1];
+}
+noInline(run);
+
+var arr = new Uint32Array([0x8000,1]); 
+var resultArr = [];
+for (var i = 0; i < 1; i++)
+test(resultArr, arr, getter);


Modified: branches/safari-603-branch/Source/_javascript_Core/ChangeLog (216569 => 216570)

--- branches/safari-603-branch/Source/_javascript_Core/ChangeLog	2017-05-10 07:40:21 UTC (rev 216569)
+++ branches/safari-603-branch/Source/_javascript_Core/ChangeLog	2017-05-10 07:40:25 UTC (rev 216570)
@@ -1,3 +1,27 @@
+2017-05-09  Jason Marcell  
+
+Cherry-pick r215748. rdar://problem/31971413
+
+2017-04-25  Mark Lam  
+
+Local CSE wrongly CSEs array accesses with different result types.
+https://bugs.webkit.org/show_bug.cgi?id=170990
+
+
+Reviewed by Saam Barati.
+
+The fix is to use different LocationKind enums for the different type of array
+result types.  This makes the HeapLocation values different based on the result
+types, and allows CSE to discern between them.
+
+* dfg/DFGCSEPhase.cpp:
+* dfg/DFGClobberize.h:
+(JSC::DFG::clobberize):
+* dfg/DFGHeapLocation.cpp:
+(WTF::printInternal):
+* dfg/DFGHeapLocation.h:
+(JSC::DFG::indexedPropertyLocForResultType):
+
 2017-05-09  Matthew Hanson  
 
 Cherry-pick r216309. rdar://problem/31971364


Modified: branches/safari-603-branch/Source/_javascript_Core/dfg/DFGCSEPhase.cpp (216569 => 216570)

--- branches/safari-603-branch/Source/_javascript_Core/dfg/DFGCSEPhase.cpp	2017-05-10 07:40:21 UTC (rev 216569)
+++ branches/safari-603-branch/Source/_javascript_Core/dfg/DFGCSEPhase.cpp	2017-05-10 07:40:25 UTC (rev 216570)
@@ -460,6 +460,7 @@
 
 Node* base = m_graph.varArgChild(m_node, 0).node();
 Node* index = m_graph.varArgChild(m_node, 1).node();
+LocationKind indexedPropertyLoc = indexedPropertyLocForResultType(m_node->result());
 
 ArrayMode mode = m_node->arrayMode();
 switch (mode.type()) {
@@ -467,7 +468,7 @@
 if (!mode.isInBounds())
 break;
 heap = HeapLocation(
-IndexedPropertyLoc, IndexedInt32Properties, base, index);
+indexedPropertyLoc, IndexedInt32Properties, base, index);
 break;
 
 case Array::Double:
@@ -474,7 +475,7 @@
 if (!mode.isInBounds())
 break;
 heap = HeapLocation(
-IndexedPropertyLoc, IndexedDoubleProperties, base, index);
+indexedPropertyLoc, 

[webkit-changes] [216566] trunk/Source/WTF

[commit-queue]

Title: [216566] trunk/Source/WTF








Revision 216566
Author commit-qu...@webkit.org
Date 2017-05-10 00:22:57 -0700 (Wed, 10 May 2017)


Log Message
[Win] StaticStringImpl in HTMLNames.cpp aren't constructed
https://bugs.webkit.org/show_bug.cgi?id=171800

Patch by Fujii Hironori  on 2017-05-10
Reviewed by Yusuke Suzuki.

Global variables of StaticStringImpl in HTMLNames.cpp aren't
constructed on Windows since Bug 171586. It seems that
reinterpret_cast prevents constexpr's compile time initialization
in VC++.

* wtf/text/StringImpl.h:
(WTF::StringImplShape::StringImplShape): Added const char* and
const char16_t* members in the union. Do not use reinterpret_cast
in constexpr constructors.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.h




Diff

Modified: trunk/Source/WTF/ChangeLog (216565 => 216566)

--- trunk/Source/WTF/ChangeLog	2017-05-10 05:51:35 UTC (rev 216565)
+++ trunk/Source/WTF/ChangeLog	2017-05-10 07:22:57 UTC (rev 216566)
@@ -1,3 +1,20 @@
+2017-05-10  Fujii Hironori  
+
+[Win] StaticStringImpl in HTMLNames.cpp aren't constructed
+https://bugs.webkit.org/show_bug.cgi?id=171800
+
+Reviewed by Yusuke Suzuki.
+
+Global variables of StaticStringImpl in HTMLNames.cpp aren't
+constructed on Windows since Bug 171586. It seems that
+reinterpret_cast prevents constexpr's compile time initialization
+in VC++.
+
+* wtf/text/StringImpl.h:
+(WTF::StringImplShape::StringImplShape): Added const char* and
+const char16_t* members in the union. Do not use reinterpret_cast
+in constexpr constructors.
+
 2017-05-09  Mark Lam  
 
 Force StaticStringImpl constructor to use the constexpr versions of StringImplShape constructors.


Modified: trunk/Source/WTF/wtf/text/StringImpl.h (216565 => 216566)

--- trunk/Source/WTF/wtf/text/StringImpl.h	2017-05-10 05:51:35 UTC (rev 216565)
+++ trunk/Source/WTF/wtf/text/StringImpl.h	2017-05-10 07:22:57 UTC (rev 216566)
@@ -152,7 +152,7 @@
 constexpr StringImplShape(unsigned refCount, unsigned length, const char ()[charactersCount], unsigned hashAndFlags, ConstructWithConstExprTag)
 : m_refCount(refCount)
 , m_length(length)
-, m_data8(reinterpret_cast(characters))
+, m_data8Char(characters)
 , m_hashAndFlags(hashAndFlags)
 { }
 
@@ -160,7 +160,7 @@
 constexpr StringImplShape(unsigned refCount, unsigned length, const char16_t ()[charactersCount], unsigned hashAndFlags, ConstructWithConstExprTag)
 : m_refCount(refCount)
 , m_length(length)
-, m_data16(reinterpret_cast(characters))
+, m_data16Char(characters)
 , m_hashAndFlags(hashAndFlags)
 { }
 
@@ -169,6 +169,10 @@
 union {
 const LChar* m_data8;
 const UChar* m_data16;
+// It seems that reinterpret_cast prevents constexpr's compile time initialization in VC++.
+// These are needed to avoid reinterpret_cast.
+const char* m_data8Char;
+const char16_t* m_data16Char;
 };
 mutable unsigned m_hashAndFlags;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes