date:20170516

[webkit-changes] [216969] trunk/LayoutTests

2017-05-16 Thread cdumez

Title: [216969] trunk/LayoutTests








Revision 216969
Author cdu...@apple.com
Date 2017-05-16 22:26:10 -0700 (Tue, 16 May 2017)


Log Message
[macOS Debug wk2] Layout test svg/animations/animations-paused-in-background-page-iframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=172183

Reviewed by Andreas Kling.

Fix test flakiness by using shouldBecome() instead of relying on a 30ms timer.

* svg/animations/animations-paused-in-background-page-iframe-expected.txt:
* svg/animations/animations-paused-in-background-page-iframe.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe-expected.txt
trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216968 => 216969)

--- trunk/LayoutTests/ChangeLog	2017-05-17 05:04:49 UTC (rev 216968)
+++ trunk/LayoutTests/ChangeLog	2017-05-17 05:26:10 UTC (rev 216969)
@@ -1,3 +1,15 @@
+2017-05-16  Chris Dumez  
+
+[macOS Debug wk2] Layout test svg/animations/animations-paused-in-background-page-iframe.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=172183
+
+Reviewed by Andreas Kling.
+
+Fix test flakiness by using shouldBecome() instead of relying on a 30ms timer.
+
+* svg/animations/animations-paused-in-background-page-iframe-expected.txt:
+* svg/animations/animations-paused-in-background-page-iframe.html:
+
 2017-05-16  Sam Weinig  
 
 Bring Notification.idl up to spec


Modified: trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe-expected.txt (216968 => 216969)

--- trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe-expected.txt	2017-05-17 05:04:49 UTC (rev 216968)
+++ trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe-expected.txt	2017-05-17 05:26:10 UTC (rev 216969)
@@ -5,7 +5,7 @@
 
 Setting page visibility to hidden
 PASS document.hidden is true
-PASS internals.isImageAnimating(testImage) is false
+PASS internals.isImageAnimating(testImage) became false
 Setting page visibility to visible
 PASS internals.isImageAnimating(testImage) became true
 PASS successfullyParsed is true


Modified: trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe.html (216968 => 216969)

--- trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe.html	2017-05-17 05:04:49 UTC (rev 216968)
+++ trunk/LayoutTests/svg/animations/animations-paused-in-background-page-iframe.html	2017-05-17 05:26:10 UTC (rev 216969)
@@ -8,10 +8,8 @@
 
 function frameLoadedInBackground()
 {
-setTimeout(function() {
-testImage = frame.contentDocument.getElementById("testImage");
-shouldBeFalse("internals.isImageAnimating(testImage)");
-
+testImage = frame.contentDocument.getElementById("testImage");
+shouldBecomeEqual("internals.isImageAnimating(testImage)", "false", function() {
 document._onvisibilitychange_ = null;
 debug("Setting page visibility to visible");
 if (window.testRunner)
@@ -18,7 +16,7 @@
 testRunner.setPageVisibility('visible');
 
 shouldBecomeEqual("internals.isImageAnimating(testImage)", "true", finishJSTest);
-}, 30);
+});
 }
 
 window._onload_ = function() {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216968] trunk/Source/WebCore

2017-05-16 Thread ddkilzer

Title: [216968] trunk/Source/WebCore








Revision 216968
Author ddkil...@apple.com
Date 2017-05-16 22:04:49 -0700 (Tue, 16 May 2017)


Log Message
Remove C-style casts by using xmlDocPtr instead of void*


Reviewed by Alex Christensen.

* dom/TransformSource.h: Fix whitespace indentation.
(typedef PlatformTransformSource): Use xmlDocPtr not void*.
* dom/TransformSourceLibxslt.cpp:
(WebCore::TransformSource::~TransformSource): Remove cast.
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::document): Remove cast.
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::xmlDocPtrFromNode): Remove casts.
* xml/parser/XMLDocumentParser.h:
(WebCore::xmlDocPtrForString): Update declaration to return
xmlDocPtr not void*.
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd): Change type of local
variable from void* to xmlDocPtr.
(WebCore::xmlDocPtrForString): Update to return xmlDocPtr
not void*.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/TransformSource.h
trunk/Source/WebCore/dom/TransformSourceLibxslt.cpp
trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp
trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParser.h
trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216967 => 216968)

--- trunk/Source/WebCore/ChangeLog	2017-05-17 03:22:38 UTC (rev 216967)
+++ trunk/Source/WebCore/ChangeLog	2017-05-17 05:04:49 UTC (rev 216968)
@@ -1,3 +1,27 @@
+2017-05-16  David Kilzer  
+
+Remove C-style casts by using xmlDocPtr instead of void*
+
+
+Reviewed by Alex Christensen.
+
+* dom/TransformSource.h: Fix whitespace indentation.
+(typedef PlatformTransformSource): Use xmlDocPtr not void*.
+* dom/TransformSourceLibxslt.cpp:
+(WebCore::TransformSource::~TransformSource): Remove cast.
+* xml/XSLStyleSheetLibxslt.cpp:
+(WebCore::XSLStyleSheet::document): Remove cast.
+* xml/XSLTProcessorLibxslt.cpp:
+(WebCore::xmlDocPtrFromNode): Remove casts.
+* xml/parser/XMLDocumentParser.h:
+(WebCore::xmlDocPtrForString): Update declaration to return
+xmlDocPtr not void*.
+* xml/parser/XMLDocumentParserLibxml2.cpp:
+(WebCore::XMLDocumentParser::doEnd): Change type of local
+variable from void* to xmlDocPtr.
+(WebCore::xmlDocPtrForString): Update to return xmlDocPtr
+not void*.
+
 2017-05-16  Sam Weinig  
 
 Bring Notification.idl up to spec


Modified: trunk/Source/WebCore/dom/TransformSource.h (216967 => 216968)

--- trunk/Source/WebCore/dom/TransformSource.h	2017-05-17 03:22:38 UTC (rev 216967)
+++ trunk/Source/WebCore/dom/TransformSource.h	2017-05-17 05:04:49 UTC (rev 216968)
@@ -21,6 +21,7 @@
 
 #if ENABLE(XSLT)
 
+#include 
 #include 
 #include 
 #include 
@@ -28,19 +29,19 @@
 
 namespace WebCore {
 
-typedef void* PlatformTransformSource;
+typedef xmlDocPtr PlatformTransformSource;
 
-class TransformSource {
-WTF_MAKE_NONCOPYABLE(TransformSource); WTF_MAKE_FAST_ALLOCATED;
-public:
-explicit TransformSource(const PlatformTransformSource&);
-~TransformSource();
+class TransformSource {
+WTF_MAKE_NONCOPYABLE(TransformSource); WTF_MAKE_FAST_ALLOCATED;
+public:
+explicit TransformSource(const PlatformTransformSource&);
+~TransformSource();
 
-PlatformTransformSource platformSource() const { return m_source; }
+PlatformTransformSource platformSource() const { return m_source; }
 
-private:
-PlatformTransformSource m_source;
-};
+private:
+PlatformTransformSource m_source;
+};
 
 } // namespace WebCore
 


Modified: trunk/Source/WebCore/dom/TransformSourceLibxslt.cpp (216967 => 216968)

--- trunk/Source/WebCore/dom/TransformSourceLibxslt.cpp	2017-05-17 03:22:38 UTC (rev 216967)
+++ trunk/Source/WebCore/dom/TransformSourceLibxslt.cpp	2017-05-17 05:04:49 UTC (rev 216968)
@@ -39,7 +39,7 @@
 
 TransformSource::~TransformSource()
 {
-xmlFreeDoc((xmlDocPtr)m_source);
+xmlFreeDoc(m_source);
 }
 
 }


Modified: trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp (216967 => 216968)

--- trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp	2017-05-17 03:22:38 UTC (rev 216967)
+++ trunk/Source/WebCore/xml/XSLStyleSheetLibxslt.cpp	2017-05-17 05:04:49 UTC (rev 216968)
@@ -103,7 +103,7 @@
 xmlDocPtr XSLStyleSheet::document()
 {
 if (m_embedded && ownerDocument() && ownerDocument()->transformSource())
-return (xmlDocPtr)ownerDocument()->transformSource()->platformSource();
+return ownerDocument()->transformSource()->platformSource();
 return m_stylesheetDoc;
 }
 


Modified: trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp (216967 => 216968)

--- trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp	2017-05-17 03:22:38 UTC (rev 216967)
+++ trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp	2017-05-17 05:04:49

[webkit-changes] [216967] trunk

2017-05-16 Thread commit-queue

Title: [216967] trunk








Revision 216967
Author commit-qu...@webkit.org
Date 2017-05-16 20:22:38 -0700 (Tue, 16 May 2017)


Log Message
Bring Notification.idl up to spec
https://bugs.webkit.org/show_bug.cgi?id=172156

Patch by Sam Weinig  on 2017-05-16
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/notifications/notification.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
Add new files.

* Modules/notifications/Notification.cpp:
(WebCore::Notification::create):
(WebCore::Notification::Notification):
(WebCore::Notification::show):
(WebCore::directionString): Deleted.
(WebCore::Notification::permission): Deleted.
(WebCore::Notification::permissionString): Deleted.
* Modules/notifications/Notification.h:
* Modules/notifications/Notification.idl:
* Modules/notifications/NotificationClient.h:
* Modules/notifications/NotificationDirection.h: Added.
* Modules/notifications/NotificationPermission.h: Added.
* Modules/notifications/NotificationPermission.idl: Added.
* Modules/notifications/NotificationPermissionCallback.h:
* Modules/notifications/NotificationPermissionCallback.idl:
Bring up to spec, replacing DOMStrings with enums where appropriate and adding
additional readonly properties to Notification to mirror options provided
in construction.

Source/WebKit/mac:

* WebCoreSupport/WebNotificationClient.h:
* WebCoreSupport/WebNotificationClient.mm:
(generateNotificationID):
(WebNotificationClient::show):
(WebNotificationClient::cancel):
(WebNotificationClient::clearNotifications):
(WebNotificationClient::notificationObjectDestroyed):
(WebNotificationClient::requestPermission):
(WebNotificationClient::hasPendingPermissionRequests):
(WebNotificationClient::checkPermission):
(-[WebNotificationPolicyListener allow]):
(-[WebNotificationPolicyListener deny]):
* WebView/WebNotification.mm:
(-[WebNotification iconURL]):
(-[WebNotification dir]):
Simplify #ifdefs and update for enum vs String usage.

Source/WebKit2:

* Shared/WebCoreArgumentCoders.h:
* UIProcess/API/C/WKNotification.cpp:
(WKNotificationCopyDir):
* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
(WebKit::WebNotification::dir):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show):
* UIProcess/Notifications/WebNotificationManagerProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest):
(WebKit::NotificationPermissionRequestManager::permissionLevel):
(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::policyForOrigin):
(WebKit::WebNotificationManager::show):
* WebProcess/WebCoreSupport/WebNotificationClient.cpp:
(WebKit::WebNotificationClient::checkPermission):
* WebProcess/WebCoreSupport/WebNotificationClient.h:
Update for enum vs String usage.

LayoutTests:

* http/tests/notifications/notification-expected.txt: Added.
* http/tests/notifications/notification.html: Added.
Add test for basic Notification API functionality.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/notifications/Notification.cpp
trunk/Source/WebCore/Modules/notifications/Notification.h
trunk/Source/WebCore/Modules/notifications/Notification.idl
trunk/Source/WebCore/Modules/notifications/NotificationClient.h
trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.h
trunk/Source/WebCore/Modules/notifications/NotificationPermissionCallback.idl
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebNotificationClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebNotificationClient.mm
trunk/Source/WebKit/mac/WebView/WebNotification.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.h
trunk/Source/WebKit2/UIProcess/API/C/WKNotification.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotification.h
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/WebProcess/Notifications/NotificationPermissionRequestManager.cpp
trunk/Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp

[webkit-changes] [216966] trunk

2017-05-16 Thread zalan

Title: [216966] trunk








Revision 216966
Author za...@apple.com
Date 2017-05-16 19:33:28 -0700 (Tue, 16 May 2017)


Log Message
Do not skip  children when collecting content for innerText.
https://bugs.webkit.org/show_bug.cgi?id=172113


Reviewed by Ryosuke Niwa and Brent Fulgham.

Source/WebCore:

"display: contents" elements do not generate renderers but their children might.
This patch ensure that we don't skip them while collecting text content.

Test: fast/text/inner-text-should-include-slot-subtree.html

* editing/TextIterator.cpp:
(WebCore::TextIterator::advance):

LayoutTests:

* fast/text/inner-text-should-include-slot-subtree-expected.txt: Added.
* fast/text/inner-text-should-include-slot-subtree.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/text-iterator/find-string-on-flat-tree-expected.txt
trunk/LayoutTests/editing/text-iterator/find-string-on-flat-tree.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextIterator.cpp


Added Paths

trunk/LayoutTests/fast/text/inner-text-should-include-slot-subtree-expected.txt
trunk/LayoutTests/fast/text/inner-text-should-include-slot-subtree.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216965 => 216966)

--- trunk/LayoutTests/ChangeLog	2017-05-17 02:11:43 UTC (rev 216965)
+++ trunk/LayoutTests/ChangeLog	2017-05-17 02:33:28 UTC (rev 216966)
@@ -1,3 +1,14 @@
+2017-05-16  Zalan Bujtas  
+
+Do not skip  children when collecting content for innerText.
+https://bugs.webkit.org/show_bug.cgi?id=172113
+
+
+Reviewed by Ryosuke Niwa and Brent Fulgham.
+
+* fast/text/inner-text-should-include-slot-subtree-expected.txt: Added.
+* fast/text/inner-text-should-include-slot-subtree.html: Added.
+
 2017-05-16  Jiewen Tan  
 
 Unreviewed, fix LayoutTests/plugins/navigator-plugin-crash.html


Modified: trunk/LayoutTests/editing/text-iterator/find-string-on-flat-tree-expected.txt (216965 => 216966)

--- trunk/LayoutTests/editing/text-iterator/find-string-on-flat-tree-expected.txt	2017-05-17 02:11:43 UTC (rev 216965)
+++ trunk/LayoutTests/editing/text-iterator/find-string-on-flat-tree-expected.txt	2017-05-17 02:33:28 UTC (rev 216966)
@@ -77,6 +77,7 @@
 PASS internals.countFindMatches('in-', []) is 4
 PASS internals.countFindMatches('in-shadow in-document', ['DoNotTraverseFlatTree']) is 0
 PASS internals.countFindMatches('in-shadow in-document', []) is 0
+PASS rangeText(internals.rangeOfString('inside-display-none', null, [])) is null
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/editing/text-iterator/find-string-on-flat-tree.html (216965 => 216966)

--- trunk/LayoutTests/editing/text-iterator/find-string-on-flat-tree.html	2017-05-17 02:11:43 UTC (rev 216965)
+++ trunk/LayoutTests/editing/text-iterator/find-string-on-flat-tree.html	2017-05-17 02:33:28 UTC (rev 216966)
@@ -2,6 +2,7 @@
 
 
 in-document unslotted slotted unslotted in-document
+inside-display-none