[webkit-changes] [236497] trunk/Source/WebKit
Title: [236497] trunk/Source/WebKit
Revision 236497
Author rn...@webkit.org
Date 2018-09-25 22:26:30 -0700 (Tue, 25 Sep 2018)
Log Message
Make frame flattening an internal debug feature
https://bugs.webkit.org/show_bug.cgi?id=189984
Reviewed by Simon Fraser.
Made frame flattening a runtime switchable from internal debug menu.
To avoid having to enumerate three distinct values in the settings, made it a boolean flag in WKPreference.
That's what's exposd as an API anyway.
* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFrameFlatteningEnabled):
(WKPreferencesGetFrameFlatteningEnabled):
* UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_get_enable_frame_flattening):
(webkit_settings_set_enable_frame_flattening):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (236496 => 236497)
--- trunk/Source/WebKit/ChangeLog 2018-09-26 05:16:22 UTC (rev 236496)
+++ trunk/Source/WebKit/ChangeLog 2018-09-26 05:26:30 UTC (rev 236497)
@@ -1,3 +1,26 @@
+2018-09-25 Ryosuke Niwa
+
+Make frame flattening an internal debug feature
+https://bugs.webkit.org/show_bug.cgi?id=189984
+
+Reviewed by Simon Fraser.
+
+Made frame flattening a runtime switchable from internal debug menu.
+
+To avoid having to enumerate three distinct values in the settings, made it a boolean flag in WKPreference.
+That's what's exposd as an API anyway.
+
+* Shared/WebPreferences.yaml:
+* Shared/WebPreferencesDefaultValues.h:
+* UIProcess/API/C/WKPreferences.cpp:
+(WKPreferencesSetFrameFlatteningEnabled):
+(WKPreferencesGetFrameFlatteningEnabled):
+* UIProcess/API/glib/WebKitSettings.cpp:
+(webkit_settings_get_enable_frame_flattening):
+(webkit_settings_set_enable_frame_flattening):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::updatePreferences):
+
2018-09-25 Eric Carlson
[MediaStream] Add Mac window capture source
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (236496 => 236497)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-09-26 05:16:22 UTC (rev 236496)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-09-26 05:26:30 UTC (rev 236497)
@@ -886,10 +886,13 @@
defaultValue: 0
webcoreBinding: custom
-FrameFlattening:
- type: uint32_t
+FrameFlatteningEnabled:
+ type: bool
defaultValue: DEFAULT_FRAME_FLATTENING
webcoreBinding: custom
+ humanReadableName: "Frame flattening"
+ humanReadableDescription: "Enable frame flattening, which adjusts the height of an iframe to fit its contents"
+ category: internal
StandardFontFamily:
type: String
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (236496 => 236497)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2018-09-26 05:16:22 UTC (rev 236496)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2018-09-26 05:26:30 UTC (rev 236497)
@@ -60,7 +60,7 @@
#if PLATFORM(IOS)
#define DEFAULT_ALLOWS_PICTURE_IN_PICTURE_MEDIA_PLAYBACK true
#define DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED false
-#define DEFAULT_FRAME_FLATTENING FrameFlattening::FullyEnabled
+#define DEFAULT_FRAME_FLATTENING true
#define DEFAULT_SHOULD_PRINT_BACKGROUNDS true
#define DEFAULT_TEXT_AREAS_ARE_RESIZABLE false
#define DEFAULT_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY false
@@ -79,7 +79,7 @@
#else
#define DEFAULT_ALLOWS_PICTURE_IN_PICTURE_MEDIA_PLAYBACK false
#define DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED true
-#define DEFAULT_FRAME_FLATTENING FrameFlattening::Disabled
+#define DEFAULT_FRAME_FLATTENING false
#define DEFAULT_SHOULD_PRINT_BACKGROUNDS false
#define DEFAULT_TEXT_AREAS_ARE_RESIZABLE true
#define DEFAULT_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY true
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (236496 => 236497)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-09-26 05:16:22 UTC (rev 236496)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-09-26 05:26:30 UTC (rev 236497)
@@ -160,14 +160,12 @@
void WKPreferencesSetFrameFlatteningEnabled(WKPreferencesRef preferencesRef, bool frameFlatteningEnabled)
{
-// FIXME: Expose more frame flattening values.
-toImpl(preferencesRef)->setFrameFlattening(frameFlatteningEnabled ? static_cast(WebCore::FrameFlattening::FullyEnabled) : static_cast(WebCore::FrameFlattening::Disabled));
+toImpl(preferencesRef)->setFrameFlatteningEnabled(frameFlatteningEnabled);
}
bool
[webkit-changes] [236496] trunk
Title: [236496] trunk
Revision 236496
Author yusukesuz...@slowstart.org
Date 2018-09-25 22:16:22 -0700 (Tue, 25 Sep 2018)
Log Message
[JSC] Optimize Array#lastIndexOf
https://bugs.webkit.org/show_bug.cgi?id=189780
Reviewed by Saam Barati.
JSTests:
* stress/array-lastindexof-array-prototype-trap.js: Added.
(shouldBe):
(AncestorArray.prototype.get 2):
(AncestorArray):
* stress/array-lastindexof-have-a-bad-time-c-runtime.js: Added.
(shouldBe):
* stress/array-lastindexof-hole-nan.js: Added.
(shouldBe):
(throw.new.Error):
* stress/array-lastindexof-infinity.js: Added.
(shouldBe):
(throw.new.Error):
* stress/array-lastindexof-negative-zero.js: Added.
(shouldBe):
(throw.new.Error):
* stress/array-lastindexof-own-getter.js: Added.
(shouldBe):
(throw.new.Error.get array):
(get array):
* stress/array-lastindexof-prototype-trap.js: Added.
(shouldBe):
(DerivedArray.prototype.get 2):
(DerivedArray):
Source/_javascript_Core:
Optimize Array#lastIndexOf as the same to Array#indexOf. We add a fast path
for JSArray with contiguous storage.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncLastIndexOf):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
Added Paths
trunk/JSTests/stress/array-lastindexof-array-prototype-trap.js
trunk/JSTests/stress/array-lastindexof-cached-length.js
trunk/JSTests/stress/array-lastindexof-fast-path-effects.js
trunk/JSTests/stress/array-lastindexof-have-a-bad-time-c-runtime.js
trunk/JSTests/stress/array-lastindexof-hole-nan.js
trunk/JSTests/stress/array-lastindexof-infinity.js
trunk/JSTests/stress/array-lastindexof-negative-zero.js
trunk/JSTests/stress/array-lastindexof-own-getter.js
trunk/JSTests/stress/array-lastindexof-prototype-trap.js
Diff
Modified: trunk/JSTests/ChangeLog (236495 => 236496)
--- trunk/JSTests/ChangeLog 2018-09-26 03:14:09 UTC (rev 236495)
+++ trunk/JSTests/ChangeLog 2018-09-26 05:16:22 UTC (rev 236496)
@@ -1,3 +1,34 @@
+2018-09-20 Yusuke Suzuki
+
+[JSC] Optimize Array#lastIndexOf
+https://bugs.webkit.org/show_bug.cgi?id=189780
+
+Reviewed by Saam Barati.
+
+* stress/array-lastindexof-array-prototype-trap.js: Added.
+(shouldBe):
+(AncestorArray.prototype.get 2):
+(AncestorArray):
+* stress/array-lastindexof-have-a-bad-time-c-runtime.js: Added.
+(shouldBe):
+* stress/array-lastindexof-hole-nan.js: Added.
+(shouldBe):
+(throw.new.Error):
+* stress/array-lastindexof-infinity.js: Added.
+(shouldBe):
+(throw.new.Error):
+* stress/array-lastindexof-negative-zero.js: Added.
+(shouldBe):
+(throw.new.Error):
+* stress/array-lastindexof-own-getter.js: Added.
+(shouldBe):
+(throw.new.Error.get array):
+(get array):
+* stress/array-lastindexof-prototype-trap.js: Added.
+(shouldBe):
+(DerivedArray.prototype.get 2):
+(DerivedArray):
+
2018-09-25 Saam Barati
Calls to baselineCodeBlockForOriginAndBaselineCodeBlock in operationMaterializeObjectInOSR should actually pass in the baseline CodeBlock
Added: trunk/JSTests/stress/array-lastindexof-array-prototype-trap.js (0 => 236496)
--- trunk/JSTests/stress/array-lastindexof-array-prototype-trap.js (rev 0)
+++ trunk/JSTests/stress/array-lastindexof-array-prototype-trap.js 2018-09-26 05:16:22 UTC (rev 236496)
@@ -0,0 +1,45 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+class AncestorArray extends Object {
+get 2() {
+this.called = true;
+return 42;
+}
+}
+
+Array.prototype.__proto__ = AncestorArray.prototype;
+
+{
+let array = [];
+array.length = 42;
+shouldBe(array.lastIndexOf(42), 2);
+shouldBe(array.called, true);
+}
+{
+let array = [20, 20];
+array.length = 42;
+shouldBe(array.lastIndexOf(42), 2);
+shouldBe(array.called, true);
+}
+{
+let array = ["Hello"];
+array.length = 42;
+shouldBe(array.lastIndexOf(42), 2);
+shouldBe(array.called, true);
+}
+{
+let array = [42.195];
+array.length = 42;
+shouldBe(array.lastIndexOf(42), 2);
+shouldBe(array.called, true);
+}
+{
+let array = ["Hello"];
+array.length = 42;
+ensureArrayStorage(array);
+shouldBe(array.lastIndexOf(42), 2);
+shouldBe(array.called, true);
+}
Added: trunk/JSTests/stress/array-lastindexof-cached-length.js (0 => 236496)
--- trunk/JSTests/stress/array-lastindexof-cached-length.js (rev 0)
+++ trunk/JSTests/stress/array-lastindexof-cached-length.js 2018-09-26 05:16:22 UTC (rev 236496)
@@ -0,0 +1,24 @@
+function assert(b) {
+if (!b)
+throw new Error;
+
+}
+
+const originalLength = 1;
+let arr = new Proxy([], {
+has(...args) {
+assert(parseInt(args[1]) < originalLength);
+
[webkit-changes] [236495] trunk
Title: [236495] trunk
Revision 236495
Author sbar...@apple.com
Date 2018-09-25 20:14:09 -0700 (Tue, 25 Sep 2018)
Log Message
Calls to baselineCodeBlockForOriginAndBaselineCodeBlock in operationMaterializeObjectInOSR should actually pass in the baseline CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=189940
Reviewed by Mark Lam.
JSTests:
* stress/use-baseline-codeblock-materialize-osr-exit.js: Added.
Source/_javascript_Core:
We were calling baselineCodeBlockForOriginAndBaselineCodeBlock with the FTL
CodeBlock. There is nothing semantically wrong with doing that (except for
poor naming), however, the poor naming here led us to make a real semantic
mistake. We wanted the baseline CodeBlock's constant pool, but we were
accessing the FTL CodeBlock's constant pool accidentally. We need to
access the baseline CodeBlock's constant pool when we update the NewArrayBuffer
constant value.
* bytecode/InlineCallFrame.h:
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
* ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/InlineCallFrame.h
trunk/Source/_javascript_Core/ftl/FTLOperations.cpp
Added Paths
trunk/JSTests/stress/use-baseline-codeblock-materialize-osr-exit.js
Diff
Modified: trunk/JSTests/ChangeLog (236494 => 236495)
--- trunk/JSTests/ChangeLog 2018-09-26 02:33:02 UTC (rev 236494)
+++ trunk/JSTests/ChangeLog 2018-09-26 03:14:09 UTC (rev 236495)
@@ -1,3 +1,13 @@
+2018-09-25 Saam Barati
+
+Calls to baselineCodeBlockForOriginAndBaselineCodeBlock in operationMaterializeObjectInOSR should actually pass in the baseline CodeBlock
+https://bugs.webkit.org/show_bug.cgi?id=189940
+
+
+Reviewed by Mark Lam.
+
+* stress/use-baseline-codeblock-materialize-osr-exit.js: Added.
+
2018-09-24 Saam Barati
Array.prototype.indexOf fast path needs to ensure the length is still valid after performing effects
Added: trunk/JSTests/stress/use-baseline-codeblock-materialize-osr-exit.js (0 => 236495)
--- trunk/JSTests/stress/use-baseline-codeblock-materialize-osr-exit.js (rev 0)
+++ trunk/JSTests/stress/use-baseline-codeblock-materialize-osr-exit.js 2018-09-26 03:14:09 UTC (rev 236495)
@@ -0,0 +1,13 @@
+//@ runDefault("--jitPolicyScale=0")
+
+function foo() {
+let j = 0;
+let arr = [0];
+arr.foo = 0;
+for (var i = 0; i < 1024; i++) {
+arr[0] = new Array(1024);
+}
+}
+
+foo();
+foo();
Modified: trunk/Source/_javascript_Core/ChangeLog (236494 => 236495)
--- trunk/Source/_javascript_Core/ChangeLog 2018-09-26 02:33:02 UTC (rev 236494)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-09-26 03:14:09 UTC (rev 236495)
@@ -1,3 +1,24 @@
+2018-09-25 Saam Barati
+
+Calls to baselineCodeBlockForOriginAndBaselineCodeBlock in operationMaterializeObjectInOSR should actually pass in the baseline CodeBlock
+https://bugs.webkit.org/show_bug.cgi?id=189940
+
+
+Reviewed by Mark Lam.
+
+We were calling baselineCodeBlockForOriginAndBaselineCodeBlock with the FTL
+CodeBlock. There is nothing semantically wrong with doing that (except for
+poor naming), however, the poor naming here led us to make a real semantic
+mistake. We wanted the baseline CodeBlock's constant pool, but we were
+accessing the FTL CodeBlock's constant pool accidentally. We need to
+access the baseline CodeBlock's constant pool when we update the NewArrayBuffer
+constant value.
+
+* bytecode/InlineCallFrame.h:
+(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
+* ftl/FTLOperations.cpp:
+(JSC::FTL::operationMaterializeObjectInOSR):
+
2018-09-25 Joseph Pecoraro
Web Inspector: Stricter block syntax in generated ObjC protocol interfaces
Modified: trunk/Source/_javascript_Core/bytecode/InlineCallFrame.h (236494 => 236495)
--- trunk/Source/_javascript_Core/bytecode/InlineCallFrame.h 2018-09-26 02:33:02 UTC (rev 236494)
+++ trunk/Source/_javascript_Core/bytecode/InlineCallFrame.h 2018-09-26 03:14:09 UTC (rev 236495)
@@ -240,6 +240,7 @@
inline CodeBlock* baselineCodeBlockForOriginAndBaselineCodeBlock(const CodeOrigin& codeOrigin, CodeBlock* baselineCodeBlock)
{
+ASSERT(baselineCodeBlock->jitType() == JITCode::BaselineJIT);
if (codeOrigin.inlineCallFrame)
return baselineCodeBlockForInlineCallFrame(codeOrigin.inlineCallFrame);
return baselineCodeBlock;
Modified: trunk/Source/_javascript_Core/ftl/FTLOperations.cpp (236494 => 236495)
--- trunk/Source/_javascript_Core/ftl/FTLOperations.cpp 2018-09-26 02:33:02 UTC (rev 236494)
+++ trunk/Source/_javascript_Core/ftl/FTLOperations.cpp 2018-09-26 03:14:09 UTC (rev 236495)
@@ -225,7 +225,7 @@
RELEASE_ASSERT(table);
CodeBlock* codeBlock = baselineCodeBlockForOriginAndBaselineCodeBlock(
-
[webkit-changes] [236494] trunk/Source
Title: [236494] trunk/Source Revision 236494 Author eric.carl...@apple.com Date 2018-09-25 19:33:02 -0700 (Tue, 25 Sep 2018) Log Message [MediaStream] Add Mac window capture source https://bugs.webkit.org/show_bug.cgi?id=189958 Reviewed by Youenn Fablet. Source/WebCore: * SourcesCocoa.txt: Add WindowDisplayCaptureSourceMac. * WebCore.xcodeproj/project.pbxproj: Ditto. * platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp: (WebCore::DisplayCaptureManagerCocoa::captureDevices): Include window "devices". (WebCore::DisplayCaptureManagerCocoa::updateWindowCaptureDevices): New. (WebCore::DisplayCaptureManagerCocoa::windowCaptureDeviceWithPersistentID): New. (WebCore::DisplayCaptureManagerCocoa::captureDeviceWithPersistentID): Include window devices. * platform/mediastream/mac/DisplayCaptureManagerCocoa.h: * platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp: (WebCore::DisplayCaptureSourceCocoa::DisplayCaptureSourceCocoa): (WebCore::DisplayCaptureSourceCocoa::settings): Use frameSize, report surface type and logical surface. (WebCore::DisplayCaptureSourceCocoa::settingsDidChange): Clear m_lastSampleBuffer when size changes. (WebCore::DisplayCaptureSourceCocoa::frameSize const): New, return size() or intrinsic size. (WebCore::DisplayCaptureSourceCocoa::setIntrinsicSize): New. (WebCore::DisplayCaptureSourceCocoa::emitFrame): generateFrame now returns a CVPixelBuffer so derived classes don't have to deal with resizing/transforming. * platform/mediastream/mac/DisplayCaptureSourceCocoa.h: * platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp: * platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h: * platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm: (WebCore::ScreenDisplayCaptureSourceMac::ScreenDisplayCaptureSourceMac): Add fixme. (WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream): Update intrinsic size when width/height changes. (WebCore::ScreenDisplayCaptureSourceMac::generateFrame): Return a CVPixelBuffer. * platform/mediastream/mac/WindowDisplayCaptureSourceMac.h: Added. * platform/mediastream/mac/WindowDisplayCaptureSourceMac.mm: Added. (WebCore::anyOfCGWindow): (WebCore::windowDescription): (WebCore::WindowDisplayCaptureSourceMac::create): (WebCore::WindowDisplayCaptureSourceMac::WindowDisplayCaptureSourceMac): (WebCore::WindowDisplayCaptureSourceMac::windowImage): (WebCore::WindowDisplayCaptureSourceMac::generateFrame): (WebCore::WindowDisplayCaptureSourceMac::pixelBufferFromCGImage): (WebCore::WindowDisplayCaptureSourceMac::windowCaptureDeviceWithPersistentID): (WebCore::WindowDisplayCaptureSourceMac::windowCaptureDevices): Source/WebKit: * UIProcess/UserMediaPermissionRequestManagerProxy.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::beginMonitoringCaptureDevices): Sync with webcore prefs before listening to device changes so we listen on the correct devices. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/cv/PixelBufferResizer.mm trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureManagerCocoa.h trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp trunk/Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h trunk/Source/WebCore/platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Added Paths trunk/Source/WebCore/platform/mediastream/mac/WindowDisplayCaptureSourceMac.h trunk/Source/WebCore/platform/mediastream/mac/WindowDisplayCaptureSourceMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (236493 => 236494) --- trunk/Source/WebCore/ChangeLog 2018-09-26 02:03:00 UTC (rev 236493) +++ trunk/Source/WebCore/ChangeLog 2018-09-26 02:33:02 UTC (rev 236494) @@ -1,3 +1,53 @@ +2018-09-25 Eric Carlson + +[MediaStream] Add Mac window capture source +https://bugs.webkit.org/show_bug.cgi?id=189958 + + +Reviewed by Youenn Fablet. + +* SourcesCocoa.txt: Add WindowDisplayCaptureSourceMac. +* WebCore.xcodeproj/project.pbxproj: Ditto. + +* platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp: +(WebCore::DisplayCaptureManagerCocoa::captureDevices): Include window "devices". +(WebCore::DisplayCaptureManagerCocoa::updateWindowCaptureDevices): New. +(WebCore::DisplayCaptureManagerCocoa::windowCaptureDeviceWithPersistentID): New. +(WebCore::DisplayCaptureManagerCocoa::captureDeviceWithPersistentID): Include window devices. +* platform/mediastream/mac/DisplayCaptureManagerCocoa.h: + +*
[webkit-changes] [236493] trunk/Source/ThirdParty/libwebrtc
Title: [236493] trunk/Source/ThirdParty/libwebrtc Revision 236493 Author ryanhad...@apple.com Date 2018-09-25 19:03:00 -0700 (Tue, 25 Sep 2018) Log Message Import libvpx source code https://bugs.webkit.org/show_bug.cgi?id=189954 Another unreviewed build fix attempt. * Source/third_party/libvpx/source/libvpx/VPX.framework: Remove unneeded folder. Modified Paths trunk/Source/ThirdParty/libwebrtc/ChangeLog Removed Paths trunk/Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/VPX.framework/ Diff Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (236492 => 236493) --- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-09-26 01:27:54 UTC (rev 236492) +++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-09-26 02:03:00 UTC (rev 236493) @@ -1,3 +1,12 @@ +2018-09-25 Ryan Haddad + +Import libvpx source code +https://bugs.webkit.org/show_bug.cgi?id=189954 + +Another unreviewed build fix attempt. + +* Source/third_party/libvpx/source/libvpx/VPX.framework: Remove unneeded folder. + 2018-09-25 Youenn Fablet Import libvpx source code ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236492] trunk/Source/WebKit
Title: [236492] trunk/Source/WebKit
Revision 236492
Author cdu...@apple.com
Date 2018-09-25 18:27:54 -0700 (Tue, 25 Sep 2018)
Log Message
Unreviewed, rolling out r236471 and r236480.
Seems to be causing some flaky crashes
Reverted changesets:
"UIProcess should process incoming sync IPC from WebProcess
when waiting for a sync IPC reply from it"
https://bugs.webkit.org/show_bug.cgi?id=189927
https://trac.webkit.org/changeset/236471
"Revert some of the changes in r236471"
https://bugs.webkit.org/show_bug.cgi?id=189973
https://trac.webkit.org/changeset/236480
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (236491 => 236492)
--- trunk/Source/WebKit/ChangeLog 2018-09-26 01:18:53 UTC (rev 236491)
+++ trunk/Source/WebKit/ChangeLog 2018-09-26 01:27:54 UTC (rev 236492)
@@ -1,3 +1,20 @@
+2018-09-25 Chris Dumez
+
+Unreviewed, rolling out r236471 and r236480.
+
+Seems to be causing some flaky crashes
+
+Reverted changesets:
+
+"UIProcess should process incoming sync IPC from WebProcess
+when waiting for a sync IPC reply from it"
+https://bugs.webkit.org/show_bug.cgi?id=189927
+https://trac.webkit.org/changeset/236471
+
+"Revert some of the changes in r236471"
+https://bugs.webkit.org/show_bug.cgi?id=189973
+https://trac.webkit.org/changeset/236480
+
2018-09-25 Conrad Shultz
Enable customization of the file upload panel
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (236491 => 236492)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-09-26 01:18:53 UTC (rev 236491)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-09-26 01:27:54 UTC (rev 236492)
@@ -4013,7 +4013,7 @@
if (!fromAPI)
m_pageLoadState.clearPendingAPIRequestURL(transaction);
-auto* frame = m_process->webFrame(frameID);
+WebFrameProxy* frame = m_process->webFrame(frameID);
MESSAGE_CHECK(frame);
MESSAGE_CHECK_URL(request.url());
MESSAGE_CHECK_URL(originalRequest.url());
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp (236491 => 236492)
--- trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2018-09-26 01:18:53 UTC (rev 236491)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2018-09-26 01:27:54 UTC (rev 236492)
@@ -111,8 +111,6 @@
Ref WebFrame::createWithCoreMainFrame(WebPage* page, WebCore::Frame* coreFrame)
{
auto frame = create(std::unique_ptr(static_cast(>loader().client(;
-// DispatchMessageEvenWhenWaitingForSyncReply SendOption is needed to ensure that this IPC always gets received before the DecidePolicyForNavigationSync synchronous
-// IPC for this frame.
page->send(Messages::WebPageProxy::DidCreateMainFrame(frame->frameID()), page->pageID(), IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply);
frame->m_coreFrame = coreFrame;
@@ -124,8 +122,6 @@
Ref WebFrame::createSubframe(WebPage* page, const String& frameName, HTMLFrameOwnerElement* ownerElement)
{
auto frame = create(std::make_unique());
-// DispatchMessageEvenWhenWaitingForSyncReply SendOption is needed to ensure that this IPC always gets received before the DecidePolicyForNavigationSync synchronous
-// IPC for this frame.
page->send(Messages::WebPageProxy::DidCreateSubframe(frame->frameID()), page->pageID(), IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply);
auto coreFrame = Frame::create(page->corePage(), ownerElement, frame->m_frameLoaderClient.get());
Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (236491 => 236492)
--- trunk/Source/WebKit/WebProcess/WebProcess.cpp 2018-09-26 01:18:53 UTC (rev 236491)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp 2018-09-26 01:27:54 UTC (rev 236492)
@@ -251,6 +251,12 @@
supplement->initializeConnection(connection);
m_webConnection = WebConnectionToUIProcess::create(this);
+
+// In order to ensure that the asynchronous messages that are used for notifying the UI process
+// about when WebFrame objects come and go are always delivered before the synchronous policy messages,
+// use this flag to force synchronous messages to be treated as asynchronous messages in the UI process
+// unless when doing so would lead to a deadlock.
+connection->setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage(true);
}
void WebProcess::initializeWebProcess(WebProcessCreationParameters&& parameters)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236491] trunk/Source/WebKit
Title: [236491] trunk/Source/WebKit Revision 236491 Author conrad_shu...@apple.com Date 2018-09-25 18:18:53 -0700 (Tue, 25 Sep 2018) Log Message Enable customization of the file upload panel https://bugs.webkit.org/show_bug.cgi?id=189970 Reviewed by Wenson Hsieh. With this change, platform implementations can override, or implement in a category, +[WKContentView _fileUploadPanelClass] as needed. * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _showRunOpenPanel:resultListener:]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: trunk/Source/WebKit/ChangeLog (236490 => 236491) --- trunk/Source/WebKit/ChangeLog 2018-09-26 00:24:52 UTC (rev 236490) +++ trunk/Source/WebKit/ChangeLog 2018-09-26 01:18:53 UTC (rev 236491) @@ -1,3 +1,17 @@ +2018-09-25 Conrad Shultz + +Enable customization of the file upload panel +https://bugs.webkit.org/show_bug.cgi?id=189970 + +Reviewed by Wenson Hsieh. + +With this change, platform implementations can override, or implement in a category, ++[WKContentView _fileUploadPanelClass] as needed. + +* UIProcess/ios/WKContentViewInteraction.h: +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView _showRunOpenPanel:resultListener:]): + 2018-09-25 Chris Dumez Unreviewed, rolling out r236420 and r236458. Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (236490 => 236491) --- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2018-09-26 00:24:52 UTC (rev 236490) +++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2018-09-26 01:18:53 UTC (rev 236491) @@ -404,4 +404,8 @@ @end #endif +@interface WKContentView (WKFileUploadPanel) ++ (Class)_fileUploadPanelClass; +@end + #endif // PLATFORM(IOS) Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (236490 => 236491) --- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-09-26 00:24:52 UTC (rev 236490) +++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-09-26 01:18:53 UTC (rev 236491) @@ -117,6 +117,10 @@ #import "WKFormColorControl.h" #endif +#if USE(APPLE_INTERNAL_SDK) && __has_include() +#import +#endif + @interface UIEvent(UIEventInternal) @property (nonatomic, assign) UIKeyboardInputFlags _inputFlags; @end @@ -4731,7 +4735,14 @@ if (_fileUploadPanel) return; -_fileUploadPanel = adoptNS([[WKFileUploadPanel alloc] initWithView:self]); +Class ownClass = self.class; +Class panelClass = nil; +if ([ownClass respondsToSelector:@selector(_fileUploadPanelClass)]) +panelClass = [ownClass _fileUploadPanelClass]; +if (!panelClass) +panelClass = [WKFileUploadPanel class]; + +_fileUploadPanel = adoptNS([[panelClass alloc] initWithView:self]); [_fileUploadPanel setDelegate:self]; [_fileUploadPanel presentWithParameters:parameters resultListener:listener]; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236490] trunk
Title: [236490] trunk Revision 236490 Author justin_...@apple.com Date 2018-09-25 17:24:52 -0700 (Tue, 25 Sep 2018) Log Message WebGL 2 Conformance: primitive restart and draw_primitive_restart WebGL2 sample https://bugs.webkit.org/show_bug.cgi?id=189625 Reviewed by Dean Jackson. Source/WebCore: Ref test: webgl/webgl2-primitive-restart.html. Implement support for Primitive Restart Fixed Index as expected by the WebGL 2 specifications. * html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::validateIndexArrayConservative): * html/canvas/WebGLRenderingContextBase.h: (WebCore::WebGLRenderingContextBase::getLastIndex): Template that must be defined in header. * html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::validateIndexArrayPrecise): * platform/graphics/GraphicsContext3D.h: * platform/graphics/cocoa/GraphicsContext3DCocoa.mm: (WebCore::GraphicsContext3D::GraphicsContext3D): * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: (WebCore::GraphicsContext3D::primitiveRestartIndex): LayoutTests: Implement support for Primitive Restart Fixed Index as expected by the WebGL 2 specifications. * TestExpectations: Skip some flaky tests between different Mac machines under 2.0.0. * webgl/webgl2-primitive-restart.html: Canary ref test to be run as part of LayoutTests suite. * webgl/webgl2-primitive-restart-expected.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp Added Paths trunk/LayoutTests/webgl/webgl2-primitive-restart-expected.html trunk/LayoutTests/webgl/webgl2-primitive-restart.html Diff Modified: trunk/LayoutTests/ChangeLog (236489 => 236490) --- trunk/LayoutTests/ChangeLog 2018-09-26 00:13:59 UTC (rev 236489) +++ trunk/LayoutTests/ChangeLog 2018-09-26 00:24:52 UTC (rev 236490) @@ -1,3 +1,18 @@ +2018-09-25 Justin Fan + +WebGL 2 Conformance: primitive restart and draw_primitive_restart WebGL2 sample +https://bugs.webkit.org/show_bug.cgi?id=189625 + + +Reviewed by Dean Jackson. + +Implement support for Primitive Restart Fixed Index as expected +by the WebGL 2 specifications. + +* TestExpectations: Skip some flaky tests between different Mac machines under 2.0.0. +* webgl/webgl2-primitive-restart.html: Canary ref test to be run as part of LayoutTests suite. +* webgl/webgl2-primitive-restart-expected.html: + 2018-09-25 Chris Dumez Unreviewed, rolling out r236420 and r236458. Modified: trunk/LayoutTests/TestExpectations (236489 => 236490) --- trunk/LayoutTests/TestExpectations 2018-09-26 00:13:59 UTC (rev 236489) +++ trunk/LayoutTests/TestExpectations 2018-09-26 00:24:52 UTC (rev 236490) @@ -965,13 +965,15 @@ webkit.org/b/139640 [ Debug ] webgl/1.0.2/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Slow ] -webkit.org/b/189641 webgl/2.0.0/conformance/buffers/buffer-uninitialized.html [ Failure ] -webkit.org/b/189641 webgl/2.0.0/conformance/extensions/webgl-draw-buffers.html [ Failure Slow ] -webkit.org/b/189641 webgl/2.0.0/conformance/renderbuffers/feedback-loop.html [ Failure ] -webkit.org/b/189641 webgl/2.0.0/conformance/rendering/clipping-wide-points.html [ Failure ] -webkit.org/b/189641 webgl/2.0.0/conformance/textures/misc/copy-tex-image-2d-formats.html [ Failure ] -webkit.org/b/189641 webgl/2.0.0/conformance2/state/gl-object-get-calls.html [ Failure Slow ] -webkit.org/b/189641 webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit.html [ Failure ] +# These tests are generating inconsistent results between my machine (AMD) and test bots (INTEL) +webkit.org/b/189641 webgl/2.0.0/conformance/buffers/buffer-uninitialized.html [ Skip ] +webkit.org/b/189641 webgl/2.0.0/conformance/extensions/webgl-draw-buffers.html [ Skip ] +webkit.org/b/189641 webgl/2.0.0/conformance/renderbuffers/feedback-loop.html [ Skip ] +webkit.org/b/189641 webgl/2.0.0/conformance/rendering/clipping-wide-points.html [ Skip ] +webkit.org/b/189641 webgl/2.0.0/conformance/textures/misc/copy-tex-image-2d-formats.html [ Skip ] +webkit.org/b/189641 webgl/2.0.0/conformance2/state/gl-object-get-calls.html [ Skip ] +webkit.org/b/189641 webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit.html [ Skip ] + webkit.org/b/189641 webgl/2.0.0/conformance2/rendering/blitframebuffer-filter-outofbounds.html [ Slow ] [ Debug ] fast/workers/worker-cloneport.html [ Slow ] Added: trunk/LayoutTests/webgl/webgl2-primitive-restart-expected.html (0 => 236490) ---
[webkit-changes] [236489] branches/safari-606-branch/Source
Title: [236489] branches/safari-606-branch/Source Revision 236489 Author kocsen_ch...@apple.com Date 2018-09-25 17:13:59 -0700 (Tue, 25 Sep 2018) Log Message Versioning. Modified Paths branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig (236488 => 236489) --- branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-09-25 23:33:08 UTC (rev 236488) +++ branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-09-26 00:13:59 UTC (rev 236489) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; -TINY_VERSION = 102; +TINY_VERSION = 103; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (236488 => 236489) --- branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-09-25 23:33:08 UTC (rev 236488) +++ branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-09-26 00:13:59 UTC (rev 236489) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; -TINY_VERSION = 102; +TINY_VERSION = 103; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig (236488 => 236489) --- branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig 2018-09-25 23:33:08 UTC (rev 236488) +++ branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig 2018-09-26 00:13:59 UTC (rev 236489) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; -TINY_VERSION = 102; +TINY_VERSION = 103; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (236488 => 236489) --- branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-09-25 23:33:08 UTC (rev 236488) +++ branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-09-26 00:13:59 UTC (rev 236489) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; -TINY_VERSION = 102; +TINY_VERSION = 103; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (236488 => 236489) --- branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-09-25 23:33:08 UTC (rev 236488) +++ branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-09-26 00:13:59 UTC (rev 236489) @@ -1,6 +1,6 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; -TINY_VERSION = 102; +TINY_VERSION = 103; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig (236488 => 236489) --- branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig 2018-09-25 23:33:08 UTC (rev 236488) +++ branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig 2018-09-26 00:13:59 UTC (rev 236489) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; -TINY_VERSION = 102; +TINY_VERSION = 103; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (236488 => 236489) --- branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-09-25 23:33:08 UTC (rev 236488) +++ branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-09-26 00:13:59 UTC (rev 236489) @@ -23,7 +23,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; -TINY_VERSION = 102; +TINY_VERSION = 103; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236488] trunk/Source/ThirdParty/libwebrtc
Title: [236488] trunk/Source/ThirdParty/libwebrtc Revision 236488 Author you...@apple.com Date 2018-09-25 16:33:08 -0700 (Tue, 25 Sep 2018) Log Message Unreviewed, internal build fix after r236479. * Source/third_party/libvpx/source/libvpx/_iosbuild: Removed. Folder is unneeded. Modified Paths trunk/Source/ThirdParty/libwebrtc/ChangeLog Removed Paths trunk/Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/_iosbuild/ Diff Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (236487 => 236488) --- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-09-25 23:29:34 UTC (rev 236487) +++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-09-25 23:33:08 UTC (rev 236488) @@ -3,6 +3,16 @@ Import libvpx source code https://bugs.webkit.org/show_bug.cgi?id=189954 +Unreviewed, internal build fix. + +* Source/third_party/libvpx/source/libvpx/_iosbuild: Removed. +Folder is unneeded. + +2018-09-25 Youenn Fablet + +Import libvpx source code +https://bugs.webkit.org/show_bug.cgi?id=189954 + Reviewed by Eric Carlson. * Source/third_party/libvpx: Added. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236487] trunk
Title: [236487] trunk
Revision 236487
Author cdu...@apple.com
Date 2018-09-25 16:29:34 -0700 (Tue, 25 Sep 2018)
Log Message
Unreviewed, rolling out r236420 and r236458.
This change is not fully correct
Reverted changesets:
"Do not do early processing of incoming sync IPC unless we're
waiting for a sync IPC reply"
https://bugs.webkit.org/show_bug.cgi?id=186941
https://trac.webkit.org/changeset/236420
"Unreviewed, update bug number of http/tests/misc/blob-
size.html crash on Windows"
https://trac.webkit.org/changeset/236458
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Connection.cpp
Removed Paths
trunk/LayoutTests/http/tests/misc/blob-size-expected.txt
trunk/LayoutTests/http/tests/misc/blob-size.html
Diff
Modified: trunk/LayoutTests/ChangeLog (236486 => 236487)
--- trunk/LayoutTests/ChangeLog 2018-09-25 23:21:25 UTC (rev 236486)
+++ trunk/LayoutTests/ChangeLog 2018-09-25 23:29:34 UTC (rev 236487)
@@ -1,3 +1,20 @@
+2018-09-25 Chris Dumez
+
+Unreviewed, rolling out r236420 and r236458.
+
+This change is not fully correct
+
+Reverted changesets:
+
+"Do not do early processing of incoming sync IPC unless we're
+waiting for a sync IPC reply"
+https://bugs.webkit.org/show_bug.cgi?id=186941
+https://trac.webkit.org/changeset/236420
+
+"Unreviewed, update bug number of http/tests/misc/blob-
+size.html crash on Windows"
+https://trac.webkit.org/changeset/236458
+
2018-09-25 Justin Fan
WebGL 2 conformance: expected test results for the deqp suite (mac-mojave-wk2)
Deleted: trunk/LayoutTests/http/tests/misc/blob-size-expected.txt (236486 => 236487)
--- trunk/LayoutTests/http/tests/misc/blob-size-expected.txt 2018-09-25 23:21:25 UTC (rev 236486)
+++ trunk/LayoutTests/http/tests/misc/blob-size-expected.txt 2018-09-25 23:29:34 UTC (rev 236487)
@@ -1,10 +0,0 @@
-Tests that constructing a Blob and querying its size right away is not flaky
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Getting the Blob size is not flaky
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/http/tests/misc/blob-size.html (236486 => 236487)
--- trunk/LayoutTests/http/tests/misc/blob-size.html 2018-09-25 23:21:25 UTC (rev 236486)
+++ trunk/LayoutTests/http/tests/misc/blob-size.html 2018-09-25 23:29:34 UTC (rev 236487)
@@ -1,26 +0,0 @@
-
-
-
-
-description("Tests that constructing a Blob and querying its size right away is not flaky");
-
-function runTest() {
-for (let i = 0; i < 50; i++) {
-for (let j = 0; j < 200; j++) {
-fetch('/resources/square100.png', { cache: 'no-store' }).then(function(res) { });
-}
-for (let k = 0; k < 5; k++) {
-if ((new Blob([""])).size != 4) {
-testFailed("Getting the Blob size is flaky");
-return;
-}
-}
-}
-testPassed("Getting the Blob size is not flaky");
-}
-
-runTest();
-
-
-
Modified: trunk/LayoutTests/platform/win/TestExpectations (236486 => 236487)
--- trunk/LayoutTests/platform/win/TestExpectations 2018-09-25 23:21:25 UTC (rev 236486)
+++ trunk/LayoutTests/platform/win/TestExpectations 2018-09-25 23:29:34 UTC (rev 236487)
@@ -4173,8 +4173,6 @@
webkit.org/b/188948 fast/events/dblclick-event-getModifierState.html [ Failure ]
-webkit.org/b/189948 http/tests/misc/blob-size.html [ Crash ]
-
# Tests failing on EWS after updating to iTunes 12.8
webkit.org/b/189194 http/tests/IndexedDB/collect-IDB-objects.https.html [ Failure ]
webkit.org/b/189194 http/tests/referrer-policy/origin-when-cross-origin/cross-origin-http.https.html [ Failure ]
Modified: trunk/Source/WebKit/ChangeLog (236486 => 236487)
--- trunk/Source/WebKit/ChangeLog 2018-09-25 23:21:25 UTC (rev 236486)
+++ trunk/Source/WebKit/ChangeLog 2018-09-25 23:29:34 UTC (rev 236487)
@@ -1,3 +1,20 @@
+2018-09-25 Chris Dumez
+
+Unreviewed, rolling out r236420 and r236458.
+
+This change is not fully correct
+
+Reverted changesets:
+
+"Do not do early processing of incoming sync IPC unless we're
+waiting for a sync IPC reply"
+https://bugs.webkit.org/show_bug.cgi?id=186941
+https://trac.webkit.org/changeset/236420
+
+"Unreviewed, update bug number of http/tests/misc/blob-
+size.html crash on Windows"
+https://trac.webkit.org/changeset/236458
+
2018-09-25 Jiewen Tan
Unreviewed, a quick fix after r236481.
Modified: trunk/Source/WebKit/Platform/IPC/Connection.cpp (236486 => 236487)
--- trunk/Source/WebKit/Platform/IPC/Connection.cpp 2018-09-25 23:21:25 UTC (rev 236486)
+++ trunk/Source/WebKit/Platform/IPC/Connection.cpp 2018-09-25 23:29:34 UTC (rev 236487)
@@ -719,13 +719,8 @@
// Check if this is a sync message or if it's a message that should be
[webkit-changes] [236486] trunk/Source/WebKit
Title: [236486] trunk/Source/WebKit
Revision 236486
Author jiewen_...@apple.com
Date 2018-09-25 16:21:25 -0700 (Tue, 25 Sep 2018)
Log Message
Unreviewed, a quick fix after r236481.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setMockWebAuthenticationConfiguration):
Add an early return, so we don't end up with setting MockWebAuthenticationConfiguration twice.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (236485 => 236486)
--- trunk/Source/WebKit/ChangeLog 2018-09-25 22:49:47 UTC (rev 236485)
+++ trunk/Source/WebKit/ChangeLog 2018-09-25 23:21:25 UTC (rev 236486)
@@ -1,3 +1,11 @@
+2018-09-25 Jiewen Tan
+
+Unreviewed, a quick fix after r236481.
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::setMockWebAuthenticationConfiguration):
+Add an early return, so we don't end up with setting MockWebAuthenticationConfiguration twice.
+
2018-09-25 John Wilander
Change from HAVE(CFNETWORK_STORAGE_PARTITIONING) to ENABLE(RESOURCE_LOAD_STATISTICS)
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (236485 => 236486)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2018-09-25 22:49:47 UTC (rev 236485)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2018-09-25 23:21:25 UTC (rev 236486)
@@ -1662,8 +1662,10 @@
#if ENABLE(WEB_AUTHN)
void WebsiteDataStore::setMockWebAuthenticationConfiguration(MockWebAuthenticationConfiguration&& configuration)
{
-if (!m_authenticatorManager->isMock())
+if (!m_authenticatorManager->isMock()) {
m_authenticatorManager = makeUniqueRef(WTFMove(configuration));
+return;
+}
static_cast(_authenticatorManager)->setTestConfiguration(WTFMove(configuration));
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236485] trunk/Source
Title: [236485] trunk/Source Revision 236485 Author wilan...@apple.com Date 2018-09-25 15:49:47 -0700 (Tue, 25 Sep 2018) Log Message Change from HAVE(CFNETWORK_STORAGE_PARTITIONING) to ENABLE(RESOURCE_LOAD_STATISTICS) https://bugs.webkit.org/show_bug.cgi?id=189959 Reviewed by Chris Dumez. Source/WebCore: No new tests because of no code change. We no longer make use of CFNetwork's cookie partitioning so we should change the compile-time flag to something that makes sense. This should also make it easier/cleaner for other ports. * dom/Document.cpp: (WebCore::Document::hasStorageAccess): (WebCore::Document::requestStorageAccess): (WebCore::Document::setHasRequestedPageSpecificStorageAccessWithUserInteraction): * dom/Document.h: * loader/EmptyFrameLoaderClient.h: * loader/FrameLoaderClient.h: * loader/ResourceLoadObserver.cpp: (WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution): (WebCore::ResourceLoadObserver::logWindowCreation): * loader/ResourceLoadObserver.h: * page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): * platform/network/NetworkStorageSession.h: * platform/network/cf/NetworkStorageSessionCFNet.cpp: * platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::cookiesForURL): (WebCore::NetworkStorageSession::setCookiesFromDOM const): Source/WebKit: We no longer make use of CFNetwork's cookie partitioning so we should change the compile-time flag to something that makes sense. This should also make it easier/cleaner for other ports. * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::cookiesForDOM): (WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM): (WebKit::NetworkConnectionToWebProcess::removeStorageAccessForFrame): (WebKit::NetworkConnectionToWebProcess::removeStorageAccessForAllFramesOnPage): * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeNetworkProcess): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * NetworkProcess/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode const): (WebKit::NetworkProcessCreationParameters::decode): * NetworkProcess/NetworkProcessCreationParameters.h: * NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didFinishLoading): (WebKit::NetworkResourceLoader::sendResultForCacheEntry): * NetworkProcess/NetworkResourceLoader.h: * NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::Cache::retrieve): * NetworkProcess/cocoa/NetworkDataTaskCocoa.h: * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::applyCookieBlockingPolicy): (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): (WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection): * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): (WebKit::WebProcessPool::platformInitializeNetworkProcess): * UIProcess/Network/NetworkProcessProxy.cpp: * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/WebPageProxy.cpp: * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler): (WebKit::WebResourceLoadStatisticsStore::callGrantStorageAccessHandler): (WebKit::WebResourceLoadStatisticsStore::removeAllStorageAccess): (WebKit::WebResourceLoadStatisticsStore::setCacheMaxAgeCap): (WebKit::WebResourceLoadStatisticsStore::callUpdatePrevalentDomainsToBlockCookiesForHandler): (WebKit::WebResourceLoadStatisticsStore::callRemoveDomainsHandler): * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::setCacheMaxAgeCapForPrevalentResources): (WebKit::WebsiteDataStore::resetCacheMaxAgeCapForPrevalentResources): (WebKit::WebsiteDataStore::networkProcessDidCrash): * UIProcess/WebsiteData/WebsiteDataStore.h: * WebProcess/WebCoreSupport/WebChromeClient.cpp: * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::detachedFromParent2): (WebKit::WebFrameLoaderClient::dispatchWillChangeDocument): * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * WebProcess/WebPage/WebPage.cpp: * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Source/WTF: * wtf/Platform.h: Enables RESOURCE_LOAD_STATISTICS for Cocoa platforms. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/loader/EmptyFrameLoaderClient.h trunk/Source/WebCore/loader/FrameLoaderClient.h
[webkit-changes] [236483] releases/WebKitGTK/webkit-2.22/Source/WebKit
Title: [236483] releases/WebKitGTK/webkit-2.22/Source/WebKit
Revision 236483
Author ape...@igalia.com
Date 2018-09-25 15:39:59 -0700 (Tue, 25 Sep 2018)
Log Message
Merge r236482 - [WPE] Export jsc_ symbols
https://bugs.webkit.org/show_bug.cgi?id=189964
Patch by Philippe Normand on 2018-09-25
Reviewed by Michael Catanzaro.
* webkitglib-symbols.map: Keep jsc_* symbols as visible so they
can be used by applications depending on WPE.
Modified Paths
releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/webkitglib-symbols.map
Diff
Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog (236482 => 236483)
--- releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog 2018-09-25 22:28:40 UTC (rev 236482)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog 2018-09-25 22:39:59 UTC (rev 236483)
@@ -1,3 +1,13 @@
+2018-09-25 Philippe Normand
+
+[WPE] Export jsc_ symbols
+https://bugs.webkit.org/show_bug.cgi?id=189964
+
+Reviewed by Michael Catanzaro.
+
+* webkitglib-symbols.map: Keep jsc_* symbols as visible so they
+can be used by applications depending on WPE.
+
2018-09-21 Adrian Perez de Castro
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.1 release.
Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/webkitglib-symbols.map (236482 => 236483)
--- releases/WebKitGTK/webkit-2.22/Source/WebKit/webkitglib-symbols.map 2018-09-25 22:28:40 UTC (rev 236482)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/webkitglib-symbols.map 2018-09-25 22:39:59 UTC (rev 236483)
@@ -1,5 +1,6 @@
{
global:
+ jsc_*;
webkit_*;
WebProcessMainUnix;
NetworkProcessMainUnix;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236482] trunk/Source/WebKit
Title: [236482] trunk/Source/WebKit
Revision 236482
Author commit-qu...@webkit.org
Date 2018-09-25 15:28:40 -0700 (Tue, 25 Sep 2018)
Log Message
[WPE] Export jsc_ symbols
https://bugs.webkit.org/show_bug.cgi?id=189964
Patch by Philippe Normand on 2018-09-25
Reviewed by Michael Catanzaro.
* webkitglib-symbols.map: Keep jsc_* symbols as visible so they
can be used by applications depending on WPE.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/webkitglib-symbols.map
Diff
Modified: trunk/Source/WebKit/ChangeLog (236481 => 236482)
--- trunk/Source/WebKit/ChangeLog 2018-09-25 22:22:36 UTC (rev 236481)
+++ trunk/Source/WebKit/ChangeLog 2018-09-25 22:28:40 UTC (rev 236482)
@@ -1,3 +1,13 @@
+2018-09-25 Philippe Normand
+
+[WPE] Export jsc_ symbols
+https://bugs.webkit.org/show_bug.cgi?id=189964
+
+Reviewed by Michael Catanzaro.
+
+* webkitglib-symbols.map: Keep jsc_* symbols as visible so they
+can be used by applications depending on WPE.
+
2018-09-25 Jiewen Tan
[WebAuthN] Make AuthenticatorManager
Modified: trunk/Source/WebKit/webkitglib-symbols.map (236481 => 236482)
--- trunk/Source/WebKit/webkitglib-symbols.map 2018-09-25 22:22:36 UTC (rev 236481)
+++ trunk/Source/WebKit/webkitglib-symbols.map 2018-09-25 22:28:40 UTC (rev 236482)
@@ -1,5 +1,6 @@
{
global:
+ jsc_*;
webkit_*;
WebProcessMainUnix;
NetworkProcessMainUnix;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236480] trunk/Source/WebKit
Title: [236480] trunk/Source/WebKit
Revision 236480
Author cdu...@apple.com
Date 2018-09-25 15:17:51 -0700 (Tue, 25 Sep 2018)
Log Message
Revert some of the changes in r236471
https://bugs.webkit.org/show_bug.cgi?id=189973
Reviewed by Alex Christensen.
Revert some of the changes in r236471 as they should not be needed. In particular,
it should not be possible for the DecidePolicyForNavigationActionSync IPC to get
processed *before* the DidCreateMainFrame / DidCreateSubframe ones because those
use IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply. They are thus
processed early when necessary, the same way as synchronous IPC messages.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateMainFrame):
(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebFrame.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (236479 => 236480)
--- trunk/Source/WebKit/ChangeLog 2018-09-25 22:09:45 UTC (rev 236479)
+++ trunk/Source/WebKit/ChangeLog 2018-09-25 22:17:51 UTC (rev 236480)
@@ -1,3 +1,30 @@
+2018-09-25 Chris Dumez
+
+Revert some of the changes in r236471
+https://bugs.webkit.org/show_bug.cgi?id=189973
+
+Reviewed by Alex Christensen.
+
+Revert some of the changes in r236471 as they should not be needed. In particular,
+it should not be possible for the DecidePolicyForNavigationActionSync IPC to get
+processed *before* the DidCreateMainFrame / DidCreateSubframe ones because those
+use IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply. They are thus
+processed early when necessary, the same way as synchronous IPC messages.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didCreateMainFrame):
+(WebKit::WebPageProxy::didCreateSubframe):
+(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
+(WebKit::WebPageProxy::decidePolicyForNavigationAction):
+(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::createWithCoreMainFrame):
+(WebKit::WebFrame::createSubframe):
+
2018-09-25 Sihui Liu
Move Service Worker Management from Storage Process to Network Process
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (236479 => 236480)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-09-25 22:09:45 UTC (rev 236479)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-09-25 22:17:51 UTC (rev 236480)
@@ -3357,9 +3357,6 @@
void WebPageProxy::didCreateMainFrame(uint64_t frameID)
{
-if (m_mainFrame && m_mainFrame->frameID() == frameID)
-return;
-
PageClientProtector protector(pageClient());
MESSAGE_CHECK(!m_mainFrame);
@@ -3382,10 +3379,6 @@
PageClientProtector protector(pageClient());
MESSAGE_CHECK(m_mainFrame);
-
-if (m_process->webFrame(frameID))
-return;
-
MESSAGE_CHECK(m_process->canCreateFrame(frameID));
RefPtr subFrame = WebFrameProxy::create(this, frameID);
@@ -4003,15 +3996,12 @@
void WebPageProxy::decidePolicyForNavigationActionAsync(uint64_t frameID, const WebCore::SecurityOriginData& frameSecurityOrigin, uint64_t navigationID, NavigationActionData&& navigationActionData, const FrameInfoData& frameInfoData, uint64_t originatingPageID, const WebCore::ResourceRequest& originalRequest, WebCore::ResourceRequest&& request, WebCore::ResourceResponse&& redirectResponse, const UserData& userData, WebCore::ShouldSkipSafeBrowsingCheck shouldSkipSafeBrowsingCheck, uint64_t listenerID)
{
-auto* frame = m_process->webFrame(frameID);
-MESSAGE_CHECK(frame);
-
-decidePolicyForNavigationAction(*frame, frameSecurityOrigin, navigationID, WTFMove(navigationActionData), frameInfoData, originatingPageID, originalRequest, WTFMove(request), WTFMove(redirectResponse), userData, shouldSkipSafeBrowsingCheck, PolicyDecisionSender::create([this, protectedThis = makeRef(*this), frameID,
[webkit-changes] [236478] trunk
Title: [236478] trunk Revision 236478 Author commit-qu...@webkit.org Date 2018-09-25 14:59:35 -0700 (Tue, 25 Sep 2018) Log Message Implement MediaStreamTrack Content Hints https://bugs.webkit.org/show_bug.cgi?id=189262 Patch by YUHAN WU on 2018-09-25 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: * web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint-expected.txt: Source/WebCore: contentHint is a new attribute which is stored in MediaStreamTrackPrivate. https://w3c.github.io/mst-content-hint/ Covered by tests: LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window.html * Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::contentHint const): (WebCore::MediaStreamTrack::setContentHint): * Modules/mediastream/MediaStreamTrack.h: * Modules/mediastream/MediaStreamTrack.idl: * platform/mediastream/MediaStreamTrackPrivate.cpp: (WebCore::MediaStreamTrackPrivate::setContentHint): (WebCore::MediaStreamTrackPrivate::clone): * platform/mediastream/MediaStreamTrackPrivate.h: (WebCore::MediaStreamTrackPrivate::contentHint): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236477 => 236478) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-25 21:57:42 UTC (rev 236477) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-25 21:59:35 UTC (rev 236478) @@ -1,5 +1,15 @@ 2018-09-25 YUHAN WU +Implement MediaStreamTrack Content Hints +https://bugs.webkit.org/show_bug.cgi?id=189262 + + +Reviewed by Youenn Fablet. + +* web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint-expected.txt: + +2018-09-25 YUHAN WU + Import WPT content hint tests https://bugs.webkit.org/show_bug.cgi?id=189854 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint-expected.txt (236477 => 236478) --- trunk/LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint-expected.txt 2018-09-25 21:57:42 UTC (rev 236477) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint-expected.txt 2018-09-25 21:59:35 UTC (rev 236478) @@ -1,9 +1,9 @@ -FAIL Tracks have empty default content hint assert_equals: expected (undefined) undefined but got (string) "" +PASS Tracks have empty default content hint PASS Accepts valid audio contentHints -FAIL Audio tracks ignore invalid/video contentHints assert_equals: Audio tracks should ignore video-only contentHints. expected "speech" but got "motion" +PASS Audio tracks ignore invalid/video contentHints PASS Accepts valid video contentHints -FAIL Video tracks ignore invalid/audio contentHints assert_equals: Video tracks should ignore audio-only contentHints. expected "motion" but got "speech" -FAIL Cloned video tracks have separate contentHints assert_equals: expected (string) "motion" but got (undefined) undefined -FAIL Cloned audio tracks have separate contentHints assert_equals: expected (string) "speech" but got (undefined) undefined +PASS Video tracks ignore invalid/audio contentHints +FAIL Cloned video tracks have separate contentHints assert_equals: expected "motion" but got "" +PASS Cloned audio tracks have separate contentHints Modified: trunk/Source/WebCore/ChangeLog (236477 => 236478) --- trunk/Source/WebCore/ChangeLog 2018-09-25 21:57:42 UTC (rev 236477) +++ trunk/Source/WebCore/ChangeLog 2018-09-25 21:59:35 UTC (rev 236478) @@ -1,3 +1,29 @@ +2018-09-25 YUHAN WU + +Implement MediaStreamTrack Content Hints +https://bugs.webkit.org/show_bug.cgi?id=189262 + + +Reviewed by Youenn Fablet. + +contentHint is a new attribute which is stored in MediaStreamTrackPrivate. +https://w3c.github.io/mst-content-hint/ + +Covered by tests: +LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html +LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window.html + +* Modules/mediastream/MediaStreamTrack.cpp: +(WebCore::MediaStreamTrack::contentHint const): +(WebCore::MediaStreamTrack::setContentHint): +* Modules/mediastream/MediaStreamTrack.h: +* Modules/mediastream/MediaStreamTrack.idl: +* platform/mediastream/MediaStreamTrackPrivate.cpp: +
[webkit-changes] [236476] trunk/Tools
Title: [236476] trunk/Tools
Revision 236476
Author eric.carl...@apple.com
Date 2018-09-25 14:31:29 -0700 (Tue, 25 Sep 2018)
Log Message
[MediaStream] Update constraints supported by getDisplayMedia
https://bugs.webkit.org/show_bug.cgi?id=189930
Unreviewed, fix test broken by r236465.
* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(TestWebKitAPI::TEST_F):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm
Diff
Modified: trunk/Tools/ChangeLog (236475 => 236476)
--- trunk/Tools/ChangeLog 2018-09-25 21:21:10 UTC (rev 236475)
+++ trunk/Tools/ChangeLog 2018-09-25 21:31:29 UTC (rev 236476)
@@ -1,3 +1,14 @@
+2018-09-25 Eric Carlson
+
+[MediaStream] Update constraints supported by getDisplayMedia
+https://bugs.webkit.org/show_bug.cgi?id=189930
+
+
+Unreviewed, fix test broken by r236465.
+
+* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
+(TestWebKitAPI::TEST_F):
+
2018-09-25 Myles C. Maxfield
[WHSL] Implement semantics
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm (236475 => 236476)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm 2018-09-25 21:21:10 UTC (rev 236475)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm 2018-09-25 21:31:29 UTC (rev 236476)
@@ -152,7 +152,7 @@
TEST_F(GetDisplayMediaTest, BasicPrompt)
{
promptForCapture(@"{ audio: true, video: true }", true);
-promptForCapture(@"{ audio: true, video: false }", true);
+promptForCapture(@"{ audio: true, video: false }", false);
promptForCapture(@"{ audio: false, video: true }", true);
promptForCapture(@"{ audio: false, video: false }", false);
}
@@ -159,9 +159,10 @@
TEST_F(GetDisplayMediaTest, Constraints)
{
-promptForCapture(@"{ video: {width: 640} }", false);
-promptForCapture(@"{ video: true, audio: { volume: 0.5 } }", false);
-promptForCapture(@"{ video: {height: 480}, audio: true }", false);
+promptForCapture(@"{ video: {width: 640} }", true);
+promptForCapture(@"{ video: true, audio: { volume: 0.5 } }", true);
+promptForCapture(@"{ video: {height: 480}, audio: true }", true);
+promptForCapture(@"{ video: {width: { exact: 640} } }", false);
}
} // namespace TestWebKitAPI
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236474] trunk/Source
Title: [236474] trunk/Source
Revision 236474
Author achristen...@apple.com
Date 2018-09-25 14:06:31 -0700 (Tue, 25 Sep 2018)
Log Message
Allow for suffixes to com.apple.WebKit.WebContent
https://bugs.webkit.org/show_bug.cgi?id=189972
Reviewed by Chris Dumez.
Source/bmalloc:
* bmalloc/ProcessCheck.mm:
(bmalloc::gigacageEnabledForProcess):
Source/WebCore:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::isInWebProcess):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/ProcessCheck.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236473 => 236474)
--- trunk/Source/WebCore/ChangeLog 2018-09-25 21:04:03 UTC (rev 236473)
+++ trunk/Source/WebCore/ChangeLog 2018-09-25 21:06:31 UTC (rev 236474)
@@ -1,3 +1,13 @@
+2018-09-25 Alex Christensen
+
+Allow for suffixes to com.apple.WebKit.WebContent
+https://bugs.webkit.org/show_bug.cgi?id=189972
+
+Reviewed by Chris Dumez.
+
+* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+(WebCore::isInWebProcess):
+
2018-09-25 Wenson Hsieh
[iOS] Fix the open source iOS 12 build after r236445
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (236473 => 236474)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2018-09-25 21:04:03 UTC (rev 236473)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2018-09-25 21:06:31 UTC (rev 236474)
@@ -86,9 +86,7 @@
bool isInWebProcess()
{
-static bool mainBundleIsWebProcess = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.WebKit.WebContent.Development"]
-|| [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.WebKit.WebContent"]
-|| [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.WebProcess"];
+static bool mainBundleIsWebProcess = [[[NSBundle mainBundle] bundleIdentifier] hasPrefix:@"com.apple.WebKit.WebContent"];
return mainBundleIsWebProcess;
}
Modified: trunk/Source/bmalloc/ChangeLog (236473 => 236474)
--- trunk/Source/bmalloc/ChangeLog 2018-09-25 21:04:03 UTC (rev 236473)
+++ trunk/Source/bmalloc/ChangeLog 2018-09-25 21:06:31 UTC (rev 236474)
@@ -1,3 +1,13 @@
+2018-09-25 Alex Christensen
+
+Allow for suffixes to com.apple.WebKit.WebContent
+https://bugs.webkit.org/show_bug.cgi?id=189972
+
+Reviewed by Chris Dumez.
+
+* bmalloc/ProcessCheck.mm:
+(bmalloc::gigacageEnabledForProcess):
+
2018-09-24 Fujii Hironori
Rename WTF_COMPILER_GCC_OR_CLANG to WTF_COMPILER_GCC_COMPATIBLE
Modified: trunk/Source/bmalloc/bmalloc/ProcessCheck.mm (236473 => 236474)
--- trunk/Source/bmalloc/bmalloc/ProcessCheck.mm 2018-09-25 21:04:03 UTC (rev 236473)
+++ trunk/Source/bmalloc/bmalloc/ProcessCheck.mm 2018-09-25 21:06:31 UTC (rev 236474)
@@ -38,9 +38,7 @@
NSString *appName = [[NSBundle mainBundle] bundleIdentifier];
if (appName) {
-bool isWebProcess = [appName isEqualToString:@"com.apple.WebKit.WebContent.Development"]
-|| [appName isEqualToString:@"com.apple.WebKit.WebContent"]
-|| [appName isEqualToString:@"com.apple.WebProcess"];
+bool isWebProcess = [appName hasPrefix:@"com.apple.WebKit.WebContent"];
return isWebProcess;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236473] trunk/LayoutTests
Title: [236473] trunk/LayoutTests Revision 236473 Author ryanhad...@apple.com Date 2018-09-25 14:04:03 -0700 (Tue, 25 Sep 2018) Log Message REGRESSION: (r235948) Layout Test compositing/backing/backing-store-attachment-fill-forwards-animation.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=189598#c0 Unreviewed test gardening. * platform/ios/TestExpectations: Mark test as flaky. * platform/mac-wk2/TestExpectations: Ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236472 => 236473) --- trunk/LayoutTests/ChangeLog 2018-09-25 20:50:19 UTC (rev 236472) +++ trunk/LayoutTests/ChangeLog 2018-09-25 21:04:03 UTC (rev 236473) @@ -1,3 +1,13 @@ +2018-09-25 Ryan Haddad + +REGRESSION: (r235948) Layout Test compositing/backing/backing-store-attachment-fill-forwards-animation.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=189598#c0 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: Mark test as flaky. +* platform/mac-wk2/TestExpectations: Ditto. + 2018-09-25 Eric Carlson [MediaStream] Update constraints supported by getDisplayMedia Modified: trunk/LayoutTests/platform/ios/TestExpectations (236472 => 236473) --- trunk/LayoutTests/platform/ios/TestExpectations 2018-09-25 20:50:19 UTC (rev 236472) +++ trunk/LayoutTests/platform/ios/TestExpectations 2018-09-25 21:04:03 UTC (rev 236473) @@ -3165,4 +3165,6 @@ webkit.org/b/187557 media/media-fragments/TC0088.html [ Pass Failure ] webkit.org/b/187557 media/media-fragments/TC0089.html [ Pass Failure ] webkit.org/b/187557 media/media-fragments/TC0090.html [ Pass Failure ] -webkit.org/b/187557 media/media-fragments/TC0091.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/187557 media/media-fragments/TC0091.html [ Pass Failure ] + +webkit.org/b/189598 compositing/backing/backing-store-attachment-fill-forwards-animation.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (236472 => 236473) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-09-25 20:50:19 UTC (rev 236472) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-09-25 21:04:03 UTC (rev 236473) @@ -881,3 +881,4 @@ webkit.org/b/189094 [ HighSierra+ ] accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html [ Skip ] +webkit.org/b/189598 compositing/backing/backing-store-attachment-fill-forwards-animation.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236471] trunk/Source/WebKit
Title: [236471] trunk/Source/WebKit
Revision 236471
Author cdu...@apple.com
Date 2018-09-25 12:41:41 -0700 (Tue, 25 Sep 2018)
Log Message
UIProcess should process incoming sync IPC from WebProcess when waiting for a sync IPC reply from it
https://bugs.webkit.org/show_bug.cgi?id=189927
Reviewed by Alex Christensen.
UIProcess should process incoming sync IPC from WebProcess when waiting for a sync IPC reply from it
in order to avoid deadlocks. This is not an issue currently because the WebProcess does process
incoming sync IPC when waiting for a sync IPC reply. However, we plan to change this in the future
in order to avoid bugs caused by re-entering WebCore at unsafe times.
The reason the UIProcess previously did not do out of order sync IPC process was to avoid processing
a synchronous policy decision IPC for a frameID it did not know about yet, due to the DidCreateMainFrame /
DidCreateSubframe IPC messages being asynchronous. To address this issue, the decidePolicyForNavigationActionSync
IPC handler now calls didCreateMainFrame() / didCreateSubframe() as needed if it does not know about
the frame yet. Note that synchronous policy decisions are rare and are currently only needed by initial
about:blank and fragment navigations.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateMainFrame):
(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (236470 => 236471)
--- trunk/Source/WebKit/ChangeLog 2018-09-25 19:34:17 UTC (rev 236470)
+++ trunk/Source/WebKit/ChangeLog 2018-09-25 19:41:41 UTC (rev 236471)
@@ -1,5 +1,37 @@
2018-09-25 Chris Dumez
+UIProcess should process incoming sync IPC from WebProcess when waiting for a sync IPC reply from it
+https://bugs.webkit.org/show_bug.cgi?id=189927
+
+Reviewed by Alex Christensen.
+
+UIProcess should process incoming sync IPC from WebProcess when waiting for a sync IPC reply from it
+in order to avoid deadlocks. This is not an issue currently because the WebProcess does process
+incoming sync IPC when waiting for a sync IPC reply. However, we plan to change this in the future
+in order to avoid bugs caused by re-entering WebCore at unsafe times.
+
+The reason the UIProcess previously did not do out of order sync IPC process was to avoid processing
+a synchronous policy decision IPC for a frameID it did not know about yet, due to the DidCreateMainFrame /
+DidCreateSubframe IPC messages being asynchronous. To address this issue, the decidePolicyForNavigationActionSync
+IPC handler now calls didCreateMainFrame() / didCreateSubframe() as needed if it does not know about
+the frame yet. Note that synchronous policy decisions are rare and are currently only needed by initial
+about:blank and fragment navigations.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didCreateMainFrame):
+(WebKit::WebPageProxy::didCreateSubframe):
+(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
+(WebKit::WebPageProxy::decidePolicyForNavigationAction):
+(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeConnection):
+
+2018-09-25 Chris Dumez
+
Extending the lifetime of a NetworkProcessProxy / StorageProcessProxy may cause it to have a stale WebProcessPool pointer
https://bugs.webkit.org/show_bug.cgi?id=189851
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (236470 => 236471)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-09-25 19:34:17 UTC (rev 236470)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-09-25 19:41:41 UTC (rev 236471)
@@ -3357,6 +3357,9 @@
void WebPageProxy::didCreateMainFrame(uint64_t frameID)
{
+if (m_mainFrame && m_mainFrame->frameID() == frameID)
+return;
+
PageClientProtector protector(pageClient());
[webkit-changes] [236470] trunk/Tools
Title: [236470] trunk/Tools
Revision 236470
Author mmaxfi...@apple.com
Date 2018-09-25 12:34:17 -0700 (Tue, 25 Sep 2018)
Log Message
Unreviewed build fix after r236455
https://bugs.webkit.org/show_bug.cgi?id=189121
* WebGPUShadingLanguageRI/Test.js:
(tests.shaderStages):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebGPUShadingLanguageRI/Test.js
Diff
Modified: trunk/Tools/ChangeLog (236469 => 236470)
--- trunk/Tools/ChangeLog 2018-09-25 19:32:44 UTC (rev 236469)
+++ trunk/Tools/ChangeLog 2018-09-25 19:34:17 UTC (rev 236470)
@@ -1,3 +1,11 @@
+2018-09-25 Myles C. Maxfield
+
+Unreviewed build fix after r236455
+https://bugs.webkit.org/show_bug.cgi?id=189121
+
+* WebGPUShadingLanguageRI/Test.js:
+(tests.shaderStages):
+
2018-09-24 Myles C. Maxfield
[WHLSL] Not all functions should be able to run in all shader stages
Modified: trunk/Tools/WebGPUShadingLanguageRI/Test.js (236469 => 236470)
--- trunk/Tools/WebGPUShadingLanguageRI/Test.js 2018-09-25 19:32:44 UTC (rev 236469)
+++ trunk/Tools/WebGPUShadingLanguageRI/Test.js 2018-09-25 19:34:17 UTC (rev 236470)
@@ -5770,6 +5770,7 @@
}
`);
doPrep(`
+[numthreads(1, 1, 1)]
compute void foo()
{
AllMemoryBarrierWithGroupSync();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236469] trunk/Source/JavaScriptCore
Title: [236469] trunk/Source/_javascript_Core
Revision 236469
Author commit-qu...@webkit.org
Date 2018-09-25 12:32:44 -0700 (Tue, 25 Sep 2018)
Log Message
Web Inspector: Stricter block syntax in generated ObjC protocol interfaces
https://bugs.webkit.org/show_bug.cgi?id=189962
Patch by Joseph Pecoraro on 2018-09-25
Reviewed by Brian Burg.
* inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator._callback_block_for_command):
If there are no return parameters include "void" in the block signature.
* inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
* inspector/scripts/tests/generic/expected/domain-availability.json-result:
* inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
* inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
* inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
* inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
Rebaseline test results.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_header.py
trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/domain-availability.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/generic/expected/worker-supported-domains.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (236468 => 236469)
--- trunk/Source/_javascript_Core/ChangeLog 2018-09-25 18:59:38 UTC (rev 236468)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-09-25 19:32:44 UTC (rev 236469)
@@ -1,3 +1,23 @@
+2018-09-25 Joseph Pecoraro
+
+Web Inspector: Stricter block syntax in generated ObjC protocol interfaces
+https://bugs.webkit.org/show_bug.cgi?id=189962
+
+
+Reviewed by Brian Burg.
+
+* inspector/scripts/codegen/generate_objc_header.py:
+(ObjCHeaderGenerator._callback_block_for_command):
+If there are no return parameters include "void" in the block signature.
+
+* inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
+* inspector/scripts/tests/generic/expected/domain-availability.json-result:
+* inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
+* inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
+* inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
+* inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
+Rebaseline test results.
+
2018-09-24 Joseph Pecoraro
Remove AUTHORS and THANKS files which are stale
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_header.py (236468 => 236469)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_header.py 2018-09-25 18:59:38 UTC (rev 236468)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_header.py 2018-09-25 19:32:44 UTC (rev 236469)
@@ -226,7 +226,10 @@
pairs = []
for parameter in command.return_parameters:
pairs.append(join_type_and_name(self.objc_type_for_param(domain, command.command_name, parameter), parameter.parameter_name))
-return 'void(^)(%s)' % ', '.join(pairs)
+params = 'void'
+if pairs:
+params = ', '.join(pairs)
+return 'void(^)(%s)' % params
def _generate_event_interfaces(self, domain):
lines = []
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result (236468 => 236469)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result 2018-09-25 18:59:38 UTC (rev 236468)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result 2018-09-25 19:32:44 UTC (rev 236469)
@@ -915,7 +915,7 @@
@protocol TestProtocolNetworkDomainHandler
@required
-- (void)loadResourceWithErrorCallback:(void(^)(NSString *error))errorCallback successCallback:(void(^)())successCallback;
+- (void)loadResourceWithErrorCallback:(void(^)(NSString *error))errorCallback successCallback:(void(^)(void))successCallback;
@end
__attribute__((visibility ("default")))
Modified:
[webkit-changes] [236468] trunk/Source/WebCore
Title: [236468] trunk/Source/WebCore
Revision 236468
Author wenson_hs...@apple.com
Date 2018-09-25 11:59:38 -0700 (Tue, 25 Sep 2018)
Log Message
[iOS] Fix the open source iOS 12 build after r236445
https://bugs.webkit.org/show_bug.cgi?id=189953
Reviewed by Alex Christensen.
Source/WebCore:
Remove soft-linking macros from several sources in WebCore, and instead import UIKitSoftLink from PAL. This
allows different WebCore sources to soft-link UIKit (and its classes and symbols) without reimplementing
WebCore::UIKitLibrary.
* editing/cocoa/FontAttributesCocoa.mm:
* editing/cocoa/FontShadowCocoa.mm:
(WebCore::FontShadow::createShadow const):
* platform/graphics/cocoa/ColorCocoa.mm:
(WebCore::platformColor):
* platform/ios/PlatformScreenIOS.mm:
(WebCore::screenIsMonochrome):
(WebCore::screenHasInvertedColors):
(WebCore::screenSize):
(WebCore::availableScreenSize):
(WebCore::screenScaleFactor):
Source/WebCore/PAL:
Introduce a single UIKit soft-linking header in PAL.
* PAL.xcodeproj/project.pbxproj:
* pal/ios/UIKitSoftLink.h: Copied from Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm.
* pal/ios/UIKitSoftLink.mm: Copied from Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/editing/cocoa/FontAttributesCocoa.mm
trunk/Source/WebCore/editing/cocoa/FontShadowCocoa.mm
trunk/Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm
trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm
Added Paths
trunk/Source/WebCore/PAL/pal/ios/
trunk/Source/WebCore/PAL/pal/ios/UIKitSoftLink.h
trunk/Source/WebCore/PAL/pal/ios/UIKitSoftLink.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236467 => 236468)
--- trunk/Source/WebCore/ChangeLog 2018-09-25 18:55:24 UTC (rev 236467)
+++ trunk/Source/WebCore/ChangeLog 2018-09-25 18:59:38 UTC (rev 236468)
@@ -1,3 +1,26 @@
+2018-09-25 Wenson Hsieh
+
+[iOS] Fix the open source iOS 12 build after r236445
+https://bugs.webkit.org/show_bug.cgi?id=189953
+
+Reviewed by Alex Christensen.
+
+Remove soft-linking macros from several sources in WebCore, and instead import UIKitSoftLink from PAL. This
+allows different WebCore sources to soft-link UIKit (and its classes and symbols) without reimplementing
+WebCore::UIKitLibrary.
+
+* editing/cocoa/FontAttributesCocoa.mm:
+* editing/cocoa/FontShadowCocoa.mm:
+(WebCore::FontShadow::createShadow const):
+* platform/graphics/cocoa/ColorCocoa.mm:
+(WebCore::platformColor):
+* platform/ios/PlatformScreenIOS.mm:
+(WebCore::screenIsMonochrome):
+(WebCore::screenHasInvertedColors):
+(WebCore::screenSize):
+(WebCore::availableScreenSize):
+(WebCore::screenScaleFactor):
+
2018-09-25 Thibault Saunier
[WPE][GTK][WebRTC] Fixup VP8 encoding support
Modified: trunk/Source/WebCore/PAL/ChangeLog (236467 => 236468)
--- trunk/Source/WebCore/PAL/ChangeLog 2018-09-25 18:55:24 UTC (rev 236467)
+++ trunk/Source/WebCore/PAL/ChangeLog 2018-09-25 18:59:38 UTC (rev 236468)
@@ -1,3 +1,16 @@
+2018-09-25 Wenson Hsieh
+
+[iOS] Fix the open source iOS 12 build after r236445
+https://bugs.webkit.org/show_bug.cgi?id=189953
+
+Reviewed by Alex Christensen.
+
+Introduce a single UIKit soft-linking header in PAL.
+
+* PAL.xcodeproj/project.pbxproj:
+* pal/ios/UIKitSoftLink.h: Copied from Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm.
+* pal/ios/UIKitSoftLink.mm: Copied from Source/WebCore/platform/graphics/cocoa/ColorCocoa.mm.
+
2018-09-24 Wenson Hsieh
Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (236467 => 236468)
--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2018-09-25 18:55:24 UTC (rev 236467)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj 2018-09-25 18:59:38 UTC (rev 236468)
@@ -108,6 +108,8 @@
1CCEE4F520D871930047B097 /* CoreUISPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CCEE4F420D871930047B097 /* CoreUISPI.h */; };
1CCEE4F720D8743F0047B097 /* NSAppearanceSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 1CCEE4F620D8743F0047B097 /* NSAppearanceSPI.h */; };
2D02E93C2056FAA700A13797 /* AudioToolboxSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D02E93B2056FAA700A13797 /* AudioToolboxSPI.h */; };
+ 2E1342CC215AA10A007199D2 /* UIKitSoftLink.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E1342CA215AA10A007199D2 /* UIKitSoftLink.h */; };
+ 2E1342CD215AA10A007199D2 /* UIKitSoftLink.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2E1342CB215AA10A007199D2 /* UIKitSoftLink.mm */; };
31308B1420A21705003FB929 /* SystemPreviewSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 31308B1320A21705003FB929 /* SystemPreviewSPI.h
[webkit-changes] [236467] trunk/LayoutTests/imported/w3c
Title: [236467] trunk/LayoutTests/imported/w3c
Revision 236467
Author commit-qu...@webkit.org
Date 2018-09-25 11:55:24 -0700 (Tue, 25 Sep 2018)
Log Message
Import WPT content hint tests
https://bugs.webkit.org/show_bug.cgi?id=189854
Patch by YUHAN WU on 2018-09-25
Reviewed by Youenn Fablet.
* web-platform-tests/mst-content-hint/idlharness.window-expected.txt: Added.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window-expected.txt
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236466 => 236467)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-25 18:41:07 UTC (rev 236466)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-25 18:55:24 UTC (rev 236467)
@@ -1,3 +1,12 @@
+2018-09-25 YUHAN WU
+
+Import WPT content hint tests
+https://bugs.webkit.org/show_bug.cgi?id=189854
+
+Reviewed by Youenn Fablet.
+
+* web-platform-tests/mst-content-hint/idlharness.window-expected.txt: Added.
+
2018-09-24 Simon Fraser
Remove filterRes parameter from SVG filters
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window-expected.txt (0 => 236467)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window-expected.txt 2018-09-25 18:55:24 UTC (rev 236467)
@@ -0,0 +1,30 @@
+
+FAIL idl_test setup promise_test: Unhandled rejection with value: object "Got an error before parsing any named definition: Unrecognised tokens, line 1 (tokens: "{\"error\": {\"message\"")
+[
+{
+"type": "{",
+"value": "{",
+"trivia": ""
+},
+{
+"type": "string",
+"value": "\"error\"",
+"trivia": ""
+},
+{
+"type": ":",
+"value": ":",
+"trivia": ""
+},
+{
+"type": "{",
+"value": "{",
+"trivia": " "
+},
+{
+"type": "string",
+"value": "\"message\"",
+"trivia": ""
+}
+]"
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236466] trunk/Source/WebCore
Title: [236466] trunk/Source/WebCore
Revision 236466
Author commit-qu...@webkit.org
Date 2018-09-25 11:41:07 -0700 (Tue, 25 Sep 2018)
Log Message
[WPE][GTK][WebRTC] Fixup VP8 encoding support
https://bugs.webkit.org/show_bug.cgi?id=189921
Previous leak fixing commit introduced a regression in
the way the encoded buffer were prepared in the default
GStreamerVideoEncoder::Fragmentize implementation (when
encoding with VP8 basically).
+ Fix a build warning in the decoder.
+ Fix some wrong object members namings.
+ Properly move the caps reference when setting restriction caps.
+ Do not raise a GStreamer error when GStreamerVideoEncoder::OnEncodedImage
fails - this might be a network issue and other encoders do not consider that
fatal.
+ Use GstMappedBuffer where appropriate.
Patch by Thibault Saunier on 2018-09-25
Reviewed by Philippe Normand.
* platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::InitEncode):
(WebCore::GStreamerVideoEncoder::newSampleCallback):
(WebCore::GStreamerVideoEncoder::Fragmentize):
(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp
trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236465 => 236466)
--- trunk/Source/WebCore/ChangeLog 2018-09-25 18:37:29 UTC (rev 236465)
+++ trunk/Source/WebCore/ChangeLog 2018-09-25 18:41:07 UTC (rev 236466)
@@ -1,3 +1,30 @@
+2018-09-25 Thibault Saunier
+
+[WPE][GTK][WebRTC] Fixup VP8 encoding support
+https://bugs.webkit.org/show_bug.cgi?id=189921
+
+Previous leak fixing commit introduced a regression in
+the way the encoded buffer were prepared in the default
+GStreamerVideoEncoder::Fragmentize implementation (when
+encoding with VP8 basically).
+
++ Fix a build warning in the decoder.
++ Fix some wrong object members namings.
++ Properly move the caps reference when setting restriction caps.
++ Do not raise a GStreamer error when GStreamerVideoEncoder::OnEncodedImage
+ fails - this might be a network issue and other encoders do not consider that
+ fatal.
++ Use GstMappedBuffer where appropriate.
+
+Reviewed by Philippe Normand.
+
+* platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
+* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
+(WebCore::GStreamerVideoEncoder::InitEncode):
+(WebCore::GStreamerVideoEncoder::newSampleCallback):
+(WebCore::GStreamerVideoEncoder::Fragmentize):
+(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):
+
2018-09-25 Eric Carlson
[MediaStream] Update constraints supported by getDisplayMedia
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp (236465 => 236466)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp 2018-09-25 18:37:29 UTC (rev 236465)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp 2018-09-25 18:41:07 UTC (rev 236466)
@@ -165,7 +165,7 @@
GST_BUFFER_PTS(buffer.get()) = (static_cast(renderTimeMs) * GST_MSECOND) - m_firstBufferPts;
m_dtsPtsMap[GST_BUFFER_PTS(buffer.get())] = inputImage._timeStamp;
-GST_LOG_OBJECT(pipeline(), "%ld Decoding: %" GST_PTR_FORMAT, renderTimeMs, buffer);
+GST_LOG_OBJECT(pipeline(), "%ld Decoding: %" GST_PTR_FORMAT, renderTimeMs, buffer.get());
auto sample = adoptGRef(gst_sample_new(buffer.get(), GetCapsForFrame(inputImage), nullptr, nullptr));
switch (gst_app_src_push_sample(GST_APP_SRC(m_src), sample.get())) {
case GST_FLOW_OK:
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp (236465 => 236466)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp 2018-09-25 18:37:29 UTC (rev 236465)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp 2018-09-25 18:41:07 UTC (rev 236466)
@@ -81,7 +81,7 @@
auto caps = adoptGRef(gst_caps_copy(m_restrictionCaps.get()));
gst_caps_set_simple(caps.get(), "framerate", GST_TYPE_FRACTION, frameRate, 1, nullptr);
-SetRestrictionCaps(caps);
+SetRestrictionCaps(WTFMove(caps));
if (m_bitrateSetter && m_encoder)
m_bitrateSetter(m_encoder, newBitrate);
@@ -109,7 +109,7 @@
m_encodedFrame._size = codecSettings->width * codecSettings->height * 3;
m_encodedFrame._buffer = new uint8_t[m_encodedFrame._size];
-encoded_image_buffer_.reset(m_encodedFrame._buffer);
+m_encodedImageBuffer.reset(m_encodedFrame._buffer);
[webkit-changes] [236465] trunk
Title: [236465] trunk Revision 236465 Author eric.carl...@apple.com Date 2018-09-25 11:37:29 -0700 (Tue, 25 Sep 2018) Log Message [MediaStream] Update constraints supported by getDisplayMedia https://bugs.webkit.org/show_bug.cgi?id=189930 Reviewed by Youenn Fablet. Source/WebCore: No new tests, updated http/tests/media/media-stream/get-display-media-prompt.html. * Modules/mediastream/MediaDevices.cpp: (WebCore::MediaDevices::getDisplayMedia const): Ignore audio constraints. * Modules/mediastream/UserMediaRequest.cpp: (WebCore::hasInvalidGetDisplayMediaConstraint): Check for invalid constraints. (WebCore::UserMediaRequest::start): Check for invalid constraints. (WebCore::UserMediaRequest::deny): Support new error. * Modules/mediastream/UserMediaRequest.h: * platform/mediastream/RealtimeMediaSourceCenter.cpp: (WebCore::RealtimeMediaSourceCenter::validateRequestConstraints): LayoutTests: * http/tests/media/media-stream/get-display-media-prompt-expected.txt: * http/tests/media/media-stream/get-display-media-prompt.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt-expected.txt trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.h trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h Diff Modified: trunk/LayoutTests/ChangeLog (236464 => 236465) --- trunk/LayoutTests/ChangeLog 2018-09-25 18:31:21 UTC (rev 236464) +++ trunk/LayoutTests/ChangeLog 2018-09-25 18:37:29 UTC (rev 236465) @@ -1,3 +1,13 @@ +2018-09-25 Eric Carlson + +[MediaStream] Update constraints supported by getDisplayMedia +https://bugs.webkit.org/show_bug.cgi?id=189930 + +Reviewed by Youenn Fablet. + +* http/tests/media/media-stream/get-display-media-prompt-expected.txt: +* http/tests/media/media-stream/get-display-media-prompt.html: + 2018-09-25 Ryan Haddad [resource-timing] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html times out on WK1 Modified: trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt-expected.txt (236464 => 236465) --- trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt-expected.txt 2018-09-25 18:31:21 UTC (rev 236464) +++ trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt-expected.txt 2018-09-25 18:37:29 UTC (rev 236465) @@ -5,26 +5,49 @@ PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 0 -** Request an audio-only stream, the user should be prompted ** +** Request an audio-only stream, the user should not be prompted ** +PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 0 +PASS stream is undefined. +PASS err instanceof Error is true +PASS err.name is "TypeError" + +** Request an video-only stream, the user should be prompted ** PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 1 -PASS stream.getAudioTracks().length is 1 -PASS stream.getVideoTracks().length is 0 +PASS stream.getAudioTracks().length is 0 +PASS stream.getVideoTracks().length is 1 -** Request an video-only stream, the user should be prompted ** +** Request a stream with audio and video, the user should be prompted but no audio track should be created ** PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 2 PASS stream.getAudioTracks().length is 0 PASS stream.getVideoTracks().length is 1 -** Request a stream with audio and video, the user should be prompted ** +** Request a stream with 'max' constraints, the user should not be prompted ** +PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 2 +PASS stream is undefined. +PASS err instanceof Error is true +PASS err.name is "TypeError" + +** Request a stream with 'min' constraints, the user should not be prompted ** +PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 2 +PASS stream is undefined. +PASS err instanceof Error is true +PASS err.name is "TypeError" + +** Request a stream with 'advanced' constraints, the user should not be prompted ** +PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 2 +PASS stream is undefined. +PASS err instanceof Error is true +PASS err.name is "TypeError" + +** Request a stream with valid constraints, the user should be prompted ** PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 3 -PASS stream.getAudioTracks().length is 1 +PASS stream.getAudioTracks().length is 0 PASS stream.getVideoTracks().length is 1 -** Request a stream with invalid constraints, the user should not be prompted ** -PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 3 -PASS stream is null -PASS err instanceof Error is true -PASS err.name is "InvalidAccessError" +** Request a stream with an exact
[webkit-changes] [236464] trunk/Source/WebKit
Title: [236464] trunk/Source/WebKit Revision 236464 Author cdu...@apple.com Date 2018-09-25 11:31:21 -0700 (Tue, 25 Sep 2018) Log Message Extending the lifetime of a NetworkProcessProxy / StorageProcessProxy may cause it to have a stale WebProcessPool pointer https://bugs.webkit.org/show_bug.cgi?id=189851 Reviewed by Alex Christensen. Extending the lifetime of a NetworkProcessProxy / StorageProcessProxy may cause it to have a stale WebProcessPool pointer: - NetworkProcessProxy::m_processPool - StorageProcessProxy::m_processPool Those data members are C++ references because it is expected that the WebProcessPool owns the NetworkProcessProxy and StorageProcessProxy. However, since NetworkProcessProxy / StorageProcessProxy are refcounted, it has happened that code extends the lifetime of those past their process pool, leading to stale prrocess pool usage. The fix for these crashes so far as been to ref the WebProcessPool instead of the NetworkProcessProxy / StorageProcessProxy. However, it is very tempting for people to simply ref the NetworkProcessProxy / StorageProcessProxy given that they are refcounted. For this reason, this patch updates NetworkProcessProxy / StorageProcessProxy so that they are no longer RefCounted and so that the WebProcessPool truly owns them via std::unique_ptr<>. * UIProcess/ChildProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::networkProcessCrashed): (WebKit::NetworkProcessProxy::didClose): (WebKit::NetworkProcessProxy::create): Deleted. * UIProcess/Network/NetworkProcessProxy.h: (WebKit::NetworkProcessProxy::throttler): Deleted. (WebKit::NetworkProcessProxy::processPool): Deleted. * UIProcess/Plugins/PluginProcessProxy.h: (WebKit::PluginProcessProxy::pluginProcessAttributes const): Deleted. (WebKit::PluginProcessProxy::pluginProcessToken const): Deleted. (WebKit::PluginProcessProxy::isValid const): Deleted. * UIProcess/Storage/StorageProcessProxy.cpp: (WebKit::StorageProcessProxy::create): Deleted. * UIProcess/Storage/StorageProcessProxy.h: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess): (WebKit::WebProcessPool::ensureStorageProcessAndWebsiteDataStore): (WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess): * UIProcess/WebProcessPool.h: * UIProcess/WebProcessProxy.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ChildProcessProxy.h trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h trunk/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.h trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.h trunk/Source/WebKit/UIProcess/WebProcessProxy.h Diff Modified: trunk/Source/WebKit/ChangeLog (236463 => 236464) --- trunk/Source/WebKit/ChangeLog 2018-09-25 17:36:19 UTC (rev 236463) +++ trunk/Source/WebKit/ChangeLog 2018-09-25 18:31:21 UTC (rev 236464) @@ -1,3 +1,45 @@ +2018-09-25 Chris Dumez + +Extending the lifetime of a NetworkProcessProxy / StorageProcessProxy may cause it to have a stale WebProcessPool pointer +https://bugs.webkit.org/show_bug.cgi?id=189851 + + +Reviewed by Alex Christensen. + +Extending the lifetime of a NetworkProcessProxy / StorageProcessProxy may cause it to have a stale WebProcessPool pointer: +- NetworkProcessProxy::m_processPool +- StorageProcessProxy::m_processPool + +Those data members are C++ references because it is expected that the WebProcessPool owns the NetworkProcessProxy and +StorageProcessProxy. However, since NetworkProcessProxy / StorageProcessProxy are refcounted, it has happened that code +extends the lifetime of those past their process pool, leading to stale prrocess pool usage. The fix for these crashes +so far as been to ref the WebProcessPool instead of the NetworkProcessProxy / StorageProcessProxy. However, it is very +tempting for people to simply ref the NetworkProcessProxy / StorageProcessProxy given that they are refcounted. +For this reason, this patch updates NetworkProcessProxy / StorageProcessProxy so that they are no longer RefCounted +and so that the WebProcessPool truly owns them via std::unique_ptr<>. + +* UIProcess/ChildProcessProxy.h: +* UIProcess/Network/NetworkProcessProxy.cpp: +(WebKit::NetworkProcessProxy::networkProcessCrashed): +(WebKit::NetworkProcessProxy::didClose): +(WebKit::NetworkProcessProxy::create): Deleted. +* UIProcess/Network/NetworkProcessProxy.h: +(WebKit::NetworkProcessProxy::throttler): Deleted. +(WebKit::NetworkProcessProxy::processPool): Deleted. +* UIProcess/Plugins/PluginProcessProxy.h: +
[webkit-changes] [236463] trunk/Source/WebKit
Title: [236463] trunk/Source/WebKit Revision 236463 Author achristen...@apple.com Date 2018-09-25 10:36:19 -0700 (Tue, 25 Sep 2018) Log Message NetworkLoad::didReceiveResponse should pass its completion handler to its client https://bugs.webkit.org/show_bug.cgi?id=188701 Reviewed by Michael Catanzaro. Right now we have a confusing enum ShouldContinueDidReceiveResponse and a complicated flow that involves many objects and implicitly using NetworkLoad's destructor as part of the loading flow. This makes the responsibilities of the objects clear. * NetworkProcess/Downloads/PendingDownload.cpp: (WebKit::PendingDownload::didReceiveResponse): * NetworkProcess/Downloads/PendingDownload.h: * NetworkProcess/NetworkCORSPreflightChecker.cpp: (WebKit::NetworkCORSPreflightChecker::didReceiveResponse): (WebKit::NetworkCORSPreflightChecker::didReceiveResponseNetworkSession): Deleted. * NetworkProcess/NetworkCORSPreflightChecker.h: * NetworkProcess/NetworkDataTask.cpp: (WebKit::NetworkDataTask::didReceiveResponse): * NetworkProcess/NetworkDataTask.h: * NetworkProcess/NetworkLoad.cpp: (WebKit::NetworkLoad::~NetworkLoad): (WebKit::NetworkLoad::convertTaskToDownload): (WebKit::NetworkLoad::didReceiveResponse): (WebKit::NetworkLoad::notifyDidReceiveResponse): (WebKit::NetworkLoad::continueDidReceiveResponse): Deleted. (WebKit::NetworkLoad::didReceiveResponseNetworkSession): Deleted. * NetworkProcess/NetworkLoad.h: * NetworkProcess/NetworkLoadClient.h: * NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::~NetworkResourceLoader): (WebKit::NetworkResourceLoader::didReceiveResponse): (WebKit::NetworkResourceLoader::didFinishWithRedirectResponse): (WebKit::NetworkResourceLoader::continueDidReceiveResponse): * NetworkProcess/NetworkResourceLoader.h: * NetworkProcess/PingLoad.cpp: (WebKit::PingLoad::didReceiveResponse): (WebKit::PingLoad::didReceiveResponseNetworkSession): Deleted. * NetworkProcess/PingLoad.h: * NetworkProcess/PreconnectTask.cpp: (WebKit::PreconnectTask::didReceiveResponse): * NetworkProcess/PreconnectTask.h: * NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp: (WebKit::NetworkCache::SpeculativeLoad::didReceiveResponse): * NetworkProcess/cache/NetworkCacheSpeculativeLoad.h: * NetworkProcess/capture/NetworkDataTaskReplay.cpp: (WebKit::NetworkCapture::NetworkDataTaskReplay::didReceiveResponse): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp trunk/Source/WebKit/NetworkProcess/Downloads/DownloadManager.h trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.h trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp trunk/Source/WebKit/NetworkProcess/NetworkLoad.h trunk/Source/WebKit/NetworkProcess/NetworkLoadClient.h trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h trunk/Source/WebKit/NetworkProcess/PingLoad.cpp trunk/Source/WebKit/NetworkProcess/PingLoad.h trunk/Source/WebKit/NetworkProcess/PreconnectTask.cpp trunk/Source/WebKit/NetworkProcess/PreconnectTask.h trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h trunk/Source/WebKit/NetworkProcess/capture/NetworkDataTaskReplay.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (236462 => 236463) --- trunk/Source/WebKit/ChangeLog 2018-09-25 17:19:36 UTC (rev 236462) +++ trunk/Source/WebKit/ChangeLog 2018-09-25 17:36:19 UTC (rev 236463) @@ -1,3 +1,52 @@ +2018-09-25 Alex Christensen + +NetworkLoad::didReceiveResponse should pass its completion handler to its client +https://bugs.webkit.org/show_bug.cgi?id=188701 + +Reviewed by Michael Catanzaro. + +Right now we have a confusing enum ShouldContinueDidReceiveResponse and a complicated flow +that involves many objects and implicitly using NetworkLoad's destructor as part of the +loading flow. This makes the responsibilities of the objects clear. + +* NetworkProcess/Downloads/PendingDownload.cpp: +(WebKit::PendingDownload::didReceiveResponse): +* NetworkProcess/Downloads/PendingDownload.h: +* NetworkProcess/NetworkCORSPreflightChecker.cpp: +(WebKit::NetworkCORSPreflightChecker::didReceiveResponse): +(WebKit::NetworkCORSPreflightChecker::didReceiveResponseNetworkSession): Deleted. +* NetworkProcess/NetworkCORSPreflightChecker.h: +* NetworkProcess/NetworkDataTask.cpp: +(WebKit::NetworkDataTask::didReceiveResponse): +* NetworkProcess/NetworkDataTask.h: +* NetworkProcess/NetworkLoad.cpp: +
[webkit-changes] [236462] trunk/Source/WebCore
Title: [236462] trunk/Source/WebCore
Revision 236462
Author calva...@igalia.com
Date 2018-09-25 10:19:36 -0700 (Tue, 25 Sep 2018)
Log Message
[EME] Fix variable name that should have gone in r236317
https://bugs.webkit.org/show_bug.cgi?id=189944
Reviewed by Jer Noble.
m_cdmInstanceClientWeakPtrFactory becomes
m_cdmInstanceSessionClientWeakPtrFactory as its type changes to
CDMInstanceSessionClient.
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::MediaKeySession):
* Modules/encryptedmedia/MediaKeySession.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (236461 => 236462)
--- trunk/Source/WebCore/ChangeLog 2018-09-25 16:57:32 UTC (rev 236461)
+++ trunk/Source/WebCore/ChangeLog 2018-09-25 17:19:36 UTC (rev 236462)
@@ -1,3 +1,18 @@
+2018-09-25 Xabier Rodriguez Calvar
+
+[EME] Fix variable name that should have gone in r236317
+https://bugs.webkit.org/show_bug.cgi?id=189944
+
+Reviewed by Jer Noble.
+
+m_cdmInstanceClientWeakPtrFactory becomes
+m_cdmInstanceSessionClientWeakPtrFactory as its type changes to
+CDMInstanceSessionClient.
+
+* Modules/encryptedmedia/MediaKeySession.cpp:
+(WebCore::MediaKeySession::MediaKeySession):
+* Modules/encryptedmedia/MediaKeySession.h:
+
2018-09-25 Simon Fraser
Clean up code around RenderLayer's "has accelerated scrolling" functions
Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp (236461 => 236462)
--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp 2018-09-25 16:57:32 UTC (rev 236461)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp 2018-09-25 17:19:36 UTC (rev 236462)
@@ -88,7 +88,7 @@
UNUSED_PARAM(m_closed);
UNUSED_PARAM(m_uninitialized);
-m_instanceSession->setClient(m_cdmInstanceClientWeakPtrFactory.createWeakPtr(*this));
+m_instanceSession->setClient(m_cdmInstanceSessionClientWeakPtrFactory.createWeakPtr(*this));
}
MediaKeySession::~MediaKeySession()
Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.h (236461 => 236462)
--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.h 2018-09-25 16:57:32 UTC (rev 236461)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.h 2018-09-25 17:19:36 UTC (rev 236462)
@@ -117,7 +117,7 @@
double m_firstDecryptTime { 0 };
double m_latestDecryptTime { 0 };
Vector, MediaKeyStatus>> m_statuses;
-WeakPtrFactory m_cdmInstanceClientWeakPtrFactory;
+WeakPtrFactory m_cdmInstanceSessionClientWeakPtrFactory;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236461] trunk/LayoutTests
Title: [236461] trunk/LayoutTests Revision 236461 Author ryanhad...@apple.com Date 2018-09-25 09:57:32 -0700 (Tue, 25 Sep 2018) Log Message [resource-timing] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html times out on WK1 https://bugs.webkit.org/show_bug.cgi?id=189908 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Mark test as a failure since it is hitting a WPT harness timeout. * platform/mac/TestExpectations: Remove expectation in favor of a mac-wk1 specific one. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236460 => 236461) --- trunk/LayoutTests/ChangeLog 2018-09-25 15:56:16 UTC (rev 236460) +++ trunk/LayoutTests/ChangeLog 2018-09-25 16:57:32 UTC (rev 236461) @@ -1,5 +1,15 @@ 2018-09-25 Ryan Haddad +[resource-timing] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html times out on WK1 +https://bugs.webkit.org/show_bug.cgi?id=189908 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: Mark test as a failure since it is hitting a WPT harness timeout. +* platform/mac/TestExpectations: Remove expectation in favor of a mac-wk1 specific one. + +2018-09-25 Ryan Haddad + Unreviewed, correct a typo in a bug URL. * platform/mac/TestExpectations: Modified: trunk/LayoutTests/platform/mac/TestExpectations (236460 => 236461) --- trunk/LayoutTests/platform/mac/TestExpectations 2018-09-25 15:56:16 UTC (rev 236460) +++ trunk/LayoutTests/platform/mac/TestExpectations 2018-09-25 16:57:32 UTC (rev 236461) @@ -1647,7 +1647,6 @@ [ Sierra ] fast/canvas/webgl/index-validation-with-subsequent-draws.html [ Skip ] webkit.org/b/180260 [ HighSierra ] http/wpt/resource-timing/rt-resources-per-worker.html [ Pass Failure ] -webkit.org/b/189908 imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html [ Pass Timeout ] webkit.org/b/181830 [ Debug ] media/video-main-content-allow-then-deny.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (236460 => 236461) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2018-09-25 15:56:16 UTC (rev 236460) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2018-09-25 16:57:32 UTC (rev 236461) @@ -629,3 +629,5 @@ # Not supported on WK1 imported/w3c/web-platform-tests/css/css-properties-values-api/ [ Skip ] css-custom-properties-api [ Skip ] + +webkit.org/b/189908 imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html [ Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236460] trunk/LayoutTests
Title: [236460] trunk/LayoutTests Revision 236460 Author ryanhad...@apple.com Date 2018-09-25 08:56:16 -0700 (Tue, 25 Sep 2018) Log Message Unreviewed, correct a typo in a bug URL. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236459 => 236460) --- trunk/LayoutTests/ChangeLog 2018-09-25 15:49:20 UTC (rev 236459) +++ trunk/LayoutTests/ChangeLog 2018-09-25 15:56:16 UTC (rev 236460) @@ -1,3 +1,9 @@ +2018-09-25 Ryan Haddad + +Unreviewed, correct a typo in a bug URL. + +* platform/mac/TestExpectations: + 2018-09-25 Chris Dumez Unreviewed, update bug number of http/tests/misc/blob-size.html crash on Windows Modified: trunk/LayoutTests/platform/mac/TestExpectations (236459 => 236460) --- trunk/LayoutTests/platform/mac/TestExpectations 2018-09-25 15:49:20 UTC (rev 236459) +++ trunk/LayoutTests/platform/mac/TestExpectations 2018-09-25 15:56:16 UTC (rev 236460) @@ -1776,4 +1776,4 @@ webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer.html [ Slow ] webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Slow ] -webkit.org/189674 media/media-controls-accessibility.html [ Pass Failure ] +webkit.org/b/189674 media/media-controls-accessibility.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236459] trunk/Source/WebCore
Title: [236459] trunk/Source/WebCore
Revision 236459
Author simon.fra...@apple.com
Date 2018-09-25 08:49:20 -0700 (Tue, 25 Sep 2018)
Log Message
Clean up code around RenderLayer's "has accelerated scrolling" functions
https://bugs.webkit.org/show_bug.cgi?id=189932
Reviewed by Zalan Bujtas.
RenderLayer had:
bool hasAcceleratedTouchScrolling()
bool hasTouchScrollableOverflow()
bool usesAcceleratedScrolling()
bool usesCompositedScrolling()
bool usesAsyncScrolling()
which are hard to keep in your head. Removed usesAcceleratedScrolling() since it just returns hasTouchScrollableOverflow().
Renamed hasAcceleratedTouchScrolling() to canUseAcceleratedTouchScrolling() to indicate that it just looks at style,
not whether layout has given the layer scrollable overflow yet. Tidy up some #ifdefs.
usesCompositedScrolling() and usesAsyncScrolling() are ScrollableArea overrides, and
look at backing layers, so require that compositing has run already. Note this in comments.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::canUseAcceleratedTouchScrolling const):
(WebCore::RenderLayer::hasTouchScrollableOverflow const):
(WebCore::RenderLayer::handleTouchEvent):
(WebCore::RenderLayer::usesAsyncScrolling const):
(WebCore::RenderLayer::showsOverflowControls const):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::RenderLayer::hasAcceleratedTouchScrolling const): Deleted.
(WebCore::RenderLayer::usesAcceleratedScrolling const): Deleted.
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::updateConfiguration):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):
(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236458 => 236459)
--- trunk/Source/WebCore/ChangeLog 2018-09-25 15:45:42 UTC (rev 236458)
+++ trunk/Source/WebCore/ChangeLog 2018-09-25 15:49:20 UTC (rev 236459)
@@ -1,3 +1,42 @@
+2018-09-25 Simon Fraser
+
+Clean up code around RenderLayer's "has accelerated scrolling" functions
+https://bugs.webkit.org/show_bug.cgi?id=189932
+
+Reviewed by Zalan Bujtas.
+
+RenderLayer had:
+
+bool hasAcceleratedTouchScrolling()
+bool hasTouchScrollableOverflow()
+bool usesAcceleratedScrolling()
+bool usesCompositedScrolling()
+bool usesAsyncScrolling()
+
+which are hard to keep in your head. Removed usesAcceleratedScrolling() since it just returns hasTouchScrollableOverflow().
+Renamed hasAcceleratedTouchScrolling() to canUseAcceleratedTouchScrolling() to indicate that it just looks at style,
+not whether layout has given the layer scrollable overflow yet. Tidy up some #ifdefs.
+
+usesCompositedScrolling() and usesAsyncScrolling() are ScrollableArea overrides, and
+look at backing layers, so require that compositing has run already. Note this in comments.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::canUseAcceleratedTouchScrolling const):
+(WebCore::RenderLayer::hasTouchScrollableOverflow const):
+(WebCore::RenderLayer::handleTouchEvent):
+(WebCore::RenderLayer::usesAsyncScrolling const):
+(WebCore::RenderLayer::showsOverflowControls const):
+(WebCore::RenderLayer::calculateClipRects const):
+(WebCore::RenderLayer::hasAcceleratedTouchScrolling const): Deleted.
+(WebCore::RenderLayer::usesAcceleratedScrolling const): Deleted.
+* rendering/RenderLayer.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
+(WebCore::RenderLayerBacking::updateConfiguration):
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer const):
+(WebCore::RenderLayerCompositor::requiresCompositingForOverflowScrolling const):
+
2018-09-24 Fujii Hironori
Rename WTF_COMPILER_GCC_OR_CLANG to WTF_COMPILER_GCC_COMPATIBLE
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (236458 => 236459)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2018-09-25 15:45:42 UTC (rev 236458)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2018-09-25 15:49:20 UTC (rev 236459)
@@ -1948,14 +1948,10 @@
return toLayoutSize(convertToLayerCoords(ancestorLayer, LayoutPoint(), adjustForColumns));
}
-#if PLATFORM(IOS)
-bool RenderLayer::hasAcceleratedTouchScrolling() const
+bool RenderLayer::canUseAcceleratedTouchScrolling() const
{
-#if
[webkit-changes] [236458] trunk/LayoutTests
Title: [236458] trunk/LayoutTests Revision 236458 Author cdu...@apple.com Date 2018-09-25 08:45:42 -0700 (Tue, 25 Sep 2018) Log Message Unreviewed, update bug number of http/tests/misc/blob-size.html crash on Windows * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (236457 => 236458) --- trunk/LayoutTests/ChangeLog 2018-09-25 14:18:28 UTC (rev 236457) +++ trunk/LayoutTests/ChangeLog 2018-09-25 15:45:42 UTC (rev 236458) @@ -1,3 +1,9 @@ +2018-09-25 Chris Dumez + +Unreviewed, update bug number of http/tests/misc/blob-size.html crash on Windows + +* platform/win/TestExpectations: + 2018-09-24 Simon Fraser Mark two tests as flakey. Modified: trunk/LayoutTests/platform/win/TestExpectations (236457 => 236458) --- trunk/LayoutTests/platform/win/TestExpectations 2018-09-25 14:18:28 UTC (rev 236457) +++ trunk/LayoutTests/platform/win/TestExpectations 2018-09-25 15:45:42 UTC (rev 236458) @@ -4173,7 +4173,7 @@ webkit.org/b/188948 fast/events/dblclick-event-getModifierState.html [ Failure ] -webkit.org/b/186941 http/tests/misc/blob-size.html [ Crash ] +webkit.org/b/189948 http/tests/misc/blob-size.html [ Crash ] # Tests failing on EWS after updating to iTunes 12.8 webkit.org/b/189194 http/tests/IndexedDB/collect-IDB-objects.https.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236457] releases/WebKitGTK/webkit-2.22/Source/WebCore
Title: [236457] releases/WebKitGTK/webkit-2.22/Source/WebCore
Revision 236457
Author ape...@igalia.com
Date 2018-09-25 07:18:28 -0700 (Tue, 25 Sep 2018)
Log Message
Merge r235536 - Speculative build fix for WPE after r235531.
* platform/graphics/filters/PointLightSource.cpp:
Add missing include.
Modified Paths
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/filters/PointLightSource.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (236456 => 236457)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-09-25 14:18:19 UTC (rev 236456)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-09-25 14:18:28 UTC (rev 236457)
@@ -1,3 +1,10 @@
+2018-08-30 Ross Kirsling
+
+Speculative build fix for WPE after r235531.
+
+* platform/graphics/filters/PointLightSource.cpp:
+Add missing include.
+
2018-09-22 Adrian Perez de Castro
[ARM] Building FELightingNEON.cpp fails due to missing lightVector member
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/filters/PointLightSource.cpp (236456 => 236457)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/filters/PointLightSource.cpp 2018-09-25 14:18:19 UTC (rev 236456)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/filters/PointLightSource.cpp 2018-09-25 14:18:28 UTC (rev 236457)
@@ -31,6 +31,7 @@
#include "config.h"
#include "PointLightSource.h"
+#include "FilterEffect.h"
#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236456] releases/WebKitGTK/webkit-2.22/Source/WebCore
Title: [236456] releases/WebKitGTK/webkit-2.22/Source/WebCore
Revision 236456
Author ape...@igalia.com
Date 2018-09-25 07:18:19 -0700 (Tue, 25 Sep 2018)
Log Message
Merge r236391 - [ARM] Building FELightingNEON.cpp fails due to missing lightVector member
https://bugs.webkit.org/show_bug.cgi?id=189890
Reviewed by Darin Adler.
No new tests needed.
* platform/graphics/cpu/arm/filters/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon): Adapt to new layout of "struct PaintingData" after r225122.
Modified Paths
releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
Diff
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (236455 => 236456)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-09-25 06:36:04 UTC (rev 236455)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog 2018-09-25 14:18:19 UTC (rev 236456)
@@ -1,3 +1,15 @@
+2018-09-22 Adrian Perez de Castro
+
+[ARM] Building FELightingNEON.cpp fails due to missing lightVector member
+https://bugs.webkit.org/show_bug.cgi?id=189890
+
+Reviewed by Darin Adler.
+
+No new tests needed.
+
+* platform/graphics/cpu/arm/filters/FELightingNEON.h:
+(WebCore::FELighting::platformApplyNeon): Adapt to new layout of "struct PaintingData" after r225122.
+
2018-09-21 Alicia Boya García
[MSE] Fix comparsion with uninitialized greatestDecodeDuration
Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h (236455 => 236456)
--- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h 2018-09-25 06:36:04 UTC (rev 236455)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h 2018-09-25 14:18:19 UTC (rev 236456)
@@ -144,9 +144,9 @@
neonData.flags |= FLAG_CONE_EXPONENT_IS_1;
} else {
ASSERT(m_lightSource->type() == LS_DISTANT);
-floatArguments.lightX = paintingData.lightVector.x();
-floatArguments.lightY = paintingData.lightVector.y();
-floatArguments.lightZ = paintingData.lightVector.z();
+floatArguments.lightX = paintingData.initialLightingData.lightVector.x();
+floatArguments.lightY = paintingData.initialLightingData.lightVector.y();
+floatArguments.lightZ = paintingData.initialLightingData.lightVector.z();
floatArguments.padding2 = 1;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236455] trunk/Tools
Title: [236455] trunk/Tools
Revision 236455
Author mmaxfi...@apple.com
Date 2018-09-24 23:36:04 -0700 (Mon, 24 Sep 2018)
Log Message
[WHLSL] Not all functions should be able to run in all shader stages
https://bugs.webkit.org/show_bug.cgi?id=189121
Reviewed by Filip Pizlo.
ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
if/when we make them native.
The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
0. Therefore, those functions are unchanged.
* WebGPUShadingLanguageRI/All.js:
* WebGPUShadingLanguageRI/Intrinsics.js:
* WebGPUShadingLanguageRI/LateChecker.js:
(LateChecker.prototype._checkShaderType):
* WebGPUShadingLanguageRI/NativeFunc.js:
(NativeFunc):
(NativeFunc.prototype.get stage):
(NativeFunc.prototype.toDeclString):
* WebGPUShadingLanguageRI/Parse.js:
(parseFuncDecl):
(parseNativeFunc):
(parseNative):
* WebGPUShadingLanguageRI/Prepare.js:
(let.prepare):
* WebGPUShadingLanguageRI/SPIRV.html:
* WebGPUShadingLanguageRI/StandardLibrary.js:
(let.standardLibrary):
* WebGPUShadingLanguageRI/StatementCloner.js:
(StatementCloner.prototype.visitNativeFunc):
* WebGPUShadingLanguageRI/Test.html:
* WebGPUShadingLanguageRI/Test.js:
(tests.shaderStages):
* WebGPUShadingLanguageRI/WSyntaxError.js:
(WSyntaxError.prototype.toString):
(WSyntaxError):
* WebGPUShadingLanguageRI/index.html:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebGPUShadingLanguageRI/All.js
trunk/Tools/WebGPUShadingLanguageRI/Intrinsics.js
trunk/Tools/WebGPUShadingLanguageRI/LateChecker.js
trunk/Tools/WebGPUShadingLanguageRI/NativeFunc.js
trunk/Tools/WebGPUShadingLanguageRI/Parse.js
trunk/Tools/WebGPUShadingLanguageRI/Prepare.js
trunk/Tools/WebGPUShadingLanguageRI/SPIRV.html
trunk/Tools/WebGPUShadingLanguageRI/StandardLibrary.js
trunk/Tools/WebGPUShadingLanguageRI/StatementCloner.js
trunk/Tools/WebGPUShadingLanguageRI/Test.html
trunk/Tools/WebGPUShadingLanguageRI/Test.js
trunk/Tools/WebGPUShadingLanguageRI/WSyntaxError.js
trunk/Tools/WebGPUShadingLanguageRI/index.html
Added Paths
trunk/Tools/WebGPUShadingLanguageRI/CheckNativeFuncStages.js
Diff
Modified: trunk/Tools/ChangeLog (236454 => 236455)
--- trunk/Tools/ChangeLog 2018-09-25 05:12:13 UTC (rev 236454)
+++ trunk/Tools/ChangeLog 2018-09-25 06:36:04 UTC (rev 236455)
@@ -1,3 +1,44 @@
+2018-09-24 Myles C. Maxfield
+
+[WHLSL] Not all functions should be able to run in all shader stages
+https://bugs.webkit.org/show_bug.cgi?id=189121
+
+Reviewed by Filip Pizlo.
+
+ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
+ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
+if/when we make them native.
+
+The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
+0. Therefore, those functions are unchanged.
+
+* WebGPUShadingLanguageRI/All.js:
+* WebGPUShadingLanguageRI/Intrinsics.js:
+* WebGPUShadingLanguageRI/LateChecker.js:
+(LateChecker.prototype._checkShaderType):
+* WebGPUShadingLanguageRI/NativeFunc.js:
+(NativeFunc):
+(NativeFunc.prototype.get stage):
+(NativeFunc.prototype.toDeclString):
+* WebGPUShadingLanguageRI/Parse.js:
+(parseFuncDecl):
+(parseNativeFunc):
+(parseNative):
+* WebGPUShadingLanguageRI/Prepare.js:
+(let.prepare):
+* WebGPUShadingLanguageRI/SPIRV.html:
+* WebGPUShadingLanguageRI/StandardLibrary.js:
+(let.standardLibrary):
+* WebGPUShadingLanguageRI/StatementCloner.js:
+(StatementCloner.prototype.visitNativeFunc):
+* WebGPUShadingLanguageRI/Test.html:
+* WebGPUShadingLanguageRI/Test.js:
+(tests.shaderStages):
+* WebGPUShadingLanguageRI/WSyntaxError.js:
+(WSyntaxError.prototype.toString):
+(WSyntaxError):
+* WebGPUShadingLanguageRI/index.html:
+
2018-09-24 Thomas Denney
[WHLSL] Implement trap statements in Metal code generation
Modified: trunk/Tools/WebGPUShadingLanguageRI/All.js (236454 => 236455)
--- trunk/Tools/WebGPUShadingLanguageRI/All.js 2018-09-25 05:12:13 UTC (rev 236454)
+++ trunk/Tools/WebGPUShadingLanguageRI/All.js 2018-09-25 06:36:04 UTC (rev 236455)
@@ -56,6 +56,7 @@
load("Check.js");
load("CheckLiteralTypes.js");
load("CheckLoops.js");
+load("CheckNativeFuncStages.js");
load("CheckRecursion.js");
load("CheckRecursiveTypes.js");
load("CheckReturns.js");
Copied: trunk/Tools/WebGPUShadingLanguageRI/CheckNativeFuncStages.js (from rev 236454, trunk/Tools/WebGPUShadingLanguageRI/NativeFunc.js) (0 => 236455)
---
