[webkit-changes] [236784] trunk
Title: [236784] trunk Revision 236784 Author cdu...@apple.com Date 2018-10-02 18:59:04 -0700 (Tue, 02 Oct 2018) Log Message MessageEvent.ports should return the same object https://bugs.webkit.org/show_bug.cgi?id=190151 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT test now that it is passing. * web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt: Source/WebCore: MessageEvent.ports should return the same object it was initialized to instead of constructing a new JSValue every time. No new tests, rebaselined existing test. * bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::ports const): (WebCore::JSMessageEvent::visitAdditionalChildren): * dom/MessageEvent.cpp: (WebCore::MessageEvent::initMessageEvent): * dom/MessageEvent.h: * dom/MessageEvent.idl: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp trunk/Source/WebCore/dom/MessageEvent.cpp trunk/Source/WebCore/dom/MessageEvent.h trunk/Source/WebCore/dom/MessageEvent.idl Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236783 => 236784) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-03 01:49:05 UTC (rev 236783) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-03 01:59:04 UTC (rev 236784) @@ -1,5 +1,16 @@ 2018-10-02 Chris Dumez +MessageEvent.ports should return the same object +https://bugs.webkit.org/show_bug.cgi?id=190151 + +Reviewed by Darin Adler. + +Rebaseline WPT test now that it is passing. + +* web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt: + +2018-10-02 Chris Dumez + radio / checkbox inputs should fire "click, input, change" events in order when clicked https://bugs.webkit.org/show_bug.cgi?id=190223 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt (236783 => 236784) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt 2018-10-03 01:49:05 UTC (rev 236783) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt 2018-10-03 01:59:04 UTC (rev 236784) @@ -2,7 +2,7 @@ PASS Default event values PASS MessageEventInit dictionary PASS Passing null for ports member -FAIL ports attribute should be a FrozenArray assert_true: ev.ports should return the same object expected true got false +PASS ports attribute should be a FrozenArray PASS initMessageEvent operation PASS Passing null for ports parameter to initMessageEvent PASS initMessageEvent operation default parameter values Modified: trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt (236783 => 236784) --- trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt 2018-10-03 01:49:05 UTC (rev 236783) +++ trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt 2018-10-03 01:59:04 UTC (rev 236784) @@ -2,7 +2,7 @@ PASS Default event values PASS MessageEventInit dictionary PASS Passing null for ports member -FAIL ports attribute should be a FrozenArray assert_true: ev.ports should return the same object expected true got false +PASS ports attribute should be a FrozenArray PASS initMessageEvent operation PASS Passing null for ports parameter to initMessageEvent PASS initMessageEvent operation default parameter values Modified: trunk/Source/WebCore/ChangeLog (236783 => 236784) --- trunk/Source/WebCore/ChangeLog 2018-10-03 01:49:05 UTC (rev 236783) +++ trunk/Source/WebCore/ChangeLog 2018-10-03 01:59:04 UTC (rev 236784) @@ -1,3 +1,23 @@ +2018-10-02 Chris Dumez + +MessageEvent.ports should return the same object +https://bugs.webkit.org/show_bug.cgi?id=190151 + +Reviewed by Darin Adler. + +MessageEvent.ports should return the same object it was initialized to instead of +constructing a new JSValue every time. + +No new tests, rebaselined existing test. + +* bindings/js/JSMessageEventCustom.cpp: +(WebCore::JSMessageEvent::ports const): +(WebCore::JSMessageEvent::visitAdditionalChildren): +* dom/MessageEvent.cpp: +(WebCore::MessageEvent::initMessageEvent): +* dom/MessageEvent.h: +*
[webkit-changes] [236783] trunk/Source/WebInspectorUI
Title: [236783] trunk/Source/WebInspectorUI
Revision 236783
Author drou...@apple.com
Date 2018-10-02 18:49:05 -0700 (Tue, 02 Oct 2018)
Log Message
Web Inspector: merge SourceMapManager into NetworkManager
https://bugs.webkit.org/show_bug.cgi?id=190224
Reviewed by Joseph Pecoraro.
* UserInterface/Main.html:
* UserInterface/Base/Main.js:
(WI.loaded):
* UserInterface/Test.html:
* UserInterface/Test/Test.js:
(WI.loaded):
* UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager):
(WI.NetworkManager.prototype.downloadSourceMap): Added.
(WI.NetworkManager.prototype.resourceRequestWasServedFromMemoryCache):
(WI.NetworkManager.prototype.resourceRequestDidFinishLoading):
(WI.NetworkManager.prototype._createResource):
(WI.NetworkManager.prototype._loadAndParseSourceMap): Added.
(WI.NetworkManager.prototype._sourceMapLoadAndParseFailed): Added.
(WI.NetworkManager.prototype._sourceMapLoadAndParseSucceeded): Added.
(WI.NetworkManager.prototype._handleFrameMainResourceDidChange): Added.
* UserInterface/Controllers/SourceMapManager.js: Removed.
* UserInterface/Models/Script.js:
(WI.Script):
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Models/Script.js
trunk/Source/WebInspectorUI/UserInterface/Test/Test.js
trunk/Source/WebInspectorUI/UserInterface/Test.html
trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj
trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters
Removed Paths
trunk/Source/WebInspectorUI/UserInterface/Controllers/SourceMapManager.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236782 => 236783)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-03 00:48:59 UTC (rev 236782)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-03 01:49:05 UTC (rev 236783)
@@ -1,3 +1,35 @@
+2018-10-02 Devin Rousso
+
+Web Inspector: merge SourceMapManager into NetworkManager
+https://bugs.webkit.org/show_bug.cgi?id=190224
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Main.html:
+* UserInterface/Base/Main.js:
+(WI.loaded):
+* UserInterface/Test.html:
+* UserInterface/Test/Test.js:
+(WI.loaded):
+
+* UserInterface/Controllers/NetworkManager.js:
+(WI.NetworkManager):
+(WI.NetworkManager.prototype.downloadSourceMap): Added.
+(WI.NetworkManager.prototype.resourceRequestWasServedFromMemoryCache):
+(WI.NetworkManager.prototype.resourceRequestDidFinishLoading):
+(WI.NetworkManager.prototype._createResource):
+(WI.NetworkManager.prototype._loadAndParseSourceMap): Added.
+(WI.NetworkManager.prototype._sourceMapLoadAndParseFailed): Added.
+(WI.NetworkManager.prototype._sourceMapLoadAndParseSucceeded): Added.
+(WI.NetworkManager.prototype._handleFrameMainResourceDidChange): Added.
+* UserInterface/Controllers/SourceMapManager.js: Removed.
+
+* UserInterface/Models/Script.js:
+(WI.Script):
+
+* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
+* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
+
2018-10-02 Nikita Vasilyev
Web Inspector: Styles: start editing property name/value on mouseup instead of mousedown
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (236782 => 236783)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-10-03 00:48:59 UTC (rev 236782)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2018-10-03 01:49:05 UTC (rev 236783)
@@ -123,7 +123,6 @@
this.applicationCacheManager = new WI.ApplicationCacheManager;
this.timelineManager = new WI.TimelineManager;
this.debuggerManager = new WI.DebuggerManager;
-this.sourceMapManager = new WI.SourceMapManager;
this.layerTreeManager = new WI.LayerTreeManager;
this.probeManager = new WI.ProbeManager;
this.workerManager = new WI.WorkerManager;
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js (236782 => 236783)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js 2018-10-03 00:48:59 UTC (rev 236782)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js 2018-10-03 01:49:05 UTC (rev 236783)
@@ -37,6 +37,9 @@
this._waitingForMainFrameResourceTreePayload = true;
+this._sourceMapURLMap = new Map;
+this._downloadingSourceMaps = new Set;
+
if (window.PageAgent) {
PageAgent.enable();
PageAgent.getResourceTree(this._processMainFrameResourceTreePayload.bind(this));
@@ -49,6 +52,7 @@
NetworkAgent.enable();
[webkit-changes] [236782] tags/Safari-606.2.104.1.1/
Title: [236782] tags/Safari-606.2.104.1.1/ Revision 236782 Author kocsen_ch...@apple.com Date 2018-10-02 17:48:59 -0700 (Tue, 02 Oct 2018) Log Message Tag Safari-606.2.104.1.1. Added Paths tags/Safari-606.2.104.1.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236781] trunk
Title: [236781] trunk Revision 236781 Author rn...@webkit.org Date 2018-10-02 17:29:46 -0700 (Tue, 02 Oct 2018) Log Message GC can collect JS wrappers of nodes in the mutation records waiting to be delivered https://bugs.webkit.org/show_bug.cgi?id=190115 Reviewed by Geoffrey Garen. Source/WebCore: Fixed the bug by retaining JS wrappers of elements in mutation records using GCReachableRef. This patch deploys GCReachableRef in two places: MutationObserver where each mutation record's target is kept alive and MutationObserverRegistration where each node which had been removed from an observed tree is kept alive for a subtree observation. Test: fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive.html * dom/GCReachableRef.h: (WebCore::GCReachableRef): Made it work with hash table. (WebCore::GCReachableRef::operator T& const): (WebCore::GCReachableRef::GCReachableRef): (WebCore::GCReachableRef::isHashTableDeletedValue const): (WebCore::GCReachableRef::isHashTableEmptyValue const): (WebCore::GCReachableRef::ptrAllowingHashTableEmptyValue const): (WebCore::GCReachableRef::ptrAllowingHashTableEmptyValue): (WebCore::GCReachableRef::assignToHashTableEmptyValue): (WTF::HashTraits>::emptyValue): (WTF::HashTraits>::constructEmptyValue): (WTF::HashTraits>::isEmptyValue): (WTF::HashTraits>::assignToEmpty): (WTF::HashTraits>::peek): (WTF::HashTraits>::take): * dom/MutationObserver.cpp: (WebCore::MutationObserver::takeRecords): Don't clear m_pendingTargets because that would allow wrappers to be collected before elements in mutation records are accessed. We delay until the end of the current microtask at which point deliver() function is called. (WebCore::MutationObserver::disconnect): (WebCore::MutationObserver::enqueueMutationRecord): Add the target to the list of elements to keep alive. This is needed for a newly inserted node, a node with attribute change, etc... (WebCore::MutationObserver::deliver): Keep the set of transient registration targets alive until mutation records are delivered to each observer. These are nodes which had been removed from a tree and whose subtree had still been obsreved up until this point. * dom/MutationObserver.h: * dom/MutationObserverRegistration.cpp: (WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach): (WebCore::MutationObserverRegistration::takeTransientRegistrations): Return the hash set of elemenets that need to be kept alive so that MutationObserver::deliver can keep them alive until the deliver function had been called. (WebCore::MutationObserverRegistration::addRegistrationNodesToSet const): * dom/MutationObserverRegistration.h: LayoutTests: Added a regression test. * fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive-expected.txt: Added. * fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/GCReachableRef.h trunk/Source/WebCore/dom/MutationObserver.cpp trunk/Source/WebCore/dom/MutationObserver.h trunk/Source/WebCore/dom/MutationObserverRegistration.cpp trunk/Source/WebCore/dom/MutationObserverRegistration.h Added Paths trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive-expected.txt trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive.html Diff Modified: trunk/LayoutTests/ChangeLog (236780 => 236781) --- trunk/LayoutTests/ChangeLog 2018-10-03 00:29:42 UTC (rev 236780) +++ trunk/LayoutTests/ChangeLog 2018-10-03 00:29:46 UTC (rev 236781) @@ -1,3 +1,15 @@ +2018-10-01 Ryosuke Niwa + +GC can collect JS wrappers of nodes in the mutation records waiting to be delivered +https://bugs.webkit.org/show_bug.cgi?id=190115 + +Reviewed by Geoffrey Garen. + +Added a regression test. + +* fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive-expected.txt: Added. +* fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive.html: Added. + 2018-10-02 Chris Dumez radio / checkbox inputs should fire "click, input, change" events in order when clicked Added: trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive-expected.txt (0 => 236781) --- trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive-expected.txt (rev 0) +++ trunk/LayoutTests/fast/dom/MutationObserver/mutation-observer-retains-js-wrappers-of-targets-alive-expected.txt 2018-10-03 00:29:46 UTC (rev 236781) @@ -0,0 +1,23 @@ +This tests that JS wrappers of nodes in a tree mutation record do not get collected. + +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS +PASS + Added:
[webkit-changes] [236780] trunk/Source/WebInspectorUI
Title: [236780] trunk/Source/WebInspectorUI
Revision 236780
Author nvasil...@apple.com
Date 2018-10-02 17:29:42 -0700 (Tue, 02 Oct 2018)
Log Message
Web Inspector: Styles: start editing property name/value on mouseup instead of mousedown
https://bugs.webkit.org/show_bug.cgi?id=190114
Reviewed by Matt Baker.
This change only affects the experimental multiple properties selection.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)):
Without this code, the focus outline flickers on click (after mousedown but before mouseup event).
* UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype._handleMouseUp):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236779 => 236780)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-03 00:28:21 UTC (rev 236779)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-03 00:29:42 UTC (rev 236780)
@@ -1,3 +1,23 @@
+2018-10-02 Nikita Vasilyev
+
+Web Inspector: Styles: start editing property name/value on mouseup instead of mousedown
+https://bugs.webkit.org/show_bug.cgi?id=190114
+
+
+Reviewed by Matt Baker.
+
+This change only affects the experimental multiple properties selection.
+
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
+(WI.SpreadsheetCSSStyleDeclarationSection):
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
+(.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)):
+Without this code, the focus outline flickers on click (after mousedown but before mouseup event).
+
+* UserInterface/Views/SpreadsheetTextField.js:
+(WI.SpreadsheetTextField):
+(WI.SpreadsheetTextField.prototype._handleMouseUp):
+
2018-10-02 Devin Rousso
Web Inspector: prevent layer events from firing until the layer information is re-requested
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css (236779 => 236780)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css 2018-10-03 00:28:21 UTC (rev 236779)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css 2018-10-03 00:29:42 UTC (rev 236780)
@@ -52,6 +52,10 @@
padding-bottom: 0 !important;
}
+.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing) {
+outline: none;
+}
+
.spreadsheet-style-declaration-editor .value.editing {
display: inline-block;
position: relative;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js (236779 => 236780)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js 2018-10-03 00:28:21 UTC (rev 236779)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js 2018-10-03 00:29:42 UTC (rev 236780)
@@ -31,6 +31,10 @@
let element = document.createElement("section");
element.classList.add("spreadsheet-css-declaration");
+
+if (WI.settings.experimentalEnableMultiplePropertiesSelection.value)
+element.classList.add("multiple-properties-selection");
+
super(element);
this._delegate = delegate || null;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js (236779 => 236780)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2018-10-03 00:28:21 UTC (rev 236779)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2018-10-03 00:29:42 UTC (rev 236780)
@@ -40,7 +40,11 @@
this._element.classList.add("spreadsheet-text-field");
-this._element.addEventListener("focus", this._handleFocus.bind(this));
+if (WI.settings.experimentalEnableMultiplePropertiesSelection.value)
+this._element.addEventListener("mouseup", this._handleMouseUp.bind(this));
+else
+this._element.addEventListener("focus", this._handleFocus.bind(this));
+
this._element.addEventListener("blur", this._handleBlur.bind(this));
this._element.addEventListener("keydown", this._handleKeyDown.bind(this));
this._element.addEventListener("input", this._handleInput.bind(this));
@@ -197,6 +201,11 @@
}
}
+_handleMouseUp(event)
+
[webkit-changes] [236779] trunk
Title: [236779] trunk Revision 236779 Author cdu...@apple.com Date 2018-10-02 17:28:21 -0700 (Tue, 02 Oct 2018) Log Message radio / checkbox inputs should fire "click, input, change" events in order when clicked https://bugs.webkit.org/show_bug.cgi?id=190223 Reviewed by Ryosuke Niwa. LayoutTests/imported/w3c: Rebaseline a few WPT tests that are now passing. I have verified that those are passing in Gecko and Blink as well. * web-platform-tests/html/semantics/forms/the-input-element/checkbox-click-events-expected.txt: * web-platform-tests/html/semantics/forms/the-input-element/checkbox-expected.txt: * web-platform-tests/html/semantics/forms/the-input-element/radio-expected.txt: Source/WebCore: radio / checkbox inputs should fire "click, input, change" events in order when clicked: - https://html.spec.whatwg.org/#radio-button-state-(type=radio) - https://html.spec.whatwg.org/#checkbox-state-(type=checkbox) - https://dom.spec.whatwg.org/#ref-for-eventtarget-activation-behavior③ (step 11) Gecko and Blink already behave this way. However, WebKit has the following issues: - the input event is not fired - the click event is fired after the change event No new tests, updated / rebaselined existing tests. * html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::fireInputAndChangeEvents): * html/BaseCheckableInputType.h: * html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::willDispatchClick): (WebCore::CheckboxInputType::didDispatchClick): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): * html/HTMLInputElement.h: * html/RadioInputType.cpp: (WebCore::RadioInputType::willDispatchClick): (WebCore::RadioInputType::didDispatchClick): LayoutTests: Update existing test to reflect behavior change. I have verified that our new behavior on this test is consistent with Gecko and Chrome. * fast/forms/radio/radio-group-keyboard-change-event-expected.txt: * fast/forms/radio/radio-group-keyboard-change-event.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt trunk/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/checkbox-click-events-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/checkbox-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/BaseCheckableInputType.cpp trunk/Source/WebCore/html/BaseCheckableInputType.h trunk/Source/WebCore/html/CheckboxInputType.cpp trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/RadioInputType.cpp Diff Modified: trunk/LayoutTests/ChangeLog (236778 => 236779) --- trunk/LayoutTests/ChangeLog 2018-10-03 00:26:41 UTC (rev 236778) +++ trunk/LayoutTests/ChangeLog 2018-10-03 00:28:21 UTC (rev 236779) @@ -1,5 +1,18 @@ 2018-10-02 Chris Dumez +radio / checkbox inputs should fire "click, input, change" events in order when clicked +https://bugs.webkit.org/show_bug.cgi?id=190223 + +Reviewed by Ryosuke Niwa. + +Update existing test to reflect behavior change. I have verified that our new behavior +on this test is consistent with Gecko and Chrome. + +* fast/forms/radio/radio-group-keyboard-change-event-expected.txt: +* fast/forms/radio/radio-group-keyboard-change-event.html: + +2018-10-02 Chris Dumez + fieldset.elements should return an HTMLCollection instead of an HTMLFormControlsCollection https://bugs.webkit.org/show_bug.cgi?id=190218 Modified: trunk/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt (236778 => 236779) --- trunk/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt 2018-10-03 00:26:41 UTC (rev 236778) +++ trunk/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event-expected.txt 2018-10-03 00:28:21 UTC (rev 236779) @@ -8,10 +8,22 @@ d e f +b dispatched click event +PASS: b is checked +b dispatched input event +PASS: b is checked b dispatched change event +PASS: b is checked +c dispatched click event +PASS: c is checked +c dispatched input event +PASS: c is checked c dispatched change event -e dispatched change event -f dispatched change event +PASS: c is checked +e dispatched click event +PASS: e is checked +f dispatched click event +PASS: f is checked PASS: a is not checked PASS: b is not checked PASS: c is checked Modified: trunk/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html (236778 => 236779) --- trunk/LayoutTests/fast/forms/radio/radio-group-keyboard-change-event.html 2018-10-03 00:26:41 UTC (rev 236778) +++
[webkit-changes] [236778] trunk
Title: [236778] trunk Revision 236778 Author cdu...@apple.com Date 2018-10-02 17:26:41 -0700 (Tue, 02 Oct 2018) Log Message fieldset.elements should return an HTMLCollection instead of an HTMLFormControlsCollection https://bugs.webkit.org/show_bug.cgi?id=190218 Reviewed by Alex Christensen. LayoutTests/imported/w3c: Rebaseline existing WPT test now that it is passing. * web-platform-tests/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement-expected.txt: Source/WebCore: fieldset.elements should return an HTMLCollection instead of an HTMLFormControlsCollection: - https://github.com/whatwg/html/commit/8beedf0c2ffd38853caddec67490288f47afc8eb Gecko has always behaved this way. Blink aligned with Gecko and the HTML specification in December 2016: - https://bugs.chromium.org/p/chromium/issues/detail?id=665291 This simplifies our HTMLFieldSetElement code a lot. Test: fast/forms/fieldset/fieldset-elements-htmlcollection.html * html/CollectionType.h: * html/GenericCachedHTMLCollection.cpp: (WebCore::GenericCachedHTMLCollection::elementMatches const): * html/HTMLCollection.cpp: (WebCore::HTMLCollection::rootTypeFromCollectionType): (WebCore::invalidationTypeExcludingIdAndNameAttributes): * html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::elements): * html/HTMLFieldSetElement.h: * html/HTMLFieldSetElement.idl: * html/HTMLFormControlsCollection.cpp: (WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection): (WebCore:: const): (WebCore::HTMLFormControlsCollection::copyFormControlElementsVector const): (WebCore::HTMLFormControlsCollection::ownerNode const): (WebCore::HTMLFormControlsCollection::updateNamedElementCache const): * html/HTMLFormControlsCollection.h: LayoutTests: Update existing tests to reflect behavior change, after checking that our behavior is consistent with Gecko and Blink on these tests. * fast/forms/fieldset/fieldset-elements-expected.txt: * fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt: Added. * fast/forms/fieldset/fieldset-elements-htmlcollection.html: Added. * fast/forms/fieldset/fieldset-elements.html: * fast/forms/fieldset/fieldset-form-collection-radionode-list-expected.txt: Removed. * fast/forms/fieldset/fieldset-form-collection-radionode-list.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/fieldset/fieldset-elements-expected.txt trunk/LayoutTests/fast/forms/fieldset/fieldset-elements.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/CollectionType.h trunk/Source/WebCore/html/GenericCachedHTMLCollection.cpp trunk/Source/WebCore/html/HTMLCollection.cpp trunk/Source/WebCore/html/HTMLFieldSetElement.cpp trunk/Source/WebCore/html/HTMLFieldSetElement.h trunk/Source/WebCore/html/HTMLFieldSetElement.idl trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp trunk/Source/WebCore/html/HTMLFormControlsCollection.h Added Paths trunk/LayoutTests/fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt trunk/LayoutTests/fast/forms/fieldset/fieldset-elements-htmlcollection.html Removed Paths trunk/LayoutTests/fast/forms/fieldset/fieldset-form-collection-radionode-list-expected.txt trunk/LayoutTests/fast/forms/fieldset/fieldset-form-collection-radionode-list.html Diff Modified: trunk/LayoutTests/ChangeLog (236777 => 236778) --- trunk/LayoutTests/ChangeLog 2018-10-03 00:25:10 UTC (rev 236777) +++ trunk/LayoutTests/ChangeLog 2018-10-03 00:26:41 UTC (rev 236778) @@ -1,3 +1,20 @@ +2018-10-02 Chris Dumez + +fieldset.elements should return an HTMLCollection instead of an HTMLFormControlsCollection +https://bugs.webkit.org/show_bug.cgi?id=190218 + +Reviewed by Alex Christensen. + +Update existing tests to reflect behavior change, after checking that our behavior is consistent +with Gecko and Blink on these tests. + +* fast/forms/fieldset/fieldset-elements-expected.txt: +* fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt: Added. +* fast/forms/fieldset/fieldset-elements-htmlcollection.html: Added. +* fast/forms/fieldset/fieldset-elements.html: +* fast/forms/fieldset/fieldset-form-collection-radionode-list-expected.txt: Removed. +* fast/forms/fieldset/fieldset-form-collection-radionode-list.html: Removed. + 2018-10-02 Devin Rousso Web Inspector: prevent layer events from firing until the layer information is re-requested Modified: trunk/LayoutTests/fast/forms/fieldset/fieldset-elements-expected.txt (236777 => 236778) --- trunk/LayoutTests/fast/forms/fieldset/fieldset-elements-expected.txt 2018-10-03 00:25:10 UTC (rev 236777) +++ trunk/LayoutTests/fast/forms/fieldset/fieldset-elements-expected.txt 2018-10-03 00:26:41 UTC (rev 236778) @@ -3,7 +3,7 @@ On success, you will see a series
[webkit-changes] [236777] trunk
Title: [236777] trunk
Revision 236777
Author drou...@apple.com
Date 2018-10-02 17:25:10 -0700 (Tue, 02 Oct 2018)
Log Message
Web Inspector: prevent layer events from firing until the layer information is re-requested
https://bugs.webkit.org/show_bug.cgi?id=190159
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector/layers/layerTreeDidChange.html
* inspector/agents/InspectorLayerTreeAgent.h:
* inspector/agents/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reset):
(WebCore::InspectorLayerTreeAgent::layerTreeDidChange):
(WebCore::InspectorLayerTreeAgent::layersForNode):
Source/WebInspectorUI:
* UserInterface/Controllers/LayerTreeManager.js:
(WI.LayerTreeManager):
(WI.LayerTreeManager.prototype.get supported):
Remove `supported` member variable in favor of re-evaluating its value.
* UserInterface/Protocol/LayerTreeObserver.js:
(WI.LayerTreeObserver.prototype.layerTreeDidChange):
LayoutTests:
* inspector/layers/layerTreeDidChange-expected.txt: Added.
* inspector/layers/layerTreeDidChange.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorLayerTreeAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorLayerTreeAgent.h
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/LayerTreeObserver.js
Added Paths
trunk/LayoutTests/inspector/layers/layerTreeDidChange-expected.txt
trunk/LayoutTests/inspector/layers/layerTreeDidChange.html
Diff
Modified: trunk/LayoutTests/ChangeLog (236776 => 236777)
--- trunk/LayoutTests/ChangeLog 2018-10-03 00:21:57 UTC (rev 236776)
+++ trunk/LayoutTests/ChangeLog 2018-10-03 00:25:10 UTC (rev 236777)
@@ -1,5 +1,15 @@
2018-10-02 Devin Rousso
+Web Inspector: prevent layer events from firing until the layer information is re-requested
+https://bugs.webkit.org/show_bug.cgi?id=190159
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/layers/layerTreeDidChange-expected.txt: Added.
+* inspector/layers/layerTreeDidChange.html: Added.
+
+2018-10-02 Devin Rousso
+
Web Inspector: rename frontend managers to be more consistent with backend agents
https://bugs.webkit.org/show_bug.cgi?id=190160
Added: trunk/LayoutTests/inspector/layers/layerTreeDidChange-expected.txt (0 => 236777)
--- trunk/LayoutTests/inspector/layers/layerTreeDidChange-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/layers/layerTreeDidChange-expected.txt 2018-10-03 00:25:10 UTC (rev 236777)
@@ -0,0 +1,17 @@
+Tests for LayerTree.event.layerTreeDidChange.
+
+
+== Running test suite: LayerTree.layerTreeDidChange
+-- Running test case: LayerTree.layerTreeDidChange.WithRequest
+Creating layer...
+Layer tree changed
+Creating layer...
+Layer tree changed
+PASS: LayerTreeDidChange should fire after layersForNode is called
+
+-- Running test case: LayerTree.layerTreeDidChange.WithoutRequest
+Creating layer...
+Layer tree changed
+Creating layer...
+PASS: LayerTreeDidChange should not fire before layersForNode is called
+
Added: trunk/LayoutTests/inspector/layers/layerTreeDidChange.html (0 => 236777)
--- trunk/LayoutTests/inspector/layers/layerTreeDidChange.html (rev 0)
+++ trunk/LayoutTests/inspector/layers/layerTreeDidChange.html 2018-10-03 00:25:10 UTC (rev 236777)
@@ -0,0 +1,122 @@
+
+
+
+
+
+function addCompositedLayer()
+{
+var element = document.createElement("div");
+element.className = "composited";
+element.id = "last-element";
+document.body.appendChild(element);
+
+requestAnimationFrame(() => {
+TestPage.dispatchEventToFrontend("TestPageDidAppendChild");
+});
+};
+
+function test()
+{
+let documentNode = null;
+
+let suite = InspectorTest.createAsyncSuite("LayerTree.layerTreeDidChange");
+
+suite.addTestCase({
+name: "LayerTree.layerTreeDidChange.WithRequest",
+description: "Check that layerTreeDidChange is able to be dispatched once LayerTree.commands.layersForNode is called.",
+test(resolve, reject) {
+let layerTreeDidChangeCount = 0;
+let handleLayerTreeDidChange = WI.layerTreeManager.addEventListener(WI.LayerTreeManager.Event.LayerTreeDidChange, (event) => {
+++layerTreeDidChangeCount;
+
+InspectorTest.log("Layer tree changed");
+
+if (layerTreeDidChangeCount === 1) {
+WI.layerTreeManager.layersForNode(documentNode, (layers) => {
+InspectorTest.log("Creating layer...");
+InspectorTest.evaluateInPage(`addCompositedLayer()`);
+});
+}
+});
+
+let testPageDidAppendChildCount = 0;
+let handleTestPageDidAppendChild = InspectorTest.addEventListener("TestPageDidAppendChild", (event) => {
+
[webkit-changes] [236776] trunk/Source/WebInspectorUI
Title: [236776] trunk/Source/WebInspectorUI
Revision 236776
Author drou...@apple.com
Date 2018-10-02 17:21:57 -0700 (Tue, 02 Oct 2018)
Log Message
Web Inspector: REGRESSION(r236766): WI.IssueManager no longer exists
https://bugs.webkit.org/show_bug.cgi?id=190226
Reviewed by Joseph Pecoraro.
* UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager.prototype.issuesForSourceCode):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236775 => 236776)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-03 00:13:09 UTC (rev 236775)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-03 00:21:57 UTC (rev 236776)
@@ -1,5 +1,15 @@
2018-10-02 Devin Rousso
+Web Inspector: REGRESSION(r236766): WI.IssueManager no longer exists
+https://bugs.webkit.org/show_bug.cgi?id=190226
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Controllers/ConsoleManager.js:
+(WI.ConsoleManager.prototype.issuesForSourceCode):
+
+2018-10-02 Devin Rousso
+
Web Inspector: rename frontend managers to be more consistent with backend agents
https://bugs.webkit.org/show_bug.cgi?id=190160
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js (236775 => 236776)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js 2018-10-03 00:13:09 UTC (rev 236775)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js 2018-10-03 00:21:57 UTC (rev 236776)
@@ -84,7 +84,7 @@
for (var i = 0; i < this._issues.length; ++i) {
var issue = this._issues[i];
-if (WI.IssueManager.issueMatchSourceCode(issue, sourceCode))
+if (WI.ConsoleManager.issueMatchSourceCode(issue, sourceCode))
issues.push(issue);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236775] trunk/Source/WebKit
Title: [236775] trunk/Source/WebKit
Revision 236775
Author commit-qu...@webkit.org
Date 2018-10-02 17:13:09 -0700 (Tue, 02 Oct 2018)
Log Message
Deprecate WKConnection
https://bugs.webkit.org/show_bug.cgi?id=190147
Patch by Alex Christensen on 2018-10-02
Reviewed by Andy Estes.
* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* UIProcess/API/Cocoa/WKConnection.h:
* UIProcess/API/Cocoa/WKConnection.mm:
(didReceiveMessage):
(didClose):
* UIProcess/API/Cocoa/WKConnectionInternal.h:
* UIProcess/API/Cocoa/WKProcessGroup.h:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/APIObject.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnectionInternal.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.h
trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h
trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (236774 => 236775)
--- trunk/Source/WebKit/ChangeLog 2018-10-02 23:55:42 UTC (rev 236774)
+++ trunk/Source/WebKit/ChangeLog 2018-10-03 00:13:09 UTC (rev 236775)
@@ -1,3 +1,21 @@
+2018-10-02 Alex Christensen
+
+Deprecate WKConnection
+https://bugs.webkit.org/show_bug.cgi?id=190147
+
+Reviewed by Andy Estes.
+
+* Shared/Cocoa/APIObject.mm:
+(API::Object::newObject):
+* UIProcess/API/Cocoa/WKConnection.h:
+* UIProcess/API/Cocoa/WKConnection.mm:
+(didReceiveMessage):
+(didClose):
+* UIProcess/API/Cocoa/WKConnectionInternal.h:
+* UIProcess/API/Cocoa/WKProcessGroup.h:
+* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
+* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
+
2018-10-01 Dean Jackson
[macOS] Switching to discrete GPU should be done in the UI process
Modified: trunk/Source/WebKit/Shared/Cocoa/APIObject.mm (236774 => 236775)
--- trunk/Source/WebKit/Shared/Cocoa/APIObject.mm 2018-10-02 23:55:42 UTC (rev 236774)
+++ trunk/Source/WebKit/Shared/Cocoa/APIObject.mm 2018-10-03 00:13:09 UTC (rev 236775)
@@ -178,7 +178,9 @@
case Type::Connection:
// While not actually a WKObject instance, WKConnection uses allocateWKObject to allocate extra space
// instead of using ObjectStorage because the wrapped C++ object is a subclass of WebConnection.
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
wrapper = allocateWKObject([WKConnection self], size);
+ALLOW_DEPRECATED_DECLARATIONS_END
break;
case Type::Preferences:
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.h (236774 => 236775)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.h 2018-10-02 23:55:42 UTC (rev 236774)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.h 2018-10-03 00:13:09 UTC (rev 236775)
@@ -38,7 +38,7 @@
@end
-WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0))
+WK_CLASS_DEPRECATED_WITH_REPLACEMENT("_WKRemoteObjectRegistry", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA))
@interface WKConnection : NSObject
- (void)sendMessageWithName:(NSString *)messageName body:(id)messageBody;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm (236774 => 236775)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm 2018-10-02 23:55:42 UTC (rev 236774)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm 2018-10-03 00:13:09 UTC (rev 236775)
@@ -49,7 +49,9 @@
static void didReceiveMessage(WKConnectionRef, WKStringRef messageName, WKTypeRef messageBody, const void* clientInfo)
{
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
auto connection = (__bridge WKConnection *)clientInfo;
+ALLOW_DEPRECATED_DECLARATIONS_END
auto delegate = connection->_delegate.get();
if ([delegate respondsToSelector:@selector(connection:didReceiveMessageWithName:body:)]) {
@@ -61,7 +63,9 @@
static void didClose(WKConnectionRef, const void* clientInfo)
{
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
auto connection = (__bridge WKConnection *)clientInfo;
+ALLOW_DEPRECATED_DECLARATIONS_END
auto delegate = connection->_delegate.get();
if ([delegate respondsToSelector:@selector(connectionDidClose:)])
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnectionInternal.h (236774 => 236775)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnectionInternal.h 2018-10-02 23:55:42 UTC (rev 236774)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnectionInternal.h 2018-10-03 00:13:09 UTC (rev 236775)
@@ -33,7 +33,9 @@
namespace WebKit {
template<> struct WrapperTraits {
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
using WrapperClass = WKConnection;
+ALLOW_DEPRECATED_DECLARATIONS_END
};
}
Modified:
[webkit-changes] [236774] trunk/Source/WebCore
Title: [236774] trunk/Source/WebCore
Revision 236774
Author bb...@apple.com
Date 2018-10-02 16:55:42 -0700 (Tue, 02 Oct 2018)
Log Message
Web Automation: tab default key handler should always cycle focus when page is controlled by automation
https://bugs.webkit.org/show_bug.cgi?id=190221
Reviewed by Joseph Pecoraro.
This change progresses WPT WebDriver test special_keys.py::test_webdriver_special_key_sends_keydown[TAB-expected24].
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):
Always cycle focus if the page is controlled by automation. If the chrome takes
focus, then the first responder will be something other than the WebView, which
causes subsequent WebDriver commands to hang.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FocusController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (236773 => 236774)
--- trunk/Source/WebCore/ChangeLog 2018-10-02 23:42:38 UTC (rev 236773)
+++ trunk/Source/WebCore/ChangeLog 2018-10-02 23:55:42 UTC (rev 236774)
@@ -1,3 +1,19 @@
+2018-10-02 Brian Burg
+
+Web Automation: tab default key handler should always cycle focus when page is controlled by automation
+https://bugs.webkit.org/show_bug.cgi?id=190221
+
+
+Reviewed by Joseph Pecoraro.
+
+This change progresses WPT WebDriver test special_keys.py::test_webdriver_special_key_sends_keydown[TAB-expected24].
+
+* page/FocusController.cpp:
+(WebCore::FocusController::advanceFocusInDocumentOrder):
+Always cycle focus if the page is controlled by automation. If the chrome takes
+focus, then the first responder will be something other than the WebView, which
+causes subsequent WebDriver commands to hang.
+
2018-10-01 Dean Jackson
[macOS] Switching to discrete GPU should be done in the UI process
Modified: trunk/Source/WebCore/page/FocusController.cpp (236773 => 236774)
--- trunk/Source/WebCore/page/FocusController.cpp 2018-10-02 23:42:38 UTC (rev 236773)
+++ trunk/Source/WebCore/page/FocusController.cpp 2018-10-02 23:55:42 UTC (rev 236774)
@@ -465,7 +465,7 @@
if (!element) {
// We didn't find a node to focus, so we should try to pass focus to Chrome.
-if (!initialFocus && m_page.chrome().canTakeFocus(direction)) {
+if (!initialFocus && m_page.chrome().canTakeFocus(direction) && !m_page.isControlledByAutomation()) {
document->setFocusedElement(nullptr);
setFocusedFrame(nullptr);
m_page.chrome().takeFocus(direction);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236773] trunk/Source
Title: [236773] trunk/Source Revision 236773 Author d...@apple.com Date 2018-10-02 16:42:38 -0700 (Tue, 02 Oct 2018) Log Message [macOS] Switching to discrete GPU should be done in the UI process https://bugs.webkit.org/show_bug.cgi?id=189361 Reviewed by Simon Fraser. Source/WebCore: Based on an earlier patch by Per Arne Vollan. Due to the fact we can't talk to the Window Server, the Web Process can no longer muxing to the discrete GPU directly. Instead we have to get the UI Process to process the change. Do this by adding a new Chrome client called GPUClient, that will have implementations provided by both WebKit and legacy WebKit. Unfortunately this can't be tested by a regular WKTR since: - it requires specific hardware - swapping to/from the discrete GPU takes about 20 seconds - running concurrent tests could confuse the tests into thinking the wrong GPU is active Instead we'll write a specific test for this functionality and run it on a separate bot. * WebCore.xcodeproj/project.pbxproj: Add GPUClient files. * page/Chrome.cpp: Drive by clean-up. (WebCore::Chrome::windowScreenDidChange): * platform/graphics/GraphicsContext3D.h: We need to keep track of whether we've muxed for this context, in order to not respond to the screen change notifications (they are misleading in the case of muxing). * platform/graphics/GraphicsContext3DManager.cpp: Rather than try to mux directly, call into GPUClient. (WebCore::GraphicsContext3DManager::displayWasReconfigured): (WebCore::GraphicsContext3DManager::updateHighPerformanceState): (WebCore::GraphicsContext3DManager::disableHighPerformanceGPUTimerFired): (WebCore::GraphicsContext3DManager::recycleContextIfNecessary): * platform/graphics/GraphicsContext3DManager.h: * platform/graphics/cocoa/GraphicsContext3DCocoa.mm: Only reconfigure the virtual display if it didn't happen from muxing. (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::updateCGLContext): (WebCore::GraphicsContext3D::screenDidChange): * platform/graphics/mac/GPUClient.cpp: Added. (WebCore::GPUClient::singleton): (WebCore::GPUClient::setSingleton): * platform/graphics/mac/GPUClient.h: Added. * testing/Internals.cpp: Testing helper. (WebCore::Internals::hasMuxableGPU): * testing/Internals.h: * testing/Internals.idl: Source/WebKit: Implement the UI-side process for triggering a GPU mux. * Platform/Logging.h: Add a WebGL logging channel. * SourcesCocoa.txt: Add the new files: WebGPUClient and HighPerformanceGPUManager. * UIProcess/Cocoa/WebProcessProxyCocoa.mm: UI process calls that use HighPerformanceGPUManager to keep track of whether or not this process needs the high-performance GPU. (WebKit::WebProcessProxy::requestHighPerformanceGPU): (WebKit::WebProcessProxy::releaseHighPerformanceGPU): * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::~WebProcessProxy): Make sure to unregister with the HighPerformanceGPUManager as the process disappears without manually removing itself (e.g. crashes). * UIProcess/WebProcessProxy.h: * UIProcess/WebProcessProxy.messages.in: New messages. * UIProcess/mac/HighPerformanceGPUManager.cpp: New class that copies most of what used to live in GraphicsContext3DManager. It creates a CGLPixelFormat object when it sees that at least one process needs the high-performance GPU. (WebKit::HighPerformanceGPUManager::singleton): (WebKit::HighPerformanceGPUManager::addProcessRequiringHighPerformance): (WebKit::HighPerformanceGPUManager::removeProcessRequiringHighPerformance): (WebKit::HighPerformanceGPUManager::updateState): * UIProcess/mac/HighPerformanceGPUManager.h: Added. * WebKit.xcodeproj/project.pbxproj: Add new files. * WebProcess/WebCoreSupport/mac/WebGPUClient.cpp: Implementation of the GPUClient for WebCore, which sends messages to the UI process. (WebKit::WebGPUClient::singleton): (WebKit::WebGPUClient::requestHighPerformanceGPU): (WebKit::WebGPUClient::releaseHighPerformanceGPU): * WebProcess/WebCoreSupport/mac/WebGPUClient.h: Added. * WebProcess/cocoa/WebProcessCocoa.mm: Register the GPUClient. (WebKit::WebProcess::platformInitializeProcess): Source/WebKitLegacy: * WebKitLegacy.xcodeproj/project.pbxproj: Add new files. Source/WebKitLegacy/mac: Implement a no-op GPUClient instance in legacy WebKit. We will not support swapping to the discrete GPU in this configuration. * WebCoreSupport/WebGPUClient.cpp: Added. (WebKit::WebGPUClient::singleton): * WebCoreSupport/WebGPUClient.h: Added. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Source/WTF: Define GL_SILENCE_DEPRECATION to avoid deprecation warnings for OpenGL. * wtf/Platform.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/page/Chrome.cpp trunk/Source/WebCore/platform/graphics/GraphicsContext3D.h trunk/Source/WebCore/platform/graphics/GraphicsContext3DManager.cpp
[webkit-changes] [236772] trunk/Source/WebKit
Title: [236772] trunk/Source/WebKit
Revision 236772
Author sihui_...@apple.com
Date 2018-10-02 16:02:39 -0700 (Tue, 02 Oct 2018)
Log Message
Fix a potential crash in NetworkProcess::deleteWebsiteDataForOrigins
https://bugs.webkit.org/show_bug.cgi?id=190220
Reviewed by Chris Dumez.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (236771 => 236772)
--- trunk/Source/WebKit/ChangeLog 2018-10-02 22:59:15 UTC (rev 236771)
+++ trunk/Source/WebKit/ChangeLog 2018-10-02 23:02:39 UTC (rev 236772)
@@ -1,3 +1,13 @@
+2018-10-02 Sihui Liu
+
+Fix a potential crash in NetworkProcess::deleteWebsiteDataForOrigins
+https://bugs.webkit.org/show_bug.cgi?id=190220
+
+Reviewed by Chris Dumez.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
+
2018-10-02 Wenson Hsieh
[WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (236771 => 236772)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2018-10-02 22:59:15 UTC (rev 236771)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2018-10-02 23:02:39 UTC (rev 236772)
@@ -772,7 +772,7 @@
if (websiteDataTypes.contains(WebsiteDataType::ServiceWorkerRegistrations) && !sessionID.isEphemeral()) {
auto& server = swServerForSession(sessionID);
for (auto& originData : originDatas)
-server.clear(originData, [clearTasksHandler = WTFMove(clearTasksHandler)] { });
+server.clear(originData, [clearTasksHandler = clearTasksHandler.copyRef()] { });
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236770] trunk
Title: [236770] trunk
Revision 236770
Author wenson_hs...@apple.com
Date 2018-10-02 15:53:37 -0700 (Tue, 02 Oct 2018)
Log Message
[WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
https://bugs.webkit.org/show_bug.cgi?id=179787
Reviewed by Tim Horton.
Source/WebKit:
Fixes the bug by relaxing our policy in WebViewImpl::updateFontManagerIfNeeded. Instead of updating only when
the font panel is visible, update when either the font panel is visible, or the selection is in a richly
editable area. In the latter case, an up-to-date NSFontManager state is needed in order for certain font
formatting menu items, such as bold and italic, to correctly toggle state.
Test: FontManagerTests.ToggleBoldAndItalicWithMenuItems
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(-[WKWindowVisibilityObserver observeValueForKeyPath:ofObject:change:context:]):
(WebKit::WebViewImpl::selectionDidChange):
(WebKit::WebViewImpl::updateFontManagerIfNeeded):
Rename updateFontPanelIfNeeded to updateFontManagerIfNeeded, to reflect the new behavior.
(WebKit::WebViewImpl::changeFontAttributesFromSender):
(WebKit::WebViewImpl::changeFontFromFontManager):
(WebKit::WebViewImpl::updateFontPanelIfNeeded): Deleted.
Tools:
Add a test to verify that NSFontManager's selected font is updated when applying italic and bold styles using
menu items.
* TestWebKitAPI/Tests/mac/FontManagerTests.mm:
(webViewForFontManagerTesting):
(menuItemCellForFontAction):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (236769 => 236770)
--- trunk/Source/WebKit/ChangeLog 2018-10-02 22:53:33 UTC (rev 236769)
+++ trunk/Source/WebKit/ChangeLog 2018-10-02 22:53:37 UTC (rev 236770)
@@ -1,3 +1,30 @@
+2018-10-02 Wenson Hsieh
+
+[WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
+https://bugs.webkit.org/show_bug.cgi?id=179787
+
+
+Reviewed by Tim Horton.
+
+Fixes the bug by relaxing our policy in WebViewImpl::updateFontManagerIfNeeded. Instead of updating only when
+the font panel is visible, update when either the font panel is visible, or the selection is in a richly
+editable area. In the latter case, an up-to-date NSFontManager state is needed in order for certain font
+formatting menu items, such as bold and italic, to correctly toggle state.
+
+Test: FontManagerTests.ToggleBoldAndItalicWithMenuItems
+
+* UIProcess/Cocoa/WebViewImpl.h:
+* UIProcess/Cocoa/WebViewImpl.mm:
+(-[WKWindowVisibilityObserver observeValueForKeyPath:ofObject:change:context:]):
+(WebKit::WebViewImpl::selectionDidChange):
+(WebKit::WebViewImpl::updateFontManagerIfNeeded):
+
+Rename updateFontPanelIfNeeded to updateFontManagerIfNeeded, to reflect the new behavior.
+
+(WebKit::WebViewImpl::changeFontAttributesFromSender):
+(WebKit::WebViewImpl::changeFontFromFontManager):
+(WebKit::WebViewImpl::updateFontPanelIfNeeded): Deleted.
+
2018-10-02 Alex Christensen
Remove ParsedURLString
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h (236769 => 236770)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h 2018-10-02 22:53:33 UTC (rev 236769)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.h 2018-10-02 22:53:37 UTC (rev 236770)
@@ -323,7 +323,7 @@
void selectionDidChange();
void didBecomeEditable();
-void updateFontPanelIfNeeded();
+void updateFontManagerIfNeeded();
void changeFontFromFontManager();
void changeFontAttributesFromSender(id);
void changeFontColorFromSender(id);
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (236769 => 236770)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2018-10-02 22:53:33 UTC (rev 236769)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2018-10-02 22:53:37 UTC (rev 236770)
@@ -374,7 +374,7 @@
}
if ([keyPath isEqualToString:@"visible"] && [NSFontPanel sharedFontPanelExists] && object == [NSFontPanel sharedFontPanel]) {
-_impl->updateFontPanelIfNeeded();
+_impl->updateFontManagerIfNeeded();
return;
}
if ([keyPath isEqualToString:@"contentLayoutRect"] || [keyPath isEqualToString:@"titlebarAppearsTransparent"])
@@ -2736,7 +2736,7 @@
void WebViewImpl::selectionDidChange()
{
-updateFontPanelIfNeeded();
+updateFontManagerIfNeeded();
if (!m_isHandlingAcceptedCandidate)
m_softSpaceRange = NSMakeRange(NSNotFound, 0);
#if HAVE(TOUCH_BAR)
@@ -2787,18 +2787,16 @@
});
}
-void WebViewImpl::updateFontPanelIfNeeded()
+void WebViewImpl::updateFontManagerIfNeeded()
{
-const EditorState& editorState =
[webkit-changes] [236769] trunk
Title: [236769] trunk
Revision 236769
Author cdu...@apple.com
Date 2018-10-02 15:53:33 -0700 (Tue, 02 Oct 2018)
Log Message
Image.__proto__ should be Function.prototype, not HTMLElement.prototype
https://bugs.webkit.org/show_bug.cgi?id=190216
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline existing WPT test now that it is passing.
* web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor-expected.txt:
Source/WebCore:
Properties created for named constructors should always use Function.prototype as prototype, as per:
- https://heycam.github.io/webidl/#named-constructors
Gecko and Blink agree with the Web IDL specification. However, WebKit was using the parent interface's
prototype if such a parent existing. So Image.__proto__ would end up being HTMLElement.prototype
instead of Function.prototype.
No new tests, rebaselined existing test.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor-expected.txt
trunk/LayoutTests/js/interface-objects-expected.txt
trunk/LayoutTests/js/interface-objects.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236768 => 236769)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-02 22:53:26 UTC (rev 236768)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-02 22:53:33 UTC (rev 236769)
@@ -1,3 +1,14 @@
+2018-10-02 Chris Dumez
+
+Image.__proto__ should be Function.prototype, not HTMLElement.prototype
+https://bugs.webkit.org/show_bug.cgi?id=190216
+
+Reviewed by Alex Christensen.
+
+Rebaseline existing WPT test now that it is passing.
+
+* web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor-expected.txt:
+
2018-10-01 Simon Pieters
in quirks mode should have margin-block-end: 1em
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor-expected.txt (236768 => 236769)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor-expected.txt 2018-10-02 22:53:26 UTC (rev 236768)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor-expected.txt 2018-10-02 22:53:33 UTC (rev 236769)
@@ -3,9 +3,5 @@
PASS Image and HTMLImageElement share a prototype
PASS Image localName is img
PASS Image namespace URI is correct
-FAIL NamedConstructor creates the correct object structure. assert_equals: Image __proto__ is Function prototype expected function "function () {
-[native code]
-}" but got function "function HTMLElement() {
-[native code]
-}"
+PASS NamedConstructor creates the correct object structure.
Modified: trunk/LayoutTests/js/interface-objects-expected.txt (236768 => 236769)
--- trunk/LayoutTests/js/interface-objects-expected.txt 2018-10-02 22:53:26 UTC (rev 236768)
+++ trunk/LayoutTests/js/interface-objects-expected.txt 2018-10-02 22:53:33 UTC (rev 236769)
@@ -16,7 +16,7 @@
* Interface with named constructor
PASS window.Audio instanceof Function is true
PASS typeof Audio is "function"
-PASS Object.getPrototypeOf(Audio) is HTMLMediaElement
+PASS Object.getPrototypeOf(Audio) is Function.prototype
PASS Audio() threw exception TypeError: Constructor requires 'new' operator.
PASS Audio.call() threw exception TypeError: Constructor requires 'new' operator.
PASS new Audio() did not throw exception.
Modified: trunk/LayoutTests/js/interface-objects.html (236768 => 236769)
--- trunk/LayoutTests/js/interface-objects.html 2018-10-02 22:53:26 UTC (rev 236768)
+++ trunk/LayoutTests/js/interface-objects.html 2018-10-02 22:53:33 UTC (rev 236769)
@@ -19,7 +19,7 @@
debug("* Interface with named constructor");
shouldBeTrue("window.Audio instanceof Function");
shouldBeEqualToString("typeof Audio", "function");
-shouldBe("Object.getPrototypeOf(Audio)", "HTMLMediaElement");
+shouldBe("Object.getPrototypeOf(Audio)", "Function.prototype");
shouldThrow("Audio()");
shouldThrow("Audio.call()");
shouldNotThrow("new Audio()");
Modified: trunk/Source/WebCore/ChangeLog (236768 => 236769)
--- trunk/Source/WebCore/ChangeLog 2018-10-02 22:53:26 UTC (rev 236768)
+++ trunk/Source/WebCore/ChangeLog 2018-10-02 22:53:33 UTC (rev 236769)
@@ -1,3 +1,22 @@
+2018-10-02 Chris Dumez
+
+Image.__proto__ should be Function.prototype, not HTMLElement.prototype
+https://bugs.webkit.org/show_bug.cgi?id=190216
+
+Reviewed by Alex Christensen.
+
+Properties created for named constructors should always use Function.prototype as prototype, as per:
+- https://heycam.github.io/webidl/#named-constructors
+
+
[webkit-changes] [236768] trunk/Source/JavaScriptCore
Title: [236768] trunk/Source/_javascript_Core
Revision 236768
Author commit-qu...@webkit.org
Date 2018-10-02 15:53:26 -0700 (Tue, 02 Oct 2018)
Log Message
Fix Disassembler-output on ARM Thumb2
https://bugs.webkit.org/show_bug.cgi?id=190203
On ARMv7 with Thumb2 addresses have bit 0 set to 1 to force
execution in thumb mode for jumps and calls. The actual machine
instructions are still aligned to 2-bytes though. Use dataLocation() as
start address for disassembling since it unsets the thumb bit.
Until now the disassembler would start at the wrong address (off by 1),
resulting in the wrong disassembled machine instructions.
Patch by Dominik Infuehr on 2018-10-02
Reviewed by Mark Lam.
* disassembler/CapstoneDisassembler.cpp:
(JSC::tryToDisassemble):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/disassembler/CapstoneDisassembler.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (236767 => 236768)
--- trunk/Source/_javascript_Core/ChangeLog 2018-10-02 22:34:09 UTC (rev 236767)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-10-02 22:53:26 UTC (rev 236768)
@@ -1,3 +1,20 @@
+2018-10-02 Dominik Infuehr
+
+Fix Disassembler-output on ARM Thumb2
+https://bugs.webkit.org/show_bug.cgi?id=190203
+
+On ARMv7 with Thumb2 addresses have bit 0 set to 1 to force
+execution in thumb mode for jumps and calls. The actual machine
+instructions are still aligned to 2-bytes though. Use dataLocation() as
+start address for disassembling since it unsets the thumb bit.
+Until now the disassembler would start at the wrong address (off by 1),
+resulting in the wrong disassembled machine instructions.
+
+Reviewed by Mark Lam.
+
+* disassembler/CapstoneDisassembler.cpp:
+(JSC::tryToDisassemble):
+
2018-10-02 Yusuke Suzuki
[JSC] Add stub of ExecutableAllocator used when JIT is disabled
Modified: trunk/Source/_javascript_Core/disassembler/CapstoneDisassembler.cpp (236767 => 236768)
--- trunk/Source/_javascript_Core/disassembler/CapstoneDisassembler.cpp 2018-10-02 22:34:09 UTC (rev 236767)
+++ trunk/Source/_javascript_Core/disassembler/CapstoneDisassembler.cpp 2018-10-02 22:53:26 UTC (rev 236768)
@@ -67,7 +67,7 @@
}
#endif
-size_t count = cs_disasm(handle, codePtr.untaggedExecutableAddress(), size, codePtr.untaggedExecutableAddress(), 0, );
+size_t count = cs_disasm(handle, codePtr.dataLocation(), size, codePtr.dataLocation(), 0, );
if (count > 0) {
for (size_t i = 0; i < count; ++i) {
auto& instruction = instructions[i];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236767] trunk/Source/WebCore
Title: [236767] trunk/Source/WebCore
Revision 236767
Author achristen...@apple.com
Date 2018-10-02 15:34:09 -0700 (Tue, 02 Oct 2018)
Log Message
Prepare WebCoreNSURLExtras for ARC
https://bugs.webkit.org/show_bug.cgi?id=190219
Reviewed by Tim Horton.
ARC doesn't like the explicit sending of -release.
Use RetainPtr instead.
* platform/mac/WebCoreNSURLExtras.mm:
(WebCore::collectRangesThatNeedMapping):
(WebCore::collectRangesThatNeedEncoding):
(WebCore::collectRangesThatNeedDecoding):
(WebCore::applyHostNameFunctionToMailToURLString):
(WebCore::applyHostNameFunctionToURLString):
(WebCore::mapHostNames):
(WebCore::stringByTrimmingWhitespace):
(WebCore::URLWithUserTypedString):
(WebCore::userVisibleString):
(WebCore::rangeOfURLScheme):
(WebCore::looksLikeAbsoluteURL):
(WebCore::retain): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236766 => 236767)
--- trunk/Source/WebCore/ChangeLog 2018-10-02 22:14:52 UTC (rev 236766)
+++ trunk/Source/WebCore/ChangeLog 2018-10-02 22:34:09 UTC (rev 236767)
@@ -1,3 +1,27 @@
+2018-10-02 Alex Christensen
+
+Prepare WebCoreNSURLExtras for ARC
+https://bugs.webkit.org/show_bug.cgi?id=190219
+
+Reviewed by Tim Horton.
+
+ARC doesn't like the explicit sending of -release.
+Use RetainPtr instead.
+
+* platform/mac/WebCoreNSURLExtras.mm:
+(WebCore::collectRangesThatNeedMapping):
+(WebCore::collectRangesThatNeedEncoding):
+(WebCore::collectRangesThatNeedDecoding):
+(WebCore::applyHostNameFunctionToMailToURLString):
+(WebCore::applyHostNameFunctionToURLString):
+(WebCore::mapHostNames):
+(WebCore::stringByTrimmingWhitespace):
+(WebCore::URLWithUserTypedString):
+(WebCore::userVisibleString):
+(WebCore::rangeOfURLScheme):
+(WebCore::looksLikeAbsoluteURL):
+(WebCore::retain): Deleted.
+
2018-10-02 Basuke Suzuki
[Curl] Fix missing values of resource timing API.
Modified: trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm (236766 => 236767)
--- trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm 2018-10-02 22:14:52 UTC (rev 236766)
+++ trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm 2018-10-02 22:34:09 UTC (rev 236767)
@@ -44,7 +44,7 @@
#define HOST_NAME_BUFFER_LENGTH 2048
#define URL_BYTES_BUFFER_LENGTH 2048
-typedef void (* StringRangeApplierFunction)(NSString *string, NSRange range, void *context);
+typedef void (* StringRangeApplierFunction)(NSString *, NSRange, RetainPtr&);
static uint32_t IDNScriptWhiteList[(USCRIPT_CODE_LIMIT + 31) / 32];
@@ -631,7 +631,7 @@
return !host ? string : host;
}
-static void collectRangesThatNeedMapping(NSString *string, NSRange range, void *context, BOOL encode)
+static void collectRangesThatNeedMapping(NSString *string, NSRange range, RetainPtr& array, BOOL encode)
{
// Generally, we want to optimize for the case where there is one host name that does not need mapping.
// Therefore, we use nil to indicate no mapping here and an empty array to indicate error.
@@ -641,39 +641,32 @@
if (!error && !needsMapping)
return;
-__strong NSMutableArray **array = (__strong NSMutableArray **)context;
-if (!*array)
-*array = [[NSMutableArray alloc] init];
-
+if (!array)
+array = adoptNS([NSMutableArray new]);
+
if (!error)
-[*array addObject:[NSValue valueWithRange:range]];
+[array addObject:[NSValue valueWithRange:range]];
}
-static void collectRangesThatNeedEncoding(NSString *string, NSRange range, void *context)
+static void collectRangesThatNeedEncoding(NSString *string, NSRange range, RetainPtr& array)
{
-return collectRangesThatNeedMapping(string, range, context, YES);
+return collectRangesThatNeedMapping(string, range, array, YES);
}
-static void collectRangesThatNeedDecoding(NSString *string, NSRange range, void *context)
+static void collectRangesThatNeedDecoding(NSString *string, NSRange range, RetainPtr& array)
{
-return collectRangesThatNeedMapping(string, range, context, NO);
+return collectRangesThatNeedMapping(string, range, array, NO);
}
-static inline NSCharacterSet *retain(NSCharacterSet *charset)
+static void applyHostNameFunctionToMailToURLString(NSString *string, StringRangeApplierFunction f, RetainPtr& array)
{
-CFRetain(charset);
-return charset;
-}
-
-static void applyHostNameFunctionToMailToURLString(NSString *string, StringRangeApplierFunction f, void *context)
-{
// In a mailto: URL, host names come after a '@' character and end with a '>' or ',' or '?' character.
// Skip quoted strings so that characters in them don't confuse us.
// When we find a '?' character, we are past the part of the URL that contains host names.
-static NSCharacterSet
[webkit-changes] [236764] trunk/Tools
Title: [236764] trunk/Tools Revision 236764 Author cdu...@apple.com Date 2018-10-02 13:44:27 -0700 (Tue, 02 Oct 2018) Log Message REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing https://bugs.webkit.org/show_bug.cgi?id=190176 Reviewed by Alex Christensen. Use a URL that is truly recognized as invalid by WebCore's URL parser. * TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm: (TEST): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm Diff Modified: trunk/Tools/ChangeLog (236763 => 236764) --- trunk/Tools/ChangeLog 2018-10-02 20:26:15 UTC (rev 236763) +++ trunk/Tools/ChangeLog 2018-10-02 20:44:27 UTC (rev 236764) @@ -1,3 +1,16 @@ +2018-10-02 Chris Dumez + +REGRESSION: TestWebKitAPI.WKWebView.ProvisionalURLNotChange API test is failing +https://bugs.webkit.org/show_bug.cgi?id=190176 + + +Reviewed by Alex Christensen. + +Use a URL that is truly recognized as invalid by WebCore's URL parser. + +* TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm: +(TEST): + 2018-10-02 Alex Christensen Remove ParsedURLString Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm (236763 => 236764) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm 2018-10-02 20:26:15 UTC (rev 236763) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProvisionalURLNotChange.mm 2018-10-02 20:44:27 UTC (rev 236764) @@ -52,7 +52,8 @@ TestWebKitAPI::Util::run(); isDone = false; -[webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"http://www.webkit.org!"]]]; +NSURL *invalidURL = [NSURL URLWithString:@"https://a@/b"]; +[webView loadRequest:[NSURLRequest requestWithURL:invalidURL]]; TestWebKitAPI::Util::run(); isDone = false; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236763] trunk/Source
Title: [236763] trunk/Source
Revision 236763
Author achristen...@apple.com
Date 2018-10-02 13:26:15 -0700 (Tue, 02 Oct 2018)
Log Message
Remove unused linked-on-or-before-iOS5 check
https://bugs.webkit.org/show_bug.cgi?id=190164
Reviewed by Michael Saboff.
Source/WebCore:
If an app hasn't been updated since iOS5, it can't run supported iOS.
This value is also only checked in an uninstantiated template function.
* platform/URL.cpp:
(WebCore::enableURLSchemeCanonicalization): Deleted.
(WebCore::equal): Deleted.
* platform/URL.h:
Source/WebKitLegacy/ios:
* Misc/WebUIKitSupport.mm:
(WebKitInitialize):
(linkedOnOrAfterIOS5): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URL.cpp
trunk/Source/WebCore/platform/URL.h
trunk/Source/WebKitLegacy/ios/ChangeLog
trunk/Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (236762 => 236763)
--- trunk/Source/WebCore/ChangeLog 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebCore/ChangeLog 2018-10-02 20:26:15 UTC (rev 236763)
@@ -1,5 +1,20 @@
2018-10-02 Alex Christensen
+Remove unused linked-on-or-before-iOS5 check
+https://bugs.webkit.org/show_bug.cgi?id=190164
+
+Reviewed by Michael Saboff.
+
+If an app hasn't been updated since iOS5, it can't run supported iOS.
+This value is also only checked in an uninstantiated template function.
+
+* platform/URL.cpp:
+(WebCore::enableURLSchemeCanonicalization): Deleted.
+(WebCore::equal): Deleted.
+* platform/URL.h:
+
+2018-10-02 Alex Christensen
+
Remove ParsedURLString
https://bugs.webkit.org/show_bug.cgi?id=190154
Modified: trunk/Source/WebCore/platform/URL.cpp (236762 => 236763)
--- trunk/Source/WebCore/platform/URL.cpp 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebCore/platform/URL.cpp 2018-10-02 20:26:15 UTC (rev 236763)
@@ -664,42 +664,6 @@
*this = parser.result();
}
-#if PLATFORM(IOS)
-
-static bool shouldCanonicalizeScheme = true;
-
-void enableURLSchemeCanonicalization(bool enableSchemeCanonicalization)
-{
-shouldCanonicalizeScheme = enableSchemeCanonicalization;
-}
-
-#endif
-
-template
-static inline bool equal(const char* a, const char ()[length])
-{
-#if PLATFORM(IOS)
-if (!shouldCanonicalizeScheme) {
-for (size_t i = 0; i < length; ++i) {
-if (toASCIILower(a[i]) != b[i])
-return false;
-}
-return true;
-}
-#endif
-for (size_t i = 0; i < length; ++i) {
-if (a[i] != b[i])
-return false;
-}
-return true;
-}
-
-template
-static inline bool equal(const char* stringA, size_t lengthA, const char ()[lengthB])
-{
-return lengthA == lengthB && equal(stringA, stringB);
-}
-
bool equalIgnoringFragmentIdentifier(const URL& a, const URL& b)
{
if (a.m_queryEnd != b.m_queryEnd)
Modified: trunk/Source/WebCore/platform/URL.h (236762 => 236763)
--- trunk/Source/WebCore/platform/URL.h 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebCore/platform/URL.h 2018-10-02 20:26:15 UTC (rev 236763)
@@ -261,13 +261,6 @@
return URL(URL(), string);
}
-bool operator==(const URL&, const URL&);
-bool operator==(const URL&, const String&);
-bool operator==(const String&, const URL&);
-bool operator!=(const URL&, const URL&);
-bool operator!=(const URL&, const String&);
-bool operator!=(const String&, const URL&);
-
WEBCORE_EXPORT bool equalIgnoringFragmentIdentifier(const URL&, const URL&);
WEBCORE_EXPORT bool equalIgnoringQueryAndFragment(const URL&, const URL&);
WEBCORE_EXPORT bool protocolHostAndPortAreEqual(const URL&, const URL&);
@@ -299,10 +292,6 @@
// FIXME: This is a wrong concept to expose, different parts of a URL need different escaping per the URL Standard.
WEBCORE_EXPORT String encodeWithURLEscapeSequences(const String&);
-#if PLATFORM(IOS)
-WEBCORE_EXPORT void enableURLSchemeCanonicalization(bool);
-#endif
-
// Inlines.
inline bool operator==(const URL& a, const URL& b)
Modified: trunk/Source/WebKitLegacy/ios/ChangeLog (236762 => 236763)
--- trunk/Source/WebKitLegacy/ios/ChangeLog 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebKitLegacy/ios/ChangeLog 2018-10-02 20:26:15 UTC (rev 236763)
@@ -1,3 +1,14 @@
+2018-10-02 Alex Christensen
+
+Remove unused linked-on-or-before-iOS5 check
+https://bugs.webkit.org/show_bug.cgi?id=190164
+
+Reviewed by Michael Saboff.
+
+* Misc/WebUIKitSupport.mm:
+(WebKitInitialize):
+(linkedOnOrAfterIOS5): Deleted.
+
2018-09-17 Darin Adler
Use OpaqueJSString rather than JSRetainPtr inside WebKit
Modified: trunk/Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm (236762 => 236763)
--- trunk/Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm 2018-10-02 20:24:42 UTC (rev 236762)
+++ trunk/Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm 2018-10-02 20:26:15 UTC (rev 236763)
@@
[webkit-changes] [236762] trunk
Title: [236762] trunk Revision 236762 Author achristen...@apple.com Date 2018-10-02 13:24:42 -0700 (Tue, 02 Oct 2018) Log Message Remove ParsedURLString https://bugs.webkit.org/show_bug.cgi?id=190154 Reviewed by Chris Dumez. Source/WebCore: Before the introduction of URLParser, it would indicate that we should assume the String is from a valid URL so we can skip canonicalization and just find the offsets inside the String to quickly create a URL. It was a performance optimization that caused security issues when misused. Since the introduction of URLParser, we have a fast path for all URL parsing, so right now it actually doesn't change any behavior. It's just a relic of the past that complicates the URL class, making it harder to express which constructor to use and making it harder to move the class. * Modules/navigatorcontentutils/NavigatorContentUtils.cpp: (WebCore::NavigatorContentUtils::registerProtocolHandler): (WebCore::NavigatorContentUtils::isProtocolHandlerRegistered): (WebCore::NavigatorContentUtils::unregisterProtocolHandler): * dom/Document.cpp: (WebCore::Document::updateBaseURL): (WebCore::Document::initSecurityContext): * dom/ExtensionStyleSheets.cpp: (WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache const): * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): * editing/markup.cpp: (WebCore::completeURLs): * fileapi/BlobURL.cpp: (WebCore::BlobURL::createBlobURL): * history/HistoryItem.cpp: (WebCore::HistoryItem::url const): (WebCore::HistoryItem::originalURL const): * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::location const): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): * html/PublicURLManager.cpp: (WebCore::PublicURLManager::stop): * inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText const): * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::getCookies): (WebCore::InspectorPageAgent::deleteCookie): (WebCore::InspectorPageAgent::getResourceContent): (WebCore::InspectorPageAgent::searchInResource): * inspector/agents/page/PageDebuggerAgent.cpp: (WebCore::PageDebuggerAgent::sourceMapURLForScript): * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresources const): * loader/FrameLoader.cpp: (WebCore::FrameLoader::init): (WebCore::FrameLoader::initForSynthesizedDocument): * loader/HistoryController.cpp: (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState): * loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource): (WebCore::ApplicationCache::resourceForURL): * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::ApplicationCacheGroup::addEntry): * loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): (WebCore::ApplicationCacheStorage::loadCache): (WebCore::ApplicationCacheStorage::manifestURLs): * loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): * page/DOMWindow.cpp: (WebCore::DOMWindow::createWindow): * page/PageSerializer.cpp: (WebCore::PageSerializer::urlForBlankFrame): * platform/URL.cpp: (WebCore::blankURL): * platform/URL.h: (): Deleted. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::load): * platform/network/BlobRegistryImpl.cpp: (WebCore::BlobRegistryImpl::populateBlobsForFileWriting): * platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::decodeBase): * platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::sanitizeSuggestedFilename): * platform/network/cf/DNSResolveQueueCFNet.cpp: (WebCore::DNSResolveQueueCFNet::updateIsUsingProxy): * platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): * platform/network/curl/CookieJarDB.cpp: (WebCore::CookieJarDB::searchCookies): (WebCore::CookieJarDB::setCookie): (WebCore::CookieJarDB::deleteCookie): * platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): * platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): * xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc): Source/WebKit: * NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: (WebKit::NetworkBlobRegistry::writeBlobToFilePath): * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles): * PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::streamWillSendRequest): (WebKit::PluginControllerProxy::streamDidReceiveResponse): (WebKit::PluginControllerProxy::manualStreamDidReceiveResponse): * Shared/API/APIUserContentURLPattern.h: (API::UserContentURLPattern::matchesURL const): * Shared/WebBackForwardListItem.cpp: (WebKit::WebBackForwardListItem::itemIsInSameDocument const): *
[webkit-changes] [236761] trunk/Tools
Title: [236761] trunk/Tools
Revision 236761
Author dba...@webkit.org
Date 2018-10-02 12:42:25 -0700 (Tue, 02 Oct 2018)
Log Message
Fix iOS TestWebKitAPI failures following
(https://bugs.webkit.org/show_bug.cgi?id=190017)
For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
WKWebViewAutofillTests.AutofillRequiresInputSession
DragAndDropTests.ExternalSourceJPEGOnly
DragAndDropTests.ExternalSourceUTF8PlainTextOnly
so that the presence of a hardware keyboad does not effect their results. In
we will look to swizzle this method for all test by default.
* TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
(TestWebKitAPI::overrideIsInHardwareKeyboardMode):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
(TestWebKitAPI::overrideIsInHardwareKeyboardMode):
(TestWebKitAPI::TEST):
* TestWebKitAPI/ios/UIKitSPI.h:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm
trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm
trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h
Diff
Modified: trunk/Tools/ChangeLog (236760 => 236761)
--- trunk/Tools/ChangeLog 2018-10-02 19:20:18 UTC (rev 236760)
+++ trunk/Tools/ChangeLog 2018-10-02 19:42:25 UTC (rev 236761)
@@ -1,3 +1,24 @@
+2018-10-02 Daniel Bates
+
+Fix iOS TestWebKitAPI failures following
+(https://bugs.webkit.org/show_bug.cgi?id=190017)
+
+For now swizzle +[UIKeyboard isInHardwareKeyboardMode] to return NO in the following tests:
+WKWebViewAutofillTests.AutofillRequiresInputSession
+DragAndDropTests.ExternalSourceJPEGOnly
+DragAndDropTests.ExternalSourceUTF8PlainTextOnly
+
+so that the presence of a hardware keyboad does not effect their results. In
+we will look to swizzle this method for all test by default.
+
+* TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
+(TestWebKitAPI::overrideIsInHardwareKeyboardMode):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
+(TestWebKitAPI::overrideIsInHardwareKeyboardMode):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/ios/UIKitSPI.h:
+
2018-10-02 Dawei Fenton
Unreviewed, rolling out r236751.
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm (236760 => 236761)
--- trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm 2018-10-02 19:20:18 UTC (rev 236760)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm 2018-10-02 19:42:25 UTC (rev 236761)
@@ -27,6 +27,7 @@
#if ENABLE(DRAG_SUPPORT) && PLATFORM(IOS) && WK_API_ENABLED
+#import "ClassMethodSwizzler.h"
#import "DragAndDropSimulator.h"
#import "PlatformUtilities.h"
#import "TestWKWebView.h"
@@ -907,8 +908,15 @@
EXPECT_TRUE([webView editorContainsImageElement]);
}
+static BOOL overrideIsInHardwareKeyboardMode()
+{
+return NO;
+}
+
TEST(DragAndDropTests, ExternalSourceUTF8PlainTextOnly)
{
+ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast(overrideIsInHardwareKeyboardMode));
+
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[webView synchronouslyLoadTestPageNamed:@"autofocus-contenteditable"];
@@ -928,6 +936,8 @@
TEST(DragAndDropTests, ExternalSourceJPEGOnly)
{
+ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast(overrideIsInHardwareKeyboardMode));
+
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[webView synchronouslyLoadTestPageNamed:@"autofocus-contenteditable"];
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm (236760 => 236761)
--- trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm 2018-10-02 19:20:18 UTC (rev 236760)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm 2018-10-02 19:42:25 UTC (rev 236761)
@@ -27,6 +27,7 @@
#if WK_API_ENABLED && PLATFORM(IOS)
+#import "ClassMethodSwizzler.h"
#import "PlatformUtilities.h"
#import "TestInputDelegate.h"
#import "TestWKWebView.h"
@@ -164,8 +165,15 @@
EXPECT_FALSE([webView textInputHasAutofillContext]);
}
+static BOOL overrideIsInHardwareKeyboardMode()
+{
+return NO;
+}
+
TEST(WKWebViewAutofillTests, AutofillRequiresInputSession)
{
+ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast(overrideIsInHardwareKeyboardMode));
+
auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[(TestInputDelegate *)[webView _inputDelegate] setFocusStartsInputSessionPolicyHandler:[] (WKWebView *, id <_WKFocusedElementInfo>) -> _WKFocusStartsInputSessionPolicy {
return _WKFocusStartsInputSessionPolicyAuto;
Modified: trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h (236760 => 236761)
---
[webkit-changes] [236760] branches/safari-606.2.104.0-branch/Source
Title: [236760] branches/safari-606.2.104.0-branch/Source Revision 236760 Author kocsen_ch...@apple.com Date 2018-10-02 12:20:18 -0700 (Tue, 02 Oct 2018) Log Message Versioning. Modified Paths branches/safari-606.2.104.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-606.2.104.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-606.2.104.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-606.2.104.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-606.2.104.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-606.2.104.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-606.2.104.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-606.2.104.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (236759 => 236760) --- branches/safari-606.2.104.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) +++ branches/safari-606.2.104.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-10-02 19:20:18 UTC (rev 236760) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 104; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-606.2.104.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (236759 => 236760) --- branches/safari-606.2.104.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) +++ branches/safari-606.2.104.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-10-02 19:20:18 UTC (rev 236760) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 104; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-606.2.104.0-branch/Source/WebCore/Configurations/Version.xcconfig (236759 => 236760) --- branches/safari-606.2.104.0-branch/Source/WebCore/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) +++ branches/safari-606.2.104.0-branch/Source/WebCore/Configurations/Version.xcconfig 2018-10-02 19:20:18 UTC (rev 236760) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 104; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-606.2.104.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (236759 => 236760) --- branches/safari-606.2.104.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) +++ branches/safari-606.2.104.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-10-02 19:20:18 UTC (rev 236760) @@ -25,8 +25,8 @@ MINOR_VERSION = 2; TINY_VERSION = 104; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-606.2.104.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (236759 => 236760) --- branches/safari-606.2.104.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) +++ branches/safari-606.2.104.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-10-02 19:20:18 UTC (rev 236760) @@ -2,8 +2,8 @@ MINOR_VERSION = 2; TINY_VERSION = 104; MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified:
[webkit-changes] [236759] branches/safari-606.2.104.1-branch/Source
Title: [236759] branches/safari-606.2.104.1-branch/Source Revision 236759 Author kocsen_ch...@apple.com Date 2018-10-02 12:18:33 -0700 (Tue, 02 Oct 2018) Log Message Versioning. Modified Paths branches/safari-606.2.104.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-606.2.104.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-606.2.104.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-606.2.104.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-606.2.104.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-606.2.104.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-606.2.104.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-606.2.104.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (236758 => 236759) --- branches/safari-606.2.104.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-10-02 19:01:28 UTC (rev 236758) +++ branches/safari-606.2.104.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) @@ -24,9 +24,9 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; TINY_VERSION = 104; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-606.2.104.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (236758 => 236759) --- branches/safari-606.2.104.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-10-02 19:01:28 UTC (rev 236758) +++ branches/safari-606.2.104.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) @@ -24,9 +24,9 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; TINY_VERSION = 104; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-606.2.104.1-branch/Source/WebCore/Configurations/Version.xcconfig (236758 => 236759) --- branches/safari-606.2.104.1-branch/Source/WebCore/Configurations/Version.xcconfig 2018-10-02 19:01:28 UTC (rev 236758) +++ branches/safari-606.2.104.1-branch/Source/WebCore/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) @@ -24,9 +24,9 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; TINY_VERSION = 104; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-606.2.104.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (236758 => 236759) --- branches/safari-606.2.104.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-10-02 19:01:28 UTC (rev 236758) +++ branches/safari-606.2.104.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) @@ -24,9 +24,9 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; TINY_VERSION = 104; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-606.2.104.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (236758 => 236759) --- branches/safari-606.2.104.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-10-02 19:01:28 UTC (rev 236758) +++ branches/safari-606.2.104.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-10-02 19:18:33 UTC (rev 236759) @@ -1,9 +1,9 @@ MAJOR_VERSION = 606; MINOR_VERSION = 2; TINY_VERSION = 104; -MICRO_VERSION = 0; -NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +MICRO_VERSION = 1; +NANO_VERSION = 1; +FULL_VERSION =
[webkit-changes] [236758] trunk/Source/JavaScriptCore
Title: [236758] trunk/Source/_javascript_Core
Revision 236758
Author yusukesuz...@slowstart.org
Date 2018-10-02 12:01:28 -0700 (Tue, 02 Oct 2018)
Log Message
[JSC] Add stub of ExecutableAllocator used when JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=190215
Reviewed by Mark Lam.
When ENABLE(JIT) is disabled, we do not use JIT. But we ExecutableAllocator is still available since
it is guarded by ENABLE(ASSEMBLER). ENABLE(ASSEMBLER) is necessary for LLInt ASM interpreter since
our MacroAssembler tells machine architecture information. Eventually, we would like to decouple
this machine architecture information from MacroAssembler. But for now, we use ENABLE(ASSEMBLER)
for LLInt ASM interpreter even if JIT is disabled by ENABLE(JIT).
To ensure any executable memory allocation is not done, we add a stub of ExecutableAllocator for
non-JIT configurations. This does not have any functionality allocating executable memory, thus
any accidental operation cannot attempt to allocate executable memory if ENABLE(JIT) = OFF.
* jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::initializeAllocator):
(JSC::ExecutableAllocator::singleton):
* jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::isValid const):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutableAllocator::memoryPressureMultiplier):
(JSC::ExecutableAllocator::dumpProfile):
(JSC::ExecutableAllocator::allocate):
(JSC::ExecutableAllocator::isValidExecutableMemory):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::getLock const):
(JSC::performJITMemcpy):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp
trunk/Source/_javascript_Core/jit/ExecutableAllocator.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (236757 => 236758)
--- trunk/Source/_javascript_Core/ChangeLog 2018-10-02 18:43:27 UTC (rev 236757)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-10-02 19:01:28 UTC (rev 236758)
@@ -1,3 +1,34 @@
+2018-10-02 Yusuke Suzuki
+
+[JSC] Add stub of ExecutableAllocator used when JIT is disabled
+https://bugs.webkit.org/show_bug.cgi?id=190215
+
+Reviewed by Mark Lam.
+
+When ENABLE(JIT) is disabled, we do not use JIT. But we ExecutableAllocator is still available since
+it is guarded by ENABLE(ASSEMBLER). ENABLE(ASSEMBLER) is necessary for LLInt ASM interpreter since
+our MacroAssembler tells machine architecture information. Eventually, we would like to decouple
+this machine architecture information from MacroAssembler. But for now, we use ENABLE(ASSEMBLER)
+for LLInt ASM interpreter even if JIT is disabled by ENABLE(JIT).
+
+To ensure any executable memory allocation is not done, we add a stub of ExecutableAllocator for
+non-JIT configurations. This does not have any functionality allocating executable memory, thus
+any accidental operation cannot attempt to allocate executable memory if ENABLE(JIT) = OFF.
+
+* jit/ExecutableAllocator.cpp:
+(JSC::ExecutableAllocator::initializeAllocator):
+(JSC::ExecutableAllocator::singleton):
+* jit/ExecutableAllocator.h:
+(JSC::ExecutableAllocator::isValid const):
+(JSC::ExecutableAllocator::underMemoryPressure):
+(JSC::ExecutableAllocator::memoryPressureMultiplier):
+(JSC::ExecutableAllocator::dumpProfile):
+(JSC::ExecutableAllocator::allocate):
+(JSC::ExecutableAllocator::isValidExecutableMemory):
+(JSC::ExecutableAllocator::committedByteCount):
+(JSC::ExecutableAllocator::getLock const):
+(JSC::performJITMemcpy):
+
2018-10-01 Dean Jackson
Remove CSS Animation Triggers
Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp (236757 => 236758)
--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-10-02 18:43:27 UTC (rev 236757)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2018-10-02 19:01:28 UTC (rev 236758)
@@ -26,7 +26,7 @@
#include "config.h"
#include "ExecutableAllocator.h"
-#if ENABLE(ASSEMBLER)
+#if ENABLE(JIT)
#include "CodeProfiling.h"
#include "ExecutableAllocationFuzz.h"
@@ -497,4 +497,23 @@
}
-#endif // ENABLE(ASSEMBLER)
+#else // !ENABLE(JIT)
+
+namespace JSC {
+
+static ExecutableAllocator* executableAllocator;
+
+void ExecutableAllocator::initializeAllocator()
+{
+executableAllocator = new ExecutableAllocator;
+}
+
+ExecutableAllocator& ExecutableAllocator::singleton()
+{
+ASSERT(executableAllocator);
+return *executableAllocator;
+}
+
+} // namespace JSC
+
+#endif // ENABLE(JIT)
Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.h (236757 => 236758)
--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.h 2018-10-02 18:43:27 UTC (rev 236757)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.h 2018-10-02 19:01:28 UTC (rev 236758)
@@ -59,7 +59,7 @@
typedef
[webkit-changes] [236757] branches/safari-606.2.104.1-branch/
Title: [236757] branches/safari-606.2.104.1-branch/ Revision 236757 Author kocsen_ch...@apple.com Date 2018-10-02 11:43:27 -0700 (Tue, 02 Oct 2018) Log Message New branch. Added Paths branches/safari-606.2.104.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236756] branches/safari-606.2.104.0-branch/
Title: [236756] branches/safari-606.2.104.0-branch/ Revision 236756 Author kocsen_ch...@apple.com Date 2018-10-02 11:42:45 -0700 (Tue, 02 Oct 2018) Log Message New branch. Added Paths branches/safari-606.2.104.0-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236755] trunk/Tools
Title: [236755] trunk/Tools
Revision 236755
Author realda...@apple.com
Date 2018-10-02 11:39:08 -0700 (Tue, 02 Oct 2018)
Log Message
Unreviewed, rolling out r236751.
broke the iOS Build
Reverted changeset:
"Fix iOS TestWebKitAPI failures following
"
https://bugs.webkit.org/show_bug.cgi?id=190017
https://trac.webkit.org/changeset/236751
Patch by Dawei Fenton on 2018-10-02
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm
trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm
trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h
Diff
Modified: trunk/Tools/ChangeLog (236754 => 236755)
--- trunk/Tools/ChangeLog 2018-10-02 18:36:32 UTC (rev 236754)
+++ trunk/Tools/ChangeLog 2018-10-02 18:39:08 UTC (rev 236755)
@@ -1,3 +1,16 @@
+2018-10-02 Dawei Fenton
+
+Unreviewed, rolling out r236751.
+
+broke the iOS Build
+
+Reverted changeset:
+
+"Fix iOS TestWebKitAPI failures following
+"
+https://bugs.webkit.org/show_bug.cgi?id=190017
+https://trac.webkit.org/changeset/236751
+
2018-10-02 Daniel Bates
Fix iOS TestWebKitAPI failures following
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm (236754 => 236755)
--- trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm 2018-10-02 18:36:32 UTC (rev 236754)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm 2018-10-02 18:39:08 UTC (rev 236755)
@@ -27,7 +27,6 @@
#if ENABLE(DRAG_SUPPORT) && PLATFORM(IOS) && WK_API_ENABLED
-#import "ClassMethodSwizzler.h"
#import "DragAndDropSimulator.h"
#import "PlatformUtilities.h"
#import "TestWKWebView.h"
@@ -908,15 +907,8 @@
EXPECT_TRUE([webView editorContainsImageElement]);
}
-static BOOL overrideIsInHardwareKeyboardMode()
-{
-return NO;
-}
-
TEST(DragAndDropTests, ExternalSourceUTF8PlainTextOnly)
{
-ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast(overrideIsInHardwareKeyboardMode));
-
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[webView synchronouslyLoadTestPageNamed:@"autofocus-contenteditable"];
@@ -936,8 +928,6 @@
TEST(DragAndDropTests, ExternalSourceJPEGOnly)
{
-ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast(overrideIsInHardwareKeyboardMode));
-
auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[webView synchronouslyLoadTestPageNamed:@"autofocus-contenteditable"];
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm (236754 => 236755)
--- trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm 2018-10-02 18:36:32 UTC (rev 236754)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm 2018-10-02 18:39:08 UTC (rev 236755)
@@ -27,7 +27,6 @@
#if WK_API_ENABLED && PLATFORM(IOS)
-#import "ClassMethodSwizzler.h"
#import "PlatformUtilities.h"
#import "TestInputDelegate.h"
#import "TestWKWebView.h"
@@ -165,15 +164,8 @@
EXPECT_FALSE([webView textInputHasAutofillContext]);
}
-static BOOL overrideIsInHardwareKeyboardMode()
-{
-return NO;
-}
-
TEST(WKWebViewAutofillTests, AutofillRequiresInputSession)
{
-ClassMethodSwizzler swizzler([UIKeyboard class], @selector(isInHardwareKeyboardMode), reinterpret_cast(overrideIsInHardwareKeyboardMode));
-
auto webView = adoptNS([[AutofillTestView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)]);
[(TestInputDelegate *)[webView _inputDelegate] setFocusStartsInputSessionPolicyHandler:[] (WKWebView *, id <_WKFocusedElementInfo>) -> _WKFocusStartsInputSessionPolicy {
return _WKFocusStartsInputSessionPolicyAuto;
Modified: trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h (236754 => 236755)
--- trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h 2018-10-02 18:36:32 UTC (rev 236754)
+++ trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h 2018-10-02 18:39:08 UTC (rev 236755)
@@ -30,7 +30,6 @@
#if USE(APPLE_INTERNAL_SDK)
#import
-#import
#import
#import
#import
@@ -161,8 +160,4 @@
- (UIResponder *)firstResponder;
@end
-@interface UIKeyboard ()
-+ (BOOL)isInHardwareKeyboardMode;
-@end
-
#endif // PLATFORM(IOS)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [236754] trunk
Title: [236754] trunk
Revision 236754
Author pvol...@apple.com
Date 2018-10-02 11:36:32 -0700 (Tue, 02 Oct 2018)
Log Message
[WebVTT] Cue with line setting is not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=190168
Reviewed by Eric Carlson.
Source/WebCore:
When the line setting contains an optional alignment value, the cue is not rendered at the correct position,
see https://w3c.github.io/webvtt/#webvtt-line-cue-setting. This patch does not implement correct handling of
the line setting alignment values, it only makes sure parsing does not fail when the cue has line alignment
settings.
Test: media/track/track-cue-line-position.html
* html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
(WebCore::VTTCue::getPositionCoordinates const):
(WebCore::VTTCue::setCueSettings):
LayoutTests:
* media/track/captions-webvtt/line-position.vtt: Added.
* media/track/track-cue-line-position-expected-mismatch.html: Added.
* media/track/track-cue-line-position.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/VTTCue.cpp
Added Paths
trunk/LayoutTests/media/track/captions-webvtt/line-position.vtt
trunk/LayoutTests/media/track/track-cue-line-position-expected-mismatch.html
trunk/LayoutTests/media/track/track-cue-line-position.html
Diff
Modified: trunk/LayoutTests/ChangeLog (236753 => 236754)
--- trunk/LayoutTests/ChangeLog 2018-10-02 17:57:41 UTC (rev 236753)
+++ trunk/LayoutTests/ChangeLog 2018-10-02 18:36:32 UTC (rev 236754)
@@ -1,3 +1,14 @@
+2018-10-02 Per Arne Vollan
+
+[WebVTT] Cue with line setting is not rendered correctly
+https://bugs.webkit.org/show_bug.cgi?id=190168
+
+Reviewed by Eric Carlson.
+
+* media/track/captions-webvtt/line-position.vtt: Added.
+* media/track/track-cue-line-position-expected-mismatch.html: Added.
+* media/track/track-cue-line-position.html: Added.
+
2018-10-02 Carlos Eduardo Ramalho
[GTK] fast/forms/color/input-appearance-color.html is failing
Added: trunk/LayoutTests/media/track/captions-webvtt/line-position.vtt (0 => 236754)
--- trunk/LayoutTests/media/track/captions-webvtt/line-position.vtt (rev 0)
+++ trunk/LayoutTests/media/track/captions-webvtt/line-position.vtt 2018-10-02 18:36:32 UTC (rev 236754)
@@ -0,0 +1,5 @@
+WEBVTT
+
+1
+00:00.000 --> 01:00.000 line:10%,start
+Lorum ipsum
Added: trunk/LayoutTests/media/track/track-cue-line-position-expected-mismatch.html (0 => 236754)
--- trunk/LayoutTests/media/track/track-cue-line-position-expected-mismatch.html (rev 0)
+++ trunk/LayoutTests/media/track/track-cue-line-position-expected-mismatch.html 2018-10-02 18:36:32 UTC (rev 236754)
@@ -0,0 +1,40 @@
+
+
+
+var requirePixelDump = true;
+
+
+.obscurer {
+width: 500px;
+height: 500px;
+position: absolute;
+background-color: white;
+}
+
+