[webkit-changes] [237789] trunk
Title: [237789] trunk
Revision 237789
Author hironori.fu...@sony.com
Date 2018-11-04 20:38:32 -0800 (Sun, 04 Nov 2018)
Log Message
[Win] Use C++14, not C++17
https://bugs.webkit.org/show_bug.cgi?id=191101
Reviewed by Alex Christensen.
.:
Based on the webkit-dev discussion, this change switches Windows
port from C++17 to C++14.
* Source/cmake/OptionsMSVC.cmake: Replaced /std:c++17 with /std:c++14 switch.
Source/WTF:
* wtf/StdLibExtras.h: Use _MSVC_LANG to check C++ language version
instead of _MSC_FULL_VER.
Tools:
std::basic_string::data() returns a read-only const buffer in
C++14.
* MiniBrowser/win/WebKitBrowserWindow.cpp:
(createString): Use std::vector instead of std::wstring.
(createUTF8String): Use std::vector instead of std::string.
Modified Paths
trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StdLibExtras.h
trunk/Source/cmake/OptionsMSVC.cmake
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
Diff
Modified: trunk/ChangeLog (237788 => 237789)
--- trunk/ChangeLog 2018-11-05 04:29:02 UTC (rev 237788)
+++ trunk/ChangeLog 2018-11-05 04:38:32 UTC (rev 237789)
@@ -1,3 +1,16 @@
+2018-11-04 Fujii Hironori
+
+[Win] Use C++14, not C++17
+https://bugs.webkit.org/show_bug.cgi?id=191101
+
+Reviewed by Alex Christensen.
+
+Based on the webkit-dev discussion, this change switches Windows
+port from C++17 to C++14.
+
+
+* Source/cmake/OptionsMSVC.cmake: Replaced /std:c++17 with /std:c++14 switch.
+
2018-10-30 Don Olmstead
[PlayStation] Enable _javascript_Core
Modified: trunk/Source/WTF/ChangeLog (237788 => 237789)
--- trunk/Source/WTF/ChangeLog 2018-11-05 04:29:02 UTC (rev 237788)
+++ trunk/Source/WTF/ChangeLog 2018-11-05 04:38:32 UTC (rev 237789)
@@ -1,3 +1,13 @@
+2018-11-04 Fujii Hironori
+
+[Win] Use C++14, not C++17
+https://bugs.webkit.org/show_bug.cgi?id=191101
+
+Reviewed by Alex Christensen.
+
+* wtf/StdLibExtras.h: Use _MSVC_LANG to check C++ language version
+instead of _MSC_FULL_VER.
+
2018-11-02 Justin Fan
[WebGPU] Experimental prototype for MSL shaders
Modified: trunk/Source/WTF/wtf/StdLibExtras.h (237788 => 237789)
--- trunk/Source/WTF/wtf/StdLibExtras.h 2018-11-05 04:29:02 UTC (rev 237788)
+++ trunk/Source/WTF/wtf/StdLibExtras.h 2018-11-05 04:38:32 UTC (rev 237789)
@@ -527,7 +527,7 @@
// Provide in_place_t when not building with -std=c++17, or when building with libstdc++ 6
// (which doesn't define the _GLIBCXX_RELEASE macro that's been introduced in libstdc++ 7).
-#if (__cplusplus < 201703L || (defined(__GLIBCXX__) && !defined(_GLIBCXX_RELEASE))) && (!defined(_MSC_FULL_VER) || _MSC_FULL_VER < 190023918)
+#if (__cplusplus < 201703L || (defined(__GLIBCXX__) && !defined(_GLIBCXX_RELEASE))) && (!defined(_MSVC_LANG) || _MSVC_LANG < 201703L)
// These are inline variable for C++17 and later.
#define __IN_PLACE_INLINE_VARIABLE static const
Modified: trunk/Source/cmake/OptionsMSVC.cmake (237788 => 237789)
--- trunk/Source/cmake/OptionsMSVC.cmake 2018-11-05 04:29:02 UTC (rev 237788)
+++ trunk/Source/cmake/OptionsMSVC.cmake 2018-11-05 04:38:32 UTC (rev 237789)
@@ -26,9 +26,9 @@
add_definitions(-D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1)
endif ()
-# Enable C++17
+# Enable C++14
# https://docs.microsoft.com/en-us/cpp/build/reference/std-specify-language-standard-version
-add_compile_options(/std:c++17)
+add_compile_options(/std:c++14)
# Specify the source code encoding
add_compile_options(/utf-8 /validate-charset)
Modified: trunk/Tools/ChangeLog (237788 => 237789)
--- trunk/Tools/ChangeLog 2018-11-05 04:29:02 UTC (rev 237788)
+++ trunk/Tools/ChangeLog 2018-11-05 04:38:32 UTC (rev 237789)
@@ -1,3 +1,17 @@
+2018-11-04 Fujii Hironori
+
+[Win] Use C++14, not C++17
+https://bugs.webkit.org/show_bug.cgi?id=191101
+
+Reviewed by Alex Christensen.
+
+std::basic_string::data() returns a read-only const buffer in
+C++14.
+
+* MiniBrowser/win/WebKitBrowserWindow.cpp:
+(createString): Use std::vector instead of std::wstring.
+(createUTF8String): Use std::vector instead of std::string.
+
2018-11-04 Wenson Hsieh
[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
Modified: trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp (237788 => 237789)
--- trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2018-11-05 04:29:02 UTC (rev 237788)
+++ trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp 2018-11-05 04:38:32 UTC (rev 237789)
@@ -37,11 +37,10 @@
std::wstring createString(WKStringRef wkString)
{
size_t maxSize = WKStringGetLength(wkString);
-std::wstring str(maxSize, '\0');
-size_t actualLength = WKStringGetCharacters(wkString, str.data(), maxSize);
-if (maxSize != actualLength)
-str.resize(actualLength);
-return
[webkit-changes] [237788] trunk/Source/WebKit
Title: [237788] trunk/Source/WebKit
Revision 237788
Author hironori.fu...@sony.com
Date 2018-11-04 20:29:02 -0800 (Sun, 04 Nov 2018)
Log Message
[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
Unreviewed build fix of ports not ENABLE(MEDIA_STREAM).
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Define getRequestAction only if ENABLE(MEDIA_STREAM).
* UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (237787 => 237788)
--- trunk/Source/WebKit/ChangeLog 2018-11-05 02:15:48 UTC (rev 237787)
+++ trunk/Source/WebKit/ChangeLog 2018-11-05 04:29:02 UTC (rev 237788)
@@ -1,3 +1,14 @@
+2018-11-04 Fujii Hironori
+
+[MediaStream] User should not be prompted again after denying getDisplayMedia request
+https://bugs.webkit.org/show_bug.cgi?id=191227
+
+
+Unreviewed build fix of ports not ENABLE(MEDIA_STREAM).
+
+* UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Define getRequestAction only if ENABLE(MEDIA_STREAM).
+* UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto.
+
2018-11-04 Zalan Bujtas
[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (237787 => 237788)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2018-11-05 02:15:48 UTC (rev 237787)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2018-11-05 04:29:02 UTC (rev 237788)
@@ -261,6 +261,7 @@
m_rejectionTimer.startOneShot(Seconds(mimimumDelayBeforeReplying + randomNumber()));
}
+#if ENABLE(MEDIA_STREAM)
UserMediaPermissionRequestManagerProxy::RequestAction UserMediaPermissionRequestManagerProxy::getRequestAction(uint64_t frameID, SecurityOrigin& userMediaDocumentOrigin, SecurityOrigin& topLevelDocumentOrigin, const MediaStreamRequest& userRequest, Vector& audioDevices, Vector& videoDevices)
{
if (videoDevices.isEmpty() && audioDevices.isEmpty())
@@ -280,6 +281,7 @@
return searchForGrantedRequest(frameID, userMediaDocumentOrigin, topLevelDocumentOrigin, requestingMicrophone, requestingCamera) ? RequestAction::Grant : RequestAction::Prompt;
}
+#endif
void UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame(uint64_t userMediaID, uint64_t frameID, Ref&& userMediaDocumentOrigin, Ref&& topLevelDocumentOrigin, const MediaStreamRequest& userRequest)
{
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h (237787 => 237788)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h 2018-11-05 02:15:48 UTC (rev 237787)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h 2018-11-05 04:29:02 UTC (rev 237788)
@@ -74,7 +74,7 @@
const UserMediaPermissionRequestProxy* searchForGrantedRequest(uint64_t frameID, const WebCore::SecurityOrigin& userMediaDocumentOrigin, const WebCore::SecurityOrigin& topLevelDocumentOrigin, bool needsAudio, bool needsVideo) const;
bool wasRequestDenied(uint64_t mainFrameID, const WebCore::SecurityOrigin& userMediaDocumentOrigin, const WebCore::SecurityOrigin& topLevelDocumentOrigin, bool needsAudio, bool needsVideo, bool needsScreenCapture);
-#endif
+
void getUserMediaPermissionInfo(uint64_t userMediaID, uint64_t frameID, UserMediaPermissionCheckProxy::CompletionHandler&&, Ref&& userMediaDocumentOrigin, Ref&& topLevelDocumentOrigin);
enum class RequestAction {
@@ -83,6 +83,7 @@
Prompt
};
RequestAction getRequestAction(uint64_t frameID, WebCore::SecurityOrigin& userMediaDocumentOrigin, WebCore::SecurityOrigin& topLevelDocumentOrigin, const WebCore::MediaStreamRequest&, Vector& audioDevices, Vector& videoDevices);
+#endif
void watchdogTimerFired();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237787] trunk/Source/WebCore
Title: [237787] trunk/Source/WebCore
Revision 237787
Author commit-qu...@webkit.org
Date 2018-11-04 18:15:48 -0800 (Sun, 04 Nov 2018)
Log Message
Remove ENABLE_OPENCL fully
https://bugs.webkit.org/show_bug.cgi?id=191172
Patch by Rob Buis on 2018-11-04
Reviewed by Yusuke Suzuki.
Forgot to simplify this, no need for applyAll anymore
since it just calls apply.
No new tests since no change in functionality.
* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::applyAll): Deleted.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FilterEffect.h
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (237786 => 237787)
--- trunk/Source/WebCore/ChangeLog 2018-11-04 21:19:44 UTC (rev 237786)
+++ trunk/Source/WebCore/ChangeLog 2018-11-05 02:15:48 UTC (rev 237787)
@@ -1,3 +1,20 @@
+2018-11-04 Rob Buis
+
+Remove ENABLE_OPENCL fully
+https://bugs.webkit.org/show_bug.cgi?id=191172
+
+Reviewed by Yusuke Suzuki.
+
+Forgot to simplify this, no need for applyAll anymore
+since it just calls apply.
+
+No new tests since no change in functionality.
+
+* platform/graphics/filters/FilterEffect.h:
+(WebCore::FilterEffect::applyAll): Deleted.
+* rendering/svg/RenderSVGResourceFilter.cpp:
+(WebCore::RenderSVGResourceFilter::postApplyResource):
+
2018-11-04 Zalan Bujtas
[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
Modified: trunk/Source/WebCore/platform/graphics/filters/FilterEffect.h (237786 => 237787)
--- trunk/Source/WebCore/platform/graphics/filters/FilterEffect.h 2018-11-04 21:19:44 UTC (rev 237786)
+++ trunk/Source/WebCore/platform/graphics/filters/FilterEffect.h 2018-11-05 02:15:48 UTC (rev 237787)
@@ -93,7 +93,6 @@
void setMaxEffectRect(const FloatRect& maxEffectRect) { m_maxEffectRect = maxEffectRect; }
void apply();
-inline void applyAll() { apply(); }
// Correct any invalid pixels, if necessary, in the result of a filter operation.
// This method is used to ensure valid pixel values on filter inputs and the final result.
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp (237786 => 237787)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp 2018-11-04 21:19:44 UTC (rev 237786)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp 2018-11-05 02:15:48 UTC (rev 237787)
@@ -268,7 +268,7 @@
// Always true if filterData is just built (filterData->state == FilterData::Built).
if (!lastEffect->hasResult()) {
filterData.state = FilterData::Applying;
-lastEffect->applyAll();
+lastEffect->apply();
lastEffect->correctFilterResultIfNeeded();
lastEffect->transformResultColorSpace(ColorSpaceSRGB);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237786] trunk/Tools
Title: [237786] trunk/Tools Revision 237786 Author wenson_hs...@apple.com Date 2018-11-04 13:19:44 -0800 (Sun, 04 Nov 2018) Log Message [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm https://bugs.webkit.org/show_bug.cgi?id=191231 Reviewed by Simon Fraser. Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so it can be shared between iOS-family and macOS platforms. See below for more details. No change in behavior. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::overridePreference): Add a method stub for DumpRenderTree. * TestRunnerShared/UIScriptContext/UIScriptController.cpp: * WebKitTestRunner/UIScriptControllerCocoa.mm: (WTR::UIScriptController::doAsyncTask): (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Unify these method implementations. (WTR::UIScriptController::removeViewFromWindow): (WTR::UIScriptController::addViewToWindow): Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this. (WTR::UIScriptController::overridePreference): (WTR::UIScriptController::findString): (WTR::UIScriptController::contentsOfUserInterfaceItem const): Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::doAsyncTask): Deleted. (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted. (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted. (WTR::UIScriptController::findString): Deleted. (WTR::UIScriptController::removeViewFromWindow): Deleted. (WTR::UIScriptController::addViewToWindow): Deleted. * WebKitTestRunner/mac/UIScriptControllerMac.mm: (WTR::UIScriptController::doAsyncTask): Deleted. (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted. (WTR::UIScriptController::overridePreference): Deleted. (WTR::UIScriptController::findString): Deleted. (WTR::UIScriptController::removeViewFromWindow): Deleted. (WTR::UIScriptController::addViewToWindow): Deleted. (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/ios/UIScriptControllerIOS.mm trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp trunk/Tools/WebKitTestRunner/UIScriptControllerCocoa.mm trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm trunk/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm Diff Modified: trunk/Tools/ChangeLog (237785 => 237786) --- trunk/Tools/ChangeLog 2018-11-04 16:38:36 UTC (rev 237785) +++ trunk/Tools/ChangeLog 2018-11-04 21:19:44 UTC (rev 237786) @@ -1,3 +1,57 @@ +2018-11-04 Wenson Hsieh + +[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm +https://bugs.webkit.org/show_bug.cgi?id=191231 + +Reviewed by Simon Fraser. + +Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so +it can be shared between iOS-family and macOS platforms. See below for more details. + +No change in behavior. + +* DumpRenderTree/ios/UIScriptControllerIOS.mm: +(WTR::UIScriptController::overridePreference): + +Add a method stub for DumpRenderTree. + +* TestRunnerShared/UIScriptContext/UIScriptController.cpp: +* WebKitTestRunner/UIScriptControllerCocoa.mm: +(WTR::UIScriptController::doAsyncTask): +(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): + +Unify these method implementations. + +(WTR::UIScriptController::removeViewFromWindow): +(WTR::UIScriptController::addViewToWindow): + +Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view +to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion +block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to +begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this. + +(WTR::UIScriptController::overridePreference): +(WTR::UIScriptController::findString): +(WTR::UIScriptController::contentsOfUserInterfaceItem const): + +Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS
[webkit-changes] [237785] trunk/Source
Title: [237785] trunk/Source Revision 237785 Author za...@apple.com Date 2018-11-04 08:38:36 -0800 (Sun, 04 Nov 2018) Log Message [iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired. https://bugs.webkit.org/show_bug.cgi?id=191078 Reviewed by Antti Koivisto. Source/WebCore: 1. Improve visuallyNonEmpty milestone confidence level. Ignore whitespace and non visible text content. Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading. Check if the html/body is actually visible. 2. Issue initial paint soon after the milestone fires. Use a 0ms timer to flush the initial paint. Throttle additional flushes for 500ms (remove the non-initial 1.5 throttling) 3. Suspend optional style recalcs and layouts while painting is being throttled. When parsing yields we initiate a 0ms style recalc/layout timer. These optional layouts produce content that we have no intention to paint. * dom/Document.cpp: (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::shouldScheduleLayout): * page/ChromeClient.h: * page/FrameView.cpp: (WebCore::FrameView::resetLayoutMilestones): (WebCore::FrameView::qualifiesAsVisuallyNonEmpty const): (WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded): (WebCore::FrameView::updateIsVisuallyNonEmpty): * page/FrameView.h: (WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content. * platform/graphics/FontCascade.h: * rendering/RenderText.cpp: Check whether the text is actually visible at this point. (WebCore::RenderText::RenderText): Source/WebKit: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::layerFlushThrottlingIsActive const): * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebPage/AcceleratedDrawingArea.cpp: (WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint): * WebProcess/WebPage/AcceleratedDrawingArea.h: * WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::layerFlushThrottlingIsActive const): * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea): (WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen): (WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint): (WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint): (WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush): * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/page/ChromeClient.h trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h trunk/Source/WebCore/platform/graphics/FontCascade.h trunk/Source/WebCore/rendering/RenderText.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h trunk/Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.cpp trunk/Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.h trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.h trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm Diff Modified: trunk/Source/WebCore/ChangeLog (237784 => 237785) --- trunk/Source/WebCore/ChangeLog 2018-11-04 16:04:19 UTC (rev 237784) +++ trunk/Source/WebCore/ChangeLog 2018-11-04 16:38:36 UTC (rev 237785) @@ -1,5 +1,41 @@ 2018-11-04 Zalan Bujtas +[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired. +https://bugs.webkit.org/show_bug.cgi?id=191078 + + +Reviewed by Antti Koivisto. + +1. Improve visuallyNonEmpty milestone confidence level. +Ignore whitespace and non visible text content. +Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading. +Check if the html/body is actually visible. + +2. Issue initial paint soon after the milestone fires. +Use a 0ms timer to flush the initial paint. +Throttle additional flushes for 500ms (remove the non-initial 1.5 throttling) + +3. Suspend optional style recalcs and layouts while painting is being throttled. + When parsing yields we initiate a 0ms style recalc/layout timer. + These optional layouts produce content that we have no intention to
[webkit-changes] [237784] trunk
Title: [237784] trunk
Revision 237784
Author eric.carl...@apple.com
Date 2018-11-04 08:04:19 -0800 (Sun, 04 Nov 2018)
Log Message
[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
Reviewed by Youenn Fablet.
Source/WebKit:
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
* UIProcess/UserMediaPermissionRequestManagerProxy.h:
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (237783 => 237784)
--- trunk/Source/WebKit/ChangeLog 2018-11-04 15:46:38 UTC (rev 237783)
+++ trunk/Source/WebKit/ChangeLog 2018-11-04 16:04:19 UTC (rev 237784)
@@ -1,3 +1,17 @@
+2018-11-04 Eric Carlson
+
+[MediaStream] User should not be prompted again after denying getDisplayMedia request
+https://bugs.webkit.org/show_bug.cgi?id=191227
+
+
+Reviewed by Youenn Fablet.
+
+* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
+(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
+(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
+* UIProcess/UserMediaPermissionRequestManagerProxy.h:
+
2018-11-03 Alex Christensen
Mac production builds should sign the network process xpc service with entitlements
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (237783 => 237784)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2018-11-04 15:46:38 UTC (rev 237783)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2018-11-04 16:04:19 UTC (rev 237784)
@@ -133,7 +133,7 @@
return;
if (reason == UserMediaPermissionRequestProxy::UserMediaAccessDenialReason::PermissionDenied)
-m_deniedRequests.append(DeniedRequest { request->mainFrameID(), request->userMediaDocumentSecurityOrigin(), request->topLevelDocumentSecurityOrigin(), request->requiresAudioCapture(), request->requiresVideoCapture() });
+m_deniedRequests.append(DeniedRequest { request->mainFrameID(), request->userMediaDocumentSecurityOrigin(), request->topLevelDocumentSecurityOrigin(), request->requiresAudioCapture(), request->requiresVideoCapture(), request->requiresDisplayCapture() });
denyRequest(userMediaID, reason, emptyString());
}
@@ -213,7 +213,7 @@
return nullptr;
}
-bool UserMediaPermissionRequestManagerProxy::wasRequestDenied(uint64_t mainFrameID, const SecurityOrigin& userMediaDocumentOrigin, const SecurityOrigin& topLevelDocumentOrigin, bool needsAudio, bool needsVideo)
+bool UserMediaPermissionRequestManagerProxy::wasRequestDenied(uint64_t mainFrameID, const SecurityOrigin& userMediaDocumentOrigin, const SecurityOrigin& topLevelDocumentOrigin, bool needsAudio, bool needsVideo, bool needsScreenCapture)
{
for (const auto& deniedRequest : m_deniedRequests) {
if (!deniedRequest.userMediaDocumentOrigin->isSameSchemeHostPort(userMediaDocumentOrigin))
@@ -226,6 +226,8 @@
return true;
if (deniedRequest.isVideoDenied && needsVideo)
return true;
+if (deniedRequest.isScreenCaptureDenied && needsScreenCapture)
+return true;
}
return false;
}
@@ -259,6 +261,26 @@
m_rejectionTimer.startOneShot(Seconds(mimimumDelayBeforeReplying + randomNumber()));
}
+UserMediaPermissionRequestManagerProxy::RequestAction UserMediaPermissionRequestManagerProxy::getRequestAction(uint64_t frameID, SecurityOrigin& userMediaDocumentOrigin, SecurityOrigin& topLevelDocumentOrigin, const MediaStreamRequest& userRequest, Vector& audioDevices, Vector& videoDevices)
+{
+if (videoDevices.isEmpty() && audioDevices.isEmpty())
+return RequestAction::Deny;
+
+bool requestingScreenCapture = userRequest.type == MediaStreamRequest::Type::DisplayMedia;
+ASSERT(!(requestingScreenCapture && videoDevices.isEmpty()));
+ASSERT(!(requestingScreenCapture && !audioDevices.isEmpty()));
+bool requestingCamera = !requestingScreenCapture && !videoDevices.isEmpty();
+bool requestingMicrophone = !audioDevices.isEmpty();
+
+if
[webkit-changes] [237783] trunk
Title: [237783] trunk
Revision 237783
Author za...@apple.com
Date 2018-11-04 07:46:38 -0800 (Sun, 04 Nov 2018)
Log Message
[LFC][BFC] Add support for percentage height in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=191232
Reviewed by Antti Koivisto.
Source/WebCore:
In quirks mode, we go and travers the containing block chain to find a block level
box with fixed height value to resolve the percentage value.
Test: fast/block/basic/quirk-mode-percent-height.html
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
* layout/Verification.cpp:
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):
Tools:
* LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
* fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
* fast/block/basic/quirk-mode-percent-height.html: Added.
* platform/ios/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContextGeometry.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
Added Paths
trunk/LayoutTests/fast/block/basic/quirk-mode-percent-height-expected.txt
trunk/LayoutTests/fast/block/basic/quirk-mode-percent-height.html
Diff
Modified: trunk/LayoutTests/ChangeLog (237782 => 237783)
--- trunk/LayoutTests/ChangeLog 2018-11-04 15:44:57 UTC (rev 237782)
+++ trunk/LayoutTests/ChangeLog 2018-11-04 15:46:38 UTC (rev 237783)
@@ -1,5 +1,16 @@
2018-11-04 Zalan Bujtas
+[LFC][BFC] Add support for percentage height in quirks mode.
+https://bugs.webkit.org/show_bug.cgi?id=191232
+
+Reviewed by Antti Koivisto.
+
+* fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
+* fast/block/basic/quirk-mode-percent-height.html: Added.
+* platform/ios/TestExpectations:
+
+2018-11-04 Zalan Bujtas
+
[LFC][BCF] Add support for block level non-replaced inflow height percentage
https://bugs.webkit.org/show_bug.cgi?id=191229
Added: trunk/LayoutTests/fast/block/basic/quirk-mode-percent-height-expected.txt (0 => 237783)
--- trunk/LayoutTests/fast/block/basic/quirk-mode-percent-height-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/block/basic/quirk-mode-percent-height-expected.txt 2018-11-04 15:46:38 UTC (rev 237783)
@@ -0,0 +1,24 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+layer at (8,8) size 202x296 clip at (9,9) size 200x294 scrollWidth 300
+ RenderBlock {DIV} at (0,0) size 202x296 [border: (1px solid #008000)]
+RenderBlock {DIV} at (1,1) size 300x294
+ RenderBlock {DIV} at (0,0) size 202x294 [border: (1px solid #FF)]
+RenderText {#text} at (1,1) size 182x72
+ text run at (1,1) width 175: "This nested div has percent"
+ text run at (1,19) width 177: "height value and the closest"
+ text run at (1,37) width 182: "block level containing block"
+ text run at (1,55) width 97: "box is the ICB."
+layer at (8,304) size 202x202 clip at (9,305) size 200x200 scrollWidth 300
+ RenderBlock {DIV} at (0,296) size 202x202 [border: (1px solid #008000)]
+RenderBlock {DIV} at (1,1) size 300x102
+ RenderBlock {DIV} at (0,0) size 202x102 [border: (1px solid #FF)]
+RenderText {#text} at (1,1) size 182x90
+ text run at (1,1) width 175: "This nested div has percent"
+ text run at (1,19) width 177: "height value and the closest"
+ text run at (1,37) width 182: "block level containing block"
+ text run at (1,55) width 168: "box is 2 containing blocks"
+ text run at (1,73) width 37: "away."
Added: trunk/LayoutTests/fast/block/basic/quirk-mode-percent-height.html (0 => 237783)
--- trunk/LayoutTests/fast/block/basic/quirk-mode-percent-height.html (rev 0)
+++ trunk/LayoutTests/fast/block/basic/quirk-mode-percent-height.html 2018-11-04 15:46:38 UTC (rev 237783)
@@ -0,0 +1,23 @@
+
+.top {
+ border: 1px solid green;
+ width: 200px;
+ overflow: hidden;
+}
+
+.main {
+ width: 300px;
+}
+
+.nested {
+ border: 1px solid red;
+ display: block;
+ height: 50%;
+ width: 200px;
+}
+
+
+
+This nested div has percent height value and the closest block level containing block box is the ICB.
+
+This nested div has percent height value and the closest block level containing block box is 2 containing blocks away.
Modified: trunk/LayoutTests/platform/ios/TestExpectations (237782 => 237783)
--- trunk/LayoutTests/platform/ios/TestExpectations 2018-11-04 15:44:57 UTC (rev 237782)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2018-11-04 15:46:38 UTC (rev 237783)
@@ -3117,6 +3117,7 @@
fast/inline/simple-shrink-to-fit-inline-block.html [ Failure ]
[webkit-changes] [237782] trunk
Title: [237782] trunk
Revision 237782
Author za...@apple.com
Date 2018-11-04 07:44:57 -0800 (Sun, 04 Nov 2018)
Log Message
[LFC][BCF] Add support for block level non-replaced inflow height percentage
https://bugs.webkit.org/show_bug.cgi?id=191229
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/block/basic/child-block-level-box-with-height-percent.html
* layout/FormattingContext.h:
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
(WebCore::Layout::computedHeightValue): Deleted.
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
Tools:
* LayoutReloaded/misc/LFC-passing-tests.txt:
LayoutTests:
* fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
* fast/block/basic/child-block-level-box-with-height-percent.html: Added.
* platform/ios/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/FormattingContextGeometry.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt
Added Paths
trunk/LayoutTests/fast/block/basic/child-block-level-box-with-height-percent-expected.txt
trunk/LayoutTests/fast/block/basic/child-block-level-box-with-height-percent.html
Diff
Modified: trunk/LayoutTests/ChangeLog (237781 => 237782)
--- trunk/LayoutTests/ChangeLog 2018-11-04 15:30:31 UTC (rev 237781)
+++ trunk/LayoutTests/ChangeLog 2018-11-04 15:44:57 UTC (rev 237782)
@@ -1,3 +1,14 @@
+2018-11-04 Zalan Bujtas
+
+[LFC][BCF] Add support for block level non-replaced inflow height percentage
+https://bugs.webkit.org/show_bug.cgi?id=191229
+
+Reviewed by Antti Koivisto.
+
+* fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
+* fast/block/basic/child-block-level-box-with-height-percent.html: Added.
+* platform/ios/TestExpectations:
+
2018-11-03 Devin Rousso
Web Inspector: Canvas: capture changes to that would affect the recorded context
Added: trunk/LayoutTests/fast/block/basic/child-block-level-box-with-height-percent-expected.txt (0 => 237782)
--- trunk/LayoutTests/fast/block/basic/child-block-level-box-with-height-percent-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/block/basic/child-block-level-box-with-height-percent-expected.txt 2018-11-04 15:44:57 UTC (rev 237782)
@@ -0,0 +1,16 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 300x300
+RenderBlock (anonymous) at (0,0) size 300x18
+ RenderText {#text} at (0,0) size 132x18
+text run at (0,0) width 132: "block level box with"
+RenderBlock {DIV} at (0,18) size 152x152 [border: (1px solid #FF)]
+ RenderText {#text} at (1,1) size 40x18
+text run at (1,1) width 40: "height"
+RenderBlock (anonymous) at (0,170) size 300x36
+ RenderText {#text} at (0,0) size 259x36
+text run at (0,0) width 259: "percent when containing block has fixed"
+text run at (0,18) width 44: "height."
Added: trunk/LayoutTests/fast/block/basic/child-block-level-box-with-height-percent.html (0 => 237782)
--- trunk/LayoutTests/fast/block/basic/child-block-level-box-with-height-percent.html (rev 0)
+++ trunk/LayoutTests/fast/block/basic/child-block-level-box-with-height-percent.html 2018-11-04 15:44:57 UTC (rev 237782)
@@ -0,0 +1,16 @@
+
+#main {
+ width: 300px;
+ height: 300px;
+}
+
+#nested {
+ border: 1px solid red;
+ display: block;
+ height: 50%;
+ width: 50%;
+}
+
+
+
+block level box withheight percent when containing block has fixed height.
Modified: trunk/LayoutTests/platform/ios/TestExpectations (237781 => 237782)
--- trunk/LayoutTests/platform/ios/TestExpectations 2018-11-04 15:30:31 UTC (rev 237781)
+++ trunk/LayoutTests/platform/ios/TestExpectations 2018-11-04 15:44:57 UTC (rev 237782)
@@ -3116,6 +3116,7 @@
fast/inline/simple-inline-block.html [ Failure ]
fast/inline/simple-shrink-to-fit-inline-block.html [ Failure ]
fast/block/basic/height-percentage-simple.html [ Failure ]
+fast/block/basic/child-block-level-box-with-height-percent.html [ Failure ]
# Datalist
webkit.org/b/186714 fast/forms/datalist/datalist-textinput-keydown.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (237781 => 237782)
--- trunk/Source/WebCore/ChangeLog 2018-11-04 15:30:31 UTC (rev 237781)
+++ trunk/Source/WebCore/ChangeLog 2018-11-04 15:44:57 UTC (rev 237782)
@@ -1,3 +1,19 @@
+2018-11-04 Zalan Bujtas
+
+
[webkit-changes] [237781] trunk/Source/WebCore
Title: [237781] trunk/Source/WebCore
Revision 237781
Author you...@apple.com
Date 2018-11-04 07:30:31 -0800 (Sun, 04 Nov 2018)
Log Message
RealtimeOutgoingAudioSource should use DestructionThread::Main
https://bugs.webkit.org/show_bug.cgi?id=191230
Reviewed by Eric Carlson.
Covered by imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html
that should no longer crash in debug.
* platform/mediastream/RealtimeOutgoingAudioSource.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (237780 => 237781)
--- trunk/Source/WebCore/ChangeLog 2018-11-04 15:05:43 UTC (rev 237780)
+++ trunk/Source/WebCore/ChangeLog 2018-11-04 15:30:31 UTC (rev 237781)
@@ -1,5 +1,17 @@
2018-11-04 Youenn Fablet
+RealtimeOutgoingAudioSource should use DestructionThread::Main
+https://bugs.webkit.org/show_bug.cgi?id=191230
+
+Reviewed by Eric Carlson.
+
+Covered by imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html
+that should no longer crash in debug.
+
+* platform/mediastream/RealtimeOutgoingAudioSource.h:
+
+2018-11-04 Youenn Fablet
+
IDB should allow storing RTCCertificate
https://bugs.webkit.org/show_bug.cgi?id=191077
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h (237780 => 237781)
--- trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h 2018-11-04 15:05:43 UTC (rev 237780)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h 2018-11-04 15:30:31 UTC (rev 237781)
@@ -50,7 +50,7 @@
namespace WebCore {
-class RealtimeOutgoingAudioSource : public ThreadSafeRefCounted, public webrtc::AudioSourceInterface, private MediaStreamTrackPrivate::Observer {
+class RealtimeOutgoingAudioSource : public ThreadSafeRefCounted, public webrtc::AudioSourceInterface, private MediaStreamTrackPrivate::Observer {
public:
static Ref create(Ref&& audioSource);
@@ -77,10 +77,9 @@
void AddRef() const final { ref(); }
rtc::RefCountReleaseStatus Release() const final
{
-callOnMainThread([this] {
-deref();
-});
-return rtc::RefCountReleaseStatus::kOtherRefsRemained;
+auto result = refCount() - 1;
+deref();
+return result ? rtc::RefCountReleaseStatus::kOtherRefsRemained : rtc::RefCountReleaseStatus::kDroppedLastRef;
}
SourceState state() const final { return kLive; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237780] releases/WebKitGTK/webkit-2.22/Source/JavaScriptCore
Title: [237780] releases/WebKitGTK/webkit-2.22/Source/_javascript_Core Revision 237780 Author ape...@igalia.com Date 2018-11-04 07:05:43 -0800 (Sun, 04 Nov 2018) Log Message [GTK] Cannot make debug builds of JSC using release 2.22.3 https://bugs.webkit.org/show_bug.cgi?id=191233 Unreviewed build fix. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetByVal): Use context.asStructureForInContext() instead of explicit cast and remove the unneeded assertion, which is already done in the helper function. Modified Paths releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp Diff Modified: releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog (237779 => 237780) --- releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog 2018-11-04 10:28:11 UTC (rev 237779) +++ releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/ChangeLog 2018-11-04 15:05:43 UTC (rev 237780) @@ -1,3 +1,16 @@ +2018-11-04 Adrian Perez de Castro + +[GTK] Cannot make debug builds of JSC using release 2.22.3 +https://bugs.webkit.org/show_bug.cgi?id=191233 + +Unreviewed build fix. + +* bytecompiler/BytecodeGenerator.cpp: +(JSC::BytecodeGenerator::emitGetByVal): +Use context.asStructureForInContext() instead of explicit cast and +remove the unneeded assertion, which is already done in the helper +function. + 2018-10-26 Mark Lam Fix missing edge cases with JSGlobalObjects having a bad time. Modified: releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (237779 => 237780) --- releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2018-11-04 10:28:11 UTC (rev 237779) +++ releases/WebKitGTK/webkit-2.22/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2018-11-04 15:05:43 UTC (rev 237780) @@ -2920,8 +2920,7 @@ break; } -ASSERT(context.type() == ForInContext::StructureForInContextType); -StructureForInContext& structureContext = static_cast(context); +StructureForInContext& structureContext = context.asStructureForInContext(); UnlinkedValueProfile profile = "" instructions().append(kill(dst)); instructions().append(base->index()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237779] trunk
Title: [237779] trunk Revision 237779 Author you...@apple.com Date 2018-11-04 02:28:11 -0800 (Sun, 04 Nov 2018) Log Message IDB should allow storing RTCCertificate https://bugs.webkit.org/show_bug.cgi?id=191077 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/webrtc/RTCCertificate-postMessage.html: Added. * web-platform-tests/webrtc/resources/RTCCertificate-postMessage-iframe.html: Added. Source/WebCore: Add support for serialization/deserialization of RTCCertificate. Store the origin in RTCCertificate and make sure that a certificate with a different origin cannot be used to create a RTCPeerConnection. Test: imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html * Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::generateCertificate): * Modules/mediastream/RTCCertificate.cpp: (WebCore::RTCCertificate::create): (WebCore::RTCCertificate::RTCCertificate): * Modules/mediastream/RTCCertificate.h: (WebCore::RTCCertificate::origin const): * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::certificatesFromConfiguration): * Modules/mediastream/RTCPeerConnection.h: * Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp: (WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::RTCCertificateGeneratorCallback): (WebCore::LibWebRTCCertificateGenerator::generateCertificate): * Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.h: * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::CachedString::takeString): (WebCore::CloneDeserializer::readRTCCertificate): (WebCore::CloneDeserializer::readTerminal): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp trunk/Source/WebCore/Modules/mediastream/RTCCertificate.cpp trunk/Source/WebCore/Modules/mediastream/RTCCertificate.h trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.h trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/resources/ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/resources/RTCCertificate-postMessage-iframe.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (237778 => 237779) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-04 07:55:02 UTC (rev 237778) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-04 10:28:11 UTC (rev 237779) @@ -1,5 +1,15 @@ 2018-11-04 Youenn Fablet +IDB should allow storing RTCCertificate +https://bugs.webkit.org/show_bug.cgi?id=191077 + +Reviewed by Chris Dumez. + +* web-platform-tests/webrtc/RTCCertificate-postMessage.html: Added. +* web-platform-tests/webrtc/resources/RTCCertificate-postMessage-iframe.html: Added. + +2018-11-04 Youenn Fablet + Add support for RTCMuxPolicy https://bugs.webkit.org/show_bug.cgi?id=191188 Added: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html (0 => 237779) --- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html 2018-11-04 10:28:11 UTC (rev 237779) @@ -0,0 +1,77 @@ + + +RTCCertificate persistent Tests + +