[webkit-changes] [238081] trunk/Tools
Title: [238081] trunk/Tools
Revision 238081
Author hironori.fu...@sony.com
Date 2018-11-11 18:00:59 -0800 (Sun, 11 Nov 2018)
Log Message
run-bindings-tests is timing out in some WinCairo bots
https://bugs.webkit.org/show_bug.cgi?id=191348
Reviewed by Alex Christensen.
BuildBot kills run-bindings-tests if it outputs nothing for 20
minutes. run-bindings-tests runs very slowly in WinCairo Docker,
and it takes more than 30 minutes to finish. And, Windows Python
buffers the progress output.
* Scripts/webkitpy/bindings/main.py:
(BindingsTests.detect_changes): Call sys.stdout.flush() after the
test case result is output.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/bindings/main.py
Diff
Modified: trunk/Tools/ChangeLog (238080 => 238081)
--- trunk/Tools/ChangeLog 2018-11-12 01:39:27 UTC (rev 238080)
+++ trunk/Tools/ChangeLog 2018-11-12 02:00:59 UTC (rev 238081)
@@ -1,3 +1,19 @@
+2018-11-11 Fujii Hironori
+
+run-bindings-tests is timing out in some WinCairo bots
+https://bugs.webkit.org/show_bug.cgi?id=191348
+
+Reviewed by Alex Christensen.
+
+BuildBot kills run-bindings-tests if it outputs nothing for 20
+minutes. run-bindings-tests runs very slowly in WinCairo Docker,
+and it takes more than 30 minutes to finish. And, Windows Python
+buffers the progress output.
+
+* Scripts/webkitpy/bindings/main.py:
+(BindingsTests.detect_changes): Call sys.stdout.flush() after the
+test case result is output.
+
2018-11-11 Wenson Hsieh
Implement a new edit command to change the enclosing list type
Modified: trunk/Tools/Scripts/webkitpy/bindings/main.py (238080 => 238081)
--- trunk/Tools/Scripts/webkitpy/bindings/main.py 2018-11-12 01:39:27 UTC (rev 238080)
+++ trunk/Tools/Scripts/webkitpy/bindings/main.py 2018-11-12 02:00:59 UTC (rev 238081)
@@ -127,6 +127,7 @@
self.failures.append("(%s) %s" % (generator, output_file))
elif self.verbose:
print('PASS: (%s) %s' % (generator, output_file))
+sys.stdout.flush()
return changes_found
def test_matches_patterns(self, test):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238080] trunk
Title: [238080] trunk Revision 238080 Author wenson_hs...@apple.com Date 2018-11-11 17:39:27 -0800 (Sun, 11 Nov 2018) Log Message Implement a new edit command to change the enclosing list type https://bugs.webkit.org/show_bug.cgi?id=191487 Reviewed by Ryosuke Niwa. Source/WebCore: Add support for a new edit command that changes the type of the enclosing list element around the selection from unordered to ordered list and vice versa. This new edit command is exposed only to internal WebKit2 clients, via SPI on WKWebView (`-_changeListType:`). This is currently intended for use in Mail compose, but may also be adopted by legacy Notes in the future. As such, the behavior of this editing command mostly matches shipping behavior in Mail compose (which is currently implemented entirely by Mail). See below for more details. Test: editing/execCommand/change-list-type.html WKWebViewEditActions.ChangeListType * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * editing/ChangeListTypeCommand.cpp: Added. (WebCore::listConversionTypeForSelection): (WebCore::ChangeListTypeCommand::listConversionType): Helper that returns a potential list conversion command that may be executed at the given document's selection, if any exists. We also use existing logic from Mail here to determine which list to change, by walking up the DOM from the lowest common ancestor container of the current selection until we hit the first list element. (WebCore::ChangeListTypeCommand::createNewList): Helper method to create a new list element to replace the given list, and then clone element data from the given list to the new list. This addresses an existing bug in Mail, wherein changing list type for an enclosing list which contains inline style properties drops the inline styles, because existing logic in Mail that implements this editing command only copies the `class` attribute of the old list to the new list. (WebCore::ChangeListTypeCommand::doApply): Apply the edit command by running the following steps: - Find the enclosing list element, if any (see above). - Create a new list element of the opposite type as the enclosing list, and clone over element data from the list element being replaced. - Insert the new list next to the original list. - Move all children of the original list to the new list. - Remove the original list. - Set the selection to the end of the new list. * editing/ChangeListTypeCommand.h: Added. * editing/EditAction.h: Add a pair of new edit actions for conversion from unordered list to ordered list and vice versa. * editing/Editor.cpp: (WebCore::Editor::changeSelectionListType): Implement this by creating and applying a new ChangeListTypeCommand. (WebCore::Editor::canChangeSelectionListType): Deleted. Remove this for now, since there's no need for it until full support for edit command validation is implemented. * editing/Editor.h: * testing/Internals.cpp: (WebCore::Internals::changeSelectionListType): * testing/Internals.h: * testing/Internals.idl: Add internal hooks to change list type from layout tests. Source/WebKit: * UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::nameForEditAction): Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::increaseListLevel): (WebKit::WebPage::decreaseListLevel): (WebKit::WebPage::changeListType): Remove preflight checks for these list editing commands. These are not necessary because these commands fall back to being noops if these checks return false. This avoids an extraneous ancestor walk to determine the enclosing list element when changing list type. Source/WebKitLegacy/mac: Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList. * WebCoreSupport/WebEditorClient.mm: (undoNameForEditAction): Tools: Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing command in WebCore. See the new layout test for a test that exercises more nuanced corner cases. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: (-[TestWKWebView setPosition:offset:]): (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]): (TestWebKitAPI::webViewForEditActionTestingWithPageNamed): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added. LayoutTests: Add a new layout test to verify that the list change type editing command can be used to swap between enclosing ordered and unordered lists. Also exercises undo, redo, changing list types under `pre` and `table` elements, and handling selection within nested list elements. * editing/execCommand/change-list-type-expected.txt: Added. * editing/execCommand/change-list-type.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt
[webkit-changes] [238078] trunk
Title: [238078] trunk Revision 238078 Author dba...@webkit.org Date 2018-11-11 13:32:53 -0800 (Sun, 11 Nov 2018) Log Message [iOS] Draw caps lock indicator in password fields https://bugs.webkit.org/show_bug.cgi?id=190565 Source/WebCore: Reviewed by Dean Jackson. Draw the caps lock indicator in a focused password field on iOS. This makes the behavior of password fields on iOS more closely match the behavior of password fields on Mac. The majority of this patch is implementing PlatformKeyboardEvent::currentCapsLockState() for iOS. In Legacy WebKit, the implementation boils down to calling call -[::WebEvent modifierFlags]. In Modern WebKit the UIProcess is responsible for -[::WebEvent modifierFlags] and passing it the WebProcess to store such that invocations of PlatformKeyboardEvent::currentCapsLockState() consult the store in the WebProcess. A smaller part of this patch is having both the legacy and modern web views listen for keyboard availability changes so as to update the the caps lock state when a hardware keyboard is detached or attached. * WebCore.xcodeproj/project.pbxproj: * page/EventHandler.cpp: (WebCore::EventHandler::capsLockStateMayHaveChanged const): Extracted from EventHandler::internalKeyEvent() so that it can shared between WebCore, Modern WebKit, and Legacy WebKit code. (WebCore::EventHandler::internalKeyEvent): Modified to call capsLockStateMayHaveChanged(). * page/EventHandler.h: * platform/cocoa/KeyEventCocoa.mm: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Moved from KeyEventMac.mm. (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Moved from KeyEventMac.mm. * platform/ios/KeyEventIOS.mm: (WebCore::PlatformKeyboardEvent::currentStateOfModifierKeys): Fetch the current modifier state. (WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; we now use the Cocoa implementation. (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; we now use the Cocoa implementation. * platform/ios/WebEvent.h: * platform/ios/WebEvent.mm: (+[WebEvent modifierFlags]): Added. * platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Deleted; moved to KeyEventCocoa.mm to be shared by both Mac and iOS. (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Deleted; moved to KeyEventCocoa.mm to be shared by both Mac and iOS. * rendering/RenderThemeCocoa.h: * rendering/RenderThemeCocoa.mm: (WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const): Moved from RenderThemeMac.mm. * rendering/RenderThemeIOS.h: * rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::shouldHaveCapsLockIndicator const): Deleted. * rendering/RenderThemeMac.h: * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldHaveCapsLockIndicator const): Deleted; moved to RenderThemeCocoa.mm to be shared by both Mac and iOS. Source/WebCore/PAL: Reviewed by Dean Jackson. Forward declare some more SPI. * pal/spi/ios/GraphicsServicesSPI.h: * pal/spi/ios/UIKitSPI.h: Source/WebKit: Reviewed by Dean Jackson. Notify the WebContent process with the current modifer state on window activation changes. Notify the WebContent process when hardware keyboard availability changes (e.g. a keyboard is attached). * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): Register for hardware keyboard availability changed notifications. (-[WKWebView dealloc]): Unregister from hardware availability changed notifications. (hardwareKeyboardAvailabilityChangedCallback): Added. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::updateCurrentModifierState): Compile this code when building for iOS. * UIProcess/WebPageProxy.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _handleKeyUIEvent:]): Update the current modifier state if this event is a hardware keyboard flags changed event. * UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::hardwareKeyboardAvailabilityChanged): Added. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::hardwareKeyboardAvailabilityChanged): Added new message HardwareKeyboardAvailabilityChanged. Notify the focused HTML input element (if we have one) that the caps lock state may have changed when we receive message HardwareKeyboardAvailabilityChanged so that we toggle visibility of the caps lock indicator. Source/WebKitLegacy/mac: Reviewed by Dean Jackson. Update the caps lock state when a hardware keyboard is attached or detached. * WebView/WebHTMLView.mm: (hardwareKeyboardAvailabilityChangedCallback): Added. (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications. (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications. WebKitLibraries: Reviewed by Dean Jackson. Expose some more symbols. * WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd: LayoutTests: Unreviewed. Update expected
[webkit-changes] [238077] trunk/Source/WebCore
Title: [238077] trunk/Source/WebCore
Revision 238077
Author za...@apple.com
Date 2018-11-11 13:29:12 -0800 (Sun, 11 Nov 2018)
Log Message
[LFC][BFC] In-flow positioned logic is really formatting context dependent.
https://bugs.webkit.org/show_bug.cgi?id=191512
Reviewed by Simon Fraser.
Move block formatting context specific code from FormattingContext to BlockFormattingContext.
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const): Deleted.
* layout/FormattingContext.h:
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset):
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const): Deleted.
* layout/blockformatting/BlockFormattingContext.h:
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition): Deleted.
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const): Deleted.
* layout/inlineformatting/InlineFormattingContext.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/FormattingContextGeometry.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (238076 => 238077)
--- trunk/Source/WebCore/ChangeLog 2018-11-11 20:00:01 UTC (rev 238076)
+++ trunk/Source/WebCore/ChangeLog 2018-11-11 21:29:12 UTC (rev 238077)
@@ -1,3 +1,27 @@
+2018-11-11 Zalan Bujtas
+
+[LFC][BFC] In-flow positioned logic is really formatting context dependent.
+https://bugs.webkit.org/show_bug.cgi?id=191512
+
+Reviewed by Simon Fraser.
+
+Move block formatting context specific code from FormattingContext to BlockFormattingContext.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const): Deleted.
+* layout/FormattingContext.h:
+* layout/FormattingContextGeometry.cpp:
+(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset):
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren const):
+(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const): Deleted.
+* layout/blockformatting/BlockFormattingContext.h:
+* layout/blockformatting/BlockFormattingContextGeometry.cpp:
+(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition): Deleted.
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const): Deleted.
+* layout/inlineformatting/InlineFormattingContext.h:
+
2018-11-11 Myles C. Maxfield
Address post-review comments after r237955
Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (238076 => 238077)
--- trunk/Source/WebCore/layout/FormattingContext.cpp 2018-11-11 20:00:01 UTC (rev 238076)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp 2018-11-11 21:29:12 UTC (rev 238077)
@@ -130,21 +130,6 @@
displayBox.setPadding(Geometry::computedPadding(layoutState, layoutBox));
}
-void FormattingContext::placeInFlowPositionedChildren(const Container& container) const
-{
-// If this container also establishes a formatting context, then positioning already has happend in that the formatting context.
-if (container.establishesFormattingContext() && != ())
-return;
-
-LOG_WITH_STREAM(FormattingContextLayout, stream << "Start: move in-flow positioned children -> parent: " << );
-for (auto& layoutBox : childrenOfType(container)) {
-if (!layoutBox.isInFlowPositioned())
-continue;
-computeInFlowPositionedPosition(layoutBox);
-}
-LOG_WITH_STREAM(FormattingContextLayout, stream << "End: move in-flow positioned children -> parent: " << );
-}
-
void FormattingContext::layoutOutOfFlowDescendants(const Box& layoutBox) const
{
// Initial containing block by definition is a containing block.
Modified: trunk/Source/WebCore/layout/FormattingContext.h (238076 => 238077)
--- trunk/Source/WebCore/layout/FormattingContext.h 2018-11-11 20:00:01 UTC (rev 238076)
+++ trunk/Source/WebCore/layout/FormattingContext.h 2018-11-11 21:29:12 UTC
[webkit-changes] [238076] trunk
Title: [238076] trunk
Revision 238076
Author m...@apple.com
Date 2018-11-11 12:00:01 -0800 (Sun, 11 Nov 2018)
Log Message
ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
https://bugs.webkit.org/show_bug.cgi?id=191514
Reviewed by Geoffrey Garen.
Source/WebKit:
Test: WebKitCocoa/WKProcessPoolConfiguration.mm
* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy): Copy m_customWebContentServiceBundleIdentifier.
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
(TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238075 => 238076)
--- trunk/Source/WebKit/ChangeLog 2018-11-11 17:13:40 UTC (rev 238075)
+++ trunk/Source/WebKit/ChangeLog 2018-11-11 20:00:01 UTC (rev 238076)
@@ -1,3 +1,15 @@
+2018-11-11 Dan Bernstein
+
+ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=191514
+
+Reviewed by Geoffrey Garen.
+
+Test: WebKitCocoa/WKProcessPoolConfiguration.mm
+
+* UIProcess/API/APIProcessPoolConfiguration.cpp:
+(API::ProcessPoolConfiguration::copy): Copy m_customWebContentServiceBundleIdentifier.
+
2018-11-11 Benjamin Poulain
Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
Modified: trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp (238075 => 238076)
--- trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp 2018-11-11 17:13:40 UTC (rev 238075)
+++ trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp 2018-11-11 20:00:01 UTC (rev 238076)
@@ -130,6 +130,7 @@
#if PLATFORM(COCOA)
copy->m_suppressesConnectionTerminationOnSystemChange = this->m_suppressesConnectionTerminationOnSystemChange;
#endif
+copy->m_customWebContentServiceBundleIdentifier = this->m_customWebContentServiceBundleIdentifier;
return copy;
}
Modified: trunk/Tools/ChangeLog (238075 => 238076)
--- trunk/Tools/ChangeLog 2018-11-11 17:13:40 UTC (rev 238075)
+++ trunk/Tools/ChangeLog 2018-11-11 20:00:01 UTC (rev 238076)
@@ -1,3 +1,14 @@
+2018-11-11 Dan Bernstein
+
+ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=191514
+
+Reviewed by Geoffrey Garen.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
+(TEST):
+
2018-11-11 Benjamin Poulain
Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (238075 => 238076)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2018-11-11 17:13:40 UTC (rev 238075)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2018-11-11 20:00:01 UTC (rev 238076)
@@ -141,6 +141,7 @@
375E0E171D66674400EFEC2C /* WKNSNumber.mm in Sources */ = {isa = PBXBuildFile; fileRef = 375E0E151D66674400EFEC2C /* WKNSNumber.mm */; };
3760C4F1211249AF00233ACC /* AttrStyle.mm in Sources */ = {isa = PBXBuildFile; fileRef = 3760C4F0211249AF00233ACC /* AttrStyle.mm */; };
376C8C061D6E197C007D2BB9 /* FrameHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 376C8C041D6E197C007D2BB9 /* FrameHandle.cpp */; };
+ 3781746D2198AE4600062C26 /* WKProcessPoolConfiguration.mm in Sources */ = {isa = PBXBuildFile; fileRef = 3781746C2198AE2400062C26 /* WKProcessPoolConfiguration.mm */; };
378E64771632655E00B6C676 /* InjectedBundleFrameHitTest_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 378E64751632655D00B6C676 /* InjectedBundleFrameHitTest_Bundle.cpp */; };
378E64791632707400B6C676 /* link-with-title.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 378E647816326FDF00B6C676 /* link-with-title.html */; };
379028B914FAC24C007E6B43 /* acceptsFirstMouse.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 379028B814FABE49007E6B43 /* acceptsFirstMouse.html */; };
@@ -1424,6 +1425,7 @@
3760C4F221124BD000233ACC /* AttrStyle.html */ = {isa = PBXFileReference; lastKnownFileType = text.html; path = AttrStyle.html; sourceTree = ""; };
376C8C041D6E197C007D2BB9 /* FrameHandle.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = FrameHandle.cpp; sourceTree = ""; };
3776BC62150946BC0043A66D /* DeviceScaleFactorInDashboardRegions.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DeviceScaleFactorInDashboardRegions.mm;
[webkit-changes] [238075] trunk
Title: [238075] trunk
Revision 238075
Author mmaxfi...@apple.com
Date 2018-11-11 09:13:40 -0800 (Sun, 11 Nov 2018)
Log Message
Address post-review comments after r237955
https://bugs.webkit.org/show_bug.cgi?id=191496
Reviewed by Darin Adler.
Source/WebCore:
* rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintTextDecoration):
* style/InlineTextBoxStyle.cpp:
(WebCore::computeUnderlineOffset):
* style/InlineTextBoxStyle.h:
LayoutTests:
* fast/css3-text/css3-text-decoration/text-underline-negative-expected.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-negative-expected.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/TextDecorationPainter.cpp
trunk/Source/WebCore/style/InlineTextBoxStyle.cpp
trunk/Source/WebCore/style/InlineTextBoxStyle.h
Diff
Modified: trunk/LayoutTests/ChangeLog (238074 => 238075)
--- trunk/LayoutTests/ChangeLog 2018-11-11 08:27:32 UTC (rev 238074)
+++ trunk/LayoutTests/ChangeLog 2018-11-11 17:13:40 UTC (rev 238075)
@@ -1,3 +1,12 @@
+2018-11-11 Myles C. Maxfield
+
+Address post-review comments after r237955
+https://bugs.webkit.org/show_bug.cgi?id=191496
+
+Reviewed by Darin Adler.
+
+* fast/css3-text/css3-text-decoration/text-underline-negative-expected.html:
+
2018-11-10 Simon Fraser
Remove support for -webkit-svg-shadow
Modified: trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-negative-expected.html (238074 => 238075)
--- trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-negative-expected.html 2018-11-11 08:27:32 UTC (rev 238074)
+++ trunk/LayoutTests/fast/css3-text/css3-text-decoration/text-underline-negative-expected.html 2018-11-11 17:13:40 UTC (rev 238075)
@@ -4,6 +4,6 @@
This test makes sure you can't place an underline to make it look like a line-through. The test passes if all the underlines are in the correct place.
-
+
Modified: trunk/Source/WebCore/ChangeLog (238074 => 238075)
--- trunk/Source/WebCore/ChangeLog 2018-11-11 08:27:32 UTC (rev 238074)
+++ trunk/Source/WebCore/ChangeLog 2018-11-11 17:13:40 UTC (rev 238075)
@@ -1,3 +1,16 @@
+2018-11-11 Myles C. Maxfield
+
+Address post-review comments after r237955
+https://bugs.webkit.org/show_bug.cgi?id=191496
+
+Reviewed by Darin Adler.
+
+* rendering/TextDecorationPainter.cpp:
+(WebCore::TextDecorationPainter::paintTextDecoration):
+* style/InlineTextBoxStyle.cpp:
+(WebCore::computeUnderlineOffset):
+* style/InlineTextBoxStyle.h:
+
2018-11-11 Benjamin Poulain
Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
Modified: trunk/Source/WebCore/rendering/TextDecorationPainter.cpp (238074 => 238075)
--- trunk/Source/WebCore/rendering/TextDecorationPainter.cpp 2018-11-11 08:27:32 UTC (rev 238074)
+++ trunk/Source/WebCore/rendering/TextDecorationPainter.cpp 2018-11-11 17:13:40 UTC (rev 238075)
@@ -287,7 +287,7 @@
if (m_decorations.contains(TextDecoration::Underline)) {
float textDecorationBaseFontSize = 16;
auto defaultGap = m_lineStyle.computedFontSize() / textDecorationBaseFontSize;
-int offset = computeUnderlineOffset(m_lineStyle.textUnderlinePosition(), m_lineStyle.textUnderlineOffset(), m_lineStyle.fontMetrics(), m_inlineTextBox, defaultGap);
+float offset = computeUnderlineOffset(m_lineStyle.textUnderlinePosition(), m_lineStyle.textUnderlineOffset(), m_lineStyle.fontMetrics(), m_inlineTextBox, defaultGap);
float wavyOffset = m_styles.underlineStyle == TextDecorationStyle::Wavy ? m_wavyOffset : 0;
FloatRect rect(localOrigin, FloatSize(m_width, textDecorationThickness));
rect.move(0, offset + wavyOffset);
Modified: trunk/Source/WebCore/style/InlineTextBoxStyle.cpp (238074 => 238075)
--- trunk/Source/WebCore/style/InlineTextBoxStyle.cpp 2018-11-11 08:27:32 UTC (rev 238074)
+++ trunk/Source/WebCore/style/InlineTextBoxStyle.cpp 2018-11-11 17:13:40 UTC (rev 238075)
@@ -32,10 +32,10 @@
namespace WebCore {
-int computeUnderlineOffset(TextUnderlinePosition underlinePosition, TextUnderlineOffset underlineOffset, const FontMetrics& fontMetrics, const InlineTextBox* inlineTextBox, int defaultGap)
+float computeUnderlineOffset(TextUnderlinePosition underlinePosition, TextUnderlineOffset underlineOffset, const FontMetrics& fontMetrics, const InlineTextBox* inlineTextBox, float defaultGap)
{
// This represents the gap between the baseline and the closest edge of the underline.
-int gap = std::max(1, ceilf(defaultGap / 2.0));
+float gap = std::max(1, std::ceil(defaultGap / 2.0f));
// FIXME: The code for visual overflow detection passes in a null inline text box. This means it is now
// broken for the case where auto needs to behave like "under".
@@ -78,9 +78,8 @@
[webkit-changes] [238074] trunk
Title: [238074] trunk
Revision 238074
Author benja...@webkit.org
Date 2018-11-11 00:27:32 -0800 (Sun, 11 Nov 2018)
Log Message
Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
https://bugs.webkit.org/show_bug.cgi?id=191492
Reviewed by Alex Christensen.
Source/_javascript_Core:
Rename file.
* API/JSValue.mm:
Source/WebCore:
Rename file.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
* page/mac/EventHandlerMac.mm:
* platform/mac/URLMac.mm:
* platform/mac/WebCoreNSURLExtras.mm:
* platform/mac/WebCoreObjCExtras.mm:
* rendering/RenderThemeMac.mm:
Source/WebKit:
* Platform/mac/StringUtilities.mm:
* UIProcess/ApplicationStateTracker.mm:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
Source/WebKitLegacy/mac:
* Carbon/HIWebView.mm:
* Misc/WebNSFileManagerExtras.mm:
* Misc/WebNSURLExtras.mm:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
* Plugins/WebBasePluginPackage.mm:
* Plugins/WebPluginContainerCheck.mm:
* WebCoreSupport/WebCachedFramePlatformData.h:
* WebCoreSupport/WebDeviceOrientationClient.mm:
* WebView/WebDelegateImplementationCaching.mm:
* WebView/WebHTMLView.mm:
* WebView/WebPDFRepresentation.mm:
* WebView/WebPolicyDelegate.mm:
* WebView/WebView.mm:
Tools:
Update file name.
* DumpRenderTree/mac/DumpRenderTree.mm:
* WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
* WebKitTestRunner/mac/TestControllerMac.mm:
Modified Paths
trunk/Source/_javascript_Core/API/JSValue.mm
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Source/WebCore/page/mac/EventHandlerMac.mm
trunk/Source/WebCore/platform/mac/URLMac.mm
trunk/Source/WebCore/platform/mac/WebCoreNSURLExtras.mm
trunk/Source/WebCore/platform/mac/WebCoreObjCExtras.mm
trunk/Source/WebCore/rendering/RenderThemeMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/mac/StringUtilities.mm
trunk/Source/WebKit/UIProcess/ApplicationStateTracker.mm
trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm
trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm
trunk/Source/WebKitLegacy/mac/Carbon/HIWebView.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Misc/WebNSFileManagerExtras.mm
trunk/Source/WebKitLegacy/mac/Misc/WebNSURLExtras.mm
trunk/Source/WebKitLegacy/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm
trunk/Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.mm
trunk/Source/WebKitLegacy/mac/Plugins/WebPluginContainerCheck.mm
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebCachedFramePlatformData.h
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebDeviceOrientationClient.mm
trunk/Source/WebKitLegacy/mac/WebView/WebDelegateImplementationCaching.mm
trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPDFRepresentation.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPolicyDelegate.mm
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm
trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm
Added Paths
trunk/Source/WTF/wtf/ObjCRuntimeExtras.h
Removed Paths
trunk/Source/WTF/wtf/WTFObjCRuntimeExtras.h
Diff
Modified: trunk/Source/_javascript_Core/API/JSValue.mm (238073 => 238074)
--- trunk/Source/_javascript_Core/API/JSValue.mm 2018-11-11 06:16:22 UTC (rev 238073)
+++ trunk/Source/_javascript_Core/API/JSValue.mm 2018-11-11 08:27:32 UTC (rev 238074)
@@ -45,7 +45,7 @@
#import
#import
#import
-#import
+#import
#import
#import
#import
Modified: trunk/Source/_javascript_Core/ChangeLog (238073 => 238074)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-11 06:16:22 UTC (rev 238073)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-11 08:27:32 UTC (rev 238074)
@@ -1,3 +1,14 @@
+2018-11-11 Benjamin Poulain
+
+Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
+https://bugs.webkit.org/show_bug.cgi?id=191492
+
+Reviewed by Alex Christensen.
+
+Rename file.
+
+* API/JSValue.mm:
+
2018-11-10 Benjamin Poulain
Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (238073 => 238074)
--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2018-11-11 06:16:22 UTC (rev 238073)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj 2018-11-11 08:27:32 UTC (rev 238074)
@@ -389,7 +389,7 @@
7CDD7FF7186D291E007433CD /* IteratorAdaptors.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IteratorAdaptors.h; sourceTree = ""; };
7CDD7FF9186D2A54007433CD /* IteratorRange.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
