[webkit-changes] [238219] trunk
Title: [238219] trunk
Revision 238219
Author krol...@apple.com
Date 2018-11-14 22:01:15 -0800 (Wed, 14 Nov 2018)
Log Message
Move scripts for Derived and Unified Sources to external files
https://bugs.webkit.org/show_bug.cgi?id=191670
Reviewed by Keith Miller.
Move the scripts in the Generate Derived Sources and Generate Unified
Sources Run Script phases from the Xcode projects to external shell
script files. Then invoke those scripts from the Run Script phases.
This refactoring is being performed to support later work that will
invoke these scripts in other contexts.
The scripts were maintained as-is when making the move. I did a little
reformatting and added 'set -e' to the top of each file, but that's
it.
Source/_javascript_Core:
* _javascript_Core.xcodeproj/project.pbxproj:
* Scripts/generate-derived-sources.sh: Added.
* Scripts/generate-unified-sources.sh: Added.
Source/WebCore:
No new tests -- no changed functionality.
* Scripts/generate-derived-sources.sh: Added.
* Scripts/generate-unified-sources.sh: Added.
* WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
* Scripts/generate-derived-sources.sh: Added.
* Scripts/generate-unified-sources.sh: Added.
* WebKit.xcodeproj/project.pbxproj:
Tools:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/Scripts/generate-derived-sources.sh: Added.
* WebKitTestRunner/Scripts/generate-derived-sources.sh: Added.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
Added Paths
trunk/Source/_javascript_Core/Scripts/generate-derived-sources.sh
trunk/Source/_javascript_Core/Scripts/generate-unified-sources.sh
trunk/Source/WebCore/Scripts/generate-derived-sources.sh
trunk/Source/WebCore/Scripts/generate-unified-sources.sh
trunk/Source/WebKit/Scripts/generate-derived-sources.sh
trunk/Source/WebKit/Scripts/generate-unified-sources.sh
trunk/Tools/DumpRenderTree/Scripts/
trunk/Tools/DumpRenderTree/Scripts/generate-derived-sources.sh
trunk/Tools/WebKitTestRunner/Scripts/
trunk/Tools/WebKitTestRunner/Scripts/generate-derived-sources.sh
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (238218 => 238219)
--- trunk/Source/_javascript_Core/ChangeLog 2018-11-15 03:35:37 UTC (rev 238218)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-11-15 06:01:15 UTC (rev 238219)
@@ -1,3 +1,25 @@
+2018-11-14 Keith Rollin
+
+Move scripts for Derived and Unified Sources to external files
+https://bugs.webkit.org/show_bug.cgi?id=191670
+
+
+Reviewed by Keith Miller.
+
+Move the scripts in the Generate Derived Sources and Generate Unified
+Sources Run Script phases from the Xcode projects to external shell
+script files. Then invoke those scripts from the Run Script phases.
+This refactoring is being performed to support later work that will
+invoke these scripts in other contexts.
+
+The scripts were maintained as-is when making the move. I did a little
+reformatting and added 'set -e' to the top of each file, but that's
+it.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* Scripts/generate-derived-sources.sh: Added.
+* Scripts/generate-unified-sources.sh: Added.
+
2018-11-14 Joseph Pecoraro
Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (238218 => 238219)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2018-11-15 03:35:37 UTC (rev 238218)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2018-11-15 06:01:15 UTC (rev 238219)
@@ -10178,7 +10178,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "set -e\n\ncd $SRCROOT\n\nif [ \"${DEPLOYMENT_LOCATION}\" == \"YES\" ]; then\nBUILD_SCRIPTS_DIR=\"${SDKROOT}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/include/wtf/Scripts\"\nelse\nBUILD_SCRIPTS_DIR=\"${BUILT_PRODUCTS_DIR}/usr/local/include/wtf/Scripts\"\nfi\n\nUnifiedSourceCppFileCount=145\nUnifiedSourceMmFileCount=5\n\n/usr/bin/env ruby \"${BUILD_SCRIPTS_DIR}/generate-unified-source-bundles.rb\" \"--derived-sources-path\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core\" \"--source-tree-path\" \"${SRCROOT}\" \"--max-cpp-bundle-count\" \"${UnifiedSourceCppFileCount}\" \"--max-obj-c-bundle-count\" \"${UnifiedSourceMmFileCount}\" \"Sources.txt\" \"SourcesCocoa.txt\" > /dev/null\n";
+ shellScript =
[webkit-changes] [238218] trunk
Title: [238218] trunk Revision 238218 Author cdu...@apple.com Date 2018-11-14 19:35:37 -0800 (Wed, 14 Nov 2018) Log Message WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects API fails when PSON is enabled https://bugs.webkit.org/show_bug.cgi?id=191640 Reviewed by Alex Christensen. Source/WebKit: The issue was that when process-swapping on a redirect, the parameters provided by the new WebContent process for navigationActionData / originatingFrameInfoData / frameSecurityOrigin are not correct because it does not have sufficient information (it does not know a swap happened). To address the issue, we now store the navigationActionData / originatingFrameInfoData / frameSecurityOrigin on the Navigation object whenever decidePolicyForNavigationAction is called. If the decidePolicyForNavigationAction is for a redirect, use the ones we stored on the Navigation object instead of the ones provided by the WebContent process. In case of redirect, those do not change anyway. This fixes all WebKit.DecidePolicyForNavigationAction* tests with PSON enabled. * UIProcess/API/APINavigation.h: (API::Navigation::currentRequestIsRedirect const): (API::Navigation::wasUserInitiated const): (API::Navigation::shouldForceDownload const): (API::Navigation::treatAsSameOriginNavigation const): (API::Navigation::hasOpenedFrames const): (API::Navigation::openedViaWindowOpenWithOpener const): (API::Navigation::opener const): (API::Navigation::requesterOrigin const): (API::Navigation::lockHistory const): (API::Navigation::lockBackForwardList const): (API::Navigation::clientRedirectSourceForHistory const): (API::Navigation::setLastNavigationAction): (API::Navigation::lastNavigationAction const): (API::Navigation::setOriginatingFrameInfo): (API::Navigation::originatingFrameInfo const): (API::Navigation::setDestinationFrameSecurityOrigin): (API::Navigation::destinationFrameSecurityOrigin const): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::decidePolicyForNavigationActionAsync): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNavigationActionSync): * UIProcess/WebPageProxy.h: Tools: Add API test coverage. * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm: (runDecidePolicyForNavigationActionForHyperlinkThatRedirects): (TEST): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APINavigation.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm Diff Modified: trunk/Source/WebKit/ChangeLog (238217 => 238218) --- trunk/Source/WebKit/ChangeLog 2018-11-15 03:33:40 UTC (rev 238217) +++ trunk/Source/WebKit/ChangeLog 2018-11-15 03:35:37 UTC (rev 238218) @@ -1,5 +1,49 @@ 2018-11-14 Chris Dumez +WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects API fails when PSON is enabled +https://bugs.webkit.org/show_bug.cgi?id=191640 + +Reviewed by Alex Christensen. + +The issue was that when process-swapping on a redirect, the parameters provided by the new +WebContent process for navigationActionData / originatingFrameInfoData / frameSecurityOrigin +are not correct because it does not have sufficient information (it does not know a swap +happened). + +To address the issue, we now store the navigationActionData / originatingFrameInfoData / +frameSecurityOrigin on the Navigation object whenever decidePolicyForNavigationAction is +called. If the decidePolicyForNavigationAction is for a redirect, use the ones we stored +on the Navigation object instead of the ones provided by the WebContent process. In case +of redirect, those do not change anyway. + +This fixes all WebKit.DecidePolicyForNavigationAction* tests with PSON enabled. + +* UIProcess/API/APINavigation.h: +(API::Navigation::currentRequestIsRedirect const): +(API::Navigation::wasUserInitiated const): +(API::Navigation::shouldForceDownload const): +(API::Navigation::treatAsSameOriginNavigation const): +(API::Navigation::hasOpenedFrames const): +(API::Navigation::openedViaWindowOpenWithOpener const): +(API::Navigation::opener const): +(API::Navigation::requesterOrigin const): +(API::Navigation::lockHistory const): +(API::Navigation::lockBackForwardList const): +(API::Navigation::clientRedirectSourceForHistory const): +(API::Navigation::setLastNavigationAction): +(API::Navigation::lastNavigationAction const): +(API::Navigation::setOriginatingFrameInfo): +(API::Navigation::originatingFrameInfo const): +(API::Navigation::setDestinationFrameSecurityOrigin): +(API::Navigation::destinationFrameSecurityOrigin const): +* UIProcess/WebPageProxy.cpp: +
[webkit-changes] [238217] trunk/Source
Title: [238217] trunk/Source
Revision 238217
Author krol...@apple.com
Date 2018-11-14 19:33:40 -0800 (Wed, 14 Nov 2018)
Log Message
Fix #end vs. #endif typo.
https://bugs.webkit.org/show_bug.cgi?id=191668
Reviewed by Alexey Proskuryakov.
Source/WebCore/SourcesCocoa.txt had a #end that should have been a
#endif. Fix this, an add a check to generate-unified-source-bundles.rb
to detect similar typos.
Source/WebCore:
No new tests -- no changed functionality.
* SourcesCocoa.txt:
Source/WTF:
* Scripts/generate-unified-source-bundles.rb:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesCocoa.txt
Diff
Modified: trunk/Source/WTF/ChangeLog (238216 => 238217)
--- trunk/Source/WTF/ChangeLog 2018-11-15 03:32:32 UTC (rev 238216)
+++ trunk/Source/WTF/ChangeLog 2018-11-15 03:33:40 UTC (rev 238217)
@@ -1,3 +1,17 @@
+2018-11-14 Keith Rollin
+
+Fix #end vs. #endif typo.
+https://bugs.webkit.org/show_bug.cgi?id=191668
+
+
+Reviewed by Alexey Proskuryakov.
+
+Source/WebCore/SourcesCocoa.txt had a #end that should have been a
+#endif. Fix this, an add a check to generate-unified-source-bundles.rb
+to detect similar typos.
+
+* Scripts/generate-unified-source-bundles.rb:
+
2018-11-12 Mark Lam
Add OOM detection to StringPrototype's substituteBackreferences().
Modified: trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb (238216 => 238217)
--- trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb 2018-11-15 03:32:32 UTC (rev 238216)
+++ trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb 2018-11-15 03:33:40 UTC (rev 238217)
@@ -273,6 +273,7 @@
raise "malformed #if" unless line =~ /\A#if\s+(\S+)/
inDisabledLines = !$featureFlags[$1]
else
+raise "malformed preprocessor directive: #{line}" if line =~ /^#/
raise "duplicate line: #{line} in #{path}" if seen[line]
seen[line] = true
result << SourceFile.new(line, sourceFileIndex)
Modified: trunk/Source/WebCore/ChangeLog (238216 => 238217)
--- trunk/Source/WebCore/ChangeLog 2018-11-15 03:32:32 UTC (rev 238216)
+++ trunk/Source/WebCore/ChangeLog 2018-11-15 03:33:40 UTC (rev 238217)
@@ -1,5 +1,21 @@
2018-11-14 Keith Rollin
+Fix #end vs. #endif typo.
+https://bugs.webkit.org/show_bug.cgi?id=191668
+
+
+Reviewed by Alexey Proskuryakov.
+
+Source/WebCore/SourcesCocoa.txt had a #end that should have been a
+#endif. Fix this, an add a check to generate-unified-source-bundles.rb
+to detect similar typos.
+
+No new tests -- no changed functionality.
+
+* SourcesCocoa.txt:
+
+2018-11-14 Keith Rollin
+
Remove VideoFullscreenLayerManager.mm from WebCore/SourcesCocoa.txt
https://bugs.webkit.org/show_bug.cgi?id=191667
Modified: trunk/Source/WebCore/SourcesCocoa.txt (238216 => 238217)
--- trunk/Source/WebCore/SourcesCocoa.txt 2018-11-15 03:32:32 UTC (rev 238216)
+++ trunk/Source/WebCore/SourcesCocoa.txt 2018-11-15 03:33:40 UTC (rev 238217)
@@ -632,7 +632,7 @@
JSTouchEvent.cpp
JSTouchList.cpp
-#end
+#endif
#if ENABLE_IOS_GESTURE_EVENTS
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238216] trunk/Tools
Title: [238216] trunk/Tools
Revision 238216
Author cdu...@apple.com
Date 2018-11-14 19:32:32 -0800 (Wed, 14 Nov 2018)
Log Message
REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing
https://bugs.webkit.org/show_bug.cgi?id=191660
Reviewed by Ryosuke Niwa.
The test tries to navigate to an invalid URL and makes sure that we do not process swap
for such load. The test was inherently racing because it was doing:
Its load event handler tries to navigate to 'http://A=a%B=b' and sets a 0 timer to
log an alert, which causes the API test to keep going and check that we did not swap
process. The issue is that a 0 timer may not be sufficient to trigger the load, as
the policy decision is asynchronous and relies on the UIProcess responding to it.
To address the issue, the test now waits for the next policy decision, spins the
run loop and then makes sure we did not swap process. It no longer relies on a message
from the page.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Diff
Modified: trunk/Tools/ChangeLog (238215 => 238216)
--- trunk/Tools/ChangeLog 2018-11-15 03:30:58 UTC (rev 238215)
+++ trunk/Tools/ChangeLog 2018-11-15 03:32:32 UTC (rev 238216)
@@ -1,5 +1,28 @@
2018-11-14 Chris Dumez
+REGRESSION (r238115): [iOS] TestWebKitAPI.ProcessSwap.NavigateToInvalidURL is failing
+https://bugs.webkit.org/show_bug.cgi?id=191660
+
+Reviewed by Ryosuke Niwa.
+
+The test tries to navigate to an invalid URL and makes sure that we do not process swap
+for such load. The test was inherently racing because it was doing:
+
+
+Its load event handler tries to navigate to 'http://A=a%B=b' and sets a 0 timer to
+log an alert, which causes the API test to keep going and check that we did not swap
+process. The issue is that a 0 timer may not be sufficient to trigger the load, as
+the policy decision is asynchronous and relies on the UIProcess responding to it.
+
+To address the issue, the test now waits for the next policy decision, spins the
+run loop and then makes sure we did not swap process. It no longer relies on a message
+from the page.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+(-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
+
+2018-11-14 Chris Dumez
+
WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
https://bugs.webkit.org/show_bug.cgi?id=191638
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (238215 => 238216)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2018-11-15 03:30:58 UTC (rev 238215)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2018-11-15 03:32:32 UTC (rev 238216)
@@ -62,6 +62,7 @@
static bool failed;
static bool didCreateWebView;
static int numberOfDecidePolicyCalls;
+static bool didRepondToPolicyDecisionCall;
static RetainPtr receivedMessages = adoptNS([@[] mutableCopy]);
bool didReceiveAlert;
@@ -123,6 +124,7 @@
decidePolicyForNavigationAction(navigationAction, decisionHandler);
else
decisionHandler(WKNavigationActionPolicyAllow);
+didRepondToPolicyDecisionCall = true;
}
- (void)webView:(WKWebView *)webView didReceiveServerRedirectForProvisionalNavigation:(WKNavigation *)navigation
@@ -2344,12 +2346,6 @@
EXPECT_EQ(pid1, pid3);
}
-static const char* navigateToInvalidURLTestBytes = R"PSONRESOURCE(
-
-
-
-)PSONRESOURCE";
-
TEST(ProcessSwap, NavigateToInvalidURL)
{
auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
@@ -2358,7 +2354,7 @@
auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
[webViewConfiguration setProcessPool:processPool.get()];
-auto handler = adoptNS([[PSONScheme alloc] initWithBytes:navigateToInvalidURLTestBytes]);
+auto handler = adoptNS([[PSONScheme alloc] init]);
[webViewConfiguration setURLSchemeHandler:handler.get() forURLScheme:@"PSON"];
auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:webViewConfiguration.get()]);
@@ -2374,8 +2370,15 @@
auto pid1 = [webView _webProcessIdentifier];
EXPECT_TRUE(!!pid1);
-TestWebKitAPI::Util::run();
-didReceiveAlert = false;
+EXPECT_EQ(1, numberOfDecidePolicyCalls);
+
+[webView evaluateJavaScript:@"location.href = ''" completionHandler:nil];
+
+didRepondToPolicyDecisionCall = false;
+TestWebKitAPI::Util::run();
+
+TestWebKitAPI::Util::spinRunLoop(1);
+
auto pid2 = [webView _webProcessIdentifier];
EXPECT_TRUE(!!pid2);
[webkit-changes] [238215] trunk
Title: [238215] trunk
Revision 238215
Author cdu...@apple.com
Date 2018-11-14 19:30:58 -0800 (Wed, 14 Nov 2018)
Log Message
WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
https://bugs.webkit.org/show_bug.cgi?id=191638
Reviewed by Alex Christensen.
Source/WebKit:
WebProcessPool::prewarmProcess() should not create the default WebSite Data Store if it
does not exist yet. This is bad for memory consumption and it is what was causing this
API test to fail.
WebProcessPool::prewarmProcess() now tries to use the following data stores in this
order of preference:
1. WebProcessPool::m_websiteDataStore (aka this process pool's primary data store)
2. The data store of the last WebProcessProxy that was created
3. The default data store if it exists
If no suitable data store is found, we cancel the process prewarming and log a console
message instead.
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::prewarmProcess):
Tools:
Add API test coverage.
* TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
(TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (238214 => 238215)
--- trunk/Source/WebKit/ChangeLog 2018-11-15 02:40:08 UTC (rev 238214)
+++ trunk/Source/WebKit/ChangeLog 2018-11-15 03:30:58 UTC (rev 238215)
@@ -1,3 +1,26 @@
+2018-11-14 Chris Dumez
+
+WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
+https://bugs.webkit.org/show_bug.cgi?id=191638
+
+Reviewed by Alex Christensen.
+
+WebProcessPool::prewarmProcess() should not create the default WebSite Data Store if it
+does not exist yet. This is bad for memory consumption and it is what was causing this
+API test to fail.
+
+WebProcessPool::prewarmProcess() now tries to use the following data stores in this
+order of preference:
+1. WebProcessPool::m_websiteDataStore (aka this process pool's primary data store)
+2. The data store of the last WebProcessProxy that was created
+3. The default data store if it exists
+
+If no suitable data store is found, we cancel the process prewarming and log a console
+message instead.
+
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::prewarmProcess):
+
2018-11-14 Timothy Hatcher
Enabled dark mode CSS support by default.
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (238214 => 238215)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-11-15 02:40:08 UTC (rev 238214)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-11-15 03:30:58 UTC (rev 238215)
@@ -955,12 +955,21 @@
if (m_prewarmedProcess)
return;
-auto* websiteDataStore = m_websiteDataStore.get();
-if (!websiteDataStore)
-websiteDataStore = API::WebsiteDataStore::defaultDataStore().ptr();
+auto* websiteDataStore = m_websiteDataStore ? _websiteDataStore->websiteDataStore() : nullptr;
+if (!websiteDataStore) {
+if (!m_processes.isEmpty())
+websiteDataStore = _processes.last()->websiteDataStore();
+else if (API::WebsiteDataStore::defaultDataStoreExists())
+websiteDataStore = ::WebsiteDataStore::defaultDataStore()->websiteDataStore();
+else {
+RELEASE_LOG(PerformanceLogging, "Unable to prewarming a WebProcess because we could not find a usable data store");
+return;
+}
+}
+ASSERT(websiteDataStore);
RELEASE_LOG(PerformanceLogging, "Prewarming a WebProcess for performance");
-createNewWebProcess(websiteDataStore->websiteDataStore(), WebProcessProxy::IsPrewarmed::Yes);
+createNewWebProcess(*websiteDataStore, WebProcessProxy::IsPrewarmed::Yes);
}
void WebProcessPool::enableProcessTermination()
Modified: trunk/Tools/ChangeLog (238214 => 238215)
--- trunk/Tools/ChangeLog 2018-11-15 02:40:08 UTC (rev 238214)
+++ trunk/Tools/ChangeLog 2018-11-15 03:30:58 UTC (rev 238215)
@@ -1,3 +1,16 @@
+2018-11-14 Chris Dumez
+
+WebKit.WebsiteDataStoreCustomPaths API test is failing when enabling process prewarming
+https://bugs.webkit.org/show_bug.cgi?id=191638
+
+Reviewed by Alex Christensen.
+
+Add API test coverage.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
+(runWebsiteDataStoreCustomPaths):
+(TEST):
+
2018-11-14 Alex Christensen
Add SPI to show a safe browsing warning
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm (238214 => 238215)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm 2018-11-15 02:40:08 UTC (rev 238214)
+++
[webkit-changes] [238214] trunk/Source/WebCore
Title: [238214] trunk/Source/WebCore Revision 238214 Author krol...@apple.com Date 2018-11-14 18:40:08 -0800 (Wed, 14 Nov 2018) Log Message Remove VideoFullscreenLayerManager.mm from WebCore/SourcesCocoa.txt https://bugs.webkit.org/show_bug.cgi?id=191667 Reviewed by Eric Carlson. VideoFullscreenLayerManager.mm no longer exists. No new tests -- No changed functionality. * SourcesCocoa.txt: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/SourcesCocoa.txt Diff Modified: trunk/Source/WebCore/ChangeLog (238213 => 238214) --- trunk/Source/WebCore/ChangeLog 2018-11-15 02:27:32 UTC (rev 238213) +++ trunk/Source/WebCore/ChangeLog 2018-11-15 02:40:08 UTC (rev 238214) @@ -1,3 +1,17 @@ +2018-11-14 Keith Rollin + +Remove VideoFullscreenLayerManager.mm from WebCore/SourcesCocoa.txt +https://bugs.webkit.org/show_bug.cgi?id=191667 + + +Reviewed by Eric Carlson. + +VideoFullscreenLayerManager.mm no longer exists. + +No new tests -- No changed functionality. + +* SourcesCocoa.txt: + 2018-11-14 Timothy Hatcher Enabled dark mode CSS support by default. Modified: trunk/Source/WebCore/SourcesCocoa.txt (238213 => 238214) --- trunk/Source/WebCore/SourcesCocoa.txt 2018-11-15 02:27:32 UTC (rev 238213) +++ trunk/Source/WebCore/SourcesCocoa.txt 2018-11-15 02:40:08 UTC (rev 238214) @@ -259,7 +259,6 @@ platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm @no-unify platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm @no-unify platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm @no-unify -platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm @no-unify platform/graphics/ca/GraphicsLayerCA.cpp platform/graphics/ca/LayerPool.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238213] trunk/Source
Title: [238213] trunk/Source
Revision 238213
Author timo...@apple.com
Date 2018-11-14 18:27:32 -0800 (Wed, 14 Nov 2018)
Log Message
Enabled dark mode CSS support by default.
https://bugs.webkit.org/show_bug.cgi?id=191609
rdar://problem/46046861
Reviewed by Megan Gardner.
Source/WebCore:
* page/RuntimeEnabledFeatures.h: Set m_isDarkModeCSSEnabled to true.
Source/WebKit:
* Shared/WebPreferences.yaml: Set DarkModeCSSEnabled's defaultValue to true.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
Diff
Modified: trunk/Source/WebCore/ChangeLog (238212 => 238213)
--- trunk/Source/WebCore/ChangeLog 2018-11-15 01:48:20 UTC (rev 238212)
+++ trunk/Source/WebCore/ChangeLog 2018-11-15 02:27:32 UTC (rev 238213)
@@ -1,5 +1,15 @@
2018-11-14 Timothy Hatcher
+Enabled dark mode CSS support by default.
+https://bugs.webkit.org/show_bug.cgi?id=191609
+rdar://problem/46046861
+
+Reviewed by Megan Gardner.
+
+* page/RuntimeEnabledFeatures.h: Set m_isDarkModeCSSEnabled to true.
+
+2018-11-14 Timothy Hatcher
+
Default the view background color and text color to different values when in dark mode.
https://bugs.webkit.org/show_bug.cgi?id=191607
rdar://problem/46045854
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (238212 => 238213)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2018-11-15 01:48:20 UTC (rev 238212)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2018-11-15 02:27:32 UTC (rev 238213)
@@ -381,7 +381,7 @@
#endif
#if ENABLE(DARK_MODE_CSS)
-bool m_isDarkModeCSSEnabled { false };
+bool m_isDarkModeCSSEnabled { true };
#endif
#if ENABLE(INDEXED_DATABASE_IN_WORKERS)
Modified: trunk/Source/WebKit/ChangeLog (238212 => 238213)
--- trunk/Source/WebKit/ChangeLog 2018-11-15 01:48:20 UTC (rev 238212)
+++ trunk/Source/WebKit/ChangeLog 2018-11-15 02:27:32 UTC (rev 238213)
@@ -1,5 +1,15 @@
2018-11-14 Timothy Hatcher
+Enabled dark mode CSS support by default.
+https://bugs.webkit.org/show_bug.cgi?id=191609
+rdar://problem/46046861
+
+Reviewed by Megan Gardner.
+
+* Shared/WebPreferences.yaml: Set DarkModeCSSEnabled's defaultValue to true.
+
+2018-11-14 Timothy Hatcher
+
Default the view background color and text color to different values when in dark mode.
https://bugs.webkit.org/show_bug.cgi?id=191607
rdar://problem/46045854
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (238212 => 238213)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-11-15 01:48:20 UTC (rev 238212)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-11-15 02:27:32 UTC (rev 238213)
@@ -1323,7 +1323,7 @@
DarkModeCSSEnabled:
type: bool
- defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
+ defaultValue: true
humanReadableName: "Dark Mode CSS Support"
humanReadableDescription: "Enable Dark Mode CSS Support"
webcoreBinding: RuntimeEnabledFeatures
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238212] trunk
Title: [238212] trunk Revision 238212 Author timo...@apple.com Date 2018-11-14 17:48:20 -0800 (Wed, 14 Nov 2018) Log Message Default the view background color and text color to different values when in dark mode. https://bugs.webkit.org/show_bug.cgi?id=191607 rdar://problem/46045854 Reviewed by Dean Jackson. Source/WebCore: Test: css-dark-mode/default-colors.html * css/html.css: (html): Set color: text on macOS. * dom/Document.cpp: (WebCore::Document::processSupportedColorSchemes): Call recalculateBaseBackgroundColor(). * editing/EditingStyle.cpp: (WebCore::caretColorFromStyle): Added. (WebCore::EditingStyle::prepareToApplyAt): Use equalIgnoringSemanticColor. Check for caret-color directly since removeEquivalentProperties fails with semantic colors. (WebCore::extractPropertiesNotIn): Use equalIgnoringSemanticColor. Check for caret-color directly since removeEquivalentProperties fails with semantic colors. * page/Frame.cpp: (WebCore::Frame::createView): Drop backgroundColor. * page/Frame.h: * page/FrameView.cpp: (WebCore::FrameView::recalculateBaseBackgroundColor): Added. (WebCore::FrameView::updateBackgroundRecursively): Drop backgroundColor argument. Calculate the backgroundColor based on the transparent argument only. * page/FrameView.h: * platform/graphics/Color.h: (WebCore::equalIgnoringSemanticColor): Added for EditingStyle. * rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): Call recalculateBaseBackgroundColor(). * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::shouldDumpPropertyForLayer const): Use isWhiteColor() since it ignores the semantic color flag. * testing/Internals.cpp: (WebCore::Internals::setViewIsTransparent): Drop backgroundColor. (WebCore::Internals::viewBaseBackgroundColor): Added. * testing/Internals.h: * testing/Internals.idl: Added viewBaseBackgroundColor. Source/WebKit: * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::backgroundColor const): Use controlBackgroundColor. (WebKit::WebViewImpl::updateLayer): Simplified and use backgroundColor() getter. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setDrawsBackground): Drop backgroundColor. Source/WebKitLegacy/win: * WebFrame.cpp: (WebFrame::updateBackground): Drop backgroundColor. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor. LayoutTests: * css-dark-mode/default-colors-expected.txt: Added. * css-dark-mode/default-colors.html: Added. * inspector/css/shadow-scoped-style-expected.txt: Rebaseline. * platform/mac/printing/width-overflow-expected.txt: Rebaseline. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/css/shadow-scoped-style-expected.txt trunk/LayoutTests/platform/mac/printing/width-overflow-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/html.css trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/editing/EditingStyle.cpp trunk/Source/WebCore/page/Frame.cpp trunk/Source/WebCore/page/Frame.h trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h trunk/Source/WebCore/platform/graphics/Color.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKitLegacy/win/ChangeLog trunk/Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Source/WebKitLegacy/win/WebFrame.cpp Added Paths trunk/LayoutTests/css-dark-mode/default-colors-expected.txt trunk/LayoutTests/css-dark-mode/default-colors.html Diff Modified: trunk/LayoutTests/ChangeLog (238211 => 238212) --- trunk/LayoutTests/ChangeLog 2018-11-15 01:38:30 UTC (rev 238211) +++ trunk/LayoutTests/ChangeLog 2018-11-15 01:48:20 UTC (rev 238212) @@ -1,3 +1,16 @@ +2018-11-14 Timothy Hatcher + +Default the view background color and text color to different values when in dark mode. +https://bugs.webkit.org/show_bug.cgi?id=191607 +rdar://problem/46045854 + +Reviewed by Dean Jackson. + +* css-dark-mode/default-colors-expected.txt: Added. +* css-dark-mode/default-colors.html: Added. +* inspector/css/shadow-scoped-style-expected.txt: Rebaseline. +* platform/mac/printing/width-overflow-expected.txt: Rebaseline. + 2018-11-14 Ryan Haddad Layout test fast/layers/no-clipping-overflow-hidden-added-after-transform.html is a flaky failure on EWS bots Added: trunk/LayoutTests/css-dark-mode/default-colors-expected.txt (0 => 238212) ---
[webkit-changes] [238211] trunk/Source
Title: [238211] trunk/Source Revision 238211 Author alanc...@apple.com Date 2018-11-14 17:38:30 -0800 (Wed, 14 Nov 2018) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (238210 => 238211) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-15 01:38:30 UTC (rev 238211) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (238210 => 238211) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-15 01:38:30 UTC (rev 238211) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (238210 => 238211) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2018-11-15 01:38:30 UTC (rev 238211) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (238210 => 238211) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-15 01:38:30 UTC (rev 238211) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (238210 => 238211) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-15 01:38:30 UTC (rev 238211) @@ -1,6 +1,6 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (238210 => 238211) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2018-11-15 01:38:30 UTC (rev 238211) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (238210 => 238211) --- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) +++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-15 01:38:30 UTC (rev 238211) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238210] trunk/Source
Title: [238210] trunk/Source Revision 238210 Author alanc...@apple.com Date 2018-11-14 17:27:21 -0800 (Wed, 14 Nov 2018) Log Message Revert "Versioning." This reverts commit 657b4918e31469e5d37af91eca7b4a07f0335d9c. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (238209 => 238210) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-15 01:25:56 UTC (rev 238209) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 15; +TINY_VERSION = 14; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (238209 => 238210) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-15 01:25:56 UTC (rev 238209) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 15; +TINY_VERSION = 14; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (238209 => 238210) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2018-11-15 01:25:56 UTC (rev 238209) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 15; +TINY_VERSION = 14; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (238209 => 238210) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-15 01:25:56 UTC (rev 238209) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 15; +TINY_VERSION = 14; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (238209 => 238210) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-15 01:25:56 UTC (rev 238209) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) @@ -1,6 +1,6 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 15; +TINY_VERSION = 14; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (238209 => 238210) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2018-11-15 01:25:56 UTC (rev 238209) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 15; +TINY_VERSION = 14; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (238209 => 238210) --- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-15 01:25:56 UTC (rev 238209) +++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-15 01:27:21 UTC (rev 238210) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 15; +TINY_VERSION = 14; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238209] releases/Apple
Title: [238209] releases/Apple Revision 238209 Author m...@apple.com Date 2018-11-14 17:25:56 -0800 (Wed, 14 Nov 2018) Log Message Added a tag for Safari Technology Preview release 70. Added Paths releases/Apple/Safari Technology Preview 70/ releases/Apple/Safari Technology Preview 70/ANGLE/ releases/Apple/Safari Technology Preview 70/_javascript_Core/ releases/Apple/Safari Technology Preview 70/WTF/ releases/Apple/Safari Technology Preview 70/WebCore/ releases/Apple/Safari Technology Preview 70/WebInspectorUI/ releases/Apple/Safari Technology Preview 70/WebKit/ releases/Apple/Safari Technology Preview 70/WebKitLegacy/ releases/Apple/Safari Technology Preview 70/bmalloc/ releases/Apple/Safari Technology Preview 70/libwebrtc/ Diff Index: releases/Apple/Safari Technology Preview 70/ANGLE === --- tags/Safari-607.1.13/Source/ThirdParty/ANGLE 2018-11-15 00:33:53 UTC (rev 238208) +++ releases/Apple/Safari Technology Preview 70/ANGLE 2018-11-15 01:25:56 UTC (rev 238209) Property changes: releases/Apple/Safari Technology Preview 70/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 70/_javascript_Core === --- tags/Safari-607.1.13/Source/_javascript_Core 2018-11-15 00:33:53 UTC (rev 238208) +++ releases/Apple/Safari Technology Preview 70/_javascript_Core 2018-11-15 01:25:56 UTC (rev 238209) Property changes: releases/Apple/Safari Technology Preview 70/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 70/WTF === --- tags/Safari-607.1.13/Source/WTF 2018-11-15 00:33:53 UTC (rev 238208) +++ releases/Apple/Safari Technology Preview 70/WTF 2018-11-15 01:25:56 UTC (rev 238209) Property changes: releases/Apple/Safari Technology Preview 70/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 70/WebInspectorUI === --- tags/Safari-607.1.13/Source/WebInspectorUI 2018-11-15 00:33:53 UTC (rev 238208) +++ releases/Apple/Safari Technology Preview 70/WebInspectorUI 2018-11-15 01:25:56 UTC (rev 238209) Property changes: releases/Apple/Safari Technology Preview 70/WebInspectorUI Added: svn:mergeinfo +/trunk/Source/WebInspectorUI:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 70/bmalloc === --- tags/Safari-607.1.13/Source/bmalloc 2018-11-15 00:33:53 UTC (rev 238208) +++ releases/Apple/Safari Technology Preview 70/bmalloc 2018-11-15 01:25:56 UTC (rev 238209) Property changes: releases/Apple/Safari Technology Preview 70/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455 \ No newline at end of property Index: releases/Apple/Safari Technology Preview 70/libwebrtc === --- tags/Safari-607.1.13/Source/ThirdParty/libwebrtc 2018-11-15 00:33:53 UTC (rev 238208) +++ releases/Apple/Safari Technology Preview 70/libwebrtc 2018-11-15 01:25:56 UTC (rev 238209) Property changes: releases/Apple/Safari Technology Preview 70/libwebrtc Added: svn:mergeinfo +/trunk/Source/ThirdParty/libwebrtc:53455 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238208] trunk/Source/WebCore
Title: [238208] trunk/Source/WebCore
Revision 238208
Author justin_...@apple.com
Date 2018-11-14 16:33:53 -0800 (Wed, 14 Nov 2018)
Log Message
[WebGPU] Code quality concerns raised for 191291: [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
https://bugs.webkit.org/show_bug.cgi?id=191383
Reviewed by Dean Jackson.
Covered by existing WebGPU tests introduced in original patch.
* Modules/webgpu/GPUDevice.h:
* Modules/webgpu/GPUPipelineStageDescriptor.h:
* Modules/webgpu/GPURenderPipelineDescriptor.h: Now a base struct with a guaranteed vertex stage member.
(): Refactored into enum class.
(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor): Removed in favor of init-list construction.
(WebCore::GPURenderPipelineDescriptor::primitiveTopology): Now a proper enum class member.
* Modules/webgpu/GPUShaderModule.h:
* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createRenderPipeline const):
* Modules/webgpu/WebGPUShaderModule.h:
(WebCore::WebGPUShaderModule::module const):
* Modules/webgpu/WebGPUShaderStage.h: Replaced enum with constants to better reflect IDL.
* Modules/webgpu/cocoa/GPURenderPipeline.h:
* Modules/webgpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::setFunctionsForPipelineDescriptor):
(WebCore::GPURenderPipeline::create):
* Modules/webgpu/cocoa/GPUSwapChain.h:
* WebCore.xcodeproj/project.pbxproj: Removed GPUPipelineDescriptorBase.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webgpu/GPUDevice.h
trunk/Source/WebCore/Modules/webgpu/GPUPipelineStageDescriptor.h
trunk/Source/WebCore/Modules/webgpu/GPURenderPipelineDescriptor.h
trunk/Source/WebCore/Modules/webgpu/GPUShaderModule.h
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
trunk/Source/WebCore/Modules/webgpu/WebGPUShaderModule.h
trunk/Source/WebCore/Modules/webgpu/WebGPUShaderStage.h
trunk/Source/WebCore/Modules/webgpu/cocoa/GPURenderPipeline.h
trunk/Source/WebCore/Modules/webgpu/cocoa/GPURenderPipelineMetal.mm
trunk/Source/WebCore/Modules/webgpu/cocoa/GPUSwapChain.h
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (238207 => 238208)
--- trunk/Source/WebCore/ChangeLog 2018-11-15 00:32:57 UTC (rev 238207)
+++ trunk/Source/WebCore/ChangeLog 2018-11-15 00:33:53 UTC (rev 238208)
@@ -1,3 +1,31 @@
+2018-11-14 Justin Fan
+
+[WebGPU] Code quality concerns raised for 191291: [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
+https://bugs.webkit.org/show_bug.cgi?id=191383
+
+Reviewed by Dean Jackson.
+
+Covered by existing WebGPU tests introduced in original patch.
+
+* Modules/webgpu/GPUDevice.h:
+* Modules/webgpu/GPUPipelineStageDescriptor.h:
+* Modules/webgpu/GPURenderPipelineDescriptor.h: Now a base struct with a guaranteed vertex stage member.
+(): Refactored into enum class.
+(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor): Removed in favor of init-list construction.
+(WebCore::GPURenderPipelineDescriptor::primitiveTopology): Now a proper enum class member.
+* Modules/webgpu/GPUShaderModule.h:
+* Modules/webgpu/WebGPUDevice.cpp:
+(WebCore::WebGPUDevice::createRenderPipeline const):
+* Modules/webgpu/WebGPUShaderModule.h:
+(WebCore::WebGPUShaderModule::module const):
+* Modules/webgpu/WebGPUShaderStage.h: Replaced enum with constants to better reflect IDL.
+* Modules/webgpu/cocoa/GPURenderPipeline.h:
+* Modules/webgpu/cocoa/GPURenderPipelineMetal.mm:
+(WebCore::setFunctionsForPipelineDescriptor):
+(WebCore::GPURenderPipeline::create):
+* Modules/webgpu/cocoa/GPUSwapChain.h:
+* WebCore.xcodeproj/project.pbxproj: Removed GPUPipelineDescriptorBase.
+
2018-11-14 Joseph Pecoraro
Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
Modified: trunk/Source/WebCore/Modules/webgpu/GPUDevice.h (238207 => 238208)
--- trunk/Source/WebCore/Modules/webgpu/GPUDevice.h 2018-11-15 00:32:57 UTC (rev 238207)
+++ trunk/Source/WebCore/Modules/webgpu/GPUDevice.h 2018-11-15 00:33:53 UTC (rev 238208)
@@ -31,19 +31,12 @@
#include
#include
-#if USE(METAL)
OBJC_PROTOCOL(MTLDevice);
-#endif
namespace WebCore {
-#if USE(METAL)
using PlatformDevice = MTLDevice;
using PlatformDeviceSmartPtr = RetainPtr;
-#else
-using PlatformDevice = void;
-using PlatformDeviceSmartPtr = RefPtr;
-#endif
class GPUShaderModule;
class GPURenderPipeline;
Modified: trunk/Source/WebCore/Modules/webgpu/GPUPipelineStageDescriptor.h (238207 => 238208)
--- trunk/Source/WebCore/Modules/webgpu/GPUPipelineStageDescriptor.h 2018-11-15 00:32:57 UTC (rev 238207)
+++ trunk/Source/WebCore/Modules/webgpu/GPUPipelineStageDescriptor.h 2018-11-15 00:33:53 UTC (rev 238208)
@@ -34,8 +34,7 @@
namespace WebCore {
struct GPUPipelineStageDescriptor {
-const
[webkit-changes] [238207] trunk/LayoutTests
Title: [238207] trunk/LayoutTests Revision 238207 Author ryanhad...@apple.com Date 2018-11-14 16:32:57 -0800 (Wed, 14 Nov 2018) Log Message Layout test fast/layers/no-clipping-overflow-hidden-added-after-transform.html is a flaky failure on EWS bots https://bugs.webkit.org/show_bug.cgi?id=191658 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Mark this test as flaky on Sierra Release WK2 to reduce the number of retries on mac-wk2-ews. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (238206 => 238207) --- trunk/LayoutTests/ChangeLog 2018-11-14 23:56:07 UTC (rev 238206) +++ trunk/LayoutTests/ChangeLog 2018-11-15 00:32:57 UTC (rev 238207) @@ -1,3 +1,12 @@ +2018-11-14 Ryan Haddad + +Layout test fast/layers/no-clipping-overflow-hidden-added-after-transform.html is a flaky failure on EWS bots +https://bugs.webkit.org/show_bug.cgi?id=191658 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: Mark this test as flaky on Sierra Release WK2 to reduce the number of retries on mac-wk2-ews. + 2018-11-14 Timothy Hatcher Update prefers-color-scheme media query matching based on GitHub issue #3278. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (238206 => 238207) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-11-14 23:56:07 UTC (rev 238206) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-11-15 00:32:57 UTC (rev 238207) @@ -908,3 +908,5 @@ webkit.org/b/191644 [ Sierra ] fast/workers/worker-cloneport.html [ Pass Failure ] webkit.org/b/191642 accessibility/mac/selection-notification-focus-change.html [ Skip ] + +webkit.org/b/191658 [ Sierra Release ] fast/layers/no-clipping-overflow-hidden-added-after-transform.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238206] trunk/Source
Title: [238206] trunk/Source Revision 238206 Author joep...@webkit.org Date 2018-11-14 15:56:07 -0800 (Wed, 14 Nov 2018) Log Message Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods https://bugs.webkit.org/show_bug.cgi?id=191612 Reviewed by Matt Baker. Source/_javascript_Core: * inspector/InspectorFrontendRouter.cpp: (Inspector::FrontendRouter::connectFrontend): (Inspector::FrontendRouter::disconnectFrontend): * inspector/InspectorFrontendRouter.h: * inspector/JSGlobalObjectInspectorController.cpp: (Inspector::JSGlobalObjectInspectorController::connectFrontend): (Inspector::JSGlobalObjectInspectorController::disconnectFrontend): * inspector/JSGlobalObjectInspectorController.h: * inspector/remote/RemoteControllableTarget.h: * inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm: (Inspector::RemoteConnectionToTarget::setup): (Inspector::RemoteConnectionToTarget::close): * inspector/remote/glib/RemoteConnectionToTargetGlib.cpp: (Inspector::RemoteConnectionToTarget::setup): (Inspector::RemoteConnectionToTarget::close): * runtime/JSGlobalObjectDebuggable.cpp: (JSC::JSGlobalObjectDebuggable::connect): (JSC::JSGlobalObjectDebuggable::disconnect): * runtime/JSGlobalObjectDebuggable.h: Source/WebCore: * inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::show): * inspector/InspectorController.h: * inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend): * page/PageDebuggable.cpp: (WebCore::PageDebuggable::connect): (WebCore::PageDebuggable::disconnect): * page/PageDebuggable.h: * testing/Internals.cpp: (WebCore::InspectorStubFrontend::InspectorStubFrontend): (WebCore::InspectorStubFrontend::closeWindow): * workers/service/context/ServiceWorkerDebuggable.cpp: (WebCore::ServiceWorkerDebuggable::connect): (WebCore::ServiceWorkerDebuggable::disconnect): * workers/service/context/ServiceWorkerDebuggable.h: * workers/service/context/ServiceWorkerInspectorProxy.cpp: (WebCore::ServiceWorkerInspectorProxy::connectToWorker): (WebCore::ServiceWorkerInspectorProxy::disconnectFromWorker): * workers/service/context/ServiceWorkerInspectorProxy.h: Source/WebKit: * UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::connect): (WebKit::WebAutomationSession::disconnect): (WebKit::WebAutomationSession::terminate): * UIProcess/Automation/WebAutomationSession.h: * UIProcess/WebPageDebuggable.cpp: (WebKit::WebPageDebuggable::connect): (WebKit::WebPageDebuggable::disconnect): * UIProcess/WebPageDebuggable.h: * UIProcess/WebPageInspectorController.cpp: (WebKit::WebPageInspectorController::connectFrontend): (WebKit::WebPageInspectorController::disconnectFrontend): * UIProcess/WebPageInspectorController.h: * WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::close): * WebProcess/WebPage/WebPageInspectorTarget.cpp: (WebKit::WebPageInspectorTarget::connect): (WebKit::WebPageInspectorTarget::disconnect): Source/WebKitLegacy/mac: * WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController destroyInspectorView]): Source/WebKitLegacy/win: * WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::destroyInspectorView): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/InspectorFrontendRouter.cpp trunk/Source/_javascript_Core/inspector/InspectorFrontendRouter.h trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.cpp trunk/Source/_javascript_Core/inspector/JSGlobalObjectInspectorController.h trunk/Source/_javascript_Core/inspector/remote/RemoteControllableTarget.h trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm trunk/Source/_javascript_Core/inspector/remote/glib/RemoteConnectionToTargetGlib.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObjectDebuggable.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObjectDebuggable.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorController.cpp trunk/Source/WebCore/inspector/InspectorController.h trunk/Source/WebCore/inspector/WorkerInspectorController.cpp trunk/Source/WebCore/page/PageDebuggable.cpp trunk/Source/WebCore/page/PageDebuggable.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/workers/service/context/ServiceWorkerDebuggable.cpp trunk/Source/WebCore/workers/service/context/ServiceWorkerDebuggable.h trunk/Source/WebCore/workers/service/context/ServiceWorkerInspectorProxy.cpp trunk/Source/WebCore/workers/service/context/ServiceWorkerInspectorProxy.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.h trunk/Source/WebKit/UIProcess/WebPageDebuggable.cpp trunk/Source/WebKit/UIProcess/WebPageDebuggable.h
[webkit-changes] [238205] trunk/Source
Title: [238205] trunk/Source Revision 238205 Author alanc...@apple.com Date 2018-11-14 15:40:00 -0800 (Wed, 14 Nov 2018) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (238204 => 238205) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-14 23:31:29 UTC (rev 238204) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-14 23:40:00 UTC (rev 238205) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (238204 => 238205) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-14 23:31:29 UTC (rev 238204) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-14 23:40:00 UTC (rev 238205) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (238204 => 238205) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2018-11-14 23:31:29 UTC (rev 238204) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2018-11-14 23:40:00 UTC (rev 238205) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (238204 => 238205) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-14 23:31:29 UTC (rev 238204) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-14 23:40:00 UTC (rev 238205) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (238204 => 238205) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-14 23:31:29 UTC (rev 238204) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-14 23:40:00 UTC (rev 238205) @@ -1,6 +1,6 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (238204 => 238205) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2018-11-14 23:31:29 UTC (rev 238204) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2018-11-14 23:40:00 UTC (rev 238205) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (238204 => 238205) --- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-14 23:31:29 UTC (rev 238204) +++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-14 23:40:00 UTC (rev 238205) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 14; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238204] tags/Safari-607.1.14/
Title: [238204] tags/Safari-607.1.14/ Revision 238204 Author alanc...@apple.com Date 2018-11-14 15:31:29 -0800 (Wed, 14 Nov 2018) Log Message Tag Safari-607.1.14. Added Paths tags/Safari-607.1.14/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238203] trunk/Source/WebInspectorUI
Title: [238203] trunk/Source/WebInspectorUI Revision 238203 Author mattba...@apple.com Date 2018-11-14 14:54:18 -0800 (Wed, 14 Nov 2018) Log Message Web Inspector: Table should recalculate scrollable height when resized https://bugs.webkit.org/show_bug.cgi?id=191328 Reviewed by Devin Rousso. * UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView.prototype._hideDetailView): Force table columns to layout after hiding the detail view. * UserInterface/Views/Table.js: (WI.Table): (WI.Table.prototype.showColumn): Call `_resizeColumnsAndFiller` instead of `resize`. The latter also cleared `_cachedWidth`, which isn't unnecessary since the width hasn't changed. (WI.Table.prototype.layout): previously `_resizeColumnsAndFiller` always occurred after `_updateVisibleRows`, it was just a matter of whether the cached width and height were cleared first. That now happens in `sizeDidChange`. (WI.Table.prototype.sizeDidChange): (WI.Table.prototype._updateVisibleRows): (WI.Table.prototype.resize): Deleted. Internally this cleared the cached width and height, which moved to `sizeDidChange`. Externally this was used by NetworkTableContentView to force columns to layout after hiding the details view. Calling `updateLayout` on the table accomplishes the same thing using the standard View API. (WI.Table.prototype._resizeColumnsAndFiller): Only update the cached width, since the height will already have been updated. The number of rows doesn't change during this method, so that check was removed. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/Table.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (238202 => 238203) --- trunk/Source/WebInspectorUI/ChangeLog 2018-11-14 22:39:25 UTC (rev 238202) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-14 22:54:18 UTC (rev 238203) @@ -1,3 +1,39 @@ +2018-11-14 Matt Baker + +Web Inspector: Table should recalculate scrollable height when resized +https://bugs.webkit.org/show_bug.cgi?id=191328 + + +Reviewed by Devin Rousso. + +* UserInterface/Views/NetworkTableContentView.js: +(WI.NetworkTableContentView.prototype._hideDetailView): +Force table columns to layout after hiding the detail view. + +* UserInterface/Views/Table.js: +(WI.Table): +(WI.Table.prototype.showColumn): +Call `_resizeColumnsAndFiller` instead of `resize`. The latter also cleared +`_cachedWidth`, which isn't unnecessary since the width hasn't changed. + +(WI.Table.prototype.layout): +previously `_resizeColumnsAndFiller` always occurred after `_updateVisibleRows`, +it was just a matter of whether the cached width and height were cleared first. +That now happens in `sizeDidChange`. + +(WI.Table.prototype.sizeDidChange): +(WI.Table.prototype._updateVisibleRows): +(WI.Table.prototype.resize): Deleted. +Internally this cleared the cached width and height, which moved to `sizeDidChange`. +Externally this was used by NetworkTableContentView to force columns to +layout after hiding the details view. Calling `updateLayout` on the table +accomplishes the same thing using the standard View API. + +(WI.Table.prototype._resizeColumnsAndFiller): +Only update the cached width, since the height will already have been +updated. The number of rows doesn't change during this method, so that +check was removed. + 2018-11-14 Devin Rousso Web Inspector: REGRESSION(r236540): Debugger: breakpoints are sorted alphabetically instead of numerically Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (238202 => 238203) --- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2018-11-14 22:39:25 UTC (rev 238202) +++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2018-11-14 22:54:18 UTC (rev 238203) @@ -1297,7 +1297,7 @@ this._detailView.hidden(); this._detailView = null; -this._table.resize(); +this._table.updateLayout(WI.View.LayoutReason.Resize); this._table.reloadVisibleColumnCells(this._waterfallColumn); } Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (238202 => 238203) --- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2018-11-14 22:39:25 UTC (rev 238202) +++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2018-11-14 22:54:18 UTC (rev 238203) @@ -109,7 +109,7 @@ this._cachedWidth = NaN; this._cachedHeight = NaN; this._cachedScrollTop = NaN; -this._cachedScrollableHeight = NaN; +this._previousCachedWidth = NaN; this._previousRevealedRowCount = NaN; this._topSpacerHeight = NaN;
[webkit-changes] [238202] trunk/Source/WebInspectorUI
Title: [238202] trunk/Source/WebInspectorUI
Revision 238202
Author drou...@apple.com
Date 2018-11-14 14:39:25 -0800 (Wed, 14 Nov 2018)
Log Message
Web Inspector: REGRESSION(r236540): Debugger: breakpoints are sorted alphabetically instead of numerically
https://bugs.webkit.org/show_bug.cgi?id=191560
Reviewed by Joseph Pecoraro.
When sorting breakpoints, if the `WI.TreeElement`s being compared both contain instances of
`WI.Breakpoint`, sort by `WI.SourceCodeLocation` instead of title.
We only do this for `WI.Breakpoint` because they are the only debuggable item that has a
`WI.SourceCodeLocation` (e.g. `WI.EventBreakpoint` is just an event name string).
* UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._addTreeElement):
(WI.DebuggerSidebarPanel.prototype._compareBreakpointTreeElements): Added.
(WI.DebuggerSidebarPanel.prototype._addIssue):
(WI.DebuggerSidebarPanel.prototype._addTreeElement.comparator): Deleted.
(WI.DebuggerSidebarPanel.prototype._compareTreeElements): Deleted.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238201 => 238202)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-14 22:28:52 UTC (rev 238201)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-14 22:39:25 UTC (rev 238202)
@@ -1,3 +1,23 @@
+2018-11-14 Devin Rousso
+
+Web Inspector: REGRESSION(r236540): Debugger: breakpoints are sorted alphabetically instead of numerically
+https://bugs.webkit.org/show_bug.cgi?id=191560
+
+Reviewed by Joseph Pecoraro.
+
+When sorting breakpoints, if the `WI.TreeElement`s being compared both contain instances of
+`WI.Breakpoint`, sort by `WI.SourceCodeLocation` instead of title.
+
+We only do this for `WI.Breakpoint` because they are the only debuggable item that has a
+`WI.SourceCodeLocation` (e.g. `WI.EventBreakpoint` is just an event name string).
+
+* UserInterface/Views/DebuggerSidebarPanel.js:
+(WI.DebuggerSidebarPanel.prototype._addTreeElement):
+(WI.DebuggerSidebarPanel.prototype._compareBreakpointTreeElements): Added.
+(WI.DebuggerSidebarPanel.prototype._addIssue):
+(WI.DebuggerSidebarPanel.prototype._addTreeElement.comparator): Deleted.
+(WI.DebuggerSidebarPanel.prototype._compareTreeElements): Deleted.
+
2018-11-14 Nikita Vasilyev
Web Inspector: Styles: shift-clicking on a property should extend selection
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (238201 => 238202)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2018-11-14 22:28:52 UTC (rev 238201)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js 2018-11-14 22:39:25 UTC (rev 238202)
@@ -969,7 +969,7 @@
if (!parentTreeElement)
parentTreeElement = this._breakpointsContentTreeOutline;
-function comparator(a, b) {
+let comparator = (a, b) => {
const rankFunctions = [
(treeElement) => treeElement.representedObject === WI.debuggerManager.allExceptionsBreakpoint,
(treeElement) => treeElement.representedObject === WI.debuggerManager.uncaughtExceptionsBreakpoint,
@@ -991,13 +991,16 @@
return 1;
}
+if (a instanceof WI.BreakpointTreeElement && b instanceof WI.BreakpointTreeElement)
+return this._compareBreakpointTreeElements(a, b);
+
return a.mainTitle.extendedLocaleCompare(b.mainTitle) || a.subtitle.extendedLocaleCompare(b.subtitle);
-}
+};
parentTreeElement.insertChild(treeElement, insertionIndexForObjectInListSortedByFunction(treeElement, parentTreeElement.children, comparator));
}
-_compareTreeElements(a, b)
+_compareBreakpointTreeElements(a, b)
{
if (!a.representedObject || !b.representedObject)
return 0;
@@ -1326,7 +1329,7 @@
issueTreeElement = new WI.IssueTreeElement(issueMessage);
-parentTreeElement.insertChild(issueTreeElement, insertionIndexForObjectInListSortedByFunction(issueTreeElement, parentTreeElement.children, this._compareTreeElements));
+parentTreeElement.insertChild(issueTreeElement, insertionIndexForObjectInListSortedByFunction(issueTreeElement, parentTreeElement.children, this._compareBreakpointTreeElements));
if (parentTreeElement.children.length === 1)
parentTreeElement.expand();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [238201] trunk/Source/WebInspectorUI
Title: [238201] trunk/Source/WebInspectorUI Revision 238201 Author nvasil...@apple.com Date 2018-11-14 14:28:52 -0800 (Wed, 14 Nov 2018) Log Message Web Inspector: Styles: shift-clicking on a property should extend selection https://bugs.webkit.org/show_bug.cgi?id=191575 Reviewed by Devin Rousso. When there's at least one property is selected, Shift-clicking another property should extend the selection. Pressing Up or Down keys while holding Shift also extends the selection. Remove unnecessary `_startedSelection`. Use `hasSelectedProperties` and `_isMousePressed` instead. * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js: `_isMousePressed` was set to `true` by mistake, causing numerous assertion fails. (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set focusIndex): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.hasSelectedProperties): Renamed from _hasSelectedProperties. (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.extendSelectedProperties): Added. (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseLeave): Removed. (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown): Implement Shift-ArrowUp/ArrowDown keys. * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: (WI.SpreadsheetCSSStyleDeclarationSection): (WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyBlur): (WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseLeave): Removed. This was only used to set _startedSelection. (WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown): (WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowClick): (WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick): Remove _startedSelection and use hasSelectedProperties method instead. * UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty): Remove spreadsheetStylePropertyMouseLeave since it is no longer used. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (238200 => 238201) --- trunk/Source/WebInspectorUI/ChangeLog 2018-11-14 22:24:09 UTC (rev 238200) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-14 22:28:52 UTC (rev 238201) @@ -1,3 +1,43 @@ +2018-11-14 Nikita Vasilyev + +Web Inspector: Styles: shift-clicking on a property should extend selection +https://bugs.webkit.org/show_bug.cgi?id=191575 + + +Reviewed by Devin Rousso. + +When there's at least one property is selected, Shift-clicking another property should extend the selection. +Pressing Up or Down keys while holding Shift also extends the selection. + +Remove unnecessary `_startedSelection`. Use `hasSelectedProperties` and `_isMousePressed` instead. + +* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js: +`_isMousePressed` was set to `true` by mistake, causing numerous assertion fails. + +(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set focusIndex): +(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.hasSelectedProperties): Renamed from _hasSelectedProperties. +(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.extendSelectedProperties): Added. +(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseLeave): Removed. +(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy): + +(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown): +Implement Shift-ArrowUp/ArrowDown keys. + +* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: +(WI.SpreadsheetCSSStyleDeclarationSection): +(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyBlur): +(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseLeave): Removed. +This was only used to set _startedSelection. + +(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown): +(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowClick): +(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick): +Remove _startedSelection and use hasSelectedProperties method instead. + +* UserInterface/Views/SpreadsheetStyleProperty.js: +(WI.SpreadsheetStyleProperty): +Remove spreadsheetStylePropertyMouseLeave since it is no longer used. + 2018-11-14 Devin Rousso Web Inspector: Canvas: send a call stack with each
[webkit-changes] [238200] trunk
Title: [238200] trunk Revision 238200 Author timo...@apple.com Date 2018-11-14 14:24:09 -0800 (Wed, 14 Nov 2018) Log Message Update prefers-color-scheme media query matching based on GitHub issue #3278. https://bugs.webkit.org/show_bug.cgi?id=191654 rdar://problem/46074307 Reviewed by Simon Fraser. Source/WebCore: Test: css-dark-mode/prefers-color-scheme.html * css/MediaQueryEvaluator.cpp: (WebCore::prefersColorSchemeEvaluate): Return true when there is no value. Return false for `no-preference` since there is no macOS option for no user preference. * css/MediaQueryExpression.cpp: (WebCore::isFeatureValidWithoutValue): Added prefers-color-scheme. LayoutTests: * css-dark-mode/prefers-color-scheme-expected.txt: Rebaseline. * css-dark-mode/prefers-color-scheme.html: Updates to better match the spec. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css-dark-mode/prefers-color-scheme-expected.txt trunk/LayoutTests/css-dark-mode/prefers-color-scheme.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/MediaQueryEvaluator.cpp trunk/Source/WebCore/css/MediaQueryExpression.cpp Diff Modified: trunk/LayoutTests/ChangeLog (238199 => 238200) --- trunk/LayoutTests/ChangeLog 2018-11-14 22:03:14 UTC (rev 238199) +++ trunk/LayoutTests/ChangeLog 2018-11-14 22:24:09 UTC (rev 238200) @@ -1,3 +1,14 @@ +2018-11-14 Timothy Hatcher + +Update prefers-color-scheme media query matching based on GitHub issue #3278. +https://bugs.webkit.org/show_bug.cgi?id=191654 +rdar://problem/46074307 + +Reviewed by Simon Fraser. + +* css-dark-mode/prefers-color-scheme-expected.txt: Rebaseline. +* css-dark-mode/prefers-color-scheme.html: Updates to better match the spec. + 2018-11-14 Devin Rousso Web Inspector: Canvas: send a call stack with each action instead of an array of call frames Modified: trunk/LayoutTests/css-dark-mode/prefers-color-scheme-expected.txt (238199 => 238200) --- trunk/LayoutTests/css-dark-mode/prefers-color-scheme-expected.txt 2018-11-14 22:03:14 UTC (rev 238199) +++ trunk/LayoutTests/css-dark-mode/prefers-color-scheme-expected.txt 2018-11-14 22:24:09 UTC (rev 238200) @@ -1,5 +1,7 @@ PASS Element colors are correct in light color scheme +PASS Element colors are correct in light color scheme with boolean context query PASS Dark color scheme enabled PASS Element colors are correct in dark color scheme +PASS Element colors are correct in dark color scheme with boolean context query Modified: trunk/LayoutTests/css-dark-mode/prefers-color-scheme.html (238199 => 238200) --- trunk/LayoutTests/css-dark-mode/prefers-color-scheme.html 2018-11-14 22:03:14 UTC (rev 238199) +++ trunk/LayoutTests/css-dark-mode/prefers-color-scheme.html 2018-11-14 22:24:09 UTC (rev 238200) @@ -6,7 +6,7 @@ +