[webkit-changes] [238440] trunk/Source/WebCore

[rniwa]

Title: [238440] trunk/Source/WebCore








Revision 238440
Author rn...@webkit.org
Date 2018-11-21 22:39:15 -0800 (Wed, 21 Nov 2018)


Log Message
Phantom focus/blur events fire on clicking between text input fields when listening with addEventListener
https://bugs.webkit.org/show_bug.cgi?id=179990

Reviewed by Tim Horton.

The bug was caused by TemporarySelectionChange which is used by TextIndicator::createWithRange
to set and restore the selection putting the focus on the newly mouse-down'ed input element
and restoring the focus back to the input element which originally had the focus immediately.

Fixed the bug by avoiding to set the focus since only selection highlights need to be updated here.
Also made TemporarySelectionOption an enum class.

Unfortunately, no new tests since force click testing is broken :( See .

* editing/Editor.cpp:
(WebCore::TemporarySelectionChange::TemporarySelectionChange):
(WebCore::TemporarySelectionChange::~TemporarySelectionChange):
(WebCore::TemporarySelectionChange::setSelection): Extracted. Fixed the bug by adding
FrameSelection::DoNotSetFocus to the option when TemporarySelectionOption::DoNotSetFocus is set.
* editing/Editor.h:
* page/DragController.cpp:
(WebCore::DragController::performDragOperation):
* page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithRange): Set TemporarySelectionOption::DoNotSetFocus.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/TextIndicator.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238439 => 238440)

--- trunk/Source/WebCore/ChangeLog	2018-11-22 05:47:05 UTC (rev 238439)
+++ trunk/Source/WebCore/ChangeLog	2018-11-22 06:39:15 UTC (rev 238440)
@@ -1,3 +1,30 @@
+2018-11-21  Ryosuke Niwa  
+
+Phantom focus/blur events fire on clicking between text input fields when listening with addEventListener
+https://bugs.webkit.org/show_bug.cgi?id=179990
+
+Reviewed by Tim Horton.
+
+The bug was caused by TemporarySelectionChange which is used by TextIndicator::createWithRange
+to set and restore the selection putting the focus on the newly mouse-down'ed input element
+and restoring the focus back to the input element which originally had the focus immediately.
+
+Fixed the bug by avoiding to set the focus since only selection highlights need to be updated here.
+Also made TemporarySelectionOption an enum class.
+
+Unfortunately, no new tests since force click testing is broken :( See .
+
+* editing/Editor.cpp:
+(WebCore::TemporarySelectionChange::TemporarySelectionChange):
+(WebCore::TemporarySelectionChange::~TemporarySelectionChange):
+(WebCore::TemporarySelectionChange::setSelection): Extracted. Fixed the bug by adding
+FrameSelection::DoNotSetFocus to the option when TemporarySelectionOption::DoNotSetFocus is set.
+* editing/Editor.h:
+* page/DragController.cpp:
+(WebCore::DragController::performDragOperation):
+* page/TextIndicator.cpp:
+(WebCore::TextIndicator::createWithRange): Set TemporarySelectionOption::DoNotSetFocus.
+
 2018-11-21  Wenson Hsieh  
 
 [Cocoa] [WebKit2] Add support for replacing find-in-page text matches


Modified: trunk/Source/WebCore/editing/Editor.cpp (238439 => 238440)

--- trunk/Source/WebCore/editing/Editor.cpp	2018-11-22 05:47:05 UTC (rev 238439)
+++ trunk/Source/WebCore/editing/Editor.cpp	2018-11-22 06:39:15 UTC (rev 238440)
@@ -206,16 +206,16 @@
 #endif
 {
 #if PLATFORM(IOS_FAMILY)
-if (options & TemporarySelectionOptionEnableAppearanceUpdates)
+if (options & TemporarySelectionOption::EnableAppearanceUpdates)
 frame.selection().setUpdateAppearanceEnabled(true);
 #endif
 
-if (options & TemporarySelectionOptionIgnoreSelectionChanges)
+if (options & TemporarySelectionOption::IgnoreSelectionChanges)
 frame.editor().setIgnoreSelectionChanges(true);
 
 if (temporarySelection) {
 m_selectionToRestore = frame.selection().selection();
-frame.selection().setSelection(temporarySelection.value());
+setSelection(temporarySelection.value());
 }
 }
 
@@ -222,19 +222,27 @@
 TemporarySelectionChange::~TemporarySelectionChange()
 {
 if (m_selectionToRestore)
-m_frame->selection().setSelection(m_selectionToRestore.value());
+setSelection(m_selectionToRestore.value());
 
-if (m_options & TemporarySelectionOptionIgnoreSelectionChanges) {
-auto revealSelection = m_options & TemporarySelectionOptionRevealSelection ? Editor::RevealSelection::Yes : Editor::RevealSelection::No;
+if (m_options & TemporarySelectionOption::IgnoreSelectionChanges) {
+auto revealSelection = m_options & TemporarySelectionOption::RevealSelection ? Editor::RevealSelection::Yes : Editor::RevealSelection::No;
 

[webkit-changes] [238438] trunk

[wenson_hsieh]

Title: [238438] trunk








Revision 238438
Author wenson_hs...@apple.com
Date 2018-11-21 21:03:59 -0800 (Wed, 21 Nov 2018)


Log Message
[Cocoa] [WebKit2] Add support for replacing find-in-page text matches
https://bugs.webkit.org/show_bug.cgi?id=191786


Reviewed by Ryosuke Niwa.

Source/WebCore:

Add support for replacing Find-in-Page matches. See below for details. Covered by new layout tests as well as a
new API test.

Tests: editing/find/find-and-replace-adjacent-words.html
   editing/find/find-and-replace-at-editing-boundary.html
   editing/find/find-and-replace-basic.html
   editing/find/find-and-replace-in-subframes.html
   editing/find/find-and-replace-no-matches.html
   editing/find/find-and-replace-noneditable-matches.html
   editing/find/find-and-replace-replacement-text-input-events.html

API test: WebKit.FindAndReplace

* page/Page.cpp:
(WebCore::replaceRanges):
(WebCore::Page::replaceRangesWithText):

Add a helper that, given a list of Ranges, replaces each range with the given text. To do this, we first map
each Range to editing offsets within the topmost editable root for each Range. This results in a map of editable
root to list of editing offsets we need to replace. To apply the replacements, for each editable root in the
map, we iterate over each replacement range (i.e. an offset and length), set the current selection to contain
that replacement range, and use `Editor::replaceSelectionWithText`. To prevent prior text replacements from
clobbering the offsets of latter text replacement ranges, we also iterate backwards through text replacement
ranges when performing each replacement.

Likewise, we also apply text replacement to each editing container in backwards order: for nodes in the same
frame, we compare their position in the document, and for nodes in different frames, we instead compare their
frames in frame tree traversal order.

We map Ranges to editing offsets and back when performing text replacement because each text replacement may
split or merge text nodes, which causes adjacent Ranges to shrink or extend while replacing text. In an earlier
attempt to implement this, I simply iterated over each Range to replace and carried out text replacement for
each Range. This led to incorrect behavior in some cases, such as replacing adjacent matches. Thus, by computing
the set of text replacement offsets prior to replacing any text, we're able to target the correct ranges for
replacement.

(WebCore::Page::replaceSelectionWithText):

Add a helper method on Page to replace the current selection with some text. This simply calls out to
`Editor::replaceSelectionWithText`.

* page/Page.h:

Source/WebCore/PAL:

Add `-replaceMatches:withString:inSelectionOnly:resultCollector:`.

* pal/spi/mac/NSTextFinderSPI.h:

Source/WebKit:

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView replaceMatches:withString:inSelectionOnly:resultCollector:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::replaceMatches):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WKTextFinderClient.mm:
(-[WKTextFinderClient replaceMatches:withString:inSelectionOnly:resultCollector:]):

Implement this method to opt in to "Replace…" UI on macOS in the find bar. In this API, we're given a list of
matches to replace. We propagate the indices of each match to the web process, where FindController maps them to
corresponding replacement ranges. Currently, the given list of matches is only ever a list containing the first
match, or a list containing all matches.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageFindStringMatches):
(WKBundlePageReplaceStringMatches):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::replaceMatches):

Map match indices to Ranges, and then call into WebCore::Page to do the heavy lifting (see WebCore ChangeLog for
more details). Additionally add a hard find-and-replace limit here to prevent the web process from spinning
indefinitely if there are an enormous number of find matches.

* WebProcess/WebPage/FindController.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findStringMatchesFromInjectedBundle):
(WebKit::WebPage::replaceStringMatchesFromInjectedBundle):

Add helpers to exercise find and replace in WebKit2.

(WebKit::WebPage::replaceMatches):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController setFindBarView:]):

Fix a bug in MiniBrowser that prevents AppKit from displaying the "All" button in the find bar after checking
the "Replace" option.

* TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:

Add an API test to exercise find-and-replace API using WKWebView.

(replaceMatches):
(TEST):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::findOptionsFromArray):

[webkit-changes] [238437] trunk

[sbarati]

Title: [238437] trunk








Revision 238437
Author sbar...@apple.com
Date 2018-11-21 19:43:30 -0800 (Wed, 21 Nov 2018)


Log Message
DFGSpeculativeJIT should not &= exitOK with mayExit(node)
https://bugs.webkit.org/show_bug.cgi?id=191897


Reviewed by Mark Lam.

JSTests:

* stress/exitok-is-not-the-same-as-mayExit.js: Added.
(bar):
(foo):

Source/_javascript_Core:

exitOK is a statement about it being legal to exit. mayExit() is about being
conservative and returning false only if an OSR exit *could never* happen.
mayExit() tries to be as smart as possible to see if it can return false.
It can't return false if a runtime exit *could* happen. However, there is
code in the compiler where mayExit() returns false (because it uses data
generated from AI about type checks being proved), but the code we emit in the
compiler backend unconditionally generates an OSR exit, even if that exit may
never execute. For example, let's say we have this IR:

SomeNode(Boolean:@input)

And we always emit code like this as a way of emitting a boolean type check:

jump L1 if input == true
jump L1 if input == false
emit an OSR exit

In such a program, when we generate the above OSR exit, in a validationEnabled()
build, and if @input is proved to be a boolean, we'll end up crashing because we
have the bogus assertion saying !exitOK. This is one reason why things are cleaner
if we don't conflate mayExit() with exitOK.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp


Added Paths

trunk/JSTests/stress/exitok-is-not-the-same-as-mayExit.js




Diff

Modified: trunk/JSTests/ChangeLog (238436 => 238437)

--- trunk/JSTests/ChangeLog	2018-11-22 03:39:54 UTC (rev 238436)
+++ trunk/JSTests/ChangeLog	2018-11-22 03:43:30 UTC (rev 238437)
@@ -1,5 +1,17 @@
 2018-11-21  Saam barati  
 
+DFGSpeculativeJIT should not &= exitOK with mayExit(node)
+https://bugs.webkit.org/show_bug.cgi?id=191897
+
+
+Reviewed by Mark Lam.
+
+* stress/exitok-is-not-the-same-as-mayExit.js: Added.
+(bar):
+(foo):
+
+2018-11-21  Saam barati  
+
 Fix assertion in KnownCellUse inside SpeculativeJIT::speculate
 https://bugs.webkit.org/show_bug.cgi?id=191895
 


Added: trunk/JSTests/stress/exitok-is-not-the-same-as-mayExit.js (0 => 238437)

--- trunk/JSTests/stress/exitok-is-not-the-same-as-mayExit.js	(rev 0)
+++ trunk/JSTests/stress/exitok-is-not-the-same-as-mayExit.js	2018-11-22 03:43:30 UTC (rev 238437)
@@ -0,0 +1,19 @@
+//@ runDefault("--useAccessInlining=0")
+
+function bar(ranges) {
+for (const [z] of ranges) {
+let ys = [];
+for (y = 0; y <= 10; y++) {
+ys[y] = false;
+}
+}
+}
+
+function foo() {
+let iterator = [][Symbol.iterator]();
+iterator.x = 1;
+}
+
+bar([ [], [], [], [], [], [], [], [], [], [], [] ]);
+foo();
+bar([ [], [] ]);


Modified: trunk/Source/_javascript_Core/ChangeLog (238436 => 238437)

--- trunk/Source/_javascript_Core/ChangeLog	2018-11-22 03:39:54 UTC (rev 238436)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-22 03:43:30 UTC (rev 238437)
@@ -1,5 +1,38 @@
 2018-11-21  Saam barati  
 
+DFGSpeculativeJIT should not &= exitOK with mayExit(node)
+https://bugs.webkit.org/show_bug.cgi?id=191897
+
+
+Reviewed by Mark Lam.
+
+exitOK is a statement about it being legal to exit. mayExit() is about being
+conservative and returning false only if an OSR exit *could never* happen.
+mayExit() tries to be as smart as possible to see if it can return false.
+It can't return false if a runtime exit *could* happen. However, there is
+code in the compiler where mayExit() returns false (because it uses data
+generated from AI about type checks being proved), but the code we emit in the
+compiler backend unconditionally generates an OSR exit, even if that exit may
+never execute. For example, let's say we have this IR:
+
+SomeNode(Boolean:@input)
+
+And we always emit code like this as a way of emitting a boolean type check:
+
+jump L1 if input == true
+jump L1 if input == false
+emit an OSR exit
+
+In such a program, when we generate the above OSR exit, in a validationEnabled()
+build, and if @input is proved to be a boolean, we'll end up crashing because we
+have the bogus assertion saying !exitOK. This is one reason why things are cleaner
+if we don't conflate mayExit() with exitOK.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
+
+2018-11-21  Saam barati  
+
 Fix assertion in KnownCellUse inside SpeculativeJIT::speculate
 https://bugs.webkit.org/show_bug.cgi?id=191895
 

[webkit-changes] [238436] trunk

[sbarati]

Title: [238436] trunk








Revision 238436
Author sbar...@apple.com
Date 2018-11-21 19:39:54 -0800 (Wed, 21 Nov 2018)


Log Message
Fix assertion in KnownCellUse inside SpeculativeJIT::speculate
https://bugs.webkit.org/show_bug.cgi?id=191895


Reviewed by Mark Lam.

JSTests:

* stress/known-cell-use-needs-type-check-assertion.js: Added.
(foo):
(bar):

Source/_javascript_Core:

We were asserting that the input edge should have type SpecCell but it should
really be SpecCellCheck since the type filter for KnownCellUse is SpecCellCheck.

This patch cleans up that assertion code by joining a bunch of cases into a
single function call which grabs the type filter for the edge UseKind and
asserts that the incoming edge meets the type filter criteria.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculate):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::speculate):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp


Added Paths

trunk/JSTests/stress/known-cell-use-needs-type-check-assertion.js




Diff

Modified: trunk/JSTests/ChangeLog (238435 => 238436)

--- trunk/JSTests/ChangeLog	2018-11-22 02:57:14 UTC (rev 238435)
+++ trunk/JSTests/ChangeLog	2018-11-22 03:39:54 UTC (rev 238436)
@@ -1,3 +1,15 @@
+2018-11-21  Saam barati  
+
+Fix assertion in KnownCellUse inside SpeculativeJIT::speculate
+https://bugs.webkit.org/show_bug.cgi?id=191895
+
+
+Reviewed by Mark Lam.
+
+* stress/known-cell-use-needs-type-check-assertion.js: Added.
+(foo):
+(bar):
+
 2018-11-21  Mark Lam  
 
 Creating a wasm memory that is bigger than the ArrayBuffer limit but smaller than the spec limit should throw OOME not RangeError.


Added: trunk/JSTests/stress/known-cell-use-needs-type-check-assertion.js (0 => 238436)

--- trunk/JSTests/stress/known-cell-use-needs-type-check-assertion.js	(rev 0)
+++ trunk/JSTests/stress/known-cell-use-needs-type-check-assertion.js	2018-11-22 03:39:54 UTC (rev 238436)
@@ -0,0 +1,14 @@
+//@ runDefault("--useTypeProfiler=1")
+
+function foo(z) {
+bar(z);
+}
+function bar(o) {
+o.x = 0;
+}
+let p = 0;
+let k = {};
+for (var i = 0; i < 10; ++i) {
+bar(p);
+foo(k);
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (238435 => 238436)

--- trunk/Source/_javascript_Core/ChangeLog	2018-11-22 02:57:14 UTC (rev 238435)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-22 03:39:54 UTC (rev 238436)
@@ -1,3 +1,23 @@
+2018-11-21  Saam barati  
+
+Fix assertion in KnownCellUse inside SpeculativeJIT::speculate
+https://bugs.webkit.org/show_bug.cgi?id=191895
+
+
+Reviewed by Mark Lam.
+
+We were asserting that the input edge should have type SpecCell but it should
+really be SpecCellCheck since the type filter for KnownCellUse is SpecCellCheck.
+
+This patch cleans up that assertion code by joining a bunch of cases into a
+single function call which grabs the type filter for the edge UseKind and
+asserts that the incoming edge meets the type filter criteria.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::speculate):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::speculate):
+
 2018-11-21  Yusuke Suzuki  
 
 [JSC] Use ProtoCallFrame::numberOfRegisters instead of raw number `4`


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (238435 => 238436)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-11-22 02:57:14 UTC (rev 238435)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-11-22 03:39:54 UTC (rev 238436)
@@ -10286,23 +10286,15 @@
 switch (edge.useKind()) {
 case UntypedUse:
 break;
-case KnownInt32Use:
-ASSERT(!needsTypeCheck(edge, SpecInt32Only));
-break;
 case DoubleRepUse:
-ASSERT(!needsTypeCheck(edge, SpecFullDouble));
-break;
 case Int52RepUse:
-ASSERT(!needsTypeCheck(edge, SpecAnyInt));
-break;
+case KnownInt32Use:
 case KnownCellUse:
-ASSERT(!needsTypeCheck(edge, SpecCell));
-break;
 case KnownStringUse:
-ASSERT(!needsTypeCheck(edge, SpecString));
-break;
 case KnownPrimitiveUse:
-ASSERT(!needsTypeCheck(edge, SpecHeapTop & ~SpecObject));
+case KnownOtherUse:
+case KnownBooleanUse:
+ASSERT(!m_interpreter.needsTypeCheck(edge));
 break;
 case Int32Use:
 speculateInt32(edge);
@@ -10327,9 +10319,6 @@
 case BooleanUse:
 speculateBoolean(edge);
 break;
-case KnownBooleanUse:
-ASSERT(!needsTypeCheck(edge, SpecBoolean));
-break;
 case CellUse:
 speculateCell(edge);
 break;
@@ -10405,9 +10394,6 @@
 case NotCellUse:
 

[webkit-changes] [238435] trunk/Source/JavaScriptCore

[yusukesuzuki]

Title: [238435] trunk/Source/_javascript_Core








Revision 238435
Author yusukesuz...@slowstart.org
Date 2018-11-21 18:57:14 -0800 (Wed, 21 Nov 2018)


Log Message
[JSC] Use ProtoCallFrame::numberOfRegisters instead of raw number `4`
https://bugs.webkit.org/show_bug.cgi?id=191877

Reviewed by Sam Weinig.

Instead of hard-coding `4` into LowLevelInterpreter, use ProtoCallFrame::numberOfRegisters.

* interpreter/ProtoCallFrame.h:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/ProtoCallFrame.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (238434 => 238435)

--- trunk/Source/_javascript_Core/ChangeLog	2018-11-22 02:12:04 UTC (rev 238434)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-22 02:57:14 UTC (rev 238435)
@@ -1,3 +1,16 @@
+2018-11-21  Yusuke Suzuki  
+
+[JSC] Use ProtoCallFrame::numberOfRegisters instead of raw number `4`
+https://bugs.webkit.org/show_bug.cgi?id=191877
+
+Reviewed by Sam Weinig.
+
+Instead of hard-coding `4` into LowLevelInterpreter, use ProtoCallFrame::numberOfRegisters.
+
+* interpreter/ProtoCallFrame.h:
+* llint/LowLevelInterpreter32_64.asm:
+* llint/LowLevelInterpreter64.asm:
+
 2018-11-21  Mark Lam  
 
 Creating a wasm memory that is bigger than the ArrayBuffer limit but smaller than the spec limit should throw OOME not RangeError.


Modified: trunk/Source/_javascript_Core/interpreter/ProtoCallFrame.h (238434 => 238435)

--- trunk/Source/_javascript_Core/interpreter/ProtoCallFrame.h	2018-11-22 02:12:04 UTC (rev 238434)
+++ trunk/Source/_javascript_Core/interpreter/ProtoCallFrame.h	2018-11-22 02:57:14 UTC (rev 238435)
@@ -35,6 +35,9 @@
 struct JS_EXPORT_PRIVATE ProtoCallFrame {
 WTF_FORBID_HEAP_ALLOCATION;
 public:
+// CodeBlock, Callee, ArgumentCount, and |this|.
+static constexpr unsigned numberOfRegisters { 4 };
+
 Register codeBlockValue;
 Register calleeValue;
 Register argCountAndCodeOriginValue;


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (238434 => 238435)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2018-11-22 02:12:04 UTC (rev 238434)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2018-11-22 02:57:14 UTC (rev 238435)
@@ -214,7 +214,7 @@
 
 .stackHeightOK:
 move t3, sp
-move 4, t3
+move (constexpr ProtoCallFrame::numberOfRegisters), t3
 
 .copyHeaderLoop:
 subi 1, t3


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (238434 => 238435)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2018-11-22 02:12:04 UTC (rev 238434)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm	2018-11-22 02:57:14 UTC (rev 238435)
@@ -201,7 +201,7 @@
 
 .stackHeightOK:
 move t3, sp
-move 4, t3
+move (constexpr ProtoCallFrame::numberOfRegisters), t3
 
 .copyHeaderLoop:
 # Copy the CodeBlock/Callee/ArgumentCount/|this| from protoCallFrame into the callee frame.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238434] trunk/Source

[aestes]

Title: [238434] trunk/Source








Revision 238434
Author aes...@apple.com
Date 2018-11-21 18:12:04 -0800 (Wed, 21 Nov 2018)


Log Message
[Cocoa] Create a soft-linking file for PassKit
https://bugs.webkit.org/show_bug.cgi?id=191875


Reviewed by Myles Maxfield.

Source/WebCore:

* Modules/applepay/cocoa/PaymentContactCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
* Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm: Ditto.
* SourcesCocoa.txt: Removed @no-unify from PaymentMerchantSessionCocoa.mm.
* WebCore.xcodeproj/project.pbxproj: Removed PaymentMerchantSessionCocoa.mm from the WebCore target.
* rendering/RenderThemeCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/PlatformMac.cmake:
* pal/cocoa/PassKitSoftLink.h: Added.
* pal/cocoa/PassKitSoftLink.mm: Added. Used _WITH_EXPORT soft-linking macros in order to
make the PAL soft-linking symbols visible to WebKit.
* pal/spi/cocoa/PassKitSPI.h:

Source/WebKit:

* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
* SourcesCocoa.txt: Removed @no-unify from WebPaymentCoordinatorProxyIOS.mm and WebPaymentCoordinatorProxyMac.mm.
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: Removed SOFT_LINK macros and included PassKitSoftLink.h instead.
* UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: Ditto.
* UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: Ditto.
* UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm: Included NSAttributedStringSPI.h.
* UIProcess/mac/WebProcessProxyMac.mm: Included ProcessPrivilege.h.
* WebKit.xcodeproj/project.pbxproj: Removed WebPaymentCoordinatorProxyIOS.mm and WebPaymentCoordinatorProxyMac.mm from the WebKit target.

Source/WTF:

* wtf/Platform.h: Defined USE_PASSKIT.
* wtf/cocoa/SoftLinking.h: Added _WITH_EXPORT variants of SOFT_LINK_FRAMEWORK_FOR_SOURCE,
SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE, SOFT_LINK_CLASS_FOR_SOURCE,
SOFT_LINK_FUNCTION_FOR_SOURCE, and SOFT_LINK_CONSTANT_FOR_SOURCE.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WTF/wtf/cocoa/SoftLinking.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm
trunk/Source/WebCore/Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/PAL/pal/PlatformMac.cmake
trunk/Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderThemeCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
trunk/Source/WebKit/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm
trunk/Source/WebKit/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm
trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm
trunk/Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h
trunk/Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (238433 => 238434)

--- trunk/Source/WTF/ChangeLog	2018-11-22 01:51:33 UTC (rev 238433)
+++ trunk/Source/WTF/ChangeLog	2018-11-22 02:12:04 UTC (rev 238434)
@@ -1,3 +1,16 @@
+2018-11-21  Andy Estes  
+
+[Cocoa] Create a soft-linking file for PassKit
+https://bugs.webkit.org/show_bug.cgi?id=191875
+
+
+Reviewed by Myles Maxfield.
+
+* wtf/Platform.h: Defined USE_PASSKIT.
+* wtf/cocoa/SoftLinking.h: Added _WITH_EXPORT variants of SOFT_LINK_FRAMEWORK_FOR_SOURCE,
+SOFT_LINK_PRIVATE_FRAMEWORK_FOR_SOURCE, SOFT_LINK_CLASS_FOR_SOURCE,
+SOFT_LINK_FUNCTION_FOR_SOURCE, and SOFT_LINK_CONSTANT_FOR_SOURCE.
+
 2018-11-21  Dominik Infuehr  
 
 Enable JIT on ARM/Linux


Modified: trunk/Source/WTF/wtf/Platform.h (238433 => 238434)

--- trunk/Source/WTF/wtf/Platform.h	2018-11-22 01:51:33 UTC (rev 238433)
+++ trunk/Source/WTF/wtf/Platform.h	2018-11-22 02:12:04 UTC (rev 238434)
@@ -616,9 +616,10 @@
 
 #if PLATFORM(MAC)
 
-#define USE_APPKIT 1
 #define HAVE_RUNLOOP_TIMER 1
 #define HAVE_SEC_KEYCHAIN 1
+#define USE_APPKIT 1
+#define USE_PASSKIT 1
 
 #if CPU(X86_64)
 #define HAVE_NETWORK_EXTENSION 1
@@ -1060,9 +1061,10 @@
 #endif
 
 #if PLATFORM(IOS)
+#define HAVE_APP_LINKS 1
+#define USE_PASSKIT 1
 #define USE_QUICK_LOOK 1
 #define USE_SYSTEM_PREVIEW 1
-#define HAVE_APP_LINKS 1
 #endif
 
 #if PLATFORM(IOS_FAMILY) && !PLATFORM(IOSMAC)


Modified: trunk/Source/WTF/wtf/cocoa/SoftLinking.h (238433 => 238434)

--- trunk/Source/WTF/wtf/cocoa/SoftLinking.h	2018-11-22 01:51:33 UTC (rev 238433)
+++ 

[webkit-changes] [238433] trunk

[mark . lam]

Title: [238433] trunk








Revision 238433
Author mark@apple.com
Date 2018-11-21 17:51:33 -0800 (Wed, 21 Nov 2018)


Log Message
Creating a wasm memory that is bigger than the ArrayBuffer limit but smaller than the spec limit should throw OOME not RangeError.
https://bugs.webkit.org/show_bug.cgi?id=191776


Reviewed by Saam Barati.

JSTests:

* stress/big-wasm-memory-grow-no-max.js:
* stress/big-wasm-memory-grow.js:
* stress/big-wasm-memory.js:
- updated these to expect an OutOfMemoryError.

* wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE-2.js: Added.
(Binary.prototype.emit_u8):
(Binary.prototype.emit_u32v):
(Binary.prototype.emit_header):
(Binary.prototype.emit_section):
(Binary):
(WasmModuleBuilder):
(WasmModuleBuilder.prototype.addMemory):
(WasmModuleBuilder.prototype.toArray):
(WasmModuleBuilder.prototype.toBuffer):
(WasmModuleBuilder.prototype.instantiate):
(catch):
* wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE.js: Added.
(catch):

Source/_javascript_Core:

* wasm/WasmMemory.cpp:
(JSC::Wasm::Memory::tryCreate):
- return nullptr if the requested bytes exceed MAX_ARRAY_BUFFER_SIZE.
  The clients will already do a null check and throw an OutOfMemoryError if needed.
(JSC::Wasm::Memory::grow):
- throw OOME if newPageCount.bytes() > MAX_ARRAY_BUFFER_SIZE.
* wasm/js/WebAssemblyMemoryConstructor.cpp:
(JSC::constructJSWebAssemblyMemory):
- throw OOME if newPageCount.bytes() > MAX_ARRAY_BUFFER_SIZE.

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/big-wasm-memory-grow-no-max.js
trunk/JSTests/stress/big-wasm-memory-grow.js
trunk/JSTests/stress/big-wasm-memory.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmMemory.cpp
trunk/Source/_javascript_Core/wasm/js/WebAssemblyMemoryConstructor.cpp


Added Paths

trunk/JSTests/wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE-2.js
trunk/JSTests/wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE.js




Diff

Modified: trunk/JSTests/ChangeLog (238432 => 238433)

--- trunk/JSTests/ChangeLog	2018-11-22 01:27:42 UTC (rev 238432)
+++ trunk/JSTests/ChangeLog	2018-11-22 01:51:33 UTC (rev 238433)
@@ -1,3 +1,31 @@
+2018-11-21  Mark Lam  
+
+Creating a wasm memory that is bigger than the ArrayBuffer limit but smaller than the spec limit should throw OOME not RangeError.
+https://bugs.webkit.org/show_bug.cgi?id=191776
+
+
+Reviewed by Saam Barati.
+
+* stress/big-wasm-memory-grow-no-max.js:
+* stress/big-wasm-memory-grow.js:
+* stress/big-wasm-memory.js:
+- updated these to expect an OutOfMemoryError.
+
+* wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE-2.js: Added.
+(Binary.prototype.emit_u8):
+(Binary.prototype.emit_u32v):
+(Binary.prototype.emit_header):
+(Binary.prototype.emit_section):
+(Binary):
+(WasmModuleBuilder):
+(WasmModuleBuilder.prototype.addMemory):
+(WasmModuleBuilder.prototype.toArray):
+(WasmModuleBuilder.prototype.toBuffer):
+(WasmModuleBuilder.prototype.instantiate):
+(catch):
+* wasm/regress/wasm-memory-requested-more-than-MAX_ARRAY_BUFFER_SIZE.js: Added.
+(catch):
+
 2018-11-21  Caio Lima  
 
 [BigInt] JSBigInt::createWithLength should throw when length is greater than JSBigInt::maxLength


Modified: trunk/JSTests/stress/big-wasm-memory-grow-no-max.js (238432 => 238433)

--- trunk/JSTests/stress/big-wasm-memory-grow-no-max.js	2018-11-22 01:27:42 UTC (rev 238432)
+++ trunk/JSTests/stress/big-wasm-memory-grow-no-max.js	2018-11-22 01:51:33 UTC (rev 238433)
@@ -26,7 +26,7 @@
 throw "Error: bad result at end: " + result;
 ok = true;
 } catch (e) {
-if (e.toString() != "RangeError: WebAssembly.Memory.grow expects the grown size to be a valid page count")
+if (e.toString() != "Error: Out of memory")
 throw e;
 }
 


Modified: trunk/JSTests/stress/big-wasm-memory-grow.js (238432 => 238433)

--- trunk/JSTests/stress/big-wasm-memory-grow.js	2018-11-22 01:27:42 UTC (rev 238432)
+++ trunk/JSTests/stress/big-wasm-memory-grow.js	2018-11-22 01:51:33 UTC (rev 238433)
@@ -26,7 +26,7 @@
 throw "Error: bad result at end: " + result;
 ok = true;
 } catch (e) {
-if (e.toString() != "RangeError: WebAssembly.Memory.grow expects the grown size to be a valid page count")
+if (e.toString() != "Error: Out of memory")
 throw e;
 }
 


Modified: trunk/JSTests/stress/big-wasm-memory.js (238432 => 238433)

--- trunk/JSTests/stress/big-wasm-memory.js	2018-11-22 01:27:42 UTC (rev 238432)
+++ trunk/JSTests/stress/big-wasm-memory.js	2018-11-22 01:51:33 UTC (rev 238433)
@@ -24,7 +24,7 @@
 throw "Error: bad result at end: " + result;
 ok = true;
 } catch (e) {
-if (e.toString() != "RangeError: WebAssembly.Memory 'initial' page count is too large")
+if (e.toString() != "Error: Out of memory")
  

[webkit-changes] [238432] trunk/Source/WebKit

[Hironori . Fujii]

Title: [238432] trunk/Source/WebKit








Revision 238432
Author hironori.fu...@sony.com
Date 2018-11-21 17:27:42 -0800 (Wed, 21 Nov 2018)


Log Message
Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
https://bugs.webkit.org/show_bug.cgi?id=191853

Reviewed by Michael Catanzaro.

In r235845, I excluded InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp from unify source builds in order to
work around a MSVC bug.

Then, I commited a different workaround for the MSVC bug in
r238386. Now, we can include InjectedBundleRangeHandle.cpp and
InjectedBundleNodeHandle.cpp in unified source builds. Revert
r235845.

* Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp
and InjectedBundleNodeHandle.cpp
* WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership
not to be compiled by XCode.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit/ChangeLog (238431 => 238432)

--- trunk/Source/WebKit/ChangeLog	2018-11-21 23:25:13 UTC (rev 238431)
+++ trunk/Source/WebKit/ChangeLog	2018-11-22 01:27:42 UTC (rev 238432)
@@ -1,3 +1,24 @@
+2018-11-21  Fujii Hironori  
+
+Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp
+https://bugs.webkit.org/show_bug.cgi?id=191853
+
+Reviewed by Michael Catanzaro.
+
+In r235845, I excluded InjectedBundleRangeHandle.cpp and
+InjectedBundleNodeHandle.cpp from unify source builds in order to
+work around a MSVC bug.
+
+Then, I commited a different workaround for the MSVC bug in
+r238386. Now, we can include InjectedBundleRangeHandle.cpp and
+InjectedBundleNodeHandle.cpp in unified source builds. Revert
+r235845.
+
+* Sources.txt: Removed @no-unify of InjectedBundleRangeHandle.cpp
+and InjectedBundleNodeHandle.cpp
+* WebKit.xcodeproj/project.pbxproj: Unchecked Target Membership
+not to be compiled by XCode.
+
 2018-11-20  Jeff Miller  
 
 Return nullptr immediately if the key doesn't exist in the HashMap.


Modified: trunk/Source/WebKit/Sources.txt (238431 => 238432)

--- trunk/Source/WebKit/Sources.txt	2018-11-21 23:25:13 UTC (rev 238431)
+++ trunk/Source/WebKit/Sources.txt	2018-11-22 01:27:42 UTC (rev 238432)
@@ -456,8 +456,8 @@
 WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp
 
 WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp
-WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp @no-unify
-WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp @no-unify
+WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
+WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp
 
 WebProcess/MediaStream/MediaDeviceSandboxExtensions.cpp
 WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (238431 => 238432)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2018-11-21 23:25:13 UTC (rev 238431)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2018-11-22 01:27:42 UTC (rev 238432)
@@ -412,8 +412,6 @@
 		26F10BE819187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F10BE619187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.h */; };
 		26F10BE919187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.m in Sources */ = {isa = PBXBuildFile; fileRef = 26F10BE719187E2E001D0E68 /* WKSyntheticClickTapGestureRecognizer.m */; };
 		26F9A83B18A3468100AEB88A /* WKWebViewPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F9A83A18A3463F00AEB88A /* WKWebViewPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		2749F6442146561B008380BF /* InjectedBundleNodeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC4BEEAA120A0A5F00FBA0C7 /* InjectedBundleNodeHandle.cpp */; };
-		2749F6452146561E008380BF /* InjectedBundleRangeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC33E0D012408E8600360F3F /* InjectedBundleRangeHandle.cpp */; };
 		290F4272172A0C7400939FF0 /* ChildProcessSupplement.h in Headers */ = {isa = PBXBuildFile; fileRef = 290F4271172A0C7400939FF0 /* ChildProcessSupplement.h */; };
 		29232DF418B29D6800D0596F /* WKAccessibilityWebPageObjectMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 29232DF318B29D6800D0596F /* WKAccessibilityWebPageObjectMac.h */; };
 		293EBEAB1627D9C9005F89F1 /* WKDOMText.h in Headers */ = {isa = PBXBuildFile; fileRef = 293EBEA91627D9C9005F89F1 /* WKDOMText.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -10719,8 +10717,6 @@
 1A64230812DD09EB00CAAE2C /* DrawingAreaProxyMessageReceiver.cpp in Sources */,
 2D92A780212B6A7100F493FD /* Encoder.cpp in Sources */,
 1AA576021496B97900A4EE06 /* EventDispatcherMessageReceiver.cpp in Sources */,
-2749F6442146561B008380BF /* InjectedBundleNodeHandle.cpp in Sources */,
-

[webkit-changes] [238431] trunk/Source/WebCore

[zalan]

Title: [238431] trunk/Source/WebCore








Revision 238431
Author za...@apple.com
Date 2018-11-21 15:25:13 -0800 (Wed, 21 Nov 2018)


Log Message
[LFC] LayoutState should always be initialized with the initial containing block.
https://bugs.webkit.org/show_bug.cgi?id=191896

Reviewed by Antti Koivisto.

There should always be only one LayoutState per layout tree (it does not mean that layout always starts at the ICB).
The ICB is a special formatting context root because it does not have a parent formatting context. All the other formatting contexts
first need to be laid out (partially at least e.g margin) in their parent formatting context.
Having a non-null parent formatting context as root could lead to undefined behaviour.

* layout/LayoutFormattingState.cpp:
(WebCore::Layout::LayoutState::LayoutState):
(WebCore::Layout::LayoutState::initializeRoot): Deleted.
* layout/LayoutFormattingState.h:
* layout/Verification.cpp:
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):
* page/FrameViewLayoutContext.cpp:
(WebCore::layoutUsingFormattingContext):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/LayoutFormattingState.cpp
trunk/Source/WebCore/layout/LayoutFormattingState.h
trunk/Source/WebCore/layout/Verification.cpp
trunk/Source/WebCore/page/FrameViewLayoutContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238430 => 238431)

--- trunk/Source/WebCore/ChangeLog	2018-11-21 23:13:22 UTC (rev 238430)
+++ trunk/Source/WebCore/ChangeLog	2018-11-21 23:25:13 UTC (rev 238431)
@@ -1,5 +1,26 @@
 2018-11-21  Zalan Bujtas  
 
+[LFC] LayoutState should always be initialized with the initial containing block.
+https://bugs.webkit.org/show_bug.cgi?id=191896
+
+Reviewed by Antti Koivisto.
+
+There should always be only one LayoutState per layout tree (it does not mean that layout always starts at the ICB).
+The ICB is a special formatting context root because it does not have a parent formatting context. All the other formatting contexts
+first need to be laid out (partially at least e.g margin) in their parent formatting context.
+Having a non-null parent formatting context as root could lead to undefined behaviour.
+
+* layout/LayoutFormattingState.cpp:
+(WebCore::Layout::LayoutState::LayoutState):
+(WebCore::Layout::LayoutState::initializeRoot): Deleted.
+* layout/LayoutFormattingState.h:
+* layout/Verification.cpp:
+(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):
+* page/FrameViewLayoutContext.cpp:
+(WebCore::layoutUsingFormattingContext):
+
+2018-11-21  Zalan Bujtas  
+
 [LFC][IFC] Horizontal margins should be considered as non-breakable space
 https://bugs.webkit.org/show_bug.cgi?id=191894
 


Modified: trunk/Source/WebCore/layout/LayoutFormattingState.cpp (238430 => 238431)

--- trunk/Source/WebCore/layout/LayoutFormattingState.cpp	2018-11-21 23:13:22 UTC (rev 238430)
+++ trunk/Source/WebCore/layout/LayoutFormattingState.cpp	2018-11-21 23:25:13 UTC (rev 238431)
@@ -45,18 +45,14 @@
 
 WTF_MAKE_ISO_ALLOCATED_IMPL(LayoutState);
 
-LayoutState::LayoutState()
+LayoutState::LayoutState(const Container& initialContainingBlock, const LayoutSize& containerSize)
+: m_initialContainingBlock(makeWeakPtr(initialContainingBlock))
 {
-}
+// LayoutState is always initiated with the ICB.
+ASSERT(!initialContainingBlock.parent());
+ASSERT(initialContainingBlock.establishesBlockFormattingContext());
 
-void LayoutState::initializeRoot(const Container& root, const LayoutSize& containerSize)
-{
-ASSERT(root.establishesFormattingContext());
-
-m_root = makeWeakPtr(root);
-auto& displayBox = displayBoxForLayoutBox(root);
-
-// FIXME: m_root could very well be a formatting context root with ancestors and resolvable border and padding (as opposed to the topmost root)
+auto& displayBox = displayBoxForLayoutBox(initialContainingBlock);
 displayBox.setHorizontalMargin({ });
 displayBox.setHorizontalNonComputedMargin({ });
 displayBox.setVerticalMargin({ });
@@ -63,11 +59,11 @@
 displayBox.setVerticalNonCollapsedMargin({ });
 displayBox.setBorder({ });
 displayBox.setPadding({ });
+displayBox.setTopLeft({ });
 displayBox.setContentBoxHeight(containerSize.height());
 displayBox.setContentBoxWidth(containerSize.width());
-displayBox.setTopLeft({ });
 
-m_formattingContextRootListForLayout.add();
+m_formattingContextRootListForLayout.add();
 }
 
 void LayoutState::updateLayout()


Modified: trunk/Source/WebCore/layout/LayoutFormattingState.h (238430 => 238431)

--- trunk/Source/WebCore/layout/LayoutFormattingState.h	2018-11-21 23:13:22 UTC (rev 238430)
+++ trunk/Source/WebCore/layout/LayoutFormattingState.h	2018-11-21 23:25:13 UTC (rev 238431)
@@ -49,9 +49,9 @@
 class Container;
 class FormattingState;
 
-// LayoutState is the entry point 

[webkit-changes] [238430] trunk

[zalan]

Title: [238430] trunk








Revision 238430
Author za...@apple.com
Date 2018-11-21 15:13:22 -0800 (Wed, 21 Nov 2018)


Log Message
[LFC][IFC] Horizontal margins should be considered as non-breakable space
https://bugs.webkit.org/show_bug.cgi?id=191894

Reviewed by Antti Koivisto.

Source/WebCore:

Like padding and border, horizontal margins also force run breaks and offset them.

Test: fast/inline/inline-content-with-margin-left-right.html

* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/inline/inline-content-with-margin-left-right-expected.txt: Added.
* fast/inline/inline-content-with-margin-left-right.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt


Added Paths

trunk/LayoutTests/fast/inline/inline-content-with-margin-left-right-expected.txt
trunk/LayoutTests/fast/inline/inline-content-with-margin-left-right.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238429 => 238430)

--- trunk/LayoutTests/ChangeLog	2018-11-21 21:33:48 UTC (rev 238429)
+++ trunk/LayoutTests/ChangeLog	2018-11-21 23:13:22 UTC (rev 238430)
@@ -1,3 +1,13 @@
+2018-11-21  Zalan Bujtas  
+
+[LFC][IFC] Horizontal margins should be considered as non-breakable space
+https://bugs.webkit.org/show_bug.cgi?id=191894
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/inline-content-with-margin-left-right-expected.txt: Added.
+* fast/inline/inline-content-with-margin-left-right.html: Added.
+
 2018-11-21  Ryosuke Niwa  
 
 Mutation observers doesn't get notified of character data mutation made by the parser


Added: trunk/LayoutTests/fast/inline/inline-content-with-margin-left-right-expected.txt (0 => 238430)

--- trunk/LayoutTests/fast/inline/inline-content-with-margin-left-right-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/inline/inline-content-with-margin-left-right-expected.txt	2018-11-21 23:13:22 UTC (rev 238430)
@@ -0,0 +1,225 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+layer at (8,8) size 402x22 clip at (9,9) size 400x20
+  RenderBlock {DIV} at (0,0) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 6x14
+  RenderText {#text} at (17,1) size 6x14
+text run at (17,1) width 6: "2"
+RenderText {#text} at (33,1) size 6x14
+  text run at (33,1) width 6: "3"
+layer at (8,30) size 402x22 clip at (9,31) size 400x20
+  RenderBlock {DIV} at (0,22) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 6x14
+  RenderText {#text} at (17,1) size 6x14
+text run at (17,1) width 6: "2"
+RenderText {#text} at (23,1) size 6x14
+  text run at (23,1) width 6: "3"
+layer at (8,52) size 402x22 clip at (9,53) size 400x20
+  RenderBlock {DIV} at (0,44) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 6x14
+  RenderText {#text} at (7,1) size 6x14
+text run at (7,1) width 6: "2"
+RenderText {#text} at (23,1) size 6x14
+  text run at (23,1) width 6: "3"
+layer at (8,74) size 402x22 clip at (9,75) size 400x20
+  RenderBlock {DIV} at (0,66) size 402x22 [border: (1px solid #008000)]
+RenderInline {SPAN} at (0,0) size 6x14
+  RenderText {#text} at (11,1) size 6x14
+text run at (11,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 6x14
+  RenderText {#text} at (27,1) size 6x14
+text run at (27,1) width 6: "2"
+RenderInline {SPAN} at (0,0) size 6x14
+  RenderText {#text} at (43,1) size 6x14
+text run at (43,1) width 6: "3"
+layer at (8,96) size 402x22 clip at (9,97) size 400x20
+  RenderBlock {DIV} at (0,88) size 402x22 [border: (1px solid #008000)]
+RenderInline {SPAN} at (0,0) size 36x14
+  RenderInline {SPAN} at (0,0) size 26x14
+RenderInline {SPAN} at (0,0) size 6x14
+  RenderText {#text} at (21,1) size 6x14
+text run at (21,1) width 6: "1"
+layer at (8,118) size 402x22 clip at (9,119) size 400x20
+  RenderBlock {DIV} at (0,110) size 402x22 [border: (1px solid #008000)]
+RenderInline {SPAN} at (0,0) size 36x14
+  RenderInline {SPAN} at (0,0) size 26x14
+RenderInline {SPAN} at (0,0) size 6x14
+  RenderText {#text} at (21,1) size 6x14
+text run at (21,1) width 6: "1"
+layer at (8,140) size 402x22 

[webkit-changes] [238429] trunk

[rniwa]

Title: [238429] trunk








Revision 238429
Author rn...@webkit.org
Date 2018-11-21 13:33:48 -0800 (Wed, 21 Nov 2018)


Log Message
Mutation observers doesn't get notified of character data mutation made by the parser
https://bugs.webkit.org/show_bug.cgi?id=191874

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed the bug that CharacterData::parserAppendData was never notifying MutationObserver.

Test: fast/dom/MutationObserver/observe-parser-character-data-change.html

* dom/CharacterData.cpp:
(WebCore::CharacterData::parserAppendData):

LayoutTests:

Added a regression test.

* fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt: Added.
* fast/dom/MutationObserver/observe-parser-character-data-change.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/CharacterData.cpp


Added Paths

trunk/LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt
trunk/LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238428 => 238429)

--- trunk/LayoutTests/ChangeLog	2018-11-21 19:10:49 UTC (rev 238428)
+++ trunk/LayoutTests/ChangeLog	2018-11-21 21:33:48 UTC (rev 238429)
@@ -1,3 +1,15 @@
+2018-11-21  Ryosuke Niwa  
+
+Mutation observers doesn't get notified of character data mutation made by the parser
+https://bugs.webkit.org/show_bug.cgi?id=191874
+
+Reviewed by Antti Koivisto.
+
+Added a regression test.
+
+* fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt: Added.
+* fast/dom/MutationObserver/observe-parser-character-data-change.html: Added.
+
 2018-11-21  Zalan Bujtas 
 
 [LFC][IFC] Border should be considered as non-breakable space


Added: trunk/LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt (0 => 238429)

--- trunk/LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change-expected.txt	2018-11-21 21:33:48 UTC (rev 238429)
@@ -0,0 +1,4 @@
+This tests observing the character data change by the HTML parser.
+
+PASS
+ab


Added: trunk/LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change.html (0 => 238429)

--- trunk/LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/MutationObserver/observe-parser-character-data-change.html	2018-11-21 21:33:48 UTC (rev 238429)
@@ -0,0 +1,37 @@
+
+
+
+This tests observing the character data change by the HTML parser.
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+const log = document.getElementById('log');
+
+document.write('a');
+let observer = new MutationObserver((mutations) => {
+let result = 'PASS';
+if (mutations.length != 1)
+result = `FAIL - expected 1 mutation record but got ${mutations.length}`;
+else if (mutations[0].type != 'characterData')
+result = `FAIL - expected characterData mutation record but got ${mutations[0].type}`;
+else if (mutations[0].oldValue != 'a')
+result = `FAIL - expected oldValue to be "a" but got "${mutations[0].oldValue}"`;
+log.textContent = result;
+});
+observer.observe(document.getElementById('parent'), {childList: true, subtree: true, characterData: true, characterDataOldValue: true});
+document.write('b');
+
+function fail() {
+if (!log.textContent)
+log.textContent = 'FAIL - did not receive a mutation record in time';
+}
+
+Promise.resolve().then(fail);
+window._onload_ = () => fail;
+
+
+
+
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (238428 => 238429)

--- trunk/Source/WebCore/ChangeLog	2018-11-21 19:10:49 UTC (rev 238428)
+++ trunk/Source/WebCore/ChangeLog	2018-11-21 21:33:48 UTC (rev 238429)
@@ -1,3 +1,17 @@
+2018-11-20  Ryosuke Niwa  
+
+Mutation observers doesn't get notified of character data mutation made by the parser
+https://bugs.webkit.org/show_bug.cgi?id=191874
+
+Reviewed by Antti Koivisto.
+
+Fixed the bug that CharacterData::parserAppendData was never notifying MutationObserver.
+
+Test: fast/dom/MutationObserver/observe-parser-character-data-change.html
+
+* dom/CharacterData.cpp:
+(WebCore::CharacterData::parserAppendData):
+
 2018-11-21  Claudio Saavedra  
 
 [SOUP] Follow-up robustness improvements to the certificate decoder


Modified: trunk/Source/WebCore/dom/CharacterData.cpp (238428 => 238429)

--- trunk/Source/WebCore/dom/CharacterData.cpp	2018-11-21 19:10:49 UTC (rev 238428)
+++ trunk/Source/WebCore/dom/CharacterData.cpp	2018-11-21 21:33:48 UTC (rev 238429)
@@ -96,6 +96,7 @@
 if (!characterLengthLimit)
 return 0;
 
+String oldData = m_data;
 if (string.is8Bit())
  

[webkit-changes] [238428] releases/WPE WebKit/webkit-2.22.2/

[aperez]

Title: [238428] releases/WPE WebKit/webkit-2.22.2/








Revision 238428
Author ape...@igalia.com
Date 2018-11-21 11:10:49 -0800 (Wed, 21 Nov 2018)


Log Message
WPE WebKit release 2.22.2

Added Paths

releases/WPE WebKit/webkit-2.22.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238427] releases/WebKitGTK/webkit-2.22

[aperez]

Title: [238427] releases/WebKitGTK/webkit-2.22








Revision 238427
Author ape...@igalia.com
Date 2018-11-21 11:09:35 -0800 (Wed, 21 Nov 2018)


Log Message
Unreviewed. Update OptionsWPE.cmake and NEWS for 2.22.2 release.

.:

* Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

* wpe/NEWS: Add release notes for 2.22.2.

Modified Paths

releases/WebKitGTK/webkit-2.22/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/wpe/NEWS
releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsWPE.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.22/ChangeLog (238426 => 238427)

--- releases/WebKitGTK/webkit-2.22/ChangeLog	2018-11-21 18:58:13 UTC (rev 238426)
+++ releases/WebKitGTK/webkit-2.22/ChangeLog	2018-11-21 19:09:35 UTC (rev 238427)
@@ -1,5 +1,11 @@
 2018-11-21  Adrian Perez de Castro  
 
+Unreviewed. Update OptionsWPE.cmake and NEWS for 2.22.2 release.
+
+* Source/cmake/OptionsWPE.cmake: Bump version numbers.
+
+2018-11-21  Adrian Perez de Castro  
+
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.4 release.
 
 * Source/cmake/OptionsGTK.cmake: Bump version numbers.


Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog (238426 => 238427)

--- releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog	2018-11-21 18:58:13 UTC (rev 238426)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog	2018-11-21 19:09:35 UTC (rev 238427)
@@ -1,5 +1,11 @@
 2018-11-21  Adrian Perez de Castro  
 
+Unreviewed. Update OptionsWPE.cmake and NEWS for 2.22.2 release.
+
+* wpe/NEWS: Add release notes for 2.22.2.
+
+2018-11-21  Adrian Perez de Castro  
+
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.4 release.
 
 * gtk/NEWS: Add release notes for 2.22.4.


Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/wpe/NEWS (238426 => 238427)

--- releases/WebKitGTK/webkit-2.22/Source/WebKit/wpe/NEWS	2018-11-21 18:58:13 UTC (rev 238426)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/wpe/NEWS	2018-11-21 19:09:35 UTC (rev 238427)
@@ -1,4 +1,14 @@
 =
+WPE WebKit 2.22.2
+=
+
+What's new in WPE WebKit 2.22.2?
+
+  - Fix a crash when using Cairo versions between 1.15 and 1.16.0
+  - Fix the build with -DLOG_DISABLED=0.
+  - Fix several crashes and rendering issues.
+
+=
 WPE WebKit 2.22.1
 =
 


Modified: releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsWPE.cmake (238426 => 238427)

--- releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsWPE.cmake	2018-11-21 18:58:13 UTC (rev 238426)
+++ releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsWPE.cmake	2018-11-21 19:09:35 UTC (rev 238427)
@@ -1,10 +1,10 @@
 include(GNUInstallDirs)
 include(VersioningUtils)
 
-SET_PROJECT_VERSION(2 22 1)
+SET_PROJECT_VERSION(2 22 2)
 set(WPE_API_VERSION 0.1)
 
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 4 2 2)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 4 3 2)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238426] trunk/Source/WebCore

[csaavedra]

Title: [238426] trunk/Source/WebCore








Revision 238426
Author csaave...@igalia.com
Date 2018-11-21 10:58:13 -0800 (Wed, 21 Nov 2018)


Log Message
[SOUP] Follow-up robustness improvements to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=191892

Reviewed by Michael Catanzaro.

If at any point the certificate fails to be constructed from
the DER data, bail out. Likewise, if the certificate returned
is NULL, return false from the decoder to notify the failure
to decode it.

* platform/network/soup/CertificateInfo.h:
(WTF::Persistence::certificateFromCertificatesDataList):
(WTF::Persistence::Coder::decode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/CertificateInfo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238425 => 238426)

--- trunk/Source/WebCore/ChangeLog	2018-11-21 18:38:11 UTC (rev 238425)
+++ trunk/Source/WebCore/ChangeLog	2018-11-21 18:58:13 UTC (rev 238426)
@@ -1,3 +1,19 @@
+2018-11-21  Claudio Saavedra  
+
+[SOUP] Follow-up robustness improvements to the certificate decoder
+https://bugs.webkit.org/show_bug.cgi?id=191892
+
+Reviewed by Michael Catanzaro.
+
+If at any point the certificate fails to be constructed from
+the DER data, bail out. Likewise, if the certificate returned
+is NULL, return false from the decoder to notify the failure
+to decode it.
+
+* platform/network/soup/CertificateInfo.h:
+(WTF::Persistence::certificateFromCertificatesDataList):
+(WTF::Persistence::Coder::decode):
+
 2018-11-21  Zalan Bujtas  
 
 [LFC][IFC] Border should be considered as non-breakable space


Modified: trunk/Source/WebCore/platform/network/soup/CertificateInfo.h (238425 => 238426)

--- trunk/Source/WebCore/platform/network/soup/CertificateInfo.h	2018-11-21 18:38:11 UTC (rev 238425)
+++ trunk/Source/WebCore/platform/network/soup/CertificateInfo.h	2018-11-21 18:58:13 UTC (rev 238426)
@@ -119,6 +119,8 @@
 for (auto& certificateData : certificatesDataList) {
 certificate = adoptGRef(G_TLS_CERTIFICATE(g_initable_new(
 certificateType, nullptr, nullptr, "certificate", certificateData.get(), "issuer", certificate.get(), nullptr)));
+if (!certificate)
+break;
 }
 
 return certificate;
@@ -145,7 +147,10 @@
 
 if (certificatesDataList.isEmpty())
 return true;
-certificateInfo.setCertificate(certificateFromCertificatesDataList(certificatesDataList).get());
+auto certificate = certificateFromCertificatesDataList(certificatesDataList);
+if (!certificate)
+return false;
+certificateInfo.setCertificate(certificate.get());
 
 uint32_t tlsErrors;
 if (!decoder.decode(tlsErrors))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238424] releases/WebKitGTK/webkit-2.22.4/

[aperez]

Title: [238424] releases/WebKitGTK/webkit-2.22.4/








Revision 238424
Author ape...@igalia.com
Date 2018-11-21 10:10:17 -0800 (Wed, 21 Nov 2018)


Log Message
WebKitGTK release 2.22.4

Added Paths

releases/WebKitGTK/webkit-2.22.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238423] releases/WebKitGTK/webkit-2.22

[aperez]

Title: [238423] releases/WebKitGTK/webkit-2.22








Revision 238423
Author ape...@igalia.com
Date 2018-11-21 10:08:04 -0800 (Wed, 21 Nov 2018)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.4 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.22.4.

Modified Paths

releases/WebKitGTK/webkit-2.22/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.22/ChangeLog (238422 => 238423)

--- releases/WebKitGTK/webkit-2.22/ChangeLog	2018-11-21 17:38:08 UTC (rev 238422)
+++ releases/WebKitGTK/webkit-2.22/ChangeLog	2018-11-21 18:08:04 UTC (rev 238423)
@@ -1,3 +1,9 @@
+2018-11-21  Adrian Perez de Castro  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.4 release.
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2018-11-06  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for 2.22.1 release.


Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog (238422 => 238423)

--- releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog	2018-11-21 17:38:08 UTC (rev 238422)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/ChangeLog	2018-11-21 18:08:04 UTC (rev 238423)
@@ -1,3 +1,9 @@
+2018-11-21  Adrian Perez de Castro  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.22.4 release.
+
+* gtk/NEWS: Add release notes for 2.22.4.
+
 2018-11-06  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for 2.22.1 release.


Modified: releases/WebKitGTK/webkit-2.22/Source/WebKit/gtk/NEWS (238422 => 238423)

--- releases/WebKitGTK/webkit-2.22/Source/WebKit/gtk/NEWS	2018-11-21 17:38:08 UTC (rev 238422)
+++ releases/WebKitGTK/webkit-2.22/Source/WebKit/gtk/NEWS	2018-11-21 18:08:04 UTC (rev 238423)
@@ -1,4 +1,17 @@
 =
+WebKitGTK+ 2.22.4
+=
+
+What's new in WebKitGTK+ 2.22.4?
+
+  - Expose ENABLE_MEDIA_SOURCE as a public build option.
+  - Fix a crash when using Cairo versions between 1.15 and 1.16.0
+  - Fix the build with -DLOG_DISABLED=0.
+  - Fix the build with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF.
+  - Fix debug builds of _javascript_Core.
+  - Fix several crashes and rendering issues.
+
+=
 WebKitGTK+ 2.22.3
 =
 


Modified: releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsGTK.cmake (238422 => 238423)

--- releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsGTK.cmake	2018-11-21 17:38:08 UTC (rev 238422)
+++ releases/WebKitGTK/webkit-2.22/Source/cmake/OptionsGTK.cmake	2018-11-21 18:08:04 UTC (rev 238423)
@@ -1,11 +1,11 @@
 include(GNUInstallDirs)
 include(VersioningUtils)
 
-SET_PROJECT_VERSION(2 22 3)
+SET_PROJECT_VERSION(2 22 4)
 set(WEBKITGTK_API_VERSION 4.0)
 
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 70 4 33)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 29 4 11)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 70 5 33)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 29 5 11)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238422] trunk

[zalan]

Title: [238422] trunk








Revision 238422
Author za...@apple.com
Date 2018-11-21 09:38:08 -0800 (Wed, 21 Nov 2018)


Log Message
[LFC][IFC] Border should be considered as non-breakable space
https://bugs.webkit.org/show_bug.cgi?id=191891

Reviewed by Antti Koivisto.

Source/WebCore:

Like padding, border also forces run breaks and offsets them.

Test: fast/inline/inline-content-with-border-left-right.html

* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::collectInlineContentForSubtree const):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/inline/inline-content-with-border-left-right-expected.txt: Added.
* fast/inline/inline-content-with-border-left-right.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt


Added Paths

trunk/LayoutTests/fast/inline/inline-content-with-border-left-right-expected.txt
trunk/LayoutTests/fast/inline/inline-content-with-border-left-right.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238421 => 238422)

--- trunk/LayoutTests/ChangeLog	2018-11-21 17:37:54 UTC (rev 238421)
+++ trunk/LayoutTests/ChangeLog	2018-11-21 17:38:08 UTC (rev 238422)
@@ -1,3 +1,13 @@
+2018-11-21  Zalan Bujtas 
+
+[LFC][IFC] Border should be considered as non-breakable space
+https://bugs.webkit.org/show_bug.cgi?id=191891
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/inline-content-with-border-left-right-expected.txt: Added.
+* fast/inline/inline-content-with-border-left-right.html: Added.
+
 2018-11-21  Alicia Boya García  
 
 [GTK] Unreviewed test gardening


Added: trunk/LayoutTests/fast/inline/inline-content-with-border-left-right-expected.txt (0 => 238422)

--- trunk/LayoutTests/fast/inline/inline-content-with-border-left-right-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/inline/inline-content-with-border-left-right-expected.txt	2018-11-21 17:38:08 UTC (rev 238422)
@@ -0,0 +1,225 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+layer at (8,8) size 402x22 clip at (9,9) size 400x20 scrollHeight 24
+  RenderBlock {DIV} at (0,0) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 26x34 [border: (10px solid #FF)]
+  RenderText {#text} at (17,1) size 6x14
+text run at (17,1) width 6: "2"
+RenderText {#text} at (33,1) size 6x14
+  text run at (33,1) width 6: "3"
+layer at (8,30) size 402x22 clip at (9,31) size 400x20
+  RenderBlock {DIV} at (0,22) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 16x14 [border: none (10px solid #008000)]
+  RenderText {#text} at (17,1) size 6x14
+text run at (17,1) width 6: "2"
+RenderText {#text} at (23,1) size 6x14
+  text run at (23,1) width 6: "3"
+layer at (8,52) size 402x22 clip at (9,53) size 400x20
+  RenderBlock {DIV} at (0,44) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 16x14 [border: none (10px solid #FF) none]
+  RenderText {#text} at (7,1) size 6x14
+text run at (7,1) width 6: "2"
+RenderText {#text} at (23,1) size 6x14
+  text run at (23,1) width 6: "3"
+layer at (8,74) size 402x22 clip at (9,75) size 400x20 scrollHeight 24
+  RenderBlock {DIV} at (0,66) size 402x22 [border: (1px solid #008000)]
+RenderInline {SPAN} at (0,0) size 16x14 [border: none (10px solid #008000)]
+  RenderText {#text} at (11,1) size 6x14
+text run at (11,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 26x34 [border: (10px solid #FF)]
+  RenderText {#text} at (27,1) size 6x14
+text run at (27,1) width 6: "2"
+RenderInline {SPAN} at (0,0) size 16x14 [border: none (10px solid #FF) none]
+  RenderText {#text} at (43,1) size 6x14
+text run at (43,1) width 6: "3"
+layer at (8,96) size 402x22 clip at (9,97) size 400x20 scrollHeight 24
+  RenderBlock {DIV} at (0,88) size 402x22 [border: (1px solid #008000)]
+RenderInline {SPAN} at (0,0) size 46x14 [border: none (10px solid #008000)]
+  RenderInline {SPAN} at (0,0) size 36x14 [border: none (10px solid #FF) none]
+RenderInline {SPAN} at (0,0) size 26x34 [border: (10px solid #FF)]
+  RenderText {#text} at (21,1) size 6x14
+text run at (21,1) width 6: "1"
+layer at (8,118) size 402x22 clip at (9,119) size 400x20 scrollHeight 24
+  RenderBlock {DIV} at (0,110) size 

[webkit-changes] [238421] trunk

[mark . lam]

Title: [238421] trunk








Revision 238421
Author mark@apple.com
Date 2018-11-21 09:37:54 -0800 (Wed, 21 Nov 2018)


Log Message
Remove invalid assertion in VMTraps::SignalSender's SignalAction.
https://bugs.webkit.org/show_bug.cgi?id=191856


Reviewed by Yusuke Suzuki.

JSTests:

* stress/regress-191856.js: Added.
- this test is skipped for now until we have a fix for webkit.org/b/191855.

Source/_javascript_Core:

The ASSERT(vm.traps().needTrapHandling()) assertion in SignalSender's SigAction
function is invalid because we can't be sure that the trap has been handled yet
by the time the trap fires.  This is because the main thread may also check traps
(in LLInt, baseline JIT and VM runtime code).  There's a race to handle the trap.
Hence, the SigAction cannot assume that the trap still needs handling by the time
it is executed.  This patch removed the invalid assertion.

Also renamed m_trapSet to m_condition because it is a AutomaticThreadCondition,
and all the ways it is used is as a condvar.  The m_trapSet name doesn't seem
appropriate nor meaningful.

* runtime/VMTraps.cpp:
(JSC::VMTraps::tryInstallTrapBreakpoints):
- Added a !needTrapHandling() check as an optimization: there's no need to install
  VMTrap breakpoints if someone already beat us to handling the trap (remember,
  the main thread is racing against the VMTraps signalling thread to handle the
  trap too).  We only need to install the VMTraps breakpoints if we need DFG/FTL
  compiled code to deopt so that they can check and handle pending traps.  If the
  trap has already been handled, it's better to not deopt any DFG/FTL functions.

(JSC::VMTraps::willDestroyVM):
(JSC::VMTraps::fireTrap):
(JSC::VMTraps::VMTraps):
* runtime/VMTraps.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/VMTraps.cpp
trunk/Source/_javascript_Core/runtime/VMTraps.h


Added Paths

trunk/JSTests/stress/regress-191856.js




Diff

Modified: trunk/JSTests/ChangeLog (238420 => 238421)

--- trunk/JSTests/ChangeLog	2018-11-21 17:36:32 UTC (rev 238420)
+++ trunk/JSTests/ChangeLog	2018-11-21 17:37:54 UTC (rev 238421)
@@ -1,3 +1,14 @@
+2018-11-20  Mark Lam  
+
+Remove invalid assertion in VMTraps::SignalSender's SignalAction.
+https://bugs.webkit.org/show_bug.cgi?id=191856
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/regress-191856.js: Added.
+- this test is skipped for now until we have a fix for webkit.org/b/191855.
+
 2018-11-21  Dominik Infuehr  
 
 Enable JIT on ARM/Linux


Added: trunk/JSTests/stress/regress-191856.js (0 => 238421)

--- trunk/JSTests/stress/regress-191856.js	(rev 0)
+++ trunk/JSTests/stress/regress-191856.js	2018-11-21 17:37:54 UTC (rev 238421)
@@ -0,0 +1,8 @@
+//@ skip
+//@ requireOptions("--watchdog=100")
+
+// FIMXE: skipping this test for now because it takes too long to run until we have a fix
+// for https://bugs.webkit.org/show_bug.cgi?id=191855.
+
+for (let i=0; i<1000; i++)
+import(0);


Modified: trunk/Source/_javascript_Core/ChangeLog (238420 => 238421)

--- trunk/Source/_javascript_Core/ChangeLog	2018-11-21 17:36:32 UTC (rev 238420)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-21 17:37:54 UTC (rev 238421)
@@ -1,3 +1,36 @@
+2018-11-20  Mark Lam  
+
+Remove invalid assertion in VMTraps::SignalSender's SignalAction.
+https://bugs.webkit.org/show_bug.cgi?id=191856
+
+
+Reviewed by Yusuke Suzuki.
+
+The ASSERT(vm.traps().needTrapHandling()) assertion in SignalSender's SigAction
+function is invalid because we can't be sure that the trap has been handled yet
+by the time the trap fires.  This is because the main thread may also check traps
+(in LLInt, baseline JIT and VM runtime code).  There's a race to handle the trap.
+Hence, the SigAction cannot assume that the trap still needs handling by the time
+it is executed.  This patch removed the invalid assertion.
+
+Also renamed m_trapSet to m_condition because it is a AutomaticThreadCondition,
+and all the ways it is used is as a condvar.  The m_trapSet name doesn't seem
+appropriate nor meaningful.
+
+* runtime/VMTraps.cpp:
+(JSC::VMTraps::tryInstallTrapBreakpoints):
+- Added a !needTrapHandling() check as an optimization: there's no need to install
+  VMTrap breakpoints if someone already beat us to handling the trap (remember,
+  the main thread is racing against the VMTraps signalling thread to handle the
+  trap too).  We only need to install the VMTraps breakpoints if we need DFG/FTL
+  compiled code to deopt so that they can check and handle pending traps.  If the
+  trap has already been handled, it's better to not deopt any DFG/FTL functions.
+
+(JSC::VMTraps::willDestroyVM):
+(JSC::VMTraps::fireTrap):
+(JSC::VMTraps::VMTraps):
+  

[webkit-changes] [238420] trunk/Source/WebCore

[zalan]

Title: [238420] trunk/Source/WebCore








Revision 238420
Author za...@apple.com
Date 2018-11-21 09:36:32 -0800 (Wed, 21 Nov 2018)


Log Message
[LFC][IFC] Use contains and containsAll in InlineFormattingContext::splitInlineRunIfNeeded consistently
https://bugs.webkit.org/show_bug.cgi?id=191890

Rearrange the comment numbers to match the logic below.

Reviewed by Antti Koivisto.

* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238419 => 238420)

--- trunk/Source/WebCore/ChangeLog	2018-11-21 17:24:47 UTC (rev 238419)
+++ trunk/Source/WebCore/ChangeLog	2018-11-21 17:36:32 UTC (rev 238420)
@@ -1,3 +1,15 @@
+2018-11-21  Zalan Bujtas  
+
+[LFC][IFC] Use contains and containsAll in InlineFormattingContext::splitInlineRunIfNeeded consistently
+https://bugs.webkit.org/show_bug.cgi?id=191890
+
+Rearrange the comment numbers to match the logic below.
+
+Reviewed by Antti Koivisto.
+
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):
+
 2018-11-20  Dean Jackson  
 
 Move WebGPU platform code to platform/graphics/gpu


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp (238419 => 238420)

--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp	2018-11-21 17:24:47 UTC (rev 238419)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp	2018-11-21 17:36:32 UTC (rev 238420)
@@ -179,13 +179,13 @@
 return std::min(remaningLength, inlineItem.textContent().length() - startPosition);
 };
 
-// 1. Inline element does not require run breaking -> add current inline element to uncommitted. Jump to the next element.
+// 1. Break before/after -> requires dedicated run -> commit what we've got so far and also commit the current inline element as a separate inline run.
 // 2. Break at the beginning of the inline element -> commit what we've got so far. Current element becomes the first uncommitted.
 // 3. Break at the end of the inline element -> commit what we've got so far including the current element.
-// 4. Break before/after -> requires dedicated run -> commit what we've got so far and also commit the current inline element as a separate inline run.
+// 4. Inline element does not require run breaking -> add current inline element to uncommitted. Jump to the next element.
 auto detachingRules = inlineItem.detachingRules();
 
-// #4
+// #1
 if (detachingRules.containsAll({ InlineItem::DetachingRule::BreakAtStart, InlineItem::DetachingRule::BreakAtEnd })) {
 commit();
 uncommitted = Uncommitted { , , currentLength() };
@@ -194,10 +194,11 @@
 }
 
 // #2
-if (detachingRules == InlineItem::DetachingRule::BreakAtStart)
+if (detachingRules.contains(InlineItem::DetachingRule::BreakAtStart))
 commit();
 
 // Add current inline item to uncommitted.
+// #3 and #4
 if (!uncommitted)
 uncommitted = Uncommitted { , , 0 };
 uncommitted->length += currentLength();
@@ -204,7 +205,7 @@
 uncommitted->lastInlineItem = 
 
 // #3
-if (detachingRules == InlineItem::DetachingRule::BreakAtEnd)
+if (detachingRules.contains(InlineItem::DetachingRule::BreakAtEnd))
 commit();
 }
 // Either all inline elements needed dedicated runs or neither of them.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238418] releases/WebKitGTK/webkit-2.22/Source/WebCore

[mcatanzaro]

Title: [238418] releases/WebKitGTK/webkit-2.22/Source/WebCore








Revision 238418
Author mcatanz...@igalia.com
Date 2018-11-21 08:52:32 -0800 (Wed, 21 Nov 2018)


Log Message
[FreeType] Problem under WebCore::FontPlatformData::FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=191595

Unofficially reviewed stable branch commit.

Blacklist cairo 1.15 and 1.16.0 when setting FreeType memory allocation functions. These
broken versions of cairo free memory allocated by FreeType with system free. We can avoid
trouble by using the system allocator instead of bmalloc.

* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::initializeFreeTypeLibrary):

Modified Paths

releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (238417 => 238418)

--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog	2018-11-21 16:37:29 UTC (rev 238417)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog	2018-11-21 16:52:32 UTC (rev 238418)
@@ -1,3 +1,17 @@
+2018-11-21  Michael Catanzaro  
+
+[FreeType] Problem under WebCore::FontPlatformData::FontPlatformData
+https://bugs.webkit.org/show_bug.cgi?id=191595
+
+Unofficially reviewed stable branch commit.
+
+Blacklist cairo 1.15 and 1.16.0 when setting FreeType memory allocation functions. These
+broken versions of cairo free memory allocated by FreeType with system free. We can avoid
+trouble by using the system allocator instead of bmalloc.
+
+* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
+(WebCore::initializeFreeTypeLibrary):
+
 2018-11-20  Zan Dobersek  
 
 Segfaults on https://terminalizer.com/


Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp (238417 => 238418)

--- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp	2018-11-21 16:37:29 UTC (rev 238417)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp	2018-11-21 16:52:32 UTC (rev 238418)
@@ -66,6 +66,13 @@
 // https://www.freetype.org/freetype2/docs/design/design-4.html
 // https://lists.nongnu.org/archive/html/freetype-devel/2004-10/msg00022.html
 
+// Workaround crash in cairo 1.16.0. See https://webkit.org/b/191595.
+int version = cairo_version();
+if (version >= CAIRO_VERSION_ENCODE(1, 15, 0) && version < CAIRO_VERSION_ENCODE(1, 16, 1)) {
+FT_Init_FreeType();
+return true;
+}
+
 FT_Memory memory = bitwise_cast(ft_smalloc(sizeof(*memory)));
 if (!memory)
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238417] trunk/Source/WebCore

[aperez]

Title: [238417] trunk/Source/WebCore








Revision 238417
Author ape...@igalia.com
Date 2018-11-21 08:37:29 -0800 (Wed, 21 Nov 2018)


Log Message
[SOUP] Certificate decoder always returns GByteArray with zero size
https://bugs.webkit.org/show_bug.cgi?id=191888

Reviewed by Žan Doberšek.

No new tests needed.

* platform/network/soup/CertificateInfo.h:
(WTF::Persistence::Coder>::decode): Add missing
call to g_byte_array_set_size() to make sure byteArray->len has the
correct value.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/CertificateInfo.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (238416 => 238417)

--- trunk/Source/WebCore/ChangeLog	2018-11-21 15:53:24 UTC (rev 238416)
+++ trunk/Source/WebCore/ChangeLog	2018-11-21 16:37:29 UTC (rev 238417)
@@ -1,3 +1,17 @@
+2018-11-21  Adrian Perez de Castro  
+
+[SOUP] Certificate decoder always returns GByteArray with zero size
+https://bugs.webkit.org/show_bug.cgi?id=191888
+
+Reviewed by Žan Doberšek.
+
+No new tests needed.
+
+* platform/network/soup/CertificateInfo.h:
+(WTF::Persistence::Coder>::decode): Add missing
+call to g_byte_array_set_size() to make sure byteArray->len has the
+correct value.
+
 2018-11-21  Zalan Butjas  
 
 [LFC][IFC] Take nonBreakableStart/End into use.


Modified: trunk/Source/WebCore/platform/network/soup/CertificateInfo.h (238416 => 238417)

--- trunk/Source/WebCore/platform/network/soup/CertificateInfo.h	2018-11-21 15:53:24 UTC (rev 238416)
+++ trunk/Source/WebCore/platform/network/soup/CertificateInfo.h	2018-11-21 16:37:29 UTC (rev 238417)
@@ -83,7 +83,8 @@
 return false;
 
 byteArray = adoptGRef(g_byte_array_sized_new(size));
-return decoder.decodeFixedLengthData(byteArray->data, byteArray->len);
+g_byte_array_set_size(byteArray.get(), size);
+return decoder.decodeFixedLengthData(byteArray->data, size);
 }
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238416] trunk/LayoutTests

[aboya]

Title: [238416] trunk/LayoutTests








Revision 238416
Author ab...@igalia.com
Date 2018-11-21 07:53:24 -0800 (Wed, 21 Nov 2018)


Log Message
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=191887


* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (238415 => 238416)

--- trunk/LayoutTests/ChangeLog	2018-11-21 15:41:45 UTC (rev 238415)
+++ trunk/LayoutTests/ChangeLog	2018-11-21 15:53:24 UTC (rev 238416)
@@ -1,3 +1,10 @@
+2018-11-21  Alicia Boya García  
+
+[GTK] Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=191887
+
+* platform/gtk/TestExpectations:
+
 2018-11-21  Zalan Bujtas  
 
 [LFC][IFC] Take nonBreakableStart/End into use.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (238415 => 238416)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-11-21 15:41:45 UTC (rev 238415)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-11-21 15:53:24 UTC (rev 238416)
@@ -773,7 +773,7 @@
 webkit.org/b/128172 fast/events/touch/multi-touch-grouped-targets.html [ Timeout Failure ]
 webkit.org/b/128172 fast/events/touch/multi-touch-inside-nested-iframes.html [ Crash Timeout ]
 webkit.org/b/128172 fast/events/touch/multi-touch-inside-iframes.html [ Timeout ]
-webkit.org/b/128172 fast/events/touch/basic-single-touch-events.html [ Crash Timeout ]
+webkit.org/b/128172 fast/events/touch/basic-single-touch-events.html [ Crash Failure ]
 webkit.org/b/128172 fast/events/touch/page-scaled-touch-gesture-click.html [ Timeout ]
 webkit.org/b/128172 fast/events/touch/touch-target.html [ Crash Timeout ]
 webkit.org/b/128172 fast/events/touch/touch-target-limited.html [ Crash Timeout ]
@@ -1293,6 +1293,8 @@
 
 webkit.org/b/190578 media/encrypted-media/mock-MediaKeySystemAccess.html [ Crash ]
 webkit.org/b/190738 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license.https.html [ Crash Pass ]
+webkit.org/b/191882 fast/forms/validation-message-clone.html [ Failure Crash ]
+webkit.org/b/191882 fast/forms/validation-message-in-relative-body.html [ Failure Crash ]
 
 #
 # End of Crashing tests
@@ -3612,6 +3614,21 @@
 webkit.org/b/191688 compositing/overflow/clip-descendents.html [ Failure ]
 webkit.org/b/191688 compositing/repaint/absolute-painted-into-composited-ancestor.html [ Failure ]
 
+webkit.org/b/191882 fast/forms/validation-message-on-range.html [ Failure ]
+webkit.org/b/191882 fast/forms/validation-message-on-textarea.html [ Failure ]
+webkit.org/b/191882 fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html [ Failure ]
+
+webkit.org/b/191883 fast/events/touch/emulate-touch-events.html [ Failure ]
+
+webkit.org/b/191884 fast/images/icon-decoding.html [ Failure ]
+
+webkit.org/b/191885 fast/inline/simple-inline-inflow-positioned.html [ Failure ]
+webkit.org/b/191885 fast/inline/simple-inline-with-out-of-flow-descendant.html [ Failure ]
+webkit.org/b/191885 fast/inline/simple-inline-with-out-of-flow-descendant2.html [ Failure ]
+webkit.org/b/191885 fast/inline/simple-intruding-floats3.html [ Failure ]
+
+webkit.org/b/191886 fast/mediastream/MediaStream-video-element-remove-track.html [ Failure ]
+
 #
 # End of non-crashing, non-flaky tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238415] trunk

[zalan]

Title: [238415] trunk








Revision 238415
Author za...@apple.com
Date 2018-11-21 07:41:45 -0800 (Wed, 21 Nov 2018)


Log Message
[LFC][IFC] Take nonBreakableStart/End into use.
https://bugs.webkit.org/show_bug.cgi?id=191873

Reviewed by Antti Koivisto.

Source/WebCore:

Offset the final inline runs with the nonBreakableStart/End values.
(This patch also fixes relative positioned run verification.)

Test: fast/inline/inline-content-with-padding-left-right.html

* layout/Verification.cpp:
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::splitInlineRunIfNeeded const):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/inline/inline-content-with-padding-left-right-expected.txt: Added.
* fast/inline/inline-content-with-padding-left-right.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/Verification.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LFC-passing-tests.txt


Added Paths

trunk/LayoutTests/fast/inline/inline-content-with-padding-left-right-expected.txt
trunk/LayoutTests/fast/inline/inline-content-with-padding-left-right.html




Diff

Modified: trunk/LayoutTests/ChangeLog (238414 => 238415)

--- trunk/LayoutTests/ChangeLog	2018-11-21 11:03:29 UTC (rev 238414)
+++ trunk/LayoutTests/ChangeLog	2018-11-21 15:41:45 UTC (rev 238415)
@@ -1,3 +1,13 @@
+2018-11-21  Zalan Bujtas  
+
+[LFC][IFC] Take nonBreakableStart/End into use.
+https://bugs.webkit.org/show_bug.cgi?id=191873
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/inline-content-with-padding-left-right-expected.txt: Added.
+* fast/inline/inline-content-with-padding-left-right.html: Added.
+
 2018-11-20  Ryosuke Niwa  
 
 Input element gains focus when a selectstart event listener on document prevents the default action


Added: trunk/LayoutTests/fast/inline/inline-content-with-padding-left-right-expected.txt (0 => 238415)

--- trunk/LayoutTests/fast/inline/inline-content-with-padding-left-right-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/inline/inline-content-with-padding-left-right-expected.txt	2018-11-21 15:41:45 UTC (rev 238415)
@@ -0,0 +1,225 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+layer at (8,8) size 402x22 clip at (9,9) size 400x20 scrollHeight 24
+  RenderBlock {DIV} at (0,0) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 26x34
+  RenderText {#text} at (17,1) size 6x14
+text run at (17,1) width 6: "2"
+RenderText {#text} at (33,1) size 6x14
+  text run at (33,1) width 6: "3"
+layer at (8,30) size 402x22 clip at (9,31) size 400x20
+  RenderBlock {DIV} at (0,22) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 16x14
+  RenderText {#text} at (17,1) size 6x14
+text run at (17,1) width 6: "2"
+RenderText {#text} at (23,1) size 6x14
+  text run at (23,1) width 6: "3"
+layer at (8,52) size 402x22 clip at (9,53) size 400x20
+  RenderBlock {DIV} at (0,44) size 402x22 [border: (1px solid #008000)]
+RenderText {#text} at (1,1) size 6x14
+  text run at (1,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 16x14
+  RenderText {#text} at (7,1) size 6x14
+text run at (7,1) width 6: "2"
+RenderText {#text} at (23,1) size 6x14
+  text run at (23,1) width 6: "3"
+layer at (8,74) size 402x22 clip at (9,75) size 400x20 scrollHeight 24
+  RenderBlock {DIV} at (0,66) size 402x22 [border: (1px solid #008000)]
+RenderInline {SPAN} at (0,0) size 16x14
+  RenderText {#text} at (11,1) size 6x14
+text run at (11,1) width 6: "1"
+RenderInline {SPAN} at (0,0) size 26x34
+  RenderText {#text} at (27,1) size 6x14
+text run at (27,1) width 6: "2"
+RenderInline {SPAN} at (0,0) size 16x14
+  RenderText {#text} at (43,1) size 6x14
+text run at (43,1) width 6: "3"
+layer at (8,96) size 402x22 clip at (9,97) size 400x20 scrollHeight 24
+  RenderBlock {DIV} at (0,88) size 402x22 [border: (1px solid #008000)]
+RenderInline {SPAN} at (0,0) size 46x14
+  RenderInline {SPAN} at (0,0) size 36x14
+RenderInline {SPAN} at (0,0) size 26x34
+  RenderText {#text} at (21,1) size 6x14
+text run at (21,1) width 6: "1"
+layer at (8,118) size 402x22 clip at (9,119) size 400x20 scrollHeight 24
+  RenderBlock {DIV} at (0,110) size 402x22 [border: (1px solid #008000)]
+RenderInline {SPAN} at (0,0) 

[webkit-changes] [238413] trunk/Source/WebCore

[carlosgc]

Title: [238413] trunk/Source/WebCore








Revision 238413
Author carlo...@webkit.org
Date 2018-11-21 01:11:23 -0800 (Wed, 21 Nov 2018)


Log Message
REGRESSION(r237845): [cairo] Hyperlink underscore layout issue
https://bugs.webkit.org/show_bug.cgi?id=191630

Reviewed by Michael Catanzaro.

Only flip Y in GlyphToPathTranslator for ports using CG.

* platform/graphics/FontCascade.cpp:
(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238412 => 238413)

--- trunk/Source/WebCore/ChangeLog	2018-11-21 08:49:39 UTC (rev 238412)
+++ trunk/Source/WebCore/ChangeLog	2018-11-21 09:11:23 UTC (rev 238413)
@@ -1,3 +1,15 @@
+2018-11-21  Carlos Garcia Campos  
+
+REGRESSION(r237845): [cairo] Hyperlink underscore layout issue
+https://bugs.webkit.org/show_bug.cgi?id=191630
+
+Reviewed by Michael Catanzaro.
+
+Only flip Y in GlyphToPathTranslator for ports using CG.
+
+* platform/graphics/FontCascade.cpp:
+(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):
+
 2018-11-21  Alicia Boya García  
 
 [MSE][GStreamer] Refactor AppendPipeline deinitialization


Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (238412 => 238413)

--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2018-11-21 08:49:39 UTC (rev 238412)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2018-11-21 09:11:23 UTC (rev 238413)
@@ -1739,8 +1739,11 @@
 , m_textRun(textRun)
 , m_glyphBuffer(glyphBuffer)
 , m_fontData(glyphBuffer.fontAt(m_index))
-, m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()).scale(1, -1))
+, m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()))
 {
+#if USE(CG)
+m_translation.flipY();
+#endif
 }
 
 bool containsMorePaths() { return m_index != m_glyphBuffer.size(); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [238412] trunk/Source/WebCore

[aboya]

Title: [238412] trunk/Source/WebCore








Revision 238412
Author ab...@igalia.com
Date 2018-11-21 00:49:39 -0800 (Wed, 21 Nov 2018)


Log Message
[MSE][GStreamer] Refactor AppendPipeline deinitialization
https://bugs.webkit.org/show_bug.cgi?id=191759

Reviewed by Xabier Rodriguez-Calvar.

AppendPipeline currently has a method, clearPlayerPrivate(), that the
client code uses to deinitialize most of the AppendPipeline... just
before actually destructing it in the next line of code.

Since at that point there should not be alive RefPtr's pointing to the
AppendPipeline there is no need for this kind of pre-deinitialization
in this usage pattern. Instead, we can just rely on C++ destructors,
cleaning the code a bit and removing the potential for the question
"what if `clearPlayerPrivate() has been called before?`": it has not.

Assertions have been added to ensure that there is only one alive
RefPtr pointing to AppendPipeline, therefore guaranteeing its immediate
destruction.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::deinitialize):
(WebCore::AppendPipeline::clearPlayerPrivate): Deleted.
* platform/graphics/gstreamer/mse/AppendPipeline.h:
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::~MediaPlayerPrivateGStreamerMSE):
* platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
(WebCore::MediaSourceClientGStreamerMSE::removedFromMediaSource):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h
trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (238411 => 238412)

--- trunk/Source/WebCore/ChangeLog	2018-11-21 05:15:31 UTC (rev 238411)
+++ trunk/Source/WebCore/ChangeLog	2018-11-21 08:49:39 UTC (rev 238412)
@@ -1,3 +1,34 @@
+2018-11-21  Alicia Boya García  
+
+[MSE][GStreamer] Refactor AppendPipeline deinitialization
+https://bugs.webkit.org/show_bug.cgi?id=191759
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+AppendPipeline currently has a method, clearPlayerPrivate(), that the
+client code uses to deinitialize most of the AppendPipeline... just
+before actually destructing it in the next line of code.
+
+Since at that point there should not be alive RefPtr's pointing to the
+AppendPipeline there is no need for this kind of pre-deinitialization
+in this usage pattern. Instead, we can just rely on C++ destructors,
+cleaning the code a bit and removing the potential for the question
+"what if `clearPlayerPrivate() has been called before?`": it has not.
+
+Assertions have been added to ensure that there is only one alive
+RefPtr pointing to AppendPipeline, therefore guaranteeing its immediate
+destruction.
+
+* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+(WebCore::AppendPipeline::~AppendPipeline):
+(WebCore::AppendPipeline::deinitialize):
+(WebCore::AppendPipeline::clearPlayerPrivate): Deleted.
+* platform/graphics/gstreamer/mse/AppendPipeline.h:
+* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
+(WebCore::MediaPlayerPrivateGStreamerMSE::~MediaPlayerPrivateGStreamerMSE):
+* platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
+(WebCore::MediaSourceClientGStreamerMSE::removedFromMediaSource):
+
 2018-11-20  Dean Jackson  
 
 Removing using namespace WebCore from WebLayer


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (238411 => 238412)

--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp	2018-11-21 05:15:31 UTC (rev 238411)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp	2018-11-21 08:49:39 UTC (rev 238412)
@@ -225,6 +225,7 @@
 
 AppendPipeline::~AppendPipeline()
 {
+GST_TRACE("Destructing AppendPipeline (%p)", this);
 ASSERT(isMainThread());
 
 setAppendState(AppendState::Invalid);
@@ -231,23 +232,18 @@
 // Forget all pending tasks and unblock the streaming thread if it was blocked.
 m_taskQueue.startAborting();
 
-GST_TRACE("Destroying AppendPipeline (%p)", this);
+// Disconnect all synchronous event handlers and probes susceptible of firing from the main thread
+// when changing the pipeline state.
 
-// FIXME: Maybe notify appendComplete here?
-
 if (m_pipeline) {
 ASSERT(m_bus);
 g_signal_handlers_disconnect_by_data(m_bus.get(), this);
 gst_bus_disable_sync_message_emission(m_bus.get());
 gst_bus_remove_signal_watch(m_bus.get());
-